[Webkit-unassigned] [Bug 119959] Add TextNodeTraversal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119959


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209005|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2013-08-17 13:51:05 PST ---
(From update of attachment 209005)
View in context: https://bugs.webkit.org/attachment.cgi?id=209005&action=review

r=me

> Source/WebCore/dom/Text.cpp:139
> +        resultLength += text->data().length();

text->length() here would avoid some String ref churn.

> Source/WebCore/dom/TextNodeTraversal.h:68
> +    // Except for the root containers, only elements can have element children.

Copypasta detected.

> Source/WebCore/dom/TextNodeTraversal.h:80
> +    // Except for the root containers, only elements can have element children.

Copypasta detected.

> Source/WebCore/editing/ApplyStyleCommand.cpp:1525
>      Vector<RefPtr<Text> > textNodes;

Might as well >> this one too. It's so close!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.