[Webkit-unassigned] [Bug 119953] New: Tries to fetch plugins information once and again when plugin process fails

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 17 10:10:06 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119953

           Summary: Tries to fetch plugins information once and again when
                    plugin process fails
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
               URL: https://bugzilla.gnome.org/show_bug.cgi?id=706210
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: csaavedra at igalia.com
                CC: mrobinson at webkit.org, cgarcia at igalia.com


This is problematic when GetPlugins fails somehow:

void WebPlatformStrategies::populatePluginCache()
{
    if (m_pluginCacheIsPopulated)
        return;

    ASSERT(m_cachedPlugins.isEmpty());

    // FIXME: Should we do something in case of error here?
    if
(!WebProcess::shared().parentProcessConnection()->sendSync(Messages::WebProcessProxy::GetPlugins(m_shouldRefreshPlugins),
Messages::WebProcessProxy::GetPlugins::Reply(m_cachedPlugins,
m_cachedApplicationPlugins), 0))
        return;

    m_shouldRefreshPlugins = false;
    m_pluginCacheIsPopulated = true;
}

If this fails we shouldn't be checking once an again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list