[Webkit-unassigned] [Bug 119908] New: [CSS Masking] Build without CSS features broken after r154174

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119908

           Summary: [CSS Masking] Build without CSS features broken after
                    r154174
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zarvai at inf.u-szeged.hu
                CC: allan.jensen at digia.com, krit at webkit.org,
                    ossy at webkit.org, kadam at inf.u-szeged.hu,
                    parvu at adobe.com
            Blocks: 119614


It seems some guards are missing after adding and parsing of the mask-type property.

Build on Qt Linux Release minimal bot is broken. All CSS features are disabled on this one:

CSS Device Adaptation ......... no
CSS Exclusions ................ no
CSS Shapes .................... no
CSS Filters ................... no
CSS3 Conditional Rules support (i.e. @supports)  no
CSS3 Text ..................... no
CSS3 Text Line Break .......... no
CSS box-decoration-break ...... no
CSS image-orientation ......... no
CSS image-resolution .......... no
CSS image-set ................. no
CSS Regions ................... no
CSS Shaders ................... no
CSS sticky position ........... no
CSS Compositing ............... no
Support for unprefixed CSS animations and transforms  no
CSS Variable .................. no

Details from the build log:

http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/80916

/ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/CSSComputedStyleDeclaration.cpp: In function 'WTF::PassRefPtr<WebCore::CSSValue> WebCore::fillSourceTypeToCSSValue(WebCore::EMaskSourceType)':
/ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1431:43: error: 'CSSValueAlpha' was not declared in this scope
/ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1433:43: error: 'CSSValueLuminance' was not declared in this scope

And some more detail, after local build:

/home/azbest/webkit/WebKit/Source/WebCore/css/CSSParser.cpp:4433:63: error: 'CSSValueAlpha' was not declared in this scope
/home/azbest/webkit/WebKit/Source/WebCore/css/CSSParser.cpp:4433:91: error: 'CSSValueLuminance' was not declared in this scope

/home/azbest/webkit/WebKit/Source/WebCore/css/CSSToStyleMap.cpp:315:10: error: 'CSSValueAlpha' was not declared in this scope
/home/azbest/webkit/WebKit/Source/WebCore/css/CSSToStyleMap.cpp:318:10: error: 'CSSValueLuminance' was not declared in this scope

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.