[Webkit-unassigned] [Bug 99036] [GTK] Enable Pointer Lock feature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99036


Simon Pena <simon.pena at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.pena at samsung.com




--- Comment #13 from Simon Pena <simon.pena at samsung.com>  2013-08-16 06:03:08 PST ---
I applied your patch locally and then checked http://threejs.org/examples/misc_controls_pointerlock.html, and it works! :)

(I run it with Tools/Scripts/run-launcher --gtk --release -2 --enable-webgl=TRUE http://threejs.org/examples/misc_controls_pointerlock.html)

However, I noticed a couple of issues:

 * First, the lock wasn't released when I pressed Esc, so I had to close minibrowser to stop.
 * Then, you probably need to do some adjustments on how you calculate the way it turns. In Chromium, you're able to turn 360º, while in Minibrowser the range was something closer to maybe 120º. That also happens when looking up & down.

Regarding the patch itself, I didn't check much, but I think you missed some memory cleanup in the webkitWebViewBaseUnlockMouse and webkitWebViewBaseLockMouse methods.

Pretty nice! I already look forward to trying http://media.tojicode.com/q3bsp/!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.