[Webkit-unassigned] [Bug 119614] [CSS Masking] Add -webkit-mask-source-type property, with alpha and luminance values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119614





--- Comment #14 from Andrei Parvu <parvu at adobe.com>  2013-08-16 01:03:40 PST ---
(In reply to comment #13)
> (From update of attachment 208806 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208806&action=review
> 
> Patch looks great. Just a question.
> 
> > Source/WebCore/css/CSSToStyleMap.cpp:322
> > +    case CSSValueAuto:
> > +        break;
> 
> Why don't you set type = EMaskSourceType::MaskAlpha; here? after all, the user explicitly specified auto?

Type is already initialized to the default value, which is MaskAlpha, and since auto sets the default value for FillLayer, there's no need to assign it again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.