[Webkit-unassigned] [Bug 119843] New: PropertySlot::setValue is ambiguous

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119843

           Summary: PropertySlot::setValue is ambiguous
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: barraclough at apple.com


There are three different versions of PropertySlot::setValue, one for cacheable properties, and two that are used interchangeably and inconsistently.
The problematic variants are the ones that just take a value, and one that takes a value and also the object containing the property.
Unify on always providing the object, and remove the version that just takes a value.
This always works except for JSString, where we optimize out the object (logically we should be instantiating a temporary StringObject on every property access).  Provide a version of setValue that takes a JSString as the owner of the property.  We won't store this, but it makes it clear that this interface should only be used from JSString.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.