[Webkit-unassigned] [Bug 98350] [GTK] accessibility/aria-invalid.html times out

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98350





--- Comment #2 from Mario Sanchez Prada <mario at webkit.org>  2013-08-15 07:06:05 PST ---
(From update of attachment 208804)
View in context: https://bugs.webkit.org/attachment.cgi?id=208804&action=review

> LayoutTests/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * platform/gtk/TestExpectations:

You need a small description here

> Source/WebCore/ChangeLog:13
> +        * accessibility/atk/AXObjectCacheAtk.cpp:
> +        (WebCore::AXObjectCache::postPlatformNotification):
> +        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
> +        (webkitAccessibleGetAttributes):

I know not everyone does it (even though it's in the guidelines), but I normally like to have shorts descriptions for every function touched in the ChangeLog.

> Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:169
> +    } else if (notification == AXInvalidStatusChanged) {
> +        g_signal_emit_by_name(axObject, "state-change", "invalid-entry", coreObject->invalidStatus() != "false");
>      }

You do not need { } if it's a one line branch

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:898
> +
> +    // In case of 'aria-invalid' when the attribute empty or has "false" for ATK
> +    // according to http://www.w3.org/WAI/PF/aria-implementation/#mapping attribute
> +    // is not mapped but layout tests will expect 'false'.
> +    if (attributeValue.isEmpty() && atkAttributeName == "aria-invalid")
> +        return JSStringCreateWithUTF8CString("false");
> +

You probably need to add this aria-invalid specific mapping to WKTR too

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.