[Webkit-unassigned] [Bug 119654] [Qt] Avoid calling QWebPage's virtual functions during deletion of QWebPage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 12 11:00:04 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119654





--- Comment #8 from Arunprasad Rajkumar <arurajku at cisco.com>  2013-08-12 10:59:39 PST ---
Some review comments given by Allen(via IRC)

 - Implement the unload() method QWebFrame instead of QWebPage
 - Use detachFromParent()/cancelAndClear() of FrameLoader to send unload event instead of closeURL()
 - Finding appropriate place to call QWebFrame::unload implicitly without user intervention(may be side-effect of QWidget::close,..or similar)

Allan, Please correct me if I'm wrong :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list