[Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119515





--- Comment #7 from Przemyslaw Szymanski <p.szymanski3 at samsung.com>  2013-08-12 02:24:08 PST ---
(In reply to comment #5)
> (From update of attachment 208178 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208178&action=review
> 
> >> Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.h:62
> >> +        inline bool validateBinding() const { return !enabled || (enabled && isBound()); }
> > 
> > Second check should be enough here.
> 
> Do you need the second enabled? (if enabled is false, the second part of the condition does not get evaluated, while if enabled is true, then it doesnt bring much value to the second part of the condition)

Good point. Thank you. I updated this code. Review again please.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.