[Webkit-unassigned] [Bug 119625] [Performance]making HTMLSelectElement::usesMenuList() inline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119625





--- Comment #6 from Sam Weinig <sam at webkit.org>  2013-08-10 15:01:17 PST ---
(In reply to comment #5)
> (In reply to comment #3)
> > Does this actually speed anything up?
> 
> Isn't function usesMenuList() will take less machine code now .
> + inlining the function will reduce the machine cycle.
> 
> This function had useless overhead of theme checking every time.
> 
> it will definitely up this function performance logically. which is used many times(22) in HTMLSelectElement class. 
> I think any improvement(minor/major) in WebCore is really good, as  it is difficult  for big architectural changes to improve performance.
> 
> This is just way of improving performance by Thinking a bit low level as explained by Benjamin in his blog.

Have you measured an improvement (speed / binary size/ etc), or are you just guessing?  Is usesMenuList() a hot function?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.