[Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 9 07:32:12 PDT 2013


--- Comment #11 from Sergio Villar Senin <svillar at igalia.com>  2013-08-09 07:31:50 PST ---
(From update of attachment 208429)
View in context: https://bugs.webkit.org/attachment.cgi?id=208429&action=review

Not really my field of expertise, just doing an informal general review.

> Source/WebCore/rendering/RenderView.cpp:782
> +    bool cond = os && os != stop;

Do not use "cond", use a more descriptive name.

> Source/WebCore/rendering/RenderView.cpp:849
> +    cond = o && o != stop;


> Source/WebCore/rendering/RenderView.cpp:873
> +        }

The code looks exactly the same than the above, would it be possible to refactor it in some function?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list