[Webkit-unassigned] [Bug 115180] [GTK] Compile only WebKit2 by default

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 8 07:37:48 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=115180





--- Comment #11 from Zan Dobersek <zandobersek at gmail.com>  2013-08-08 07:37:27 PST ---
(In reply to comment #10)
> Putting that aside and focusing on the scope of this patch, I'd recommend disabling WebKit1 builds by default only in the Autotools build system. Developers and Buildbot builders should still rely on build-webkit's --no-webkit1 and --no-webkit2 flags to get the desired configuration. Similarly, I don't think the additional --webkit1 flag is needed.
> 
> In short - release builds (straight via configure) should disable WK1 by default, developer builds (through build-webkit) should still enable WK1 unless specifically disabled (via --no-webkit1), at most until support for WK1GTK+ and all of its related code is thrown out of the source tree.

Another approach:
Disable WebKit1 by default in Automake configuration, as it's done in the proposed patch now. For build-webkit, no new options would be required, but --no-webkit1 and --no-webkit2 options' support would be removed for the Autotools build system. This would mean that runnning `build-webkit --gtk` would fall back to only building WK2. One could still build WK1 by running `build-webkit --gtk --enable-webkit1` as the unrecognized arguments are added to the arguments list that's used when running autogen.sh.

The related code that does that is located here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitdirs.pm#L1980

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list