[Webkit-unassigned] [Bug 119448] [Gtk] Suppress irrelevant or known leaks for Valgrind

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119448





--- Comment #4 from Brian Holt <brian.holt at samsung.com>  2013-08-06 09:02:13 PST ---
(In reply to comment #2)
> (From update of attachment 208029 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208029&action=review
> 
> Thanks for the patch, Brian. Informal review here:
> 
> First of all, the patch looks good in general, although there are some problems such as the fact that the patch does not seem to be consistent with the fact that this bug depends on bug 118785 (you're adding some code here that is already proposed as part of the latest patch for that other bug, instead of proposing just the incremental diff compared to that one), or that there are some issues related to coding style that would need fixing before landing.

Thanks for the review.  In light of the comments especially about style I've made all comments for leaks start with Uppercase and end with a period. I've also chosen the offending function as the leak name with and optional "(Third party)" or "(Intentional)".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.