[Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 5 10:23:17 PDT 2013


--- Comment #64 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2013-08-05 10:22:58 PST ---
(From update of attachment 208132)
View in context: https://bugs.webkit.org/attachment.cgi?id=208132&action=review

Found a few more minor issues on the last comb pass.

> Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:259
> +    VisibilityState visibilityState();

const missing here

> Source/WebKit/qt/WidgetApi/qwebpage.h:82
> +    Q_PROPERTY(QWebPage::VisibilityState visibilityState READ visibilityState WRITE setVisibilityState)
>      Q_ENUMS(LinkDelegationPolicy NavigationType WebAction)

I think you need to add VisibilityState to the Q_ENUMS line here for the property to work. Also I'm not sure if the "QWebPage::" part is necessary.

> Source/WebKit/qt/WidgetApi/qwebpage.h:286
> +    VisibilityState visibilityState();

const missing here too.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list