[Webkit-unassigned] [Bug 119482] New: Waste work in CustomFilterValidatedProgram(), MediaController() and ArrayBuffer()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119482

           Summary: Waste work in CustomFilterValidatedProgram(),
                    MediaController() and ArrayBuffer()
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: pchang9 at cs.wisc.edu


The problem appears in revision 153701. I have attached simple one-line patches that fixes it.

In method ustomFilterValidatedProgram::rewriteMixVertexShader() in WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp, the loop on line 228 should break immediately after "texCoordAttributeDefined" is set to "true". All the iterations after "texCoordAttributeDefined" is set to "true" do not perform any useful work, at best they just set "texCoordAttributeDefined" again to "true".

Similarly, method MediaController::hasEnded() in WebCore/html/MediaController.cpp, the loop on line 528 should break immediately after "allHaveEnded" is set to "false". Method ArrayBuffer::transfer() in WTF/wtf/ArrayBuffer.cpp, the loop on line 46 should break immediately after "allViewsAreNeuterable" is set to "false".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.