[Webkit-unassigned] [Bug 117550] [CSS Shaders] Animations and transitions should use validated custom programs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117550





--- Comment #24 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-08-02 10:52:29 PST ---
(From update of attachment 205273)
View in context: https://bugs.webkit.org/attachment.cgi?id=205273&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:2120
> +        // Calling CustomFilterProgram::isLoaded with no clients will make it assert; add

If you need EmptyCustomFilterProgramClient just for this, why not fix the assert?

> Source/WebCore/rendering/RenderLayerBacking.cpp:2268
> +            FilterOperations validatedFromFilters;
> +            FilterOperations validatedToFilters;
> +            if (validateCustomFilters(owningLayer(), fromStyle, validatedFromFilters))
> +                filterVector.insert(FilterAnimationValue::create(0, validatedFromFilters));
> +            if (validateCustomFilters(owningLayer(), toStyle, validatedToFilters))
> +                filterVector.insert(FilterAnimationValue::create(1, validatedToFilters));

I don't think we should pay the cost of two FilterOperations on the stack when there are no custom filters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.