[Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117545





--- Comment #5 from Diego Pino <dpino at igalia.com>  2013-08-02 01:05:47 PST ---
(From update of attachment 205012)
View in context: https://bugs.webkit.org/attachment.cgi?id=205012&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:551
>> +        push(@txtGetProps, "        g_value_set_$gtype(value, ${convertFunction}${getterFunctionName}(" . join(", ", @getterArguments) . ")${postConvertFunction});\n");
> 
> I wonder why these lines are duplicated, I know it's not introduced by you, but I think this can be simplified. If we can get rid of the implemented by check this could just be 
> 
> } else { 
>     push(@txtGetProps, "        g_value_set_$gtype(value, ${convertFunction}${getterFunctionName}(" . join(", ", @getterArguments) . ")${postConvertFunction});\n");
> }

Correct. I agree with these suggestions. I will cook a new patch with this changes, and check the script generates the same code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.