From bugzilla-daemon at webkit.org Thu Aug 1 00:07:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:07:45 -0700 Subject: [Webkit-unassigned] [Bug 119347] Web Inspector: Copying JS object output from console could be better In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119347 --- Comment #2 from Antoine Quint 2013-08-01 00:07:30 PST --- We could look at the properties on the logged objects and see if it is all basic types and log it as expected here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:11:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:11:11 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:11:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:11:14 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #6 from Build Bot 2013-08-01 00:10:58 PST --- (From update of attachment 207899) Attachment 207899 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1292902 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:13:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:13:50 -0700 Subject: [Webkit-unassigned] [Bug 119380] New: [CSSRegions] Scrolling a fixed positioned region results in painting artifacts Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119380 Summary: [CSSRegions] Scrolling a fixed positioned region results in painting artifacts Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mihnea at adobe.com CC: WebkitBugTracker at adobe.com Blocks: 57312 With the following test case:
AAAAA
Test
If one scrolls up&&down the document, the content flowed in region is painted incorrectly. Adding background-color or border to the region fixes the problem. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:13:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:13:55 -0700 Subject: [Webkit-unassigned] [Bug 57312] [META][CSSRegions] Add regions support in WebKit In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=57312 Mihnea Ovidenie changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119380 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:13:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:13:58 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207729|0 |1 is obsolete| | Attachment #207729|review- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:14:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:14:07 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207900| |review? Flag| | --- Comment #8 from Mihai Tica 2013-08-01 00:13:52 PST --- Created an attachment (id=207900) --> (https://bugs.webkit.org/attachment.cgi?id=207900&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:15:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:15:13 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 --- Comment #9 from Mihai Tica 2013-08-01 00:14:58 PST --- I rewrote most of the test using the model initially used by Rik, and the one that was used for the alpha test. Can you please take another look? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:16:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:16:43 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #7 from Ruth Fong 2013-08-01 00:16:27 PST --- (From update of attachment 207899) View in context: https://bugs.webkit.org/attachment.cgi?id=207899&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:2944 > +#if ENABLE(INPUT_TYPE_COLOR_POPOVER) > + m_colorPicker = m_pageClient->createColorPicker(this, initialColor, elementRect); > +#else > if (!m_colorPicker) > m_colorPicker = m_pageClient->createColorPicker(this, initialColor, elementRect); > m_colorPicker->showColorPicker(initialColor); > +#endif Every time a new element is activated, the previous popover is destroyed and a new one constructed. This differs from the panel implementation; which "resets" the color picker instead of tearing it down and building a new one when it's associated to another color element. Should we standardize the implementation? (Probably yes, that where there's a more similar implementation for the color picker UIs in WebColorPickerMac.) Disadvantage of createIfNeeded-and-show: It'd be harder to follow the createIfNeeded then show model for popover because in WKColorPopoverMac, initForFrame needs to be called to set the popover over the right color element, but it can be done (more information would have to be passed to showColorPicker, such as elementRect and m_pageClient->wkView()). For destroy-and-create: For the panel implementation, it may be a poor UI experience (will try it out) having a picker disappear and then reappear. > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:103 > +#endif The deconstructor probably shouldn't have the ASSERT. Will file a new bug to fix this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:28:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:28:32 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207899|0 |1 is obsolete| | Attachment #207899|commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:28:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:28:37 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #8 from Ruth Fong 2013-08-01 00:28:20 PST --- Created an attachment (id=207901) --> (https://bugs.webkit.org/attachment.cgi?id=207901&action=review) Patch fixed feature defines bug -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:38:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:38:49 -0700 Subject: [Webkit-unassigned] [Bug 119379] Remove return statement in void function In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119379 Kwang Yul Seo changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |skyul at company100.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:46:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:46:53 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #9 from Benjamin Poulain 2013-08-01 00:46:37 PST --- (From update of attachment 207901) View in context: https://bugs.webkit.org/attachment.cgi?id=207901&action=review Some comments: > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:65 > + at interface WKColorPickerMac : NSObject { > + at protected > +BOOL _lastChangedByUser; > +WebColorPickerMac* _picker; > } > - > -- (id)init; > -- (void)setAndShowPicker:(WebKit::WebColorPickerMac*)picker withColor:(NSColor *)color; > -- (void)didChooseColor:(NSColorPanel *)panel; > +- (void)didChooseColor:(id)sender; > - (void)invalidate; > - > -// Sets color to the NSColorPanel as a non user change. > - (void)setColor:(NSColor *)color; > + at end > > + at implementation WKColorPickerMac > +- (void)didChooseColor:(id)sender { } > +- (void)invalidate { } > +- (void)setColor:(NSColor *)color { } > @end I think you should transform WKColorPickerMac to a protocol, and move the two attributes to the subclass. WKColorPickerMac does not have ownership of _lastChangedByUser which leads to improper encapsulation. You should try to avoid inheritance as a way to share code, using encapsulation/aggregation leads to better designs. > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:74 > + NSPopoverColorWell* popoverWell; You could use a RetainPtr here to avoid risking leaking this. > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:159 > + return self; Indent. > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:167 > + [popoverWell retain]; This is odd! > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:177 > +} > + I would also add a destructor just to be safe. You could call invalidate from it, or just assert that _picker and popoverWell are nil. > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:183 > + [popoverWell removeFromSuperviewWithoutNeedingDisplay]; > + [popoverWell deactivate]; > + [popoverWell release]; > + _picker = nil; I believe you also want to remove the target of the popowerWell. Otherwise, if an other reference to the object exist, you may still get called. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 00:51:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 00:51:24 -0700 Subject: [Webkit-unassigned] [Bug 99065] [GStreamer] Add support for Media Source API In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99065 --- Comment #22 from Stephane Jadaud 2013-08-01 00:51:08 PST --- (In reply to comment #21) > > Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:534 > > + KURL url(KURL(), uri); > > I wonder if this shouldn't be: > KURL url(KURL(), uri + 5); > because else the url.protocolIsInHTTPFamily() call will fail. At least on my setup it does. You are right, I forgot to remove the test with "url.protocolIsInHTTPFamily" when GST_API_VERSION_1 is undefined. > I have tested this on QT4.8 with qtwebkit 2.3.2 (I have patched up the media source api from webkit), gstreamer 0.10.36 and I was wondering about the following: > When testing with youtube.com/tv the load() function is called twice, with two different blob urls. Is this normal? I see the same thing, i don't have any explanations -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:05:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:05:49 -0700 Subject: [Webkit-unassigned] [Bug 119381] New: [WK2] Add USE(SOUP) guard in WebProcess::destroyPrivateBrowsingSession Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119381 Summary: [WK2] Add USE(SOUP) guard in WebProcess::destroyPrivateBrowsingSession Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit2 AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: skyul at company100.com The is a followup to r153355. I missed to add USE(SOUP) guard in WebProcess::destroyPrivateBrowsingSession. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:09:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:09:27 -0700 Subject: [Webkit-unassigned] [Bug 119381] [WK2] Add USE(SOUP) guard in WebProcess::destroyPrivateBrowsingSession In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119381 Kwang Yul Seo changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |skyul at company100.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:15:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:15:16 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207901| |commit-queue- Flag| | --- Comment #10 from Build Bot 2013-08-01 01:15:00 PST --- (From update of attachment 207901) Attachment 207901 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1307198 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:29:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:29:35 -0700 Subject: [Webkit-unassigned] [Bug 119382] New: Fix problem with find-resolved-bugs command Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 Summary: Fix problem with find-resolved-bugs command Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: seokju at webkit.org Error occurs if bugs have restricted accesses. So this patch allow it to avoid authentication during fetching bugs for find-resolved-bugs command. [Before] bugs.webkit.org login: test at webit.org bugs.webkit.org password for test at webit.org: Store password in system keyring? [y/N]: Logging in as test at webit.org... Traceback (most recent call last): File "./Tools/Scripts/webkit-patch", line 84, in main() File "./Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/home/neocrash/git/WebKit-Qt/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/home/neocrash/git/WebKit-Qt/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/home/neocrash/git/WebKit-Qt/Tools/Scripts/webkitpy/tool/commands/queries.py", line 604, in execute bug = bugzilla.fetch_bug(bugid) File "/home/neocrash/git/WebKit-Qt/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 455, in fetch_bug return Bug(self.fetch_bug_dictionary(bug_id), self) File "/home/neocrash/git/WebKit-Qt/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 449, in fetch_bug_dictionary self.authenticate() File "/home/neocrash/git/WebKit-Qt/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 526, in authenticate raise Exception(errorMessage) Exception: Bugzilla login failed: Invalid Username Or Password [After] $./Tools/Scripts/webkit-patch find-resolved-bugs LayoutTests/platform/gtk-wk2/TestExpectations Resolved bugs in LayoutTests/platform/gtk-wk2/TestExpectations : https://bugs.webkit.org/show_bug.cgi?id=63706 https://bugs.webkit.org/show_bug.cgi?id=85463 https://bugs.webkit.org/show_bug.cgi?id=81042 https://bugs.webkit.org/show_bug.cgi?id=97192 https://bugs.webkit.org/show_bug.cgi?id=94549 https://bugs.webkit.org/show_bug.cgi?id=42457 Not permitted bugs in LayoutTests/platform/gtk-wk2/TestExpectations : https://bugs.webkit.org/show_bug.cgi?id=89287 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:31:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:31:25 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Peng Xinchao changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xinchao.peng at samsung.com --- Comment #19 from Peng Xinchao 2013-08-01 01:31:09 PST --- I happened the same issue at GTK , ARM ,32bit And Disable DFG_JIT and FTL_JIT. Merge the patch , i happened other crash . backtrace ? 1 0x400d1608 libjavascriptcoregtk-3.0.so.0(_ZN3JSC9CodeBlock14bytecodeOffsetEPNS_9ExecStateENS_16ReturnAddressPtrE+0x28b) [0x400d1608] 2 0x401290e0 libjavascriptcoregtk-3.0.so.0(_ZN3JSC8jitThrowEPNS_2VMEPNS_9ExecStateENS_7JSValueENS_16ReturnAddressPtrE+0x1b) [0x401290e0] 3 0x40144d3c libjavascriptcoregtk-3.0.so.0(JITStubThunked_vm_throw+0x1f) [0x40144d3c] -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:34:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:34:57 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207905| |review? Flag| | --- Comment #1 from Seokju Kwon 2013-08-01 01:34:42 PST --- Created an attachment (id=207905) --> (https://bugs.webkit.org/attachment.cgi?id=207905&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:35:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:35:04 -0700 Subject: [Webkit-unassigned] [Bug 119383] New: Latest WebKit nightly builds crash while using facebook chat Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119383 Summary: Latest WebKit nightly builds crash while using facebook chat Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel URL: http://facebook.com OS/Version: Mac OS X 10.8 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: nastrock at gmail.com Steps to reproduce: 1) Log on to facebook 2) Click anyone in the friends list on the right - browser crashes immediately. I believe this is related to JS, but I'm not sure. I install updates periodically, and this crash started happening after 2013-07-29 update, still here on 6.0.5 (8536.30.1, 538+). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:35:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:35:13 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #20 from Julien Brianceau 2013-08-01 01:34:57 PST --- (In reply to comment #17) > That means that ctiVMThrowTrampolineSlowpath will need to be modified for those compilers to allocate the struct space on the stack and put the address in %ecx, put callFrame in %edx and then on return use the values in the stack instead of %eax:edx Exactly. To confirm this, I've replaced the implementation of ctiVMThrowTrampolineSlowpath in Source/JavaScriptCore/jit/JITStubsX86.h like this: asm ( ".globl " SYMBOL_STRING(ctiVMThrowTrampolineSlowpath) "\n" HIDE_SYMBOL(ctiVMThrowTrampolineSlowpath) "\n" SYMBOL_STRING(ctiVMThrowTrampolineSlowpath) ":" "\n" "movl %edi, %edx" "\n" "call " LOCAL_REFERENCE(cti_vm_throw_slowpath) "\n" // When cti_vm_throw_slowpath returns, eax has callFrame and edx has handler address "movl (%ecx), %eax" "\n" "movl 4(%ecx), %edx" "\n" "jmp *%edx" "\n" ); Results are ok: - run-fast-jsc reports "426 tests passed, 34 tests failed, 0 tests crashed." - run-javascriptcore-tests reports "0 regressions found. 0 tests fixed. OK." -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:36:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:36:04 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |dpranke at chromium.org, | |glenn at skynav.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:37:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:37:02 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #11 from Build Bot 2013-08-01 01:36:45 PST --- (From update of attachment 207901) Attachment 207901 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1259019 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:39:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:39:23 -0700 Subject: [Webkit-unassigned] [Bug 119384] New: Crash on Facebook Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119384 Summary: Crash on Facebook Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.8 Status: UNCONFIRMED Severity: Major Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: georgij.michaliutin at me.com Created an attachment (id=207906) --> (https://bugs.webkit.org/attachment.cgi?id=207906&action=review) Crash log When opening chat sidebar on Facebook and clicking on a friend, it will crash. Doesn't happen on Safari 6.0.5. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:44:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:44:21 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abrhm at inf.u-szeged.hu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 01:57:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 01:57:30 -0700 Subject: [Webkit-unassigned] [Bug 119385] New: [GTK] Enable ENABLE_8BIT_TEXTRUN Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119385 Summary: [GTK] Enable ENABLE_8BIT_TEXTRUN Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: skyul at company100.com Enable ENABLE_8BIT_TEXTRUN for Gtk. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 02:02:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 02:02:15 -0700 Subject: [Webkit-unassigned] [Bug 119080] [CSS Masking] -webkit-mask-repeat: round does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119080 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207633|0 |1 is obsolete| | Attachment #207633|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 02:02:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 02:02:25 -0700 Subject: [Webkit-unassigned] [Bug 119080] [CSS Masking] -webkit-mask-repeat: round does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119080 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207907| |review? Flag| | --- Comment #4 from Andrei Parvu 2013-08-01 02:02:09 PST --- Created an attachment (id=207907) --> (https://bugs.webkit.org/attachment.cgi?id=207907&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 02:04:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 02:04:37 -0700 Subject: [Webkit-unassigned] [Bug 119080] [CSS Masking] -webkit-mask-repeat: round does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119080 --- Comment #5 from Andrei Parvu 2013-08-01 02:04:20 PST --- This also fixes the background-repeat. I added background-repeat tests and addressed your comments. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 02:39:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 02:39:53 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #12 from Build Bot 2013-08-01 02:39:36 PST --- (From update of attachment 207901) Attachment 207901 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1311014 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 03:56:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 03:56:43 -0700 Subject: [Webkit-unassigned] [Bug 119137] [CSS Regions] Selecting text through different regions flow does not match with highlight In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119137 --- Comment #11 from Javier Fernandez 2013-08-01 03:56:26 PST --- (In reply to comment #10) > (From update of attachment 207639 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207639&action=review > > > Source/WebCore/editing/FrameSelection.cpp:307 > > + if (atDifferentFlowThread(s.base(), s.extent())) > > + return; > > + > > This is not the right place to fix this. We need to do this inside VisibleSelection::validate probably right before or right after we call adjustSelectionToAvoidCrossingShadowBoundaries. The purpose of this patch is to avoid setting a new VisibleSelection instance to the FrameSelection if it's incompatible in terms of RenderFlow. For the shake of clarity, I've taken the assumption that only selections starting and ending in the same FlowThread, or both outside, are allowed. On the other hand, that's the current behaviour after the fix for the bug #105641. This patch keep that behaviour form the rendering point of view, but at the same time targeting also the issues related to the selected content. Getting back to your suggestion of implementing this in the VisibleSelection::validate(), this method is intended for adjusting the new Selection to fit in some validation rules. It's not necessary to adjust the new selection, since the one already set before in the FrameSelection instance is correct. If done at validation() we should move back the extent Position to the last one FlowThread compatible, which it would require to explore the DOM. This could have also an impact on performance, even more considering validate(9 is called a lot of times, overall, when selection is performed by user gestures. After all this, do you still think VisibleSelection::validate() is the right place to put this logic ? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 04:00:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 04:00:07 -0700 Subject: [Webkit-unassigned] [Bug 113571] Implement DOMFutures In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113571 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW AssignedTo|dchris at gmail.com |webkit-unassigned at lists.web | |kit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 04:01:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 04:01:02 -0700 Subject: [Webkit-unassigned] [Bug 119388] New: [rendering] Implement PaintInfo interfaces Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119388 Summary: [rendering] Implement PaintInfo interfaces Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: savagobr at yahoo.com PaintInfo is a struct used all around in rendering. There is a FIXME that dates way back to August 2011 to implement interfaces on it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 04:01:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 04:01:35 -0700 Subject: [Webkit-unassigned] [Bug 113571] Implement DOMFutures In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113571 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #17 from Christophe Dumez 2013-08-01 04:01:17 PST --- Promises should now be implemented, not futures. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:17:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:17:47 -0700 Subject: [Webkit-unassigned] [Bug 119078] [GTK] [EFL] Enable tiled shadow blur for the inset shadows. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119078 --- Comment #3 from Alejandro G. Castro 2013-08-01 05:17:31 PST --- (In reply to comment #2) > (From update of attachment 207444 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207444&action=review > > Nice. Just a couple suggestions before landing. > > > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1054 > > + if (!roundedHoleRect.radii().isZero()) > > + path.addRoundedRect(roundedHoleRect); > > + else > > + path.addRect(roundedHoleRect.rect()); > > I wonder if this optimization should go into Path.cpp eventually? > Good point, not sure, I can check it in a follow-up patch. > > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1061 > > + setFillRule(RULE_EVENODD); > > + setFillColor(color, colorSpace); > > I think that instead of setting the fill rule and color for the GraphicsContext you should just set them for the Cairo context. That way you can use cairo_save/cairo_restore, instead of oldFillRule and oldFillColor. > Yep, it sounds better option. > > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1065 > > + ShadowBlur& shadow = platformContext()->shadowBlur(); > > + shadow.drawInsetShadow(this, rect, roundedHoleRect.rect(), roundedHoleRect.radii()); > > I think you can avoid the temporary and move this code to the very start of the method after the early return. Ok, Thanks for the review. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:25:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:25:53 -0700 Subject: [Webkit-unassigned] [Bug 119391] New: REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119391 Summary: REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jbrianceau at nds.com ctiVMThrowTrampolineSlowpath implementation is not correct for sh4 architecture and crashes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:31:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:31:32 -0700 Subject: [Webkit-unassigned] [Bug 118894] [CSS blending] Background-blend-mode doesn't apply for an SVG image with css border-style or padding property set In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118894 Horia Olaru changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olaru at adobe.com --- Comment #1 from Horia Olaru 2013-08-01 05:31:16 PST --- I tested this with the current nightly: Version 6.0.5 (8536.30.1, 538+) I can reproduce this only using border-style. If I take out the border, and leave only the padding, background blending works. Also,the bug reproduces even without the padding added. This only seems to reproduce with data uri svg images. I could not reproduce it with a local file svg (url). It is probably worth checking if this reproduces with data uri non-svg images. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:39:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:39:01 -0700 Subject: [Webkit-unassigned] [Bug 119080] [CSS Masking] -webkit-mask-repeat: round does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119080 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207907|review? |review+, commit-queue+ Flag| | --- Comment #6 from Dirk Schulze 2013-08-01 05:38:46 PST --- (From update of attachment 207907) r=me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:43:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:43:06 -0700 Subject: [Webkit-unassigned] [Bug 119392] New: [Qt] REGRESSION(r) Two pixel result fail after r153522 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119392 Summary: [Qt] REGRESSION(r) Two pixel result fail after r153522 Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: Qt Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: zarvai at inf.u-szeged.hu CC: allan.jensen at digia.com, jocelyn.turcotte at digia.com, kadam at inf.u-szeged.hu, abrhm at inf.u-szeged.hu Blocks: 79666,119263 Created an attachment (id=207915) --> (https://bugs.webkit.org/attachment.cgi?id=207915&action=review) svg results There are many results that look much better :-) Those are updated in r153579. Also there are two test that seem to be fail after changing scale values: svg/custom/image-rescale.svg svg/custom/image-small-width-height.svg Results are attached to the bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:43:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:43:09 -0700 Subject: [Webkit-unassigned] [Bug 79666] [Qt] Meta bug to fix regressions cause layout test failures In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=79666 Zoltan Arvai changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119392 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:44:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:44:05 -0700 Subject: [Webkit-unassigned] [Bug 119392] [Qt] REGRESSION(r) Two pixel result fail after r153522 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119392 --- Comment #1 from Zoltan Arvai 2013-08-01 05:43:50 PST --- Created an attachment (id=207916) --> (https://bugs.webkit.org/attachment.cgi?id=207916&action=review) image-rescale-actual -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:44:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:44:38 -0700 Subject: [Webkit-unassigned] [Bug 119392] [Qt] REGRESSION(r) Two pixel result fail after r153522 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119392 --- Comment #2 from Zoltan Arvai 2013-08-01 05:44:23 PST --- Created an attachment (id=207917) --> (https://bugs.webkit.org/attachment.cgi?id=207917&action=review) image-small-width-height-actual -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:46:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:46:21 -0700 Subject: [Webkit-unassigned] [Bug 119393] New: [CSS Regions] Margins are not correctly computed in regions with mixed widths Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119393 Summary: [CSS Regions] Margins are not correctly computed in regions with mixed widths Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.pena at samsung.com CC: mihnea at adobe.com Blocks: 57312 Created an attachment (id=207918) --> (https://bugs.webkit.org/attachment.cgi?id=207918&action=review) LayoutTest proposal (This shares the same preconditions as bug #74131) If you have an element in a region with a percentage margin, and the region is followed by another region with a larger width, the size and margin calculations are using the widest region in the flow, then moving and clipping for display in the first region. As a result, using getComputedStyle to retrieve these margins fails, giving the original values which used the widest region in the flow. I created a test, starting from the one attached in bug #74131 and modifying it to incorporate the logic from http://trac.webkit.org/browser/trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-margin-percentage.html. It can be seen how the test passes once we remove the second region with the larger width. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:46:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:46:25 -0700 Subject: [Webkit-unassigned] [Bug 57312] [META][CSSRegions] Add regions support in WebKit In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=57312 Simon Pena changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119393 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:54:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:54:22 -0700 Subject: [Webkit-unassigned] [Bug 119391] REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119391 --- Comment #1 from Julien Brianceau 2013-08-01 05:54:06 PST --- Created an attachment (id=207919) --> (https://bugs.webkit.org/attachment.cgi?id=207919&action=review) ctiVMThrowTrampolineSlowpath fix for sh4 architecture. According to the run-javascriptcore-tests script, sh4 port seems to be equivalent to what is was before FTL merge with this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:58:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:58:16 -0700 Subject: [Webkit-unassigned] [Bug 119391] REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119391 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:58:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:58:23 -0700 Subject: [Webkit-unassigned] [Bug 119391] REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119391 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fpizlo at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 05:58:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 05:58:41 -0700 Subject: [Webkit-unassigned] [Bug 119391] REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119391 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207919| |review?, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:02:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:02:46 -0700 Subject: [Webkit-unassigned] [Bug 119080] [CSS Masking] -webkit-mask-repeat: round does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119080 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207907|review+, commit-queue+ | Flag| | --- Comment #7 from WebKit Commit Bot 2013-08-01 06:02:31 PST --- (From update of attachment 207907) Clearing flags on attachment: 207907 Committed r153582: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:02:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:02:51 -0700 Subject: [Webkit-unassigned] [Bug 119080] [CSS Masking] -webkit-mask-repeat: round does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119080 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #8 from WebKit Commit Bot 2013-08-01 06:02:35 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:02:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:02:52 -0700 Subject: [Webkit-unassigned] [Bug 95389] Master bug: Implementing CSS Masking In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=95389 Bug 95389 depends on bug 119080, which changed state. Bug 119080 Summary: [CSS Masking] -webkit-mask-repeat: round does not work https://bugs.webkit.org/show_bug.cgi?id=119080 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|UNCONFIRMED |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:04:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:04:03 -0700 Subject: [Webkit-unassigned] [Bug 119391] REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119391 Csaba Osztrogonac changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207919|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #2 from Csaba Osztrogonac 2013-08-01 06:03:48 PST --- (From update of attachment 207919) rs=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:04:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:04:57 -0700 Subject: [Webkit-unassigned] [Bug 119391] REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119391 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:05:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:05:40 -0700 Subject: [Webkit-unassigned] [Bug 119395] New: JavaScript crash. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119395 Summary: JavaScript crash. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: peavo at outlook.com I'm getting a crash (NULL pointer access violation) in JavaScriptCore. This is the stacktrace: JavaScriptCore.dll!JSC::JSCell::methodTable() Line 157 C++ JavaScriptCore.dll!JSC::errorDescriptionForValue(JSC::ExecState * exec, JSC::JSValue v) Line 112 + 0xe bytes C++ JavaScriptCore.dll!JSC::createError(JSC::ExecState * exec, JSC::JSObject * (JSC::ExecState *, const WTF::String &)* errorFactory, JSC::JSValue value, const WTF::String & message) Line 117 + 0x24 bytes C++ JavaScriptCore.dll!JSC::createNotAnObjectError(JSC::ExecState * exec, JSC::JSValue value) Line 141 + 0x28 bytes C++ JavaScriptCore.dll!JSC::JSValue::synthesizePrototype(JSC::ExecState * exec) Line 111 + 0xe bytes C++ JavaScriptCore.dll!JSC::JSValue::get(JSC::ExecState * exec, unsigned int propertyName, JSC::PropertySlot & slot) Line 660 C++ JavaScriptCore.dll!JSC::getByVal(JSC::ExecState * callFrame, JSC::JSValue baseValue, JSC::JSValue subscript, JSC::ReturnAddressPtr returnAddress) Line 1542 C++ JavaScriptCore.dll!cti_op_get_by_val_generic(void * * args) Line 1603 C++ 0c192fce() JavaScriptCore.dll!JSC::JITCode::execute(JSC::JSStack * stack, JSC::ExecState * callFrame, JSC::VM * vm) Line 46 + 0x20 bytes C++ JavaScriptCore.dll!JSC::Interpreter::execute(JSC::ProgramExecutable * program, JSC::ExecState * callFrame, JSC::JSObject * thisObj) Line 856 + 0x2d bytes C++ JavaScriptCore.dll!JSC::evaluate(JSC::ExecState * exec, const JSC::SourceCode & source, JSC::JSValue thisValue, JSC::JSValue * returnedException) Line 85 C++ WebKit.dll!WebCore::JSMainThreadExecState::evaluate(JSC::ExecState * exec, const JSC::SourceCode & source, JSC::JSValue thisValue, JSC::JSValue * exception) Line 74 + 0x1b bytes C++ WebKit.dll!WebCore::ScriptController::evaluateInWorld(const WebCore::ScriptSourceCode & sourceCode, WebCore::DOMWrapperWorld * world) Line 142 + 0x34 bytes C++ WebKit.dll!WebCore::ScriptController::evaluate(const WebCore::ScriptSourceCode & sourceCode) Line 158 + 0x40 bytes C++ WebKit.dll!WebCore::ScriptElement::executeScript(const WebCore::ScriptSourceCode & sourceCode) Line 316 + 0x16 bytes C++ WebKit.dll!WebCore::ScriptRunner::timerFired(WebCore::Timer * timer) Line 121 + 0x2a5 bytes C++ WebKit.dll!WebCore::Timer::fired() Line 114 + 0xb bytes C++ WebKit.dll!WebCore::ThreadTimers::sharedTimerFiredInternal() Line 132 C++ WebKit.dll!WebCore::TimerWindowWndProc(HWND__ * hWnd, unsigned int message, unsigned int wParam, long lParam) Line 111 C++ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:11:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:11:10 -0700 Subject: [Webkit-unassigned] [Bug 119395] JavaScript crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119395 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207921| |review? Flag| | --- Comment #1 from peavo at outlook.com 2013-08-01 06:10:55 PST --- Created an attachment (id=207921) --> (https://bugs.webkit.org/attachment.cgi?id=207921&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:11:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:11:50 -0700 Subject: [Webkit-unassigned] [Bug 119395] JavaScript crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119395 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207921| |commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:12:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:12:16 -0700 Subject: [Webkit-unassigned] [Bug 119395] JavaScript crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119395 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:14:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:14:17 -0700 Subject: [Webkit-unassigned] [Bug 119395] JavaScript crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119395 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ggaren at apple.com, | |mhahnenberg at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:20:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:20:56 -0700 Subject: [Webkit-unassigned] [Bug 119396] New: Constant REPEATABLE Crashes, Repeatable STEPS every time included Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119396 Summary: Constant REPEATABLE Crashes, Repeatable STEPS every time included Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh OS/Version: All Status: UNCONFIRMED Severity: Blocker Priority: P1 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: courtkizer at gmail.com For the last two weeks of nightly builds constant crashing when clicking links. The one below is repeatable. Login to Facebook. Double click a buddy on the right side as if you were going to message them Webkit will instantly crash. This is not a Facebook only bug, it's happening all the time. Something you changed in Webkit is breaking and making it completely unusable. I find it really hard to believe something like this wouldn't get caught in unit testing. SCREENSHOT: http://kzr.me/image/2r1R0d2Z1F1Q ERRROR MESSAGES: Process: WebProcess [20387] Path: /Applications/WebKit.app/Contents/Frameworks/10.8/WebKit2.framework/WebProcess.app/Contents/MacOS/WebProcess Identifier: com.apple.WebProcess Version: 538+ (538.1+) Code Type: X86-64 (Native) Parent Process: ??? [1] User ID: 502 Date/Time: 2013-08-01 09:13:25.162 -0400 OS Version: Mac OS X 10.8.4 (12E55) Report Version: 10 Sleep/Wake UUID: A7494A97-3BA6-41BC-893C-192BDF670B1A Interval Since Last Report: 8348 sec Crashes Since Last Report: 20 Per-App Interval Since Last Report: 639 sec Per-App Crashes Since Last Report: 2 Anonymous UUID: BD895012-4E85-784A-0CA0-643812312DB2 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000018 VM Regions Near 0x18: --> __TEXT 000000010d609000-000000010d60a000 [ 4K] r-x/rwx SM=COW /Applications/WebKit.app/Contents/Frameworks/10.8/WebKit2.framework/WebProcess.app/Contents/MacOS/WebProcess Application Specific Information: Bundle controller class: BrowserBundleController Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x000000010ea37a5c WebCore::SpaceSplitString::spaceSplitStringContainsValue(WTF::String const&, char const*, unsigned int, bool) + 60 1 com.apple.WebCore 0x000000010e2d1ca7 WebCore::HTMLAnchorElement::parseAttribute(WebCore::QualifiedName const&, WTF::AtomicString const&) + 423 2 com.apple.WebCore 0x000000010e1ee2ea WebCore::Element::attributeChanged(WebCore::QualifiedName const&, WTF::AtomicString const&, WebCore::Element::AttributeModificationReason) + 42 3 com.apple.WebCore 0x000000010e1f23f8 WebCore::Element::didRemoveAttribute(WebCore::QualifiedName const&) + 40 4 com.apple.WebCore 0x000000010e1ebfb9 WebCore::Element::removeAttributeInternal(unsigned int, WebCore::Element::SynchronizationOfLazyAttribute) + 329 5 com.apple.WebCore 0x000000010e1f26c5 WebCore::Element::removeAttribute(WTF::AtomicString const&) + 149 6 com.apple.WebCore 0x000000010e531bd6 WebCore::jsElementPrototypeFunctionRemoveAttribute(JSC::ExecState*) + 326 7 ??? 0x0000298842a01045 0 + 45665210077253 8 com.apple.JavaScriptCore 0x000000010dc0a771 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) + 49 9 com.apple.JavaScriptCore 0x000000010dbf04aa JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 650 10 com.apple.JavaScriptCore 0x000000010dad8475 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 69 11 com.apple.JavaScriptCore 0x000000010dc4006e JSC::boundFunctionCall(JSC::ExecState*) + 558 12 ??? 0x0000298842a01045 0 + 45665210077253 13 com.apple.JavaScriptCore 0x000000010dc0a771 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) + 49 14 com.apple.JavaScriptCore 0x000000010dbf0bdf JSC::Interpreter::execute(JSC::CallFrameClosure&) + 287 15 com.apple.JavaScriptCore 0x000000010dab66de JSC::arrayProtoFuncForEach(JSC::ExecState*) + 1118 16 ??? 0x0000298842a01045 0 + 45665210077253 17 com.apple.JavaScriptCore 0x000000010dc0a771 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) + 49 18 com.apple.JavaScriptCore 0x000000010dbf04aa JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 650 19 com.apple.JavaScriptCore 0x000000010dad8475 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 69 20 com.apple.JavaScriptCore 0x000000010dc4006e JSC::boundFunctionCall(JSC::ExecState*) + 558 21 ??? 0x0000298842a01045 0 + 45665210077253 22 com.apple.JavaScriptCore 0x000000010dc0a771 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) + 49 23 com.apple.JavaScriptCore 0x000000010dbf04aa JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 650 24 com.apple.JavaScriptCore 0x000000010dad8475 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 69 25 com.apple.JavaScriptCore 0x000000010dc4006e JSC::boundFunctionCall(JSC::ExecState*) + 558 26 ??? 0x0000298842a01045 0 + 45665210077253 27 com.apple.JavaScriptCore 0x000000010dc0a771 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) + 49 28 com.apple.JavaScriptCore 0x000000010dbf04aa JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 650 29 com.apple.JavaScriptCore 0x000000010dad8475 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 69 30 com.apple.JavaScriptCore 0x000000010dc4006e JSC::boundFunctionCall(JSC::ExecState*) + 558 31 ??? 0x0000298842a01045 0 + 45665210077253 32 com.apple.JavaScriptCore 0x000000010dc0a771 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) + 49 33 com.apple.JavaScriptCore 0x000000010dbf04aa JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 650 34 com.apple.JavaScriptCore 0x000000010dad8475 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 69 35 com.apple.JavaScriptCore 0x000000010dc4006e JSC::boundFunctionCall(JSC::ExecState*) + 558 36 ??? 0x0000298842a01045 0 + 45665210077253 37 com.apple.JavaScriptCore 0x000000010dc0a771 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) + 49 38 com.apple.JavaScriptCore 0x000000010dbf04aa JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 650 39 com.apple.JavaScriptCore 0x000000010dad8475 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 69 40 com.apple.JavaScriptCore 0x000000010dc4006e JSC::boundFunctionCall(JSC::ExecState*) + 558 41 ??? 0x0000298842a01045 0 + 45665210077253 42 com.apple.JavaScriptCore 0x000000010dc0a771 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) + 49 43 com.apple.JavaScriptCore 0x000000010dbf04aa JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 650 44 com.apple.JavaScriptCore 0x000000010dad8475 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 69 45 com.apple.WebCore 0x000000010e545c0c WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) + 908 46 com.apple.WebCore 0x000000010e21618c WebCore::EventTarget::fireEventListeners(WebCore::Event*, WebCore::EventTargetData*, WTF::Vector&) + 364 47 com.apple.WebCore 0x000000010e215ea6 WebCore::EventTarget::fireEventListeners(WebCore::Event*) + 390 48 com.apple.WebCore 0x000000010e7fc833 WebCore::Node::handleLocalEvents(WebCore::Event*) + 67 49 com.apple.WebCore 0x000000010e1fe5e7 WebCore::EventContext::handleLocalEvents(WebCore::Event*) const + 87 50 com.apple.WebCore 0x000000010e1ff508 WebCore::EventDispatcher::dispatchEventAtBubbling(WebCore::WindowEventContext&) + 56 51 com.apple.WebCore 0x000000010e1ff3f1 WebCore::EventDispatcher::dispatch() + 753 52 com.apple.WebCore 0x000000010e7e9a6f WebCore::MouseEventDispatchMediator::dispatchEvent(WebCore::EventDispatcher*) const + 159 53 com.apple.WebCore 0x000000010e1fe7fc WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WTF::PassRefPtr) + 124 54 com.apple.WebCore 0x000000010e7fcf35 WebCore::Node::dispatchMouseEvent(WebCore::PlatformMouseEvent const&, WTF::AtomicString const&, int, WebCore::Node*) + 133 55 com.apple.WebCore 0x000000010e205f6b WebCore::EventHandler::dispatchMouseEvent(WTF::AtomicString const&, WebCore::Node*, bool, int, WebCore::PlatformMouseEvent const&, bool) + 107 56 com.apple.WebCore 0x000000010e207a0e WebCore::EventHandler::handleMouseReleaseEvent(WebCore::PlatformMouseEvent const&) + 1198 57 com.apple.WebKit2 0x000000010d738dac WebKit::handleMouseEvent(WebKit::WebMouseEvent const&, WebKit::WebPage*, bool) + 419 58 com.apple.WebKit2 0x000000010d738bcd WebKit::WebPage::mouseEvent(WebKit::WebMouseEvent const&) + 221 59 com.apple.WebKit2 0x000000010d74c18c void CoreIPC::handleMessage(CoreIPC::MessageDecoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebMouseEvent const&)) + 83 60 com.apple.WebKit2 0x000000010d67f277 CoreIPC::MessageReceiverMap::dispatchMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&) + 137 61 com.apple.WebKit2 0x000000010d787c9c WebKit::WebProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&) + 34 62 com.apple.WebKit2 0x000000010d65476b CoreIPC::Connection::dispatchMessage(WTF::PassOwnPtr) + 105 63 com.apple.WebKit2 0x000000010d6562b6 CoreIPC::Connection::dispatchOneMessage() + 106 64 com.apple.WebCore 0x000000010e9d5091 WebCore::RunLoop::performWork() + 129 65 com.apple.WebCore 0x000000010e9d5652 WebCore::RunLoop::performWork(void*) + 34 66 com.apple.CoreFoundation 0x00007fff8eb76b31 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 67 com.apple.CoreFoundation 0x00007fff8eb76455 __CFRunLoopDoSources0 + 245 68 com.apple.CoreFoundation 0x00007fff8eb997f5 __CFRunLoopRun + 789 69 com.apple.CoreFoundation 0x00007fff8eb990e2 CFRunLoopRunSpecific + 290 70 com.apple.HIToolbox 0x00007fff8fecfeb4 RunCurrentEventLoopInMode + 209 71 com.apple.HIToolbox 0x00007fff8fecfc52 ReceiveNextEventCommon + 356 72 com.apple.HIToolbox 0x00007fff8fecfae3 BlockUntilNextEventMatchingListInMode + 62 73 com.apple.AppKit 0x00007fff88021533 _DPSNextEvent + 685 74 com.apple.AppKit 0x00007fff88020df2 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128 75 com.apple.AppKit 0x00007fff880181a3 -[NSApplication run] + 517 76 com.apple.WebCore 0x000000010e9d5cd2 WebCore::RunLoop::run() + 82 77 com.apple.WebKit2 0x000000010d6f65b7 int WebKit::ChildProcessMain(int, char**) + 579 78 com.apple.WebProcess 0x000000010d609e23 main + 337 79 libdyld.dylib 0x00007fff8792f7e1 start + 1 Thread 1:: Dispatch queue: com.apple.libdispatch-manager 0 libsystem_kernel.dylib 0x00007fff8fd04d16 kevent + 10 1 libdispatch.dylib 0x00007fff898e3dea _dispatch_mgr_invoke + 883 2 libdispatch.dylib 0x00007fff898e39ee _dispatch_mgr_thread + 54 Thread 2: 0 libsystem_kernel.dylib 0x00007fff8fd046d6 __workq_kernreturn + 10 1 libsystem_c.dylib 0x00007fff8f983f4c _pthread_workq_return + 25 2 libsystem_c.dylib 0x00007fff8f983d13 _pthread_wqthread + 412 3 libsystem_c.dylib 0x00007fff8f96e1d1 start_wqthread + 13 Thread 3:: JavaScriptCore::BlockFree 0 libsystem_kernel.dylib 0x00007fff8fd040fa __psynch_cvwait + 10 1 libsystem_c.dylib 0x00007fff8f985fe9 _pthread_cond_wait + 869 2 com.apple.JavaScriptCore 0x000000010ddb05c6 WTF::ThreadCondition::timedWait(WTF::Mutex&, double) + 118 3 com.apple.JavaScriptCore 0x000000010dabe59b JSC::BlockAllocator::blockFreeingThreadMain() + 123 4 com.apple.JavaScriptCore 0x000000010ddaf8df WTF::wtfThreadEntryPoint(void*) + 15 5 libsystem_c.dylib 0x00007fff8f9817a2 _pthread_start + 327 6 libsystem_c.dylib 0x00007fff8f96e1e1 thread_start + 13 Thread 4:: JavaScriptCore::Marking 0 libsystem_kernel.dylib 0x00007fff8fd040fa __psynch_cvwait + 10 1 libsystem_c.dylib 0x00007fff8f985fe9 _pthread_cond_wait + 869 2 com.apple.JavaScriptCore 0x000000010dbe23db JSC::GCThread::waitForNextPhase() + 123 3 com.apple.JavaScriptCore 0x000000010dbe249f JSC::GCThread::gcThreadMain() + 143 4 com.apple.JavaScriptCore 0x000000010ddaf8df WTF::wtfThreadEntryPoint(void*) + 15 5 libsystem_c.dylib 0x00007fff8f9817a2 _pthread_start + 327 6 libsystem_c.dylib 0x00007fff8f96e1e1 thread_start + 13 Thread 5:: JavaScriptCore::Marking 0 libsystem_kernel.dylib 0x00007fff8fd040fa __psynch_cvwait + 10 1 libsystem_c.dylib 0x00007fff8f985fe9 _pthread_cond_wait + 869 2 com.apple.JavaScriptCore 0x000000010dbe23db JSC::GCThread::waitForNextPhase() + 123 3 com.apple.JavaScriptCore 0x000000010dbe249f JSC::GCThread::gcThreadMain() + 143 4 com.apple.JavaScriptCore 0x000000010ddaf8df WTF::wtfThreadEntryPoint(void*) + 15 5 libsystem_c.dylib 0x00007fff8f9817a2 _pthread_start + 327 6 libsystem_c.dylib 0x00007fff8f96e1e1 thread_start + 13 Thread 6:: JavaScriptCore::Marking 0 libsystem_kernel.dylib 0x00007fff8fd040fa __psynch_cvwait + 10 1 libsystem_c.dylib 0x00007fff8f985fe9 _pthread_cond_wait + 869 2 com.apple.JavaScriptCore 0x000000010dbe23db JSC::GCThread::waitForNextPhase() + 123 3 com.apple.JavaScriptCore 0x000000010dbe249f JSC::GCThread::gcThreadMain() + 143 4 com.apple.JavaScriptCore 0x000000010ddaf8df WTF::wtfThreadEntryPoint(void*) + 15 5 libsystem_c.dylib 0x00007fff8f9817a2 _pthread_start + 327 6 libsystem_c.dylib 0x00007fff8f96e1e1 thread_start + 13 Thread 7:: JavaScriptCore::Marking 0 libsystem_kernel.dylib 0x00007fff8fd040fa __psynch_cvwait + 10 1 libsystem_c.dylib 0x00007fff8f985fe9 _pthread_cond_wait + 869 2 com.apple.JavaScriptCore 0x000000010dbe23db JSC::GCThread::waitForNextPhase() + 123 3 com.apple.JavaScriptCore 0x000000010dbe249f JSC::GCThread::gcThreadMain() + 143 4 com.apple.JavaScriptCore 0x000000010ddaf8df WTF::wtfThreadEntryPoint(void*) + 15 5 libsystem_c.dylib 0x00007fff8f9817a2 _pthread_start + 327 6 libsystem_c.dylib 0x00007fff8f96e1e1 thread_start + 13 Thread 8:: JavaScriptCore::Marking 0 libsystem_kernel.dylib 0x00007fff8fd040fa __psynch_cvwait + 10 1 libsystem_c.dylib 0x00007fff8f985fe9 _pthread_cond_wait + 869 2 com.apple.JavaScriptCore 0x000000010dbe23db JSC::GCThread::waitForNextPhase() + 123 3 com.apple.JavaScriptCore 0x000000010dbe249f JSC::GCThread::gcThreadMain() + 143 4 com.apple.JavaScriptCore 0x000000010ddaf8df WTF::wtfThreadEntryPoint(void*) + 15 5 libsystem_c.dylib 0x00007fff8f9817a2 _pthread_start + 327 6 libsystem_c.dylib 0x00007fff8f96e1e1 thread_start + 13 Thread 9:: JavaScriptCore::Marking 0 libsystem_kernel.dylib 0x00007fff8fd040fa __psynch_cvwait + 10 1 libsystem_c.dylib 0x00007fff8f985fe9 _pthread_cond_wait + 869 2 com.apple.JavaScriptCore 0x000000010dbe23db JSC::GCThread::waitForNextPhase() + 123 3 com.apple.JavaScriptCore 0x000000010dbe249f JSC::GCThread::gcThreadMain() + 143 4 com.apple.JavaScriptCore 0x000000010ddaf8df WTF::wtfThreadEntryPoint(void*) + 15 5 libsystem_c.dylib 0x00007fff8f9817a2 _pthread_start + 327 6 libsystem_c.dylib 0x00007fff8f96e1e1 thread_start + 13 Thread 10:: WebCore: Scrolling 0 libsystem_kernel.dylib 0x00007fff8fd02686 mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff8fd01c42 mach_msg + 70 2 com.apple.CoreFoundation 0x00007fff8eb94233 __CFRunLoopServiceMachPort + 195 3 com.apple.CoreFoundation 0x00007fff8eb99916 __CFRunLoopRun + 1078 4 com.apple.CoreFoundation 0x00007fff8eb990e2 CFRunLoopRunSpecific + 290 5 com.apple.CoreFoundation 0x00007fff8eba7dd1 CFRunLoopRun + 97 6 com.apple.WebCore 0x000000010ea0141e WebCore::ScrollingThread::initializeRunLoop() + 254 7 com.apple.JavaScriptCore 0x000000010ddaf8df WTF::wtfThreadEntryPoint(void*) + 15 8 libsystem_c.dylib 0x00007fff8f9817a2 _pthread_start + 327 9 libsystem_c.dylib 0x00007fff8f96e1e1 thread_start + 13 Thread 11:: com.apple.NSURLConnectionLoader 0 libsystem_kernel.dylib 0x00007fff8fd02686 mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff8fd01c42 mach_msg + 70 2 com.apple.CoreFoundation 0x00007fff8eb94233 __CFRunLoopServiceMachPort + 195 3 com.apple.CoreFoundation 0x00007fff8eb99916 __CFRunLoopRun + 1078 4 com.apple.CoreFoundation 0x00007fff8eb990e2 CFRunLoopRunSpecific + 290 5 com.apple.Foundation 0x00007fff8a035546 +[NSURLConnection(Loader) _resourceLoadLoop:] + 356 6 com.apple.Foundation 0x00007fff8a093562 __NSThread__main__ + 1345 7 libsystem_c.dylib 0x00007fff8f9817a2 _pthread_start + 327 8 libsystem_c.dylib 0x00007fff8f96e1e1 thread_start + 13 Thread 12:: com.apple.CFSocket.private 0 libsystem_kernel.dylib 0x00007fff8fd04322 __select + 10 1 com.apple.CoreFoundation 0x00007fff8ebd8f46 __CFSocketManager + 1302 2 libsystem_c.dylib 0x00007fff8f9817a2 _pthread_start + 327 3 libsystem_c.dylib 0x00007fff8f96e1e1 thread_start + 13 Thread 13:: JSC Compilation Thread 0 libsystem_kernel.dylib 0x00007fff8fd040fa __psynch_cvwait + 10 1 libsystem_c.dylib 0x00007fff8f985fe9 _pthread_cond_wait + 869 2 com.apple.JavaScriptCore 0x000000010dbd492b JSC::DFG::Worklist::runThread() + 747 3 com.apple.JavaScriptCore 0x000000010ddaf8df WTF::wtfThreadEntryPoint(void*) + 15 4 libsystem_c.dylib 0x00007fff8f9817a2 _pthread_start + 327 5 libsystem_c.dylib 0x00007fff8f96e1e1 thread_start + 13 Thread 14: 0 libsystem_kernel.dylib 0x00007fff8fd046d6 __workq_kernreturn + 10 1 libsystem_c.dylib 0x00007fff8f983f4c _pthread_workq_return + 25 2 libsystem_c.dylib 0x00007fff8f983d13 _pthread_wqthread + 412 3 libsystem_c.dylib 0x00007fff8f96e1d1 start_wqthread + 13 Thread 15: 0 libsystem_kernel.dylib 0x00007fff8fd046d6 __workq_kernreturn + 10 1 libsystem_c.dylib 0x00007fff8f983f4c _pthread_workq_return + 25 2 libsystem_c.dylib 0x00007fff8f983d13 _pthread_wqthread + 412 3 libsystem_c.dylib 0x00007fff8f96e1d1 start_wqthread + 13 Thread 16: 0 libsystem_kernel.dylib 0x00007fff8fd046d6 __workq_kernreturn + 10 1 libsystem_c.dylib 0x00007fff8f983f4c _pthread_workq_return + 25 2 libsystem_c.dylib 0x00007fff8f983d13 _pthread_wqthread + 412 3 libsystem_c.dylib 0x00007fff8f96e1d1 start_wqthread + 13 Thread 17: 0 libsystem_kernel.dylib 0x00007fff8fd046d6 __workq_kernreturn + 10 1 libsystem_c.dylib 0x00007fff8f983f4c _pthread_workq_return + 25 2 libsystem_c.dylib 0x00007fff8f983d13 _pthread_wqthread + 412 3 libsystem_c.dylib 0x00007fff8f96e1d1 start_wqthread + 13 Thread 18: 0 libsystem_kernel.dylib 0x00007fff8fd046d6 __workq_kernreturn + 10 1 libsystem_c.dylib 0x00007fff8f983f4c _pthread_workq_return + 25 2 libsystem_c.dylib 0x00007fff8f983d13 _pthread_wqthread + 412 3 libsystem_c.dylib 0x00007fff8f96e1d1 start_wqthread + 13 Thread 19: 0 libsystem_kernel.dylib 0x00007fff8fd046d6 __workq_kernreturn + 10 1 libsystem_c.dylib 0x00007fff8f983f4c _pthread_workq_return + 25 2 libsystem_c.dylib 0x00007fff8f983d13 _pthread_wqthread + 412 3 libsystem_c.dylib 0x00007fff8f96e1d1 start_wqthread + 13 Thread 20: 0 libsystem_kernel.dylib 0x00007fff8fd046d6 __workq_kernreturn + 10 1 libsystem_c.dylib 0x00007fff8f983f4c _pthread_workq_return + 25 2 libsystem_c.dylib 0x00007fff8f983d13 _pthread_wqthread + 412 3 libsystem_c.dylib 0x00007fff8f96e1d1 start_wqthread + 13 Thread 0 crashed with X86 Thread State (64-bit): rax: 0x0000000000000000 rbx: 0x000000000000000a rcx: 0x0000000000000001 rdx: 0x0000000000000000 rdi: 0x000000010de6b218 rsi: 0x000000010ece8524 rbp: 0x00007fff525f32b0 rsp: 0x00007fff525f3270 r8: 0x0000000000000000 r9: 0x0000000112a8d728 r10: 0x0000000117d2d908 r11: 0x000000010fbbd040 r12: 0x000000011a748f00 r13: 0x000000011a74cf00 r14: 0x000000010ece8524 r15: 0x000000011a748a10 rip: 0x000000010ea37a5c rfl: 0x0000000000010246 cr2: 0x0000000000000018 Logical CPU: 6 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:22:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:22:11 -0700 Subject: [Webkit-unassigned] [Bug 118893] Rendering offset for a circle with feBlend applied In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118893 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |krit at webkit.org Ever Confirmed|0 |1 --- Comment #4 from Dirk Schulze 2013-08-01 06:21:55 PST --- feImage seems to be responsible for the mis match http://jsfiddle.net/qZuru/ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:27:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:27:43 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hausmann at webkit.org --- Comment #21 from Simon Hausmann 2013-08-01 06:27:26 PST --- (In reply to comment #17) > (In reply to comment #16) > > Julien and I discovered the problem here: > > > > ExceptionHandler __attribute__ ((fastcall)) cti_vm_throw_slowpath(CallFrame* callFrame); > > > > On some compilers, returning a struct causes the compiler to allocate the first register as the "pointer to return value". > > Makes sense. I was looking at the disassembly that Julien posted and the use of %ecx was throwing me. The first arg (callFrame) was in %edx. > > That means that ctiVMThrowTrampolineSlowpath will need to be modified for those compilers to allocate the struct space on the stack and put the address in %ecx, put callFrame in %edx and then on return use the values in the stack instead of %eax:edx > > Did you determine any predefined macros that say the compiler is doing this? I believe that is the standard System V ABI on x86, which is implemented by Linux, Mac OS X (not that 32-bit matters here I suppose :) and other Unixy variants . See also "Functions Returning Structures or Unions" in http://sco.com/developers/devspecs/abi386-4.pdf The invisible pointer-to-returned-structure argument that's normally on the stack indeed moves into the first register then. On Windows on the other hand the structure in this case (which is 8 bytes) is returned in an eax:edx pair, if it fits ( http://msdn.microsoft.com/en-us/library/984x0h58.aspx ) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:28:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:28:01 -0700 Subject: [Webkit-unassigned] [Bug 119391] REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119391 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207919|review+, commit-queue+ | Flag| | --- Comment #3 from WebKit Commit Bot 2013-08-01 06:27:46 PST --- (From update of attachment 207919) Clearing flags on attachment: 207919 Committed r153583: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 06:28:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 06:28:03 -0700 Subject: [Webkit-unassigned] [Bug 119391] REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119391 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from WebKit Commit Bot 2013-08-01 06:27:47 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 07:08:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 07:08:02 -0700 Subject: [Webkit-unassigned] [Bug 115248] [CSSRegions] Min/max-width should support values other than length In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115248 --- Comment #9 from Anton Obzhirov 2013-08-01 07:07:47 PST --- (In reply to comment #7) > I have created a simple fiddle here: http://jsfiddle.net/chrisjg/q7nhQ/ > > example HTML > > > ----------------- > > example CSS > > nav { > font-size: 16px; > letter-spacing: -0.5px; > list-style: none outside none; > } > .nav, nav ul { > display: table; > margin: 0; > width: 100%; > } > .nav { > float: left; > left: 0; > position: relative; > list-style: none outside none; > margin-bottom: 1.42857rem; > margin-left: 0; > width: 400px; > } > > li { > border: 1px solid black; > display: table-cell; > height: 34px; > min-width: 25%; > text-align: center; > vertical-align: middle; > } > > ------- > The important bits are > .nav display: table; > li display: table-cell; > li min-width: 25%; > > It should result in 4 equally sized boxes, > as in the firefox screenshot I have attached. But in chrome it auto-sizes each box to fit the content - as in the chrome screenshot I also attached. > > Hope this helps. > > Chris. Hi, Checked the example html now - I think it is probably intended for another bug or new bug should be created for this. From what I see it doesn't use CSS regions. Chris, could you confirm that - may be I am missing something. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 07:14:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 07:14:43 -0700 Subject: [Webkit-unassigned] [Bug 118893] Rendering offset for a circle with feImage applied In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118893 Mirela changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rendering offset for a |Rendering offset for a |circle with feBlend applied |circle with feImage applied -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 07:28:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 07:28:12 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207731|0 |1 is obsolete| | Attachment #207731|review-, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 07:28:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 07:28:24 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207922| |review?, commit-queue? Flag| | --- Comment #48 from Brian Holt 2013-08-01 07:28:08 PST --- Created an attachment (id=207922) --> (https://bugs.webkit.org/attachment.cgi?id=207922&action=review) Rebased to master, addressed all comments and improved unit test -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 07:41:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 07:41:23 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207923| |review?, commit-queue? Flag| | --- Comment #50 from Benjamin Dupont 2013-08-01 07:41:07 PST --- Created an attachment (id=207923) --> (https://bugs.webkit.org/attachment.cgi?id=207923&action=review) New QWebPage API (with test): void QWebPage::setVisibilityState(QWebPage::PageVisibilityState state) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 08:04:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 08:04:05 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207923|0 |1 is obsolete| | Attachment #207923|review?, commit-queue? | Flag| | --- Comment #51 from Benjamin Dupont 2013-08-01 08:03:48 PST --- (From update of attachment 207923) I must remove webkit suffix (eg. webkitHidden -> hidden) from the test... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 08:10:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 08:10:03 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207926| |review?, commit-queue? Flag| | --- Comment #52 from Benjamin Dupont 2013-08-01 08:09:46 PST --- Created an attachment (id=207926) --> (https://bugs.webkit.org/attachment.cgi?id=207926&action=review) New QWebPage API (with test): void QWebPage::setVisibilityState(QWebPage::PageVisibilityState state) (2) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 08:11:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 08:11:05 -0700 Subject: [Webkit-unassigned] [Bug 119078] [GTK] [EFL] Enable tiled shadow blur for the inset shadows. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119078 Alejandro G. Castro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207444|0 |1 is obsolete| | Attachment #207927| |review? Flag| | --- Comment #4 from Alejandro G. Castro 2013-08-01 08:10:49 PST --- Created an attachment (id=207927) --> (https://bugs.webkit.org/attachment.cgi?id=207927&action=review) Proposed patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 08:11:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 08:11:30 -0700 Subject: [Webkit-unassigned] [Bug 119078] [GTK] [EFL] Enable tiled shadow blur for the inset shadows. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119078 Alejandro G. Castro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207444|review+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 08:20:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 08:20:05 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #22 from Julien Brianceau 2013-08-01 08:19:49 PST --- (In reply to comment #20) > Results are ok: > - run-fast-jsc reports "426 tests passed, 34 tests failed, 0 tests crashed." > - run-javascriptcore-tests reports "0 regressions found. 0 tests fixed. OK." Please note that results are ok for release builds ONLY (thanks to Zan who finds that debug builds were still KO with this). (In reply to comment #21) > I believe that is the standard System V ABI on x86, which is implemented by Linux, Mac OS X (not that 32-bit matters here I suppose :) and other Unixy variants . See also "Functions Returning Structures or Unions" in http://sco.com/developers/devspecs/abi386-4.pdf > > The invisible pointer-to-returned-structure argument that's normally on the stack indeed moves into the first register then. > > On Windows on the other hand the structure in this case (which is 8 bytes) is returned in an eax:edx pair, if it fits > ( http://msdn.microsoft.com/en-us/library/984x0h58.aspx ) Thanks a lot for the documentation :) So this is not a compiler issue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 08:26:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 08:26:13 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #13 from Ruth Fong 2013-08-01 08:25:57 PST --- (From update of attachment 207901) View in context: https://bugs.webkit.org/attachment.cgi?id=207901&action=review >> Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:65 >> @end > > I think you should transform WKColorPickerMac to a protocol, and move the two attributes to the subclass. > > WKColorPickerMac does not have ownership of _lastChangedByUser which leads to improper encapsulation. You should try to avoid inheritance as a way to share code, using encapsulation/aggregation leads to better designs. Moving the private variables makes sense. I like WKColorPickerMac as a base class because that way m_colorPickerUI can be of type WKColorPickerMac and I can maintain more abstraction in WebColorPickerMac. >> Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:74 >> + NSPopoverColorWell* popoverWell; > > You could use a RetainPtr here to avoid risking leaking this. Got it. >> Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:177 >> + > > I would also add a destructor just to be safe. You could call invalidate from it, or just assert that _picker and popoverWell are nil. Got it. >> Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:183 >> + _picker = nil; > > I believe you also want to remove the target of the popowerWell. Otherwise, if an other reference to the object exist, you may still get called. Got it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 08:27:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 08:27:37 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #23 from Julien Brianceau 2013-08-01 08:27:21 PST --- Created an attachment (id=207928) --> (https://bugs.webkit.org/attachment.cgi?id=207928&action=review) Fix for X86 32-bit (release and debug builds). DO NOT COMMIT Do not commit this patch. It fixes X86 32-bit builds (release and debug), but will break all other architectures (X86_64, sh4, ARM etc ...): each architecture dependent function ctiVMThrowTrampolineSlowpath must be adapated with this patch. JSC experts, do you think this kind of patch is a good way to fix the issue? If so, I'll make changes for the architectures I know (X86_64 and sh4) and submit a new patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 08:40:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 08:40:11 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #24 from Michael Saboff 2013-08-01 08:39:55 PST --- (In reply to comment #21) > (In reply to comment #17) > > (In reply to comment #16) > > > Julien and I discovered the problem here: > > > > > > ExceptionHandler __attribute__ ((fastcall)) cti_vm_throw_slowpath(CallFrame* callFrame); > > > > > > On some compilers, returning a struct causes the compiler to allocate the first register as the "pointer to return value". > > > > Makes sense. I was looking at the disassembly that Julien posted and the use of %ecx was throwing me. The first arg (callFrame) was in %edx. > > > > That means that ctiVMThrowTrampolineSlowpath will need to be modified for those compilers to allocate the struct space on the stack and put the address in %ecx, put callFrame in %edx and then on return use the values in the stack instead of %eax:edx > > > > Did you determine any predefined macros that say the compiler is doing this? > > I believe that is the standard System V ABI on x86, which is implemented by Linux, Mac OS X (not that 32-bit matters here I suppose :) and other Unixy variants . See also "Functions Returning Structures or Unions" in http://sco.com/developers/devspecs/abi386-4.pdf > > The invisible pointer-to-returned-structure argument that's normally on the stack indeed moves into the first register then. > > On Windows on the other hand the structure in this case (which is 8 bytes) is returned in an eax:edx pair, if it fits > ( http://msdn.microsoft.com/en-us/library/984x0h58.aspx ) Clang on MacOSX also passes an 8 byte structure in eax:edx. That is why this isn't an issue on 32 bit Mac builds. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 08:40:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 08:40:34 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #25 from Michael Saboff 2013-08-01 08:40:17 PST --- (In reply to comment #23) > Created an attachment (id=207928) --> (https://bugs.webkit.org/attachment.cgi?id=207928&action=review) [details] > Fix for X86 32-bit (release and debug builds). DO NOT COMMIT > > Do not commit this patch. It fixes X86 32-bit builds (release and debug), but will break all other architectures (X86_64, sh4, ARM etc ...): each architecture dependent function ctiVMThrowTrampolineSlowpath must be adapated with this patch. > > JSC experts, do you think this kind of patch is a good way to fix the issue? If so, I'll make changes for the architectures I know (X86_64 and sh4) and submit a new patch. We do not want to commit the patch. It uses whatever ecx contains without allocating memory, thus trashing whatever ecx points to. This patch could be fixed to allocate that space on the stack. The other approach is to return the two 32 bit values as one 64 bit value just like and encoded JSValue. This is in keeping with the X86 32 bit ABI. I plan on posting such a patch this morning. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 08:45:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 08:45:52 -0700 Subject: [Webkit-unassigned] [Bug 119395] JavaScript crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119395 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207921|review? |review- Flag| | --- Comment #2 from Geoffrey Garen 2013-08-01 08:45:37 PST --- (From update of attachment 207921) Can you provide a test case for this? I don't think checking isEmpty() here is right. Generally, JSValue() is not a valid value to use in the JIT or to pass to a runtime function. It's like a null pointer. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 09:18:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 09:18:58 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #26 from Julien Brianceau 2013-08-01 09:18:42 PST --- (In reply to comment #25) > > We do not want to commit the patch. It uses whatever ecx contains without allocating memory, thus trashing whatever ecx points to. This patch could be fixed to allocate that space on the stack. ecx is used as it was before: the first argument containing callFrame through fastcall. Memory for struct is reserved on stack (subl $8) and put in edx, the second argument through fastcall. > The other approach is to return the two 32 bit values as one 64 bit value just like and encoded JSValue. This is in keeping with the X86 32 bit ABI. I plan on posting such a patch this morning. I'm fine with this approach, provided we fix this bug :) Thanks in advance for your patch ! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 09:19:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 09:19:10 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207928|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 09:30:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 09:30:31 -0700 Subject: [Webkit-unassigned] [Bug 119298] JSOESTextureHalfFloat not generated on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119298 Alex Christensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207793| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 09:42:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 09:42:55 -0700 Subject: [Webkit-unassigned] [Bug 36084] baseline of inline-block is not bottom margin edge for overflow other than visible In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=36084 Christian Biesinger changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |BlinkMergeCandidate CC| |cbiesinger at chromium.org --- Comment #4 from Christian Biesinger 2013-08-01 09:42:40 PST --- https://codereview.chromium.org/21414002/ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 09:52:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 09:52:53 -0700 Subject: [Webkit-unassigned] [Bug 119298] JSOESTextureHalfFloat not generated on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119298 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207793|review+, commit-queue+ | Flag| | --- Comment #3 from WebKit Commit Bot 2013-08-01 09:52:38 PST --- (From update of attachment 207793) Clearing flags on attachment: 207793 Committed r153588: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 09:52:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 09:52:56 -0700 Subject: [Webkit-unassigned] [Bug 119298] JSOESTextureHalfFloat not generated on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119298 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from WebKit Commit Bot 2013-08-01 09:52:40 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 10:02:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 10:02:06 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #14 from Brady Eidson 2013-08-01 10:01:50 PST --- (From update of attachment 207901) View in context: https://bugs.webkit.org/attachment.cgi?id=207901&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:1008 > +#if ENABLE(INPUT_TYPE_COLOR) && ENABLE(INPUT_TYPE_COLOR_POPOVER) This preprocessor statement is unnecessary. Enabling INPUT_TYPE_COLOR_POPOVER without enabling INPUT_TYPE_COLOR is an invalid build config. I think each place you use this macro it should just be the INPUT_TYPE_COLOR_POPOVER clause by itself. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 10:47:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 10:47:31 -0700 Subject: [Webkit-unassigned] [Bug 119174] doesn't correctly handle the "size" attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119174 Antoine Quint changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |graouts at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 10:48:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 10:48:09 -0700 Subject: [Webkit-unassigned] [Bug 119402] New: [cmake] Extra compiler flags should be passed for all target Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119402 Summary: [cmake] Extra compiler flags should be passed for all target Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Text AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ossy at webkit.org Blocks: 119266 It seems extra compiler flags isn't passed for all target now. I found it when I tried to add back c++11 features and EFL build failed - https://bugs.webkit.org/show_bug.cgi?id=119266 I'm going to collect which targets are still missing and try to fix. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 10:48:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 10:48:14 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Michael Saboff changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207937| |review? Flag| | --- Comment #27 from Michael Saboff 2013-08-01 10:47:57 PST --- Created an attachment (id=207937) --> (https://bugs.webkit.org/attachment.cgi?id=207937&action=review) Patch I tested this with MacOSX 32 bit build by running JS tests and examining the disassembly to verify that edx:eax are used for return values. I also compiled this for ARM and verified via disassembly that r1:r0 are used for the return value. Maintainers of other platforms should verify this solves the issue for them as well before the patch is committed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 10:53:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 10:53:03 -0700 Subject: [Webkit-unassigned] [Bug 119403] New: Crashing Test: fast/forms/color/input-color-onchange-event.html Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 Summary: Crashing Test: fast/forms/color/input-color-onchange-event.html Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ruthiecftg at gmail.com CC: beidson at apple.com, jonlee at apple.com, graouts at apple.com Crashing on mac-wk1 because is not implemented yet on WK1 (https://bugs.webkit.org/show_bug.cgi?id=119094). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 10:53:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 10:53:40 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ruthiecftg at gmail.com, | |webkit-bug-importer at group.a | |pple.com --- Comment #1 from Ruth Fong 2013-08-01 10:53:25 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 10:54:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 10:54:01 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #2 from Radar WebKit Bug Importer 2013-08-01 10:53:46 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 10:54:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 10:54:04 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #28 from Csaba Osztrogonac 2013-08-01 10:53:48 PST --- (In reply to comment #27) > Created an attachment (id=207937) --> (https://bugs.webkit.org/attachment.cgi?id=207937&action=review) [details] > Patch > > I tested this with MacOSX 32 bit build by running JS tests and examining the disassembly to verify that edx:eax are used for return values. I also compiled this for ARM and verified via disassembly that r1:r0 are used for the return value. > > Maintainers of other platforms should verify this solves the issue for them as well before the patch is committed. Thanks for the fix, I'll check it on x86 and ARM soon with GCC. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 10:59:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 10:59:32 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207938| |review? Flag| | --- Comment #3 from Ruth Fong 2013-08-01 10:59:16 PST --- Created an attachment (id=207938) --> (https://bugs.webkit.org/attachment.cgi?id=207938&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:20:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:20:14 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 --- Comment #4 from Tim Horton 2013-08-01 11:19:59 PST --- (From update of attachment 207938) View in context: https://bugs.webkit.org/attachment.cgi?id=207938&action=review > LayoutTests/platform/mac-wk2/TestExpectations:118 > +fast/forms/color/input-color-onchange-event.html [ Pass ] There's a section down at the bottom titled "Features that are not supported in WebKit1, so skipped in mac/TestExpectations then re-enabled here". Please put this there. Also check if there's something similar for the other one. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:23:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:23:43 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 Tim Horton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thorton at apple.com --- Comment #5 from Tim Horton 2013-08-01 11:23:28 PST --- (In reply to comment #1) > We're using this one ^^. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:26:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:26:59 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 Antoine Quint changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207938|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:27:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:27:16 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207938|review+ |review- Flag| | --- Comment #6 from WebKit Commit Bot 2013-08-01 11:27:00 PST --- (From update of attachment 207938) Rejecting attachment 207938 from review queue. graouts at apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:28:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:28:14 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 Tim Horton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207938|commit-queue+ |commit-queue- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:30:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:30:35 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207938|0 |1 is obsolete| | --- Comment #7 from Ruth Fong 2013-08-01 11:30:19 PST --- Created an attachment (id=207940) --> (https://bugs.webkit.org/attachment.cgi?id=207940&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:31:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:31:56 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207940|0 |1 is obsolete| | --- Comment #8 from Ruth Fong 2013-08-01 11:31:41 PST --- Created an attachment (id=207941) --> (https://bugs.webkit.org/attachment.cgi?id=207941&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:33:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:33:39 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207941| |review?, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:33:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:33:54 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 Tim Horton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207941|review?, commit-queue? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:35:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:35:01 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:41:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:41:22 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #29 from Csaba Osztrogonac 2013-08-01 11:41:05 PST --- (In reply to comment #27) > Created an attachment (id=207937) --> (https://bugs.webkit.org/attachment.cgi?id=207937&action=review) [details] > Patch > > I tested this with MacOSX 32 bit build by running JS tests and examining the disassembly to verify that edx:eax are used for return values. I also compiled this for ARM and verified via disassembly that r1:r0 are used for the return value. > > Maintainers of other platforms should verify this solves the issue for them as well before the patch is committed. I tested it on x86/GCC/QtWebKit in release and debug mode too and run-javascriptore-tests pass without any fail, and there are only 7 crashes on fast/js: Regressions: Unexpected crashes (7) fast/js/create-lots-of-workers.html [ Crash ] fast/js/dfg-string-out-of-bounds-check-structure.html [ Crash ] fast/js/dfg-string-out-of-bounds-cse.html [ Crash ] fast/js/dfg-string-out-of-bounds-negative-check-structure.html [ Crash ] fast/js/dfg-string-out-of-bounds-negative-proto-value.html [ Crash ] fast/js/regress/string-get-by-val-out-of-bounds-insane.html [ Crash ] fast/js/regress/string-get-by-val-out-of-bounds.html [ Crash ] But it seems, it is a different bug, I'm going to file a new bug report about it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:49:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:49:00 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207901|0 |1 is obsolete| | Attachment #207901|commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:49:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:49:06 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #15 from Ruth Fong 2013-08-01 11:48:48 PST --- Created an attachment (id=207942) --> (https://bugs.webkit.org/attachment.cgi?id=207942&action=review) Patch uses WKSI, which hasn't been updated yet -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:56:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:56:53 -0700 Subject: [Webkit-unassigned] [Bug 119405] New: REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119405 Summary: REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ossy at webkit.org Depends on: 119140 STDERR: ASSERTION FAILED: currentLowest != NUM_REGS && currentSpillOrder != SpillHintInvalid STDERR: /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGRegisterBank.h(136) : JSC::DFG::RegisterBank::RegID JSC::DFG::RegisterBank::allocate(JSC::VirtualRegister&) [with BankInfo = JSC::DFG::GPRInfo, JSC::DFG::RegisterBank::RegID = JSC::X86Registers::RegisterID] Program terminated with signal 11, Segmentation fault. #0 0xf59e9618 in WTFCrash () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/Assertions.cpp:339 339 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) (gdb) bt #0 0xf59e9618 in WTFCrash () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/Assertions.cpp:339 #1 0xf57f53b6 in JSC::DFG::RegisterBank::allocate(JSC::VirtualRegister&) () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PrintStream.h:59 #2 0xf57f0368 in JSC::DFG::SpeculativeJIT::allocate() () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PrintStream.h:59 #3 0xf57d5ff3 in JSC::DFG::GPRTemporary::GPRTemporary (this=0xfff8ee64, jit=0x83094f0) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1214 #4 0xf57da30f in JSC::DFG::SpeculativeJIT::compileGetByValOnString (this=0x83094f0, node=0xeb8b04ac) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2137 #5 0xf58118c8 in JSC::DFG::SpeculativeJIT::compile(JSC::DFG::Node*) () at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:2665 #6 0xf57d878e in JSC::DFG::SpeculativeJIT::compileCurrentBlock (this=0x83094f0) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1804 #7 0xf57d8e38 in JSC::DFG::SpeculativeJIT::compile (this=0x83094f0) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1918 #8 0xf579d2e0 in JSC::DFG::JITCompiler::compileBody (this=0xfff91454) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:117 #9 0xf579ed95 in JSC::DFG::JITCompiler::compileFunction (this=0xfff91454) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:382 #10 0xf57c2649 in JSC::DFG::Plan::compileInThreadImpl (this=0x83285b0, longLivedState=0x827f790) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGPlan.cpp:256 #11 0xf57c214e in JSC::DFG::Plan::compileInThread (this=0x83285b0, longLivedState=0x827f790) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGPlan.cpp:113 #12 0xf578524d in JSC::DFG::compile (compileMode=CompileFunction, exec=0xe9d001f8, codeBlock=0x83035f8, jitCode=0xec23ea9c, jitCodeWithArityCheck=0xec23eaa4, osrEntryBytecodeIndex=) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGDriver.cpp:128 #13 0xf57852f2 in JSC::DFG::tryCompileFunction (exec=0xe9d001f8, codeBlock=0x83035f8, jitCode=0xec23ea9c, jitCodeWithArityCheck=0xec23eaa4, bytecodeIndex=) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/dfg/DFGDriver.cpp:139 #14 0xf5933125 in JSC::jitCompileFunctionIfAppropriateImpl(JSC::ExecState*, JSC::FunctionCodeBlock*, WTF::RefPtr&, JSC::MacroAssemblerCodePtr&, JSC::JITCode::JITType, unsigned int, JSC::JITCompilationEffort) () at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/bytecode/SpeculatedType.h:272 #15 0xf593346b in JSC::prepareFunctionForExecutionImpl(JSC::ExecState*, JSC::FunctionCodeBlock*, WTF::RefPtr&, JSC::MacroAssemblerCodePtr&, JSC::JITCode::JITType, unsigned int, JSC::CodeSpecializationKind) () at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/bytecode/SpeculatedType.h:272 #16 0xf59334ad in JSC::prepareFunctionForExecution(JSC::ExecState*, WTF::RefPtr&, JSC::FunctionCodeBlock*, WTF::RefPtr&, JSC::MacroAssemblerCodePtr&, int&, JSC::JITCode::JITType, unsigned int, JSC::CodeSpecializationKind) () at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/bytecode/SpeculatedType.h:272 #17 0xf59318c2 in JSC::FunctionExecutable::compileForCallInternal (this=0xec23ea88, exec=0xe9d001f8, scope=0xedc9fa38, jitType=DFGJIT, result=0xfff91db4, bytecodeIndex=) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/runtime/Executable.cpp:561 #18 0xf5931185 in JSC::FunctionExecutable::compileOptimizedForCall (this=0xec23ea88, exec=0xe9d001f8, scope=0xedc9fa38, result=0xfff91db4, bytecodeIndex=) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/runtime/Executable.cpp:480 #19 0xf567a218 in JSC::FunctionExecutable::compileOptimizedFor(JSC::ExecState*, JSC::JSScope*, JSC::CompilationResult&, unsigned int, JSC::CodeSpecializationKind) () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PrintStream.h:59 #20 0xf5674f9a in JSC::FunctionCodeBlock::compileOptimized (this=0x8314ff8, exec=0xe9d001f8, scope=0xedc9fa38, result=0xfff91db4, bytecodeIndex=) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/bytecode/CodeBlock.cpp:2730 #21 0xf588492d in cti_optimize (args=0xfff91e10) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/jit/JITStubs.cpp:1044 #22 0xf5881c61 in JSC::tryCacheGetByID (callFrame=0xee619460, codeBlock=0x827d76c, returnAddress=..., baseValue=..., propertyName=0x8274780, slot=0xfff91e98, stubInfo=0xf584e076) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/jit/JITStubs.cpp:274 #23 0xfff91e2c in ?? () #24 0xf586392a in JSC::JITCode::execute (this=0x8320a00, stack=0x827d76c, callFrame=0xe9d001a0, vm=0x8274780) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/jit/JITCode.cpp:46 #25 0xf584d40f in JSC::Interpreter::execute (this=0x827d760, eval=0xec23e9d8, callFrame=0xe9d00148, thisValue=..., scope=0xeb83cd50) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/interpreter/Interpreter.cpp:1208 #26 0xf584849d in JSC::eval (callFrame=0xe9d00148) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/interpreter/Interpreter.cpp:148 #27 0xf588875e in cti_op_call_eval (args=0xfff92900) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/jit/JITStubs.cpp:1965 #28 0xf5881c61 in JSC::tryCacheGetByID (callFrame=0xef986fc0, codeBlock=0x827d76c, returnAddress=..., baseValue=..., propertyName=0x8274780, slot=0xfff92988, stubInfo=0xf584e1d4) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/jit/JITStubs.cpp:274 #29 0xe9d00058 in ?? () #30 0xf586392a in JSC::JITCode::execute (this=0x831b0e8, stack=0x827d76c, callFrame=0xe9d00058, vm=0x8274780) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/jit/JITCode.cpp:46 #31 0xf584bb7e in JSC::Interpreter::execute (this=0x827d760, program=0xec23eae0, callFrame=0xedc9fa8c, thisObj=0xedcdffd8) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/interpreter/Interpreter.cpp:856 #32 0xf5925768 in JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) () at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/runtime/Completion.cpp:83 #33 0xf435e490 in WebCore::JSMainThreadExecState::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PassOwnArrayPtr.h:83 #34 0xf437b621 in WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*) () ---Type to continue, or q to quit--- at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PassOwnArrayPtr.h:83 #35 0xf437b71a in WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PassOwnArrayPtr.h:83 #36 0xf462e936 in WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PassOwnArrayPtr.h:83 #37 0xf47bfbcf in WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent(WebCore::PendingScript&) () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PassOwnArrayPtr.h:83 #38 0xf47bfa44 in WebCore::HTMLScriptRunner::executeParsingBlockingScript() () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PassOwnArrayPtr.h:83 #39 0xf47bfedb in WebCore::HTMLScriptRunner::executeParsingBlockingScripts() () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PassOwnArrayPtr.h:83 #40 0xf47c003e in WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad(WebCore::CachedResource*) () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PassOwnArrayPtr.h:83 #41 0xf47b1f17 in WebCore::HTMLDocumentParser::notifyFinished(WebCore::CachedResource*) () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PassOwnArrayPtr.h:83 #42 0xf49005c9 in WebCore::CachedResource::checkNotify (this=0x82e2f80) at /home/webkitbuildbot/oszi/WebKit/Source/WebCore/loader/cache/CachedResource.cpp:369 #43 0xf49006b1 in WebCore::CachedResource::finishLoading (this=0x82e2f80) at /home/webkitbuildbot/oszi/WebKit/Source/WebCore/loader/cache/CachedResource.cpp:385 #44 0xf49081b4 in WebCore::CachedScript::finishLoading(WebCore::ResourceBuffer*) () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PageBlock.h:72 #45 0xf4959af0 in WebCore::SubresourceLoader::didFinishLoading (this=0x82e3320, finishTime=0) at /home/webkitbuildbot/oszi/WebKit/Source/WebCore/loader/SubresourceLoader.cpp:282 #46 0xf4950ee1 in WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) () at /home/webkitbuildbot/oszi/WebKit/Source/WTF/wtf/PageBlock.h:72 #47 0xf4d9a0b8 in WebCore::QNetworkReplyHandler::finish() () at /usr/include/c++/4.6/bits/stl_algobase.h:218 #48 0xf4d98da0 in WebCore::QNetworkReplyHandlerCallQueue::flush() () at /usr/include/c++/4.6/bits/stl_algobase.h:218 #49 0xf4d98aec in WebCore::QNetworkReplyHandlerCallQueue::push(void (WebCore::QNetworkReplyHandler::*)()) () at /usr/include/c++/4.6/bits/stl_algobase.h:218 #50 0xf4d999a8 in WebCore::QNetworkReplyWrapper::didReceiveFinished() () at /usr/include/c++/4.6/bits/stl_algobase.h:218 #51 0xf4d9c09c in WebCore::QNetworkReplyWrapper::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) () at /usr/include/c++/4.6/bits/stl_algobase.h:218 #52 0xf2f8b9ad in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #53 0xf2f8c3cb in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #54 0xf3679fd5 in QNetworkReply::finished() () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Network.so.5 #55 0xf367a250 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Network.so.5 #56 0xf2f89b53 in QMetaCallEvent::placeMetaCall(QObject*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #57 0xf2f8d062 in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #58 0xf37c0e34 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Widgets.so.5 #59 0xf37c4844 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Widgets.so.5 #60 0xf2f62eee in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #61 0xf2f650b4 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #62 0xf2f6560c in QCoreApplication::sendPostedEvents(QObject*, int) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #63 0xf2fb02c4 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #64 0xf224bcda in g_main_context_dispatch () from /lib/i386-linux-gnu/libglib-2.0.so.0 #65 0xf224c0e5 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0 #66 0xf224c1c1 in g_main_context_iteration () from /lib/i386-linux-gnu/libglib-2.0.so.0 #67 0xf2fb06d8 in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #68 0xef9cf036 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.1/plugins/platforms/libqxcb.so #69 0xf2f61726 in QEventLoop::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #70 0xf2f61b64 in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #71 0xf2f656b2 in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #72 0xf3218984 in QGuiApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Gui.so.5 #73 0xf37bbfe4 in QApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Widgets.so.5 #74 0x0807b8db in main () at /usr/include/c++/4.6/bits/move.h:83 #75 0xf2a7e4d3 in __libc_start_main () from /lib/i386-linux-gnu/libc.so.6 #76 0x080599d1 in _start () -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:56:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:56:55 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Csaba Osztrogonac changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119405 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:57:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:57:32 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207941|review+, commit-queue+ | Flag| | --- Comment #9 from WebKit Commit Bot 2013-08-01 11:57:17 PST --- (From update of attachment 207941) Clearing flags on attachment: 207941 Committed r153594: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:57:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:57:35 -0700 Subject: [Webkit-unassigned] [Bug 119403] Crashing Test: fast/forms/color/input-color-onchange-event.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119403 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #10 from WebKit Commit Bot 2013-08-01 11:57:20 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:59:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:59:15 -0700 Subject: [Webkit-unassigned] [Bug 119405] REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119405 Csaba Osztrogonac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barraclough at apple.com, | |fpizlo at apple.com, | |ggaren at apple.com, | |mark.lam at apple.com, | |mhahnenberg at apple.com, | |msaboff at apple.com, | |oliver at apple.com, | |ossy at webkit.org --- Comment #1 from Csaba Osztrogonac 2013-08-01 11:58:59 PST --- I forgot to mention that I got it after applying https://bugs.webkit.org/attachment.cgi?id=207937&action=review And the following fast/js tests assert: fast/js/dfg-string-out-of-bounds-check-structure.html [ Crash ] fast/js/dfg-string-out-of-bounds-cse.html [ Crash ] fast/js/dfg-string-out-of-bounds-negative-check-structure.html [ Crash ] fast/js/dfg-string-out-of-bounds-negative-proto-value.html [ Crash ] fast/js/regress/string-get-by-val-out-of-bounds-insane.html [ Crash ] fast/js/regress/string-get-by-val-out-of-bounds.html [ Crash ] -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 11:59:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 11:59:42 -0700 Subject: [Webkit-unassigned] [Bug 119405] REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119405 --- Comment #2 from Csaba Osztrogonac 2013-08-01 11:59:26 PST --- ... and the tests pass with disabled DFG JIT -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 12:31:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 12:31:33 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207942| |commit-queue- Flag| | --- Comment #16 from Build Bot 2013-08-01 12:31:17 PST --- (From update of attachment 207942) Attachment 207942 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1321064 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 12:47:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 12:47:18 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #30 from Zan Dobersek 2013-08-01 12:47:01 PST --- Can confirm no crashes in JSC tests with the patch applied on the GTK port under a 32-bit chroot. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 12:56:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 12:56:17 -0700 Subject: [Webkit-unassigned] [Bug 119296] wrong static_casts in ANGLE In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119296 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207790|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 12:56:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 12:56:37 -0700 Subject: [Webkit-unassigned] [Bug 119296] wrong static_casts in ANGLE In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119296 Alex Christensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207790| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 12:59:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 12:59:54 -0700 Subject: [Webkit-unassigned] [Bug 119299] eglplatform.h needs to be copied on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119299 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207794|review? |review+, commit-queue+ Flag| | --- Comment #2 from Brent Fulgham 2013-08-01 12:59:39 PST --- (From update of attachment 207794) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:01:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:01:00 -0700 Subject: [Webkit-unassigned] [Bug 119299] eglplatform.h needs to be copied on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119299 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:01:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:01:49 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #17 from Build Bot 2013-08-01 13:01:32 PST --- (From update of attachment 207942) Attachment 207942 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1321066 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:20:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:20:05 -0700 Subject: [Webkit-unassigned] [Bug 119296] wrong static_casts in ANGLE In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119296 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207790|review+, commit-queue+ | Flag| | --- Comment #5 from WebKit Commit Bot 2013-08-01 13:19:50 PST --- (From update of attachment 207790) Clearing flags on attachment: 207790 Committed r153600: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:20:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:20:07 -0700 Subject: [Webkit-unassigned] [Bug 119296] wrong static_casts in ANGLE In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119296 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #6 from WebKit Commit Bot 2013-08-01 13:19:52 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:23:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:23:25 -0700 Subject: [Webkit-unassigned] [Bug 119299] eglplatform.h needs to be copied on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119299 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207794|review+, commit-queue+ | Flag| | --- Comment #3 from WebKit Commit Bot 2013-08-01 13:23:09 PST --- (From update of attachment 207794) Clearing flags on attachment: 207794 Committed r153601: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:23:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:23:26 -0700 Subject: [Webkit-unassigned] [Bug 119299] eglplatform.h needs to be copied on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119299 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from WebKit Commit Bot 2013-08-01 13:23:11 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:36:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:36:21 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #31 from Csaba Osztrogonac 2013-08-01 13:36:03 PST --- unfortunately ARM is still unhappy with this patch: - ARM traditional: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9246 - ARM thumb2: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9247 I'll check a disassembly soon. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:41:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:41:16 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #32 from Csaba Osztrogonac 2013-08-01 13:41:00 PST --- (In reply to comment #31) > unfortunately ARM is still unhappy with this patch: > - ARM traditional: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9246 > - ARM thumb2: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9247 > > I'll check a disassembly soon. Here is an ARM Thumb2 disassembly: 00179dc8 : 179dc8: b570 push {r4, r5, r6, lr} 179dca: 4603 mov r3, r0 179dcc: f850 1c08 ldr.w r1, [r0, #-8] 179dd0: b084 sub sp, #16 179dd2: ae02 add r6, sp, #8 179dd4: 4602 mov r2, r0 179dd6: 6b49 ldr r1, [r1, #52] ; 0x34 179dd8: 4630 mov r0, r6 179dda: f501 4592 add.w r5, r1, #18688 ; 0x4900 179dde: f501 44b1 add.w r4, r1, #22656 ; 0x5880 179de2: 622b str r3, [r5, #32] 179de4: e9d4 450e ldrd r4, r5, [r4, #56] ; 0x38 179de8: e9cd 4500 strd r4, r5, [sp] 179dec: f7e6 ffb0 bl 160d50 179df0: e896 0003 ldmia.w r6, {r0, r1} 179df4: f7e6 ff5c bl 160cb0 179df8: b004 add sp, #16 179dfa: bd70 pop {r4, r5, r6, pc} -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:44:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:44:43 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Filip Pizlo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207937|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:48:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:48:27 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #33 from Michael Saboff 2013-08-01 13:48:10 PST --- (In reply to comment #32) > (In reply to comment #31) > > unfortunately ARM is still unhappy with this patch: > > - ARM traditional: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9246 > > - ARM thumb2: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9247 > > > > I'll check a disassembly soon. > > Here is an ARM Thumb2 disassembly: > 00179dc8 : > 179dc8: b570 push {r4, r5, r6, lr} > 179dca: 4603 mov r3, r0 > 179dcc: f850 1c08 ldr.w r1, [r0, #-8] > 179dd0: b084 sub sp, #16 > 179dd2: ae02 add r6, sp, #8 > 179dd4: 4602 mov r2, r0 > 179dd6: 6b49 ldr r1, [r1, #52] ; 0x34 > 179dd8: 4630 mov r0, r6 > 179dda: f501 4592 add.w r5, r1, #18688 ; 0x4900 > 179dde: f501 44b1 add.w r4, r1, #22656 ; 0x5880 > 179de2: 622b str r3, [r5, #32] > 179de4: e9d4 450e ldrd r4, r5, [r4, #56] ; 0x38 > 179de8: e9cd 4500 strd r4, r5, [sp] > 179dec: f7e6 ffb0 bl 160d50 > 179df0: e896 0003 ldmia.w r6, {r0, r1} > 179df4: f7e6 ff5c bl 160cb0 > 179df8: b004 add sp, #16 > 179dfa: bd70 pop {r4, r5, r6, pc} What about a disassembly of JSC::encode(JSC::ExceptionHandler)? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:50:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:50:36 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #34 from Csaba Osztrogonac 2013-08-01 13:50:19 PST --- (In reply to comment #33) > What about a disassembly of JSC::encode(JSC::ExceptionHandler)? 00160cb0 : 160cb0: b084 sub sp, #16 160cb2: ab02 add r3, sp, #8 160cb4: e883 0003 stmia.w r3, {r0, r1} 160cb8: e893 0003 ldmia.w r3, {r0, r1} 160cbc: e88d 0003 stmia.w sp, {r0, r1} 160cc0: b004 add sp, #16 160cc2: 4770 bx lr -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:50:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:50:51 -0700 Subject: [Webkit-unassigned] [Bug 119395] Crash in JSCell::methodTable under errorDescriptionForValue() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119395 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|JavaScript crash. |Crash in | |JSCell::methodTable under | |errorDescriptionForValue() -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:52:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:52:52 -0700 Subject: [Webkit-unassigned] [Bug 119271] REGRESSION (r153145): fast/workers/worker-call.html fails In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119271 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.fraser at apple.com --- Comment #3 from Alexey Proskuryakov 2013-08-01 13:52:35 PST --- *** Bug 119375 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:55:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:55:55 -0700 Subject: [Webkit-unassigned] [Bug 113058] REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113058 --- Comment #13 from Alexey Proskuryakov 2013-08-01 13:55:37 PST --- Andreas, do you intend to land this patch, too? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 13:58:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 13:58:15 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #18 from Build Bot 2013-08-01 13:57:59 PST --- (From update of attachment 207942) Attachment 207942 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1314149 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:03:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:03:30 -0700 Subject: [Webkit-unassigned] [Bug 113058] REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113058 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196466|commit-queue- |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:03:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:03:37 -0700 Subject: [Webkit-unassigned] [Bug 113058] REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113058 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:04:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:04:04 -0700 Subject: [Webkit-unassigned] [Bug 119410] New: Fixed expected test results for run-bindings-tests after r153532, r153537. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119410 Summary: Fixed expected test results for run-bindings-tests after r153532, r153537. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: ASSIGNED Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mark.lam at apple.com CC: ggaren at apple.com, simon.fraser at apple.com, barraclough at apple.com r153532, r153537 changed the generated bindings code. We should update the expected test results so that the WebCore bindings test will pass. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:04:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:04:34 -0700 Subject: [Webkit-unassigned] [Bug 119410] Fixed expected test results for run-bindings-tests after r153532, r153537. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119410 --- Comment #1 from Mark Lam 2013-08-01 14:04:18 PST --- The bindings generation code was changed in https://bugs.webkit.org/show_bug.cgi?id=119343. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:07:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:07:39 -0700 Subject: [Webkit-unassigned] [Bug 119410] Fixed expected test results for run-bindings-tests after r153532, r153537. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119410 Mark Lam changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |mark.lam at apple.com |kit.org | Attachment #207951| |review? Flag| | --- Comment #2 from Mark Lam 2013-08-01 14:07:23 PST --- Created an attachment (id=207951) --> (https://bugs.webkit.org/attachment.cgi?id=207951&action=review) the patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:14:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:14:02 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #35 from Michael Saboff 2013-08-01 14:13:45 PST --- Ossy, the disassembly you provided seems reasonable. Below is what my ARM build produces. In both cases, the results of cgi_vm_throw_slowpath are left in r0:r1. JavaScriptCore`cti_vm_throw_slowpath: 0x35b318: push {r7, lr} 0x35b31a: mov r7, sp 0x35b31c: sub sp, #32 0x35b31e: str r0, [sp, #28] 0x35b320: bl 0x19a310 ; JSC::ExecState::codeBlock() const 0x35b324: bl 0x198a60 ; JSC::CodeBlock::vm() 0x35b328: str r0, [sp, #24] 0x35b32a: ldr r1, [sp, #28] 0x35b32c: movw r2, #18808 0x35b330: str r1, [r0, r2] 0x35b332: ldr r0, [sp, #24] 0x35b334: ldr r2, [sp, #28] 0x35b336: movw r1, #22496 0x35b33a: add r1, r0 0x35b33c: vldr d16, [r1] 0x35b340: vstr d16, [sp, #8] 0x35b344: ldr r3, [sp, #8] 0x35b346: ldr r1, [sp, #12] 0x35b348: mov r9, sp 0x35b34a: str.w r1, [r9] 0x35b34e: add r1, sp, #16 0x35b350: str r0, [sp, #4] 0x35b352: mov r0, r1 0x35b354: ldr r1, [sp, #4] 0x35b356: bl 0x34324c ; JSC::jitThrowNew(JSC::VM*, JSC::ExecState*, JSC::JSValue) 0x35b35a: ldr r0, [sp, #16] 0x35b35c: ldr r1, [sp, #20] 0x35b35e: bl 0x3430bc ; JSC::encode(JSC::ExceptionHandler) 0x35b362: add sp, #32 0x35b364: pop {r7, pc} 0x35b366: nop JavaScriptCore`JSC::encode(JSC::ExceptionHandler): 0x3430bc: sub sp, #16 0x3430be: str r0, [sp, #8] 0x3430c0: str r1, [sp, #12] 0x3430c2: vldr d16, [sp, #8] 0x3430c6: vstr d16, [sp] 0x3430ca: ldr r0, [sp] 0x3430cc: ldr r1, [sp, #4] 0x3430ce: add sp, #16 0x3430d0: bx lr Please provide a stack trace for one of the failures and the disassembly of ctiVMThrowTrampolineSlowpath. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:24:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:24:36 -0700 Subject: [Webkit-unassigned] [Bug 113058] REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113058 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196466|review+, commit-queue+ | Flag| | --- Comment #14 from WebKit Commit Bot 2013-08-01 14:24:19 PST --- (From update of attachment 196466) Clearing flags on attachment: 196466 Committed r153608: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:24:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:24:40 -0700 Subject: [Webkit-unassigned] [Bug 113058] REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113058 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #15 from WebKit Commit Bot 2013-08-01 14:24:22 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:35:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:35:41 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207942|0 |1 is obsolete| | Attachment #207942|commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:35:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:35:45 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207953| |review? Flag| | --- Comment #19 from Ruth Fong 2013-08-01 14:35:29 PST --- Created an attachment (id=207953) --> (https://bugs.webkit.org/attachment.cgi?id=207953&action=review) Patch don't need header because not using SPI methods declared in the header -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:37:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:37:14 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |beidson at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:42:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:42:02 -0700 Subject: [Webkit-unassigned] [Bug 119395] Crash in JSCell::methodTable under errorDescriptionForValue() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119395 --- Comment #3 from Mark Hahnenberg 2013-08-01 14:41:47 PST --- Can you give us steps to reproduce the issue? Then we can help you investigate! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:42:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:42:07 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #36 from Julien Brianceau 2013-08-01 14:41:51 PST --- (In reply to comment #27) > Created an attachment (id=207937) --> (https://bugs.webkit.org/attachment.cgi?id=207937&action=review) [details] > Patch > > Maintainers of other platforms should verify this solves the issue for them as well before the patch is committed. Ok for me too on X86 32-bit. I'll check tomorrow it's ok for sh4 architecture. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:53:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:53:41 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #37 from Michael Saboff 2013-08-01 14:53:24 PST --- I'm going to check in the latest patch as it gets most ports working again. I'll keep the bug open and can work with other port maintainers to get their ports working. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 14:56:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 14:56:51 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #38 from Michael Saboff 2013-08-01 14:56:34 PST --- Committed r153612: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 15:02:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 15:02:22 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207953|0 |1 is obsolete| | Attachment #207953|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 15:02:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 15:02:28 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207957| |review? Flag| | --- Comment #20 from Ruth Fong 2013-08-01 15:02:11 PST --- Created an attachment (id=207957) --> (https://bugs.webkit.org/attachment.cgi?id=207957&action=review) Patch added space -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 15:05:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 15:05:04 -0700 Subject: [Webkit-unassigned] [Bug 119412] New: Lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins() Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119412 Summary: Lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins() Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Plug-ins AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.fraser at apple.com CC: andersca at apple.com I ran run-webkit-tests --debug --leaks -2 LayoutTests/compositing/ and got lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins() -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 15:05:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 15:05:23 -0700 Subject: [Webkit-unassigned] [Bug 119412] Lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119412 --- Comment #1 from Simon Fraser (smfr) 2013-08-01 15:05:07 PST --- Created an attachment (id=207958) --> (https://bugs.webkit.org/attachment.cgi?id=207958&action=review) Leaks -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 15:07:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 15:07:05 -0700 Subject: [Webkit-unassigned] [Bug 119412] Lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119412 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrowe at apple.com, | |simon.fraser at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 15:16:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 15:16:13 -0700 Subject: [Webkit-unassigned] [Bug 119412] Lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119412 --- Comment #2 from Mark Rowe (bdash) 2013-08-01 15:15:57 PST --- Oh hey, I totally have a patch sitting in my tree that fixes this! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 15:17:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 15:17:20 -0700 Subject: [Webkit-unassigned] [Bug 119412] Lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119412 Anders Carlsson changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |andersca at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 15:48:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 15:48:30 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ossy at webkit.org --- Comment #2 from Seokju Kwon 2013-08-01 15:48:14 PST --- @Ossy Could you please take a look at this? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:18:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:18:30 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 --- Comment #21 from Daniel Bates 2013-08-01 17:18:13 PST --- (From update of attachment 207957) View in context: https://bugs.webkit.org/attachment.cgi?id=207957&action=review > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:150 > + return self; Nit: The indentation is off here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:21:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:21:33 -0700 Subject: [Webkit-unassigned] [Bug 119416] New: REGRESSION (r130783): Scrolling is broken going back to a cached page from a page that still has outstanding subresources Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119416 Summary: REGRESSION (r130783): Scrolling is broken going back to a cached page from a page that still has outstanding subresources Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Keywords: InRadar Severity: Normal Priority: P2 Component: Page Loading AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: beidson at apple.com REGRESSION (r130783): Scrolling is broken going back to a cached page from a page that still has outstanding sub resources This has the exact same symptom - but subtly different cause - as https://bugs.webkit.org/show_bug.cgi?id=117112 In radar as -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:22:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:22:54 -0700 Subject: [Webkit-unassigned] [Bug 119416] REGRESSION (r130783): Scrolling is broken going back to a cached page from a page that still has outstanding subresources In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119416 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.fraser at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:30:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:30:08 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Benjamin Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207957|review? |review+, commit-queue- Flag| | --- Comment #22 from Benjamin Poulain 2013-08-01 17:29:51 PST --- (From update of attachment 207957) View in context: https://bugs.webkit.org/attachment.cgi?id=207957&action=review > Source/WebKit2/Configurations/FeatureDefines.xcconfig:102 > +ENABLE_INPUT_TYPE_COLOR_POPOVER = ENABLE_INPUT_TYPE_COLOR_POPOVER; You should probably update all 4 FeatureDefines.xcconfig to avoid future confusions. > Source/WebKit2/UIProcess/WebPageProxy.cpp:1009 > + // Close popover color well when resizing window. This comment does not add value. > Source/WebKit2/UIProcess/WebPageProxy.cpp:2938 > + // A new popover color well needs to be created (and the previous one destroon each activation of a color element. The comment should be in the #ifdef. destroon? :) Aaaaaarg, an unclosed parenthesis. > Source/WebKit2/UIProcess/WebPageProxy.cpp:2940 > + m_colorPicker = nil; nil -> 0 > Source/WebKit2/UIProcess/mac/WebColorPickerMac.h:74 > + RetainPtr > m_colorPickerUI; You can remove the space between the two '>' (Yay C++ 11). > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:106 > + m_colorPickerUI = nullptr; nullptr -> nil? > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:150 > + return self; Indentation. > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:200 > + _lastChangedByUser = YES; > + return; > + } Indentation. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:35:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:35:16 -0700 Subject: [Webkit-unassigned] [Bug 119417] New: Use JITPropertyAccess to speed up access to JSCallbackObject's static value Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119417 Summary: Use JITPropertyAccess to speed up access to JSCallbackObject's static value Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: max.hong.shen at gmail.com Created an attachment (id=207970) --> (https://bugs.webkit.org/attachment.cgi?id=207970&action=review) Test case To access to JSCallbackObject's static value, JSC API needs to call JSCallbackObject::getOwnPropertySlot() first, then invokes the JSCallbackObject::getStaticValue(). The work done in getOwnPropertySlot() could be saved if we can use Baseline JIT stub (op_get_by_id_custom_stub) to call getStaticValue() directly when Baseline JIT kicks in (e.g. property access in a loop which takes 100 times). It surely can speed up the client applications that need heavy property accesses in their code. (e.g. a game app's draw function). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:40:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:40:19 -0700 Subject: [Webkit-unassigned] [Bug 119417] Use op_get_by_id_custom_stub to fast access to JSCallbackObject's static value In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119417 Yi Shen changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use JITPropertyAccess to |Use |speed up access to |op_get_by_id_custom_stub to |JSCallbackObject's static |fast access to |value |JSCallbackObject's static | |value -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:41:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:41:49 -0700 Subject: [Webkit-unassigned] [Bug 119418] New: [CSS] Introduce new structure to pass image orientation values. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119418 Summary: [CSS] Introduce new structure to pass image orientation values. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gyuyoung.kim at samsung.com As commented on https://bugs.webkit.org/show_bug.cgi?id=92330#c6, we need to consider to use new structure in order to reduce argument count. Patch is coming. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:42:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:42:13 -0700 Subject: [Webkit-unassigned] [Bug 119417] Use op_get_by_id_custom_stub to fast access to JSCallbackObject's static value In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119417 Yi Shen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207971| |review? Flag| | --- Comment #1 from Yi Shen 2013-08-01 17:41:57 PST --- Created an attachment (id=207971) --> (https://bugs.webkit.org/attachment.cgi?id=207971&action=review) proposal patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:42:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:42:15 -0700 Subject: [Webkit-unassigned] [Bug 119418] [CSS] Introduce new structure to pass image orientation values. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119418 Gyuyoung Kim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:42:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:42:31 -0700 Subject: [Webkit-unassigned] [Bug 119418] [CSS] Introduce new structure to pass image orientation values. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119418 Gyuyoung Kim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |92330 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:48:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:48:05 -0700 Subject: [Webkit-unassigned] [Bug 119417] Use op_get_by_id_custom_stub to fast access to JSCallbackObject's static value In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119417 --- Comment #2 from Yi Shen 2013-08-01 17:47:49 PST --- No JIT stub JIT stub result(ms) 1. 199 157 2. 200 155 3. 198 157 4. 198 157 5. 199 158 6. 198 158 7. 198 157 8. 197 157 9. 196 156 10. 197 156 --------------------------------------- avg 198 157 --------------------------------------------- No JIT stub JIT stub invoked times 1.getOwnPropertySlot() 1000000 100 2.getStaticValue() 1000000 1000000 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:48:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:48:42 -0700 Subject: [Webkit-unassigned] [Bug 119417] Use op_get_by_id_custom_stub to fast access to JSCallbackObject's static value In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119417 Yi Shen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ggaren at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:50:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:50:47 -0700 Subject: [Webkit-unassigned] [Bug 119417] Use op_get_by_id_custom_stub to fast access to JSCallbackObject's static value In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119417 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207971|review? |review- Flag| | --- Comment #3 from Geoffrey Garen 2013-08-01 17:50:31 PST --- (From update of attachment 207971) This isn't quite right. The API allows a client to specify an abstract hasProperty and/or getProperty callback, and that callback is allowed to return different results every time, making it incorrect to cache. Please add a test to testapi that fails for this reason with your current patch. That said, you may be able to rescue the basic idea of this optimization: You just need to modify your patch to be sure to poison all property access as uncacheable if anything in the class or prototype hierarchy specifies an abstract getProperty or hasProperty callback. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:53:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:53:07 -0700 Subject: [Webkit-unassigned] [Bug 119405] REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119405 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #3 from Geoffrey Garen 2013-08-01 17:52:51 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:53:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:53:16 -0700 Subject: [Webkit-unassigned] [Bug 119405] REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119405 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |webkit-bug-importer at group.a | |pple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:53:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:53:33 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207957|0 |1 is obsolete| | Attachment #207957|review+, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:53:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:53:38 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207972| |review? Flag| | --- Comment #23 from Ruth Fong 2013-08-01 17:53:22 PST --- Created an attachment (id=207972) --> (https://bugs.webkit.org/attachment.cgi?id=207972&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:54:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:54:57 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Benjamin Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207972|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 17:58:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 17:58:37 -0700 Subject: [Webkit-unassigned] [Bug 119419] New: [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119419 Summary: [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ruthiecftg at gmail.com In WebColorPickerMac.mm, ~WebColorPickerMac asserts to see if one of its variables is null. Instead it should check to see if its null; if not, it should properly invalidate it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 18:00:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 18:00:38 -0700 Subject: [Webkit-unassigned] [Bug 119419] [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119419 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com, | |beidson at apple.com, | |benjamin at webkit.org, | |jonlee at apple.com, | |ruthiecftg at gmail.com, | |webkit-bug-importer at group.a | |pple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 18:01:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 18:01:12 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207972| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 18:01:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 18:01:14 -0700 Subject: [Webkit-unassigned] [Bug 119419] [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119419 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Radar WebKit Bug Importer 2013-08-01 18:00:58 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 18:04:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 18:04:23 -0700 Subject: [Webkit-unassigned] [Bug 119416] REGRESSION (r130783): Scrolling is broken going back to a cached page from a page that still has outstanding subresources In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119416 Brady Eidson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |beidson at apple.com |kit.org | Attachment #207973| |review? Flag| | --- Comment #1 from Brady Eidson 2013-08-01 18:04:07 PST --- Created an attachment (id=207973) --> (https://bugs.webkit.org/attachment.cgi?id=207973&action=review) Patch v1 Uploading for EWS and review while layout tests also run locally. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 18:06:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 18:06:12 -0700 Subject: [Webkit-unassigned] [Bug 119420] New: [Forms: color] Change behavior of popover color picker on a scroll event Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119420 Summary: [Forms: color] Change behavior of popover color picker on a scroll event Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ruthiecftg at gmail.com In bug 119356, an initial patch was landed that implemented using a popover color picker. However, on scroll, the popover color picker "sticks" to the window while the page behind it is scrolled. Instead, it should probably do one of the following: - Hide the popover color picker on a scroll event (like the yellow highlighting of a "Find" search) - Disable the ability to scroll when the popover is open (like the popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119420 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 18:11:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 18:11:57 -0700 Subject: [Webkit-unassigned] [Bug 119421] New: [Forms: color] Popover color picker's well should not be drawn Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119421 Summary: [Forms: color] Popover color picker's well should not be drawn Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ruthiecftg at gmail.com In bug 119356, an initial patch implemented with a popover color picker. Currently, the color well for an element is drawn in ColorInputType:createShadowSubtree() at the WebCore level. However, the patch from bug 119356 redraws a popover color well when the element is clicked. This re-drawing of the color well should not be done and only the popover should be displayed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 18:12:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 18:12:27 -0700 Subject: [Webkit-unassigned] [Bug 119421] [Forms: color] Popover color picker's well should not be drawn In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119421 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com, | |beidson at apple.com, | |dino at apple.com, | |jonlee at apple.com, | |ruthiecftg at gmail.com, | |thorton at apple.com, | |webkit-bug-importer at group.a | |pple.com Depends on| |119356 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 18:12:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 18:12:29 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119421 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 18:12:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 18:12:55 -0700 Subject: [Webkit-unassigned] [Bug 119421] [Forms: color] Popover color picker's well should not be drawn In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119421 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Radar WebKit Bug Importer 2013-08-01 18:12:39 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 19:05:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 19:05:24 -0700 Subject: [Webkit-unassigned] [Bug 113058] REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113058 --- Comment #16 from Ryosuke Niwa 2013-08-01 19:05:03 PST --- It appears that this patch broke fast/multicol/overflow-content.html: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fmulticol%2Foverflow-content.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 19:06:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 19:06:42 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207972|review+, commit-queue+ | Flag| | --- Comment #24 from WebKit Commit Bot 2013-08-01 19:06:25 PST --- (From update of attachment 207972) Clearing flags on attachment: 207972 Committed r153633: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 19:06:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 19:06:48 -0700 Subject: [Webkit-unassigned] [Bug 119356] [Forms: color] popover color well implementation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119356 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #25 from WebKit Commit Bot 2013-08-01 19:06:31 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 19:06:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 19:06:50 -0700 Subject: [Webkit-unassigned] [Bug 119420] [Forms: color] Change behavior of popover color picker on a scroll event In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119420 Bug 119420 depends on bug 119356, which changed state. Bug 119356 Summary: [Forms: color] popover color well implementation https://bugs.webkit.org/show_bug.cgi?id=119356 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|UNCONFIRMED |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 19:06:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 19:06:51 -0700 Subject: [Webkit-unassigned] [Bug 119421] [Forms: color] Popover color picker's well should not be drawn In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119421 Bug 119421 depends on bug 119356, which changed state. Bug 119356 Summary: [Forms: color] popover color well implementation https://bugs.webkit.org/show_bug.cgi?id=119356 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|UNCONFIRMED |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 19:10:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 19:10:04 -0700 Subject: [Webkit-unassigned] [Bug 119423] New: Improve srcset parser Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119423 Summary: Improve srcset parser Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: dino at apple.com CC: webkit-bug-importer at group.apple.com Depends on: 110252 The srcset parser creates intermediate arrays of strings (multiple times). We should make a better parser than walks along the attribute value to extract the candidates. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 19:10:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 19:10:13 -0700 Subject: [Webkit-unassigned] [Bug 119423] Improve srcset parser In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119423 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Radar WebKit Bug Importer 2013-08-01 19:09:57 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 19:10:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 19:10:38 -0700 Subject: [Webkit-unassigned] [Bug 119423] Improve srcset parser In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119423 --- Comment #2 from Dean Jackson 2013-08-01 19:10:22 PST --- Note that the parser is duplicated in the preload scanner and the image element. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 19:34:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 19:34:57 -0700 Subject: [Webkit-unassigned] [Bug 113058] REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113058 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119425 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 19:35:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 19:35:00 -0700 Subject: [Webkit-unassigned] [Bug 113058] REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113058 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #17 from WebKit Commit Bot 2013-08-01 19:34:44 PST --- Re-opened since this is blocked by bug 119425 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 19:38:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 19:38:24 -0700 Subject: [Webkit-unassigned] [Bug 113058] REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113058 Bug 113058 depends on bug 119425, which changed state. Bug 119425 Summary: REGRESSION(r153608): Snorkled fast/multicol/overflow-content-expected.html (Requested by kling on #webkit). https://bugs.webkit.org/show_bug.cgi?id=119425 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 20:03:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 20:03:04 -0700 Subject: [Webkit-unassigned] [Bug 118185] Gmail reply email - Bold and Italic style get stuck In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118185 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ktf.kim at samsung.com --- Comment #40 from Ryosuke Niwa 2013-08-01 20:02:47 PST --- *** Bug 118285 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 20:04:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 20:04:22 -0700 Subject: [Webkit-unassigned] [Bug 117337] Applied background color is not retained after typing a characters In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117337 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207387|review? |review- Flag| | --- Comment #3 from Ryosuke Niwa 2013-08-01 20:04:06 PST --- (From update of attachment 207387) r- due to an inadequate test. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 20:12:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 20:12:48 -0700 Subject: [Webkit-unassigned] [Bug 119426] New: crash llint_op_catch after the FTL merge Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119426 Summary: crash llint_op_catch after the FTL merge Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: xinchao.peng at samsung.com After the FTL merge , When open webpage ,the programe happened crash .The Programe is that DISABLE_DFG , ARM_THUMB2 and Platform(GTK). Backtrace : 0 0x40245052 in llint_op_catch () from /home/view/public/pengxc/WebEngine2013/WebKit-r150045.newest/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0 No symbol table info available. #1 0x40212e30 in JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) () from /home/view/public/pengxc/WebEngine2013/WebKit-r150045.newest/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0 No symbol table info available. #2 0x40201178 in JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::JSObject*) () from /home/view/public/pengxc/WebEngine2013/WebKit-r150045.newest/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0 No symbol table info available. #3 0x402aca3e in JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) () from /home/view/public/pengxc/WebEngine2013/WebKit-r150045.newest/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0 No symbol table info available. #4 0x4133847a in WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*) () from /home/view/public/pengxc/WebEngine2013/WebKit-r150045.newest/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.0 No symbol table info available. #5 0x413387f0 in WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) () from libwebkit2gtk-3.0.so.0 No symbol table info available. #6 0x4144d166 in WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) () from libwebkit2gtk-3.0.so.0 No symbol table info available. #7 0x4155082e in WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent(WebCore::PendingScript&) () from libwebkit2gtk-3.0.so.0 No symbol table info available. #8 0x41550b10 in WebCore::HTMLScriptRunner::executeParsingBlockingScript() () from libwebkit2gtk-3.0.so.0 No symbol table info available. #9 0x41550c84 in WebCore::HTMLScriptRunner::executeParsingBlockingScripts() () from libwebkit2gtk-3.0.so.0 No symbol table info available. #10 0x415478b8 in WebCore::HTMLDocumentParser::notifyFinished(WebCore::CachedResource*) () from libwebkit2gtk-3.0.so.0 No symbol table info available. #11 0x41601958 in WebCore::CachedResource::checkNotify() () from libwebkit2gtk-3.0.so.0 No symbol table info available. #12 0x416088fa in WebCore::CachedScript::data(WTF::PassRefPtr, bool) () from libwebkit2gtk-3.0.so.0 No symbol table info available. #13 0x41637c50 in WebCore::SubresourceLoader::didFinishLoading(double) () from libwebkit2gtk-3.0.so.0 No symbol table info available. #14 0x41632018 in WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) () from libwebkit2gtk-3.0.so.0 No symbol table info available. #15 0x41b6bb1c in WebCore::readCallback(_GObject*, _GAsyncResult*, void*) () from libwebkit2gtk-3.0.so.0 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 20:20:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 20:20:28 -0700 Subject: [Webkit-unassigned] [Bug 119426] crash llint_op_catch after the FTL merge In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119426 Peng Xinchao changed: What |Removed |Added ---------------------------------------------------------------------------- Platform|Unspecified |Other OS/Version|Unspecified |Linux -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 20:34:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 20:34:37 -0700 Subject: [Webkit-unassigned] [Bug 89697] [JSC] CSSStyleDeclaration report incorrect descriptor In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=89697 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ggaren at apple.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 21:20:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 21:20:48 -0700 Subject: [Webkit-unassigned] [Bug 89697] [JSC] CSSStyleDeclaration report incorrect descriptor In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=89697 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204064|review? |review- Flag| | --- Comment #4 from Geoffrey Garen 2013-08-01 21:20:31 PST --- (From update of attachment 204064) Removing ReadOnly and DontEnum here is good. But let's keep DontDelete (configurable: true) for now, Since the property isn't delete-able, that's the most honest thing to report. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 21:38:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 21:38:27 -0700 Subject: [Webkit-unassigned] [Bug 96348] Texts with monospace font are incorrectly chosen when lang=zh In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=96348 Chen Zhixiang changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chenzx at cn.fujitsu.com --- Comment #2 from Chen Zhixiang 2013-08-01 21:38:11 PST --- Hi, this bug seems also affecting element's render behavor in WinCE port. since 's default html.css setting is "font-family: monospace", its font-size should be displayed smaller, but not. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 21:59:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 21:59:51 -0700 Subject: [Webkit-unassigned] [Bug 119430] New: Make diagnosing bugs in frame load transitions easier (Better logging and assertions) Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119430 Summary: Make diagnosing bugs in frame load transitions easier (Better logging and assertions) Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Page Loading AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: beidson at apple.com CC: simon.fraser at apple.com Make diagnosing bugs in frame load transitions easier (Better logging and assertions) Requested in https://bugs.webkit.org/show_bug.cgi?id=119416, which was a subtle variant of https://bugs.webkit.org/show_bug.cgi?id=117112 There are UIProcess-side ASSERTs that capture these types of issues, but they should be in the WebProcess-side. Also the logging about frame load state transitions should be bulked up enough to describe what's going on. This includes the URL transitioning from, the URL transitioning to, the current state, the state being changed to, and the driver behind a transition (when available) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 22:39:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 22:39:58 -0700 Subject: [Webkit-unassigned] [Bug 119431] New: A script on specific page causes a whole-browser crash Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119431 Summary: A script on specific page causes a whole-browser crash Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel URL: http://www.theverge.com/2013/8/1/4578890/this-is-the-m oto-x OS/Version: Mac OS X 10.8 Status: UNCONFIRMED Severity: Major Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: nick at nickheer.com Created an attachment (id=207981) --> (https://bugs.webkit.org/attachment.cgi?id=207981&action=review) Crash log I'm not Javascript-savvy enough to figure out what is causing this crash, but midway through loading this specific URL, the browser crashes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 22:57:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 22:57:04 -0700 Subject: [Webkit-unassigned] [Bug 119423] Improve srcset parser In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119423 Syoichi Tsuyuhara changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |syoichi at outlook.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:00:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:00:23 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #39 from Csaba Osztrogonac 2013-08-01 23:00:06 PST --- (In reply to comment #35) > Please provide a stack trace for one of the failures and the disassembly of ctiVMThrowTrampolineSlowpath. Here is the disassembly: 00174628 : 174628: 4628 mov r0, r5 17462a: f005 fbcd bl 179dc8 17462e: f8dd b05c ldr.w fp, [sp, #92] ; 0x5c 174632: f8dd a058 ldr.w sl, [sp, #88] ; 0x58 174636: f8dd 9054 ldr.w r9, [sp, #84] ; 0x54 17463a: f8dd 8050 ldr.w r8, [sp, #80] ; 0x50 17463e: 9f13 ldr r7, [sp, #76] ; 0x4c 174640: 9e12 ldr r6, [sp, #72] ; 0x48 174642: 9d11 ldr r5, [sp, #68] ; 0x44 174644: 9c10 ldr r4, [sp, #64] ; 0x40 174646: f8dd e03c ldr.w lr, [sp, #60] ; 0x3c 17464a: b01a add sp, #104 ; 0x68 17464c: 4708 bx r1 17464e: bf00 nop Unfortunately crash backtrace seems a little bit strange: (on DRT fast/js/JSON-parse-reviver.html) Program received signal SIGSEGV, Segmentation fault. 0xaf49fc38 in ?? () (gdb) bt #0 0xaf49fc38 in ?? () #1 0xaf49fc38 in ?? () Backtrace stopped: previous frame identical to this frame (corrupt stack?) On run-javascriptcore-tests there isn't any crash, but simple fails, I'll attach the actual.html, it might help. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:01:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:01:03 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #40 from Csaba Osztrogonac 2013-08-01 23:00:45 PST --- Created an attachment (id=207983) --> (https://bugs.webkit.org/attachment.cgi?id=207983&action=review) jsc test result on ARM -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:06:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:06:10 -0700 Subject: [Webkit-unassigned] [Bug 96348] Texts with monospace font are incorrectly chosen when lang=zh In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=96348 --- Comment #3 from Chen Zhixiang 2013-08-01 23:05:53 PST --- settings->setDefaultFixedFontSize(10); My problem resolved. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:19:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:19:14 -0700 Subject: [Webkit-unassigned] [Bug 117265] Spatial Navigation should avoid unwanted calculation while deciding focus candidate. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117265 Abhijeet Kandalkar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206329|0 |1 is obsolete| | Attachment #207984| |review?, commit-queue? Flag| | --- Comment #11 from Abhijeet Kandalkar 2013-08-01 23:18:56 PST --- Created an attachment (id=207984) --> (https://bugs.webkit.org/attachment.cgi?id=207984&action=review) Updated patch-3 Additionally, why should the iframe itself be considered a focus candidate? 1. node->isKeyboardFocusable(event) if node is IFrame returns true. 2. If we have Iframes in html page then Navigation alogorithm considers it as focusable element. if (HTMLFrameOwnerElement* frameElement = frameOwnerElement(focusCandidate)) { // consider Iframe as container and search best candidate node in Iframe(container). } -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:36:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:36:00 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #41 from Michael Saboff 2013-08-01 23:35:44 PST --- (In reply to comment #39) > (In reply to comment #35) > > Please provide a stack trace for one of the failures and the disassembly of ctiVMThrowTrampolineSlowpath. > > Here is the disassembly: > 00174628 : > 174628: 4628 mov r0, r5 > 17462a: f005 fbcd bl 179dc8 > 17462e: f8dd b05c ldr.w fp, [sp, #92] ; 0x5c > 174632: f8dd a058 ldr.w sl, [sp, #88] ; 0x58 > 174636: f8dd 9054 ldr.w r9, [sp, #84] ; 0x54 > 17463a: f8dd 8050 ldr.w r8, [sp, #80] ; 0x50 > 17463e: 9f13 ldr r7, [sp, #76] ; 0x4c > 174640: 9e12 ldr r6, [sp, #72] ; 0x48 > 174642: 9d11 ldr r5, [sp, #68] ; 0x44 > 174644: 9c10 ldr r4, [sp, #64] ; 0x40 > 174646: f8dd e03c ldr.w lr, [sp, #60] ; 0x3c > 17464a: b01a add sp, #104 ; 0x68 > 17464c: 4708 bx r1 > 17464e: bf00 nop I'm not sure we need to restore from the stack, but we certainly need to move r0 into the callFrameRegister, r5. I'll have a patch to try in a few minutes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:39:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:39:53 -0700 Subject: [Webkit-unassigned] [Bug 119432] New: Remove redundant call of argsList->current() from loops in CSSParser Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119432 Summary: Remove redundant call of argsList->current() from loops in CSSParser Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: bw80.lee at samsung.com while loops in CSSParser call argList->current() function at the start of each iteration, but this is redundant because argsList->next() at the end of the iteration calls the argList->current() and returns the result. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:40:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:40:51 -0700 Subject: [Webkit-unassigned] [Bug 119432] Remove redundant call of argsList->current() from loops in CSSParser In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119432 --- Comment #1 from Byungwoo Lee 2013-08-01 23:40:35 PST --- blink merge from : https://src.chromium.org/viewvc/blink?view=rev&revision=155402 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:42:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:42:24 -0700 Subject: [Webkit-unassigned] [Bug 119432] Remove redundant call of argsList->current() from loops in CSSParser In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119432 Gyuyoung Kim changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |BlinkMergeCandidate CC| |gyuyoung.kim at samsung.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:44:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:44:05 -0700 Subject: [Webkit-unassigned] [Bug 113058] REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113058 --- Comment #18 from Morten Stenshorne 2013-08-01 23:43:47 PST --- See bug 113781. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:47:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:47:44 -0700 Subject: [Webkit-unassigned] [Bug 119432] Remove redundant call of argsList->current() from loops in CSSParser In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119432 Byungwoo Lee changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |bw80.lee at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:55:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:55:21 -0700 Subject: [Webkit-unassigned] [Bug 119433] New: REGRESSION: ARM Still crashes after change set r153612 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 Summary: REGRESSION: ARM Still crashes after change set r153612 Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: All Status: NEW Severity: Blocker Priority: P1 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: msaboff at apple.com CC: allan.jensen at digia.com, ggaren at apple.com, oliver at apple.com, hausmann at webkit.org, loki at webkit.org, barraclough at apple.com, zherczeg at webkit.org, ossy at webkit.org, zandobersek at gmail.com, rgabor at webkit.org, cgarcia at igalia.com, msaboff at apple.com, fpizlo at apple.com, mhahnenberg at apple.com, mark.lam at apple.com, jbrianceau at nds.com, xinchao.peng at samsung.com Depends on: 119140 The fix https://bugs.webkit.org/show_bug.cgi?id=119140 "REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer" didn't completely resolve the crashes on ARM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 1 23:55:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 1 Aug 2013 23:55:24 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Michael Saboff changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119433 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:04:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:04:57 -0700 Subject: [Webkit-unassigned] [Bug 119433] REGRESSION: ARM Still crashes after change set r153612 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 Michael Saboff changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207987| |review? Flag| | --- Comment #1 from Michael Saboff 2013-08-02 00:04:40 PST --- Created an attachment (id=207987) --> (https://bugs.webkit.org/attachment.cgi?id=207987&action=review) Patch to set callFrameRegister to value returned by cti_vm_throw_slowpath -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:06:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:06:46 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 --- Comment #42 from Michael Saboff 2013-08-02 00:06:28 PST --- Ossy, Try out the patch attached to the newly created bug https://bugs.webkit.org/show_bug.cgi?id=119433. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:13:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:13:20 -0700 Subject: [Webkit-unassigned] [Bug 119433] REGRESSION: ARM Still crashes after change set r153612 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org --- Comment #2 from WebKit Commit Bot 2013-08-02 00:13:03 PST --- Attachment 207987 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITStubsARM.h', u'Source/JavaScriptCore/jit/JITStubsARMv7.h']" exit_code: 1 Source/JavaScriptCore/jit/JITStubsARM.h:211: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:25:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:25:55 -0700 Subject: [Webkit-unassigned] [Bug 17720] unspecified width of column causes misalignment in table In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=17720 gur.trio at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gur.trio at gmail.com --- Comment #3 from gur.trio at gmail.com 2013-08-02 00:25:39 PST --- Behaviour on safari, chrome, firefox, IE8 is same. So doesnot seem to be an issue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:32:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:32:56 -0700 Subject: [Webkit-unassigned] [Bug 17801] causes image misalignment In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=17801 gur.trio at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gur.trio at gmail.com --- Comment #3 from gur.trio at gmail.com 2013-08-02 00:32:40 PST --- Firefox and safari/chrome behaviour is different. As mentioned in the content table width is zero which mozilla doesnot apply. When we see the layout of table it shows 408*608 and for other table its 416*88. Spec says "With this (fast) algorithm, the horizontal layout of the table does not depend on the contents of the cells; it only depends on the table's width, the width of the columns, and borders or cell spacing." Also http://www.w3schools.com/cssref/tryit.asp?filename=trycss_table_table-layout when we change the width of 2nd table from 100% to 0px mozilla takes the width of content i.e td rather than 0px. So seems safari/chrome is correct. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:35:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:35:25 -0700 Subject: [Webkit-unassigned] [Bug 105132] Parts of text is not rendered properly/at all. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=105132 gur.trio at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gur.trio at gmail.com --- Comment #1 from gur.trio at gmail.com 2013-08-02 00:35:09 PST --- The content has changed and so issue is not reproducible. We can close this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:51:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:51:35 -0700 Subject: [Webkit-unassigned] [Bug 119434] New: [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Summary: [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mitica at adobe.com CC: WebkitBugTracker at adobe.com From bugzilla-daemon at webkit.org Fri Aug 2 00:55:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:55:10 -0700 Subject: [Webkit-unassigned] [Bug 119433] REGRESSION: ARM Still crashes after change set r153612 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 --- Comment #3 from Csaba Osztrogonac 2013-08-02 00:54:53 PST --- I tried this patch, but unfortunately it didn't help. - ARM traditional results: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9252 - ARM Thumb2 results: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9253 I'll try to collect some debug infos a little bit later. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:56:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:56:00 -0700 Subject: [Webkit-unassigned] [Bug 113663] Missing APIs in webkit2gtk (compared to webkit1) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113663 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario at webkit.org Depends on| |114298 --- Comment #8 from Mario Sanchez Prada 2013-08-02 00:55:44 PST --- (In reply to comment #2) > [...] > They exist in WebKit1 and users might want these behaviors. > > > > - enable-spatial-navigation, > > I suppose this might be someone's preferred link navigation method? Personally, > I just use a link labeller. > Just for the sake of clarity, this feature would be interesting in environments where you don't have the usual input methods you happen to access to in environments such PCs or touch devices (e.g. smartphones, tablets..), such as TVs, where you use a remote controller to navigate around the web. It's pretty much related to bug 114298, which is pending on WK2 owners to approve the cross platform changes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:56:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:56:03 -0700 Subject: [Webkit-unassigned] [Bug 114298] [WK2][GTK] Adding SpatialNavigation setting to webkit2 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114298 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |113663 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:56:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:56:54 -0700 Subject: [Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117545 --- Comment #4 from Carlos Garcia Campos 2013-08-02 00:56:38 PST --- (From update of attachment 205012) View in context: https://bugs.webkit.org/attachment.cgi?id=205012&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:548 > + } elsif ($attribute->signature->extendedAttributes->{"ImplementedBy"}) { > + my $implementedBy = $attribute->signature->extendedAttributes->{"ImplementedBy"}; > + $implIncludes{"${implementedBy}.h"} = 1; I wonder if we can get rid of this here, since this is already done a few lines above in this function. > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:551 > + push(@txtGetProps, " g_value_set_$gtype(value, ${convertFunction}${getterFunctionName}(" . join(", ", @getterArguments) . ")${postConvertFunction});\n"); > + } else { > + push(@txtGetProps, " g_value_set_$gtype(value, ${convertFunction}${getterFunctionName}(" . join(", ", @getterArguments) . ")${postConvertFunction});\n"); I wonder why these lines are duplicated, I know it's not introduced by you, but I think this can be simplified. If we can get rid of the implemented by check this could just be } else { push(@txtGetProps, " g_value_set_$gtype(value, ${convertFunction}${getterFunctionName}(" . join(", ", @getterArguments) . ")${postConvertFunction});\n"); } -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:57:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:57:03 -0700 Subject: [Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117545 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgarcia at igalia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:57:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:57:07 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207989| |review? Flag| | --- Comment #1 from Mihai Tica 2013-08-02 00:56:51 PST --- Created an attachment (id=207989) --> (https://bugs.webkit.org/attachment.cgi?id=207989&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 00:59:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 00:59:46 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |esprehn+autocc at chromium.org | |, glenn at skynav.com, | |kondapallykalyan at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 01:05:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 01:05:53 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207989|review? |review- Flag| | --- Comment #2 from Dirk Schulze 2013-08-02 01:05:37 PST --- (From update of attachment 207989) View in context: https://bugs.webkit.org/attachment.cgi?id=207989&action=review > LayoutTests/ChangeLog:12 > + * css3/compositing/background-blend-mode-separate-layer-declaration.html: Added. > + * platform/mac/css3/compositing/background-blend-mode-separate-layer-declaration-expected.png: Added. > + * platform/mac/css3/compositing/background-blend-mode-separate-layer-declaration-expected.txt: Added. Patch looks great! Can you please use an ref test instead of an pixel test? r- until you added a ref test. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 01:06:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 01:06:04 -0700 Subject: [Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117545 --- Comment #5 from Diego Pino 2013-08-02 01:05:47 PST --- (From update of attachment 205012) View in context: https://bugs.webkit.org/attachment.cgi?id=205012&action=review >> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:551 >> + push(@txtGetProps, " g_value_set_$gtype(value, ${convertFunction}${getterFunctionName}(" . join(", ", @getterArguments) . ")${postConvertFunction});\n"); > > I wonder why these lines are duplicated, I know it's not introduced by you, but I think this can be simplified. If we can get rid of the implemented by check this could just be > > } else { > push(@txtGetProps, " g_value_set_$gtype(value, ${convertFunction}${getterFunctionName}(" . join(", ", @getterArguments) . ")${postConvertFunction});\n"); > } Correct. I agree with these suggestions. I will cook a new patch with this changes, and check the script generates the same code. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 01:11:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 01:11:38 -0700 Subject: [Webkit-unassigned] [Bug 119435] New: FrameView should have an isMainFrameView() Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119435 Summary: FrameView should have an isMainFrameView() Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: thorton at apple.com CC: simon.fraser at apple.com There's a lot of "m_frame && m_frame->page() && m_frame->page()->mainFrame() == m_frame". Also I have already (maybe twice) made the mistake of not doing the requisite null-checks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 01:13:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 01:13:45 -0700 Subject: [Webkit-unassigned] [Bug 119435] FrameView should have an isMainFrameView() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119435 Tim Horton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207992| |review? Flag| | --- Comment #1 from Tim Horton 2013-08-02 01:13:28 PST --- Created an attachment (id=207992) --> (https://bugs.webkit.org/attachment.cgi?id=207992&action=review) patch Maybe there's some compelling reason that we haven't done this before? I don't know, but I'd love to! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 01:15:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 01:15:43 -0700 Subject: [Webkit-unassigned] [Bug 119436] New: [curl] Better SSL certificate handling Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119436 Summary: [curl] Better SSL certificate handling Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: sipka at inf.u-szeged.hu CC: galpeter at inf.u-szeged.hu, davidsz at inf.u-szeged.hu Created an attachment (id=207993) --> (https://bugs.webkit.org/attachment.cgi?id=207993&action=review) First draft Enable SSL verification when we have a way of shipping certs and/or reporting SSL errors to the user. The certificate verification result reported for the user. The enabled domains are stored in a non-persistent way and the certificate are saved into a pem format file. Future plan is to stop the communication until the user gives an answer to enable or disable those sites, which have invalid certificates and separate the enable domains and save function of the certs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 01:22:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 01:22:41 -0700 Subject: [Webkit-unassigned] [Bug 119433] REGRESSION: ARM Still crashes after change set r153612 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207994| |review? Flag| | --- Comment #4 from Julien Brianceau 2013-08-02 01:22:23 PST --- Created an attachment (id=207994) --> (https://bugs.webkit.org/attachment.cgi?id=207994&action=review) ctiVMThrowTrampolineSlowpath fix for ARM and ARMv7 architectures. I think this would work better. This patch is similar to what I've done for sh4 architecture (in http://trac.webkit.org/changeset/153583). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 01:25:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 01:25:25 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 --- Comment #3 from Mihai Tica 2013-08-02 01:25:10 PST --- (In reply to comment #2) > (From update of attachment 207989 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207989&action=review > > > LayoutTests/ChangeLog:12 > > + * css3/compositing/background-blend-mode-separate-layer-declaration.html: Added. > > + * platform/mac/css3/compositing/background-blend-mode-separate-layer-declaration-expected.png: Added. > > + * platform/mac/css3/compositing/background-blend-mode-separate-layer-declaration-expected.txt: Added. > > Patch looks great! Can you please use an ref test instead of an pixel test? r- until you added a ref test. The bug isn't showing up when specifying background-image with an SVG. Instead, the problem seems to be related only to opaque images, so I'm guessing we can't add a ref test. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 02:12:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 02:12:03 -0700 Subject: [Webkit-unassigned] [Bug 119435] FrameView should have an isMainFrameView() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119435 Zalan Bujtas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zalan at apple.com --- Comment #2 from Zalan Bujtas 2013-08-02 02:11:47 PST --- Yay. I wanted to do this for such a long time :) (I was a bit hesitant though, whether WebCore::Frame should have an isMainFrame() function instead (copy what WK2 already has) and use that in FrameView (and in other classes)) Anyway there are a few more places where you check for isMainFrameView() FrameView::setFrameRect() FrameView::performPostLayoutTasks() FrameView::pagination() FrameView::paintOverhangAreas() -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 03:22:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 03:22:34 -0700 Subject: [Webkit-unassigned] [Bug 119435] FrameView should have an isMainFrameView() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119435 --- Comment #3 from Tim Horton 2013-08-02 03:22:18 PST --- (In reply to comment #2) > Yay. I wanted to do this for such a long time :) (I was a bit hesitant though, whether WebCore::Frame should have an isMainFrame() function instead (copy what WK2 already has) and use that in FrameView (and in other classes)) > > Anyway there are a few more places where you check for isMainFrameView() > > FrameView::setFrameRect() > FrameView::performPostLayoutTasks() > FrameView::pagination() > FrameView::paintOverhangAreas() There are even more than that! I will post a new patch in a moment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 03:26:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 03:26:59 -0700 Subject: [Webkit-unassigned] [Bug 119435] FrameView should have an isMainFrameView() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119435 Tim Horton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207992|0 |1 is obsolete| | Attachment #207992|review? | Flag| | Attachment #207997| |review? Flag| | --- Comment #4 from Tim Horton 2013-08-02 03:26:42 PST --- Created an attachment (id=207997) --> (https://bugs.webkit.org/attachment.cgi?id=207997&action=review) more places -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 04:27:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 04:27:02 -0700 Subject: [Webkit-unassigned] [Bug 117265] Spatial Navigation should avoid unwanted calculation while deciding focus candidate. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117265 Abhijeet Kandalkar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207984|0 |1 is obsolete| | Attachment #207984|review?, commit-queue? | Flag| | Attachment #208002| |review?, commit-queue? Flag| | --- Comment #12 from Abhijeet Kandalkar 2013-08-02 04:26:44 PST --- Created an attachment (id=208002) --> (https://bugs.webkit.org/attachment.cgi?id=208002&action=review) Updated patch-4 Please refer latest "Updated patch-4" changes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 04:33:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 04:33:14 -0700 Subject: [Webkit-unassigned] [Bug 119405] REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119405 Csaba Osztrogonac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abrhm at inf.u-szeged.hu, | |kadam at inf.u-szeged.hu, | |zarvai at inf.u-szeged.hu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 04:55:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 04:55:40 -0700 Subject: [Webkit-unassigned] [Bug 114298] [WK2][GTK] Adding SpatialNavigation setting to webkit2 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114298 Danilo Cesar Lemes de Paula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200077|0 |1 is obsolete| | Attachment #200077|review?, commit-queue? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 04:57:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 04:57:01 -0700 Subject: [Webkit-unassigned] [Bug 114298] [WK2][GTK] Adding SpatialNavigation setting to webkit2 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114298 Danilo Cesar Lemes de Paula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208003| |review? Flag| | --- Comment #35 from Danilo Cesar Lemes de Paula 2013-08-02 04:56:44 PST --- Created an attachment (id=208003) --> (https://bugs.webkit.org/attachment.cgi?id=208003&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 04:58:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 04:58:27 -0700 Subject: [Webkit-unassigned] [Bug 114298] [WK2][GTK] Adding SpatialNavigation setting to webkit2 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114298 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dchris at gmail.com, | |gyuyoung.kim at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 05:19:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 05:19:19 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207900|0 |1 is obsolete| | Attachment #207900|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 05:19:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 05:19:28 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208005| |review? Flag| | --- Comment #10 from Mihai Tica 2013-08-02 05:19:12 PST --- Created an attachment (id=208005) --> (https://bugs.webkit.org/attachment.cgi?id=208005&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 05:21:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 05:21:16 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 --- Comment #11 from Mihai Tica 2013-08-02 05:21:00 PST --- (In reply to comment #10) > Created an attachment (id=208005) --> (https://bugs.webkit.org/attachment.cgi?id=208005&action=review) [details] > Patch Ok, there shouldn't be any more pixel tests with this patch, can you please have another look? Thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 05:33:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 05:33:55 -0700 Subject: [Webkit-unassigned] [Bug 119395] Crash in JSCell::methodTable under errorDescriptionForValue() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119395 --- Comment #4 from peavo at outlook.com 2013-08-02 05:33:39 PST --- (In reply to comment #3) > Can you give us steps to reproduce the issue? Then we can help you investigate! I don't have a reduced testcase, but I'm consistently getting the crash on many sites, e.g. www.sfgate.com. I'm running on Windows (WinCairo) though, so I'm not sure you will see the same crash if you're on OSX. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 05:41:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 05:41:53 -0700 Subject: [Webkit-unassigned] [Bug 119440] New: REGRESSION(r153612): It made jsc and layout tests crash Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 Summary: REGRESSION(r153612): It made jsc and layout tests crash Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Critical Priority: P1 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ossy at webkit.org CC: ggaren at apple.com, oliver at apple.com, barraclough at apple.com, msaboff at apple.com, fpizlo at apple.com, mhahnenberg at apple.com, mark.lam at apple.com Blocks: 119140 After http://trac.webkit.org/changeset/153612 jsc and layout tests started to crash on 64 bit bit in debug mode. (at least on Qt) Here is a GDB backtrace on r153636: gdb --args ../../../../WebKitBuild/Debug/bin/jsc -s -f ./ecma/shell.js -f ./ecma/Boolean/15.6.4.2-4-n.js GNU gdb (Ubuntu/Linaro 7.4-2012.04-0ubuntu2.1) 7.4-2012.04 Copyright (C) 2012 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". For bug reporting instructions, please see: ... Reading symbols from /home/webkitbuildbot/oszi/WebKit/WebKitBuild/Debug/bin/jsc...done. (gdb) run Starting program: /home/webkitbuildbot/oszi/WebKit/WebKitBuild/Debug/bin/jsc -s -f ./ecma/shell.js -f ./ecma/Boolean/15.6.4.2-4-n.js [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". [New Thread 0x7fffb4309700 (LWP 29393)] [New Thread 0x7fffb3ae9700 (LWP 29394)] [New Thread 0x7fffb32e8700 (LWP 29395)] [New Thread 0x7fffb2ae7700 (LWP 29396)] [New Thread 0x7fffb22e6700 (LWP 29397)] [New Thread 0x7fffb1ae5700 (LWP 29398)] [New Thread 0x7fffb12e4700 (LWP 29399)] 15.6.4.2-4-n Boolean.prototype.toString() Program received signal SIGSEGV, Segmentation fault. 0x00007fffb06e4160 in ?? () (gdb) bt #0 0x00007fffb06e4160 in ?? () #1 0x00007fffffffb550 in ?? () #2 0x000000000068efcb in JSC::JSStack::installTrapsAfterFrame (this=0x0, frame=0x0) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/interpreter/JSStackInlines.h:212 #3 0x00000000006a0682 in JSC::JITCode::execute (this=0x1024bb0, stack=0xff2668, callFrame=0x7fffb06e4160, vm=0xfe1730) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/jit/JITCode.cpp:46 #4 0x000000000068c9e3 in JSC::Interpreter::execute (this=0xff2650, eval=0x7ffff7e3fdf0, callFrame=0x7fffb06e4108, thisValue=..., scope=0x7fffb05fffc8) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/interpreter/Interpreter.cpp:1208 #5 0x0000000000687609 in JSC::eval (callFrame=0x7fffb06e4108) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/interpreter/Interpreter.cpp:148 #6 0x00000000006dace6 in JSC::LLInt::llint_slow_path_call_eval (exec=0x7fffb06e40a0, pc=0x1026fc8) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1109 #7 0x0000000000ab5737 in llint_op_call_eval () #8 0x00007fffffffca80 in ?? () #9 0x000000000068efcb in JSC::JSStack::installTrapsAfterFrame (this=0x0, frame=0x0) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/interpreter/JSStackInlines.h:212 #10 0x00000000006a0682 in JSC::JITCode::execute (this=0x101c760, stack=0xff2668, callFrame=0x7fffb06e4058, vm=0xfe1730) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/jit/JITCode.cpp:46 #11 0x000000000068af4f in JSC::Interpreter::execute (this=0xff2650, program=0x7ffff7e3fe70, callFrame=0x7ffff7f7f8e0, thisObj=0x7ffff7e7feb0) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/interpreter/Interpreter.cpp:856 #12 0x00000000007728fd in JSC::evaluate (exec=0x7ffff7f7f8e0, source=..., thisValue=..., returnedException=0x7fffffffe080) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/runtime/Completion.cpp:83 #13 0x000000000040ff8c in runWithScripts (globalObject=0x7ffff7f7f870, scripts=..., dump=false) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/jsc.cpp:596 #14 0x0000000000410c97 in jscmain (argc=6, argv=0x7fffffffe348) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/jsc.cpp:812 #15 0x000000000040fd68 in main (argc=6, argv=0x7fffffffe348) at /home/webkitbuildbot/oszi/WebKit/Source/JavaScriptCore/jsc.cpp:554 (gdb) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 05:41:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 05:41:55 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Csaba Osztrogonac changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119440 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 05:42:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 05:42:46 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 Csaba Osztrogonac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ossy at webkit.org --- Comment #1 from Csaba Osztrogonac 2013-08-02 05:42:29 PST --- r153611: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/29901 r153612: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/29888 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 05:45:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 05:45:08 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 Csaba Osztrogonac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abrhm at inf.u-szeged.hu, | |kadam at inf.u-szeged.hu, | |zarvai at inf.u-szeged.hu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 05:48:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 05:48:10 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 --- Comment #2 from Csaba Osztrogonac 2013-08-02 05:47:53 PST --- +info: - pass with disabled JIT - fail with enabled JIT + enabled DFG JIT - fail with enabled JIT + disabled DFG JIT -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 05:56:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 05:56:27 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbrianceau at nds.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:01:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:01:48 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 --- Comment #3 from Csaba Osztrogonac 2013-08-02 06:01:32 PST --- Some related disassembly: 00000000006c4023 : 6c4023: 55 push %rbp 6c4024: 48 89 e5 mov %rsp,%rbp 6c4027: 48 83 ec 40 sub $0x40,%rsp 6c402b: 48 89 7d d8 mov %rdi,-0x28(%rbp) 6c402f: 48 8b 45 d8 mov -0x28(%rbp),%rax 6c4033: 48 89 c7 mov %rax,%rdi 6c4036: e8 63 2a d9 ff callq 456a9e 6c403b: 48 89 c7 mov %rax,%rdi 6c403e: e8 ab 02 dc ff callq 4842ee 6c4043: 48 89 45 f8 mov %rax,-0x8(%rbp) 6c4047: 48 8b 45 f8 mov -0x8(%rbp),%rax 6c404b: 48 8b 55 d8 mov -0x28(%rbp),%rdx 6c404f: 48 89 90 80 90 00 00 mov %rdx,0x9080(%rax) 6c4056: 48 8b 45 f8 mov -0x8(%rbp),%rax 6c405a: 48 8b 90 50 aa 00 00 mov 0xaa50(%rax),%rdx 6c4061: 48 8b 4d d8 mov -0x28(%rbp),%rcx 6c4065: 48 8b 45 f8 mov -0x8(%rbp),%rax 6c4069: 48 89 ce mov %rcx,%rsi 6c406c: 48 89 c7 mov %rax,%rdi 6c406f: e8 4b 5b fe ff callq 6a9bbf 6c4074: 48 89 c1 mov %rax,%rcx 6c4077: 48 89 d0 mov %rdx,%rax 6c407a: 48 89 4d c0 mov %rcx,-0x40(%rbp) 6c407e: 48 89 45 c8 mov %rax,-0x38(%rbp) 6c4082: 48 8b 45 c0 mov -0x40(%rbp),%rax 6c4086: 48 89 45 e0 mov %rax,-0x20(%rbp) 6c408a: 48 8b 45 c8 mov -0x38(%rbp),%rax 6c408e: 48 89 45 e8 mov %rax,-0x18(%rbp) 6c4092: 48 8b 55 e0 mov -0x20(%rbp),%rdx 6c4096: 48 8b 45 e8 mov -0x18(%rbp),%rax 6c409a: 48 89 d7 mov %rdx,%rdi 6c409d: 48 89 c6 mov %rax,%rsi 6c40a0: e8 33 59 fe ff callq 6a99d8 6c40a5: c9 leaveq 6c40a6: c3 retq 00000000006a99d8 : 6a99d8: 55 push %rbp 6a99d9: 48 89 e5 mov %rsp,%rbp 6a99dc: 48 89 fa mov %rdi,%rdx 6a99df: 48 89 f0 mov %rsi,%rax 6a99e2: 48 89 55 e0 mov %rdx,-0x20(%rbp) 6a99e6: 48 89 45 e8 mov %rax,-0x18(%rbp) 6a99ea: 48 8b 45 e0 mov -0x20(%rbp),%rax 6a99ee: 48 89 45 f0 mov %rax,-0x10(%rbp) 6a99f2: 48 8b 45 e8 mov -0x18(%rbp),%rax 6a99f6: 48 89 45 f8 mov %rax,-0x8(%rbp) 6a99fa: 48 8b 45 f0 mov -0x10(%rbp),%rax 6a99fe: 5d pop %rbp 6a99ff: c3 retq 00000000006bc3fa : 6bc3fa: 4c 89 ef mov %r13,%rdi 6bc3fd: e8 21 7c 00 00 callq 6c4023 6bc402: ff e2 jmpq *%rdx -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:09:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:09:00 -0700 Subject: [Webkit-unassigned] [Bug 119433] REGRESSION: ARM Still crashes after change set r153612 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 --- Comment #5 from Csaba Osztrogonac 2013-08-02 06:08:43 PST --- (In reply to comment #4) > Created an attachment (id=207994) --> (https://bugs.webkit.org/attachment.cgi?id=207994&action=review) [details] > ctiVMThrowTrampolineSlowpath fix for ARM and ARMv7 architectures. > > I think this would work better. This patch is similar to what I've done for sh4 architecture (in http://trac.webkit.org/changeset/153583). It seems it works: - ARM Thumb2: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9254 (still runs ...) - ARM Traditional: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9255 (will start in an hour ...) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:27:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:27:30 -0700 Subject: [Webkit-unassigned] [Bug 99065] [GStreamer] Add support for Media Source API In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99065 Philippe Normand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206381|review? |review- Flag| | --- Comment #23 from Philippe Normand 2013-08-02 06:27:12 PST --- (From update of attachment 206381) r- as per review comments. Looking forward the next iteration! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:36:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:36:25 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Michael Saboff changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119441 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:37:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:37:16 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 --- Comment #4 from Michael Saboff 2013-08-02 06:36:59 PST --- *** Bug 119441 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:37:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:37:17 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Bug 119140 depends on bug 119441, which changed state. Bug 119441 Summary: REGRESSION: Change set r153612 breaks 64 bit builds https://bugs.webkit.org/show_bug.cgi?id=119441 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |DUPLICATE Status|ASSIGNED |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:38:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:38:50 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 Michael Saboff changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208008| |review?, commit-queue? Flag| | --- Comment #5 from Michael Saboff 2013-08-02 06:38:33 PST --- Created an attachment (id=208008) --> (https://bugs.webkit.org/attachment.cgi?id=208008&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:41:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:41:51 -0700 Subject: [Webkit-unassigned] [Bug 119443] New: Introduce toSVGMaskElement(), and use it Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119443 Summary: Introduce toSVGMaskElement(), and use it Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: SVG AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gyuyoung.kim at samsung.com CC: zimmermann at kde.org As a step to change static_cast with toSVGXXX, static_cast can be changed with toSVGMaskElement(). Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=155432 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:43:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:43:07 -0700 Subject: [Webkit-unassigned] [Bug 119443] Introduce toSVGMaskElement(), and use it In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119443 Gyuyoung Kim changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |gyuyoung.kim at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:46:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:46:53 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207832|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:49:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:49:05 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 --- Comment #6 from Julien Brianceau 2013-08-02 06:48:47 PST --- LGTM: - run-javascriptcore-tests is OK on X86 64-bit release build - run-javascriptcore-tests is OK on X86 64-bit debug build - run-javascriptcore-tests is OK on X86 32-bit release build - run-javascriptcore-tests is OK on X86 32-bit debug build -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:50:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:50:29 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 Csaba Osztrogonac changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208008|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #7 from Csaba Osztrogonac 2013-08-02 06:50:13 PST --- (From update of attachment 208008) LGTM, r=me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:51:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:51:48 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:54:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:54:59 -0700 Subject: [Webkit-unassigned] [Bug 119444] New: Buildfix for !ENABLE(SVG) platforms after r153581 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119444 Summary: Buildfix for !ENABLE(SVG) platforms after r153581 Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: zarvai at inf.u-szeged.hu CC: allan.jensen at digia.com, ossy at webkit.org, akling at apple.com, alexis at webkit.org Blocks: 117715 Patch is coming soon. /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp: In function ?const WebCore::StylePropertyShorthand& WebCore::markerShorthand()?: /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:236:9: error: ?CSSPropertyMarkerStart? was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:237:9: error: ?CSSPropertyMarkerMid? was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:238:9: error: ?CSSPropertyMarkerEnd? was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:240:5: error: ?CSSPropertyMarker? was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp: In function ?const WTF::Vector WebCore::matchingShorthandsForLonghand(WebCore::CSSPropertyID)?: /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:769:17: error: ?CSSPropertyMarkerStart? was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:770:17: error: ?CSSPropertyMarkerMid? was not declared in this scope /ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/StylePropertyShorthand.cpp:771:17: error: ?CSSPropertyMarkerEnd? was not declared in this scope These are generated from SVGCSSPropertyNames.in that guarded by ENABLE_SVG. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:55:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:55:53 -0700 Subject: [Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117545 Diego Pino changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205012|0 |1 is obsolete| | Attachment #205012|review?, commit-queue? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:56:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:56:02 -0700 Subject: [Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117545 Diego Pino changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208011| |review?, commit-queue? Flag| | --- Comment #6 from Diego Pino 2013-08-02 06:55:45 PST --- Created an attachment (id=208011) --> (https://bugs.webkit.org/attachment.cgi?id=208011&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:58:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:58:12 -0700 Subject: [Webkit-unassigned] [Bug 119444] Buildfix for !ENABLE(SVG) platforms after r153581 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119444 Zoltan Arvai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208012| |review?, commit-queue? Flag| | --- Comment #1 from Zoltan Arvai 2013-08-02 06:57:55 PST --- Created an attachment (id=208012) --> (https://bugs.webkit.org/attachment.cgi?id=208012&action=review) buildfix Adding guards for SVG related parts. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 06:59:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 06:59:18 -0700 Subject: [Webkit-unassigned] [Bug 119444] Buildfix for !ENABLE(SVG) platforms after r153581 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119444 Andreas Kling changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208012|review?, commit-queue? |review+, commit-queue- Flag| | --- Comment #2 from Andreas Kling 2013-08-02 06:59:02 PST --- (From update of attachment 208012) View in context: https://bugs.webkit.org/attachment.cgi?id=208012&action=review r=me > Source/WebCore/css/StylePropertyShorthand.cpp:233 > +#if defined(ENABLE_SVG) && ENABLE_SVG This should just be #if ENABLE(SVG) > Source/WebCore/css/StylePropertyShorthand.cpp:769 > +#if defined(ENABLE_SVG) && ENABLE_SVG Ditto. > Source/WebCore/css/StylePropertyShorthand.h:88 > +#if defined(ENABLE_SVG) && ENABLE_SVG Ditto. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:00:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:00:04 -0700 Subject: [Webkit-unassigned] [Bug 119444] Buildfix for !ENABLE(SVG) platforms after r153581 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119444 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |esprehn+autocc at chromium.org | |, glenn at skynav.com, | |macpherson at chromium.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:02:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:02:12 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207989|0 |1 is obsolete| | Attachment #207989|review- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:02:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:02:21 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208013| |review? Flag| | --- Comment #4 from Mihai Tica 2013-08-02 07:02:05 PST --- Created an attachment (id=208013) --> (https://bugs.webkit.org/attachment.cgi?id=208013&action=review) Patch Adding reference test -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:02:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:02:44 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208013| |commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:03:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:03:43 -0700 Subject: [Webkit-unassigned] [Bug 119353] A bit messy layout on Apple webpage with WebKit In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119353 --- Comment #2 from Zalan Bujtas 2013-08-02 07:03:27 PST --- Created an attachment (id=208014) --> (https://bugs.webkit.org/attachment.cgi?id=208014&action=review) test reduction -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:10:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:10:13 -0700 Subject: [Webkit-unassigned] [Bug 119353] A bit messy layout on Apple webpage with WebKit In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119353 Zalan Bujtas changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208014|0 |1 is obsolete| | --- Comment #3 from Zalan Bujtas 2013-08-02 07:09:57 PST --- Created an attachment (id=208016) --> (https://bugs.webkit.org/attachment.cgi?id=208016&action=review) test reduction with explanation. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:14:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:14:00 -0700 Subject: [Webkit-unassigned] [Bug 119431] A script on specific page causes a whole-browser crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119431 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ggaren at apple.com, | |msaboff at apple.com, | |ossy at webkit.org, | |zandobersek at gmail.com --- Comment #1 from Zan Dobersek 2013-08-02 07:13:43 PST --- The crash happens on x86-64 - might be a duplicate of bug #119440? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:15:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:15:32 -0700 Subject: [Webkit-unassigned] [Bug 119444] Buildfix for !ENABLE(SVG) platforms after r153581 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119444 Zoltan Arvai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208012|0 |1 is obsolete| | Attachment #208017| |commit-queue+ Flag| | --- Comment #3 from Zoltan Arvai 2013-08-02 07:15:15 PST --- Created an attachment (id=208017) --> (https://bugs.webkit.org/attachment.cgi?id=208017&action=review) buildfix Buildfix with corrected guards. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:16:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:16:45 -0700 Subject: [Webkit-unassigned] [Bug 119433] REGRESSION: ARM Still crashes after change set r153612 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 Michael Saboff changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207994|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:18:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:18:42 -0700 Subject: [Webkit-unassigned] [Bug 119426] crash llint_op_catch after the FTL merge In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119426 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbrianceau at nds.com, | |msaboff at apple.com, | |ossy at webkit.org, | |zandobersek at gmail.com --- Comment #1 from Zan Dobersek 2013-08-02 07:18:26 PST --- Might be a duplicate of bug #119433, despite the disabled DFG? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:21:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:21:58 -0700 Subject: [Webkit-unassigned] [Bug 119353] A bit messy layout on Apple webpage with WebKit In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119353 Zalan Bujtas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zalan at apple.com --- Comment #4 from Zalan Bujtas 2013-08-02 07:21:43 PST --- The functionality changed at http://trac.webkit.org/changeset/147245 Since r147245, we handle min-content properly and we (min)size block elements based on its (min)content dimension, when -webkit-min-content is set. The default stylesheet defines min-width: -webkit-min-content; for the
element which unfortunately pushes the content off of the 4th column. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:22:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:22:15 -0700 Subject: [Webkit-unassigned] [Bug 119431] A script on specific page causes a whole-browser crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119431 --- Comment #2 from Michael Saboff 2013-08-02 07:21:59 PST --- (In reply to comment #1) > The crash happens on x86-64 - might be a duplicate of bug #119440? It is hard to tell with what's in the crash log. If it is repeatable, apply the patch in 119440 and try the page again. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:22:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:22:16 -0700 Subject: [Webkit-unassigned] [Bug 119353] A bit messy layout on Apple webpage with WebKit In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119353 Zalan Bujtas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddkilzer at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:24:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:24:14 -0700 Subject: [Webkit-unassigned] [Bug 119426] crash llint_op_catch after the FTL merge In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119426 --- Comment #2 from Michael Saboff 2013-08-02 07:23:58 PST --- (In reply to comment #1) > Might be a duplicate of bug #119433, despite the disabled DFG? If you left the Baseline JIT enabled, it goes through the same path that 119433 fixes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:35:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:35:05 -0700 Subject: [Webkit-unassigned] [Bug 119383] Latest WebKit nightly builds crash while using facebook chat In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119383 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE CC| |zandobersek at gmail.com --- Comment #1 from Zan Dobersek 2013-08-02 07:34:48 PST --- Bug #119384 reports the same problem, also provides a crash log. Thanks for reporting. *** This bug has been marked as a duplicate of bug 119384 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:35:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:35:05 -0700 Subject: [Webkit-unassigned] [Bug 119384] Crash on Facebook In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119384 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nastrock at gmail.com --- Comment #1 from Zan Dobersek 2013-08-02 07:34:48 PST --- *** Bug 119383 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:36:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:36:52 -0700 Subject: [Webkit-unassigned] [Bug 119384] Crash on Facebook In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119384 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org --- Comment #2 from Zan Dobersek 2013-08-02 07:36:36 PST --- Doesn't seem to be related to bug #119155 or the post-FTL-merge crashes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:45:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:45:12 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208008|review+, commit-queue+ | Flag| | --- Comment #8 from WebKit Commit Bot 2013-08-02 07:44:55 PST --- (From update of attachment 208008) Clearing flags on attachment: 208008 Committed r153646: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:45:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:45:14 -0700 Subject: [Webkit-unassigned] [Bug 119440] REGRESSION(r153612): It made jsc and layout tests crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119440 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from WebKit Commit Bot 2013-08-02 07:44:58 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:45:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:45:16 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Bug 119140 depends on bug 119440, which changed state. Bug 119440 Summary: REGRESSION(r153612): It made jsc and layout tests crash https://bugs.webkit.org/show_bug.cgi?id=119440 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:45:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:45:22 -0700 Subject: [Webkit-unassigned] [Bug 119402] [cmake] Extra compiler flags should be passed for all target In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119402 Csaba Osztrogonac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ossy at webkit.org --- Comment #1 from Csaba Osztrogonac 2013-08-02 07:45:06 PST --- I checked the full EFL build.log and found that "-std=gnu++0x" isn't passed to the following targets: - Tools/DumpRenderTree/TestNetscapePlugin - Tools/DumpRenderTree/efl - Tools/ImageDiff - Tools/TestWebKitAPI - Source/cmake/gtest - Source/JavaScriptCore/llint/LLIntOffsetExtractor.cpp - Source/JavaScriptCore/shell (jsc.cpp) - Source/WebKit/efl/tests - Source/WebKit2/UIProcess/API/efl/tests - Source/WebKit2/UIProcess/API/efl/tests -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 07:58:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 07:58:34 -0700 Subject: [Webkit-unassigned] [Bug 119433] REGRESSION: ARM Still crashes after change set r153612 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207994|review+, commit-queue+ | Flag| | --- Comment #6 from WebKit Commit Bot 2013-08-02 07:58:17 PST --- (From update of attachment 207994) Clearing flags on attachment: 207994 Committed r153648: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:04:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:04:15 -0700 Subject: [Webkit-unassigned] [Bug 119433] REGRESSION: ARM Still crashes after change set r153612 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 --- Comment #7 from Geoffrey Garen 2013-08-02 08:03:57 PST --- > Update call frame and do not restore registers from JIT stack frame in ARM and ARMv7 implementations of ctiVMThrowTrampolineSlowpath. Can you comment on why we should not restore these registers? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:05:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:05:25 -0700 Subject: [Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117545 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:05:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:05:28 -0700 Subject: [Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117545 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208011|commit-queue? |commit-queue- Flag| | --- Comment #7 from Build Bot 2013-08-02 08:05:11 PST --- (From update of attachment 208011) Attachment 208011 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1330178 New failing tests: svg/batik/filters/feTile.svg -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:05:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:05:31 -0700 Subject: [Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117545 --- Comment #8 from Build Bot 2013-08-02 08:05:13 PST --- Created an attachment (id=208019) --> (https://bugs.webkit.org/attachment.cgi?id=208019&action=review) Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:09:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:09:25 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:09:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:09:28 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208013|commit-queue? |commit-queue- Flag| | --- Comment #5 from Build Bot 2013-08-02 08:09:12 PST --- (From update of attachment 208013) Attachment 208013 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1329181 New failing tests: media/track/text-track-cue-is-reachable.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:09:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:09:30 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 --- Comment #6 from Build Bot 2013-08-02 08:09:14 PST --- Created an attachment (id=208020) --> (https://bugs.webkit.org/attachment.cgi?id=208020&action=review) Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:13:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:13:21 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206874|0 |1 is obsolete| | Attachment #206874|review?, commit-queue? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:13:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:13:28 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 --- Comment #2 from Brian Holt 2013-08-02 08:13:11 PST --- Created an attachment (id=208021) --> (https://bugs.webkit.org/attachment.cgi?id=208021&action=review) Launch DRT under valgrind launch the DRT under valgrind to generate a xml file with details of leaks found. \n run with \n $ Tools/Scripts/run-webkit-tests --gtk --debug --leaks --wrapper=valgrind --run-singly LayoutTests/platform/gtk -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:14:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:14:45 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 Vani Hegde changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208022| |review? Flag| | --- Comment #1 from Vani Hegde 2013-08-02 08:14:29 PST --- Created an attachment (id=208022) --> (https://bugs.webkit.org/attachment.cgi?id=208022&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:15:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:15:35 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208021| |review?, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:16:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:16:38 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 Vani Hegde changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vani.hegde at samsung.com --- Comment #2 from Vani Hegde 2013-08-02 08:16:21 PST --- The issue here is while breaking out of empty
  • , the style applied to
  • bleeds out of it. In CompositeEditCommand::breakOutOfEmptyListItem(), while breaking out of an empty list element, we save the style present in it and apply it to the newBlock irrespective of whether it is
  • or
    or

    . IMO, there is no need of saving the style of empty

  • and applying it to newBlock. I may be wrong in thinking that there is no need to do this at all, nevertheless below is the explanation for why I think so. The empty
  • might have any of the below styles associated with it 1. Style particularly applied to it (Ex:
  • br
  • ) 2. Style applied to all
  • s in the document (Ex: li{color:red;}) 3. Style applied to document as a whole (Ex: body{color:red;}) New block created can be either
  • or
    /

    . Let's consider the case where newBlock created while breaking out is either

    or

    If

  • has style as per 1 or 2, it would be wrong to apply this style to newBlock (And we are doing it currently) If
  • has style as per 3, it would have been already handled while attaching style to element's renderer and we need not do anything. Now, let's consider the case where newBlock is
  • If it's style due to case 1, I think it would be wrong to apply it to new
  • . In case we want to apply the style for this particular case we can do something like below if (!style->isEmpty() && newBlock->hasTagName(olTag)) //Applying style of empty
  • to newBlock only if it is an
  • again If
  • has style as per 2 or 3, it would have been already handled while attaching style to element's renderer and we need not do anything With this change I have executed all layout tests and the only regression I found was editing/deleting/delete-first-list-item.html This was added as part of changelist http://trac.webkit.org/changeset/15563 and I feel this test case is wrong in itself as it is expecting the style specifically applied to empty
  • to bleed out while breaking out. We will have to rebaseline this test. Eager to know your thoughts on this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:17:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:17:18 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 Vani Hegde changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanivhegde at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:20:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:20:24 -0700 Subject: [Webkit-unassigned] [Bug 66027] Implementation for "nav-up" "nav-down" "nav-left" "nav-right" properties in CSS3-UI module In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=66027 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:21:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:21:16 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pnormand at igalia.com --- Comment #3 from Brian Holt 2013-08-02 08:20:59 PST --- Given that the previous patch was large and daunting to review, I'm breaking this up into smaller patches. The first one is to launch the DRT under Valgrind. I will submit another patch (in a new bug) to implement the parsing of the xml files that are generated by Valgrind. This will contain Chromium code, but I will additionally upload diffs with the current Chromium code to assist reviewing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:24:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:24:43 -0700 Subject: [Webkit-unassigned] [Bug 119446] New: [GTK] Parse Valgrind xml leak files Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119446 Summary: [GTK] Parse Valgrind xml leak files Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: brian.holt at samsung.com CC: dpranke at chromium.org, rniwa at webkit.org, mrobinson at webkit.org, pnormand at igalia.com Implement the parsing of the xml files that are generated by Valgrind. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:25:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:25:36 -0700 Subject: [Webkit-unassigned] [Bug 119446] [GTK] Parse Valgrind xml leak files In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119446 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |118785 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:25:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:25:38 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119446 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:27:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:27:38 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207832| |commit-queue+ Flag| | --- Comment #5 from Mario Sanchez Prada 2013-08-02 08:27:22 PST --- (From update of attachment 207832) Thanks for the review. Adding it to the commit queue... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:28:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:28:01 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:40:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:40:03 -0700 Subject: [Webkit-unassigned] [Bug 119444] Buildfix for !ENABLE(SVG) platforms after r153581 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119444 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208017|commit-queue+ | Flag| | --- Comment #4 from WebKit Commit Bot 2013-08-02 08:39:46 PST --- (From update of attachment 208017) Clearing flags on attachment: 208017 Committed r153650: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:40:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:40:07 -0700 Subject: [Webkit-unassigned] [Bug 119444] Buildfix for !ENABLE(SVG) platforms after r153581 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119444 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from WebKit Commit Bot 2013-08-02 08:39:50 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:49:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:49:17 -0700 Subject: [Webkit-unassigned] [Bug 119433] REGRESSION: ARM Still crashes after change set r153612 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 --- Comment #8 from Julien Brianceau 2013-08-02 08:49:00 PST --- (In reply to comment #7) > > Can you comment on why we should not restore these registers? From bugzilla-daemon at webkit.org Fri Aug 2 08:51:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:51:45 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207832|review+, commit-queue+ | Flag| | --- Comment #6 from WebKit Commit Bot 2013-08-02 08:51:28 PST --- (From update of attachment 207832) Clearing flags on attachment: 207832 Committed r153651: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 08:51:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 08:51:47 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #7 from WebKit Commit Bot 2013-08-02 08:51:31 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:01:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:01:24 -0700 Subject: [Webkit-unassigned] [Bug 114867] [GTK] Get rid of Pango/Gail dependencies in accessibility for ATK In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114867 Bug 114867 depends on bug 114871, which changed state. Bug 114871 Summary: [GTK] Reimplement atk_text_get_text_*_offset for WORD boundaries https://bugs.webkit.org/show_bug.cgi?id=114871 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:01:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:01:26 -0700 Subject: [Webkit-unassigned] [Bug 114872] [GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114872 Bug 114872 depends on bug 114871, which changed state. Bug 114871 Summary: [GTK] Reimplement atk_text_get_text_*_offset for WORD boundaries https://bugs.webkit.org/show_bug.cgi?id=114871 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:07:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:07:13 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:07:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:07:15 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208022| |commit-queue- Flag| | --- Comment #3 from Build Bot 2013-08-02 09:06:59 PST --- (From update of attachment 208022) Attachment 208022 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1332171 New failing tests: editing/deleting/delete-first-list-item.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:07:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:07:17 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 --- Comment #4 from Build Bot 2013-08-02 09:07:00 PST --- Created an attachment (id=208023) --> (https://bugs.webkit.org/attachment.cgi?id=208023&action=review) Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:12:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:12:55 -0700 Subject: [Webkit-unassigned] [Bug 119446] [GTK] Parse Valgrind xml leak files In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119446 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208024| |review? Flag| | --- Comment #1 from Brian Holt 2013-08-02 09:12:38 PST --- Created an attachment (id=208024) --> (https://bugs.webkit.org/attachment.cgi?id=208024&action=review) Parse Valgrind XML files -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:14:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:14:17 -0700 Subject: [Webkit-unassigned] [Bug 116041] Checking if frame is complete and access duration doesn't need a decode In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116041 Csaba Osztrogonac OOO until 21st Aug changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ossy at webkit.org |webkit-unassigned at lists.web | |kit.org --- Comment #45 from Csaba Osztrogonac OOO until 21st Aug 2013-08-02 09:13:59 PST --- Set unassigned, I can't work on it until back from holiday. Feel free to pick it up if anybody is interested in this bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:14:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:14:30 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208005| |commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:14:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:14:38 -0700 Subject: [Webkit-unassigned] [Bug 119446] [GTK] Parse Valgrind xml leak files In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119446 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |glenn at skynav.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:17:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:17:13 -0700 Subject: [Webkit-unassigned] [Bug 119446] [GTK] Parse Valgrind xml leak files In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119446 --- Comment #2 from Brian Holt 2013-08-02 09:16:56 PST --- Created an attachment (id=208025) --> (https://bugs.webkit.org/attachment.cgi?id=208025&action=review) Diff of common.py with Chromium trunk This is a diff (without whitespace) of common.py which has been taken from Chromium. The code has been reformatted to PEP8/pylint and the LICENSE file has been inserted at the top of the file. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:20:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:20:55 -0700 Subject: [Webkit-unassigned] [Bug 119446] [GTK] Parse Valgrind xml leak files In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119446 --- Comment #3 from Brian Holt 2013-08-02 09:20:38 PST --- Created an attachment (id=208026) --> (https://bugs.webkit.org/attachment.cgi?id=208026&action=review) Diff of gdb_helper.py with Chromium trunk As above, code has been reformatted to PEP8/pylint and the LICENSE file has been inserted at the top of the file. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:21:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:21:42 -0700 Subject: [Webkit-unassigned] [Bug 96163] SVG does not respect overflow:visible In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=96163 --- Comment #12 from popecode at gmail.com 2013-08-02 09:21:26 PST --- My practice benefits greatly from Webkit technology. I am grateful for it. Unless the spec clearly states to the contrary, it should be read to be consistent with its context. And I think that means that the "overflow" attribute in an SVG tag should work in symmetry with how the overflow attribute works elsewhere, e.g., in a DIV tag. The fiddle on this, to my mind, plainly illustrates the problem. Has anyone looked at this? Try it with a Webkit browser and then with Firefox nightly. Hopefully the stark difference there illustrated will see this matter through the pettifogging and toward a fix. ...nearly one year outstanding? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:26:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:26:02 -0700 Subject: [Webkit-unassigned] [Bug 119446] [GTK] Parse Valgrind xml leak files In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119446 --- Comment #4 from Brian Holt 2013-08-02 09:25:45 PST --- Created an attachment (id=208027) --> (https://bugs.webkit.org/attachment.cgi?id=208027&action=review) Diff of memcheck_analyze.py with Chromium trunk As above the code has been reformatted to PEP8/pylint. There are 2 non-cosmetic changes to this file: 1) a hunk to make suppressions platform dependent has been removed because it was found to break the parsing of suppressions. 2) Leaks_StillReachable, InvalidWrite and InvalidRead are explicitly excluded from the report (these can be added in at a later stage if deemed interesting). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:29:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:29:42 -0700 Subject: [Webkit-unassigned] [Bug 100107] [CSS Shaders] Remove m_contextSize from the CustomFilterRenderer. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100107 Ralph T changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ralpht+bugs at gmail.com --- Comment #1 from Ralph T 2013-08-02 09:29:26 PST --- In my port, I'm now (sometimes) passing in a custom projection matrix so that I can avoid rendering to a texture and blending that to the framebuffer (which is needlessly wasteful of bandwidth and is too slow on some machines I target). Is your idea that we could also avoid rebinding the attributes and setting uniforms that have not changed since the last render? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:30:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:30:03 -0700 Subject: [Webkit-unassigned] [Bug 119447] New: REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 Summary: REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jbrianceau at nds.com Crashes are observed during javascriptcore tests. For instance, array-defineOwnProperty.js: This test checks the behavior of [[DefineOwnProperty]] applied to Array objects (see ES5.1 15.4.5.1). On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS Object.defineProperty([], 'x', { get:function(){return true;} }).x is true PASS Object.defineProperty([], 'length', { value: 1 }).length is 1 PASS var a = Object.defineProperty([], 'length', { writable: false }); a[1] = 1; a.length is 0 PASS var a = Object.defineProperty([], 'length', { writable: false }); a.length = 1; a.length is 0 PASS var a = Object.defineProperty([], 'length', {}); a.length = 1; a.length is 1 Segmentation fault -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:35:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:35:12 -0700 Subject: [Webkit-unassigned] [Bug 119448] New: [Gtk] Suppress irrelevant or known leaks for Valgrind Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119448 Summary: [Gtk] Suppress irrelevant or known leaks for Valgrind Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: brian.holt at samsung.com Valgrind often works too well and reports memory leaks and violations that might not be relevant or might already be known to the application that is being analysed. To make this easier Valgrind supports a the notion of suppressions. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:36:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:36:15 -0700 Subject: [Webkit-unassigned] [Bug 119448] [Gtk] Suppress irrelevant or known leaks for Valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119448 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpranke at chromium.org, | |mrobinson at webkit.org, | |pnormand at igalia.com, | |rniwa at webkit.org Depends on| |118785 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:36:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:36:17 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119448 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:36:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:36:35 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 --- Comment #1 from Julien Brianceau 2013-08-02 09:36:19 PST --- Created an attachment (id=208028) --> (https://bugs.webkit.org/attachment.cgi?id=208028&action=review) ctiVMThrowTrampolineSlowpath fix for mips architecture. This patches fixes the issue on my Broadcom 7241 board. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:38:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:38:08 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msaboff at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:38:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:38:14 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:38:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:38:19 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fpizlo at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:39:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:39:18 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kilvadyb at homejinni.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:39:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:39:30 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208028| |review?, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:40:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:40:09 -0700 Subject: [Webkit-unassigned] [Bug 119417] Use op_get_by_id_custom_stub to fast access to JSCallbackObject's static value In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119417 --- Comment #4 from Yi Shen 2013-08-02 09:39:53 PST --- Thanks! I will update my patch with the test. (In reply to comment #3) > (From update of attachment 207971 [details]) > This isn't quite right. > > The API allows a client to specify an abstract hasProperty and/or getProperty callback, and that callback is allowed to return different results every time, making it incorrect to cache. > > Please add a test to testapi that fails for this reason with your current patch. > > That said, you may be able to rescue the basic idea of this optimization: You just need to modify your patch to be sure to poison all property access as uncacheable if anything in the class or prototype hierarchy specifies an abstract getProperty or hasProperty callback. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:40:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:40:17 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gergely at homejinni.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:46:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:46:40 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ggaren at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 09:59:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 09:59:10 -0700 Subject: [Webkit-unassigned] [Bug 119448] [Gtk] Suppress irrelevant or known leaks for Valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119448 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208029| |review? Flag| | --- Comment #1 from Brian Holt 2013-08-02 09:58:53 PST --- Created an attachment (id=208029) --> (https://bugs.webkit.org/attachment.cgi?id=208029&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 10:00:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 10:00:21 -0700 Subject: [Webkit-unassigned] [Bug 119448] [Gtk] Suppress irrelevant or known leaks for Valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119448 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |glenn at skynav.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 10:10:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 10:10:13 -0700 Subject: [Webkit-unassigned] [Bug 119384] REGRESSION (r153005): Crash in SpaceSplitString::spaceSplitStringContainsValue on Facebook In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119384 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Crash on Facebook |REGRESSION (r153005): Crash | |in | |SpaceSplitString::spaceSpli | |tStringContainsValue on | |Facebook Status|UNCONFIRMED |NEW Keywords| |InRadar Priority|P2 |P1 CC| |benjamin at webkit.org Ever Confirmed|0 |1 Alias|FB_Chat_bug | --- Comment #3 from Alexey Proskuryakov 2013-08-02 10:09:56 PST --- I didn't attempt to bisect, but this code was added in . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 10:30:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 10:30:36 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208013|0 |1 is obsolete| | Attachment #208013|review?, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 10:30:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 10:30:44 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208030| |review? Flag| | --- Comment #7 from Mihai Tica 2013-08-02 10:30:27 PST --- Created an attachment (id=208030) --> (https://bugs.webkit.org/attachment.cgi?id=208030&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 10:52:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 10:52:46 -0700 Subject: [Webkit-unassigned] [Bug 117550] [CSS Shaders] Animations and transitions should use validated custom programs In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117550 --- Comment #24 from Simon Fraser (smfr) 2013-08-02 10:52:29 PST --- (From update of attachment 205273) View in context: https://bugs.webkit.org/attachment.cgi?id=205273&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2120 > + // Calling CustomFilterProgram::isLoaded with no clients will make it assert; add If you need EmptyCustomFilterProgramClient just for this, why not fix the assert? > Source/WebCore/rendering/RenderLayerBacking.cpp:2268 > + FilterOperations validatedFromFilters; > + FilterOperations validatedToFilters; > + if (validateCustomFilters(owningLayer(), fromStyle, validatedFromFilters)) > + filterVector.insert(FilterAnimationValue::create(0, validatedFromFilters)); > + if (validateCustomFilters(owningLayer(), toStyle, validatedToFilters)) > + filterVector.insert(FilterAnimationValue::create(1, validatedToFilters)); I don't think we should pay the cost of two FilterOperations on the stack when there are no custom filters. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 10:54:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 10:54:09 -0700 Subject: [Webkit-unassigned] [Bug 119419] [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119419 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208033| |review? Flag| | --- Comment #2 from Ruth Fong 2013-08-02 10:53:52 PST --- Created an attachment (id=208033) --> (https://bugs.webkit.org/attachment.cgi?id=208033&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 10:59:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 10:59:36 -0700 Subject: [Webkit-unassigned] [Bug 119435] FrameView should have an isMainFrameView() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119435 --- Comment #5 from Simon Fraser (smfr) 2013-08-02 10:59:19 PST --- (From update of attachment 207997) View in context: https://bugs.webkit.org/attachment.cgi?id=207997&action=review > Source/WebCore/page/FrameView.cpp:427 > +bool FrameView::isMainFrameView() const > +{ > + return m_frame && m_frame->page() && m_frame->page()->mainFrame() == m_frame; > +} > + Does this do the right thing for a page in the page cache? What is the right thing? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:00:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:00:24 -0700 Subject: [Webkit-unassigned] [Bug 119452] New: ANGLE should be soft linked on Windows Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119452 Summary: ANGLE should be soft linked on Windows Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows 7 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: ANGLE AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: achristensen at apple.com Of all the not tedious things in the world, my favorite is manually linking large libraries. libEGL and libGLESv2 should be soft linked to avoid adding startup time and to not require people who won't use it to ship additional dlls. These libraries are not going to change because they are based on stable standards. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:06:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:06:16 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 --- Comment #5 from Ryosuke Niwa 2013-08-02 11:06:00 PST --- (From update of attachment 208022) View in context: https://bugs.webkit.org/attachment.cgi?id=208022&action=review > Source/WebCore/ChangeLog:25 > + it would be wrong to apply this to new block which is not
  • . Why? > Source/WebCore/ChangeLog:31 > + If style present in
  • is due to 1, it would be wrong to apply > + this to new
  • . Why? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:12:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:12:52 -0700 Subject: [Webkit-unassigned] [Bug 119453] New: [Forms: color] Styling renders a poorly drawn color well Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119453 Summary: [Forms: color] Styling renders a poorly drawn color well Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ruthiecftg at gmail.com Created an attachment (id=208035) --> (https://bugs.webkit.org/attachment.cgi?id=208035&action=review) Screenshot comparing unstyled and styled elements Setting the border and padding of an results in a poorly drawn color well. See the attached screenshot of the following: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:13:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:13:41 -0700 Subject: [Webkit-unassigned] [Bug 119453] [Forms: color] Styling renders a poorly drawn color well In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119453 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com, | |dino at apple.com, | |jonlee at apple.com, | |ruthiecftg at gmail.com, | |simon.fraser at apple.com, | |thorton at apple.com, | |webkit-bug-importer at group.a | |pple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:13:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:13:55 -0700 Subject: [Webkit-unassigned] [Bug 119453] [Forms: color] Styling renders a poorly drawn color well In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119453 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Radar WebKit Bug Importer 2013-08-02 11:13:39 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:15:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:15:40 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208030|review? |review+ Flag| | --- Comment #8 from Dirk Schulze 2013-08-02 11:15:23 PST --- (From update of attachment 208030) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:16:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:16:46 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208005|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #12 from Dirk Schulze 2013-08-02 11:16:30 PST --- (From update of attachment 208005) Great test suite! Awesome work. r=me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:18:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:18:24 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:21:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:21:46 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208028|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #2 from Geoffrey Garen 2013-08-02 11:21:29 PST --- (From update of attachment 208028) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:22:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:22:30 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:27:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:27:41 -0700 Subject: [Webkit-unassigned] [Bug 119419] [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119419 --- Comment #3 from Tim Horton 2013-08-02 11:27:24 PST --- (From update of attachment 208033) View in context: https://bugs.webkit.org/attachment.cgi?id=208033&action=review > Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:-85 > -#if ENABLE(INPUT_TYPE_COLOR_POPOVER) So, we need to endPicker() for all ? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:29:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:29:17 -0700 Subject: [Webkit-unassigned] [Bug 119452] ANGLE should be soft linked on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119452 Alex Christensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208036| |review? Flag| | --- Comment #1 from Alex Christensen 2013-08-02 11:29:01 PST --- Created an attachment (id=208036) --> (https://bugs.webkit.org/attachment.cgi?id=208036&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:31:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:31:09 -0700 Subject: [Webkit-unassigned] [Bug 119419] [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119419 Tim Horton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208033|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:32:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:32:02 -0700 Subject: [Webkit-unassigned] [Bug 119452] ANGLE should be soft linked on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119452 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |dino at apple.com, | |kondapallykalyan at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:41:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:41:57 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208005|review+, commit-queue+ | Flag| | --- Comment #13 from WebKit Commit Bot 2013-08-02 11:41:41 PST --- (From update of attachment 208005) Clearing flags on attachment: 208005 Committed r153658: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:42:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:42:00 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #14 from WebKit Commit Bot 2013-08-02 11:41:43 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:44:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:44:28 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208028|review+, commit-queue+ | Flag| | --- Comment #3 from WebKit Commit Bot 2013-08-02 11:44:11 PST --- (From update of attachment 208028) Clearing flags on attachment: 208028 Committed r153659: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 11:44:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 11:44:30 -0700 Subject: [Webkit-unassigned] [Bug 119447] REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119447 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from WebKit Commit Bot 2013-08-02 11:44:13 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 12:06:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 12:06:11 -0700 Subject: [Webkit-unassigned] [Bug 119435] FrameView should have an isMainFrameView() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119435 Tim Horton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |beidson at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 12:12:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 12:12:52 -0700 Subject: [Webkit-unassigned] [Bug 119454] New: Reset scrollbars when frameview load is completed Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119454 Summary: Reset scrollbars when frameview load is completed Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: roger_fong at apple.com CC: hyatt at apple.com, simon.fraser at apple.com, jonlee at apple.com, thorton at apple.com Sometimes a page may take longer to load than expected. If the page changes the body::-webkit-scrollbar css, those changes won't take affect because we don't call updateScrollbars when we need to. Right now we do it on the very first layout, which won't necessarily wait to happen until the page has finished loading. It also happens when resizing the view. I think we have two options here: 1. in FrameView::handleLoadComplete, call resetScrollbars so that we update the scroll bars when the page is done loading 2. ensure that the first layout doesn't occur until handleLoadComplete has been called, then allow/force the first layout. - not sure about this one because I don't really have a good grasp of all the different situations in which we decide to attempt a layout call The patch I'm loading is for 1) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 12:20:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 12:20:23 -0700 Subject: [Webkit-unassigned] [Bug 119454] Reset scrollbars when frameview load is completed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119454 Roger Fong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roger_fong at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 12:20:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 12:20:50 -0700 Subject: [Webkit-unassigned] [Bug 119454] Reset scrollbars when frameview load is completed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119454 --- Comment #1 from Roger Fong 2013-08-02 12:20:34 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 12:20:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 12:20:56 -0700 Subject: [Webkit-unassigned] [Bug 119454] Reset scrollbars when frameview load is completed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119454 Roger Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 12:22:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 12:22:54 -0700 Subject: [Webkit-unassigned] [Bug 119454] Reset scrollbars when frameview load is completed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119454 Roger Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208038| |review? Flag| | --- Comment #2 from Roger Fong 2013-08-02 12:22:37 PST --- Created an attachment (id=208038) --> (https://bugs.webkit.org/attachment.cgi?id=208038&action=review) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 12:30:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 12:30:05 -0700 Subject: [Webkit-unassigned] [Bug 119435] FrameView should have an isMainFrameView() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119435 --- Comment #6 from Brady Eidson 2013-08-02 12:29:49 PST --- (In reply to comment #5) > (From update of attachment 207997 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207997&action=review > > > Source/WebCore/page/FrameView.cpp:427 > > +bool FrameView::isMainFrameView() const > > +{ > > + return m_frame && m_frame->page() && m_frame->page()->mainFrame() == m_frame; > > +} > > + > > Does this do the right thing for a page in the page cache? What is the right thing? A "web page" in the page cache is a much different concept than a WebCore::Page WebCore::Page represents the browser tab. And that WebCore::Page has a single WebCore::Frame that is ALWAYS the main frame of that tab, even across navigations. I think this check is fine. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 12:44:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 12:44:20 -0700 Subject: [Webkit-unassigned] [Bug 119452] ANGLE should be soft linked on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119452 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208036|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 12:44:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 12:44:43 -0700 Subject: [Webkit-unassigned] [Bug 119452] ANGLE should be soft linked on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119452 Alex Christensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208036| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 12:50:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 12:50:52 -0700 Subject: [Webkit-unassigned] [Bug 119431] A script on specific page causes a whole-browser crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119431 --- Comment #3 from Nick Heer 2013-08-02 12:50:36 PST --- (In reply to comment #2) > (In reply to comment #1) > > The crash happens on x86-64 - might be a duplicate of bug #119440? > > It is hard to tell with what's in the crash log. If it is repeatable, apply the patch in 119440 and try the page again. I'm using the Safari nightlies (I don't think there's a way to manually patch; or, at least, I'm not savvy enough to do so), so I'll wait until tonight's build is released and see if that's fixed it. Thanks for the quick response. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 12:59:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 12:59:06 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208030| |commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:01:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:01:14 -0700 Subject: [Webkit-unassigned] [Bug 119455] New: [Forms: color] The positioning of the popover color well is inverted Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 Summary: [Forms: color] The positioning of the popover color well is inverted Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ruthiecftg at gmail.com The IntRect object passed to WebColorPickerMac assumes that the origin is at the top-left of the screen, while by default NSRect assumes that the origin is at bottom-left of the screen. The needed change will be in WKColorPopoverMac::initWithFrame: inView:. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:01:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:01:32 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com, | |beidson at apple.com, | |dino at apple.com, | |jonlee at apple.com, | |ruthiecftg at gmail.com, | |webkit-bug-importer at group.a | |pple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:02:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:02:23 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Radar WebKit Bug Importer 2013-08-02 13:02:07 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:09:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:09:33 -0700 Subject: [Webkit-unassigned] [Bug 119452] ANGLE should be soft linked on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119452 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208036|review+, commit-queue+ | Flag| | --- Comment #2 from WebKit Commit Bot 2013-08-02 13:09:17 PST --- (From update of attachment 208036) Clearing flags on attachment: 208036 Committed r153664: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:09:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:09:36 -0700 Subject: [Webkit-unassigned] [Bug 119452] ANGLE should be soft linked on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119452 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from WebKit Commit Bot 2013-08-02 13:09:20 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:26:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:26:11 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208039| |review? Flag| | --- Comment #2 from Ruth Fong 2013-08-02 13:25:54 PST --- Created an attachment (id=208039) --> (https://bugs.webkit.org/attachment.cgi?id=208039&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:28:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:28:12 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 --- Comment #3 from Tim Horton 2013-08-02 13:27:56 PST --- (From update of attachment 208039) View in context: https://bugs.webkit.org/attachment.cgi?id=208039&action=review > Source/WebKit2/ChangeLog:12 > + (-[WKColorPopoverMac initWithFrame:WebCore::inView:]): Looks like the change log thing did something crazy here. Please take the random WebCore namespace out. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:28:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:28:28 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 Tim Horton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208039|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:31:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:31:46 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208039|0 |1 is obsolete| | Attachment #208039|review+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:31:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:31:48 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208040| |review? Flag| | --- Comment #4 from Ruth Fong 2013-08-02 13:31:32 PST --- Created an attachment (id=208040) --> (https://bugs.webkit.org/attachment.cgi?id=208040&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:34:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:34:09 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208040|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:34:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:34:39 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208040|review+ |review- Flag| | --- Comment #5 from WebKit Commit Bot 2013-08-02 13:34:23 PST --- (From update of attachment 208040) Rejecting attachment 208040 from review queue. ruthiecftg at gmail.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:39:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:39:16 -0700 Subject: [Webkit-unassigned] [Bug 119457] New: The LayoutMilestones didLayout callback should only fire for the main frame Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119457 Summary: The LayoutMilestones didLayout callback should only fire for the main frame Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: bdakin at apple.com The LayoutMilestones didLayout callback should only fire for the main frame since it is a WebView/WebCore::Page-level concept. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:39:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:39:26 -0700 Subject: [Webkit-unassigned] [Bug 119457] The LayoutMilestones didLayout callback should only fire for the main frame In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119457 Beth Dakin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com, | |sam at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 13:42:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 13:42:22 -0700 Subject: [Webkit-unassigned] [Bug 119457] The LayoutMilestones didLayout callback should only fire for the main frame In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119457 Beth Dakin changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |bdakin at apple.com |kit.org | Attachment #208042| |review? Flag| | --- Comment #1 from Beth Dakin 2013-08-02 13:42:06 PST --- Created an attachment (id=208042) --> (https://bugs.webkit.org/attachment.cgi?id=208042&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:03:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:03:52 -0700 Subject: [Webkit-unassigned] [Bug 119459] New: webaudio/javascriptaudionode-downmix8-2channel-input.html sometimes asserts Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119459 Summary: webaudio/javascriptaudionode-downmix8-2channel-input.h tml sometimes asserts Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified URL: http://build.webkit.org/results/Apple%20MountainLion%2 0Debug%20WK2%20(Tests)/r153661%20(11425)/webaudio/java scriptaudionode-downmix8-2channel-input-crash-log.txt OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Web Audio AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.fraser at apple.com CC: crogers at google.com This test sometimes asserts: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010fc070aa WTFCrash + 42 (Assertions.cpp:339) 1 com.apple.WebCore 0x0000000111481b56 WebCore::JSEventListener::jsFunction(WebCore::ScriptExecutionContext*) const + 390 (JSEventListener.h:94) 2 com.apple.WebCore 0x00000001115ef33b WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) + 171 (JSEventListener.cpp:84) 3 com.apple.WebCore 0x0000000110f819e2 WebCore::EventTarget::fireEventListeners(WebCore::Event*, WebCore::EventTargetData*, WTF::Vector&) + 498 (EventTarget.cpp:249) 4 com.apple.WebCore 0x0000000110f815be WebCore::EventTarget::fireEventListeners(WebCore::Event*) + 334 (EventTarget.cpp:190) 5 com.apple.WebCore 0x0000000110f81437 WebCore::EventTarget::dispatchEvent(WTF::PassRefPtr) + 135 (EventTarget.cpp:156) 6 com.apple.WebCore 0x0000000111f74cf9 WebCore::ScriptProcessorNode::fireProcessEvent() + 489 (ScriptProcessorNode.cpp:262) 7 com.apple.WebCore 0x0000000111f74a77 WebCore::ScriptProcessorNode::fireProcessEventDispatch(void*) + 103 (ScriptProcessorNode.cpp:235) 8 com.apple.JavaScriptCore 0x000000010fc27968 WTF::dispatchFunctionsFromMainThread() + 280 (MainThread.cpp:156) 9 com.apple.JavaScriptCore 0x000000010fc29f55 -[JSWTFMainThreadCaller call] + 21 (MainThreadMac.mm:49) 10 com.apple.Foundation 0x00007fff9418e5ca __NSThreadPerformPerform + 225 11 com.apple.CoreFoundation 0x00007fff90c2fb31 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 12 com.apple.CoreFoundation 0x00007fff90c2f455 __CFRunLoopDoSources0 + 245 13 com.apple.CoreFoundation 0x00007fff90c527f5 __CFRunLoopRun + 789 14 com.apple.CoreFoundation 0x00007fff90c520e2 CFRunLoopRunSpecific + 290 15 com.apple.HIToolbox 0x00007fff8f905eb4 RunCurrentEventLoopInMode + 209 16 com.apple.HIToolbox 0x00007fff8f905c52 ReceiveNextEventCommon + 356 17 com.apple.HIToolbox 0x00007fff8f905ae3 BlockUntilNextEventMatchingListInMode + 62 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:04:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:04:01 -0700 Subject: [Webkit-unassigned] [Bug 119459] webaudio/javascriptaudionode-downmix8-2channel-input.html sometimes asserts In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119459 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jer.noble at apple.com, | |simon.fraser at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:04:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:04:18 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 Tim Horton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208040|review- |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:04:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:04:32 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:07:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:07:59 -0700 Subject: [Webkit-unassigned] [Bug 119460] New: Remove no-arguments constructor to PropertySlot Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119460 Summary: Remove no-arguments constructor to PropertySlot Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: barraclough at apple.com This is unsafe if getValue is subsequently called, and the property is a getter. Simplest to just remove it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:10:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:10:00 -0700 Subject: [Webkit-unassigned] [Bug 119460] Remove no-arguments constructor to PropertySlot In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119460 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |barraclough at apple.com |kit.org | Attachment #208045| |review? Flag| | --- Comment #1 from Gavin Barraclough 2013-08-02 14:09:43 PST --- Created an attachment (id=208045) --> (https://bugs.webkit.org/attachment.cgi?id=208045&action=review) fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:13:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:13:34 -0700 Subject: [Webkit-unassigned] [Bug 119435] FrameView should have an isMainFrameView() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119435 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #7 from Darin Adler 2013-08-02 14:13:17 PST --- (In reply to comment #1) > Maybe there's some compelling reason that we haven't done this before? I don't know, but I'd love to! Generally it?s hard to know how much to replicate across the core classes. Should Document have isMainFrameDocument in it? Should Frame have isMainFrame or only FrameTree, etc.? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:26:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:26:32 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208040|review+, commit-queue+ | Flag| | --- Comment #6 from WebKit Commit Bot 2013-08-02 14:26:15 PST --- (From update of attachment 208040) Clearing flags on attachment: 208040 Committed r153667: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:26:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:26:34 -0700 Subject: [Webkit-unassigned] [Bug 119455] [Forms: color] The positioning of the popover color well is inverted In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119455 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #7 from WebKit Commit Bot 2013-08-02 14:26:17 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:30:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:30:45 -0700 Subject: [Webkit-unassigned] [Bug 119419] [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119419 Ruth Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208033| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:31:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:31:34 -0700 Subject: [Webkit-unassigned] [Bug 119419] [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119419 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:34:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:34:42 -0700 Subject: [Webkit-unassigned] [Bug 119419] [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119419 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208033|review+, commit-queue+ | Flag| | --- Comment #4 from WebKit Commit Bot 2013-08-02 14:34:26 PST --- (From update of attachment 208033) Clearing flags on attachment: 208033 Committed r153670: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:34:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:34:44 -0700 Subject: [Webkit-unassigned] [Bug 119419] [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119419 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #5 from WebKit Commit Bot 2013-08-02 14:34:27 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 14:50:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 14:50:15 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 --- Comment #49 from Gustavo Noronha (kov) 2013-08-02 14:49:57 PST --- I'm happy with this API too! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 15:06:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 15:06:09 -0700 Subject: [Webkit-unassigned] [Bug 119384] REGRESSION (r153005): Crash in SpaceSplitString::spaceSplitStringContainsValue on Facebook In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119384 Benjamin Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |benjamin at webkit.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 15:45:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 15:45:27 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 --- Comment #6 from Build Bot 2013-08-02 15:45:11 PST --- (From update of attachment 208022) Attachment 208022 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1336300 New failing tests: editing/deleting/delete-first-list-item.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 15:45:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 15:45:29 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 --- Comment #7 from Build Bot 2013-08-02 15:45:13 PST --- Created an attachment (id=208050) --> (https://bugs.webkit.org/attachment.cgi?id=208050&action=review) Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 15:51:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 15:51:40 -0700 Subject: [Webkit-unassigned] [Bug 119461] New: Directly composited background layers might intersect with children Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119461 Summary: Directly composited background layers might intersect with children Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: dino at apple.com CC: simon.fraser at apple.com, noam at webkit.org, webkit-bug-importer at group.apple.com See attached testcase. A element has a directly composited background that then intersects with its children layers. We either need to flatten (which might be incorrect if the container preserves3d) or turn off composited backgrounds in this case. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 15:52:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 15:52:06 -0700 Subject: [Webkit-unassigned] [Bug 119461] Directly composited background layers might intersect with children In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119461 --- Comment #1 from Dean Jackson 2013-08-02 15:51:48 PST --- Created an attachment (id=208051) --> (https://bugs.webkit.org/attachment.cgi?id=208051&action=review) Test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 15:52:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 15:52:22 -0700 Subject: [Webkit-unassigned] [Bug 119461] Directly composited background layers might intersect with children In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119461 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #2 from Radar WebKit Bug Importer 2013-08-02 15:52:05 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 15:52:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 15:52:52 -0700 Subject: [Webkit-unassigned] [Bug 119461] Directly composited background layers might intersect with children In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119461 --- Comment #3 from Dean Jackson 2013-08-02 15:52:35 PST --- This regression was caused by Bug 103786 and http://trac.webkit.org/changeset/137006 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 16:09:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 16:09:44 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 Roger Fong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roger_fong at apple.com --- Comment #15 from Roger Fong 2013-08-02 16:09:27 PST --- Were these tests meant to work on Windows as well? / are they port agnostic results? http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r153658%20(37319)/results.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 16:57:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 16:57:30 -0700 Subject: [Webkit-unassigned] [Bug 119463] New: canvas-blending tests added in http://trac.webkit.org/changeset/153658 fail on AppleWin port Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119463 Summary: canvas-blending tests added in http://trac.webkit.org/changeset/153658 fail on AppleWin port Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows 7 Status: NEW Keywords: InRadar, LayoutTestFailure Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: roger_fong at apple.com CC: webkit-bug-importer at group.apple.com, mitica at adobe.com Tests added in https://bugs.webkit.org/show_bug.cgi?id=119082 Skipping for now -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 16:57:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 16:57:33 -0700 Subject: [Webkit-unassigned] [Bug 119463] canvas-blending tests added in http://trac.webkit.org/changeset/153658 fail on AppleWin port In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119463 Roger Fong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roger_fong at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 22:04:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 22:04:45 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 --- Comment #8 from Vani Hegde 2013-08-02 22:04:28 PST --- (In reply to comment #5) > (From update of attachment 208022 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208022&action=review > > > Source/WebCore/ChangeLog:25 > > + it would be wrong to apply this to new block which is not
  • . > > Why? Since the style has been specified particularly for
  • , wouldn't it be wrong to apply it to non
  • elements? This example will describe it better http://jsfiddle.net/rpkMM/ Please observe the behavior in firefox and IE. > > > Source/WebCore/ChangeLog:31 > > + If style present in
  • is due to 1, it would be wrong to apply > > + this to new
  • . > > Why? Example 1: http://jsfiddle.net/JWdxC/ When we consider this example
    • 1
      • a

    • 2
    Outer
      has a different style than that of inner
        . When we break out of an empty
      • present in inner
          , we will be creating new
        • which would be now part of outer
            . Shouldn't we apply the style of outer
              to this newly created
            • ? This is the behavior we see in firefox and this seems right. On the other hand, we still retain the style of inner
                for new
              • , which apparently is part of outer
                  In this scenario, not passing on the style seems more appropriate. Example 2: But if we consider below example,
                  • 1
                    • a

                  • 2
                  it becomes little tricky. Here the behavior is not quite obvious and is debatable. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 22:53:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 22:53:55 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 --- Comment #9 from Ryosuke Niwa 2013-08-02 22:53:38 PST --- I disagree. As far as user is concerned, it shouldn't matter whether the style is specified on li or on an inline element. Specifically,
                • hello
                • and
                • hello
                • look identical for users. Why should the fact the style is specified on li matter at all? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 23:21:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 23:21:33 -0700 Subject: [Webkit-unassigned] [Bug 74416] [CSS Shaders] Report the errors generated when compiling and linking the shaders In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=74416 Ralph T changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208057| |review? Flag| | --- Comment #1 from Ralph T 2013-08-02 23:21:16 PST --- Created an attachment (id=208057) --> (https://bugs.webkit.org/attachment.cgi?id=208057&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 23:23:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 23:23:44 -0700 Subject: [Webkit-unassigned] [Bug 74416] [CSS Shaders] Report the errors generated when compiling and linking the shaders In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=74416 Ralph T changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208057|review? | Flag| | --- Comment #2 from Ralph T 2013-08-02 23:23:27 PST --- (From update of attachment 208057) I'd like to figure out how to get the file name and correctly propagate the line number through to the console before getting a review on this. Hopefully ANGLE surfaces that in a nice way. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 23:23:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 23:23:51 -0700 Subject: [Webkit-unassigned] [Bug 74416] [CSS Shaders] Report the errors generated when compiling and linking the shaders In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=74416 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |dino at apple.com, | |esprehn+autocc at chromium.org | |, glenn at skynav.com, | |kondapallykalyan at gmail.com, | |mkwst at chromium.org, | |simon.fraser at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 23:30:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 23:30:28 -0700 Subject: [Webkit-unassigned] [Bug 100453] contentEditable: Style of List Item Leaks Through After List End In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=100453 --- Comment #10 from Vani Hegde 2013-08-02 23:30:11 PST --- (In reply to comment #9) > I disagree. As far as user is concerned, it shouldn't matter whether the style is specified on li or on an inline element. > > Specifically, >
                • hello
                • > and >
                • hello
                • > look identical for users. > I agree that the above two cases do not make difference for the user. But I believe here we are speaking about specific case of breaking out of an empty
                • . So here we are either creating 1)
                  /

                  Should we apply the style of

                • to
                  /

                  ? 2)or a new

                • Which will be part of different
                    . If this
                      has a different style property, shouldn't we apply that? If the
                        to which we are adding does not have any style, then we can consider applying the style present in empty
                      • . > Why should the fact the style is specified on li matter at all? It definitely should matter, how can we apply the style specified for
                      • , to a normal text node? Again, both http://jsfiddle.net/rpkMM/ and http://jsfiddle.net/JWdxC/ are examples. What do you think is the right behavior in the above examples. The one we currently have or firefox & IE behavior? Do you mean we should stick on to the current behavior we have? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 2 23:52:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 2 Aug 2013 23:52:32 -0700 Subject: [Webkit-unassigned] [Bug 119464] New: Add srcset support to HTMLPreloadScanner Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119464 Summary: Add srcset support to HTMLPreloadScanner Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yoav at yoav.ws Add srcset support to HTMLPreloadScanner -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 00:02:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 00:02:43 -0700 Subject: [Webkit-unassigned] [Bug 119402] [cmake] Extra compiler flags should be passed for all target In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119402 Nick Diego Yamane (diegoyam) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick.yamane at openbossa.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 00:15:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 00:15:13 -0700 Subject: [Webkit-unassigned] [Bug 119464] Add srcset support to HTMLPreloadScanner In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119464 Yoav Weiss changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208058| |review? Flag| | --- Comment #1 from Yoav Weiss 2013-08-03 00:14:56 PST --- Created an attachment (id=208058) --> (https://bugs.webkit.org/attachment.cgi?id=208058&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 00:20:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 00:20:14 -0700 Subject: [Webkit-unassigned] [Bug 119464] Add srcset support to HTMLPreloadScanner In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119464 Yoav Weiss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yoav at yoav.ws --- Comment #2 from Yoav Weiss 2013-08-03 00:19:57 PST --- The recently landed srcset support (https://bugs.webkit.org/show_bug.cgi?id=110252) lack a HTMlPreloadScanner support. That means that for pages with a script tag at the page's top, images with both "src" and "srcset" attributes will have 2 resources downloaded when only one is needed. (Because the "src" resource is downloaded by the preload scanner). This patch fixes that by adding srcset support to HTMLPreloadScanner. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 00:23:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 00:23:20 -0700 Subject: [Webkit-unassigned] [Bug 119464] Add srcset support to HTMLPreloadScanner In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119464 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |esprehn+autocc at chromium.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 01:21:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 01:21:38 -0700 Subject: [Webkit-unassigned] [Bug 119465] New: htmlformcontrolscollection.namedItem(name) should be returned "Null", if there are no nodes in the collection. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119465 Summary: htmlformcontrolscollection.namedItem(name) should be returned "Null", if there are no nodes in the collection. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: sh919.park at samsung.com According to below Algorithm, htmlformcontrolscollection.namedItem(name),htmloptionscollection.namedItem(name), htmlallcollection.namedItem(name) and htmlformcontrolscollection(name) should be returned "Null", if there are no nodes in the collection. [1][2][3][4]. But undefined is returned in WebKit in this case. ------------------------------------------------------------------------- The namedItem(name) method must act according to the following algorithm: If, at the time the method is called, there is exactly one node in the collection that has either an id attribute or a name attribute equal to name, then return that node and stop the algorithm. Otherwise, if there are no nodes in the collection that have either an id attribute or a name attribute equal to name, then return null and stop the algorithm. Otherwise, create a new RadioNodeList object representing a live view of the HTMLFormControlsCollection object, further filtered so that the only nodes in the RadioNodeList object are those that have either an id attribute or a name attribute equal to name. The nodes in the RadioNodeList object must be sorted in tree order. Return that RadioNodeList object. ------------------------------------------------------------------------- [1] http://www.w3.org/TR/html5/infrastructure.html#dom-htmlformcontrolscollection-nameditem [2] http://www.w3.org/TR/html5/infrastructure.html#dom-htmloptionscollection-nameditem [3] http://www.w3.org/TR/html5/infrastructure.html#dom-htmlallcollection-nameditem [4] http://www.w3.org/TR/html5/infrastructure.html#dom-htmlformcontrolscollection-nameditem -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 01:28:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 01:28:23 -0700 Subject: [Webkit-unassigned] [Bug 119464] Add srcset support to HTMLPreloadScanner In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119464 --- Comment #3 from Joseph Pecoraro 2013-08-03 01:28:07 PST --- (From update of attachment 208058) View in context: https://bugs.webkit.org/attachment.cgi?id=208058&action=review > LayoutTests/fast/hidpi/image-srcset-preload-expected.txt:1 > +WARN: shouldBe() expects string arguments (Just passing by) Looks like an unexpected use of shouldBe below. You should pass the argument as a string and shouldBeFalse will eval it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 04:00:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 04:00:43 -0700 Subject: [Webkit-unassigned] [Bug 119464] Add srcset support to HTMLPreloadScanner In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119464 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE CC| |dino at apple.com --- Comment #4 from Dean Jackson 2013-08-03 04:00:27 PST --- This is a duplicate of Bug 119360 which has a similar patch (that I'm currently reworking). I'll merge the two patches. *** This bug has been marked as a duplicate of bug 119360 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 04:02:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 04:02:34 -0700 Subject: [Webkit-unassigned] [Bug 119464] Add srcset support to HTMLPreloadScanner In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119464 Yoav Weiss changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208058|0 |1 is obsolete| | Attachment #208058|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 04:02:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 04:02:42 -0700 Subject: [Webkit-unassigned] [Bug 119464] Add srcset support to HTMLPreloadScanner In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119464 Yoav Weiss changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208061| |review? Flag| | --- Comment #5 from Yoav Weiss 2013-08-03 04:02:25 PST --- Created an attachment (id=208061) --> (https://bugs.webkit.org/attachment.cgi?id=208061&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 04:05:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 04:05:43 -0700 Subject: [Webkit-unassigned] [Bug 119464] Add srcset support to HTMLPreloadScanner In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119464 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208058| |review- Flag| | --- Comment #6 from Dean Jackson 2013-08-03 04:05:26 PST --- (From update of attachment 208058) Merging with the existing patch and review from 119360. It's very similar. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 04:19:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 04:19:46 -0700 Subject: [Webkit-unassigned] [Bug 24320] Truncation of Expedia.de pages In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=24320 gur.trio at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gur.trio at gmail.com --- Comment #3 from gur.trio at gmail.com 2013-08-03 04:19:29 PST --- Issue is not reproducible on Safari 5.1.7 We can close this issue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 04:25:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 04:25:30 -0700 Subject: [Webkit-unassigned] [Bug 24532] padding ignored when first element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=24532 gur.trio at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gur.trio at gmail.com --- Comment #3 from gur.trio at gmail.com 2013-08-03 04:25:13 PST --- Behaviour is same in firefox, IE, safari and chrome. Guess not any issue anymore , can close. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 04:40:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 04:40:14 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197661|review? |review+ Flag| | --- Comment #29 from Dean Jackson 2013-08-03 04:39:55 PST --- (From update of attachment 197661) View in context: https://bugs.webkit.org/attachment.cgi?id=197661&action=review Looks ok. Just minor comments. > Source/WebCore/ChangeLog:16 > + * html/parser/HTMLPreloadScanner.cpp: > + (WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner): > + (WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest): > + (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): > + (WebCore::TokenPreloadScanner::StartTagScanner::resourceType): > + (WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload): > + (TokenPreloadScanner::StartTagScanner): I'd really like some per-function comments here to make it clear what you're changing. > Source/WebCore/html/parser/HTMLResourcePreloader.h:43 > + return adoptPtr(new PreloadRequest(initiator, resourceURL, baseURL, resourceType, "")); Use String() rather than "". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 04:50:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 04:50:28 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 Andreas Kling changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 05:36:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 05:36:40 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 Yoav Weiss changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197661|0 |1 is obsolete| | Attachment #197661|review+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 05:36:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 05:36:49 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 Yoav Weiss changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208063| |review? Flag| | --- Comment #30 from Yoav Weiss 2013-08-03 05:36:31 PST --- Created an attachment (id=208063) --> (https://bugs.webkit.org/attachment.cgi?id=208063&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 05:39:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 05:39:13 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 --- Comment #31 from WebKit Commit Bot 2013-08-03 05:38:55 PST --- Attachment 208063 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http/tests/loading/preload-css-test-expected.txt', u'LayoutTests/http/tests/loading/preload-css-test.html', u'LayoutTests/http/tests/loading/resources/big_mq.css', u'LayoutTests/http/tests/loading/resources/small_mq.css', u'LayoutTests/http/tests/local/link-stylesheet-load-order-preload-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/parser/HTMLPreloadScanner.cpp', u'Source/WebCore/html/parser/HTMLResourcePreloader.cpp', u'Source/WebCore/html/parser/HTMLResourcePreloader.h']" exit_code: 1 Source/WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:14: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:21: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:22: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:27: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:28: Line contains tab character. [whitespace/tab] [5] Total errors found: 8 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 05:39:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 05:39:24 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208063|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 05:40:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 05:40:17 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208063|review+, commit-queue+ |review-, commit-queue- Flag| | --- Comment #32 from Dean Jackson 2013-08-03 05:39:59 PST --- (From update of attachment 208063) TABS! :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 05:42:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 05:42:40 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 Yoav Weiss changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208063|0 |1 is obsolete| | Attachment #208063|review-, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 05:42:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 05:42:50 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 Yoav Weiss changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208064| |review? Flag| | --- Comment #33 from Yoav Weiss 2013-08-03 05:42:32 PST --- Created an attachment (id=208064) --> (https://bugs.webkit.org/attachment.cgi?id=208064&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 05:44:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 05:44:59 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208064|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 06:42:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 06:42:33 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208064|review+, commit-queue+ | Flag| | --- Comment #34 from WebKit Commit Bot 2013-08-03 06:42:14 PST --- (From update of attachment 208064) Clearing flags on attachment: 208064 Committed r153689: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 06:42:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 06:42:39 -0700 Subject: [Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106198 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #35 from WebKit Commit Bot 2013-08-03 06:42:20 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 07:31:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 07:31:36 -0700 Subject: [Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119082 --- Comment #16 from Mihai Tica 2013-08-03 07:31:20 PST --- Huw(In reply to comment #15) > Were these tests meant to work on Windows as well? / are they port agnostic results? > http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r153658%20(37319)/results.html Hue, saturation, luminosity and color blend modes don't work on mac, but as these tests show, they seem to be functional on Windows. I'll take some time in one of the following days to investigate this issue and find a solution for the failing win tests. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 08:18:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 08:18:47 -0700 Subject: [Webkit-unassigned] [Bug 114872] [GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114872 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207116|0 |1 is obsolete| | Attachment #207116|review?, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 08:19:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 08:19:11 -0700 Subject: [Webkit-unassigned] [Bug 114872] [GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114872 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |mario at webkit.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 10:46:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 10:46:23 -0700 Subject: [Webkit-unassigned] [Bug 119467] New: webaudio/audiobuffersource-loop-points.html always times out Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119467 Summary: webaudio/audiobuffersource-loop-points.html always times out Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Web Audio AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.fraser at apple.com CC: crogers at google.com, jer.noble at apple.com webaudio/audiobuffersource-loop-points.html is timing out all the time: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r153688%20(11437)/results.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 10:49:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 10:49:14 -0700 Subject: [Webkit-unassigned] [Bug 119467] webaudio/audiobuffersource-loop-points.html always times out In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119467 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.fraser at apple.com --- Comment #1 from Simon Fraser (smfr) 2013-08-03 10:48:57 PST --- Skipped in r153690 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 11:33:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 11:33:29 -0700 Subject: [Webkit-unassigned] [Bug 119468] New: [Spatial Navigation] : should prefer focusable elements with absolute positioning over other elements if both elements visible area completely intersects each other. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119468 Summary: [Spatial Navigation] : should prefer focusable elements with absolute positioning over other elements if both elements visible area completely intersects each other. Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: kandalkar.abhijeet58 at gmail.com CC: darin at apple.com, mitz at webkit.org, yael at webkit.org, simon.fraser at apple.com, tonikitoo at webkit.org, gyuyoung.kim at samsung.com, joepeck at webkit.org, cshu at webkit.org, akling at apple.com, kandalkar.abhijeet58 at gmail.com Created an attachment (id=208068) --> (https://bugs.webkit.org/attachment.cgi?id=208068&action=review) Test Steps : 1. Open attached html page :snav-z-index.html in browser. 2. Press DOWN arrow key till you reach to last focusable element s5. Actual Results : User not able to select the elements s2, s3, s4 although they are focusable nodes and visible to user. Expected Results: User should able to select the elements s2, s3, s4 since they are focusable nodes and visible to user. If two or more focusable nodes are completely intersecting each other so that only one of them is visible to user then preference should be given to the node on top.In case of partial intersection, user should able to select select every node visible to him. [NOTE] : Attached snav-z-index.htm file is modified version of layout test example https://svn.webkit.org/repository/webkit/trunk/LayoutTests/fast/spatial-navigation/snav-z-index.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 11:38:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 11:38:11 -0700 Subject: [Webkit-unassigned] [Bug 119468] [Spatial Navigation] : should prefer focusable elements with absolute positioning over other elements if both elements visible area completely intersects each other. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119468 --- Comment #1 from Abhijeet Kandalkar 2013-08-03 11:37:51 PST --- Working on it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 11:42:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 11:42:48 -0700 Subject: [Webkit-unassigned] [Bug 119328] Spatial Navigation not working for the "Anchor" Tag In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119328 Abhijeet Kandalkar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kandalkar.abhijeet58 at gmail. | |com --- Comment #1 from Abhijeet Kandalkar 2013-08-03 11:42:32 PST --- Hi Lejin, Let me know the usecase or web page you are trying.Good to see you here :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 12:00:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 12:00:08 -0700 Subject: [Webkit-unassigned] [Bug 119353] A bit messy layout on Apple webpage with WebKit In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119353 Zalan Bujtas changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #5 from Zalan Bujtas 2013-08-03 11:59:51 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 12:01:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 12:01:16 -0700 Subject: [Webkit-unassigned] [Bug 119353] A bit messy layout on Apple webpage with WebKit In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119353 Zalan Bujtas changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID --- Comment #6 from Zalan Bujtas 2013-08-03 12:00:59 PST --- Content issue. This problem is tracked internally. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 14:14:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 14:14:12 -0700 Subject: [Webkit-unassigned] [Bug 119470] New: hasIndexingHeader() ought really to be a property of an object and its structure, not just its structure Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119470 Summary: hasIndexingHeader() ought really to be a property of an object and its structure, not just its structure Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: fpizlo at apple.com CC: sam at webkit.org, ggaren at apple.com, oliver at apple.com, barraclough at apple.com, msaboff at apple.com, mhahnenberg at apple.com, mark.lam at apple.com Blocks: 119064 Things. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 14:16:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 14:16:02 -0700 Subject: [Webkit-unassigned] [Bug 119470] hasIndexingHeader() ought really to be a property of an object and its structure, not just its structure In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119470 Filip Pizlo changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |fpizlo at apple.com |kit.org | Attachment #208071| |review? Flag| | --- Comment #1 from Filip Pizlo 2013-08-03 14:15:44 PST --- Created an attachment (id=208071) --> (https://bugs.webkit.org/attachment.cgi?id=208071&action=review) the patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 14:49:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 14:49:17 -0700 Subject: [Webkit-unassigned] =?utf-8?q?=5BBug_119472=5D_New=3A_Function=2E?= =?utf-8?q?prototype=2Ecall=28=29_and_=2Eapply=28=29__in_web_worker_can?= =?utf-8?b?4oCZdCBzZXQg4oCYdGhpc+KAmSB0byBnbG9iYWwgb2JqZWN0?= Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119472 Summary: Function.prototype.call() and .apply() in web worker can?t set ?this? to global object Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.8 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore JavaScript AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: flakes at gmail.com Created an attachment (id=208073) --> (https://bugs.webkit.org/attachment.cgi?id=208073&action=review) test cases to reproduce bug 'use strict' // out here, ?this? references the global object (function() { // in here, ?this? is undefined despite being given as first argument to .call() }).call(this); Steps to reproduce: 1. Load attached test page, also available at https://dl.dropboxusercontent.com/u/3736046/test/webworker-call-apply-global/index.html 2. Note that ?typeof this? in test cases is ?undefined? in WebKit nightlies since r153334. Expected behavior: ?this? inside the functions should presumably be set to the web worker global object, like it is in all other tested browsers (release Safari, Firefox, Chrome, Chrome Canary). FWIW, this only seems to happen in strict mode scopes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 17:19:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 17:19:20 -0700 Subject: [Webkit-unassigned] [Bug 119454] Reset scrollbars when frameview load is completed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119454 Roger Fong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208038|0 |1 is obsolete| | Attachment #208038|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 17:19:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 17:19:24 -0700 Subject: [Webkit-unassigned] [Bug 119454] Reset scrollbars when frameview load is completed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119454 Roger Fong changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |roger_fong at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 17:32:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 17:32:13 -0700 Subject: [Webkit-unassigned] [Bug 119435] FrameView should have an isMainFrameView() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119435 Tim Horton changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |thorton at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 17:42:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 17:42:39 -0700 Subject: [Webkit-unassigned] [Bug 119473] New: [CSS Shaders] Validated fragment shaders do too much math Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119473 Summary: [CSS Shaders] Validated fragment shaders do too much math Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ralpht+bugs at gmail.com CC: achicu at adobe.com, mvujovic at adobe.com A trivial CSS fragment shader (empty css_main) performs a mat4 * vec4, at least one vec4 * vec4 and a bunch of things that look like mix. I'd like to: 1. not multiply by css_ColorMatrix unless css_main writes it. 2. add a compositing/blending fast path for some combination of modes. My goal is to do vertex-based lighting with a fragment shader that looks more like: gl_FragColor = texture2D(css_u_texture, css_v_texCoord) * css_MixColor; (1) is easy enough to detect. Is there a combination of compositing and blending that equates to the above shader (or something close to it)? (My motivation is that the current generated shaders run very slowly on IMGTEC SGX GPUs, which generally don't want to do much fragment math). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 3 18:06:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 3 Aug 2013 18:06:13 -0700 Subject: [Webkit-unassigned] [Bug 119473] [CSS Shaders] Validated fragment shaders do too much math In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119473 Ralph T changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ralpht+bugs at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 00:46:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 00:46:38 -0700 Subject: [Webkit-unassigned] [Bug 118974] [GStreamer] Video player sets system volume to 100% In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118974 Xabier Rodr?guez Calvar changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |calvaris at igalia.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 02:10:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 02:10:31 -0700 Subject: [Webkit-unassigned] [Bug 119477] New: [GStreamer] Store preloaded media in webkit's cache Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119477 Summary: [GStreamer] Store preloaded media in webkit's cache Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Platform AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pnormand at igalia.com CC: slomo at circular-chaos.org, calvaris at igalia.com Right now preloaded videos go to ~/.cache but they should be stored in the webkit's cache folder instead. The cache location can be configured using queue2::temp-location property but I'm not sure yet how to access the right queue2 element at runtime. Some investigation is needed :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 04:48:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 04:48:47 -0700 Subject: [Webkit-unassigned] [Bug 119468] [Spatial Navigation] : should prefer focusable elements with absolute positioning over other elements if both elements visible area completely intersects each other. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119468 Abhijeet Kandalkar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208086| |review?, commit-queue? Flag| | --- Comment #2 from Abhijeet Kandalkar 2013-08-04 04:48:27 PST --- Created an attachment (id=208086) --> (https://bugs.webkit.org/attachment.cgi?id=208086&action=review) Updated patch-1 Added changes to modify existing spatial navigation behavior in case of overlapping nodes. Above patch also fixes the bug https://bugs.webkit.org/show_bug.cgi?id=56938 Needs to add seperate layouttest for 56938. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 05:00:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 05:00:34 -0700 Subject: [Webkit-unassigned] [Bug 56938] Unexpected behaviour in spatial navigation with overlapping nodes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=56938 Abhijeet Kandalkar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202921|0 |1 is obsolete| | Attachment #208087| |review?, commit-queue? Flag| | --- Comment #3 from Abhijeet Kandalkar 2013-08-04 05:00:16 PST --- Created an attachment (id=208087) --> (https://bugs.webkit.org/attachment.cgi?id=208087&action=review) Updated patch-1 Patch for bug https://bugs.webkit.org/show_bug.cgi?id=119468 fixes this bug also. Attached patch is a separate layout-test to test the behavior mentioned in this bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 05:30:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 05:30:10 -0700 Subject: [Webkit-unassigned] [Bug 119468] [Spatial Navigation] : should prefer focusable elements with absolute positioning over other elements if both elements visible area completely intersects each other. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119468 Abhijeet Kandalkar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208068|0 |1 is obsolete| | Attachment #208086|0 |1 is obsolete| | Attachment #208086|review?, commit-queue? | Flag| | Attachment #208088| |review?, commit-queue? Flag| | --- Comment #3 from Abhijeet Kandalkar 2013-08-04 05:29:51 PST --- Created an attachment (id=208088) --> (https://bugs.webkit.org/attachment.cgi?id=208088&action=review) Updated patch-2 Please find updated patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 05:34:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 05:34:43 -0700 Subject: [Webkit-unassigned] [Bug 119468] [Spatial Navigation] : should prefer focusable elements with absolute positioning over other elements if both elements visible area completely intersects each other. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119468 Abhijeet Kandalkar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208068|1 |0 is obsolete| | Attachment #208068| |review?, commit-queue? Flag| | --- Comment #4 from Abhijeet Kandalkar 2013-08-04 05:34:24 PST --- (From update of attachment 208068) Please refer test page. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 05:36:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 05:36:07 -0700 Subject: [Webkit-unassigned] [Bug 119468] [Spatial Navigation] : should prefer focusable elements with absolute positioning over other elements if both elements visible area completely intersects each other. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119468 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org --- Comment #5 from WebKit Commit Bot 2013-08-04 05:35:47 PST --- Attachment 208068 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 05:38:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 05:38:38 -0700 Subject: [Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117545 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208011|review?, commit-queue- |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 06:03:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 06:03:43 -0700 Subject: [Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117545 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208011|review+, commit-queue+ | Flag| | --- Comment #9 from WebKit Commit Bot 2013-08-04 06:03:25 PST --- (From update of attachment 208011) Clearing flags on attachment: 208011 Committed r153697: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 06:03:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 06:03:47 -0700 Subject: [Webkit-unassigned] [Bug 117545] [GTK] Remove legacy hack in CodeGeneratorGObject.pm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117545 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #10 from WebKit Commit Bot 2013-08-04 06:03:29 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 07:57:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 07:57:17 -0700 Subject: [Webkit-unassigned] [Bug 119140] REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119140 Michael Saboff changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 07:57:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 07:57:18 -0700 Subject: [Webkit-unassigned] [Bug 119405] REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119405 Bug 119405 depends on bug 119140, which changed state. Bug 119140 Summary: REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer https://bugs.webkit.org/show_bug.cgi?id=119140 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 07:57:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 07:57:19 -0700 Subject: [Webkit-unassigned] [Bug 119433] REGRESSION: ARM Still crashes after change set r153612 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 Bug 119433 depends on bug 119140, which changed state. Bug 119140 Summary: REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer https://bugs.webkit.org/show_bug.cgi?id=119140 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 07:57:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 07:57:58 -0700 Subject: [Webkit-unassigned] [Bug 119433] REGRESSION: ARM Still crashes after change set r153612 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119433 Michael Saboff changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 07:58:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 07:58:30 -0700 Subject: [Webkit-unassigned] [Bug 119405] REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119405 Michael Saboff changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |msaboff at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 09:14:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 09:14:04 -0700 Subject: [Webkit-unassigned] [Bug 119418] [CSS] Introduce new structure to pass image orientation values. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119418 Gyuyoung Kim changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |gyuyoung.kim at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 09:17:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 09:17:25 -0700 Subject: [Webkit-unassigned] [Bug 119478] New: Implement HTML spec change to Adoption Agency Algorithm to not reverse the order of nodes in the document, by removing nodes that we're not recreating from the stack of open elements Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119478 Summary: Implement HTML spec change to Adoption Agency Algorithm to not reverse the order of nodes in the document, by removing nodes that we're not recreating from the stack of open elements Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mike at w3.org http://html5.org/r/8108 https://www.w3.org/Bugs/Public/show_bug.cgi?id=20319#c3 related Blink and Gecko bugs: https://code.google.com/p/chromium/issues/detail?id=268121 https://bugzilla.mozilla.org/show_bug.cgi?id=901319 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 10:06:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 10:06:08 -0700 Subject: [Webkit-unassigned] [Bug 56938] Unexpected behaviour in spatial navigation with overlapping nodes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=56938 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 10:06:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 10:06:11 -0700 Subject: [Webkit-unassigned] [Bug 56938] Unexpected behaviour in spatial navigation with overlapping nodes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=56938 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208087|commit-queue? |commit-queue- Flag| | --- Comment #4 from Build Bot 2013-08-04 10:05:52 PST --- (From update of attachment 208087) Attachment 208087 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1333807 New failing tests: fast/spatial-navigation/snav-overlapping-nodes.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 10:06:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 10:06:14 -0700 Subject: [Webkit-unassigned] [Bug 56938] Unexpected behaviour in spatial navigation with overlapping nodes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=56938 --- Comment #5 from Build Bot 2013-08-04 10:05:55 PST --- Created an attachment (id=208094) --> (https://bugs.webkit.org/attachment.cgi?id=208094&action=review) Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 11:06:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 11:06:18 -0700 Subject: [Webkit-unassigned] [Bug 56938] Unexpected behaviour in spatial navigation with overlapping nodes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=56938 --- Comment #6 from Build Bot 2013-08-04 11:05:59 PST --- (From update of attachment 208087) Attachment 208087 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1339862 New failing tests: fast/spatial-navigation/snav-overlapping-nodes.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 11:06:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 11:06:21 -0700 Subject: [Webkit-unassigned] [Bug 56938] Unexpected behaviour in spatial navigation with overlapping nodes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=56938 --- Comment #7 from Build Bot 2013-08-04 11:06:02 PST --- Created an attachment (id=208096) --> (https://bugs.webkit.org/attachment.cgi?id=208096&action=review) Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 12:21:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 12:21:23 -0700 Subject: [Webkit-unassigned] [Bug 119423] Improve srcset parser In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119423 Benjamin Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |romain.perier at gmail.com |kit.org | CC| |benjamin at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 12:46:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 12:46:52 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208098| |review? Flag| | --- Comment #1 from Andrei Parvu 2013-08-04 12:46:34 PST --- Created an attachment (id=208098) --> (https://bugs.webkit.org/attachment.cgi?id=208098&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 12:49:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 12:49:33 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |esprehn+autocc at chromium.org | |, glenn at skynav.com, | |kondapallykalyan at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 12:54:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 12:54:00 -0700 Subject: [Webkit-unassigned] [Bug 119464] Add srcset support to HTMLPreloadScanner In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119464 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208061|0 |1 is obsolete| | Attachment #208061|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 13:34:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 13:34:42 -0700 Subject: [Webkit-unassigned] [Bug 119479] New: Inserting a JS generated keyframe animation shouldn't trigger a whole document style recalc Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119479 Summary: Inserting a JS generated keyframe animation shouldn't trigger a whole document style recalc Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ralpht+bugs at gmail.com CC: akling at apple.com, ralpht+bugs at gmail.com Created an attachment (id=208099) --> (https://bugs.webkit.org/attachment.cgi?id=208099&action=review) Example of adding an animation via JS which triggers a whole document style recalc Inserting a keyframe animation created in JS causes a full style recalc which can be very expensive on large documents. WebKit doesn't start an animation if it was referenced by a node prior to inserting it, so hopefully it's possible to add a custom keyframe animation for only the time it takes to parse it. The attached example causes a longer style recalc (on L26) when the keyframe rule is added. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 14:32:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 14:32:18 -0700 Subject: [Webkit-unassigned] [Bug 119481] New: Https (lock) element missing in address bar for viewing security certificates Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119481 Summary: Https (lock) element missing in address bar for viewing security certificates Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel URL: https://www.google.com OS/Version: Mac OS X 10.8 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: OftenTheWayfarerWaits at gmail.com Visit any site using https (such as https://www.google.com), and no button appears in the address bar that allows the user to view the security certificates being used on that webpage. Identical sites using latest Safari and other browsers all have security certificates able to be displayed. While webpage is loading, the typical "https [image of lock]" object does appear in the address bar, but disappears after a page is loaded completely. After a webpage completely loads, the address bar should keep this button there to access the important security information it offers about the current security certificates being used. I don't know how far back this problem goes. I only noticed it just now. Observed using WebKit r153570 on 8/4/2013 (Mountain Lion OS) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 15:01:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 15:01:08 -0700 Subject: [Webkit-unassigned] [Bug 119373] webkit-gtk fails to build with bison-3.0 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119373 Sergio Correia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sergio.correia at openbossa.or | |g -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 15:02:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 15:02:41 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 15:02:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 15:02:44 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208098| |commit-queue- Flag| | --- Comment #2 from Build Bot 2013-08-04 15:02:25 PST --- (From update of attachment 208098) Attachment 208098 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1334921 New failing tests: fast/gradients/gradient-on-pseudoelement-crash.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 15:02:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 15:02:46 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 --- Comment #3 from Build Bot 2013-08-04 15:02:28 PST --- Created an attachment (id=208102) --> (https://bugs.webkit.org/attachment.cgi?id=208102&action=review) Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 15:49:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 15:49:23 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 --- Comment #4 from Mario Sanchez Prada 2013-08-04 15:49:05 PST --- (From update of attachment 208021) View in context: https://bugs.webkit.org/attachment.cgi?id=208021&action=review Thanks for the patch Brian. I'm informally reviewing it now, hope you will find my comments useful. Overall, the patch seems to be fine to me, although I see some things that perhaps might not be needed (e.g. the changes related to is_running) and some minor nits. See my comments below... > Tools/ChangeLog:15 > + * Scripts/webkitpy/port/base.py: > + (Port.check_for_leaks): Move is_running flag to base class. I don't really understand why you need to move this here if you are actually not reading this value for gtk, and the same logic could be kept for the mac without having this parameter moved here > Tools/Scripts/webkitpy/port/base.py:384 > - def check_for_leaks(self, process_name, process_pid): > + def check_for_leaks(self, process_name, process_pid, is_running): As mentioned above, it seems to me this change is not actually needed. > Tools/Scripts/webkitpy/port/gtk.py:52 > + raise ValueError('use --wrapper=\"valgrind\" for' > + ' memory leak detection on GTK') No need to split these line in two > Tools/Scripts/webkitpy/port/gtk.py:55 > + self.set_option_default("batch_size", 1000) Where does this 1000 number come from? Is it just personal experience or something else? > Tools/Scripts/webkitpy/port/gtk.py:70 > + multiplier = 10 if self.get_option("leaks") else 1 I think a brief comment here explaining why having a ten times bigger timeout is needed for the "leaks" case would be helpful > Tools/Scripts/webkitpy/port/gtk.py:80 > + # we want to be slow on cleanup as well > + # (for things like ASAN, Valgrind, etc.) Put these two last lines in one. End with a period. > Tools/Scripts/webkitpy/port/gtk.py:104 > + xmlfile = "".join(('\"', self.results_directory(), "/drt-%p-", > + uuid.uuid1().hex, "-leaks.xml", '\"')) No need to split this in two lines. Also, I think you could use os.path.join() better here. > Tools/Scripts/webkitpy/port/gtk.py:112 > + # FIXME: instead we should be using "jhbuild-wrapper --gtk run" instead -> Instead > Tools/Scripts/webkitpy/port/gtk.py:115 > + #environment['LD_LIBRARY_PATH'] = self.path_from_webkit_base( > + # 'WebKitBuild', 'Dependencies', 'Root', 'lib64') Remove these two lines if not needed, otherwise uncomment them and put them in a single line > Tools/Scripts/webkitpy/port/gtk.py:161 > + def check_for_leaks(self, process_name, process_pid, is_running): > + # With Gtk we initiate memory checking by passing valgrind as a wrapper to the test. > + pass As mentioned above, you're not actually reading the is_running value here, so it seems like you do not need it for gtk > Tools/Scripts/webkitpy/port/gtk.py:166 > + # In a subsequent patch the leak xml files will be parsed here. Add a FIXME: prefix here > Tools/Scripts/webkitpy/port/mac.py:153 > - def check_for_leaks(self, process_name, process_pid): > - if not self.get_option('leaks'): > + def check_for_leaks(self, process_name, process_pid, is_running): > + # Only bother to check for leaks or stderr if the process is still running. > + if not self.get_option('leaks') or not is_running: You can't avoid this change, I think, if you just leave the original code in server_process.py untouched, since you are not doing anything special after all in the newly supported port (GTK) > Tools/Scripts/webkitpy/port/server_process.py:335 > - # Only bother to check for leaks or stderr if the process is still running. > - if self.poll() is None: > - self._port.check_for_leaks(self.name(), self.pid()) > + is_running = self.poll() is None > + self._port.check_for_leaks(self.name(), self.pid(), is_running) I think you don't need to do this, and so that you can leave the original code here too. > Tools/Scripts/webkitpy/port/server_process_unittest.py:50 > - def check_for_leaks(self, process_name, process_pid): > + def check_for_leaks(self, process_name, process_pid, is_running): You don't need this change either -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 15:59:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 15:59:45 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 --- Comment #5 from Mario Sanchez Prada 2013-08-04 15:59:27 PST --- (From update of attachment 208021) View in context: https://bugs.webkit.org/attachment.cgi?id=208021&action=review > Tools/Scripts/webkitpy/port/gtk.py:111 > + environment['VALGRIND_OPTS'] = "--tool=memcheck " \ > + "--num-callers=40 --demangle=no --trace-children=no " \ > + "--smc-check=all-non-file --leak-check=yes " \ > + "--leak-resolution=high --show-possibly-lost=no " \ > + "--show-reachable=no --leak-check=full " \ > + " --undef-value-errors=no " \ > + "--gen-suppressions=all --xml=yes --xml-file=%s " % (xmlfile) Also, please keep only one pair --option=value per line, with the first one (--tool=memcheck) starting in the line following the assignment, to improve readability. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 15:59:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 15:59:48 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 --- Comment #6 from Mario Sanchez Prada 2013-08-04 15:59:29 PST --- (From update of attachment 208021) View in context: https://bugs.webkit.org/attachment.cgi?id=208021&action=review > Tools/Scripts/webkitpy/port/gtk.py:111 > + environment['VALGRIND_OPTS'] = "--tool=memcheck " \ > + "--num-callers=40 --demangle=no --trace-children=no " \ > + "--smc-check=all-non-file --leak-check=yes " \ > + "--leak-resolution=high --show-possibly-lost=no " \ > + "--show-reachable=no --leak-check=full " \ > + " --undef-value-errors=no " \ > + "--gen-suppressions=all --xml=yes --xml-file=%s " % (xmlfile) Also, please keep only one pair --option=value per line, with the first one (--tool=memcheck) starting in the line following the assignment, to improve readability. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 16:36:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 16:36:46 -0700 Subject: [Webkit-unassigned] [Bug 119448] [Gtk] Suppress irrelevant or known leaks for Valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119448 --- Comment #2 from Mario Sanchez Prada 2013-08-04 16:36:28 PST --- (From update of attachment 208029) View in context: https://bugs.webkit.org/attachment.cgi?id=208029&action=review Thanks for the patch, Brian. Informal review here: First of all, the patch looks good in general, although there are some problems such as the fact that the patch does not seem to be consistent with the fact that this bug depends on bug 118785 (you're adding some code here that is already proposed as part of the latest patch for that other bug, instead of proposing just the incremental diff compared to that one), or that there are some issues related to coding style that would need fixing before landing. See my comments below... > Tools/Scripts/webkitpy/port/gtk.py:31 > +import uuid This line is already included as part of the latest patch for bug 118785. Please remove it from here. > Tools/Scripts/webkitpy/port/gtk.py:94 > + if self.get_option("leaks"): > + environment['G_SLICE'] = 'always-malloc' > + xmlfile = "".join(('\"', self.results_directory(), "/drt-%p-", > + uuid.uuid1().hex, "-leaks.xml", '\"')) > + suppressionsfile = self.path_from_webkit_base( > + 'Tools', 'valgrind', 'memcheck', 'suppressions.txt') > + environment['VALGRIND_OPTS'] = "--tool=memcheck " \ > + "--num-callers=40 --demangle=no --trace-children=no " \ > + "--smc-check=all-non-file --leak-check=yes " \ > + "--leak-resolution=high --show-possibly-lost=no " \ > + "--show-reachable=no --leak-check=full " \ > + " --undef-value-errors=no " \ > + "--gen-suppressions=all --xml=yes --xml-file=%s " \ As in the previous case commented above, these lines are already included as part of the latest patch for bug 118785. Please remove it from here and leave only the part that is actually added (the --suppressions=%s part) > Tools/Scripts/webkitpy/port/gtk.py:99 > + # FIXME: instead we should be using "jhbuild-wrapper --gtk run" > + # to ensure we get the correct library path. > + #environment['LD_LIBRARY_PATH'] = self.path_from_webkit_base( > + # 'WebKitBuild', 'Dependencies', 'Root', 'lib64') These lines are already part of the other patch too. Please remove them > Tools/Scripts/webkitpy/port/gtk.py:101 > + Extra line. > Tools/valgrind/memcheck/suppressions.txt:1 > +# There are four kinds of suppressions in this file. Please fix this sentence: You mention there are four kinds of suppressions but I could only find three. > Tools/valgrind/memcheck/suppressions.txt:2 > +# 1. third party stuff we have no control over Bad sentence: Start with capitalized word ("Third") and finish with a period. > Tools/valgrind/memcheck/suppressions.txt:5 > +# 2. intentional unit test errors, or stuff that is somehow a false positive > +# in our own code, or stuff that is so trivial it's not worth fixing Likewise. > Tools/valgrind/memcheck/suppressions.txt:8 > +# These should all be in webkit's bug tracking system (but a few aren't yet). webkit -> WebKit > Tools/valgrind/memcheck/suppressions.txt:13 > +# 1. third party stuff we have no control over Bad sentence: Start with capitalized word ("Third") and finish with a period. > Tools/valgrind/memcheck/suppressions.txt:15 > + #gtk developers don't like cleaning up one-time leaks. See http://mail.gnome.org/archives/gtk-devel-list/2004-April/msg00230.html Missing space at the beginning, missing period at the end and bad capitalization: "#gtk developers" -> "# GTK developers" Also, you have two spaces between the period and "See". Please replace those spaces with a line break instead > Tools/valgrind/memcheck/suppressions.txt:29 > + FcConfigAppFontAddFile_leak This underscore here is not needed (and inconsistent with what you are doing in other places (e.g. the previous two suppressions). Also, I would probably call this "Fontconfig leak 1" for consistency with the rest of the file (see my following comments below) > Tools/valgrind/memcheck/suppressions.txt:36 > + # See also http://www.gnome.org/~johan/gtk.suppression > + # (which has a smattering of similar pango suppressions) Missing period at the end of the line > Tools/valgrind/memcheck/suppressions.txt:37 > + pango_font_leak_todo Underscores not needed, and name not consistent with others. What about "Fontconfig leak 2"? > Tools/valgrind/memcheck/suppressions.txt:45 > + pango_font_leak_todo_2 "Fontconfig leak 3"? > Tools/valgrind/memcheck/suppressions.txt:55 > + pango_font_leak_todo_3 "Fontconfig leak 4"? Same applies to many other names in this file. Please try to get a rule for naming suppressions and stick to it, for the sake of consistency (and remember you do not need to use underscores here) > Tools/valgrind/memcheck/suppressions.txt:63 > + pango_font_leak_todo_4 "Fontcontig leak 5"? (last nit of this kind that I mention, please fix the others) > Tools/valgrind/memcheck/suppressions.txt:88 > + # Similar to fontconfig_bug_8428 below. Reported in > + # https://bugs.freedesktop.org/show_bug.cgi?id=8215 Missing period at the end. > Tools/valgrind/memcheck/suppressions.txt:98 > + # Fontconfig leak, seen in shard 16 of 20 of ui_tests > + # See https://bugs.freedesktop.org/show_bug.cgi?id=8428 > + # and http://www.gnome.org/~johan/gtk.suppression Likewise > Tools/valgrind/memcheck/suppressions.txt:116 > + fontconfig_bug (Third Party) Please notice you have extra unneeded spaces in this line while fixing its name > Tools/valgrind/memcheck/suppressions.txt:176 > + dlopen leak on error. See http://sourceware.org/bugzilla/show_bug.cgi?id=12878. Be consistent: Please either you put the "See http://..." string in the previous line as a comment preceeded by "#", or you just avoid using comments at all and you always bundle the "Seeh http://..." string along with the name of the rules. I personally think the first option is better. > Tools/valgrind/memcheck/suppressions.txt:203 > + # array of weak references freed but not processed? Bad capitalization at the beginning. Missing period at the end of the line. > Tools/valgrind/memcheck/suppressions.txt:211 > + http://sources.redhat.com/bugzilla/show_bug.cgi?id=5171 You never used an URL before as the name of the suppression. As I mentioned before, please be consistent. > Tools/valgrind/memcheck/suppressions.txt:283 > + Gtk leaks an X11 window bug_96402 (Third party) Extra space before "Gtk". Also, it is GTK or GTK+, but not Gtk. > Tools/valgrind/memcheck/suppressions.txt:299 > + Gtk leaks a cairo context (large leak) Gtk -> GTK > Tools/valgrind/memcheck/suppressions.txt:309 > + leaks in bash leaks -> Leaks > Tools/valgrind/memcheck/suppressions.txt:343 > +# XRandRInfo object seems to be leaking inside XRRFindDisplay. This happens the > +# first time it is called, no matter who the caller is. We have observed this > +# problem with both XRRSelectInput and XRRQueryExtension. Extra blank spaces that are not needed after the two first periods. > Tools/valgrind/memcheck/suppressions.txt:351 > + Flash Player Leak Flash Player Leak -> Flash player leak > Tools/valgrind/memcheck/suppressions.txt:426 > + cairo pixman image allocate Part of this sentence is a function name, so I would put something like "Cairo _pixman_image_allocate leak" > Tools/valgrind/memcheck/suppressions.txt:514 > + AtkProperty is cached but not released (see https://bugs.webkit.org/show_bug.cgi?id=118567#c2) Again, please be consistent with naming and URLs > Tools/valgrind/memcheck/suppressions.txt:526 > + AtkRelationSet is never freed because the target AtkObject is cached https://bugs.webkit.org/show_bug.cgi?id=118567 Ditto. > Tools/valgrind/memcheck/suppressions.txt:545 > +# 2. intentional unit test errors, or stuff that is somehow a false positive > +# in our own code, or stuff that is so trivial it's not worth fixing Bad sentence: Start with capitalized word ("Third") and finish with a period. > Tools/valgrind/memcheck/suppressions.txt:646 > + Leak webkitAccessibleNew https://bugs.webkit.org/show_bug.cgi?id=118382 Same comment about consistency on names and URLs > Tools/valgrind/memcheck/suppressions.txt:655 > + Leak atk title https://bugs.webkit.org/show_bug.cgi?id=118385 Likewise > Tools/valgrind/memcheck/suppressions.txt:665 > + Leak PluginObject in exceptional circumstances https://bugs.webkit.org/show_bug.cgi?id=118528 Likewise > Tools/valgrind/memcheck/suppressions.txt:675 > + TextCodecICU::registerCodecs is leaking https://bugs.webkit.org/show_bug.cgi?id=118505 Likewise -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 16:54:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 16:54:30 -0700 Subject: [Webkit-unassigned] [Bug 119478] Implement HTML spec change to Adoption Agency Algorithm to not reverse the order of nodes in the document, by removing nodes that we're not recreating from the stack of open elements In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119478 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rniwa at webkit.org, | |sam at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 17:13:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 17:13:47 -0700 Subject: [Webkit-unassigned] [Bug 119446] [GTK] Parse Valgrind xml leak files In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119446 --- Comment #5 from Mario Sanchez Prada 2013-08-04 17:13:29 PST --- (From update of attachment 208024) View in context: https://bugs.webkit.org/attachment.cgi?id=208024&action=review Quick informal review. Mostly coding style issues and some small issues > Tools/Scripts/webkitpy/port/common.py:37 > +import logging > +import platform > +import os > +import signal > +import subprocess > +import sys > +import time Please use alphabetical order > Tools/Scripts/webkitpy/port/common.py:39 > + Extra line > Tools/Scripts/webkitpy/port/common.py:43 > + > + Two empty lines here, while one would be enough between definitions. Please fix all across the file (it happens all the time in this patch) > Tools/Scripts/webkitpy/port/common.py:55 > + """ Runs a subprocess, until it finishes or |timeout| is exceeded and the Extra space before "Runs" > Tools/Scripts/webkitpy/port/common.py:266 > + """ Prints out the list of used suppressions in a format common to all the Extra space after the """ > Tools/Scripts/webkitpy/port/gdb_helper.py:40 > + Extra line here too > Tools/Scripts/webkitpy/port/gdb_helper.py:42 > + ''' Parse the gdb output line, return a pair (file, line num) ''' You use ''' instead of """ in this file for documenting functions. Please use """ always (to be consistent), avoid the extra space at the beginning and the end, and finish the sentence with a period > Tools/Scripts/webkitpy/port/gdb_helper.py:49 > + > + As in the other file, please use one empty line only to mark separation between defined functions > Tools/Scripts/webkitpy/port/gdb_helper.py:51 > + ''' For each address, return a pair (file, line num) ''' Use """ and period at the end, and avoid the extra spaces for consistency. Please fix further functions in this file too > Tools/Scripts/webkitpy/port/gtk.py:133 > + # FIXME: This will include too many leaks in subsequent runs until the results directory is cleared! Why we don't just clear the directory automatically each time this logic is run, right at the start? That way, you would have the results available after one execution as long as you haven't triggered a new one, giving you time enough to copy them to a safe location in case you want to keep them > Tools/Scripts/webkitpy/port/gtk_leakdetector.py:35 > + Extra line > Tools/Scripts/webkitpy/port/gtk_leakdetector.py:47 > + self._memcheck_leak_analyzer = MemcheckAnalyzer(port.webkit_base(), > + use_gdb=False) You can make this a single line > Tools/Scripts/webkitpy/port/gtk_leakdetector.py:54 > + return self._filesystem.glob(self._filesystem.join(directory, > + "*-leaks.xml")) Likewise > Tools/Scripts/webkitpy/port/memcheck_analyze.py:63 > + Extra line > Tools/Scripts/webkitpy/port/memcheck_analyze.py:75 > + Extra line. Please fix the rest like this one in this file > Tools/Scripts/webkitpy/port/memcheck_analyze.py:94 > + prefixes_to_cut = ["build/src/", "valgrind/coregrind/", > + "out/Release/../../"] This can be made just one line, as in the original version of the file > Tools/Scripts/webkitpy/port/memcheck_analyze.py:140 > + # Try using gdb Missing period at the end > Tools/Scripts/webkitpy/port/memcheck_analyze.py:245 > + self._backtraces.append([description, > + gatherFrames(node, source_dir)]) Make this one single line, as in the original version of the code > Tools/Scripts/webkitpy/port/memcheck_analyze.py:282 > + buf += (frame[FUNCTION_NAME] or \ > + frame[INSTRUCTION_POINTER]) + "\n" Make this one single line, as in the original version of the code > Tools/Scripts/webkitpy/port/memcheck_analyze.py:296 > + foo = TheAddressTable.GetFileLine( > + frame[OBJECT_FILE], > + frame[INSTRUCTION_POINTER]) Make this one line > Tools/Scripts/webkitpy/port/memcheck_analyze.py:302 > + output += (" (" + frame[SRC_FILE_DIR] + > + "/" + frame[SRC_FILE_NAME] + > + ":" + frame[SRC_LINE] + ")") These three lines can be only one too > Tools/Scripts/webkitpy/port/memcheck_analyze.py:323 > + # Widen suppression slightly to make portable between mac and linux > + # TODO(timurrrr): Oops, these transformations should happen > + # BEFORE calculating the hash! Missing periods at the end of sentences > Tools/Scripts/webkitpy/port/memcheck_analyze.py:330 > + # Split into lines so we can enforce length limits Missing period > Tools/Scripts/webkitpy/port/memcheck_analyze.py:406 > + if prev_line.strip() in ["", > + "", > + ""]: This can be one line too -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 18:53:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 18:53:54 -0700 Subject: [Webkit-unassigned] [Bug 119478] Implement HTML spec change to Adoption Agency Algorithm to not reverse the order of nodes in the document, by removing nodes that we're not recreating from the stack of open elements In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119478 --- Comment #1 from Ryosuke Niwa 2013-08-04 18:53:36 PST --- I don't understand why this specification change was made when all browsers behave according to the old specification. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 19:14:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 19:14:57 -0700 Subject: [Webkit-unassigned] [Bug 119482] New: Waste work in CustomFilterValidatedProgram(), MediaController() and ArrayBuffer() Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119482 Summary: Waste work in CustomFilterValidatedProgram(), MediaController() and ArrayBuffer() Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pchang9 at cs.wisc.edu The problem appears in revision 153701. I have attached simple one-line patches that fixes it. In method ustomFilterValidatedProgram::rewriteMixVertexShader() in WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp, the loop on line 228 should break immediately after "texCoordAttributeDefined" is set to "true". All the iterations after "texCoordAttributeDefined" is set to "true" do not perform any useful work, at best they just set "texCoordAttributeDefined" again to "true". Similarly, method MediaController::hasEnded() in WebCore/html/MediaController.cpp, the loop on line 528 should break immediately after "allHaveEnded" is set to "false". Method ArrayBuffer::transfer() in WTF/wtf/ArrayBuffer.cpp, the loop on line 46 should break immediately after "allViewsAreNeuterable" is set to "false". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 19:17:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 19:17:17 -0700 Subject: [Webkit-unassigned] [Bug 119482] Waste work in CustomFilterValidatedProgram(), MediaController() and ArrayBuffer() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119482 --- Comment #1 from Po-Chun Chang 2013-08-04 19:16:59 PST --- Created an attachment (id=208105) --> (https://bugs.webkit.org/attachment.cgi?id=208105&action=review) Suggested patch part 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 19:17:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 19:17:44 -0700 Subject: [Webkit-unassigned] [Bug 119482] Waste work in CustomFilterValidatedProgram(), MediaController() and ArrayBuffer() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119482 --- Comment #2 from Po-Chun Chang 2013-08-04 19:17:26 PST --- Created an attachment (id=208106) --> (https://bugs.webkit.org/attachment.cgi?id=208106&action=review) Suggested patch part 2 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 19:18:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 19:18:02 -0700 Subject: [Webkit-unassigned] [Bug 119482] Waste work in CustomFilterValidatedProgram(), MediaController() and ArrayBuffer() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119482 --- Comment #3 from Po-Chun Chang 2013-08-04 19:17:44 PST --- Created an attachment (id=208107) --> (https://bugs.webkit.org/attachment.cgi?id=208107&action=review) Suggested patch part 3 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 19:22:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 19:22:30 -0700 Subject: [Webkit-unassigned] [Bug 119465] htmlformcontrolscollection.namedItem(name) should be returned "Null", if there are no nodes in the collection. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119465 Sanghyun Park changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 21:51:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 21:51:34 -0700 Subject: [Webkit-unassigned] [Bug 119478] Implement HTML spec change to Adoption Agency Algorithm to not reverse the order of nodes in the document, by removing nodes that we're not recreating from the stack of open elements In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119478 --- Comment #2 from Michael[tm] Smith 2013-08-04 21:51:16 PST --- (In reply to comment #1) > I don't understand why this specification change was made when all browsers behave according to the old specification. Because the existing behavior is buggy in that it causes nodes to end up in the DOM in (from users perspective) an unexpected order; e.g., the text content of the following div ending up as "456123" instead of "123456".
                        456 Yeah, it's very invalid markup but dealing gracefully with invalid markup is entirely what this whole part of the parsing algorithm is all about. So this is a bug in the behavior of what the AAA is intended for, and if it's possible to have the spec get rid of the existing bug in the algorithm and handle that case more intuitively, then I think the right thing for Hixie or any other editor to do is to fix it in the spec if he can and then to try to see if browsers are willing to implement the revised algorithm or not. Of course it's collectively up to browser implementors to decide if they want to make the change. But for a case like this, having concrete spec text to review in context seems to me a least to be a lot better than just having an isolated proposal written in an e-mail message or whatever. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 22:22:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 22:22:55 -0700 Subject: [Webkit-unassigned] [Bug 119328] Spatial Navigation not working for the "Anchor" Tag In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119328 --- Comment #2 from Jose Lejin PJ 2013-08-04 22:22:37 PST --- Created an attachment (id=208109) --> (https://bugs.webkit.org/attachment.cgi?id=208109&action=review) Test App -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 22:41:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 22:41:24 -0700 Subject: [Webkit-unassigned] [Bug 84761] webkit fails IETC column-filling-001.htm In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=84761 G?rard Talbot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |browserbugs at gtalbot.org --- Comment #1 from G?rard Talbot 2013-08-04 22:41:06 PST --- Not true. Columns, by default, are filled in a balanced manner. " 7.1. ?column-fill? Name: column-fill Value: auto | balance Initial: balance Applies to: multicol elements " http://www.w3.org/TR/css3-multicol/#cf And this is the case for this test as column-fill is not declared. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 23:22:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 23:22:20 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 --- Comment #4 from Andrei Parvu 2013-08-04 23:22:01 PST --- I don't think the failing test has anything to do with my patch, it also fails when running it on a branch which doesn't have the repeat space changes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 23:23:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 23:23:00 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krit at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 23:44:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 23:44:57 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 --- Comment #5 from Dirk Schulze 2013-08-04 23:44:38 PST --- (In reply to comment #4) > I don't think the failing test has anything to do with my patch, it also fails when running it on a branch which doesn't have the repeat space changes. The background code can be fragile. Especially gradients code is likely to be caused by changes to background. Can you elaborate and make sure that it is not your fault? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 23:50:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 23:50:52 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208098|review? |review- Flag| | --- Comment #6 from Dirk Schulze 2013-08-04 23:50:33 PST --- (From update of attachment 208098) View in context: https://bugs.webkit.org/attachment.cgi?id=208098&action=review r- because of some change request. I didn't check the change in ModelObject yet. > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). You need to explain what you do, why you do it and why this is the right thing to archive the right behavior. > Source/WebCore/ChangeLog:24 > + (WebCore::RenderBoxModelObject::paintFillLayerExtended): > + (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Smaller inline comments can help to understand what you do. > Source/WebCore/platform/graphics/cg/ImageCG.cpp:136 > + // On Leopard and newer, this code now only runs for partially decoded images whose buffers do not yet match the overall size of the image. > + static const CGPatternCallbacks patternCallbacks = { 0, drawPatternCallback, 0 }; > + CGAffineTransform matrix = CGAffineTransformMake(narrowPrecisionToCGFloat(patternTransform.a()), 0, 0, narrowPrecisionToCGFloat(patternTransform.d()), adjustedX, adjustedY); > + matrix = CGAffineTransformConcat(matrix, CGContextGetCTM(context)); > + // The top of a partially-decoded image is drawn at the bottom of the tile. Map it to the top. > + matrix = CGAffineTransformTranslate(matrix, 0, size().height() - h); > + RetainPtr pattern = adoptCF(CGPatternCreate(subImage.get(), CGRectMake(0, 0, tileRect.width(), tileRect.height()), > + matrix, tileRect.width() + spaceSize().width(), tileRect.height() + spaceSize().height(), > + kCGPatternTilingConstantSpacing, true, &patternCallbacks)); > + if (!pattern) > + return; > + It would be great if you can use the Pattern class already in WebKit to do that, so that it works in all ports, not just Mac. You may need to add some more code to Pattern to make that possible. Can you check this first please? Resetting review flag for now. > LayoutTests/css3/background/background-repeat-border-expected.html:16 > + var urls = Array(), size = Array(), position = Array(), repeat = Array(), > + origin = Array(), clip = Array(); Does that all need to be JS? Can't you just write a simple test case to make sure that it works? > LayoutTests/css3/background/background-repeat-border-expected.html:18 > + function addMasks() { If you are testing background, then mask might be misleading. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 4 23:51:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 4 Aug 2013 23:51:28 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208030|commit-queue? |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 00:12:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 00:12:00 -0700 Subject: [Webkit-unassigned] [Bug 107386] [SVG2] Merge SVGStyledElement and SVGElement In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=107386 --- Comment #2 from Christophe Dumez 2013-08-05 00:11:38 PST --- Follow up Blink patches: https://src.chromium.org/viewvc/blink?revision=155426&view=revision https://src.chromium.org/viewvc/blink?revision=155469&view=revision -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 00:15:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 00:15:09 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208030|review+, commit-queue+ | Flag| | --- Comment #9 from WebKit Commit Bot 2013-08-05 00:14:50 PST --- (From update of attachment 208030) Clearing flags on attachment: 208030 Committed r153702: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 00:15:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 00:15:13 -0700 Subject: [Webkit-unassigned] [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119434 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #10 from WebKit Commit Bot 2013-08-05 00:14:54 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 00:39:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 00:39:08 -0700 Subject: [Webkit-unassigned] [Bug 117281] Crash in V8 benchmarks set in ARM, softfp, EABI In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117281 Peng Xinchao changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xinchao.peng at samsung.com --- Comment #53 from Peng Xinchao 2013-08-05 00:38:48 PST --- why nobody review the patch? I think the patch is ok .Does it have other issue? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 01:46:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 01:46:00 -0700 Subject: [Webkit-unassigned] [Bug 119483] New: XMLTreeViewer should be created only in the XML viewer mode Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119483 Summary: XMLTreeViewer should be created only in the XML viewer mode Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: XML AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: vivekg at webkit.org CC: rniwa at webkit.org XMLTreeViewer is created even for the XSL transform. This should be avoided. It should also remove unnecessary conditional check while deciding for XML viewer mode. These patches are already reviewed in blink. Combining these relevant patches into a single patch for webkit. https://codereview.chromium.org/19552003/ https://codereview.chromium.org/22150003/ Patch follows. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 01:49:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 01:49:00 -0700 Subject: [Webkit-unassigned] [Bug 89697] [JSC] CSSStyleDeclaration report incorrect descriptor In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=89697 Manuel Rego Casasnovas changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204064|0 |1 is obsolete| | Attachment #204064|review-, commit-queue? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 01:49:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 01:49:07 -0700 Subject: [Webkit-unassigned] [Bug 89697] [JSC] CSSStyleDeclaration report incorrect descriptor In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=89697 Manuel Rego Casasnovas changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208111| |review?, commit-queue? Flag| | --- Comment #5 from Manuel Rego Casasnovas 2013-08-05 01:48:48 PST --- Created an attachment (id=208111) --> (https://bugs.webkit.org/attachment.cgi?id=208111&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 01:49:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 01:49:19 -0700 Subject: [Webkit-unassigned] [Bug 119373] webkit-gtk fails to build with bison-3.0 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119373 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |gns at gnome.org, | |mrobinson at webkit.org, | |zandobersek at gmail.com Ever Confirmed|0 |1 --- Comment #1 from Zan Dobersek 2013-08-05 01:49:01 PST --- Confirmed. There are already generated glslang_tab.cpp and glslang_tab.h files in the ANGLE directory, produced by Bison 2.7[1]. The third-party sources have these two files regenerated with Bison 2.3, for Mac port's purposes. The GTK port regenerates these with the Bison it finds during the configuration. With Bison 3.0, the generated files are causing compilation errors. Could the GTK port switch to building the files that were generated with Bison 2.3, just like the Mac port? Also, only the GTK port generates and compiles the glslang.cpp file, so this part could possibly be removed. [1] https://code.google.com/p/angleproject/source/browse/src/compiler/glslang_tab.cpp -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 01:54:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 01:54:27 -0700 Subject: [Webkit-unassigned] [Bug 119395] Crash in JSCell::methodTable under errorDescriptionForValue() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119395 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.sfgate.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 01:54:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 01:54:47 -0700 Subject: [Webkit-unassigned] [Bug 119483] XMLTreeViewer should be created only in the XML viewer mode In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119483 Vivek Galatage changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |vivekg at webkit.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 02:31:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 02:31:01 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 Krzysztof Czech changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #8 from Krzysztof Czech 2013-08-05 02:30:42 PST --- I'm reopening this bug. Crash still occurs, I guess even on gtk port as well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 02:36:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 02:36:19 -0700 Subject: [Webkit-unassigned] [Bug 115966] [GTK] Add a cmake build In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115966 Simon Pena changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.pena at samsung.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 02:47:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 02:47:52 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Jocelyn Turcotte changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207926|review? |review- Flag| | --- Comment #53 from Jocelyn Turcotte 2013-08-05 02:47:33 PST --- (From update of attachment 207926) View in context: https://bugs.webkit.org/attachment.cgi?id=207926&action=review > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:136 > + // Must match with values of PageVisibilityState enum from PageVisibilityState.h. I think we should do a switch-case matching in QWebPageAdapter::setVisibilityState to make sure that the enum values are independent from WebCore. It's usually not a good idea to have the public header follow internal enums directly. > Source/WebKit/qt/WidgetApi/qwebpage.cpp:3161 > + \note The initial state is set to PageVisibilityStateHidden if the page visibility API is enabled, > + otherwise is set to PageVisibilityApiUnavailable. What about all applications out there not knowing about this new API, isn't it a bad default to have page told that they are hidden even though they are shown? > Source/WebKit/qt/WidgetApi/qwebpage.h:220 > + // Must match with values of PageVisibilityState enum from QWebPageAdapter.h. Please leave this information in QWebPageAdapter.h not to pollute the public header. > Source/WebKit/qt/WidgetApi/qwebpage.h:226 > + PageVisibilityApiUnavailable We should simply enable the compile-time flag all the time if we're exposing the API. A feature is usually not enabled only if it isn't implemented or ready. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 03:00:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 03:00:12 -0700 Subject: [Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118445 --- Comment #37 from Allan Sandfeld Jensen 2013-08-05 02:59:53 PST --- (From update of attachment 207669) View in context: https://bugs.webkit.org/attachment.cgi?id=207669&action=review > Source/WebKit/qt/Api/qwebsettings.cpp:516 > + \value UseNativeVirtualKeyAsDOMKey Specifies whether to use QKeyEvent::nativeVirtualKey as a DOM keyCode > + value. It might be useful for sending domain specific key values to Web Application. It is disabled > + by default. Specifies whether to use QKeyEvent::nativeVirtualKey as the DOM KeyboardEvent keyCode value instead of Windows virtual key codes. This can be used to send domain specific key values to a Web Application. This is disabled by default. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 03:04:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 03:04:11 -0700 Subject: [Webkit-unassigned] [Bug 115966] [GTK] Add a cmake build In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115966 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brian.holt at samsung.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 03:32:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 03:32:12 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 --- Comment #9 from Krzysztof Czech 2013-08-05 03:31:53 PST --- The crash seems to appear while calling parent->platformUIElement(). This method returns PlatformUIElement type which is a GRefPtr. I believe in this context: AtkObject* atkParent = parent ? parent->platformUIElement().get() : 0; platformUIElement().get(), before get() is called, the temporary PlatformUIElement is created and refGPtr(ptr) is called where ptr is a GRefPtr. I think, that's way g_object_ref_sink protests. I guess platformUIElement could be specialized for ATK so that it could return AtkObject*. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 03:41:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 03:41:53 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 --- Comment #10 from Krzysztof Czech 2013-08-05 03:41:35 PST --- While testing this approach with specialized platformUIElement (I called it platformUIElementAtk()), I did find this crash, but another one appeared: 1 0xb7033767 2 0xb7186288 3 0xb3ed5627 atk_object_get_role 4 0xafb9b568 5 0xafb9d173 WTR::AccessibilityUIElement::allAttributes() 6 0xafb8ec47 WTR::JSAccessibilityUIElement::allAttributes(OpaqueJSContext const*, OpaqueJSVal ue*, OpaqueJSValue*, unsigned int, OpaqueJSValue const* const*, OpaqueJSValue const**) 7 0xb6c79292 long long JSC::APICallbackFunction::call(JSC::ExecState *) 8 0xb7025035 9 0xb702c448 10 0xb7032ee3 11 0xb6e4d3cb JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 03:43:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 03:43:00 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 --- Comment #11 from Krzysztof Czech 2013-08-05 03:42:40 PST --- (In reply to comment #10) > ... I did find this crash ... I did not find this crash -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 03:51:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 03:51:00 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 --- Comment #54 from Benjamin Dupont 2013-08-05 03:50:40 PST --- (In reply to comment #53) > (From update of attachment 207926 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207926&action=review > > > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:136 > > + // Must match with values of PageVisibilityState enum from PageVisibilityState.h. > > I think we should do a switch-case matching in QWebPageAdapter::setVisibilityState to make sure that the enum values are independent from WebCore. It's usually not a good idea to have the public header follow internal enums directly. Initially I made a switch-case and then I delete it... :) For the default value, should I return the hidden value? > > > Source/WebKit/qt/WidgetApi/qwebpage.cpp:3161 > > + \note The initial state is set to PageVisibilityStateHidden if the page visibility API is enabled, > > + otherwise is set to PageVisibilityApiUnavailable. > > What about all applications out there not knowing about this new API, isn't it a bad default to have page told that they are hidden even though they are shown? I agree, in the current implementation if the visibility API isn't enable the visibility attributes are available even so and set to hidden. That's why I used this default value. > > > Source/WebKit/qt/WidgetApi/qwebpage.h:220 > > + // Must match with values of PageVisibilityState enum from QWebPageAdapter.h. > > Please leave this information in QWebPageAdapter.h not to pollute the public header. Ok. > > > Source/WebKit/qt/WidgetApi/qwebpage.h:226 > > + PageVisibilityApiUnavailable > > We should simply enable the compile-time flag all the time if we're exposing the API. A feature is usually not enabled only if it isn't implemented or ready. In this case should I remove all PAGE_VISIBILITY_API references: Source/WTF/wtf/FeatureDefines.h Source/WebCore/dom/Document.cpp Source/WebCore/dom/Document.h Source/WebCore/page/Frame.cpp Source/WebCore/page/Frame.h Source/WebCore/page/Page.cpp Source/WebCore/page/Page.h Source/WebCore/page/PageVisibilityState.cpp Source/WebCore/page/PageVisibilityState.h Source/WebCore/page/Settings.cpp Source/WebCore/page/Settings.h Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp Tools/Scripts/webkitperl/FeatureList.pm Tools/qmake/mkspecs/features/features.pri And WebKit2 files? Or just doing the assumption that this feature is always enabled in QWebPageAdapter? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 03:59:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 03:59:08 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Jocelyn Turcotte changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jocelyn.turcotte at digia.com --- Comment #55 from Jocelyn Turcotte 2013-08-05 03:58:49 PST --- (In reply to comment #54) > > > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:136 > > > + // Must match with values of PageVisibilityState enum from PageVisibilityState.h. > Initially I made a switch-case and then I delete it... :) For the default value, should I return the hidden value? The default shouldn't happen as we should still try to maintain the match between the enums. So just put an ASSERT(FALSE) and return any reasonable default value. > I agree, in the current implementation if the visibility API isn't enable the visibility attributes are available even so and set to hidden. That's why I used this default value. From bugzilla-daemon at webkit.org Mon Aug 5 04:10:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 04:10:27 -0700 Subject: [Webkit-unassigned] [Bug 119484] New: [WK2] REGRESSION(r138378): Keyboard scrolling does not work with delegated scrolling Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119484 Summary: [WK2] REGRESSION(r138378): Keyboard scrolling does not work with delegated scrolling Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit2 AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: allan.jensen at digia.com Blocks: 105632 Keyboard and mousewheel scrolling depends on the existance of a scrollbar in FrameView even if the scrollbars are invisible. The patch in bug #105632 removed those scrollbars, and made a work-around for wheel scrolling. Unfortunately this broke keyboards scrolling. There is no easy way around this issue without scrollbars since the scrollbar objects are currently used to keep track of page-step which is required for page-down and page-up. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 04:27:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 04:27:29 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 --- Comment #7 from Andrei Parvu 2013-08-05 04:27:09 PST --- > > Source/WebCore/platform/graphics/cg/ImageCG.cpp:136 > > + // On Leopard and newer, this code now only runs for partially decoded images whose buffers do not yet match the overall size of the image. > > + static const CGPatternCallbacks patternCallbacks = { 0, drawPatternCallback, 0 }; > > + CGAffineTransform matrix = CGAffineTransformMake(narrowPrecisionToCGFloat(patternTransform.a()), 0, 0, narrowPrecisionToCGFloat(patternTransform.d()), adjustedX, adjustedY); > > + matrix = CGAffineTransformConcat(matrix, CGContextGetCTM(context)); > > + // The top of a partially-decoded image is drawn at the bottom of the tile. Map it to the top. > > + matrix = CGAffineTransformTranslate(matrix, 0, size().height() - h); > > + RetainPtr pattern = adoptCF(CGPatternCreate(subImage.get(), CGRectMake(0, 0, tileRect.width(), tileRect.height()), > > + matrix, tileRect.width() + spaceSize().width(), tileRect.height() + spaceSize().height(), > > + kCGPatternTilingConstantSpacing, true, &patternCallbacks)); > > + if (!pattern) > > + return; > > + > > It would be great if you can use the Pattern class already in WebKit to do that, so that it works in all ports, not just Mac. You may need to add some more code to Pattern to make that possible. Can you check this first please? Resetting review flag for now. That code was already there (except the adding of 'spaceSize'). I will try using the Pattern class but it would require some changes (you have to pass a CGImageRef to it which you currently cannot). > > LayoutTests/css3/background/background-repeat-border-expected.html:16 > > + var urls = Array(), size = Array(), position = Array(), repeat = Array(), > > + origin = Array(), clip = Array(); > > Does that all need to be JS? Can't you just write a simple test case to make sure that it works? I wanted some tests with masks which are being repeated a bigger number of times - adding 12 masks manually seemed ugly :). Though I can get rid of the repeat, origin and clip arrays, apparently I only need to specifiy them once. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 04:33:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 04:33:06 -0700 Subject: [Webkit-unassigned] [Bug 119485] New: [WebGL] validateRenderingState method name change Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119485 Summary: [WebGL] validateRenderingState method name change Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebGL AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: p.szymanski3 at samsung.com validateRenderingState method has wrong name. This method validates only vertex attributes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 04:37:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 04:37:42 -0700 Subject: [Webkit-unassigned] [Bug 119485] [WebGL] validateRenderingState method name change In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119485 Przemyslaw Szymanski changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208117| |review? Flag| | --- Comment #1 from Przemyslaw Szymanski 2013-08-05 04:37:24 PST --- Created an attachment (id=208117) --> (https://bugs.webkit.org/attachment.cgi?id=208117&action=review) validate rendering state change name patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 04:38:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 04:38:11 -0700 Subject: [Webkit-unassigned] [Bug 119485] [WebGL] validateRenderingState method name change In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119485 Przemyslaw Szymanski changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208117|validate rendering state | [WebGL] description|change name patch |validateRenderingState | |method name change -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 04:39:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 04:39:37 -0700 Subject: [Webkit-unassigned] [Bug 119485] [WebGL] validateRenderingState method name change In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119485 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |dino at apple.com, | |esprehn+autocc at chromium.org | |, | |kondapallykalyan at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 04:48:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 04:48:03 -0700 Subject: [Webkit-unassigned] [Bug 119485] [WebGL] validateRenderingState method name change In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119485 Kalyan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kalyan.kondapally at intel.com --- Comment #2 from Kalyan 2013-08-05 04:47:43 PST --- You are missing changeLog -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 05:45:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 05:45:13 -0700 Subject: [Webkit-unassigned] [Bug 117265] Spatial Navigation should avoid unwanted calculation while deciding focus candidate. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117265 Antonio Gomes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208002|review?, commit-queue? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 05:53:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 05:53:20 -0700 Subject: [Webkit-unassigned] [Bug 119468] [Spatial Navigation] : should prefer focusable elements with absolute positioning over other elements if both elements visible area completely intersects each other. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119468 --- Comment #6 from Antonio Gomes 2013-08-05 05:53:00 PST --- (From update of attachment 208088) View in context: https://bugs.webkit.org/attachment.cgi?id=208088&action=review > Source/WebCore/page/SpatialNavigation.cpp:272 > + bool pariallyIntersects = (curRect.intersects(targetRect) && !curRect.contains(targetRect) && !targetRect.contains(curRect)); 'Overlap' reads better. > LayoutTests/fast/spatial-navigation/snav-z-index.html:90 > +Spatial Navigation should prefer focusable elements with absolute positioning over other elements if both elements visible area completely intersects each other. I would replace 'absolute positioning' with higher z-index. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 05:54:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 05:54:36 -0700 Subject: [Webkit-unassigned] [Bug 119468] [Spatial Navigation] : should prefer focusable elements with absolute positioning over other elements if both elements visible area completely intersects each other. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119468 --- Comment #7 from Antonio Gomes 2013-08-05 05:54:17 PST --- (From update of attachment 208088) View in context: https://bugs.webkit.org/attachment.cgi?id=208088&action=review > Source/WebCore/page/FocusController.cpp:737 > + if (candidate.rect.contains(closest.rect) || closest.rect.contains(candidate.rect)) { could you explain this new 'if'? > Source/WebCore/page/SpatialNavigation.cpp:275 > + return pariallyIntersects ? (targetRect.x() < curRect.x()): (targetRect.maxX() <= curRect.x()); could you explain these new conditions? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 05:58:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 05:58:33 -0700 Subject: [Webkit-unassigned] [Bug 119485] [WebGL] validateRenderingState method name change In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119485 Przemyslaw Szymanski changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208117|0 |1 is obsolete| | Attachment #208117|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 05:59:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 05:59:17 -0700 Subject: [Webkit-unassigned] [Bug 119485] [WebGL] validateRenderingState method name change In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119485 Przemyslaw Szymanski changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208120| |review? Flag| | --- Comment #3 from Przemyslaw Szymanski 2013-08-05 05:58:58 PST --- Created an attachment (id=208120) --> (https://bugs.webkit.org/attachment.cgi?id=208120&action=review) [WebGL] validateRenderingState method name change -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:00:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:00:33 -0700 Subject: [Webkit-unassigned] [Bug 119485] [WebGL] validateRenderingState method name change In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119485 --- Comment #4 from Przemyslaw Szymanski 2013-08-05 06:00:14 PST --- Thank you for review. The changelog was there but accidentally I removed the diff section from file. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:07:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:07:41 -0700 Subject: [Webkit-unassigned] [Bug 115693] Media element leaking in Youtube for iPad In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115693 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |allan.jensen at digia.com --- Comment #3 from Allan Sandfeld Jensen 2013-08-05 06:07:22 PST --- If you implement the activity triggered garbage collector (GCActivityCallback), the garbage collection will trigger sooner or later when new JS objects are allocated. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:08:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:08:26 -0700 Subject: [Webkit-unassigned] [Bug 117265] Spatial Navigation should avoid unwanted calculation while deciding focus candidate. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117265 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208002|review+, commit-queue+ | Flag| | --- Comment #13 from WebKit Commit Bot 2013-08-05 06:08:06 PST --- (From update of attachment 208002) Clearing flags on attachment: 208002 Committed r153704: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:08:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:08:31 -0700 Subject: [Webkit-unassigned] [Bug 117265] Spatial Navigation should avoid unwanted calculation while deciding focus candidate. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117265 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #14 from WebKit Commit Bot 2013-08-05 06:08:11 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:21:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:21:20 -0700 Subject: [Webkit-unassigned] [Bug 119463] canvas-blending tests added in http://trac.webkit.org/changeset/153658 fail on AppleWin port In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119463 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208121| |review? Flag| | --- Comment #1 from Mihai Tica 2013-08-05 06:21:01 PST --- Created an attachment (id=208121) --> (https://bugs.webkit.org/attachment.cgi?id=208121&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:22:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:22:57 -0700 Subject: [Webkit-unassigned] [Bug 119463] canvas-blending tests added in http://trac.webkit.org/changeset/153658 fail on AppleWin port In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119463 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208121| |commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:24:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:24:29 -0700 Subject: [Webkit-unassigned] [Bug 119463] canvas-blending tests added in http://trac.webkit.org/changeset/153658 fail on AppleWin port In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119463 --- Comment #2 from Mihai Tica 2013-08-05 06:24:10 PST --- These change removes testing of the inconsistent blend modes: hue, saturation, color, luminosity and soft-light, and also now correctly handles the asynchronous tests. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:29:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:29:06 -0700 Subject: [Webkit-unassigned] [Bug 119468] [Spatial Navigation] : should prefer focusable elements with absolute positioning over other elements if both elements visible area completely intersects each other. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119468 --- Comment #8 from Antonio Gomes 2013-08-05 06:28:45 PST --- If this patch fixes problems in test cases of bug 56938, tests here could be much improved. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:45:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:45:22 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208098|0 |1 is obsolete| | Attachment #208098|review-, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:45:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:45:32 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208122| |review? Flag| | --- Comment #8 from Andrei Parvu 2013-08-05 06:45:13 PST --- Created an attachment (id=208122) --> (https://bugs.webkit.org/attachment.cgi?id=208122&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:47:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:47:56 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 --- Comment #9 from Andrei Parvu 2013-08-05 06:47:37 PST --- Tried to change ImageCG::drawPattern to use the Pattern class, although I don't know how useful it will be - didn't figure out a better way to do it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:51:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:51:17 -0700 Subject: [Webkit-unassigned] [Bug 119463] canvas-blending tests added in http://trac.webkit.org/changeset/153658 fail on AppleWin port In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119463 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |WebkitBugTracker at adobe.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 06:58:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 06:58:57 -0700 Subject: [Webkit-unassigned] [Bug 119463] canvas-blending tests added in http://trac.webkit.org/changeset/153658 fail on AppleWin port In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119463 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208121|review?, commit-queue? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 07:00:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 07:00:02 -0700 Subject: [Webkit-unassigned] [Bug 119463] canvas-blending tests added in http://trac.webkit.org/changeset/153658 fail on AppleWin port In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119463 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 07:16:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 07:16:37 -0700 Subject: [Webkit-unassigned] [Bug 119487] New: [Gtk] Cancel authentication on load failed Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119487 Summary: [Gtk] Cancel authentication on load failed Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: brian.holt at samsung.com CC: gns at gnome.org, mrobinson at webkit.org, cgarcia at igalia.com If loading fails or is stopped on a page which requires HTTP authentication, the default dialog does not close (as would be expected) and the authentication is not cancelled. What this probably requires is the WebKitWebView retain a ref to an AuthenticationRequest in its private struct that it can cancel the request on the LoadFailed signal. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 07:17:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 07:17:00 -0700 Subject: [Webkit-unassigned] [Bug 119487] [Gtk] Cancel authentication on load failed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119487 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |99352 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 07:17:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 07:17:03 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119487 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 07:22:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 07:22:11 -0700 Subject: [Webkit-unassigned] [Bug 119463] canvas-blending tests added in http://trac.webkit.org/changeset/153658 fail on AppleWin port In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119463 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208121|review+, commit-queue+ | Flag| | --- Comment #3 from WebKit Commit Bot 2013-08-05 07:21:53 PST --- (From update of attachment 208121) Clearing flags on attachment: 208121 Committed r153705: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 07:22:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 07:22:13 -0700 Subject: [Webkit-unassigned] [Bug 119463] canvas-blending tests added in http://trac.webkit.org/changeset/153658 fail on AppleWin port In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119463 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from WebKit Commit Bot 2013-08-05 07:21:55 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:14:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:14:37 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207926|0 |1 is obsolete| | Attachment #207926|commit-queue? | Flag| | Attachment #208125| |review?, commit-queue? Flag| | --- Comment #56 from Benjamin Dupont 2013-08-05 08:14:17 PST --- Created an attachment (id=208125) --> (https://bugs.webkit.org/attachment.cgi?id=208125&action=review) New QWebPage API (with test): void QWebPage::setVisibilityState(QWebPage::PageVisibilityState state) (3) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:15:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:15:46 -0700 Subject: [Webkit-unassigned] [Bug 119373] webkit-gtk fails to build with bison-3.0 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119373 contact at igor-zivkovic.from.hr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |contact at igor-zivkovic.from. | |hr -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:17:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:17:20 -0700 Subject: [Webkit-unassigned] [Bug 73743] [GStreamer] webkitwebsrc: use SubResourceLoader In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=73743 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |allan.jensen at digia.com --- Comment #28 from Allan Sandfeld Jensen 2013-08-05 08:17:00 PST --- It seems the patch here also solved the bug in 109350 probably because it got rid of the RefPtr that WebKitWebSource held, which caused a circular reference. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:19:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:19:37 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 --- Comment #12 from Mario Sanchez Prada 2013-08-05 08:19:18 PST --- Thanks Krzysztof for reporting that the issue has not been properly fixed yet. I can take a look to it tomorrow if you want, but please confirm that will be fine since I see you have been already doing some investigation and I don't want to collide with your efforts, should you were planning to work on this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:20:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:20:38 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Qt Early Warning System Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208125|commit-queue? |commit-queue- Flag| | --- Comment #57 from Qt Early Warning System Bot 2013-08-05 08:20:19 PST --- (From update of attachment 208125) Attachment 208125 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1369197 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:21:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:21:22 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 --- Comment #58 from Qt Early Warning System Bot 2013-08-05 08:21:02 PST --- (From update of attachment 208125) Attachment 208125 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1375130 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:22:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:22:51 -0700 Subject: [Webkit-unassigned] [Bug 115248] [CSSRegions] Min/max-width should support values other than length In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115248 Anton Obzhirov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208126| |review? Flag| | --- Comment #10 from Anton Obzhirov 2013-08-05 08:22:33 PST --- Created an attachment (id=208126) --> (https://bugs.webkit.org/attachment.cgi?id=208126&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:26:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:26:58 -0700 Subject: [Webkit-unassigned] [Bug 119088] [Qt] Crash in SimpleFontData, related to @font-face with non-existing src url In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119088 --- Comment #7 from Milian Wolff 2013-08-05 08:26:39 PST --- I just updated everything from the stable branches and wiped the build folders and redid everything, like this: cd $(dirname $0) mkdir qtbase &>/dev/null cd qtbase ../../qtbase/configure -prefix /home/milian/projects/compiled/qt5 \ -opensource -confirm-license -debug make -j40 && make install // note: qmake-qt5 is a ln -s of the qmabe build above for d in qtjsbackend qtxmlpatterns qtdeclarative qtconnectivity qtlocation qttools qtwebkit; do if [ ! -d "$d" ]; then mkdir $d; fi pushd $d qmake-qt5 CONFIG+=debug ../../$d/$d.pro -r (make -j40 && make install -j4) || exit popd done And it still crashes: ==32468== Thread 1: ==32468== Invalid read of size 8 ==32468== at 0x8DDF820: WebCore::SimpleFontData::SimpleFontData(WebCore::FontPlatformData const&, bool, bool, bool) (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== by 0x89C5668: WebCore::CSSFontFaceSource::getFontData(WebCore::FontDescription const&, bool, bool, WebCore::CSSFontSelector*) (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== by 0x89B570B: WebCore::CSSFontFace::getFontData(WebCore::FontDescription const&, bool, bool) (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== by 0x8A27578: WebCore::CSSSegmentedFontFace::getFontData(WebCore::FontDescription const&) (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== by 0x89C2C67: WebCore::CSSFontSelector::getFontData(WebCore::FontDescription const&, WTF::AtomicString const&) (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== by 0x8DA3AE3: WebCore::FontCache::getFontData(WebCore::Font const&, int&, WebCore::FontSelector*) (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== by 0x8D8D811: WebCore::FontFallbackList::fontDataAt(WebCore::Font const*, unsigned int) const (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== by 0x8D8DADD: WebCore::FontFallbackList::determinePitch(WebCore::Font const*) const (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== by 0x9D1B386: WebCore::RenderBlock::LineBreaker::nextLineBreak(WebCore::BidiResolver&, WebCore::LineInfo&, WebCore::RenderBlock::RenderTextInfo&, WebCore::RenderBlock::FloatingObject*, unsigned int, WTF::Vector&) (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== by 0x9D2090B: WebCore::RenderBlock::layoutRunsAndFloatsInRange(WebCore::LineLayoutState&, WebCore::BidiResolver&, WebCore::InlineIterator const&, WebCore::BidiStatus const&, unsigned int) (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== by 0x9D330E7: WebCore::RenderBlock::layoutRunsAndFloats(WebCore::LineLayoutState&, bool) (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== by 0x9D337F3: WebCore::RenderBlock::layoutInlineChildren(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&) (in /ssd/milian/projects/qt5/build-x86/qtwebkit/lib/libQt5WebKit.so.5.1.2) ==32468== Address 0x38 is not stack'd, malloc'd or (recently) free'd Considering that mibrunin also cannot reproduce this issue, I wonder what else could influence this? Any other stuff from the system which might be an issue? Any font library or such? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:27:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:27:29 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 --- Comment #13 from Krzysztof Czech 2013-08-05 08:27:10 PST --- (In reply to comment #12) > Thanks Krzysztof for reporting that the issue has not been properly fixed yet. I can take a look to it tomorrow if you want, but please confirm that will be fine since I see you have been already doing some investigation and I don't want to collide with your efforts, should you were planning to work on this. Yes, I will be fine if you take a look at this issue. I wrote some suppositions, but I'm not sure whether they hit the point, they may be wrong. I just looked at this briefly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:32:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:32:41 -0700 Subject: [Webkit-unassigned] [Bug 115248] [CSSRegions] Min/max-width should support values other than length In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115248 --- Comment #11 from Anton Obzhirov 2013-08-05 08:32:23 PST --- Submitted new test to test min/max width cases for regions - the test is pass. There is an issue with red line in the last region which in my opinion is not related to this bug but should be investigate in a new one. If is ok I will create a new bug for the red line issue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:36:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:36:52 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Jocelyn Turcotte changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208125|review? |review- Flag| | --- Comment #59 from Jocelyn Turcotte 2013-08-05 08:36:33 PST --- (From update of attachment 208125) View in context: https://bugs.webkit.org/attachment.cgi?id=208125&action=review > Source/WebKit/qt/ChangeLog:3 > + [Qt] Add Page Visibility API support Ideally this patch should also enable PAGE_VISIBILITY_API by default in the build, but this can also be done in a separate patch as long as you do it soon. > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:159 > + result = WebCore::PageVisibilityStatePrerender; > + break; you can replace the temporary result variable by "return WebCore::PageVisibilityStatePrerender;" directly and also remove the breaks and the final return. > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:247 > + page->setVisibilityState(webPageVisibilityStateToWebCoreVisibilityState(m_visibilityState), true); Page::m_visibilityState is already initialized to PageVisibilityStateVisible, I'm not sure I see a use for this. > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:339 > + if (!page) > + return; By looking at the rest of the code I'd say that you can expect page to be non-null here, am I right? > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:349 > + return m_visibilityState; Why not use WebCore::Page::visibilityState() directly instead? > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:136 > + // Must match with values of PageVisibilityState enum from PageVisibilityState.h. It's not true anymore, it must however match QWebPage::PageVisibilityState. > Source/WebKit/qt/WidgetApi/qwebpage.cpp:3142 > + Returns the current page visibility state of the current page. "of the current page" is unneeded extra information. I think it's obvious. > Source/WebKit/qt/WidgetApi/qwebpage.cpp:3152 > + This method is used to change the page visibility state of the current page. ditto > Source/WebKit/qt/WidgetApi/qwebpage.cpp:3153 > + It should be called by Qt applications who want to notify Javascript application grammar: "JavaScript applications" or "the JavaScript application" > Source/WebKit/qt/WidgetApi/qwebpage.cpp:3154 > + that the visibility state has changed (eg. by reimplementing setVisible function of QWidget). - eg. --> e.g. - "the setVisible function" or simply "QWidget::setVisible" (the later should also add a link automatically in the doc) The rest of the method documentaion is pretty good and descriptive :) > Source/WebKit/qt/WidgetApi/qwebpage.h:220 > + enum PageVisibilityState { VisibilityState would be fine and match with the property name. "Page" isn't helpful here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:38:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:38:46 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208125|0 |1 is obsolete| | Attachment #208128| |review?, commit-queue? Flag| | --- Comment #60 from Benjamin Dupont 2013-08-05 08:38:26 PST --- Created an attachment (id=208128) --> (https://bugs.webkit.org/attachment.cgi?id=208128&action=review) New QWebPage API (with test): void QWebPage::setVisibilityState(QWebPage::PageVisibilityState state) (4) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:40:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:40:11 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208128|review?, commit-queue? |review-, commit-queue- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:40:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:40:25 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208128|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:42:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:42:58 -0700 Subject: [Webkit-unassigned] [Bug 119333] [EFL] REGRESSION after r153432: some accessibility tests crash. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119333 --- Comment #14 from Mario Sanchez Prada 2013-08-05 08:42:39 PST --- (In reply to comment #13) > (In reply to comment #12) > > Thanks Krzysztof for reporting that the issue has not been properly fixed yet. I can take a look to it tomorrow if you want, but please confirm that will be fine since I see you have been already doing some investigation and I don't want to collide with your efforts, should you were planning to work on this. > Yes, I will be fine if you take a look at this issue. I wrote some suppositions, but I'm not sure whether they hit the point, they may be wrong. I just looked at this briefly. Ok, fair enough. I'll work tomorrow on that then. Today I'm just almost dead because of this GUADEC conference :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:44:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:44:08 -0700 Subject: [Webkit-unassigned] [Bug 119088] [Qt] Crash in SimpleFontData, related to @font-face with non-existing src url In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119088 --- Comment #8 from Allan Sandfeld Jensen 2013-08-05 08:43:50 PST --- I have tried both the HTML and QML example and neither of them crashes for me. Perhaps you can get a better backtrace? I think the way to get that in official Qt version is to edit the file qtwebkit/Tools/qmake/mkspecs/features/production_build.prf and comment out the part that disables debug info in the internals of WebKit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:46:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:46:55 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208021|0 |1 is obsolete| | Attachment #208021|review?, commit-queue? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:47:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:47:03 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208129| |review? Flag| | --- Comment #7 from Brian Holt 2013-08-05 08:46:44 PST --- Created an attachment (id=208129) --> (https://bugs.webkit.org/attachment.cgi?id=208129&action=review) Patch Addressed review comments -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 08:50:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 08:50:14 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 --- Comment #8 from Brian Holt 2013-08-05 08:49:54 PST --- (In reply to comment #4) > (From update of attachment 208021 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208021&action=review > > Thanks for the patch Brian. I'm informally reviewing it now, hope you will find my comments useful. > Thanks for the review! Your comments made me check assumptions I had made along the (long) way of creating this patch and as result I've trimmed it down to a *much* smaller patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 09:04:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 09:04:11 -0700 Subject: [Webkit-unassigned] [Bug 119088] [Qt] Crash in SimpleFontData, related to @font-face with non-existing src url In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119088 Michael Br?ning changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.bruning at digia.com --- Comment #9 from Michael Br?ning 2013-08-05 09:03:52 PST --- (In reply to comment #7) > I just updated everything from the stable branches and wiped the build folders and redid everything, like this: > > cd $(dirname $0) > mkdir qtbase &>/dev/null > cd qtbase > > ../../qtbase/configure -prefix /home/milian/projects/compiled/qt5 \ > -opensource -confirm-license -debug > make -j40 && make install > > // note: qmake-qt5 is a ln -s of the qmabe build above > > for d in qtjsbackend qtxmlpatterns qtdeclarative qtconnectivity qtlocation qttools qtwebkit; do > if [ ! -d "$d" ]; then mkdir $d; fi > pushd $d > qmake-qt5 CONFIG+=debug ../../$d/$d.pro -r This will not have any effect on the qtwebkit submodule, as qtwebkit/qtwebkit.pro simply does not exist. If you want to run qmake for qtwebkit, please use qtwebkit/WebKit.pro > (make -j40 && make install -j4) || exit > popd > done > -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 09:25:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 09:25:36 -0700 Subject: [Webkit-unassigned] [Bug 119478] Implement HTML spec change to Adoption Agency Algorithm to not reverse the order of nodes in the document, by removing nodes that we're not recreating from the stack of open elements In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119478 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org, | |eoconnor at apple.com, | |hyatt at apple.com, | |ian at hixie.ch, mjs at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 09:29:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 09:29:18 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 --- Comment #61 from Benjamin Dupont 2013-08-05 09:28:58 PST --- (In reply to comment #59) > (From update of attachment 208125 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208125&action=review > > > Source/WebKit/qt/ChangeLog:3 > > + [Qt] Add Page Visibility API support > > Ideally this patch should also enable PAGE_VISIBILITY_API by default in the build, but this can also be done in a separate patch as long as you do it soon. I think PAGE_VISIBILITY_API is already activate by default (in Tools/qmake/mkspecs/features/features.pri ENABLE_PAGE_VISIBILITY_API=1). Is there any other places to enable it? > > > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:159 > > + result = WebCore::PageVisibilityStatePrerender; > > + break; > > you can replace the temporary result variable by "return WebCore::PageVisibilityStatePrerender;" directly and also remove the breaks and the final return. I totally agree with you, I wanted to be inspired by dragOpToDropAction function but it seems it was a bad idea :) > > > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:247 > > + page->setVisibilityState(webPageVisibilityStateToWebCoreVisibilityState(m_visibilityState), true); > > Page::m_visibilityState is already initialized to PageVisibilityStateVisible, I'm not sure I see a use for this. Yes with the visible default value is no more needed. > > > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:339 > > + if (!page) > > + return; > > By looking at the rest of the code I'd say that you can expect page to be non-null here, am I right? Yes, but as I saw "return page ? page->viewportArguments() : WebCore::ViewportArguments();", I'd preferred to add this check. > > > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:349 > > + return m_visibilityState; > > Why not use WebCore::Page::visibilityState() directly instead? Yes I agree. (getter/setter habit mistake...) I'll remove the m_visibilityState attribute because it's never used... > > > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:136 > > + // Must match with values of PageVisibilityState enum from PageVisibilityState.h. > > It's not true anymore, it must however match QWebPage::PageVisibilityState. > Erf I didn't update this comment. Yes, if there is a difference between these values and the ones defined in WebCore it'll generate a compile error into the switch (like for this patch). > > Source/WebKit/qt/WidgetApi/qwebpage.cpp:3153 > > + It should be called by Qt applications who want to notify Javascript application > > grammar: "JavaScript applications" or "the JavaScript application" > Oops, thanks. > > Source/WebKit/qt/WidgetApi/qwebpage.h:220 > > + enum PageVisibilityState { > > VisibilityState would be fine and match with the property name. "Page" isn't helpful here. Ok, is the same for QWebPageAdapter.h? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 09:37:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 09:37:32 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 --- Comment #62 from Jocelyn Turcotte 2013-08-05 09:37:13 PST --- (In reply to comment #61) > I think PAGE_VISIBILITY_API is already activate by default (in Tools/qmake/mkspecs/features/features.pri ENABLE_PAGE_VISIBILITY_API=1). Is there any other places to enable it? Ah yes you're right! > > VisibilityState would be fine and match with the property name. "Page" isn't helpful here. > Ok, is the same for QWebPageAdapter.h? Since it should match QWebPage more than WebCore I'd say that we should remove Page from this one as well, but I don't have a strong preference. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 09:45:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 09:45:42 -0700 Subject: [Webkit-unassigned] [Bug 77568] [Mac] Support OpenType 'locl' feature In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=77568 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #13 from Alexey Proskuryakov 2013-08-05 09:45:22 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 09:53:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 09:53:01 -0700 Subject: [Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118445 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207669|0 |1 is obsolete| | Attachment #207669|review?, commit-queue? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 09:53:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 09:53:15 -0700 Subject: [Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118445 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208130| |review?, commit-queue? Flag| | --- Comment #38 from Arunprasad Rajkumar 2013-08-05 09:52:56 PST --- Created an attachment (id=208130) --> (https://bugs.webkit.org/attachment.cgi?id=208130&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 09:59:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 09:59:30 -0700 Subject: [Webkit-unassigned] [Bug 119088] [Qt] Crash in SimpleFontData, related to @font-face with non-existing src url In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119088 --- Comment #10 from Milian Wolff 2013-08-05 09:59:12 PST --- Ok, here it is: Program received signal SIGSEGV, Segmentation fault. 0x00007f8782536376 in WTF::RefPtr::RefPtr (this=0x6c5c48, o=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WTF/wtf/RefPtr.h:43 43 ALWAYS_INLINE RefPtr(const RefPtr& o) : m_ptr(o.m_ptr) { refIfNotNull(m_ptr); } (gdb) thread apply all bt Thread 5 (Thread 0x7f87753a1700 (LWP 23989)): #0 0x00007f877feeec61 in pthread_cond_timedwait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0 #1 0x00007f87837f110c in WTF::ThreadCondition::timedWait (this=0x659180, mutex=..., absoluteTime=1375721283.5345609) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WTF/wtf/ThreadingPthreads.cpp:400 #2 0x00007f87835015ae in JSC::BlockAllocator::waitForRelativeTimeWhileHoldingLock (this=0x659078, relative=1) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/JavaScriptCore/heap/BlockAllocator.cpp:89 #3 0x00007f87835015f4 in JSC::BlockAllocator::waitForRelativeTime (this=0x659078, relative=1) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/JavaScriptCore/heap/BlockAllocator.cpp:99 #4 0x00007f8783501642 in JSC::BlockAllocator::blockFreeingThreadMain (this=0x659078) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/JavaScriptCore/heap/BlockAllocator.cpp:113 #5 0x00007f878350161a in JSC::BlockAllocator::blockFreeingThreadStartFunc (blockAllocator=0x659078) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/JavaScriptCore/heap/BlockAllocator.cpp:104 #6 0x00007f87837d716d in WTF::threadEntryPoint (contextData=0x61de00) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WTF/wtf/Threading.cpp:69 #7 0x00007f87837f0705 in WTF::wtfThreadEntryPoint (param=0x645850) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WTF/wtf/ThreadingPthreads.cpp:196 #8 0x00007f877feeadd2 in start_thread () from /usr/lib/libpthread.so.0 #9 0x00007f877f403cdd in clone () from /usr/lib/libc.so.6 Thread 4 (Thread 0x7f8775c16700 (LWP 23988)): #0 0x00007f877f3fb08d in poll () from /usr/lib/libc.so.6 #1 0x00007f8786087094 in ?? () from /usr/lib/libglib-2.0.so.0 #2 0x00007f878608719c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0 #3 0x00007f878065eb0b in QEventDispatcherGlib::processEvents (this=0x7f87200008c0, flags=...) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:426 #4 0x00007f87805eb686 in QEventLoop::processEvents (this=0x7f8775c15e20, flags=...) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qeventloop.cpp:136 #5 0x00007f87805eb969 in QEventLoop::exec (this=0x7f8775c15e20, flags=...) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qeventloop.cpp:212 #6 0x00007f87803f80fc in QThread::exec (this=0x638b00) at /ssd/milian/projects/qt5/qtbase/src/corelib/thread/qthread.cpp:507 #7 0x00007f87803f829a in QThread::run (this=0x638b00) at /ssd/milian/projects/qt5/qtbase/src/corelib/thread/qthread.cpp:574 #8 0x00007f87803feb98 in QThreadPrivate::start (arg=0x638b00) at /ssd/milian/projects/qt5/qtbase/src/corelib/thread/qthread_unix.cpp:345 #9 0x00007f877feeadd2 in start_thread () from /usr/lib/libpthread.so.0 #10 0x00007f877f403cdd in clone () from /usr/lib/libc.so.6 Thread 3 (Thread 0x7f87764f6700 (LWP 23987)): #0 0x00007f877f3fb08d in poll () from /usr/lib/libc.so.6 #1 0x00007f8786087094 in ?? () from /usr/lib/libglib-2.0.so.0 ---Type to continue, or q to quit--- #2 0x00007f878608719c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0 #3 0x00007f878065eb0b in QEventDispatcherGlib::processEvents (this=0x7f87280008c0, flags=...) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:426 #4 0x00007f87805eb686 in QEventLoop::processEvents (this=0x7f87764f5e20, flags=...) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qeventloop.cpp:136 #5 0x00007f87805eb969 in QEventLoop::exec (this=0x7f87764f5e20, flags=...) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qeventloop.cpp:212 #6 0x00007f87803f80fc in QThread::exec (this=0x5b3450) at /ssd/milian/projects/qt5/qtbase/src/corelib/thread/qthread.cpp:507 #7 0x00007f87803f829a in QThread::run (this=0x5b3450) at /ssd/milian/projects/qt5/qtbase/src/corelib/thread/qthread.cpp:574 #8 0x00007f87803feb98 in QThreadPrivate::start (arg=0x5b3450) at /ssd/milian/projects/qt5/qtbase/src/corelib/thread/qthread_unix.cpp:345 #9 0x00007f877feeadd2 in start_thread () from /usr/lib/libpthread.so.0 #10 0x00007f877f403cdd in clone () from /usr/lib/libc.so.6 Thread 2 (Thread 0x7f8776f02700 (LWP 23986)): #0 0x00007f877f3fb08d in poll () from /usr/lib/libc.so.6 #1 0x00007f877eef76e2 in ?? () from /usr/lib/libxcb.so.1 #2 0x00007f877eef8d7f in xcb_wait_for_event () from /usr/lib/libxcb.so.1 #3 0x00007f87797fc6c9 in QXcbEventReader::run (this=0x5957a0) at /ssd/milian/projects/qt5/qtbase/src/plugins/platforms/xcb/qxcbconnection.cpp:983 #4 0x00007f87803feb98 in QThreadPrivate::start (arg=0x5957a0) at /ssd/milian/projects/qt5/qtbase/src/corelib/thread/qthread_unix.cpp:345 #5 0x00007f877feeadd2 in start_thread () from /usr/lib/libpthread.so.0 #6 0x00007f877f403cdd in clone () from /usr/lib/libc.so.6 Thread 1 (Thread 0x7f878844e740 (LWP 23869)): #0 0x00007f8782536376 in WTF::RefPtr::RefPtr (this=0x6c5c48, o=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WTF/wtf/RefPtr.h:43 #1 0x00007f8782534719 in WebCore::FontPlatformData::FontPlatformData (this=0x6c5c48) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/graphics/qt/FontPlatformData.h:80 #2 0x00007f878257b5dd in WebCore::SimpleFontData::SimpleFontData (this=0x6c5c10, platformData=..., isCustomFont=true, isLoading=true, isTextOrientationFallback=false) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/graphics/SimpleFontData.cpp:59 #3 0x00007f878214632e in WebCore::SimpleFontData::create (platformData=..., isCustomFont=true, isLoading=true, isTextOrientationFallback=false) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/graphics/SimpleFontData.h:90 #4 0x00007f8782146fbe in WebCore::CSSFontFaceSource::getFontData (this=0x69d370, fontDescription=..., syntheticBold=false, syntheticItalic=false, fontSelector=0x676550) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/css/CSSFontFaceSource.cpp:185 #5 0x00007f8782130f4c in WebCore::CSSFontFace::getFontData (this=0x697560, fontDescription=..., syntheticBold=false, syntheticItalic=false) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/css/CSSFontFace.cpp:105 #6 0x00007f87821c5982 in WebCore::CSSSegmentedFontFace::getFontData (this=0x69dc70, fontDescription=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/css/CSSSegmentedFontFace.cpp:127 ---Type to continue, or q to quit--- #7 0x00007f87821398b1 in WebCore::CSSFontSelector::getFontData (this=0x676550, fontDescription=..., familyName=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/css/CSSFontSelector.cpp:539 #8 0x00007f8782535857 in WebCore::FontCache::getFontData (this=0x6336e0, font=..., familyIndex=@0x6a0c0c: 1, fontSelector=0x676550) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/graphics/FontCache.cpp:475 #9 0x00007f8782525e65 in WebCore::FontFallbackList::fontDataAt (this=0x6a0b70, font=0x698488, realizedFontIndex=0) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/graphics/FontFallbackList.cpp:108 #10 0x00007f878234430a in WebCore::FontFallbackList::primaryFontData (this=0x6a0b70, f=0x698488) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/graphics/FontFallbackList.h:96 #11 0x00007f8782525c1d in WebCore::FontFallbackList::determinePitch (this=0x6a0b70, font=0x698488) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/graphics/FontFallbackList.cpp:79 #12 0x00007f8783103b73 in WebCore::FontFallbackList::isFixedPitch (this=0x6a0b70, f=0x698488) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/graphics/FontFallbackList.h:73 #13 0x00007f8783103d00 in WebCore::Font::isFixedPitch (this=0x698488) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/graphics/Font.h:333 #14 0x00007f878316cf3e in WebCore::RenderBlock::LineBreaker::nextLineBreak (this=0x7fff567f11d0, resolver=..., lineInfo=..., renderTextInfo=..., lastFloatFromPreviousLine=0x0, consecutiveHyphenatedLines=0, wordMeasurements=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlockLineLayout.cpp:2544 #15 0x00007f8783166d24 in WebCore::RenderBlock::layoutRunsAndFloatsInRange (this=0x678988, layoutState=..., resolver=..., cleanLineStart=..., cleanLineBidiStatus=..., consecutiveHyphenatedLines=0) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1438 #16 0x00007f87831666c9 in WebCore::RenderBlock::layoutRunsAndFloats (this=0x678988, layoutState=..., hasInlineChild=true) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1369 #17 0x00007f8783168b81 in WebCore::RenderBlock::layoutInlineChildren (this=0x678988, relayoutChildren=true, repaintLogicalTop=..., repaintLogicalBottom=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1717 #18 0x00007f878313b31c in WebCore::RenderBlock::layoutBlock (this=0x678988, relayoutChildren=true, pageLogicalHeight=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlock.cpp:1562 #19 0x00007f878313a886 in WebCore::RenderBlock::layout (this=0x678988) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlock.cpp:1390 #20 0x00007f87831404bf in WebCore::RenderBlock::layoutBlockChild (this=0x676cc8, child=0x678988, marginInfo=..., previousFloatLogicalBottom=..., maxFloatLogicalBottom=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlock.cpp:2492 #21 0x00007f878314003f in WebCore::RenderBlock::layoutBlockChildren (this=0x676cc8, relayoutChildren=true, maxFloatLogicalBottom=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlock.cpp:2428 #22 0x00007f878313b33d in WebCore::RenderBlock::layoutBlock (this=0x676cc8, relayoutChildren=true, pageLogicalHeight=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlock.cpp:1564 #23 0x00007f878313a886 in WebCore::RenderBlock::layout (this=0x676cc8) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlock.cpp:1390 #24 0x00007f87831404bf in WebCore::RenderBlock::layoutBlockChild (this=0x61dbf8, child=0x676cc8, marginInfo=..., previousFloatLogicalBottom=..., maxFloatLogicalBottom=...) ---Type to continue, or q to quit--- at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlock.cpp:2492 #25 0x00007f878314003f in WebCore::RenderBlock::layoutBlockChildren (this=0x61dbf8, relayoutChildren=true, maxFloatLogicalBottom=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlock.cpp:2428 #26 0x00007f878313b33d in WebCore::RenderBlock::layoutBlock (this=0x61dbf8, relayoutChildren=true, pageLogicalHeight=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlock.cpp:1564 #27 0x00007f878313a886 in WebCore::RenderBlock::layout (this=0x61dbf8) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderBlock.cpp:1390 #28 0x00007f878324a556 in WebCore::RenderView::layoutContent (this=0x61dbf8, state=...) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderView.cpp:140 #29 0x00007f878324ab53 in WebCore::RenderView::layout (this=0x61dbf8) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/rendering/RenderView.cpp:198 #30 0x00007f87824c90f0 in WebCore::FrameView::layout (this=0x61c150, allowSubtree=true) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/page/FrameView.cpp:1196 #31 0x00007f87832de668 in WebCore::Document::implicitClose (this=0x658540) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/dom/Document.cpp:2463 #32 0x00007f87823fd6ad in WebCore::FrameLoader::checkCallImplicitClose (this=0x60c8b8) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/loader/FrameLoader.cpp:830 #33 0x00007f87823fd418 in WebCore::FrameLoader::checkCompleted (this=0x60c8b8) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/loader/FrameLoader.cpp:773 #34 0x00007f87823fd156 in WebCore::FrameLoader::finishedParsing (this=0x60c8b8) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/loader/FrameLoader.cpp:706 #35 0x00007f87832e5663 in WebCore::Document::finishedParsing (this=0x658540) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/dom/Document.cpp:4415 #36 0x00007f878238aa2f in WebCore::HTMLTreeBuilder::finished (this=0x61cc60) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2703 #37 0x00007f878235d382 in WebCore::HTMLDocumentParser::end (this=0x674230) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/html/parser/HTMLDocumentParser.cpp:377 #38 0x00007f878235d48b in WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd (this=0x674230) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/html/parser/HTMLDocumentParser.cpp:386 #39 0x00007f878235c5b3 in WebCore::HTMLDocumentParser::prepareToStopParsing (this=0x674230) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/html/parser/HTMLDocumentParser.cpp:154 #40 0x00007f878235d4ce in WebCore::HTMLDocumentParser::attemptToEnd (this=0x674230) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/html/parser/HTMLDocumentParser.cpp:398 #41 0x00007f878235d585 in WebCore::HTMLDocumentParser::finish (this=0x674230) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/html/parser/HTMLDocumentParser.cpp:425 #42 0x00007f87823f49cd in WebCore::DocumentWriter::end (this=0x647128) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/loader/DocumentWriter.cpp:244 #43 0x00007f87823e3dcd in WebCore::DocumentLoader::finishedLoading (this=0x647080) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/loader/DocumentLoader.cpp:301 ---Type to continue, or q to quit--- #44 0x00007f878241ecaf in WebCore::MainResourceLoader::didFinishLoading (this=0x6478f0, finishTime=0) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/loader/MainResourceLoader.cpp:520 #45 0x00007f878242b2b3 in WebCore::ResourceLoader::didFinishLoading (this=0x6478f0, finishTime=0) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/loader/ResourceLoader.cpp:453 #46 0x00007f87826e0e91 in WebCore::QNetworkReplyHandler::finish (this=0x6492e0) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:515 #47 0x00007f87826dfa90 in WebCore::QNetworkReplyHandlerCallQueue::flush (this=0x649318) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:249 #48 0x00007f87826df7b8 in WebCore::QNetworkReplyHandlerCallQueue::push (this=0x649318, method=(void (WebCore::QNetworkReplyHandler::*)(WebCore::QNetworkReplyHandler * const)) 0x7f87826e0cbc ) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:215 #49 0x00007f87826e07a6 in WebCore::QNetworkReplyWrapper::didReceiveFinished (this=0x63bc20) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:408 #50 0x00007f87826e31e2 in WebCore::QNetworkReplyWrapper::qt_static_metacall (_o=0x63bc20, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fff567f47d0) at .moc/debug-shared/moc_QNetworkReplyHandler.cpp:175 #51 0x00007f878062e5b7 in QMetaObject::activate (sender=0x5ffc50, signalOffset=7, local_signal_index=1, argv=0x0) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qobject.cpp:3479 #52 0x00007f878062de08 in QMetaObject::activate (sender=0x5ffc50, m=0x7f8780fdd640 , local_signal_index=1, argv=0x0) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qobject.cpp:3354 #53 0x00007f8780f6219f in QNetworkReply::finished (this=0x5ffc50) at .moc/debug-shared/moc_qnetworkreply.cpp:297 #54 0x00007f8780f61d44 in QNetworkReply::qt_static_metacall (_o=0x5ffc50, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x63b440) at .moc/debug-shared/moc_qnetworkreply.cpp:183 #55 0x00007f8780626da5 in QMetaCallEvent::placeMetaCall (this=0x63b960, object=0x5ffc50) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qobject.cpp:479 #56 0x00007f8780627c92 in QObject::event (this=0x5ffc50, e=0x63b960) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qobject.cpp:1070 #57 0x00007f878119c328 in QApplicationPrivate::notify_helper (this=0x579d70, receiver=0x5ffc50, e=0x63b960) at /ssd/milian/projects/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3457 #58 0x00007f8781199ac4 in QApplication::notify (this=0x572db0, receiver=0x5ffc50, e=0x63b960) at /ssd/milian/projects/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2878 #59 0x00007f87805ee926 in QCoreApplication::notifyInternal (this=0x572db0, receiver=0x5ffc50, event=0x63b960) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:867 #60 0x00007f87805f248b in QCoreApplication::sendEvent (receiver=0x5ffc50, event=0x63b960) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qcoreapplication.h:232 #61 0x00007f87805efc6f in QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0, data=0x579ee0) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1471 #62 0x00007f87805ef61f in QCoreApplication::sendPostedEvents (receiver=0x0, event_type=0) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1329 #63 0x00007f878065e363 in postEventSourceDispatch (s=0x585980) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:279 ---Type to continue, or q to quit--- #64 0x00007f8786086da6 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #65 0x00007f87860870f8 in ?? () from /usr/lib/libglib-2.0.so.0 #66 0x00007f878608719c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0 #67 0x00007f878065eb0b in QEventDispatcherGlib::processEvents (this=0x57c170, flags=...) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:426 #68 0x00007f877982bc10 in QPAEventDispatcherGlib::processEvents (this=0x57c170, flags=...) at /ssd/milian/projects/qt5/qtbase/src/platformsupport/eventdispatchers/qeventdispatcher_glib.cpp:123 #69 0x00007f87805eb686 in QEventLoop::processEvents (this=0x7fff567f5630, flags=...) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qeventloop.cpp:136 #70 0x00007f87805eb969 in QEventLoop::exec (this=0x7fff567f5630, flags=...) at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qeventloop.cpp:212 #71 0x00007f87805ef002 in QCoreApplication::exec () at /ssd/milian/projects/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1120 #72 0x00007f87826ed4fc in WebCore::RunLoop::run () at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebCore/platform/qt/RunLoopQt.cpp:69 #73 0x00007f8781f6c750 in WebKit::WebProcessMainQt (app=0x572db0) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp:195 #74 0x00000000004011c8 in main (argc=2, argv=0x7fff567f5a58) at /ssd/milian/projects/qt5/qtwebkit-gitorious/Source/WebKit2/qt/MainQt.cpp:100 for a valgrind log and bt full, see http://paste.kde.org/p9b641be0/ (was too long for the bugtracker). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 10:04:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 10:04:50 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 --- Comment #9 from Mario Sanchez Prada 2013-08-05 10:04:30 PST --- (From update of attachment 208129) View in context: https://bugs.webkit.org/attachment.cgi?id=208129&action=review Besides a small nit (which I'm not even sure whether others would agree with anyway), the patch now looks good to me, so I would say an official review would be in place now. It's so beautiful to see it reduced to less than half of the original size! :) > Tools/Scripts/webkitpy/port/gtk.py:92 > + environment['G_SLICE'] = 'always-malloc' I understand that forcing malloc() for every single memory allocation is some kind of prerequisite to use valgrind here? If so, a comment explaining the reason would be handy here too, as it's not obvious why we need this. > Tools/Scripts/webkitpy/port/gtk.py:96 > + environment['VALGRIND_OPTS'] = "--tool=memcheck " \ > + "--num-callers=40 " \ Nit. I would probably move this --tool parameter to the following line, so every option is aligned. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 10:13:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 10:13:13 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208132| |review?, commit-queue? Flag| | --- Comment #63 from Benjamin Dupont 2013-08-05 10:12:54 PST --- Created an attachment (id=208132) --> (https://bugs.webkit.org/attachment.cgi?id=208132&action=review) New QWebPage API (with test): void QWebPage::setVisibilityState(QWebPage::PageVisibilityState state) (5) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 10:15:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 10:15:24 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 --- Comment #10 from Brian Holt 2013-08-05 10:15:04 PST --- (From update of attachment 208129) View in context: https://bugs.webkit.org/attachment.cgi?id=208129&action=review Thanks for the review! Since the other changes are so heavily dependent on this getting in I'm going to hold off uploading new versions of them until this gets in (hopefully soon)! >> Tools/Scripts/webkitpy/port/gtk.py:92 >> + environment['G_SLICE'] = 'always-malloc' > > I understand that forcing malloc() for every single memory allocation is some kind of prerequisite to use valgrind here? > > If so, a comment explaining the reason would be handy here too, as it's not obvious why we need this. Good point - and in finding a link (https://wiki.gnome.org/Valgrind) I've found that I should also set G_DEBUG=gc-friendly. >> Tools/Scripts/webkitpy/port/gtk.py:96 >> + "--num-callers=40 " \ > > Nit. I would probably move this --tool parameter to the following line, so every option is aligned. Sorry, you mentioned that last review but I missed it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 10:22:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 10:22:47 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208129|0 |1 is obsolete| | Attachment #208129|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 10:22:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 10:22:55 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208133| |review?, commit-queue? Flag| | --- Comment #11 from Brian Holt 2013-08-05 10:22:36 PST --- Created an attachment (id=208133) --> (https://bugs.webkit.org/attachment.cgi?id=208133&action=review) Launch DRT under Valgrind v2 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 10:23:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 10:23:17 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 --- Comment #64 from Jocelyn Turcotte 2013-08-05 10:22:58 PST --- (From update of attachment 208132) View in context: https://bugs.webkit.org/attachment.cgi?id=208132&action=review Found a few more minor issues on the last comb pass. > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:259 > + VisibilityState visibilityState(); const missing here > Source/WebKit/qt/WidgetApi/qwebpage.h:82 > + Q_PROPERTY(QWebPage::VisibilityState visibilityState READ visibilityState WRITE setVisibilityState) > Q_ENUMS(LinkDelegationPolicy NavigationType WebAction) I think you need to add VisibilityState to the Q_ENUMS line here for the property to work. Also I'm not sure if the "QWebPage::" part is necessary. > Source/WebKit/qt/WidgetApi/qwebpage.h:286 > + VisibilityState visibilityState(); const missing here too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 10:52:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 10:52:52 -0700 Subject: [Webkit-unassigned] [Bug 118574] SVG stroke-dasharray is not animatable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118574 Rob Buis changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rwlbuis at gmail.com |kit.org | CC| |rwlbuis at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 11:24:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 11:24:04 -0700 Subject: [Webkit-unassigned] [Bug 119490] New: Various media tests spew "CGContextScaleCTM: invalid context 0x0" errors Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119490 Summary: Various media tests spew "CGContextScaleCTM: invalid context 0x0" errors Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Media Elements AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.fraser at apple.com CC: jer.noble at apple.com These tests: media/event-attributes.html media/media-controls-invalid-url.html media/video-played-reset.html spew stuff like: Aug 5 09:42:44 s-bot-209.apple.com WebProcess[75176] : CGContextScaleCTM: invalid context 0x0 Aug 5 09:42:44 s-bot-209.apple.com WebProcess[75176] : CGContextScaleCTM: invalid context 0x0 Aug 5 09:42:44 s-bot-209.apple.com WebProcess[75176] : CGContextTranslateCTM: invalid context 0x0 Aug 5 09:42:44 s-bot-209.apple.com WebProcess[75176] : CGContextAddPath: invalid context 0x0 Aug 5 09:42:44 s-bot-209.apple.com WebProcess[75176] : clip: invalid context 0x0 Aug 5 09:42:44 s-bot-209.apple.com WebProcess[75176] : CGContextDrawLinearGradient: invalid context 0x0 Aug 5 09:42:44 s-bot-209.apple.com WebProcess[75176] : CGContextTranslateCTM: invalid context 0x0 Aug 5 09:42:44 s-bot-209.apple.com WebProcess[75176] : CGContextDrawLayerInRect: invalid context 0x0 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 12:31:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 12:31:47 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 --- Comment #12 from Mario Sanchez Prada 2013-08-05 12:31:27 PST --- (From update of attachment 208133) Thanks Brian for addressing all the comments. I've certainly nothing to add now, so... time for and official review? :-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 12:31:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 12:31:54 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 12:33:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 12:33:46 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 --- Comment #13 from Dirk Pranke 2013-08-05 12:33:25 PST --- I will try to take a look shortly :). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 12:47:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 12:47:24 -0700 Subject: [Webkit-unassigned] [Bug 119373] webkit-gtk fails to build with bison-3.0 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119373 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |zandobersek at gmail.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 12:48:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 12:48:06 -0700 Subject: [Webkit-unassigned] [Bug 117281] Crash in V8 benchmarks set in ARM, softfp, EABI In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117281 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msaboff at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 13:01:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 13:01:06 -0700 Subject: [Webkit-unassigned] [Bug 119446] [GTK] Parse Valgrind xml leak files In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119446 Dirk Pranke changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208024|review? |review- Flag| | --- Comment #6 from Dirk Pranke 2013-08-05 13:00:45 PST --- (From update of attachment 208024) View in context: https://bugs.webkit.org/attachment.cgi?id=208024&action=review I didn't review everything in this patch yet (in particular, I haven't looked at memcheck_analyze.py much. However, this code is clearly not written to generally conform to the webkitpy conventions and (IMO) should be cleaned up to do so, first. You also should write at least some unittests for this. > Tools/Scripts/webkitpy/port/common.py:35 > +import subprocess This code duplicates a lot of the work in webkitpy.common.system and webkitpy.port.server_process . Please use that code instead and/or get rid of the duplicate logic here. >> Tools/Scripts/webkitpy/port/common.py:43 >> + > > Two empty lines here, while one would be enough between definitions. Please fix all across the file (it happens all the time in this patch) Actually PEP-8 requires two blanks between top-level definitions. > Tools/Scripts/webkitpy/port/common.py:219 > + "_ZN4base8internal15RunnableAdapter*Run*"), Most of this file is pretty generic, but this routine is clearly pretty specific to one particular caller or purpose. You should rename this to something more indicative. Also, somehow it seems unlikely that the base:: functions will be needed somewhere :). > Tools/Scripts/webkitpy/port/gdb_helper.py:31 > +''' A bunch of helper functions for querying gdb.''' Again, you should probably be using the routines in webkitpy.system instead. > Tools/Scripts/webkitpy/port/gtk_leakdetector.py:27 > +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. I would probably just fold these classes into gtk.py rather than create a separate file. > Tools/Scripts/webkitpy/port/memcheck_analyze.py:666 > +def _main(): Normally people use main() for this rather than _main() . Also, in webkitpy land, we wouldn't have this at all and would either split this into a separate helper script in Tools/Scripts or a _unittest.py file. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 13:01:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 13:01:55 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 --- Comment #14 from Zan Dobersek 2013-08-05 13:01:36 PST --- (From update of attachment 208133) View in context: https://bugs.webkit.org/attachment.cgi?id=208133&action=review > Tools/Scripts/webkitpy/port/gtk.py:71 > + # Starting an application under Valgrind takes a lot longer than normal > + # so increase the timeout (empirically 10x is enough to avoid timeouts). > + multiplier = 10 if self.get_option("leaks") else 1 > if self.get_option('configuration') == 'Debug': > - return 12 * 1000 > - return 6 * 1000 > + return multiplier * 12 * 1000 > + return multiplier * 6 * 1000 This timeout value covers the maximum time each test is allowed to run, not the amount of time each DumpRenderTree/WebKitTestRunner instance takes to fire up and get ready for testing. I assume that under Valgrind, you'd still want a prolonged timeout value (so applying the multiplier here is OK), but the comment is not technically correct. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 13:02:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 13:02:32 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 Dirk Pranke changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208133|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #15 from Dirk Pranke 2013-08-05 13:02:12 PST --- (From update of attachment 208133) This looks fine. I'm basically rubber-stamping the valigrind command line part :). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 13:25:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 13:25:35 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208133|review+, commit-queue+ | Flag| | --- Comment #16 from WebKit Commit Bot 2013-08-05 13:25:16 PST --- (From update of attachment 208133) Clearing flags on attachment: 208133 Committed r153721: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 13:25:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 13:25:40 -0700 Subject: [Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118785 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #17 from WebKit Commit Bot 2013-08-05 13:25:20 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 13:25:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 13:25:43 -0700 Subject: [Webkit-unassigned] [Bug 116317] [GTK] Metabug: Memory leak detection using valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116317 Bug 116317 depends on bug 118785, which changed state. Bug 118785 Summary: [GTK] Implement leak checking with valgrind https://bugs.webkit.org/show_bug.cgi?id=118785 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|UNCONFIRMED |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 13:25:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 13:25:45 -0700 Subject: [Webkit-unassigned] [Bug 119446] [GTK] Parse Valgrind xml leak files In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119446 Bug 119446 depends on bug 118785, which changed state. Bug 118785 Summary: [GTK] Implement leak checking with valgrind https://bugs.webkit.org/show_bug.cgi?id=118785 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|UNCONFIRMED |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 13:25:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 13:25:46 -0700 Subject: [Webkit-unassigned] [Bug 119448] [Gtk] Suppress irrelevant or known leaks for Valgrind In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119448 Bug 119448 depends on bug 118785, which changed state. Bug 118785 Summary: [GTK] Implement leak checking with valgrind https://bugs.webkit.org/show_bug.cgi?id=118785 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|UNCONFIRMED |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 14:18:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 14:18:56 -0700 Subject: [Webkit-unassigned] [Bug 119495] New: ANGLE fails to build with trunk clang: 'register' storage class specifier is deprecated Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119495 Summary: ANGLE fails to build with trunk clang: 'register' storage class specifier is deprecated Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: ANGLE AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: dfarler at apple.com glslang_lex.cpp and Tokenizer.cpp fail to build due to -Wdeprecated-register and register storage class specifiers on yy-related variables. This storage class specifier is deprecated in C++11. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:14:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:14:39 -0700 Subject: [Webkit-unassigned] [Bug 119497] New: Move style recalculation out from Element Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 Summary: Move style recalculation out from Element Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: koivisto at iki.fi Element currently does too much. The current Element::recalcStyle() and the related functions can be turned into standalone functions that operate on DOM tree. This will also give more freedom for future refactoring, for example making style recalculation non-recursive. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:24:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:24:54 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:25:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:25:26 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 Pratik Solanki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |psolanki at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:26:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:26:41 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 --- Comment #1 from Antti Koivisto 2013-08-05 15:26:23 PST --- Created an attachment (id=208153) --> (https://bugs.webkit.org/attachment.cgi?id=208153&action=review) for bots -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:29:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:29:40 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org --- Comment #2 from WebKit Commit Bot 2013-08-05 15:29:21 PST --- Attachment 208153 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/StyleRecalculation.cpp', u'Source/WebCore/css/StyleRecalculation.h', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/ElementShadow.cpp', u'Source/WebCore/dom/ElementShadow.h', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/PseudoElement.cpp', u'Source/WebCore/dom/PseudoElement.h', u'Source/WebCore/dom/ShadowRoot.cpp', u'Source/WebCore/dom/ShadowRoot.h', u'Source/WebCore/dom/Text.cpp', u'Source/WebCore/dom/Text.h', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.h', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.h', u'Source/WebCore/html/HTMLIFrameElement.cpp', u'Source/WebCore/html/HTMLIFrameElement.h', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLOptionElement.h', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/loader/DocumentWriter.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/svg/SVGElement.cpp', u'Source/WebCore/svg/SVGElement.h', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h']" exit_code: 1 Source/WebCore/css/StyleRecalculation.cpp:123: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/dom/Document.h:49: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:37:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:37:58 -0700 Subject: [Webkit-unassigned] [Bug 119498] New: chunked-progress-event-expectedLength.html is flaky on Mac Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119498 Summary: chunked-progress-event-expectedLength.html is flaky on Mac Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: InRadar Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:38:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:38:45 -0700 Subject: [Webkit-unassigned] [Bug 73538] Layout Test http/tests/xmlhttprequest/chunked-progress-event-expectedLength.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=73538 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID --- Comment #3 from Alexey Proskuryakov 2013-08-05 15:38:26 PST --- Chromium bug, closing. There is a cross platform issue though, filed bug 119498. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:41:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:41:34 -0700 Subject: [Webkit-unassigned] [Bug 119498] chunked-progress-event-expectedLength.html is flaky on Mac In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119498 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |ap at webkit.org |kit.org | Attachment #208154| |review? Flag| | --- Comment #1 from Alexey Proskuryakov 2013-08-05 15:41:15 PST --- Created an attachment (id=208154) --> (https://bugs.webkit.org/attachment.cgi?id=208154&action=review) proposed fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:46:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:46:04 -0700 Subject: [Webkit-unassigned] [Bug 119485] [WebGL] validateRenderingState method name change In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119485 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208120|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:50:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:50:46 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 Qt Early Warning System Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |webkit-ews at sed.inf.u-szeged | |.hu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:50:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:50:51 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 Qt Early Warning System Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208153| |commit-queue- Flag| | --- Comment #3 from Qt Early Warning System Bot 2013-08-05 15:50:32 PST --- (From update of attachment 208153) Attachment 208153 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1351018 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 15:53:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 15:53:39 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 --- Comment #4 from Qt Early Warning System Bot 2013-08-05 15:53:20 PST --- (From update of attachment 208153) Attachment 208153 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1392007 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:07:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:07:59 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 Rego GTK+ EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rego+ews at igalia.com, | |xan.lopez at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:09:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:09:00 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:09:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:09:03 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 --- Comment #5 from Build Bot 2013-08-05 16:08:43 PST --- (From update of attachment 208153) Attachment 208153 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1392010 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:19:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:19:23 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 EFL EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eflews.bot at gmail.com, | |gyuyoung.kim at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:19:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:19:28 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 --- Comment #6 from EFL EWS Bot 2013-08-05 16:19:07 PST --- (From update of attachment 208153) Attachment 208153 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1343084 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:26:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:26:23 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 --- Comment #7 from Build Bot 2013-08-05 16:26:03 PST --- (From update of attachment 208153) Attachment 208153 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1396011 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:49:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:49:16 -0700 Subject: [Webkit-unassigned] [Bug 119500] New: Windows ANGLE release build needs optimization Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119500 Summary: Windows ANGLE release build needs optimization Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows 7 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: ANGLE AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: achristensen at apple.com CC: bfulgham at webkit.org The release (and production) builds of ANGLE should have the optimizations that they have in the original repository: inline function expansion, intrinsic functions, and whole program optimization. With these changes I'm seeing about 20fps on http://soulwire.github.io/WebGL-GPU-Particles/ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:51:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:51:34 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 --- Comment #8 from EFL EWS Bot 2013-08-05 16:51:14 PST --- (From update of attachment 208153) Attachment 208153 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1402001 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:52:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:52:16 -0700 Subject: [Webkit-unassigned] [Bug 119501] New: Editor::updateMarkersForWordsAffectedByEditing(bool) shouldn't compute start and end of words when there are nor markers Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119501 Summary: Editor::updateMarkersForWordsAffectedByEditing(bool) shouldn't compute start and end of words when there are nor markers Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: InRadar Severity: Normal Priority: P2 Component: HTML Editing AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: darin at apple.com, ap at webkit.org, enrica at apple.com setMarkedText is lower on ToT. To mitigate this, avoid computing the start and the end of words in Editor::updateMarkersForWordsAffectedByEditing(bool) when there are no document markers. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:53:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:53:17 -0700 Subject: [Webkit-unassigned] [Bug 119500] Windows ANGLE release build needs optimization In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119500 Alex Christensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208156| |review? Flag| | --- Comment #1 from Alex Christensen 2013-08-05 16:52:59 PST --- Created an attachment (id=208156) --> (https://bugs.webkit.org/attachment.cgi?id=208156&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:55:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:55:04 -0700 Subject: [Webkit-unassigned] [Bug 119500] Windows ANGLE release build needs optimization In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119500 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208156|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 16:55:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 16:55:14 -0700 Subject: [Webkit-unassigned] [Bug 119500] Windows ANGLE release build needs optimization In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119500 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |dino at apple.com, | |kondapallykalyan at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 17:05:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 17:05:54 -0700 Subject: [Webkit-unassigned] [Bug 119502] New: WebGL should be enabled on WinCairo port Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119502 Summary: WebGL should be enabled on WinCairo port Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows 7 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebGL AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: achristensen at apple.com CC: bfulgham at webkit.org The WinCairo port is ready for WebGL to be enabled, and nobody from webkit-dev objected. This involves #defines in FeatureDefines.h, building ANGLE, and linking to ANGLE. As a temporary solution I'm going to put the additional libraries to link to in WebKitCFLite.props. They'll eventually be moved to WebKitCommon.props. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 17:11:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 17:11:07 -0700 Subject: [Webkit-unassigned] [Bug 119502] WebGL should be enabled on WinCairo port In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119502 Alex Christensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208158| |review? Flag| | --- Comment #1 from Alex Christensen 2013-08-05 17:10:49 PST --- Created an attachment (id=208158) --> (https://bugs.webkit.org/attachment.cgi?id=208158&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 17:13:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 17:13:16 -0700 Subject: [Webkit-unassigned] [Bug 119502] WebGL should be enabled on WinCairo port In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119502 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin at webkit.org, | |cmarcelo at webkit.org, | |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 17:30:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 17:30:19 -0700 Subject: [Webkit-unassigned] [Bug 119497] Move style recalculation out from Element In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119497 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 17:40:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 17:40:18 -0700 Subject: [Webkit-unassigned] [Bug 119500] Windows ANGLE release build needs optimization In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119500 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208156|review+, commit-queue+ | Flag| | --- Comment #2 from WebKit Commit Bot 2013-08-05 17:39:59 PST --- (From update of attachment 208156) Clearing flags on attachment: 208156 Committed r153732: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 17:40:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 17:40:20 -0700 Subject: [Webkit-unassigned] [Bug 119500] Windows ANGLE release build needs optimization In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119500 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from WebKit Commit Bot 2013-08-05 17:40:01 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 17:46:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 17:46:14 -0700 Subject: [Webkit-unassigned] [Bug 119501] Editor::updateMarkersForWordsAffectedByEditing(bool) shouldn't compute start and end of words when there are nor markers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119501 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rniwa at webkit.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 18:01:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 18:01:12 -0700 Subject: [Webkit-unassigned] [Bug 119504] New: DFG optimizes out strict mode arguments tear off Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119504 Summary: DFG optimizes out strict mode arguments tear off Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: oliver at apple.com CC: fpizlo at apple.com If i have a strict mode function: function f(a) { "use strict"; a = 5; return arguments[0]; } var x = 0; for (var i = 0; i < N; i++) x = x + f(1); The result should be N, but the DFG optimizes out the eager tear off of the Arguments object, leading to arguments[0] eventually being optimized to return 5, which is incorrect. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 18:01:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 18:01:22 -0700 Subject: [Webkit-unassigned] [Bug 119504] DFG optimizes out strict mode arguments tear off In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119504 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |NeedsRadar -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 19:56:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 19:56:21 -0700 Subject: [Webkit-unassigned] [Bug 119508] New: Explicitly test same/cross-origin importScripts() effect on worker.onerror Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119508 Summary: Explicitly test same/cross-origin importScripts() effect on worker.onerror Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: ggaren at apple.com, oliver at apple.com Consider merging tests added in https://chromium.googlesource.com/chromium/blink/+/94edc6173e6605b221187d62bccf2f77d2a7818c We currently have a single test that checks behavior when calling importScripts() on a URL that redirects from same-origin to cross-origin. This patch adds tests for cross-origin and same-origin scripts, and updates the tests to use js-test-pre.js. Currently we have some weird behavior for cross-origin scripts. The message is sanitized, the URL is set to the worker JS file, and the line number is the call to 'importScripts'. Firefox has different weird behavior: the message is unsanitized, but the URL and line number are emptied. I think it's reasonable to leave the expectations as they are, but our eventual goal should be to sanitize these errors in the same way that we do normal cross-origin messages. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 5 20:01:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 5 Aug 2013 20:01:59 -0700 Subject: [Webkit-unassigned] [Bug 119508] Explicitly test same/cross-origin importScripts() effect on worker.onerror In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119508 --- Comment #1 from Oliver Hunt 2013-08-05 20:01:40 PST --- (In reply to comment #0) > Consider merging tests added in https://chromium.googlesource.com/chromium/blink/+/94edc6173e6605b221187d62bccf2f77d2a7818c > > We currently have a single test that checks behavior when calling > importScripts() on a URL that redirects from same-origin to cross-origin. > This patch adds tests for cross-origin and same-origin scripts, and updates > the tests to use js-test-pre.js. > > Currently we have some weird behavior for cross-origin scripts. The > message is sanitized, the URL is set to the worker JS file, and the line > number is the call to 'importScripts'. > > Firefox has different weird behavior: the message is unsanitized, but > the URL and line number are emptied. > > I think it's reasonable to leave the expectations as they are, but our > eventual goal should be to sanitize these errors in the same way that we > do normal cross-origin messages. The reason for cross origin sanitization in the normal case is that The backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff411bd4e in WebCore::StylePropertySet::propertyCount (this=0x0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/css/StylePropertySet.h:254 254 if (m_isMutable) (gdb) bt #0 0x00007ffff411bd4e in WebCore::StylePropertySet::propertyCount (this=0x0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/css/StylePropertySet.h:254 #1 0x00007ffff4148b86 in WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict (this=0x8ce7a0, other=0x0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/css/StylePropertySet.cpp:1039 #2 0x00007ffff42aff7c in WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange (this=0x8d0620, style=0x8cd440, startNode=..., pastEndNode=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/editing/ApplyStyleCommand.cpp:774 #3 0x00007ffff42af9cd in WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle (this=0x8d0620, style=0x8cd440, start=..., end=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/editing/ApplyStyleCommand.cpp:711 #4 0x00007ffff42af5e9 in WebCore::ApplyStyleCommand::applyInlineStyle (this=0x8d0620, style=0x8cd440) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/editing/ApplyStyleCommand.cpp:674 #5 0x00007ffff42ac785 in WebCore::ApplyStyleCommand::doApply (this=0x8d0620) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/editing/ApplyStyleCommand.cpp:225 #6 0x00007ffff42bbdfa in WebCore::CompositeEditCommand::applyCommandToComposite (this=0x8d03b0, prpCommand=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/editing/CompositeEditCommand.cpp:266 #7 0x00007ffff42bc0e5 in WebCore::CompositeEditCommand::applyStyledElement (this=0x8d03b0, element=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/editing/CompositeEditCommand.cpp:297 #8 0x00007ffff42c85e4 in WebCore::CreateLinkCommand::doApply (this=0x8d03b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/editing/CreateLinkCommand.cpp:50 #9 0x00007ffff42bbbc2 in WebCore::CompositeEditCommand::apply (this=0x8d03b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/editing/CompositeEditCommand.cpp:215 #10 0x00007ffff42bb94a in WebCore::applyCommand (command=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/editing/CompositeEditCommand.cpp:171 #11 0x00007ffff42ecae9 in WebCore::executeCreateLink (frame=0x7aff80, value=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/editing/EditorCommand.cpp:293 #12 0x00007ffff42f0c7a in WebCore::Editor::Command::execute (this=0x7fffffffb680, parameter=..., triggeringEvent=0x0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/editing/EditorCommand.cpp:1706 #13 0x00007ffff41c19b0 in WebCore::Document::execCommand (this=0x87ab60, commandName=..., userInterface=true, value=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:4150 #14 0x00007ffff4ec743a in WebCore::jsDocumentPrototypeFunctionExecCommand (exec=0x7fffe40a10b0) at generated/JSDocument.cpp:2748 #15 0x00007fff9ffff0e5 in ?? () #16 0x00007fffffffb820 in ?? () #17 0x00007ffff6814614 in llint_op_call () from /home/reni/Data/REPOS/webkit_sec/WebKitBuild/Debug/lib/libQt5WebKit.so.5 #18 0x00007fffffffb7d0 in ?? () #19 0x00007ffff555005b in JSC::JSStack::installTrapsAfterFrame (this=0x0, frame=0x0) at /home/reni/Data/REPOS/webkit_sec/Source/JavaScriptCore/interpreter/JSStackInlines.h:212 #20 0x00007ffff5560ba4 in JSC::JITCode::execute (this=0x8b5be0, stack=0x772c58, callFrame=0x7fffe40a1058, vm=0x7f5ce0) at /home/reni/Data/REPOS/webkit_sec/Source/JavaScriptCore/jit/JITCode.cpp:46 #21 0x00007ffff554c8e1 in JSC::Interpreter::execute (this=0x772c40, program=0x7fff863afef0, callFrame=0x7fff9c05f8e0, thisObj=0x7fffe403ffd8) at /home/reni/Data/REPOS/webkit_sec/Source/JavaScriptCore/interpreter/Interpreter.cpp:851 #22 0x00007ffff562b776 in JSC::evaluate (exec=0x7fff9c05f8e0, source=..., thisValue=..., returnedException=0x7fffffffc520) at /home/reni/Data/REPOS/webkit_sec/Source/JavaScriptCore/runtime/Completion.cpp:83 #23 0x00007ffff3f7097d in WebCore::JSMainThreadExecState::evaluate (exec=0x7fff9c05f8e0, source=..., thisValue=..., exception=0x7fffffffc520) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/bindings/js/JSMainThreadExecState.h:74 #24 0x00007ffff3f8f182 in WebCore::ScriptController::evaluateInWorld (this=0x773770, sourceCode=..., world=0x7674f0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/bindings/js/ScriptController.cpp:142 #25 0x00007ffff3f8f288 in WebCore::ScriptController::evaluate (this=0x773770, sourceCode=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/bindings/js/ScriptController.cpp:158 #26 0x00007ffff427c72f in WebCore::ScriptElement::executeScript (this=0x8b69a8, sourceCode=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/ScriptElement.cpp:316 #27 0x00007ffff427bf0a in WebCore::ScriptElement::prepareScript (this=0x8b69a8, scriptStartPosition=..., supportLegacyTypes=WebCore::ScriptElement::DisallowLegacyTypeInTypeAttribute) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/ScriptElement.cpp:245 #28 0x00007ffff442c215 in WebCore::HTMLScriptRunner::runScript (this=0x7b2b00, script=0x8b6940, scriptStartPosition=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLScriptRunner.cpp:312 #29 0x00007ffff442b966 in WebCore::HTMLScriptRunner::execute (this=0x7b2b00, scriptElement=..., scriptStartPosition=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLScriptRunner.cpp:181 ---Type to continue, or q to quit--- #30 0x00007ffff4418871 in WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder (this=0x7745c0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:271 #31 0x00007ffff441895c in WebCore::HTMLDocumentParser::canTakeNextToken (this=0x7745c0, mode=WebCore::HTMLDocumentParser::AllowYield, session=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:290 #32 0x00007ffff4418f74 in WebCore::HTMLDocumentParser::pumpTokenizer (this=0x7745c0, mode=WebCore::HTMLDocumentParser::AllowYield) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:535 #33 0x00007ffff44186df in WebCore::HTMLDocumentParser::pumpTokenizerIfPossible (this=0x7745c0, mode=WebCore::HTMLDocumentParser::AllowYield) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:235 #34 0x00007ffff441987e in WebCore::HTMLDocumentParser::append (this=0x7745c0, inputSource=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:747 #35 0x00007ffff41ae089 in WebCore::DecodedDataDocumentParser::flush (this=0x7745c0, writer=0x694190) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/DecodedDataDocumentParser.cpp:60 #36 0x00007ffff45b011f in WebCore::DocumentWriter::end (this=0x694190) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentWriter.cpp:245 #37 0x00007ffff45a2c98 in WebCore::DocumentLoader::finishedLoading (this=0x6940f0, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:402 #38 0x00007ffff45a2a06 in WebCore::DocumentLoader::notifyFinished (this=0x6940f0, resource=0x7528b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:344 #39 0x00007ffff4589d02 in WebCore::CachedResource::checkNotify (this=0x7528b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:369 #40 0x00007ffff4589dd8 in WebCore::CachedResource::finishLoading (this=0x7528b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:385 #41 0x00007ffff458652c in WebCore::CachedRawResource::finishLoading (this=0x7528b0, data=0x7a0920) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedRawResource.cpp:94 #42 0x00007ffff45ecb11 in WebCore::SubresourceLoader::didFinishLoading (this=0x799800, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/SubresourceLoader.cpp:282 #43 0x00007ffff45e33ff in WebCore::ResourceLoader::didFinishLoading (this=0x799800, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/ResourceLoader.cpp:488 #44 0x00007ffff4a8b121 in WebCore::QNetworkReplyHandler::finish (this=0x7a8af0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:516 #45 0x00007ffff4a89e40 in WebCore::QNetworkReplyHandlerCallQueue::flush (this=0x7a8b28) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:250 #46 0x00007ffff4a89b3d in WebCore::QNetworkReplyHandlerCallQueue::push (this=0x7a8b28, method=(void (WebCore::QNetworkReplyHandler::*)(WebCore::QNetworkReplyHandler * const)) 0x7ffff4a8af66 ) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:216 #47 0x00007ffff4a8aa8a in WebCore::QNetworkReplyWrapper::didReceiveFinished (this=0x796a40) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:409 #48 0x00007ffff4a8d41a in WebCore::QNetworkReplyWrapper::qt_static_metacall (_o=0x796a40, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffffffcf70) at .moc/release-shared/moc_QNetworkReplyHandler.cpp:176 #49 0x00007ffff22175cb in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #50 0x00007ffff221884e in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #51 0x00007ffff305edbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #52 0x00007ffff3062075 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #53 0x00007ffff21f2dbe in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #54 0x00007ffff21f4a76 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #55 0x00007ffff223a333 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #56 0x00007fffee37f0a6 in g_main_dispatch (context=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3058 #57 g_main_context_dispatch (context=context at entry=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3634 #58 0x00007fffee37f3f8 in g_main_context_iterate (context=context at entry=0x6632f0, block=block at entry=1, dispatch=dispatch at entry=1, self=) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3705 #59 0x00007fffee37f49c in g_main_context_iteration (context=0x6632f0, may_block=1) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3766 #60 0x00007ffff223a4bc in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 ---Type to continue, or q to quit--- #61 0x00007ffff21f1d3b in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #62 0x00007ffff21f5120 in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #63 0x0000000000421ba0 in launcherMain (app=...) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:49 #64 0x0000000000423680 in main (argc=2, argv=0x7fffffffdc48) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:318 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:13:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:13:14 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119570 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:19:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:19:42 -0700 Subject: [Webkit-unassigned] [Bug 119272] Broken build with build-webkit --no-webgl In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119272 Antonio Gomes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |achicu at adobe.com --- Comment #2 from Antonio Gomes 2013-08-08 05:19:21 PST --- @achicu: CSS Shaders require ANGLE to build, and this is not available if WEBGL if disabled from say build-webkit. Does it make sense to have a hard dependency on each other, as the patch does? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:21:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:21:35 -0700 Subject: [Webkit-unassigned] [Bug 119272] Broken build with build-webkit --no-webgl In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119272 Antonio Gomes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208298|review? |review- Flag| | --- Comment #3 from Antonio Gomes 2013-08-08 05:21:15 PST --- (From update of attachment 208298) please read http://www.webkit.org/coding/contributing.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:24:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:24:18 -0700 Subject: [Webkit-unassigned] [Bug 119571] New: [GTK] Accelerated compositing results in incorrect rendering of the media controllers Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119571 Summary: [GTK] Accelerated compositing results in incorrect rendering of the media controllers Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: agomez at igalia.com CC: mrobinson at webkit.org, calvaris at igalia.com When playing some multimedia content in WebKitGtk+ 1 or 2 with accelerated compositing enabled we can see problems on the rendered media controllers. Incorrect rendering: $ WebKitBuild/Release/Programs/MiniBrowser ./Tools/iExploder/iexploder-1.7.2/src/media/blank.ogg $ WebKitBuild/Release/Programs/GtkLauncher --enable-accelerated-compositing=TRUE ./Tools/iExploder/iexploder-1.7.2/src/media/blank.ogg Correct rendering: $ WebKitBuild/Release/Programs/GtkLauncher ./Tools/iExploder/iexploder-1.7.2/src/media/blank.ogg The problems are even more obvious with short media clips. $ WebKitBuild/Release/Programs/MiniBrowser ./Source/WebKit/gtk/tests/resources/test.ogg -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:25:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:25:19 -0700 Subject: [Webkit-unassigned] [Bug 119572] New: warning: "__GNU_C_MINOR__" is not defined in 2.0.4 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119572 Summary: warning: "__GNU_C_MINOR__" is not defined in 2.0.4 Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: richard at NetBSD.org patch submission: --- Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp.orig 2013-07-19 07:03:53.000000000 +0000 +++ Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp @@ -118,7 +118,7 @@ // Turn off uninitialized variable warnings triggered by the auto-generated pplval variable. // On gcc 4.7+, The flag is called "-Wmaybe-uninitialized". // On clang and gcc < 4.7, the flag is called "-Wuninitialized". -#if !defined(__clang__) && ((__GNUC__ == 4 && __GNU_C_MINOR__ >= 7) || __GNUC__ >= 5) +#if !defined(__clang__) && ((__GNUC__ == 4 && __GNUC_MINOR__ >= 7) || __GNUC__ >= 5) #pragma GCC diagnostic ignored "-Wmaybe-uninitialized" #else #pragma GCC diagnostic ignored "-Wuninitialized" -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:25:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:25:47 -0700 Subject: [Webkit-unassigned] [Bug 119570] Null-pointer derefence in WebCore::StylePropertySet::propertyCount In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119570 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |reni at webkit.org |kit.org | Attachment #208327| |review?, commit-queue- Flag| | --- Comment #1 from Renata Hodovan 2013-08-08 05:25:25 PST --- Created an attachment (id=208327) --> (https://bugs.webkit.org/attachment.cgi?id=208327&action=review) Proposed patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:26:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:26:10 -0700 Subject: [Webkit-unassigned] [Bug 64888] event mod keys are only available via WebKitDOMMouseEvent In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=64888 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgarcia at igalia.com, | |mrobinson at webkit.org, | |zandobersek at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:26:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:26:15 -0700 Subject: [Webkit-unassigned] [Bug 119571] [GTK] Accelerated compositing results in incorrect rendering of the media controllers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119571 --- Comment #1 from Andres Gomez Garcia 2013-08-08 05:25:54 PST --- Created an attachment (id=208328) --> (https://bugs.webkit.org/attachment.cgi?id=208328&action=review) Minibrowser showing the rendering problems in the media controllers with accelerated compositing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:26:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:26:36 -0700 Subject: [Webkit-unassigned] [Bug 119571] [GTK] Accelerated compositing results in incorrect rendering of the media controllers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119571 --- Comment #2 from Andres Gomez Garcia 2013-08-08 05:26:15 PST --- Created an attachment (id=208329) --> (https://bugs.webkit.org/attachment.cgi?id=208329&action=review) Gtklauncher showing the rendering problems in the media controllers with accelerated compositing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:33:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:33:01 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208316|review?, commit-queue? |review+, commit-queue- Flag| | --- Comment #57 from Carlos Garcia Campos 2013-08-08 05:32:38 PST --- (From update of attachment 208316) View in context: https://bugs.webkit.org/attachment.cgi?id=208316&action=review Looks good to me, thank you very much. > Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp:282 > + * #WebKitWebView::load-failed signal with a #WebKitNetworkError of type #WEBKIT_NETWORK_ERROR_CANCELLED being emitted. #WEBKIT_NETWORK_ERROR_CANCELLED -> %WEBKIT_NETWORK_ERROR_CANCELLED > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1395 > + * entirely, connect to this signal and simply return %TRUE; s/;/./ > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:1275 > + if (authorization && !strcmp(authorization, authExpectedAuthorization)) { You can use g_strcmp0 that hanldes NULL so that you don't need to check first if authorization != NULL. > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:1332 > + static WebKitTestServer* kServer = new WebKitTestServer(); > + kServer->run(test->serverCallback); You can make the server global like all other tests do, so that you don't need to create/delete the test for every test case. It will be run even if you launch tests that don't need it, but it's harmless. We could consider add a ensureWebKitTestServer() to start the server on demand, though, but it would be a separate patch. > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:1347 > + g_assert(!webkit_authentication_request_can_save_credentials(request)); You should also check this is TRUE when private browsing is FALSE and webkit has been compiled with libsecret. > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:1382 > + WebKitAuthenticationRequest* request = test->waitForAuthenticationRequest(); > + WebKitCredential* credential = webkit_credential_new(authTestUsername, "wrongpassword", WEBKIT_CREDENTIAL_PERSISTENCE_NONE); You could test here that the first time is_retry is FALSE. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:53:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:53:10 -0700 Subject: [Webkit-unassigned] [Bug 119303] Add enable_credential_store option In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119303 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brian.holt at samsung.com, | |cgarcia at igalia.com --- Comment #1 from Carlos Garcia Campos 2013-08-08 05:52:49 PST --- I think we could add webkit_authentication_request_set_allow_persistent_storage() or something similar. That way the user can connect to authenticate signal, set allow_persistent_storage to FALSE and return FALSE, so that the default dialog is shown, but it won't allow to save credentials persistenly using libsecret. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:54:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:54:12 -0700 Subject: [Webkit-unassigned] [Bug 119303] [GTK] Add enable_credential_store option In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119303 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add enable_credential_store |[GTK] Add |option |enable_credential_store | |option -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 05:59:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 05:59:16 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 Divakar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208333| |review? Flag| | --- Comment #8 from Divakar 2013-08-08 05:58:55 PST --- Created an attachment (id=208333) --> (https://bugs.webkit.org/attachment.cgi?id=208333&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:00:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:00:27 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 Divakar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208333|0 |1 is obsolete| | Attachment #208333|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:00:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:00:37 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 Divakar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208334| |review? Flag| | --- Comment #9 from Divakar 2013-08-08 06:00:15 PST --- Created an attachment (id=208334) --> (https://bugs.webkit.org/attachment.cgi?id=208334&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:01:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:01:33 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 Divakar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208333|1 |0 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:02:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:02:10 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin at webkit.org, | |cmarcelo at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:02:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:02:41 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 Divakar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208334|1 |0 is patch| | Attachment #208334|0 |1 is obsolete| | Attachment #208334|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:02:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:02:55 -0700 Subject: [Webkit-unassigned] [Bug 119572] warning: "__GNU_C_MINOR__" is not defined in 2.0.4 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119572 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgarcia at igalia.com, | |zandobersek at gmail.com --- Comment #1 from Zan Dobersek 2013-08-08 06:02:34 PST --- The patch looks good, though it still requires a changelog - see the following page on how to add it and what it should contain: http://www.webkit.org/coding/contributing.html The issue is already fixed in trunk as the ANGLE sources were recently updated, fixing the mistake. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:03:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:03:27 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 Divakar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208333|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:03:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:03:37 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 Divakar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208335| |review? Flag| | --- Comment #10 from Divakar 2013-08-08 06:03:16 PST --- Created an attachment (id=208335) --> (https://bugs.webkit.org/attachment.cgi?id=208335&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:03:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:03:44 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 Divakar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208333|1 |0 is patch| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:05:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:05:28 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 --- Comment #11 from Divakar 2013-08-08 06:05:06 PST --- Corrected error and updated the patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:06:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:06:25 -0700 Subject: [Webkit-unassigned] [Bug 118067] [GTK] Use the GCActivityCallback In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118067 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrobinson at webkit.org, | |xinchao.peng at samsung.com, | |zandobersek at gmail.com --- Comment #6 from Zan Dobersek 2013-08-08 06:06:04 PST --- The patch looks about right after a quick glance at it, but is still missing the changelog and the r? flag so someone can actually do a proper review. There's also some styling issues present. It also needs to apply to the tree so the EWSs can process it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:14:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:14:09 -0700 Subject: [Webkit-unassigned] [Bug 119573] New: Malformed media query: Media queries with unexpected tokens are represented as "not all". Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119573 Summary: Malformed media query: Media queries with unexpected tokens are represented as "not all". Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Major Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: zalan at apple.com @media screen and (min-width: 480px), and (device-width: 768px) { should read @media screen and (min-width: 480px), not all http://www.w3.org/TR/css3-mediaqueries/ FYI: Works in Chrome: "Version 30.0.1590.2 canary". Probably just matter of cherrypicking the relevant patch(es). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:14:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:14:45 -0700 Subject: [Webkit-unassigned] [Bug 119513] [WebGL] compileShader map iterator validation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119513 --- Comment #4 from Przemyslaw Szymanski 2013-08-08 06:14:24 PST --- (In reply to comment #3) > (From update of attachment 208172 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208172&action=review > > > Source/WebCore/ChangeLog:15 > > + No new tests. Covered by existing tests. > > + LayoutTests/webgl/conformance/glsl/functions/glsl-function-abs.html > > + LayoutTests/webgl/conformance/glsl/functions/glsl-function-acos.html > > + LayoutTests/webgl/conformance/glsl/functions/glsl-function-length.html > > These tests currently crash, or exhibit bad behavior? > If so, we should unskip them with this change. Thank you for your review. These tests works fine. I ran them in the minibrowser directly. I ran Khronos conformance tests too. This patch does not break any webgl test. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:17:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:17:12 -0700 Subject: [Webkit-unassigned] [Bug 119303] [GTK] Add enable_credential_store option In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119303 Martin Robinson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrobinson at webkit.org --- Comment #2 from Martin Robinson 2013-08-08 06:16:50 PST --- (In reply to comment #1) > I think we could add webkit_authentication_request_set_allow_persistent_storage() or something similar. That way the user can connect to authenticate signal, set allow_persistent_storage to FALSE and return FALSE, so that the default dialog is shown, but it won't allow to save credentials persistenly using libsecret. Maybe this deserves a global setting? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:20:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:20:58 -0700 Subject: [Webkit-unassigned] [Bug 119573] Malformed media query: Media queries with unexpected tokens are represented as "not all". In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119573 --- Comment #1 from Zalan Bujtas 2013-08-08 06:20:37 PST --- Created an attachment (id=208337) --> (https://bugs.webkit.org/attachment.cgi?id=208337&action=review) test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:38:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:38:40 -0700 Subject: [Webkit-unassigned] [Bug 115180] [GTK] Compile only WebKit2 by default In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115180 --- Comment #10 from Zan Dobersek 2013-08-08 06:38:19 PST --- I agree with the WK2 testing coverage on all points, it's basically just a matter of determining which underlying hardware should be tasked with testing what configuration, and executing that. Of course it's important to get this done quick enough as the focus is on WK2 now. Also related, it should be discussed what amount of focus should be left on WebKit1 - API additions are already not welcomed there anymore, though basically most of the testing coverage is still on that variant. Putting that aside and focusing on the scope of this patch, I'd recommend disabling WebKit1 builds by default only in the Autotools build system. Developers and Buildbot builders should still rely on build-webkit's --no-webkit1 and --no-webkit2 flags to get the desired configuration. Similarly, I don't think the additional --webkit1 flag is needed. In short - release builds (straight via configure) should disable WK1 by default, developer builds (through build-webkit) should still enable WK1 unless specifically disabled (via --no-webkit1), at most until support for WK1GTK+ and all of its related code is thrown out of the source tree. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:43:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:43:11 -0700 Subject: [Webkit-unassigned] [Bug 94345] [Qt][WK2] Accelerated compositing example with links being animated crashes tap highlight In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=94345 --- Comment #7 from Allan Sandfeld Jensen 2013-08-08 06:42:49 PST --- Reported as QTBUG-32454 now. https://bugreports.qt-project.org/browse/QTBUG-32454 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:51:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:51:23 -0700 Subject: [Webkit-unassigned] [Bug 119513] [WebGL] compileShader map iterator validation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119513 Andreas Kling changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com --- Comment #5 from Andreas Kling 2013-08-08 06:51:02 PST --- (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 208172 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=208172&action=review > > > > > Source/WebCore/ChangeLog:15 > > > + No new tests. Covered by existing tests. > > > + LayoutTests/webgl/conformance/glsl/functions/glsl-function-abs.html > > > + LayoutTests/webgl/conformance/glsl/functions/glsl-function-acos.html > > > + LayoutTests/webgl/conformance/glsl/functions/glsl-function-length.html > > > > These tests currently crash, or exhibit bad behavior? > > If so, we should unskip them with this change. > > Thank you for your review. > These tests works fine. I ran them in the minibrowser directly. I ran Khronos conformance tests too. This patch does not break any webgl test. If these tests work fine without the change, how is this "covered by existing tests"? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 06:59:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 06:59:16 -0700 Subject: [Webkit-unassigned] [Bug 119571] [GTK] Accelerated compositing results in incorrect rendering of the media controllers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119571 Sergio Villar Senin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |svillar at igalia.com --- Comment #3 from Sergio Villar Senin 2013-08-08 06:58:55 PST --- I don't get exactly where the problem is. The right part of the control inside the slider? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 07:16:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 07:16:22 -0700 Subject: [Webkit-unassigned] [Bug 119303] [GTK] Add enable_credential_store option In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119303 --- Comment #3 from Carlos Garcia Campos 2013-08-08 07:16:01 PST --- (In reply to comment #2) > (In reply to comment #1) > > I think we could add webkit_authentication_request_set_allow_persistent_storage() or something similar. That way the user can connect to authenticate signal, set allow_persistent_storage to FALSE and return FALSE, so that the default dialog is shown, but it won't allow to save credentials persistenly using libsecret. > > Maybe this deserves a global setting? It would be easier to use indeed, I guess you won't want a different mode per auth request. Global settings as per web view group or web context? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 07:20:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 07:20:31 -0700 Subject: [Webkit-unassigned] [Bug 119303] [GTK] Add enable_credential_store option In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119303 --- Comment #4 from Martin Robinson 2013-08-08 07:20:10 PST --- (In reply to comment #3) > It would be easier to use indeed, I guess you won't want a different mode per auth request. Global settings as per web view group or web context? Can requests not have a WebView that owns them? I'd say WebContext, but I'm not certain. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 07:29:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 07:29:16 -0700 Subject: [Webkit-unassigned] [Bug 119571] [GTK] Accelerated compositing results in incorrect rendering of the media controllers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119571 --- Comment #4 from Xabier Rodr?guez Calvar 2013-08-08 07:28:55 PST --- (In reply to comment #3) > I don't get exactly where the problem is. The right part of the control inside the slider? The right part of the time slider thumb. It's truncated. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 07:35:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 07:35:31 -0700 Subject: [Webkit-unassigned] [Bug 103454] Typed Arrays should be part of JSC In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=103454 Antonio Gomes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tonikitoo at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 07:37:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 07:37:48 -0700 Subject: [Webkit-unassigned] [Bug 115180] [GTK] Compile only WebKit2 by default In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115180 --- Comment #11 from Zan Dobersek 2013-08-08 07:37:27 PST --- (In reply to comment #10) > Putting that aside and focusing on the scope of this patch, I'd recommend disabling WebKit1 builds by default only in the Autotools build system. Developers and Buildbot builders should still rely on build-webkit's --no-webkit1 and --no-webkit2 flags to get the desired configuration. Similarly, I don't think the additional --webkit1 flag is needed. > > In short - release builds (straight via configure) should disable WK1 by default, developer builds (through build-webkit) should still enable WK1 unless specifically disabled (via --no-webkit1), at most until support for WK1GTK+ and all of its related code is thrown out of the source tree. Another approach: Disable WebKit1 by default in Automake configuration, as it's done in the proposed patch now. For build-webkit, no new options would be required, but --no-webkit1 and --no-webkit2 options' support would be removed for the Autotools build system. This would mean that runnning `build-webkit --gtk` would fall back to only building WK2. One could still build WK1 by running `build-webkit --gtk --enable-webkit1` as the unrecognized arguments are added to the arguments list that's used when running autogen.sh. The related code that does that is located here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitdirs.pm#L1980 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 07:39:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 07:39:25 -0700 Subject: [Webkit-unassigned] [Bug 88671] generated js bindings should include headers for argument conditionally. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=88671 Antonio Gomes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tonikitoo at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 07:53:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 07:53:05 -0700 Subject: [Webkit-unassigned] [Bug 114550] [GTK] Unable to build with --disable-webgl. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114550 Antonio Gomes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tonikitoo at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 07:55:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 07:55:19 -0700 Subject: [Webkit-unassigned] [Bug 119513] [WebGL] compileShader map iterator validation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119513 --- Comment #6 from Antonio Gomes 2013-08-08 07:54:57 PST --- (From update of attachment 208172) View in context: https://bugs.webkit.org/attachment.cgi?id=208172&action=review > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:467 > + if (result == m_shaderSourceMap.end()) > + return; what situation does the patch help? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 07:55:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 07:55:45 -0700 Subject: [Webkit-unassigned] [Bug 102586] [GTK] media/video-src-blob.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=102586 --- Comment #5 from Philippe Normand 2013-08-08 07:55:23 PST --- LGTM but yeah that helper function would be good to have indeed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 07:56:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 07:56:56 -0700 Subject: [Webkit-unassigned] [Bug 117169] HTMLCanvasElement should have helper method to check attributes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117169 Antonio Gomes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tonikitoo at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:01:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:01:15 -0700 Subject: [Webkit-unassigned] [Bug 117039] [GStreamer] Support audio and video tracks In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117039 --- Comment #44 from Philippe Normand 2013-08-08 08:00:50 PST --- Well this looks good to me apart from the missing tests and the input-selector issue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:03:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:03:33 -0700 Subject: [Webkit-unassigned] [Bug 94345] [Qt][WK2] Accelerated compositing example with links being animated crashes tap highlight In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=94345 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |allan.jensen at digia.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:05:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:05:56 -0700 Subject: [Webkit-unassigned] [Bug 119574] New: [WK1] NPStream::headers not initialized Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119574 Summary: [WK1] NPStream::headers not initialized Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Plug-ins AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: allan.jensen at digia.com The header field of NPStream is left uninitialized currently until the stream starts. According to some users this causes crashes with NSplugins on Mac and Windows. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:07:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:07:54 -0700 Subject: [Webkit-unassigned] [Bug 119574] [WK1] NPStream::headers not initialized In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119574 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |allan.jensen at digia.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:12:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:12:33 -0700 Subject: [Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=103771 --- Comment #107 from Philippe Normand 2013-08-08 08:12:08 PST --- (From update of attachment 207777) I haven't had time to review this yet but I have one question :) Would this patch fix some of the media/track tests? At least media/track/track-in-band.html ? It'd be great this is patch help unskip layout tests. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:20:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:20:27 -0700 Subject: [Webkit-unassigned] [Bug 104054] svg/custom/use-href-update-crash.svg failing on certain platforms In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104054 Rob Buis changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rwlbuis at gmail.com |kit.org | CC| |rwlbuis at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:26:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:26:19 -0700 Subject: [Webkit-unassigned] [Bug 115180] [GTK] Compile only WebKit2 by default In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115180 Sergio Villar Senin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |svillar at igalia.com --- Comment #12 from Sergio Villar Senin 2013-08-08 08:25:58 PST --- (In reply to comment #11) > Another approach: > Disable WebKit1 by default in Automake configuration, as it's done in the proposed patch now. For build-webkit, no new options would be required, but --no-webkit1 and --no-webkit2 options' support would be removed for the Autotools build system. This would mean that runnning `build-webkit --gtk` would fall back to only building WK2. One could still build WK1 by running `build-webkit --gtk --enable-webkit1` as the unrecognized arguments are added to the arguments list that's used when running autogen.sh. > I like this -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:27:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:27:17 -0700 Subject: [Webkit-unassigned] [Bug 119539] [EFL] REGRESSION after r153432: marking crashing tests. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119539 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario at webkit.org --- Comment #4 from Mario Sanchez Prada 2013-08-08 08:26:55 PST --- Bug 119333 has been fixed. Time for trying these tests again in EFL? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:32:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:32:57 -0700 Subject: [Webkit-unassigned] [Bug 118713] Support findPlugin through file extentions when a mimetype is not null In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118713 --- Comment #5 from Philippe Normand 2013-08-08 08:32:36 PST --- (From update of attachment 206724) View in context: https://bugs.webkit.org/attachment.cgi?id=206724&action=review > Source/WebKit2/ChangeLog:3 > + Support findPlugin through file extentions when a mimetype isn't null. Needs [WK2] prefix. I will retitle the bug. > Source/WebKit2/ChangeLog:8 > + To find plugin through file extentions even if mimetype isn't null. It'd be good to elaborate a bit here. Why is this change needed? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:33:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:33:12 -0700 Subject: [Webkit-unassigned] [Bug 118713] [WK2] Support findPlugin through file extentions when a mimetype is not null In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118713 Philippe Normand changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Support findPlugin through |[WK2] Support findPlugin |file extentions when a |through file extentions |mimetype is not null |when a mimetype is not null CC| |pnormand at igalia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:37:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:37:18 -0700 Subject: [Webkit-unassigned] [Bug 115180] [GTK] Compile only WebKit2 by default In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115180 --- Comment #13 from Martin Robinson 2013-08-08 08:36:56 PST --- (In reply to comment #12) > (In reply to comment #11) > > Another approach: > > Disable WebKit1 by default in Automake configuration, as it's done in the proposed patch now. For build-webkit, no new options would be required, but --no-webkit1 and --no-webkit2 options' support would be removed for the Autotools build system. This would mean that runnning `build-webkit --gtk` would fall back to only building WK2. One could still build WK1 by running `build-webkit --gtk --enable-webkit1` as the unrecognized arguments are added to the arguments list that's used when running autogen.sh. > > > I like this I like it as well, though I have some small reservations about disabling WebKit1 by default for the Automake build. The primary consumers of the Automake path are downstream builders and they usually need WebKit1. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:45:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:45:09 -0700 Subject: [Webkit-unassigned] [Bug 117039] [GStreamer] Support audio and video tracks In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117039 --- Comment #45 from Brendan Long 2013-08-08 08:44:45 PST --- (In reply to comment #44) > Well this looks good to me apart from the missing tests and the input-selector issue. I'll try to get some tests done next week. I assume we don't want to commit this until input-selector works right though. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:45:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:45:25 -0700 Subject: [Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=103771 --- Comment #108 from Brendan Long 2013-08-08 08:45:02 PST --- (In reply to comment #107) > (From update of attachment 207777 [details]) > I haven't had time to review this yet but I have one question :) Would this patch fix some of the media/track tests? At least media/track/track-in-band.html ? It'd be great this is patch help unskip layout tests. track-in-band.html expects the "kind" to be set to captions, but there's not currently any way to figure out the track kind in GStreamer (see: https://bugzilla.gnome.org/show_bug.cgi?id=698853). Also, it expects "forced" tracks, but I can't find them in the HTML5 spec. I was thinking of creating a copy of counting-subtitled.m4v without forced subtitles and using that for new tests.. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 08:55:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 08:55:01 -0700 Subject: [Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=103771 --- Comment #109 from Eric Carlson 2013-08-08 08:54:38 PST --- (In reply to comment #108) > (In reply to comment #107) > > (From update of attachment 207777 [details] [details]) > > I haven't had time to review this yet but I have one question :) Would this patch fix some of the media/track tests? At least media/track/track-in-band.html ? It'd be great this is patch help unskip layout tests. > > track-in-band.html expects the "kind" to be set to captions, but there's not currently any way to figure out the track kind in GStreamer (see: https://bugzilla.gnome.org/show_bug.cgi?id=698853). Also, it expects "forced" tracks, but I can't find them in the HTML5 spec. > There is nothing in the spec about forced tracks yet, but this bug tracks adding something: https://www.w3.org/Bugs/Public/show_bug.cgi?id=21667 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:01:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:01:41 -0700 Subject: [Webkit-unassigned] [Bug 118067] [GTK] Use the GCActivityCallback In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118067 --- Comment #7 from Sergio Villar Senin 2013-08-08 09:01:20 PST --- (From update of attachment 207176) View in context: https://bugs.webkit.org/attachment.cgi?id=207176&action=review Apart from the inline comments, remember that you have to add a proper ChangeLog with the description of the changes (maybe this helps http://trac.webkit.org/wiki/CodeReview) > runtime/GCActivityCallback.h:72 > + } You don't need this if you aren't doing anything different from the #else following this code. > runtime/GCActivityCallback.h:117 > +#endif At least cancelTimer(), scheduleTimer() and m_delay are shared with the other ports. There should be a better way to write this. > runtime/GCActivityCallback.cpp:44 > +#include Why gdk? > runtime/GCActivityCallback.cpp:87 > +} Isn't this exactly the same as Qt? Couldn't we do "#elif PLATFORM(QT) || PLATFORM(GTK)" ? > runtime/GCActivityCallback.cpp:168 > + Check the indentation and remove the extra lines at the end of the function. > runtime/GCActivityCallback.cpp:174 > + stop(); Check indentation. Also the implementation is exactly the same as EFL, we might think about sharing it. > runtime/GCActivityCallback.cpp:179 > + Extra line. > runtime/GCActivityCallback.cpp:181 > + return; Indentation. > runtime/GCActivityCallback.cpp:202 > + return; Indentation. Also any reason why we could not share EFL's code?. Actually, I don't know exactly about the details but looks like the EFL code might be shared among ports (not sure about the ASSERT though) > heap/HeapTimer.cpp:44 > +#include Again why gdk? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:01:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:01:52 -0700 Subject: [Webkit-unassigned] [Bug 115180] [GTK] Compile only WebKit2 by default In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115180 --- Comment #14 from Carlos Garcia Campos 2013-08-08 09:01:31 PST --- (In reply to comment #13) > (In reply to comment #12) > > (In reply to comment #11) > > > Another approach: > > > Disable WebKit1 by default in Automake configuration, as it's done in the proposed patch now. For build-webkit, no new options would be required, but --no-webkit1 and --no-webkit2 options' support would be removed for the Autotools build system. This would mean that runnning `build-webkit --gtk` would fall back to only building WK2. One could still build WK1 by running `build-webkit --gtk --enable-webkit1` as the unrecognized arguments are added to the arguments list that's used when running autogen.sh. > > > > > I like this > > I like it as well, though I have some small reservations about disabling WebKit1 by default for the Automake build. The primary consumers of the Automake path are downstream builders and they usually need WebKit1. Same concern here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:17:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:17:30 -0700 Subject: [Webkit-unassigned] [Bug 119577] New: [Qt] REGRESSION(r153664): ThirdParty Angle build is broken. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119577 Summary: [Qt] REGRESSION(r153664): ThirdParty Angle build is broken. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: ANGLE AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: zarvai at inf.u-szeged.hu CC: allan.jensen at digia.com, dino at apple.com, ossy at webkit.org, jocelyn.turcotte at digia.com, kadam at inf.u-szeged.hu, achristensen at apple.com Blocks: 119452 Created an attachment (id=208348) --> (https://bugs.webkit.org/attachment.cgi?id=208348&action=review) build log It seems a header file is missing from the update. I found a SoftLinking.h file in Source/WebCore/platform/win. Should we use that one? C:\buildslave\qt-windows-32bit-release\build\Source\ThirdParty\ANGLE\include\GLES2/gl2softlinking.h(25) : fatal error C1083: Cannot open include file: 'SoftLinking.h': No such file or directory util.cpp Full build log attached. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:17:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:17:31 -0700 Subject: [Webkit-unassigned] [Bug 119452] ANGLE should be soft linked on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119452 Zoltan Arvai changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119577 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:18:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:18:17 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208316|0 |1 is obsolete| | Attachment #208316|review+, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:18:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:18:29 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208349| |review?, commit-queue? Flag| | --- Comment #58 from Brian Holt 2013-08-08 09:18:07 PST --- Created an attachment (id=208349) --> (https://bugs.webkit.org/attachment.cgi?id=208349&action=review) Final patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:23:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:23:20 -0700 Subject: [Webkit-unassigned] [Bug 119569] REGRESSION(FTL merge): There are still crashes on ARM In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119569 --- Comment #1 from Michael Saboff 2013-08-08 09:22:57 PST --- The test results show there was a crash, but there isn't a crash log. Could you run one or more of these tests and attach a backtrace? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:23:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:23:41 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208349|review? | Flag| | --- Comment #59 from Brian Holt 2013-08-08 09:23:20 PST --- (From update of attachment 208349) View in context: https://bugs.webkit.org/attachment.cgi?id=208349&action=review All changes have been applied - Carlos could you take a last look if they're ok and cq+? > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:1428 > + if (authorization && !strcmp(authorization, authExpectedAuthorization)) { I tried g_strcmp0, but since authExpectedAuthorization is never NULL it always returns true and never gets through to sending a challenge. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:26:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:26:40 -0700 Subject: [Webkit-unassigned] [Bug 119573] Malformed media query: Media queries with unexpected tokens are represented as "not all". In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119573 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rniwa at webkit.org, | |simon.fraser at apple.com --- Comment #2 from Simon Fraser (smfr) 2013-08-08 09:26:19 PST --- We should really take those patches. Would be good to pass this suite. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:30:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:30:17 -0700 Subject: [Webkit-unassigned] [Bug 117993] SunSpider: Move the 3d-morph fix from version 1.0 to version 1.0.1 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117993 Cosmin Truta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206011|commit-queue? |commit-queue+ Flag| | --- Comment #9 from Cosmin Truta 2013-08-08 09:29:56 PST --- (From update of attachment 206011) Thank you for the review. Committing. By the way, I noticed this change fixes the 3d-morph execution on Windows Phone also. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:36:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:36:55 -0700 Subject: [Webkit-unassigned] [Bug 101047] REGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=101047 --- Comment #12 from Zalan Bujtas 2013-08-08 09:36:34 PST --- Debug build asserts when hovering the menu. It probably has a lot to do with the blank content. ASSERTION FAILED: parentClipRect != PaintInfo::infiniteRect() RenderLayerBacking.cpp(681) : void WebCore::RenderLayerBacking::updateGraphicsLayerGeometry() 1 0x106bcaec0 WTFCrash 2 0x108d40eab WebCore::RenderLayerBacking::updateGraphicsLayerGeometry() 3 0x108d5417a WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry(WebCore::RenderLayer*, WebCore::RenderLayer*, bool) 4 0x108d543d0 WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry(WebCore::RenderLayer*, WebCore::RenderLayer*, bool) 5 0x108d543d0 WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry(WebCore::RenderLayer*, WebCore::RenderLayer*, bool) 6 0x108d543d0 WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry(WebCore::RenderLayer*, WebCore::RenderLayer*, bool) 7 0x108d40659 WebCore::RenderLayerBacking::updateAfterLayout(unsigned int) 8 0x108d0d8e7 WebCore::RenderLayer::updateLayerPositions(WebCore::RenderGeometryMap*, unsigned int) 9 0x108d0d201 WebCore::RenderLayer::updateLayerPositionsAfterLayout(WebCore::RenderLayer const*, unsigned int) 10 0x10802fba8 WebCore::FrameView::layout(bool) 11 0x107d92158 WebCore::Document::updateLayout() 12 0x108d23f76 WebCore::RenderLayer::hitTest(WebCore::HitTestRequest const&, WebCore::HitTestLocation const&, WebCore::HitTestResult&) 13 0x108ea2c8f WebCore::RenderView::hitTest(WebCore::HitTestRequest const&, WebCore::HitTestLocation const&, WebCore::HitTestResult&) 14 0x108ea2c44 WebCore::RenderView::hitTest(WebCore::HitTestRequest const&, WebCore::HitTestResult&) 15 0x107d99bbe WebCore::Document::prepareMouseEvent(WebCore::HitTestRequest const&, WebCore::LayoutPoint const&, WebCore::PlatformMouseEvent const&) 16 0x107f21341 WebCore::EventHandler::prepareMouseEvent(WebCore::HitTestRequest const&, WebCore::PlatformMouseEvent const&) 17 0x107f218a9 WebCore::EventHandler::handleMouseMoveEvent(WebCore::PlatformMouseEvent const&, WebCore::HitTestResult*, bool) 18 0x107f213d6 WebCore::EventHandler::mouseMoved(WebCore::PlatformMouseEvent const&) 19 0x1052e78a8 WebKit::handleMouseEvent(WebKit::WebMouseEvent const&, WebKit::WebPage*, bool) 20 0x1052e76a7 WebKit::WebPage::mouseEvent(WebKit::WebMouseEvent const&) 21 0x105331987 void CoreIPC::callMemberFunction(CoreIPC::Arguments1 const&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebMouseEvent const&)) 22 0x1053237b5 void CoreIPC::handleMessage(CoreIPC::MessageDecoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebMouseEvent const&)) 23 0x10531d821 WebKit::WebPage::didReceiveWebPageMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&) 24 0x1052ebe77 WebKit::WebPage::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&) 25 0x1052ebeb7 non-virtual thunk to WebKit::WebPage::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&) 26 0x105092ae0 CoreIPC::MessageReceiverMap::dispatchMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&) 27 0x1053ccd6a WebKit::WebProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&) 28 0x104fe6aa3 CoreIPC::Connection::dispatchMessage(CoreIPC::MessageDecoder&) 29 0x104fe2dda CoreIPC::Connection::dispatchMessage(WTF::PassOwnPtr) 30 0x104fe6a3b CoreIPC::Connection::dispatchOneMessage() 31 0x104ff2042 WTF::FunctionWrapper::operator()(CoreIPC::Connection*) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:39:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:39:54 -0700 Subject: [Webkit-unassigned] [Bug 116491] REGRESSION(r150386): [WK2] loader/go-back-cached-main-resource.html fails In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116491 --- Comment #5 from Alexey Proskuryakov 2013-08-08 09:39:33 PST --- This bug should have been closed with the rollout, but I'm now landing that change again, and the test still fails. Will use this bug to track fixing it separately. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:42:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:42:57 -0700 Subject: [Webkit-unassigned] [Bug 119565] problems encountered with fast-malloc on illumos x86_64 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119565 --- Comment #1 from richard at NetBSD.org 2013-08-08 09:42:36 PST --- Well, --enable-fast-malloc=no doesn't seem to have made a difference, wondering if it is because in http://trac.webkit.org/changeset/142179 WTF_SYSTEM_MALLOC is defined as 1, but USE_SYSTEM_MALLOC is what appears to be checked for in the source code. Perhaps this was an incomplete patchset. Trying again now with CPPFLAGS+= -DUSE_SYSTEM_MALLOC as well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:54:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:54:35 -0700 Subject: [Webkit-unassigned] [Bug 117993] SunSpider: Move the 3d-morph fix from version 1.0 to version 1.0.1 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117993 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206011|review+, commit-queue+ | Flag| | --- Comment #10 from WebKit Commit Bot 2013-08-08 09:54:13 PST --- (From update of attachment 206011) Clearing flags on attachment: 206011 Committed r153824: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 09:54:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 09:54:37 -0700 Subject: [Webkit-unassigned] [Bug 117993] SunSpider: Move the 3d-morph fix from version 1.0 to version 1.0.1 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117993 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #11 from WebKit Commit Bot 2013-08-08 09:54:16 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 10:05:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 10:05:19 -0700 Subject: [Webkit-unassigned] [Bug 118713] [WK2] Support findPlugin through file extension when a mimetype is not null In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118713 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[WK2] Support findPlugin |[WK2] Support findPlugin |through file extentions |through file extension when |when a mimetype is not null |a mimetype is not null CC| |ap at webkit.org --- Comment #6 from Alexey Proskuryakov 2013-08-08 10:04:57 PST --- It?s generally not a good idea to disregard an explicitly provided MIME type. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 10:10:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 10:10:30 -0700 Subject: [Webkit-unassigned] [Bug 119577] [Qt] REGRESSION(r153664): ThirdParty Angle build is broken. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119577 --- Comment #1 from Alex Christensen 2013-08-08 10:10:09 PST --- Don't use SoftLinking.h while building ANGLE. To get the soft linking to work you need to define ANGLE_WEBKIT_WIN (which I did in translatorCommon.props, libEGLCommon.props, and libGLESv2Common.props in https://trac.webkit.org/changeset/153664) while compiling ANGLE to produce an unaltered dll. When compiling WebCore with WebGL enabled, do not define ANGLE_WEBKIT_WIN and it will use my soft link headers (eglsoftlinking.h and gl2softlinking.h). Are you planning to get WebGL working on Qt win? Let me know if you run into any problems. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 10:11:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 10:11:03 -0700 Subject: [Webkit-unassigned] [Bug 119579] New: clip path transition to none crashes Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119579 Summary: clip path transition to none crashes Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gammon at adobe.com CC: krit at webkit.org Created an attachment (id=208354) --> (https://bugs.webkit.org/attachment.cgi?id=208354&action=review) reduced example if you have a clip path on an element and have the clip path set to transition and then change the clip path to none it crashes the browser. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 10:11:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 10:11:35 -0700 Subject: [Webkit-unassigned] [Bug 119567] LayoutTests/canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html is against the spec In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119567 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 10:27:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 10:27:06 -0700 Subject: [Webkit-unassigned] [Bug 119581] New: URL query string mistakenly decoded when used in tag Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119581 Summary: URL query string mistakenly decoded when used in tag Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh OS/Version: Mac OS X 10.7 Status: UNCONFIRMED Severity: Blocker Priority: P2 Component: Page Loading AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cao.yiqun at gmail.com When the src URL of a tag contains a query string, it is decoded when sent to server. For example, create this simple HTML file: Serve this file via a web server, like `python -m SimpleHTTPServer 8001`. Visit `localhost:8001`. The server log shows the following: 1.0.0.127.in-addr.arpa - - [08/Aug/2013 10:24:20] "GET / HTTP/1.1" 200 - 1.0.0.127.in-addr.arpa - - [08/Aug/2013 10:24:20] "GET /a.js?a=%3D HTTP/1.1" 200 - 1.0.0.127.in-addr.arpa - - [08/Aug/2013 10:24:20] "GET /chart.png?a== HTTP/1.1" 200 - Notice that the JavaScript URL was not decoded, which is the correct behavior, but the URL for the tag was mistakenly decoded from `chart.png?a=%3D` to `chart.png?a==`. This is causing dynamically generated image resource to fail. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 10:34:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 10:34:29 -0700 Subject: [Webkit-unassigned] [Bug 119581] URL query string mistakenly decoded when used in tag In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119581 Eddie C changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cao.yiqun at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 10:41:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 10:41:23 -0700 Subject: [Webkit-unassigned] [Bug 116125] pathSuitableForTestResult returns duplicate path In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116125 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #16 from Alexey Proskuryakov 2013-08-08 10:41:02 PST --- Committed with minor tweaks in . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 10:50:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 10:50:29 -0700 Subject: [Webkit-unassigned] [Bug 114550] [GTK] Unable to build with --disable-webgl. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114550 Ragner Magalhaes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ragner.magalhaes at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 10:53:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 10:53:32 -0700 Subject: [Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=103771 --- Comment #110 from Brendan Long 2013-08-08 10:53:09 PST --- I have the following problems with the tests: * I can't use counting-captioned.mov, because GStreamer doesn't see the caption stream, and even if it did, it would get the kind wrong (since there's no way to tell the difference between captions and subtitles). * I can't use counting-subtitled.m4v, because Apple's tests expect that file to have "forced" subtitles, and there's no way to detect that in GStreamer either, even if we wanted to support it (which I think is outside the scope of this patch -- I really want to get the minimal version working before adding more). I think I can fix this by creating a new counting-subtitled-no-forced.m4v file (is there any free software I can use to verify that my new file's subtitles aren't forced?). Is that the best way of handling this? It's kind of frustrating that none of the existing tests work because we need particular "kinds". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:06:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:06:43 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 --- Comment #60 from Carlos Garcia Campos 2013-08-08 11:06:21 PST --- (In reply to comment #59) > (From update of attachment 208349 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208349&action=review > > All changes have been applied - Carlos could you take a last look if they're ok and cq+? > > > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:1428 > > + if (authorization && !strcmp(authorization, authExpectedAuthorization)) { > > I tried g_strcmp0, but since authExpectedAuthorization is never NULL it always returns true and never gets through to sending a challenge. g_strcmp0 doesn't return TRUE/False, but -1, 0, 1. It handles NULL by considering it lower than non NULL strings, but it will only return 0 if both are NULL or non-NULL and equal. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:12:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:12:26 -0700 Subject: [Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=103771 --- Comment #111 from Eric Carlson 2013-08-08 11:12:03 PST --- (In reply to comment #110) > I have the following problems with the tests: > > * I can't use counting-captioned.mov, because GStreamer doesn't see the caption stream, and even if it did, it would get the kind wrong (since there's no way to tell the difference between captions and subtitles). > > * I can't use counting-subtitled.m4v, because Apple's tests expect that file to have "forced" subtitles, and there's no way to detect that in GStreamer either, even if we wanted to support it (which I think is outside the scope of this patch -- I really want to get the minimal version working before adding more). > It sounds like GStreamer doesn't (yet) support CEA-608 tracks in .mov files. If it only supports subtitle tracks, can't you assume that all in-band tracks are kind=subtitle? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:14:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:14:52 -0700 Subject: [Webkit-unassigned] [Bug 119582] New: Crash due to DFG in jslinux Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119582 Summary: Crash due to DFG in jslinux Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified URL: http://bellard.org/jslinux/ OS/Version: Unspecified Status: NEW Keywords: NeedsRadar Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: oliver at apple.com CC: fpizlo at apple.com jslinux crashes, occasionally during boot, but consistently when running gcc 1. JSC_enableConcurrentJIT=0 JSC_maximumInliningDepth=1 JSC_bytecodeRangeToDFGCompile=435:445 run-minibrowser 2. Go to http://bellard.org/jslinux/ 3. Wait for linux to boot 4. type gcc hello.c This results in a crash in release build, and the following assertion failure: ASSERTION FAILED: to.isSet() /Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore/assembler/X86Assembler.h(1862) : void JSC::X86Assembler::linkJump(JSC::AssemblerLabel, JSC::AssemblerLabel) 1 0x1047b76a0 WTFCrash 2 0x10436cefc JSC::X86Assembler::linkJump(JSC::AssemblerLabel, JSC::AssemblerLabel) 3 0x1044223a9 JSC::AbstractMacroAssembler::Jump::linkTo(JSC::AbstractMacroAssembler::Label, JSC::AbstractMacroAssembler*) const 4 0x10447111c JSC::DFG::SpeculativeJIT::linkBranches() 5 0x10447105f JSC::DFG::SpeculativeJIT::compile() 6 0x10441d214 JSC::DFG::JITCompiler::compileBody() 7 0x10441f3b4 JSC::DFG::JITCompiler::compileFunction() 8 0x10445534b JSC::DFG::Plan::compileInThreadImpl(JSC::DFG::LongLivedState&) 9 0x104454d26 JSC::DFG::Plan::compileInThread(JSC::DFG::LongLivedState&) 10 0x1043f7b4d JSC::DFG::compile(JSC::DFG::CompileMode, JSC::ExecState*, JSC::CodeBlock*, WTF::RefPtr&, JSC::MacroAssemblerCodePtr*, unsigned int) 11 0x1043f7bcc JSC::DFG::tryCompileFunction(JSC::ExecState*, JSC::CodeBlock*, WTF::RefPtr&, JSC::MacroAssemblerCodePtr&, unsigned int) 12 0x10450dfa5 JSC::jitCompileFunctionIfAppropriateImpl(JSC::ExecState*, JSC::FunctionCodeBlock*, WTF::RefPtr&, JSC::MacroAssemblerCodePtr&, JSC::JITCode::JITType, unsigned int, JSC::JITCompilationEffort) 13 0x10450debe JSC::prepareFunctionForExecutionImpl(JSC::ExecState*, JSC::FunctionCodeBlock*, WTF::RefPtr&, JSC::MacroAssemblerCodePtr&, JSC::JITCode::JITType, unsigned int, JSC::CodeSpecializationKind) 14 0x1045098b9 JSC::prepareFunctionForExecution(JSC::ExecState*, WTF::RefPtr&, JSC::FunctionCodeBlock*, WTF::RefPtr&, JSC::MacroAssemblerCodePtr&, int&, JSC::JITCode::JITType, unsigned int, JSC::CodeSpecializationKind) 15 0x104506afc JSC::FunctionExecutable::compileForCallInternal(JSC::ExecState*, JSC::JSScope*, JSC::JITCode::JITType, JSC::CompilationResult*, unsigned int) 16 0x10450689c JSC::FunctionExecutable::compileOptimizedForCall(JSC::ExecState*, JSC::JSScope*, JSC::CompilationResult&, unsigned int) 17 0x1042ff4e4 JSC::FunctionExecutable::compileOptimizedFor(JSC::ExecState*, JSC::JSScope*, JSC::CompilationResult&, unsigned int, JSC::CodeSpecializationKind) 18 0x1042f5353 JSC::FunctionCodeBlock::compileOptimized(JSC::ExecState*, JSC::JSScope*, JSC::CompilationResult&, unsigned int) 19 0x1045706e4 cti_optimize 20 0x1045767c0 jscGeneratedNativeCode 21 0x104552207 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) 22 0x104535bd2 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 23 0x1042e2ede JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 24 0x10459da39 JSC::boundFunctionCall(JSC::ExecState*) 25 0x104535c08 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 26 0x1042e2ede JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 27 0x105f6796b WebCore::JSMainThreadExecState::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 28 0x106a28d41 WebCore::ScheduledAction::executeFunctionInContext(JSC::JSGlobalObject*, JSC::JSValue, WebCore::ScriptExecutionContext*) 29 0x106a28932 WebCore::ScheduledAction::execute(WebCore::Document*) 30 0x106a28794 WebCore::ScheduledAction::execute(WebCore::ScriptExecutionContext*) 31 0x10597531e WebCore::DOMTimer::fired() -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:15:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:15:10 -0700 Subject: [Webkit-unassigned] [Bug 119582] Crash due to DFG in jslinux In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119582 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:18:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:18:33 -0700 Subject: [Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=103771 --- Comment #112 from Brendan Long 2013-08-08 11:18:10 PST --- (In reply to comment #111) > It sounds like GStreamer doesn't (yet) support CEA-608 tracks in .mov files. If it only supports subtitle tracks, can't you assume that all in-band tracks are kind=subtitle? Yes, that's what the patch does now (since it never gets a kind, it defaults to "subtitles"). The problem is that the counting-subtitled.m4v file also has "forced" subtitles, which we currently have no way of detecting, so both the -captioned.mov and -subtitled.m4v files cause problems with testing for GStreamer. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:19:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:19:03 -0700 Subject: [Webkit-unassigned] [Bug 119583] New: [Win] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119583 Summary: [Win] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ap at webkit.org CC: bfulgham at webkit.org, roger_fong at apple.com urlSuitableForTestResult() in DumpRenderTree/win/DumpRenderTree.cpp removes a prefix from url without checking whether the url actually has this prefix: -------------------------- RetainPtr basePath = adoptCF(CFURLCopyPath(baseURL.get())); RetainPtr path = adoptCF(CFURLCopyPath(url.get())); return cfStringRefToWString(substringFromIndex(path.get(), CFStringGetLength(basePath.get())).get()); -------------------------- When it doesn't match - or when base URL cannot be determined - we should print last path component. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:26:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:26:11 -0700 Subject: [Webkit-unassigned] [Bug 119584] New: [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119584 Summary: [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ap at webkit.org Gtk DumpRenderTree has a function named pathFromSoupURI() that's meant to print file paths without exposing full local paths, which are machine specific. It needs to match other platforms, however there are some incompatibilities: - what should be printed is a URL relative to main frame URL, or just a file name if the resource is in a different directory; - instead of a check for file URLs, there is a negative check for http and ftp ones. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:31:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:31:01 -0700 Subject: [Webkit-unassigned] [Bug 119585] New: [EFL] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119585 Summary: [EFL] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ap at webkit.org pathSuitableForTestResult() in DumpRenderTreeChrome has some code that doesn't match other platforms. If should return a path that's relative to main frame URL, or just the file name if the resource is not in the same directory subtree. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:36:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:36:16 -0700 Subject: [Webkit-unassigned] [Bug 90708] fullscreen/exit-full-screen-iframe.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=90708 Eric Carlson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME CC| |eric.carlson at apple.com --- Comment #7 from Eric Carlson 2013-08-08 11:35:55 PST --- (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Note that this test causes EFL and GTK ports to crash > > > > GTK port crash is now fixed (bug 90719) and this test passes on GTK (see http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/ ). > > EFL is also fixed in trunk. This test passes on the Mac port as well: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r153825%20(11521)/results.html Un-skipped in https://trac.webkit.org/r153834 . Marking bug as RESOLVED/WORKSFORME. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:40:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:40:55 -0700 Subject: [Webkit-unassigned] [Bug 99096] REGRESSION(r130839): fast/canvas/webgl/arraybuffer-transfer-of-control.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99096 Eric Carlson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME CC| |eric.carlson at apple.com --- Comment #4 from Eric Carlson 2013-08-08 11:40:34 PST --- This appears to have been fixed: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r153825%20(11521)/results.html Unskipped test in https://trac.webkit.org/r153836 . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:41:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:41:35 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Bug 116980 depends on bug 118839, which changed state. Bug 118839 Summary: Crash in WTF::RefPtr::operator UnspecifiedBoolType https://bugs.webkit.org/show_bug.cgi?id=118839 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 11:47:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 11:47:41 -0700 Subject: [Webkit-unassigned] [Bug 82747] fast/events/scroll-div-with-prevent-default-in-subframe.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=82747 Eric Carlson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME CC| |eric.carlson at apple.com --- Comment #3 from Eric Carlson 2013-08-08 11:47:21 PST --- This now passes: http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r153830%20(12022)/results.html Unskipped test in : https://trac.webkit.org/r153837 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 12:13:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 12:13:40 -0700 Subject: [Webkit-unassigned] [Bug 119562] WebGL on AppleWin port needs GraphicsContext3D In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119562 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208314|review? |review+ Flag| | --- Comment #2 from Brent Fulgham 2013-08-08 12:13:19 PST --- (From update of attachment 208314) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 12:46:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 12:46:10 -0700 Subject: [Webkit-unassigned] [Bug 119591] New: [Qt] URL printing code in DumpRenderTreeQt doesn't match WTR or Mac DRT Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119591 Summary: [Qt] URL printing code in DumpRenderTreeQt doesn't match WTR or Mac DRT Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ap at webkit.org urlSuitableForTestResult() in DumpRenderTreeQt.cpp doesn't match what other platforms are doing. It just returns file name, while on other platforms, we build a path relative to test URL, and only resort to file name if that's not possible. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 12:48:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 12:48:37 -0700 Subject: [Webkit-unassigned] [Bug 104104] Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104104 Eric Carlson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.carlson at apple.com --- Comment #5 from Eric Carlson 2013-08-08 12:48:16 PST --- This no longer fails on the Mac bots: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r153825%20(11521)/results.html Un-skipped in https://trac.webkit.org/r153841. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 12:53:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 12:53:10 -0700 Subject: [Webkit-unassigned] [Bug 82980] http/tests/navigation/back-twice-without-commit.html is flaky In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=82980 Eric Carlson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME CC| |eric.carlson at apple.com --- Comment #2 from Eric Carlson 2013-08-08 12:52:49 PST --- This now passes on the Mac bots: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r153825%20(11521)/results.html Test un-skipped in https://trac.webkit.org/r153842. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 12:54:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 12:54:43 -0700 Subject: [Webkit-unassigned] [Bug 116491] [WK2] loader/go-back-cached-main-resource.html fails In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116491 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REGRESSION(r150386): [WK2] |[WK2] |loader/go-back-cached-main- |loader/go-back-cached-main- |resource.html fails |resource.html fails -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 13:04:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 13:04:35 -0700 Subject: [Webkit-unassigned] [Bug 116491] [WK2] loader/go-back-cached-main-resource.html fails In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116491 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |ap at webkit.org |kit.org | Attachment #208364| |review? Flag| | --- Comment #6 from Alexey Proskuryakov 2013-08-08 13:04:13 PST --- Created an attachment (id=208364) --> (https://bugs.webkit.org/attachment.cgi?id=208364&action=review) proposed fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 13:18:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 13:18:56 -0700 Subject: [Webkit-unassigned] [Bug 119562] WebGL on AppleWin port needs GraphicsContext3D In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119562 Alex Christensen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from Alex Christensen 2013-08-08 13:18:36 PST --- r153843 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 13:22:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 13:22:06 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 Benjamin Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208335|review? |review-, commit-queue- Flag| | --- Comment #12 from Benjamin Poulain 2013-08-08 13:21:45 PST --- (From update of attachment 208335) View in context: https://bugs.webkit.org/attachment.cgi?id=208335&action=review > Source/WTF/wtf/Platform.h:1061 > +#if PLATFORM(EFL) > +#define HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP 0 > +#endif > + This is not okay. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 13:50:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 13:50:02 -0700 Subject: [Webkit-unassigned] [Bug 119592] New: [Qt] WebKit crashes when using @font-face if "Helvetica" isn't available Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119592 Summary: [Qt] WebKit crashes when using @font-face if "Helvetica" isn't available Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Text AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: b.long at cablelabs.com Created an attachment (id=208366) --> (https://bugs.webkit.org/attachment.cgi?id=208366&action=review) Page demonstrating the crash If you go to the attached page using QtTestBrowser, and you don't have Helvetica, or a font providing Helvetica installed, then the browser crashes immediately. As a workaround, I can install msttcorefonts, which contains Arial, which provides Helvetica. The problem appears to be this section of CSSFontFaceSource.cpp: SimpleFontData* temporaryFont = fontCache()->getNonRetainedLastResortFallbackFont(fontDescription); fontData = SimpleFontData::create(temporaryFont->platformData(), true, true); If Helvetica isn't available, `temporaryFont` is null, and `temporaryFont->platformData()` crashes. Backtrace: #0 0x00007ffff5229cf8 in WTF::RefPtr::RefPtr (this=0x14081a0, o=...) at /home/blong/workspace/webkit/Source/WTF/wtf/RefPtr.h:44 #1 0x00007ffff5228125 in WebCore::FontPlatformData::FontPlatformData (this=0x14081a0) at /home/blong/workspace/webkit/Source/WebCore/platform/graphics/qt/FontPlatformData.h:80 #2 0x00007ffff526f73f in WebCore::SimpleFontData::SimpleFontData (this=0x1408160, platformData=..., isCustomFont=true, isLoading=true, isTextOrientationFallback=false) at /home/blong/workspace/webkit/Source/WebCore/platform/graphics/SimpleFontData.cpp:60 #3 0x00007ffff4b2f75e in WebCore::SimpleFontData::create (platformData=..., isCustomFont=true, isLoading=true, isTextOrientationFallback=false) at /home/blong/workspace/webkit/Source/WebCore/platform/graphics/SimpleFontData.h:88 #4 0x00007ffff4b303d8 in WebCore::CSSFontFaceSource::getFontData (this=0x10922b0, fontDescription=..., syntheticBold=false, syntheticItalic=false, fontSelector=0xa66150) at /home/blong/workspace/webkit/Source/WebCore/css/CSSFontFaceSource.cpp:185 #5 0x00007ffff4b18599 in WebCore::CSSFontFace::getFontData (this=0x1058d30, fontDescription=..., syntheticBold=false, syntheticItalic=false) at /home/blong/workspace/webkit/Source/WebCore/css/CSSFontFace.cpp:127 #6 0x00007ffff4bad2cf in WebCore::CSSSegmentedFontFace::getFontData (this=0x13a5460, fontDescription=...) at /home/blong/workspace/webkit/Source/WebCore/css/CSSSegmentedFontFace.cpp:141 #7 0x00007ffff4b2263b in WebCore::CSSFontSelector::getFontData (this=0xa66150, fontDescription=..., familyName=...) at /home/blong/workspace/webkit/Source/WebCore/css/CSSFontSelector.cpp:504 #8 0x00007ffff52291d8 in WebCore::FontCache::getFontData (this=0x961170, description=..., familyIndex=@0x108ff7c: 0, fontSelector=0xa66150) at /home/blong/workspace/webkit/Source/WebCore/platform/graphics/FontCache.cpp:469 #9 0x00007ffff520c04d in WebCore::FontGlyphs::realizeFontDataAt (this=0x108fec0, description=..., realizedFontIndex=0) at /home/blong/workspace/webkit/Source/WebCore/platform/graphics/FontGlyphs.cpp:110 #10 0x00007ffff4f12410 in WebCore::FontGlyphs::primaryFontData (this=0x108fec0, description=...) at /home/blong/workspace/webkit/Source/WebCore/platform/graphics/FontGlyphs.h:89 #11 0x00007ffff4f12472 in WebCore::FontGlyphs::primarySimpleFontData (this=0x108fec0, description=...) at /home/blong/workspace/webkit/Source/WebCore/platform/graphics/FontGlyphs.h:123 #12 0x00007ffff4f12556 in WebCore::Font::primaryFont (this=0x10693b8) at /home/blong/workspace/webkit/Source/WebCore/platform/graphics/Font.h:326 #13 0x00007ffff4f124be in WebCore::Font::fontMetrics (this=0x10693b8) at /home/blong/workspace/webkit/Source/WebCore/platform/graphics/Font.h:143 #14 0x00007ffff555d216 in WebCore::RenderStyle::fontMetrics (this=0x12a0590) at /home/blong/workspace/webkit/Source/WebCore/rendering/style/RenderStyle.cpp:1331 #15 0x00007ffff555d502 in WebCore::RenderStyle::computedLineHeight (this=0x12a0590, renderView=0xa62ad8) at /home/blong/workspace/webkit/Source/WebCore/rendering/style/RenderStyle.cpp:1372 #16 0x00007ffff5381e90 in WebCore::RenderBlock::lineHeight (this=0x12bcd18, firstLine=true, direction=WebCore::HorizontalLine, linePositionMode=WebCore::PositionOfInteriorLineBoxes) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:6550 #17 0x00007ffff53aa1ff in WebCore::logicalHeightForLine (block=0x12bcd18, isFirstLine=true, replacedHeight=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlockLineLayout.cpp:76 #18 0x00007ffff53aa6e1 in WebCore::LineWidth::updateAvailableWidth (this=0x7fffffff7ba0, replacedHeight=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlockLineLayout.cpp:177 #19 0x00007ffff53aa44b in WebCore::LineWidth::LineWidth (this=0x7fffffff7ba0, block=0x12bcd18, isFirstLine=true, shouldIndentText=WebCore::IndentText) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlockLineLayout.cpp:121 #20 0x00007ffff53b76bf in WebCore::RenderBlock::LineBreaker::nextSegmentBreak (this=0x7fffffff9290, resolver=..., lineInfo=..., renderTextInfo=..., lastFloatFromPreviousLine=0x0, consecutiveHyphenatedLines=0, wordMeasurements=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlockLineLayout.cpp:2926 #21 0x00007ffff53b6de3 in WebCore::RenderBlock::LineBreaker::nextLineBreak (this=0x7fffffff9290, resolver=..., lineInfo=..., renderTextInfo=..., lastFloatFromPreviousLine=0x0, consecutiveHyphenatedLines=0, wordMeasurements=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlockLineLayout.cpp:2815 #22 0x00007ffff53b1974 in WebCore::RenderBlock::layoutRunsAndFloatsInRange (this=0x12bcd18, layoutState=..., resolver=..., cleanLineStart=..., cleanLineBidiStatus=..., consecutiveHyphenatedLines=0) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1845 #23 0x00007ffff53b037b in WebCore::RenderBlock::layoutRunsAndFloats (this=0x12bcd18, layoutState=..., hasInlineChild=true) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1614 #24 0x00007ffff53b3ac4 in WebCore::RenderBlock::layoutInlineChildren (this=0x12bcd18, relayoutChildren=true, repaintLogicalTop=..., repaintLogicalBottom=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlockLineLayout.cpp:2189 #25 0x00007ffff5366eec in WebCore::RenderBlock::layoutBlock (this=0x12bcd18, relayoutChildren=true, pageLogicalHeight=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:1656 #26 0x00007ffff5366355 in WebCore::RenderBlock::layout (this=0x12bcd18) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:1428 #27 0x00007ffff536bae1 in WebCore::RenderBlock::layoutBlockChild (this=0x129e1c8, child=0x12bcd18, marginInfo=..., previousFloatLogicalBottom=..., maxFloatLogicalBottom=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:2669 #28 0x00007ffff536b6ba in WebCore::RenderBlock::layoutBlockChildren (this=0x129e1c8, relayoutChildren=true, maxFloatLogicalBottom=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:2604 #29 0x00007ffff5366f0d in WebCore::RenderBlock::layoutBlock (this=0x129e1c8, relayoutChildren=true, pageLogicalHeight=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:1658 #30 0x00007ffff5366355 in WebCore::RenderBlock::layout (this=0x129e1c8) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:1428 #31 0x00007ffff53319b1 in WebCore::RenderObject::layoutIfNeeded (this=0x129e1c8) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderObject.h:704 #32 0x00007ffff536cd2a in WebCore::RenderBlock::layoutPositionedObjects (this=0x112c928, relayoutChildren=true, fixedPositionObjectsOnly=false) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:2920 #33 0x00007ffff5367313 in WebCore::RenderBlock::layoutBlock (this=0x112c928, relayoutChildren=true, pageLogicalHeight=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:1696 #34 0x00007ffff5366355 in WebCore::RenderBlock::layout (this=0x112c928) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:1428 #35 0x00007ffff53319b1 in WebCore::RenderObject::layoutIfNeeded (this=0x112c928) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderObject.h:704 #36 0x00007ffff536cd2a in WebCore::RenderBlock::layoutPositionedObjects (this=0x11f4d18, relayoutChildren=true, fixedPositionObjectsOnly=false) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:2920 #37 0x00007ffff5367313 in WebCore::RenderBlock::layoutBlock (this=0x11f4d18, relayoutChildren=true, pageLogicalHeight=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:1696 #38 0x00007ffff5366355 in WebCore::RenderBlock::layout (this=0x11f4d18) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:1428 #39 0x00007ffff53319b1 in WebCore::RenderObject::layoutIfNeeded (this=0x11f4d18) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderObject.h:704 #40 0x00007ffff536cd2a in WebCore::RenderBlock::layoutPositionedObjects (this=0xa62ad8, relayoutChildren=false, fixedPositionObjectsOnly=false) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:2920 #41 0x00007ffff5367313 in WebCore::RenderBlock::layoutBlock (this=0xa62ad8, relayoutChildren=false, pageLogicalHeight=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:1696 #42 0x00007ffff5366355 in WebCore::RenderBlock::layout (this=0xa62ad8) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderBlock.cpp:1428 #43 0x00007ffff5524523 in WebCore::RenderView::layoutContent (this=0xa62ad8, state=...) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderView.cpp:142 #44 0x00007ffff5525245 in WebCore::RenderView::layout (this=0xa62ad8) at /home/blong/workspace/webkit/Source/WebCore/rendering/RenderView.cpp:327 #45 0x00007ffff51ac42a in WebCore::FrameView::layout (this=0xaaa1e0, allowSubtree=true) at /home/blong/workspace/webkit/Source/WebCore/page/FrameView.cpp:1327 #46 0x00007ffff51b0543 in WebCore::FrameView::layoutTimerFired (this=0xaaa1e0) at /home/blong/workspace/webkit/Source/WebCore/page/FrameView.cpp:2410 #47 0x00007ffff51be02e in WebCore::Timer::fired (this=0xaaa318) at /home/blong/workspace/webkit/Source/WebCore/platform/Timer.h:114 #48 0x00007ffff52fcc8d in WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x9809e0) at /home/blong/workspace/webkit/Source/WebCore/platform/ThreadTimers.cpp:129 #49 0x00007ffff52fcba1 in WebCore::ThreadTimers::sharedTimerFired () at /home/blong/workspace/webkit/Source/WebCore/platform/ThreadTimers.cpp:105 #50 0x00007ffff560bd2a in WebCore::SharedTimerQt::timerEvent (this=0x980e30, ev=0x7fffffffba00) at /home/blong/workspace/webkit/Source/WebCore/platform/qt/SharedTimerQt.cpp:113 #51 0x00007ffff136229c in QObject::event (this=0x980e30, e=0x7fffffffba00) at kernel/qobject.cpp:1051 #52 0x00007ffff1eb062a in QApplicationPrivate::notify_helper (this=0x64b700, receiver=0x980e30, e=0x7fffffffba00) at kernel/qapplication.cpp:3442 #53 0x00007ffff1eadcbe in QApplication::notify (this=0x7fffffffbeb0, receiver=0x980e30, e=0x7fffffffba00) at kernel/qapplication.cpp:2845 #54 0x00007ffff1328318 in QCoreApplication::notifyInternal (this=0x7fffffffbeb0, receiver=0x980e30, event=0x7fffffffba00) at kernel/qcoreapplication.cpp:871 #55 0x00007ffff132bf95 in QCoreApplication::sendEvent (receiver=0x980e30, event=0x7fffffffba00) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:232 #56 0x00007ffff13983d8 in QTimerInfoList::activateTimers (this=0x656060) at kernel/qtimerinfo_unix.cpp:643 #57 0x00007ffff1399579 in timerSourceDispatch (source=0x656000) at kernel/qeventdispatcher_glib.cpp:185 #58 0x00007fffebfd0d53 in g_main_dispatch (context=0x654e00) at /build/buildd/glib2.0-2.32.3/./glib/gmain.c:2539 #59 g_main_context_dispatch (context=0x654e00) at /build/buildd/glib2.0-2.32.3/./glib/gmain.c:3075 #60 0x00007fffebfd10a0 in g_main_context_iterate (dispatch=1, block=, context=0x654e00, self=) at /build/buildd/glib2.0-2.32.3/./glib/gmain.c:3146 #61 g_main_context_iterate (context=0x654e00, block=, dispatch=1, self=) at /build/buildd/glib2.0-2.32.3/./glib/gmain.c:3083 #62 0x00007fffebfd1164 in g_main_context_iteration (context=0x654e00, may_block=1) at /build/buildd/glib2.0-2.32.3/./glib/gmain.c:3207 #63 0x00007ffff1399f3b in QEventDispatcherGlib::processEvents (this=0x64e4f0, flags=...) at kernel/qeventdispatcher_glib.cpp:426 #64 0x00007fffe6d170f2 in QPAEventDispatcherGlib::processEvents (this=0x64e4f0, flags=...) at eventdispatchers/qeventdispatcher_glib.cpp:123 #65 0x00007ffff1324ed8 in QEventLoop::processEvents (this=0x7fffffffbd50, flags=...) at kernel/qeventloop.cpp:136 #66 0x00007ffff13251b1 in QEventLoop::exec (this=0x7fffffffbd50, flags=...) at kernel/qeventloop.cpp:212 #67 0x00007ffff13289d0 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:1124 #68 0x00007ffff1704d48 in QGuiApplication::exec () at kernel/qguiapplication.cpp:1198 #69 0x00007ffff1ead7f1 in QApplication::exec () at kernel/qapplication.cpp:2689 #70 0x000000000042708e in launcherMain (app=...) at /home/blong/workspace/webkit/Tools/QtTestBrowser/qttestbrowser.cpp:50 #71 0x0000000000428dd5 in main (argc=2, argv=0x7fffffffc0f8) at /home/blong/workspace/webkit/Tools/QtTestBrowser/qttestbrowser.cpp:319 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 14:00:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 14:00:30 -0700 Subject: [Webkit-unassigned] [Bug 82747] fast/events/scroll-div-with-prevent-default-in-subframe.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=82747 --- Comment #4 from Eric Carlson 2013-08-08 14:00:09 PST --- Sigh, it is now flakey not fixed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 14:02:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 14:02:40 -0700 Subject: [Webkit-unassigned] [Bug 113224] ASSERT_NOT_REACHED() touched in WebCore::SVGAnimatedStringAnimator::addAnimatedTypes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113224 Rob Buis changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rwlbuis at gmail.com |kit.org | CC| |rwlbuis at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 14:05:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 14:05:03 -0700 Subject: [Webkit-unassigned] [Bug 9248] Quirksmode: document.documentElement.scrollTop is always In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=9248 Syoichi Tsuyuhara changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |syoichi at outlook.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 14:05:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 14:05:26 -0700 Subject: [Webkit-unassigned] [Bug 9610] Quirksmode meta bug In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=9610 Syoichi Tsuyuhara changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |syoichi at outlook.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 14:05:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 14:05:34 -0700 Subject: [Webkit-unassigned] [Bug 82747] fast/events/scroll-div-with-prevent-default-in-subframe.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=82747 Eric Carlson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME | --- Comment #5 from Eric Carlson 2013-08-08 14:05:13 PST --- Marked as flakey in https://trac.webkit.org/r153844. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 14:16:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 14:16:51 -0700 Subject: [Webkit-unassigned] [Bug 90708] fullscreen/exit-full-screen-iframe.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=90708 Eric Carlson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME | --- Comment #8 from Eric Carlson 2013-08-08 14:16:29 PST --- (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > Note that this test causes EFL and GTK ports to crash > > > > > > GTK port crash is now fixed (bug 90719) and this test passes on GTK (see http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/ ). > > > > EFL is also fixed in trunk. > > This test passes on the Mac port as well: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r153825%20(11521)/results.html > > Un-skipped in https://trac.webkit.org/r153834 . > > Marking bug as RESOLVED/WORKSFORME. Actually the test is flakey on both Mac and EFL ports. Marked as flakey on Mac in https://trac.webkit.org/r153846. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 14:30:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 14:30:54 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Bug 116980 depends on bug 113224, which changed state. Bug 113224 Summary: ASSERT_NOT_REACHED() touched in WebCore::SVGAnimatedStringAnimator::addAnimatedTypes https://bugs.webkit.org/show_bug.cgi?id=113224 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 15:01:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 15:01:01 -0700 Subject: [Webkit-unassigned] [Bug 99266] ASSERTION FAILED: !lookupForWriting(Extractor::extract(entry)).second : void WTF::HashTable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99266 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE CC| |sam at webkit.org --- Comment #6 from Sam Weinig 2013-08-08 15:00:39 PST --- *** This bug has been marked as a duplicate of bug 119533 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 15:13:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 15:13:14 -0700 Subject: [Webkit-unassigned] [Bug 119599] New: Layout tests use WebKitUsesPageCachePreferenceKey instead of WebKitUsesPageCache Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119599 Summary: Layout tests use WebKitUsesPageCachePreferenceKey instead of WebKitUsesPageCache Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: thorton at apple.com CC: sam at webkit.org, beidson at apple.com, simon.fraser at apple.com If you look at e.g. FOR_EACH_OVERRIDE_BOOL_PREFERENCE, we use WebKitUsesPageCache*PreferenceKey* as the name instead of "WebKitUsesPageCache" like all the other preferences. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 15:13:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 15:13:52 -0700 Subject: [Webkit-unassigned] [Bug 119599] Layout tests use WebKitUsesPageCachePreferenceKey instead of WebKitUsesPageCache In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119599 --- Comment #1 from Tim Horton 2013-08-08 15:13:22 PST --- And if you look at the tests, they do the same (this confused me because I copied a page cache pref setter and tried to use it for plugins, and wondered why it didn't work). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 15:19:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 15:19:21 -0700 Subject: [Webkit-unassigned] [Bug 119600] New: 64-bit ANGLE build can't find DirectX libraries Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119600 Summary: 64-bit ANGLE build can't find DirectX libraries Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows 7 Status: UNCONFIRMED Severity: Minor Priority: P3 Component: ANGLE AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: achristensen at apple.com CC: bfulgham at webkit.org The 64-bit build of ANGLE on Windows can't find the DirectX libraries. The DirectX installation has the 32-bit libraries in a folder called x86 and the 64-bit libraries in a folder called x64. I was using the $(PlatformShortName) macro in Visual Studio to link to these and it works fine with the 32-bit build, but with a 64-bit build it expands to AMD64, not x64. There is no macro that is x86 for a 32-bit build and x64 for a 64-bit build, so instead of making one, I'll just use two different property sheets to link the builds. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 15:20:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 15:20:18 -0700 Subject: [Webkit-unassigned] [Bug 119600] 64-bit ANGLE build can't find DirectX libraries In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119600 Alex Christensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208374| |review? Flag| | --- Comment #1 from Alex Christensen 2013-08-08 15:19:57 PST --- Created an attachment (id=208374) --> (https://bugs.webkit.org/attachment.cgi?id=208374&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 15:21:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 15:21:43 -0700 Subject: [Webkit-unassigned] [Bug 119600] 64-bit ANGLE build can't find DirectX libraries In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119600 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |dino at apple.com, | |kondapallykalyan at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 15:27:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 15:27:25 -0700 Subject: [Webkit-unassigned] [Bug 119601] New: Win64 missing ctiVMThrowTrampolineSlowpath Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119601 Summary: Win64 missing ctiVMThrowTrampolineSlowpath Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: achristensen at apple.com CC: msaboff at apple.com ctiVMThrowTrampolineSlowpath is not defined for the Win64 build of JavaScriptCore. Michael's fix is based on assembly from JITStubsX86_64.h that should be in JITStubsMSVC64.asm. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 15:29:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 15:29:49 -0700 Subject: [Webkit-unassigned] [Bug 119601] Win64 missing ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119601 Alex Christensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208375| |review? Flag| | --- Comment #1 from Alex Christensen 2013-08-08 15:29:28 PST --- Created an attachment (id=208375) --> (https://bugs.webkit.org/attachment.cgi?id=208375&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 15:33:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 15:33:31 -0700 Subject: [Webkit-unassigned] [Bug 113217] ASSERT(m_type == toSVGTransform.type()) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113217 Rob Buis changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rwlbuis at gmail.com |kit.org | CC| |rwlbuis at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 15:54:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 15:54:35 -0700 Subject: [Webkit-unassigned] [Bug 46427] Crash below CGContextShowGlyphsWithAdvances due to invalid viewBox In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=46427 Philip Rogers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW AssignedTo|pdr at google.com |webkit-unassigned at lists.web | |kit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 16:02:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 16:02:06 -0700 Subject: [Webkit-unassigned] [Bug 119601] Win64 missing ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119601 Alex Christensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208375|review? |review- Flag| | --- Comment #2 from Alex Christensen 2013-08-08 16:01:45 PST --- (From update of attachment 208375) Something is wrong with the calling convention. Something needs to be put on the stack, and I'm not even going to pretend to know exactly how to fix it. I'm going to leave this one to you, Michael. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 16:03:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 16:03:27 -0700 Subject: [Webkit-unassigned] [Bug 119604] New: Disable suppression of plugin process for Java Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119604 Summary: Disable suppression of plugin process for Java Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit2 AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: barraclough at apple.com Workaround, the Java plugin doesn't like this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 16:09:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 16:09:22 -0700 Subject: [Webkit-unassigned] [Bug 119600] 64-bit ANGLE build can't find DirectX libraries In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119600 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208374|review? |review+, commit-queue+ Flag| | --- Comment #2 from Brent Fulgham 2013-08-08 16:09:01 PST --- (From update of attachment 208374) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 16:15:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 16:15:45 -0700 Subject: [Webkit-unassigned] [Bug 119604] Disable suppression of plugin process for Java In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119604 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |barraclough at apple.com |kit.org | Attachment #208379| |review? Flag| | --- Comment #1 from Gavin Barraclough 2013-08-08 16:15:24 PST --- Created an attachment (id=208379) --> (https://bugs.webkit.org/attachment.cgi?id=208379&action=review) fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 16:23:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 16:23:28 -0700 Subject: [Webkit-unassigned] [Bug 119605] New: AX: Not able to use arrow keys to read text in a WK2 app Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119605 Summary: AX: Not able to use arrow keys to read text in a WK2 app Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Mac OS X 10.8 Status: NEW Keywords: InRadar Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: bdakin at apple.com CC: webkit-bug-importer at group.apple.com Arrow keys should be able to read text line-by-line in a WebView when running with VoiceOver. This feature is broken in WK2. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 16:23:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 16:23:33 -0700 Subject: [Webkit-unassigned] [Bug 119605] AX: Not able to use arrow keys to read text in a WK2 app In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119605 Beth Dakin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 16:28:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 16:28:59 -0700 Subject: [Webkit-unassigned] [Bug 119605] AX: Not able to use arrow keys to read text in a WK2 app In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119605 Beth Dakin changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |bdakin at apple.com |kit.org | Attachment #208380| |review? Flag| | --- Comment #1 from Beth Dakin 2013-08-08 16:28:37 PST --- Created an attachment (id=208380) --> (https://bugs.webkit.org/attachment.cgi?id=208380&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 17:30:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 17:30:33 -0700 Subject: [Webkit-unassigned] [Bug 3409] CSS1: Safari ignores "text-transform" attribute in "first-line" CSS rules In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=3409 Andrew Dunkman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adunkman at gmail.com --- Comment #20 from Andrew Dunkman 2013-08-08 17:30:10 PST --- Yep, just observed this today in Chrome 28.0.1500.95 (Official Build 213514). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 17:45:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 17:45:29 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Bug 116980 depends on bug 113224, which changed state. Bug 113224 Summary: ASSERT_NOT_REACHED() touched in WebCore::SVGAnimatedStringAnimator::addAnimatedTypes https://bugs.webkit.org/show_bug.cgi?id=113224 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution|FIXED | Status|RESOLVED |REOPENED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 19:11:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 19:11:11 -0700 Subject: [Webkit-unassigned] [Bug 119600] 64-bit ANGLE build can't find DirectX libraries In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119600 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208374|review+, commit-queue+ | Flag| | --- Comment #3 from WebKit Commit Bot 2013-08-08 19:10:50 PST --- (From update of attachment 208374) Clearing flags on attachment: 208374 Committed r153874: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 19:11:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 19:11:14 -0700 Subject: [Webkit-unassigned] [Bug 119600] 64-bit ANGLE build can't find DirectX libraries In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119600 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from WebKit Commit Bot 2013-08-08 19:10:53 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 19:20:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 19:20:24 -0700 Subject: [Webkit-unassigned] [Bug 119612] New: Minimized windows are un-minimized when links are clicked Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119612 Summary: Minimized windows are un-minimized when links are clicked Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh OS/Version: Mac OS X 10.8 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: bugzilla at bm5k.com If a minimized window exists, new requests to open links cause the window to be restored and a new tab created. This occurs even if there are other, unminimized windows open. I would expect a minimized window to NEVER be automatically restored, even if it is the only open window. This affects both the current stable release of safari Version 6.0.5 (8536.30.1) and the latest webkit nightly Version 6.0.5 (8536.30.1, 538+) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 19:50:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 19:50:06 -0700 Subject: [Webkit-unassigned] [Bug 118067] [GTK] Use the GCActivityCallback In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118067 Peng Xinchao changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208390| |review+, commit-queue+ Flag| | --- Comment #8 from Peng Xinchao 2013-08-08 19:49:44 PST --- Created an attachment (id=208390) --> (https://bugs.webkit.org/attachment.cgi?id=208390&action=review) accept these suggestiones of Sergio Villar Senin . accept these suggestiones of Sergio Villar Senin . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 20:01:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 20:01:27 -0700 Subject: [Webkit-unassigned] [Bug 118067] [GTK] Use the GCActivityCallback In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118067 --- Comment #9 from Peng Xinchao 2013-08-08 20:01:05 PST --- Created an attachment (id=208391) --> (https://bugs.webkit.org/attachment.cgi?id=208391&action=review) accept these suggestiones of Sergio Villar Senin . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 20:05:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 20:05:19 -0700 Subject: [Webkit-unassigned] [Bug 118067] [GTK] Use the GCActivityCallback In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118067 --- Comment #10 from Peng Xinchao 2013-08-08 20:04:58 PST --- (In reply to comment #7) > (From update of attachment 207176 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207176&action=review > > Apart from the inline comments, remember that you have to add a proper ChangeLog with the description of the changes (maybe this helps http://trac.webkit.org/wiki/CodeReview) > > > runtime/GCActivityCallback.h:72 > > + } > > You don't need this if you aren't doing anything different from the #else following this code. > > > runtime/GCActivityCallback.h:117 > > +#endif > > At least cancelTimer(), scheduleTimer() and m_delay are shared with the other ports. There should be a better way to write this. > > > runtime/GCActivityCallback.cpp:44 > > +#include > > Why gdk? > > > runtime/GCActivityCallback.cpp:87 > > +} > > Isn't this exactly the same as Qt? Couldn't we do "#elif PLATFORM(QT) || PLATFORM(GTK)" ? > > > runtime/GCActivityCallback.cpp:168 > > + > > Check the indentation and remove the extra lines at the end of the function. > > > runtime/GCActivityCallback.cpp:174 > > + stop(); > > Check indentation. Also the implementation is exactly the same as EFL, we might think about sharing it. > > > runtime/GCActivityCallback.cpp:179 > > + > > Extra line. > > > runtime/GCActivityCallback.cpp:181 > > + return; > > Indentation. > > > runtime/GCActivityCallback.cpp:202 > > + return; > > Indentation. Also any reason why we could not share EFL's code?. Actually, I don't know exactly about the details but looks like the EFL code might be shared among ports (not sure about the ASSERT though) > > > heap/HeapTimer.cpp:44 > > +#include > > Again why gdk? I motify codes ,but Why my new patch do not display normal? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 20:50:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 20:50:51 -0700 Subject: [Webkit-unassigned] [Bug 119613] New: move-by-word-visually-multi-space.html takes 21s and spends most of its time doing spelling and grammar checking Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119613 Summary: move-by-word-visually-multi-space.html takes 21s and spends most of its time doing spelling and grammar checking Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: HTML Editing AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.fraser at apple.com CC: rniwa at webkit.org, enrica at apple.com move-by-word-visually-multi-space.html is a very slow test: 21s on the bots. Sampling shows that it spends most of its time doing spell checking. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 20:53:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 20:53:08 -0700 Subject: [Webkit-unassigned] [Bug 119613] move-by-word-visually-multi-space.html takes 21s and spends most of its time doing spelling and grammar checking In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119613 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.fraser at apple.com --- Comment #1 from Simon Fraser (smfr) 2013-08-08 20:52:47 PST --- Doing internals.setContinuousSpellCheckingEnabled(false); takes the runtime down from 14s to 4s on my machine. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 20:58:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 20:58:58 -0700 Subject: [Webkit-unassigned] [Bug 119613] move-by-word-visually-multi-space.html takes 21s and spends most of its time doing spelling and grammar checking In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119613 --- Comment #2 from Ryosuke Niwa 2013-08-08 20:58:37 PST --- (In reply to comment #0) > move-by-word-visually-multi-space.html is a very slow test: 21s on the bots. > > Sampling shows that it spends most of its time doing spell checking. That's really bad because we should never be spellchecking content that wasn't entered by the user. Do you have any traces for this test? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 21:20:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 21:20:05 -0700 Subject: [Webkit-unassigned] [Bug 119613] move-by-word-visually-multi-space.html takes 21s and spends most of its time doing spelling and grammar checking In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119613 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |simon.fraser at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 21:51:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 21:51:46 -0700 Subject: [Webkit-unassigned] [Bug 119565] problems encountered with fast-malloc on illumos x86_64 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119565 --- Comment #2 from richard at NetBSD.org 2013-08-08 21:51:25 PST --- That seemed to do the trick. Now I only get : (process:311): GLib-GObject-CRITICAL **: g_object_class_install_property: assertion `class->set_property != NULL' failed Source/WebKit/gtk/webkit/webkitwebplugin.cpp:217: Warning: WebKit: webkit_web_plugin_get_mimetypes: Unknown type: 'WebKit.WebKitWebPluginMIMEType' Source/WebKit/gtk/webkit/webkitglobals.cpp:267: Warning: WebKit: webkit_get_text_checker: return value: Missing (transfer) annotation Source/WebKit/gtk/webkit/webkitwebframe.cpp:840: Warning: WebKit: webkit_web_frame_get_global_context: return value: Unresolved type: 'JSGlobalContextRef' Source/WebKit/gtk/webkit/webkitwebframe.cpp:1146: Warning: WebKit: webkit_web_frame_get_range_for_word_around_caret: return value: Missing (transfer) annotation Source/WebKit/gtk/webkit/webkitwebplugindatabase.h:51: Warning: WebKit: webkit_web_plugin_database_plugins_list_free: argument list: Missing (element-type) annotation GEN WebKit-1.0.typelib but the build seems successful. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 22:39:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 22:39:46 -0700 Subject: [Webkit-unassigned] [Bug 119513] [WebGL] compileShader map iterator validation In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119513 --- Comment #7 from Przemyslaw Szymanski 2013-08-08 22:39:24 PST --- (In reply to comment #6) > (From update of attachment 208172 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208172&action=review > > > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:467 > > + if (result == m_shaderSourceMap.end()) > > + return; > > what situation does the patch help? It avoids possibly bug/crash. Assume m_shaderSourceMap does not contain search object. Then result iterator will point to m_shaderSourceMap.end() and read from it should crash. Look in other methods with use of m_shaderSourceMap.find. There are that checks too. I think someone forgot about this check here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 22:46:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 22:46:34 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208122|0 |1 is obsolete| | Attachment #208122|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 22:46:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 22:46:43 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208396| |review? Flag| | --- Comment #10 from Andrei Parvu 2013-08-08 22:46:21 PST --- Created an attachment (id=208396) --> (https://bugs.webkit.org/attachment.cgi?id=208396&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 22:47:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 22:47:36 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 --- Comment #11 from Andrei Parvu 2013-08-08 22:47:14 PST --- (In reply to comment #10) > Created an attachment (id=208396) --> (https://bugs.webkit.org/attachment.cgi?id=208396&action=review) [details] > Patch Added some more comments to the change logs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 23:14:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 23:14:28 -0700 Subject: [Webkit-unassigned] [Bug 119614] New: Add -webkit-mask-type property, with alpha and luminance values Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 Summary: Add -webkit-mask-type property, with alpha and luminance values Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: parvu at adobe.com CC: WebkitBugTracker at adobe.com The CSS masking specification contains the mask-type property, which can have the value of alpha or luminance, thus creating two separate types of masks. This bug regards only the adding and parsing of the mask-type property - we do not yet apply different masks depending on the mask type. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 23:15:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 23:15:15 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking]Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add -webkit-mask-type |[CSS Masking]Add |property, with alpha and |-webkit-mask-type property, |luminance values |with alpha and luminance | |values -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 23:51:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 23:51:01 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207905|0 |1 is obsolete| | Attachment #207905|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 23:51:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 23:51:08 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208397| |review? Flag| | --- Comment #3 from Seokju Kwon 2013-08-08 23:50:47 PST --- Created an attachment (id=208397) --> (https://bugs.webkit.org/attachment.cgi?id=208397&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 8 23:52:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 8 Aug 2013 23:52:30 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rniwa at webkit.org --- Comment #4 from Seokju Kwon 2013-08-08 23:52:09 PST --- Sync with the latest code. CC'ing rniwa. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:01:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:01:30 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking]Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208398| |review? Flag| | --- Comment #1 from Andrei Parvu 2013-08-09 00:01:08 PST --- Created an attachment (id=208398) --> (https://bugs.webkit.org/attachment.cgi?id=208398&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:01:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:01:58 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking]Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krit at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:03:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:03:35 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 EFL EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eflews.bot at gmail.com, | |gyuyoung.kim at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:03:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:03:38 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 EFL EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208397| |commit-queue- Flag| | --- Comment #5 from EFL EWS Bot 2013-08-09 00:03:16 PST --- (From update of attachment 208397) Attachment 208397 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1359358 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:05:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:05:12 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking]Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexis at webkit.org, | |allan.jensen at digia.com, | |commit-queue at webkit.org, | |esprehn+autocc at chromium.org | |, glenn at skynav.com, | |kondapallykalyan at gmail.com, | |macpherson at chromium.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:05:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:05:56 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking]Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 --- Comment #2 from WebKit Commit Bot 2013-08-09 00:05:34 PST --- Attachment 208398 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/masking/parsing-mask-type-expected.txt', u'LayoutTests/fast/masking/parsing-mask-type.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSProperty.cpp', u'Source/WebCore/css/CSSPropertyNames.in', u'Source/WebCore/css/CSSToStyleMap.cpp', u'Source/WebCore/css/CSSToStyleMap.h', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/rendering/style/FillLayer.cpp', u'Source/WebCore/rendering/style/FillLayer.h', u'Source/WebCore/rendering/style/RenderStyleConstants.h', u'Source/WebCore/rendering/style/SVGRenderStyleDefs.h']" exit_code: 1 Source/WebCore/rendering/style/RenderStyleConstants.h:167: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:19:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:19:42 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 --- Comment #6 from Seokju Kwon 2013-08-09 00:19:20 PST --- It is not related to this patch.(In reply to comment #5) > (From update of attachment 208397 [details]) > Attachment 208397 [details] did not pass efl-wk2-ews (efl-wk2): > Output: http://webkit-queues.appspot.com/results/1359358 Not related to this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:31:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:31:35 -0700 Subject: [Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118445 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208130|0 |1 is obsolete| | Attachment #208130|review?, commit-queue? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:31:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:31:48 -0700 Subject: [Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118445 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208401| |review?, commit-queue? Flag| | --- Comment #39 from Arunprasad Rajkumar 2013-08-09 00:31:26 PST --- Created an attachment (id=208401) --> (https://bugs.webkit.org/attachment.cgi?id=208401&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:37:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:37:54 -0700 Subject: [Webkit-unassigned] [Bug 119324] [CSS Masking] -webkit-mask-repeat: space does not work In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119324 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208396|review? |review- Flag| | --- Comment #12 from Dirk Schulze 2013-08-09 00:37:32 PST --- (From update of attachment 208396) View in context: https://bugs.webkit.org/attachment.cgi?id=208396&action=review Great patch! I think we run into a misunderstanding on the use of Pattern. It would be great if this could be done outside of the platform dependent code, so that it works on all platforms. > Source/WebCore/platform/graphics/Pattern.h:63 > + static PassRefPtr create(); Hm, you create a Pattern without initial data? Don't you alraedy have access to the Image at that point? > Source/WebCore/platform/graphics/cg/ImageCG.cpp:126 > + matrix = CGAffineTransformTranslate(matrix, 0, size().height() - h); > + RefPtr patternPtr = Pattern::create(); > + RetainPtr pattern = adoptCF(patternPtr->createPlatformPattern(matrix, subImage.get(), tileRect, I thought more of using Pattern in the platform independent path. Here is does not make a lot of sense to wrap the Pattern class around the PlatformPattern. This can not be used by other ports either. I thought more in rendering code, where we initially call GraphicsContext background drawing routines. > Source/WebCore/platform/graphics/cg/ImageCG.cpp:143 > + CGRect r = CGContextGetClipBoundingBox(context); > + CGContextFillRect(context, r); Did you initialize the r for testing? You don't need to assign a new variable here. > Source/WebCore/platform/graphics/cg/PatternCG.cpp:90 > +CGPatternRef Pattern::createPlatformPattern(const AffineTransform& matrix, PlatformImagePtr patternImage, FloatRect tileRect, float xStep, float yStep) const You may want to pass a FloatSize instead of xStep and yStep. > Source/WebCore/rendering/RenderBoxModelObject.cpp:1323 > + geometry.setSpaceSize(FloatSize(0, 0)); just use FloatSize() > Source/WebCore/rendering/RenderBoxModelObject.cpp:1367 > + } else if (backgroundRepeatY == SpaceFill) { > + if (fillTileSize.height() > 0) { can you combine that a one condition in the else if ? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:38:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:38:26 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 --- Comment #7 from Christophe Dumez 2013-08-09 00:38:04 PST --- (From update of attachment 208397) View in context: https://bugs.webkit.org/attachment.cgi?id=208397&action=review > Tools/Scripts/webkitpy/tool/commands/queries.py:601 > + notPermitted_ids = set() not_permitted_ids -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:43:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:43:06 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208397|0 |1 is obsolete| | Attachment #208397|review?, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:43:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:43:13 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208402| |review? Flag| | --- Comment #8 from Seokju Kwon 2013-08-09 00:42:51 PST --- Created an attachment (id=208402) --> (https://bugs.webkit.org/attachment.cgi?id=208402&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:43:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:43:55 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 --- Comment #9 from Seokju Kwon 2013-08-09 00:43:33 PST --- (In reply to comment #7) > (From update of attachment 208397 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208397&action=review > > > Tools/Scripts/webkitpy/tool/commands/queries.py:601 > > + notPermitted_ids = set() > > not_permitted_ids @Christophe Dumez Fixed. Thanks :-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:50:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:50:41 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 --- Comment #10 from Christophe Dumez 2013-08-09 00:50:19 PST --- (From update of attachment 208402) View in context: https://bugs.webkit.org/attachment.cgi?id=208402&action=review > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:457 > + # Avoid authentication What if the caller of this script has access to these bugs? Doesn't it prevent him from authenticating? > Tools/Scripts/webkitpy/tool/commands/queries.py:601 > + not_Permitted_ids = set() without capital letters : not_permitted_ids. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:52:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:52:35 -0700 Subject: [Webkit-unassigned] [Bug 119382] Fix problem with find-resolved-bugs command In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119382 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dchris at gmail.com --- Comment #11 from Christophe Dumez 2013-08-09 00:52:13 PST --- (In reply to comment #10) > (From update of attachment 208402 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208402&action=review > > > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:457 > > + # Avoid authentication > > What if the caller of this script has access to these bugs? Doesn't it prevent him from authenticating? It might be better to just not abort when authentication fails, and ignore that bug instead. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 00:53:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 00:53:30 -0700 Subject: [Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118445 --- Comment #40 from Simon Hausmann 2013-08-09 00:53:07 PST --- (From update of attachment 208401) LGTM. Jocelyn, Allan, what do you think? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 01:04:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 01:04:51 -0700 Subject: [Webkit-unassigned] [Bug 119616] New: [Qt] Build fix (typo in WebCore/xml/parser/XMLDocumentParserQt.cpp) Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119616 Summary: [Qt] Build fix (typo in WebCore/xml/parser/XMLDocumentParserQt.cpp) Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jbrianceau at nds.com Changeset r153826 broke our sh4 build bot: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/28477 /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/WebCore/xml/parser/XMLDocumentParserQt.cpp: In constructor 'WebCore::XMLDocumentParser::XMLDocumentParser(WebCore::DocumentFragment*, WebCore::Element*, WebCore::ParserContentPolicy)': /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:159:49: error: base operand of '->' has non-pointer type 'const WebCore::Attribute' make[3]: *** [.obj/release-shared/xml/parser/XMLDocumentParserQt.o] Error 1 make[3]: *** Waiting for unfinished jobs.... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 01:12:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 01:12:45 -0700 Subject: [Webkit-unassigned] [Bug 119616] [Qt] Build fix (typo in WebCore/xml/parser/XMLDocumentParserQt.cpp) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119616 --- Comment #1 from Julien Brianceau 2013-08-09 01:12:24 PST --- Created an attachment (id=208403) --> (https://bugs.webkit.org/attachment.cgi?id=208403&action=review) Build fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 01:13:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 01:13:43 -0700 Subject: [Webkit-unassigned] [Bug 119616] [Qt] Build fix (typo in WebCore/xml/parser/XMLDocumentParserQt.cpp) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119616 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208403| |review?, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 01:15:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 01:15:31 -0700 Subject: [Webkit-unassigned] [Bug 119616] [Qt] Build fix (typo in WebCore/xml/parser/XMLDocumentParserQt.cpp) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119616 Andreas Kling changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208403|review?, commit-queue? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 01:16:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 01:16:09 -0700 Subject: [Webkit-unassigned] [Bug 119616] [Qt] Build fix (typo in WebCore/xml/parser/XMLDocumentParserQt.cpp) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119616 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 01:48:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 01:48:59 -0700 Subject: [Webkit-unassigned] [Bug 111702] [Meta][EFL] Touch support for WebKit EFL In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=111702 EunMi Lee changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207644|0 |1 is obsolete| | --- Comment #3 from EunMi Lee 2013-08-09 01:48:36 PST --- Created an attachment (id=208406) --> (https://bugs.webkit.org/attachment.cgi?id=208406&action=review) patch for testing gestures - 20130809 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 02:04:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 02:04:05 -0700 Subject: [Webkit-unassigned] [Bug 119616] [Qt] Build fix (typo in WebCore/xml/parser/XMLDocumentParserQt.cpp) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119616 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208403|review+, commit-queue+ | Flag| | --- Comment #2 from WebKit Commit Bot 2013-08-09 02:03:43 PST --- (From update of attachment 208403) Clearing flags on attachment: 208403 Committed r153878: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 02:04:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 02:04:07 -0700 Subject: [Webkit-unassigned] [Bug 119616] [Qt] Build fix (typo in WebCore/xml/parser/XMLDocumentParserQt.cpp) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119616 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from WebKit Commit Bot 2013-08-09 02:03:46 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 02:23:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 02:23:06 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208349|0 |1 is obsolete| | Attachment #208349|commit-queue? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 02:23:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 02:23:19 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208408| |review?, commit-queue? Flag| | --- Comment #61 from Brian Holt 2013-08-09 02:22:56 PST --- Created an attachment (id=208408) --> (https://bugs.webkit.org/attachment.cgi?id=208408&action=review) Final final patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 02:23:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 02:23:47 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208408|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 02:39:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 02:39:36 -0700 Subject: [Webkit-unassigned] [Bug 119539] [EFL] REGRESSION after r153432: marking crashing tests. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119539 --- Comment #5 from Krzysztof Czech 2013-08-09 02:39:11 PST --- I already checked. Those that crashed due to the issue with parentElement() are ok, others need to be rebased. I tested quickly rebased tests, they seem ok, but I got 0 on AXPosition so I'm going to check it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 02:56:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 02:56:43 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208408|commit-queue? |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:04:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:04:52 -0700 Subject: [Webkit-unassigned] [Bug 119618] New: Adding an .ycm_extra_conf file for webkitGtk Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119618 Summary: Adding an .ycm_extra_conf file for webkitGtk Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: danilo.cesar at collabora.co.uk YouCompleteMe is a vim plugin to allow semantic auto completion (and other fetures) on c/c++ code. It was originally built for chromium and it requires special configurations[1] depending on the build system. I have been using it for a while now, and it might be handy for others webkitgtk developers. [1] https://github.com/scheib/chromium/blob/master/tools/vim/chromium.ycm_extra_conf.py -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:07:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:07:54 -0700 Subject: [Webkit-unassigned] [Bug 119618] Adding an .ycm_extra_conf file for webkitGtk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119618 Danilo Cesar Lemes de Paula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208411| |review? Flag| | --- Comment #1 from Danilo Cesar Lemes de Paula 2013-08-09 03:07:32 PST --- Created an attachment (id=208411) --> (https://bugs.webkit.org/attachment.cgi?id=208411&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:08:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:08:01 -0700 Subject: [Webkit-unassigned] [Bug 119484] [WK2] REGRESSION(r138378): Keyboard scrolling does not work with delegated scrolling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119484 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenneth at webkit.org, | |tonikitoo at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:14:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:14:38 -0700 Subject: [Webkit-unassigned] [Bug 119618] Adding a .ycm_extra_conf file for webkitGtk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119618 Danilo Cesar Lemes de Paula changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding an .ycm_extra_conf |Adding a .ycm_extra_conf |file for webkitGtk |file for webkitGtk -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:23:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:23:55 -0700 Subject: [Webkit-unassigned] [Bug 119619] New: [Win] TestWebKitAPI fails to link. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119619 Summary: [Win] TestWebKitAPI fails to link. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: peavo at outlook.com Linking TestWebKitAPI fails with the following error: error LNK2019: unresolved external symbol "protected: class WebCore::ImageOrientation __thiscall WebCore::BitmapImage::frameOrientationAtIndex(unsigned int)" (?frameOrientationAtIndex at BitmapImage@WebCore@@IAE?AVImageOrientation at 2@I at Z) referenced in function "public: virtual class WebCore::ImageOrientation __thiscall WebCore::BitmapImage::orientationForCurrentFrame(void)" (?orientationForCurrentFrame at BitmapImage@WebCore@@UAE?AVImageOrientation at 2@XZ) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:29:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:29:35 -0700 Subject: [Webkit-unassigned] [Bug 119619] [Win] TestWebKitAPI fails to link. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119619 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208412| |review? Flag| | --- Comment #1 from peavo at outlook.com 2013-08-09 03:29:14 PST --- Created an attachment (id=208412) --> (https://bugs.webkit.org/attachment.cgi?id=208412&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:30:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:30:14 -0700 Subject: [Webkit-unassigned] [Bug 119619] [Win] TestWebKitAPI fails to link. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119619 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208412| |commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:30:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:30:23 -0700 Subject: [Webkit-unassigned] [Bug 119619] [Win] TestWebKitAPI fails to link. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119619 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bfulgham at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:32:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:32:07 -0700 Subject: [Webkit-unassigned] [Bug 79668] [Qt] Meta bug to fix crashes/assertions/timeouts In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=79668 Csaba Osztrogonac OOO until 21st Aug changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |94345 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:40:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:40:41 -0700 Subject: [Webkit-unassigned] [Bug 118547] Leaking most Documents when tab closing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118547 Sangho Kim changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Leaking most Documents |Leaking most Documents when | |tab closing --- Comment #13 from Sangho Kim 2013-08-09 03:40:19 PST --- When tab closing, Documents wasn't deleted. Because of that, All resources was not deleted. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:45:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:45:56 -0700 Subject: [Webkit-unassigned] [Bug 99059] [GTK] Add support for the hidden page DOM timer throttling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99059 --- Comment #2 from Anton Obzhirov 2013-08-09 03:45:34 PST --- After some checking - this functionality seems to be linked to setProcessSuppressionEnabled API in WebProcess which is enabled for MAC only. It is not clear for me if the process suppression is needed for GTK port, may be Carlos or Martin can comment on it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:46:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:46:37 -0700 Subject: [Webkit-unassigned] [Bug 99059] [GTK] Add support for the hidden page DOM timer throttling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99059 Anton Obzhirov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgarcia at igalia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:47:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:47:00 -0700 Subject: [Webkit-unassigned] [Bug 99059] [GTK] Add support for the hidden page DOM timer throttling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99059 Anton Obzhirov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrobinson at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:47:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:47:59 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208408|commit-queue+ | Flag| | --- Comment #62 from WebKit Commit Bot 2013-08-09 03:47:37 PST --- (From update of attachment 208408) Clearing flags on attachment: 208408 Committed r153882: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:48:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:48:06 -0700 Subject: [Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99352 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #63 from WebKit Commit Bot 2013-08-09 03:47:43 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:48:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:48:07 -0700 Subject: [Webkit-unassigned] [Bug 113663] Missing APIs in webkit2gtk (compared to webkit1) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113663 Bug 113663 depends on bug 99352, which changed state. Bug 99352 Summary: [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView https://bugs.webkit.org/show_bug.cgi?id=99352 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:48:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:48:08 -0700 Subject: [Webkit-unassigned] [Bug 116537] can no longer veto the showing of WebKitGTK's default authentication prompter In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116537 Bug 116537 depends on bug 99352, which changed state. Bug 99352 Summary: [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView https://bugs.webkit.org/show_bug.cgi?id=99352 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:48:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:48:09 -0700 Subject: [Webkit-unassigned] [Bug 119303] [GTK] Add enable_credential_store option In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119303 Bug 119303 depends on bug 99352, which changed state. Bug 99352 Summary: [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView https://bugs.webkit.org/show_bug.cgi?id=99352 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:48:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:48:09 -0700 Subject: [Webkit-unassigned] [Bug 119487] [Gtk] Cancel authentication on load failed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119487 Bug 119487 depends on bug 99352, which changed state. Bug 99352 Summary: [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView https://bugs.webkit.org/show_bug.cgi?id=99352 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:56:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:56:55 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Rashmi Shyamasundar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208243|0 |1 is obsolete| | Attachment #208243|review- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 03:57:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 03:57:06 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Rashmi Shyamasundar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208414| |review? Flag| | --- Comment #11 from Rashmi Shyamasundar 2013-08-09 03:56:43 PST --- Created an attachment (id=208414) --> (https://bugs.webkit.org/attachment.cgi?id=208414&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 04:27:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 04:27:20 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208414|review? |review- Flag| | --- Comment #12 from Christophe Dumez 2013-08-09 04:26:57 PST --- (From update of attachment 208414) View in context: https://bugs.webkit.org/attachment.cgi?id=208414&action=review > Source/WebCore/ChangeLog:12 > + This patch modifies the canvas functions drawTextInternal and measureText to conform to the above spec. Does it match Firefox as well? > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:93 > Would be nice to add a link to the specification in comment: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#space-character > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:94 > +static inline bool shouldSpaceBeReplaced(UChar c) This function has nothing to do with replacing. Maybe we can call it isHTMLSpace() ? > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:96 > + return (c == 0x0009 || c == 0x000A || c == 0x000B || c == 0x000C || c == 0x000D) ? true : false; return (c == 0x0009 || c == 0x000A || c == 0x000B || c == 0x000C || c == 0x000D); > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2111 > + const size_t replacementLength = replacement.length(); length() returns an 'unsigned' type. I think it is best to use the same type. > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2112 > + size_t index = 0; No need to initialize to 0. > LayoutTests/ChangeLog:11 > + The below listed layout tests veriy the conformance to above spec. verify > LayoutTests/fast/canvas/canvas-fillText-ideographicSpace-expected.html:1 > + -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 04:28:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 04:28:31 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #13 from Christophe Dumez 2013-08-09 04:28:09 PST --- (From update of attachment 208414) View in context: https://bugs.webkit.org/attachment.cgi?id=208414&action=review > Source/WebCore/ChangeLog:14 > + Reviewed by NOBODY (OOPS!). The reviewed by line should come before the changelog, not after. > LayoutTests/ChangeLog:13 > + Reviewed by NOBODY (OOPS!). The reviewed by line should come before the changelog, not after. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 04:46:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 04:46:29 -0700 Subject: [Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118445 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208401|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #41 from Allan Sandfeld Jensen 2013-08-09 04:46:07 PST --- (From update of attachment 208401) LGTMT -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 04:47:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 04:47:45 -0700 Subject: [Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118445 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:07:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:07:56 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Bug 116980 depends on bug 119570, which changed state. Bug 119570 Summary: Null-pointer derefence in WebCore::StylePropertySet::propertyCount https://bugs.webkit.org/show_bug.cgi?id=119570 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:10:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:10:31 -0700 Subject: [Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118445 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208401|review+, commit-queue+ | Flag| | --- Comment #42 from WebKit Commit Bot 2013-08-09 05:10:09 PST --- (From update of attachment 208401) Clearing flags on attachment: 208401 Committed r153884: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:10:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:10:35 -0700 Subject: [Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118445 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #43 from WebKit Commit Bot 2013-08-09 05:10:13 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:10:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:10:53 -0700 Subject: [Webkit-unassigned] [Bug 119620] New: [Curl] Crash when starting second download. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119620 Summary: [Curl] Crash when starting second download. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: peavo at outlook.com When I start a second download, I sometimes get a crash in Curl. This happens because the Curl easy handle is deleted and removed from the Curl multi handle twice. The first delete happens when the download thread has finished downloading, and the second happens when the WebDownload object is deleted, and calls the cancel method. The Curl handle is then put in a delete queue, which is processed by the download thread the next time it starts. This is the reason the crash happens when the second download is started. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:14:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:14:06 -0700 Subject: [Webkit-unassigned] [Bug 119621] New: ASSERTION FAILED: !(lineMidpointState.numMidpoints % 2) in WebCore::startIgnoringSpaces Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119621 Summary: ASSERTION FAILED: !(lineMidpointState.numMidpoints % 2) in WebCore::startIgnoringSpaces Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: reni at webkit.org Blocks: 116980 The following svg tests fails on the above assertion check: foo The backtrace: Program received signal SIGSEGV, Segmentation fault. b0x00007ffff56f53e4 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 342 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) bt #0 0x00007ffff56f53e4 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 #1 0x00007ffff485d428 in WebCore::startIgnoringSpaces (lineMidpointState=..., midpoint=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:444 #2 0x00007ffff485d54c in WebCore::ensureCharacterGetsLineBox (lineMidpointState=..., textParagraphSeparator=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:467 #3 0x00007ffff486bd06 in WebCore::RenderBlock::LineBreaker::nextSegmentBreak (this=0x7fffffffa2d0, resolver=..., lineInfo=..., renderTextInfo=..., lastFloatFromPreviousLine=0x0, consecutiveHyphenatedLines=0, wordMeasurements=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:3392 #4 0x00007ffff4868b66 in WebCore::RenderBlock::LineBreaker::nextLineBreak (this=0x7fffffffa2d0, resolver=..., lineInfo=..., renderTextInfo=..., lastFloatFromPreviousLine=0x0, consecutiveHyphenatedLines=0, wordMeasurements=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:2815 #5 0x00007ffff486359c in WebCore::RenderBlock::layoutRunsAndFloatsInRange (this=0x8b1878, layoutState=..., resolver=..., cleanLineStart=..., cleanLineBidiStatus=..., consecutiveHyphenatedLines=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1845 #6 0x00007ffff4862093 in WebCore::RenderBlock::layoutRunsAndFloats (this=0x8b1878, layoutState=..., hasInlineChild=true) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1614 #7 0x00007ffff48657ec in WebCore::RenderBlock::layoutInlineChildren (this=0x8b1878, relayoutChildren=true, repaintLogicalTop=..., repaintLogicalBottom=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:2189 #8 0x00007ffff4bd07b3 in WebCore::RenderBlock::forceLayoutInlineChildren (this=0x8b1878) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.h:591 #9 0x00007ffff4bd2372 in WebCore::RenderSVGText::layout (this=0x8b1878) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/svg/RenderSVGText.cpp:417 #10 0x00007ffff4bde14e in WebCore::SVGRenderSupport::layoutChildren (start=0x8b7ac8, selfNeedsLayout=true) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/svg/SVGRenderSupport.cpp:275 #11 0x00007ffff4bcd519 in WebCore::RenderSVGRoot::layout (this=0x8b7ac8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/svg/RenderSVGRoot.cpp:243 #12 0x00007ffff47e433d in WebCore::RenderObject::layoutIfNeeded (this=0x8b7ac8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderObject.h:704 #13 0x00007ffff48657aa in WebCore::RenderBlock::layoutInlineChildren (this=0x8945b8, relayoutChildren=true, repaintLogicalTop=..., repaintLogicalBottom=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:2187 #14 0x00007ffff4819ad2 in WebCore::RenderBlock::layoutBlock (this=0x8945b8, relayoutChildren=true, pageLogicalHeight=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1656 #15 0x00007ffff4818f05 in WebCore::RenderBlock::layout (this=0x8945b8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1428 #16 0x00007ffff481e334 in WebCore::RenderBlock::layoutBlockChild (this=0x7b2dd8, child=0x8945b8, marginInfo=..., previousFloatLogicalBottom=..., maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:2669 #17 0x00007ffff481df2d in WebCore::RenderBlock::layoutBlockChildren (this=0x7b2dd8, relayoutChildren=true, maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:2604 #18 0x00007ffff4819af3 in WebCore::RenderBlock::layoutBlock (this=0x7b2dd8, relayoutChildren=true, pageLogicalHeight=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1658 #19 0x00007ffff4818f05 in WebCore::RenderBlock::layout (this=0x7b2dd8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1428 #20 0x00007ffff481e334 in WebCore::RenderBlock::layoutBlockChild (this=0x76d4d8, child=0x7b2dd8, marginInfo=..., previousFloatLogicalBottom=..., maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:2669 #21 0x00007ffff481df2d in WebCore::RenderBlock::layoutBlockChildren (this=0x76d4d8, relayoutChildren=true, maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:2604 #22 0x00007ffff4819af3 in WebCore::RenderBlock::layoutBlock (this=0x76d4d8, relayoutChildren=true, pageLogicalHeight=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1658 #23 0x00007ffff4818f05 in WebCore::RenderBlock::layout (this=0x76d4d8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1428 #24 0x00007ffff49cdf15 in WebCore::RenderView::layoutContent (this=0x76d4d8, state=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderView.cpp:142 #25 0x00007ffff49cecd2 in WebCore::RenderView::layout (this=0x76d4d8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderView.cpp:327 #26 0x00007ffff467a63a in WebCore::FrameView::layout (this=0x774700, allowSubtree=true) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/page/FrameView.cpp:1327 #27 0x00007ffff41b2e8f in WebCore::Document::implicitClose (this=0x87bb10) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:2452 #28 0x00007ffff45b349f in WebCore::FrameLoader::checkCallImplicitClose (this=0x7b0a48) ---Type to continue, or q to quit--- at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:844 #29 0x00007ffff45b3210 in WebCore::FrameLoader::checkCompleted (this=0x7b0a48) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:787 #30 0x00007ffff45b2f45 in WebCore::FrameLoader::finishedParsing (this=0x7b0a48) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:720 #31 0x00007ffff41b9e35 in WebCore::Document::finishedParsing (this=0x87bb10) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:4427 #32 0x00007ffff440ce97 in WebCore::HTMLConstructionSite::finishedParsing (this=0x7f31a8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLConstructionSite.cpp:348 #33 0x00007ffff44415b9 in WebCore::HTMLTreeBuilder::finished (this=0x7f3190) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2926 #34 0x00007ffff4414596 in WebCore::HTMLDocumentParser::end (this=0x774fd0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:763 #35 0x00007ffff4414681 in WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd (this=0x774fd0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:774 #36 0x00007ffff44131f0 in WebCore::HTMLDocumentParser::prepareToStopParsing (this=0x774fd0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:211 #37 0x00007ffff44146c6 in WebCore::HTMLDocumentParser::attemptToEnd (this=0x774fd0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:786 #38 0x00007ffff441477f in WebCore::HTMLDocumentParser::finish (this=0x774fd0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:835 #39 0x00007ffff45aada5 in WebCore::DocumentWriter::end (this=0x694190) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentWriter.cpp:248 #40 0x00007ffff459d8e4 in WebCore::DocumentLoader::finishedLoading (this=0x6940f0, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:402 #41 0x00007ffff459d652 in WebCore::DocumentLoader::notifyFinished (this=0x6940f0, resource=0x7a95c0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:344 #42 0x00007ffff4584948 in WebCore::CachedResource::checkNotify (this=0x7a95c0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:369 #43 0x00007ffff4584a1e in WebCore::CachedResource::finishLoading (this=0x7a95c0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:385 #44 0x00007ffff4581170 in WebCore::CachedRawResource::finishLoading (this=0x7a95c0, data=0x765080) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedRawResource.cpp:94 #45 0x00007ffff45e7765 in WebCore::SubresourceLoader::didFinishLoading (this=0x794f30, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/SubresourceLoader.cpp:282 #46 0x00007ffff45de04f in WebCore::ResourceLoader::didFinishLoading (this=0x794f30, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/ResourceLoader.cpp:488 #47 0x00007ffff4a878e3 in WebCore::QNetworkReplyHandler::finish (this=0x74a890) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:516 #48 0x00007ffff4a86602 in WebCore::QNetworkReplyHandlerCallQueue::flush (this=0x74a8c8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:250 #49 0x00007ffff4a862ff in WebCore::QNetworkReplyHandlerCallQueue::push (this=0x74a8c8, method=(void (WebCore::QNetworkReplyHandler::*)(WebCore::QNetworkReplyHandler * const)) 0x7ffff4a87728 ) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:216 #50 0x00007ffff4a8724c in WebCore::QNetworkReplyWrapper::didReceiveFinished (this=0x797130) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:409 #51 0x00007ffff4a89bde in WebCore::QNetworkReplyWrapper::qt_static_metacall (_o=0x797130, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffffffcf70) at .moc/release-shared/moc_QNetworkReplyHandler.cpp:176 #52 0x00007ffff22115cb in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #53 0x00007ffff221284e in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #54 0x00007ffff3058dbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #55 0x00007ffff305c075 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #56 0x00007ffff21ecdbe in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #57 0x00007ffff21eea76 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #58 0x00007ffff2234333 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #59 0x00007fffee3790a6 in g_main_dispatch (context=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3058 ---Type to continue, or q to quit--- #60 g_main_context_dispatch (context=context at entry=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3634 #61 0x00007fffee3793f8 in g_main_context_iterate (context=context at entry=0x6632f0, block=block at entry=1, dispatch=dispatch at entry=1, self=) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3705 #62 0x00007fffee37949c in g_main_context_iteration (context=0x6632f0, may_block=1) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3766 #63 0x00007ffff22344bc in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #64 0x00007ffff21ebd3b in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #65 0x00007ffff21ef120 in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #66 0x0000000000421ba0 in launcherMain (app=...) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:49 #67 0x0000000000423680 in main (argc=2, argv=0x7fffffffdc48) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:318 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:14:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:14:08 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119621 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:14:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:14:23 -0700 Subject: [Webkit-unassigned] [Bug 119621] ASSERTION FAILED: !(lineMidpointState.numMidpoints % 2) in WebCore::startIgnoringSpaces In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119621 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leviw at chromium.org, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:15:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:15:06 -0700 Subject: [Webkit-unassigned] [Bug 119621] ASSERTION FAILED: !(lineMidpointState.numMidpoints % 2) in WebCore::startIgnoringSpaces In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119621 --- Comment #1 from Renata Hodovan 2013-08-09 05:14:45 PST --- Created an attachment (id=208416) --> (https://bugs.webkit.org/attachment.cgi?id=208416&action=review) Test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:16:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:16:20 -0700 Subject: [Webkit-unassigned] [Bug 119622] New: Not possible to clear the selection when mixing content from different FlowThreads Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Summary: Not possible to clear the selection when mixing content from different FlowThreads Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jfernandez at igalia.com This bug was hidden by the fix for the bug 105641, which basically prevented the selection to be rendered when crossing the FlowThread boundaries. Such fix is not correct, because instead of fixing the actual bug it adds restrictions on how the selection works with Regions. We need to properly fix the selection clearing operation, allowing selections to cross RenderFlow boundaries and select content from different Regions. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:16:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:16:51 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Javier Fernandez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jfernandez at igalia.com, | |WebkitBugTracker at adobe.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:31:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:31:19 -0700 Subject: [Webkit-unassigned] [Bug 119620] [Curl] Crash when starting second download. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119620 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208419| |review? Flag| | --- Comment #1 from peavo at outlook.com 2013-08-09 05:30:57 PST --- Created an attachment (id=208419) --> (https://bugs.webkit.org/attachment.cgi?id=208419&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:31:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:31:55 -0700 Subject: [Webkit-unassigned] [Bug 119620] [Curl] Crash when starting second download. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119620 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208419| |commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:32:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:32:04 -0700 Subject: [Webkit-unassigned] [Bug 119620] [Curl] Crash when starting second download. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119620 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bfulgham at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:33:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:33:25 -0700 Subject: [Webkit-unassigned] [Bug 119620] [Curl] Crash when starting second download. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119620 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |galpeter at inf.u-szeged.hu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:35:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:35:09 -0700 Subject: [Webkit-unassigned] [Bug 119623] New: ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119623 Summary: ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: reni at webkit.org Blocks: 116980 The following test crashes: The backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff56f53e4 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 342 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) bt #0 0x00007ffff56f53e4 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 #1 0x00007ffff4ba3754 in WebCore::SVGRenderStyle::diff (this=0x8bf0b0, other=0x727520) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/style/SVGRenderStyle.cpp:190 #2 0x00007ffff4a034a9 in WebCore::RenderStyle::diff (this=0x8bf040, other=0x72be10, changedContextSensitiveProperties=@0x7fffffffc554: 0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/style/RenderStyle.cpp:759 #3 0x00007ffff49740eb in WebCore::RenderObject::setStyle (this=0x8baa28, style=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderObject.cpp:1838 #4 0x00007ffff4973ad3 in WebCore::RenderObject::setAnimatableStyle (this=0x8baa28, style=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderObject.cpp:1730 #5 0x00007ffff4a29efa in WebCore::Style::resolveLocal (current=0x8be9d0, inheritedChange=WebCore::Style::NoChange) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/style/StyleResolveTree.cpp:156 #6 0x00007ffff4a2a3aa in WebCore::Style::resolveTree (current=0x8be9d0, change=WebCore::Style::NoChange) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/style/StyleResolveTree.cpp:234 #7 0x00007ffff4a2a582 in WebCore::Style::resolveTree (current=0x8bad00, change=WebCore::Style::NoChange) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/style/StyleResolveTree.cpp:268 #8 0x00007ffff4a2a582 in WebCore::Style::resolveTree (current=0x89aaa0, change=WebCore::Style::NoChange) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/style/StyleResolveTree.cpp:268 #9 0x00007ffff4a2a582 in WebCore::Style::resolveTree (current=0x744d30, change=WebCore::Style::NoChange) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/style/StyleResolveTree.cpp:268 #10 0x00007ffff4a2a582 in WebCore::Style::resolveTree (current=0x87f2d0, change=WebCore::Style::NoChange) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/style/StyleResolveTree.cpp:268 #11 0x00007ffff4a2a582 in WebCore::Style::resolveTree (current=0x7754e0, change=WebCore::Style::NoChange) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/style/StyleResolveTree.cpp:268 #12 0x00007ffff41b097d in WebCore::Document::recalcStyle (this=0x87c980, change=WebCore::Style::NoChange) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:1804 #13 0x00007ffff41b0cd5 in WebCore::Document::updateStyleIfNeeded (this=0x87c980) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:1856 #14 0x00007ffff401440c in WebCore::ComputedStyleExtractor::propertyValue (this=0x7fffffffcdb0, propertyID=WebCore::CSSPropertyStroke, updateLayout=WebCore::UpdateLayout) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1681 #15 0x00007ffff4c5e3a8 in WebCore::SVGAnimationElement::computeCSSPropertyValue (this=0x8b7bc0, element=0x8be9d0, id=WebCore::CSSPropertyStroke, valueString=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/svg/SVGAnimationElement.cpp:642 #16 0x00007ffff4c570f3 in WebCore::SVGAnimateElement::resetAnimatedType (this=0x8b7bc0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/svg/SVGAnimateElement.cpp:233 #17 0x00007ffff4c09a48 in WebCore::SVGSMILElement::progress (this=0x8b7bc0, elapsed=..., resultElement=0x8b7bc0, seekToTime=false) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/svg/animation/SVGSMILElement.cpp:1107 #18 0x00007ffff4bffc4d in WebCore::SMILTimeContainer::updateAnimations (this=0x893cb0, elapsed=..., seekToTime=false) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/svg/animation/SMILTimeContainer.cpp:293 #19 0x00007ffff4bff717 in WebCore::SMILTimeContainer::timerFired (this=0x893cb0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/svg/animation/SMILTimeContainer.cpp:219 #20 0x00007ffff4c03ae7 in WebCore::Timer::fired (this=0x893ce0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/Timer.h:114 #21 0x00007ffff47b2724 in WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x6e44b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/ThreadTimers.cpp:129 #22 0x00007ffff47b2611 in WebCore::ThreadTimers::sharedTimerFired () at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/ThreadTimers.cpp:105 #23 0x00007ffff4aac8e8 in WebCore::SharedTimerQt::timerEvent (this=0x6e44e0, ev=0x7fffffffd700) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/qt/SharedTimerQt.cpp:113 #24 0x00007ffff221266c in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #25 0x00007ffff3058dbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #26 0x00007ffff305c075 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #27 0x00007ffff21ecdbe in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #28 0x00007ffff223375c in QTimerInfoList::activateTimers() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #29 0x00007ffff2234094 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #30 0x00007fffee3790a6 in g_main_dispatch (context=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3058 #31 g_main_context_dispatch (context=context at entry=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3634 ---Type to continue, or q to quit--- #32 0x00007fffee3793f8 in g_main_context_iterate (context=context at entry=0x6632f0, block=block at entry=1, dispatch=dispatch at entry=1, self=) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3705 #33 0x00007fffee37949c in g_main_context_iteration (context=0x6632f0, may_block=1) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3766 #34 0x00007ffff22344bc in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #35 0x00007ffff21ebd3b in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #36 0x00007ffff21ef120 in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #37 0x0000000000421ba0 in launcherMain (app=...) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:49 #38 0x0000000000423680 in main (argc=2, argv=0x7fffffffdc68) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:318 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:35:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:35:11 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119623 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:35:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:35:22 -0700 Subject: [Webkit-unassigned] [Bug 119623] ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119623 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krit at webkit.org, | |zimmermann at kde.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:37:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:37:12 -0700 Subject: [Webkit-unassigned] [Bug 119623] ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119623 --- Comment #1 from Renata Hodovan 2013-08-09 05:36:50 PST --- Created an attachment (id=208420) --> (https://bugs.webkit.org/attachment.cgi?id=208420&action=review) Test case (extension needs to be .html) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:45:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:45:48 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Rashmi Shyamasundar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208414|0 |1 is obsolete| | Attachment #208414|review- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:46:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:46:00 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Rashmi Shyamasundar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208421| |review? Flag| | --- Comment #14 from Rashmi Shyamasundar 2013-08-09 05:45:37 PST --- Created an attachment (id=208421) --> (https://bugs.webkit.org/attachment.cgi?id=208421&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:49:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:49:47 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 EFL EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eflews.bot at gmail.com, | |gyuyoung.kim at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:49:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:49:51 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 EFL EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208421| |commit-queue- Flag| | --- Comment #15 from EFL EWS Bot 2013-08-09 05:49:28 PST --- (From update of attachment 208421) Attachment 208421 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1359437 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:50:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:50:31 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Qt Early Warning System Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |webkit-ews at sed.inf.u-szeged | |.hu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:50:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:50:37 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #16 from Qt Early Warning System Bot 2013-08-09 05:50:13 PST --- (From update of attachment 208421) Attachment 208421 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1401180 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:50:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:50:48 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #17 from Qt Early Warning System Bot 2013-08-09 05:50:25 PST --- (From update of attachment 208421) Attachment 208421 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1414319 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:53:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:53:03 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #18 from EFL EWS Bot 2013-08-09 05:52:40 PST --- (From update of attachment 208421) Attachment 208421 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1385259 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:53:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:53:44 -0700 Subject: [Webkit-unassigned] [Bug 119625] New: [Performance]making HTMLSelectElement::usesMenuList() inline Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119625 Summary: [Performance]making HTMLSelectElement::usesMenuList() inline Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: santosh.ma at samsung.com Note: Related to Benjamin Blog ( https://www.webkit.org/blog/) for improving performance of webcore The function HTMLSelectElement::usesMenuList() is used to decide how to render the select element(RenderBox or MenuList) It has been used lot of places (22 times) in same class . Its good to declare this as inline , The size of this function is unusually big as in "every times theme checking" is done. So futher to improve performance I have adjusted the code to make it inline and theme checking only once. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:57:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:57:17 -0700 Subject: [Webkit-unassigned] [Bug 116537] can no longer veto the showing of WebKitGTK's default authentication prompter In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116537 --- Comment #4 from Brian Holt 2013-08-09 05:56:54 PST --- (In reply to comment #3) > It's good to see that a formal API is being introduced to handle this in bug 99352. However I'm guessing that this API would not be added to the WebKit1 stream since it's now API-frozen? No, WebKit1 is now in maintenance mode so no new APIs are being added. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:59:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:59:11 -0700 Subject: [Webkit-unassigned] [Bug 119577] [Qt] REGRESSION(r153664): ThirdParty Angle build is broken. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119577 Zoltan Arvai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208422| |review?, commit-queue? Flag| | --- Comment #2 from Zoltan Arvai 2013-08-09 05:58:48 PST --- Created an attachment (id=208422) --> (https://bugs.webkit.org/attachment.cgi?id=208422&action=review) buildfix Adding ANGLE_WEBKIT_WIN definition to Target.pri. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:59:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:59:15 -0700 Subject: [Webkit-unassigned] [Bug 119626] New: SSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) in WebCore::RenderGeometryMap::mapToContainer Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119626 Summary: SSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) in WebCore::RenderGeometryMap::mapToContainer Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: reni at webkit.org Blocks: 116980 The crash happens on the following test:

                        123



  • Note: if you decrease the value of "rows" property of textarea then the crash disappears. The backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff56f53e4 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 342 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) bt #0 0x00007ffff56f53e4 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 #1 0x00007ffff48e8b16 in WebCore::RenderGeometryMap::mapToContainer (this=0x7fffffffc010, p=..., container=0x0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderGeometryMap.cpp:117 #2 0x00007ffff4905b62 in WebCore::RenderGeometryMap::absolutePoint (this=0x7fffffffc010, p=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderGeometryMap.h:84 #3 0x00007ffff4907144 in WebCore::RenderLayer::updateLayerPositions (this=0x8aaef8, geometryMap=0x7fffffffc010, flags=14) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderLayer.cpp:431 #4 0x00007ffff4907563 in WebCore::RenderLayer::updateLayerPositions (this=0x7b13a8, geometryMap=0x7fffffffc010, flags=14) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderLayer.cpp:499 #5 0x00007ffff4907563 in WebCore::RenderLayer::updateLayerPositions (this=0x76fe58, geometryMap=0x7fffffffc010, flags=14) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderLayer.cpp:499 #6 0x00007ffff490708b in WebCore::RenderLayer::updateLayerPositionsAfterLayout (this=0x76fe58, rootLayer=0x76fe58, flags=14) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderLayer.cpp:414 #7 0x00007ffff467a7a9 in WebCore::FrameView::layout (this=0x774890, allowSubtree=true) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/page/FrameView.cpp:1354 #8 0x00007ffff467dd40 in WebCore::FrameView::visibleContentsResized (this=0x774890) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/page/FrameView.cpp:2218 #9 0x00007ffff4795ef8 in WebCore::ScrollView::updateScrollbars (this=0x774890, desiredOffset=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/ScrollView.cpp:556 #10 0x00007ffff479497d in WebCore::ScrollView::setContentsSize (this=0x774890, newSize=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/ScrollView.cpp:305 #11 0x00007ffff4678219 in WebCore::FrameView::setContentsSize (this=0x774890, size=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/page/FrameView.cpp:595 #12 0x00007ffff4678456 in WebCore::FrameView::adjustViewSize (this=0x774890) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/page/FrameView.cpp:624 #13 0x00007ffff467a70a in WebCore::FrameView::layout (this=0x774890, allowSubtree=true) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/page/FrameView.cpp:1345 #14 0x00007ffff41b2e8f in WebCore::Document::implicitClose (this=0x87c150) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:2452 #15 0x00007ffff45b349f in WebCore::FrameLoader::checkCallImplicitClose (this=0x7b0bd8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:844 #16 0x00007ffff45b3210 in WebCore::FrameLoader::checkCompleted (this=0x7b0bd8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:787 #17 0x00007ffff45b2f45 in WebCore::FrameLoader::finishedParsing (this=0x7b0bd8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:720 #18 0x00007ffff41b9e35 in WebCore::Document::finishedParsing (this=0x87c150) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:4427 #19 0x00007ffff440ce97 in WebCore::HTMLConstructionSite::finishedParsing (this=0x7f3338) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLConstructionSite.cpp:348 #20 0x00007ffff44415b9 in WebCore::HTMLTreeBuilder::finished (this=0x7f3320) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2926 #21 0x00007ffff4414596 in WebCore::HTMLDocumentParser::end (this=0x775160) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:763 #22 0x00007ffff4414681 in WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd (this=0x775160) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:774 #23 0x00007ffff44131f0 in WebCore::HTMLDocumentParser::prepareToStopParsing (this=0x775160) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:211 #24 0x00007ffff44146c6 in WebCore::HTMLDocumentParser::attemptToEnd (this=0x775160) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:786 #25 0x00007ffff441477f in WebCore::HTMLDocumentParser::finish (this=0x775160) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:835 #26 0x00007ffff45aada5 in WebCore::DocumentWriter::end (this=0x6942f0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentWriter.cpp:248 #27 0x00007ffff459d8e4 in WebCore::DocumentLoader::finishedLoading (this=0x694250, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:402 #28 0x00007ffff459d652 in WebCore::DocumentLoader::notifyFinished (this=0x694250, resource=0x7a9840) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:344 #29 0x00007ffff4584948 in WebCore::CachedResource::checkNotify (this=0x7a9840) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:369 ---Type to continue, or q to quit--- #30 0x00007ffff4584a1e in WebCore::CachedResource::finishLoading (this=0x7a9840) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:385 #31 0x00007ffff4581170 in WebCore::CachedRawResource::finishLoading (this=0x7a9840, data=0x8668e0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedRawResource.cpp:94 #32 0x00007ffff45e7765 in WebCore::SubresourceLoader::didFinishLoading (this=0x78d780, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/SubresourceLoader.cpp:282 #33 0x00007ffff45de04f in WebCore::ResourceLoader::didFinishLoading (this=0x78d780, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/ResourceLoader.cpp:488 #34 0x00007ffff4a878e3 in WebCore::QNetworkReplyHandler::finish (this=0x7a9690) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:516 #35 0x00007ffff4a86602 in WebCore::QNetworkReplyHandlerCallQueue::flush (this=0x7a96c8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:250 #36 0x00007ffff4a862ff in WebCore::QNetworkReplyHandlerCallQueue::push (this=0x7a96c8, method=(void (WebCore::QNetworkReplyHandler::*)(WebCore::QNetworkReplyHandler * const)) 0x7ffff4a87728 ) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:216 #37 0x00007ffff4a8724c in WebCore::QNetworkReplyWrapper::didReceiveFinished (this=0x7aa3f0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:409 #38 0x00007ffff4a89bde in WebCore::QNetworkReplyWrapper::qt_static_metacall (_o=0x7aa3f0, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffffffcf80) at .moc/release-shared/moc_QNetworkReplyHandler.cpp:176 #39 0x00007ffff22115cb in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #40 0x00007ffff221284e in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #41 0x00007ffff3058dbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #42 0x00007ffff305c075 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #43 0x00007ffff21ecdbe in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #44 0x00007ffff21eea76 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #45 0x00007ffff2234333 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #46 0x00007fffee3790a6 in g_main_dispatch (context=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3058 #47 g_main_context_dispatch (context=context at entry=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3634 #48 0x00007fffee3793f8 in g_main_context_iterate (context=context at entry=0x6632f0, block=block at entry=1, dispatch=dispatch at entry=1, self=) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3705 #49 0x00007fffee37949c in g_main_context_iteration (context=0x6632f0, may_block=1) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3766 #50 0x00007ffff22344bc in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #51 0x00007ffff21ebd3b in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #52 0x00007ffff21ef120 in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #53 0x0000000000421ba0 in launcherMain (app=...) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:49 #54 0x0000000000423680 in main (argc=2, argv=0x7fffffffdc58) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:318 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 05:59:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 05:59:17 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119626 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:00:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:00:04 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Rashmi Shyamasundar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208421|0 |1 is obsolete| | Attachment #208421|review?, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:00:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:00:16 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Rashmi Shyamasundar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208423| |review? Flag| | --- Comment #19 from Rashmi Shyamasundar 2013-08-09 05:59:53 PST --- Created an attachment (id=208423) --> (https://bugs.webkit.org/attachment.cgi?id=208423&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:00:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:00:31 -0700 Subject: [Webkit-unassigned] [Bug 119626] SSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) in WebCore::RenderGeometryMap::mapToContainer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119626 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com, | |simon.fraser at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:00:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:00:57 -0700 Subject: [Webkit-unassigned] [Bug 119626] SSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) in WebCore::RenderGeometryMap::mapToContainer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119626 --- Comment #1 from Renata Hodovan 2013-08-09 06:00:35 PST --- Created an attachment (id=208424) --> (https://bugs.webkit.org/attachment.cgi?id=208424&action=review) Test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:01:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:01:49 -0700 Subject: [Webkit-unassigned] [Bug 119577] [Qt] REGRESSION(r153664): ThirdParty Angle build is broken. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119577 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |kondapallykalyan at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:02:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:02:42 -0700 Subject: [Webkit-unassigned] [Bug 119577] [Qt] REGRESSION(r153664): ThirdParty Angle build is broken. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119577 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208422|review?, commit-queue? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:03:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:03:04 -0700 Subject: [Webkit-unassigned] [Bug 119577] [Qt] REGRESSION(r153664): ThirdParty Angle build is broken. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119577 --- Comment #3 from Allan Sandfeld Jensen 2013-08-09 06:02:42 PST --- (In reply to comment #1) > Don't use SoftLinking.h while building ANGLE. To get the soft linking to work you need to define ANGLE_WEBKIT_WIN (which I did in translatorCommon.props, libEGLCommon.props, and libGLESv2Common.props in https://trac.webkit.org/changeset/153664) while compiling ANGLE to produce an unaltered dll. When compiling WebCore with WebGL enabled, do not define ANGLE_WEBKIT_WIN and it will use my soft link headers (eglsoftlinking.h and gl2softlinking.h). > > Are you planning to get WebGL working on Qt win? Let me know if you run into any problems. WebGL on Qt has been working for years. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:10:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:10:42 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Javier Fernandez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208425| |review?, commit-queue? Flag| | --- Comment #1 from Javier Fernandez 2013-08-09 06:10:21 PST --- Created an attachment (id=208425) --> (https://bugs.webkit.org/attachment.cgi?id=208425&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:13:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:13:38 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |esprehn+autocc at chromium.org | |, glenn at skynav.com, | |kondapallykalyan at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:13:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:13:50 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:13:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:13:52 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208425|commit-queue? |commit-queue- Flag| | --- Comment #2 from Build Bot 2013-08-09 06:13:30 PST --- (From update of attachment 208425) Attachment 208425 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1353447 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:14:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:14:55 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 --- Comment #3 from Build Bot 2013-08-09 06:14:33 PST --- (From update of attachment 208425) Attachment 208425 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1405199 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:15:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:15:23 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 EFL EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eflews.bot at gmail.com, | |gyuyoung.kim at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:15:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:15:27 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 --- Comment #4 from EFL EWS Bot 2013-08-09 06:15:04 PST --- (From update of attachment 208425) Attachment 208425 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1411318 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:16:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:16:13 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Qt Early Warning System Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |webkit-ews at sed.inf.u-szeged | |.hu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:16:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:16:17 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 --- Comment #5 from Qt Early Warning System Bot 2013-08-09 06:15:55 PST --- (From update of attachment 208425) Attachment 208425 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1369686 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:16:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:16:27 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 --- Comment #6 from Qt Early Warning System Bot 2013-08-09 06:16:04 PST --- (From update of attachment 208425) Attachment 208425 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1414328 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:16:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:16:35 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 --- Comment #7 from EFL EWS Bot 2013-08-09 06:16:12 PST --- (From update of attachment 208425) Attachment 208425 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1369685 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:26:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:26:07 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:26:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:26:10 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208423| |commit-queue- Flag| | --- Comment #20 from Build Bot 2013-08-09 06:25:47 PST --- (From update of attachment 208423) Attachment 208423 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1399183 New failing tests: canvas/philip/tests/2d.text.measure.width.space.html fast/canvas/canvas-fillText-ideographicSpace.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:26:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:26:12 -0700 Subject: [Webkit-unassigned] [Bug 119577] [Qt] REGRESSION(r153664): ThirdParty Angle build is broken. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119577 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208422|review+, commit-queue+ | Flag| | --- Comment #4 from WebKit Commit Bot 2013-08-09 06:25:50 PST --- (From update of attachment 208422) Clearing flags on attachment: 208422 Committed r153888: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:26:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:26:14 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #21 from Build Bot 2013-08-09 06:25:51 PST --- Created an attachment (id=208427) --> (https://bugs.webkit.org/attachment.cgi?id=208427&action=review) Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:26:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:26:14 -0700 Subject: [Webkit-unassigned] [Bug 119577] [Qt] REGRESSION(r153664): ThirdParty Angle build is broken. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119577 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from WebKit Commit Bot 2013-08-09 06:25:52 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:26:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:26:15 -0700 Subject: [Webkit-unassigned] [Bug 119452] ANGLE should be soft linked on Windows In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119452 Bug 119452 depends on bug 119577, which changed state. Bug 119577 Summary: [Qt] REGRESSION(r153664): ThirdParty Angle build is broken. https://bugs.webkit.org/show_bug.cgi?id=119577 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:26:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:26:44 -0700 Subject: [Webkit-unassigned] [Bug 119627] New: ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) in WebCore::RenderGeometryMap::mapToContainer Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119627 Summary: ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) in WebCore::RenderGeometryMap::mapToContainer Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: reni at webkit.org Blocks: 116980 The failing test:
    This bug is probably related to https://bugs.webkit.org/show_bug.cgi?id=119626. Backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff56f53e4 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 342 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) bt #0 0x00007ffff56f53e4 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 #1 0x00007ffff48e8f0a in WebCore::RenderGeometryMap::mapToContainer (this=0x7fffffffc3b0, rect=..., container=0x0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderGeometryMap.cpp:142 #2 0x00007ffff487a949 in WebCore::RenderBox::outlineBoundsForRepaint (this=0x8b3928, repaintContainer=0x0, geometryMap=0x7fffffffc3b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBox.cpp:551 #3 0x00007ffff4908006 in WebCore::RenderLayer::computeRepaintRects (this=0x899868, repaintContainer=0x0, geometryMap=0x7fffffffc3b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderLayer.cpp:731 #4 0x00007ffff49072f6 in WebCore::RenderLayer::updateLayerPositions (this=0x899868, geometryMap=0x7fffffffc3b0, flags=13) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderLayer.cpp:460 #5 0x00007ffff4907563 in WebCore::RenderLayer::updateLayerPositions (this=0x7b12a8, geometryMap=0x7fffffffc3b0, flags=13) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderLayer.cpp:499 #6 0x00007ffff4907563 in WebCore::RenderLayer::updateLayerPositions (this=0x76fd58, geometryMap=0x7fffffffc3b0, flags=13) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderLayer.cpp:499 #7 0x00007ffff490708b in WebCore::RenderLayer::updateLayerPositionsAfterLayout (this=0x76fd58, rootLayer=0x76fd58, flags=13) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderLayer.cpp:414 #8 0x00007ffff467a7a9 in WebCore::FrameView::layout (this=0x774790, allowSubtree=true) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/page/FrameView.cpp:1354 #9 0x00007ffff41b2e8f in WebCore::Document::implicitClose (this=0x87be80) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:2452 #10 0x00007ffff45b349f in WebCore::FrameLoader::checkCallImplicitClose (this=0x7b0ad8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:844 #11 0x00007ffff45b3210 in WebCore::FrameLoader::checkCompleted (this=0x7b0ad8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:787 #12 0x00007ffff45b2f45 in WebCore::FrameLoader::finishedParsing (this=0x7b0ad8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:720 #13 0x00007ffff41b9e35 in WebCore::Document::finishedParsing (this=0x87be80) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:4427 #14 0x00007ffff440ce97 in WebCore::HTMLConstructionSite::finishedParsing (this=0x7f3238) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLConstructionSite.cpp:348 #15 0x00007ffff44415b9 in WebCore::HTMLTreeBuilder::finished (this=0x7f3220) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2926 #16 0x00007ffff4414596 in WebCore::HTMLDocumentParser::end (this=0x775060) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:763 #17 0x00007ffff4414681 in WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd (this=0x775060) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:774 #18 0x00007ffff44131f0 in WebCore::HTMLDocumentParser::prepareToStopParsing (this=0x775060) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:211 #19 0x00007ffff44146c6 in WebCore::HTMLDocumentParser::attemptToEnd (this=0x775060) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:786 #20 0x00007ffff441477f in WebCore::HTMLDocumentParser::finish (this=0x775060) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:835 #21 0x00007ffff45aada5 in WebCore::DocumentWriter::end (this=0x694190) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentWriter.cpp:248 #22 0x00007ffff459d8e4 in WebCore::DocumentLoader::finishedLoading (this=0x6940f0, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:402 #23 0x00007ffff459d652 in WebCore::DocumentLoader::notifyFinished (this=0x6940f0, resource=0x7a9650) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:344 #24 0x00007ffff4584948 in WebCore::CachedResource::checkNotify (this=0x7a9650) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:369 #25 0x00007ffff4584a1e in WebCore::CachedResource::finishLoading (this=0x7a9650) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:385 #26 0x00007ffff4581170 in WebCore::CachedRawResource::finishLoading (this=0x7a9650, data=0x77b9b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedRawResource.cpp:94 #27 0x00007ffff45e7765 in WebCore::SubresourceLoader::didFinishLoading (this=0x7aa990, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/SubresourceLoader.cpp:282 #28 0x00007ffff45de04f in WebCore::ResourceLoader::didFinishLoading (this=0x7aa990, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/ResourceLoader.cpp:488 #29 0x00007ffff4a878e3 in WebCore::QNetworkReplyHandler::finish (this=0x79a560) ---Type to continue, or q to quit--- at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:516 #30 0x00007ffff4a86602 in WebCore::QNetworkReplyHandlerCallQueue::flush (this=0x79a598) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:250 #31 0x00007ffff4a862ff in WebCore::QNetworkReplyHandlerCallQueue::push (this=0x79a598, method=(void (WebCore::QNetworkReplyHandler::*)(WebCore::QNetworkReplyHandler * const)) 0x7ffff4a87728 ) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:216 #32 0x00007ffff4a8724c in WebCore::QNetworkReplyWrapper::didReceiveFinished (this=0x79a500) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:409 #33 0x00007ffff4a89bde in WebCore::QNetworkReplyWrapper::qt_static_metacall (_o=0x79a500, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffffffcf80) at .moc/release-shared/moc_QNetworkReplyHandler.cpp:176 #34 0x00007ffff22115cb in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #35 0x00007ffff221284e in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #36 0x00007ffff3058dbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #37 0x00007ffff305c075 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #38 0x00007ffff21ecdbe in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #39 0x00007ffff21eea76 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #40 0x00007ffff2234333 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #41 0x00007fffee3790a6 in g_main_dispatch (context=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3058 #42 g_main_context_dispatch (context=context at entry=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3634 #43 0x00007fffee3793f8 in g_main_context_iterate (context=context at entry=0x6632f0, block=block at entry=1, dispatch=dispatch at entry=1, self=) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3705 #44 0x00007fffee37949c in g_main_context_iteration (context=0x6632f0, may_block=1) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3766 #45 0x00007ffff22344bc in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #46 0x00007ffff21ebd3b in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #47 0x00007ffff21ef120 in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #48 0x0000000000421ba0 in launcherMain (app=...) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:49 #49 0x0000000000423680 in main (argc=2, argv=0x7fffffffdc58) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:318 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:26:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:26:46 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119627 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:27:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:27:21 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Bug 116980 depends on bug 113217, which changed state. Bug 113217 Summary: ASSERT(m_type == toSVGTransform.type()) https://bugs.webkit.org/show_bug.cgi?id=113217 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:27:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:27:25 -0700 Subject: [Webkit-unassigned] [Bug 119627] ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) in WebCore::RenderGeometryMap::mapToContainer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119627 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com, | |simon.fraser at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:27:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:27:48 -0700 Subject: [Webkit-unassigned] [Bug 119627] ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) in WebCore::RenderGeometryMap::mapToContainer In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119627 --- Comment #1 from Renata Hodovan 2013-08-09 06:27:26 PST --- Created an attachment (id=208428) --> (https://bugs.webkit.org/attachment.cgi?id=208428&action=review) Test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:27:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:27:49 -0700 Subject: [Webkit-unassigned] [Bug 105314] [Qt] Flash inside QML WebView doesn't receive mouse clicks In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=105314 Peter Rullmann changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |peter.rullmann at barco.com --- Comment #4 from Peter Rullmann 2013-08-09 06:27:27 PST --- I can confirm that this bug is still there in Qt5.1. Please let me know if I can help, test something or provide debug information. There is also a report for this bug in the Qt bug tracker: [QTBUG-32629|https://bugreports.qt-project.org/browse/QTBUG-32629] -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:29:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:29:02 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Bug 116980 depends on bug 113224, which changed state. Bug 113224 Summary: ASSERT_NOT_REACHED() touched in WebCore::SVGAnimatedStringAnimator::addAnimatedTypes https://bugs.webkit.org/show_bug.cgi?id=113224 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|REOPENED |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:29:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:29:03 -0700 Subject: [Webkit-unassigned] [Bug 116537] can no longer veto the showing of WebKitGTK's default authentication prompter In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116537 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WONTFIX -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:30:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:30:24 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Bug 116980 depends on bug 113224, which changed state. Bug 113224 Summary: ASSERT_NOT_REACHED() touched in WebCore::SVGAnimatedStringAnimator::addAnimatedTypes https://bugs.webkit.org/show_bug.cgi?id=113224 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution|FIXED | Status|RESOLVED |REOPENED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:34:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:34:56 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Javier Fernandez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208425|0 |1 is obsolete| | Attachment #208425|review?, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:35:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:35:04 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Javier Fernandez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208429| |review?, commit-queue? Flag| | --- Comment #8 from Javier Fernandez 2013-08-09 06:34:42 PST --- Created an attachment (id=208429) --> (https://bugs.webkit.org/attachment.cgi?id=208429&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:38:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:38:52 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208429|commit-queue? |commit-queue- Flag| | --- Comment #9 from Build Bot 2013-08-09 06:38:30 PST --- (From update of attachment 208429) Attachment 208429 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1385270 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:41:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:41:54 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 --- Comment #10 from Build Bot 2013-08-09 06:41:31 PST --- (From update of attachment 208429) Attachment 208429 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1369695 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:42:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:42:04 -0700 Subject: [Webkit-unassigned] [Bug 108616] [SH4] Build fails after r141543. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108616 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE --- Comment #2 from Julien Brianceau 2013-08-09 06:41:42 PST --- *** This bug has been marked as a duplicate of bug 108862 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:45:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:45:39 -0700 Subject: [Webkit-unassigned] [Bug 119628] New: Canvas blending tests should test both accelerated and non accelerated modes Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119628 Summary: Canvas blending tests should test both accelerated and non accelerated modes Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Canvas AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mitica at adobe.com Modify the tests from https://bugs.webkit.org/show_bug.cgi?id=119082 to test canvas blending with both accelerated and non accelerated 2d canvas context. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:46:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:46:46 -0700 Subject: [Webkit-unassigned] [Bug 119625] [Performance]making HTMLSelectElement::usesMenuList() inline In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119625 Santosh Mahto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208430| |review? Flag| | --- Comment #1 from Santosh Mahto 2013-08-09 06:46:24 PST --- Created an attachment (id=208430) --> (https://bugs.webkit.org/attachment.cgi?id=208430&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 06:59:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 06:59:51 -0700 Subject: [Webkit-unassigned] [Bug 119628] Canvas blending tests should test both accelerated and non accelerated modes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119628 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208431| |review? Flag| | --- Comment #1 from Mihai Tica 2013-08-09 06:59:29 PST --- Created an attachment (id=208431) --> (https://bugs.webkit.org/attachment.cgi?id=208431&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:00:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:00:15 -0700 Subject: [Webkit-unassigned] [Bug 119628] Canvas blending tests should test both accelerated and non accelerated modes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119628 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208431| |commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:00:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:00:27 -0700 Subject: [Webkit-unassigned] [Bug 119628] Canvas blending tests should test both accelerated and non accelerated modes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119628 Mihai Tica changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |WebkitBugTracker at adobe.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:00:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:00:40 -0700 Subject: [Webkit-unassigned] [Bug 119303] [GTK] Add enable_credential_store option In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119303 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |brian.holt at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:00:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:00:54 -0700 Subject: [Webkit-unassigned] [Bug 119487] [Gtk] Cancel authentication on load failed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119487 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |brian.holt at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:13:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:13:02 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #22 from Build Bot 2013-08-09 07:12:38 PST --- (From update of attachment 208423) Attachment 208423 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1405211 New failing tests: canvas/philip/tests/2d.text.measure.width.space.html fast/canvas/canvas-fillText-ideographicSpace.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:13:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:13:07 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #23 from Build Bot 2013-08-09 07:12:43 PST --- Created an attachment (id=208432) --> (https://bugs.webkit.org/attachment.cgi?id=208432&action=review) Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:23:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:23:38 -0700 Subject: [Webkit-unassigned] [Bug 119629] New: Move StyleResolver static functions to Style namespace Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Summary: Move StyleResolver static functions to Style namespace Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: koivisto at iki.fi Shrink down StyleResolver. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:25:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:25:54 -0700 Subject: [Webkit-unassigned] [Bug 119487] [Gtk] Cancel authentication on load failed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119487 Brian Holt changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|brian.holt at samsung.com |webkit-unassigned at lists.web | |kit.org CC| |a.obzhirov at samsung.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:32:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:32:12 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 --- Comment #11 from Sergio Villar Senin 2013-08-09 07:31:50 PST --- (From update of attachment 208429) View in context: https://bugs.webkit.org/attachment.cgi?id=208429&action=review Not really my field of expertise, just doing an informal general review. > Source/WebCore/rendering/RenderView.cpp:782 > + bool cond = os && os != stop; Do not use "cond", use a more descriptive name. > Source/WebCore/rendering/RenderView.cpp:849 > + cond = o && o != stop; Ditto. > Source/WebCore/rendering/RenderView.cpp:873 > + } The code looks exactly the same than the above, would it be possible to refactor it in some function? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:55:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:55:31 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 --- Comment #5 from Zalan Bujtas 2013-08-09 07:55:09 PST --- (From update of attachment 208178) View in context: https://bugs.webkit.org/attachment.cgi?id=208178&action=review >> Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.h:62 >> + inline bool validateBinding() const { return !enabled || (enabled && isBound()); } > > Second check should be enough here. Do you need the second enabled? (if enabled is false, the second part of the condition does not get evaluated, while if enabled is true, then it doesnt bring much value to the second part of the condition) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:56:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:56:28 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Bug 116980 depends on bug 113224, which changed state. Bug 113224 Summary: ASSERT_NOT_REACHED() touched in WebCore::SVGAnimatedStringAnimator::addAnimatedTypes https://bugs.webkit.org/show_bug.cgi?id=113224 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|REOPENED |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 07:59:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 07:59:20 -0700 Subject: [Webkit-unassigned] [Bug 79668] [Qt] Meta bug to fix crashes/assertions/timeouts In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=79668 Bug 79668 depends on bug 94345, which changed state. Bug 94345 Summary: [Qt][WK2] Accelerated compositing example with links being animated crashes tap highlight https://bugs.webkit.org/show_bug.cgi?id=94345 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:00:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:00:47 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 --- Comment #12 from EFL EWS Bot 2013-08-09 08:00:24 PST --- (From update of attachment 208429) Attachment 208429 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1353465 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:06:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:06:06 -0700 Subject: [Webkit-unassigned] [Bug 119630] New: ASSERTION FAILED: !m_frame->page()->defersLoading() || InspectorInstrumentation::isDebuggerPaused(m_frame) in WebCore::DocumentLoader::finishedLoading Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119630 Summary: ASSERTION FAILED: !m_frame->page()->defersLoading() || InspectorInstrumentation::isDebuggerPaused(m_frame) in WebCore::DocumentLoader::finishedLoading Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Page Loading AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: reni at webkit.org Blocks: 116980 The test causes the crash: Reproduction steps: 1) Load the test. 2) Click 'OK' on the alert message. 3) Refresh. Backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff56f53e4 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 342 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) bt #0 0x00007ffff56f53e4 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 #1 0x00007ffff459d749 in WebCore::DocumentLoader::finishedLoading (this=0xa82020, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:361 #2 0x00007ffff459d652 in WebCore::DocumentLoader::notifyFinished (this=0xa82020, resource=0x89a620) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:344 #3 0x00007ffff45851c0 in WebCore::CachedResource::didAddClient (this=0x89a620, c=0xa82020) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:499 #4 0x00007ffff4581635 in WebCore::CachedRawResource::didAddClient (this=0x89a620, c=0xa82020) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedRawResource.cpp:140 #5 0x00007ffff4586c84 in WebCore::CachedResource::CachedResourceCallback::timerFired (this=0xa7ddc0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:914 #6 0x00007ffff458cc49 in WebCore::Timer::fired (this=0xa7ddd0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/Timer.h:114 #7 0x00007ffff47b2724 in WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x6e4510) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/ThreadTimers.cpp:129 #8 0x00007ffff47b2611 in WebCore::ThreadTimers::sharedTimerFired () at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/ThreadTimers.cpp:105 #9 0x00007ffff4aac8e8 in WebCore::SharedTimerQt::timerEvent (this=0x6e4540, ev=0x7fffffffb1f0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/qt/SharedTimerQt.cpp:113 #10 0x00007ffff221266c in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #11 0x00007ffff3058dbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #12 0x00007ffff305c075 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #13 0x00007ffff21ecdbe in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #14 0x00007ffff223375c in QTimerInfoList::activateTimers() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #15 0x00007ffff2234094 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #16 0x00007fffee3790a6 in g_main_dispatch (context=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3058 #17 g_main_context_dispatch (context=context at entry=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3634 #18 0x00007fffee3793f8 in g_main_context_iterate (context=context at entry=0x6632f0, block=block at entry=1, dispatch=dispatch at entry=1, self=) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3705 #19 0x00007fffee37949c in g_main_context_iteration (context=0x6632f0, may_block=1) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3766 #20 0x00007ffff22344bc in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #21 0x00007ffff21ebd3b in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #22 0x00007ffff321381b in QDialog::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #23 0x00007ffff7bb0da1 in QWebPage::javaScriptAlert (this=0x743ef0, frame=0x70aea0, msg=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebKit/qt/WidgetApi/qwebpage.cpp:1516 #24 0x00007ffff7bae058 in QWebPagePrivate::javaScriptAlert (this=0x7409e0, frame=0x7b1fe0, msg=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebKit/qt/WidgetApi/qwebpage.cpp:288 #25 0x00007ffff3b85fb5 in WebCore::ChromeClientQt::runJavaScriptAlert (this=0x740d10, f=0x7b0c10, msg=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:343 #26 0x00007ffff4619ce6 in WebCore::Chrome::runJavaScriptAlert (this=0x743fc0, frame=0x7b0c10, message=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/page/Chrome.cpp:322 #27 0x00007ffff463b8eb in WebCore::DOMWindow::alert (this=0x89c410, message=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/page/DOMWindow.cpp:1055 ---Type to continue, or q to quit--- #28 0x00007ffff50a4127 in WebCore::jsDOMWindowPrototypeFunctionAlert (exec=0x7fffe409b0a8) at generated/JSDOMWindow.cpp:14480 #29 0x00007fff9ffff0e5 in ?? () #30 0x00007fffffffb840 in ?? () #31 0x00007ffff6812b14 in llint_op_call () from /home/reni/Data/REPOS/webkit_sec/WebKitBuild/Debug/lib/libQt5WebKit.so.5 #32 0x00007fffffffb7f0 in ?? () #33 0x00007ffff554cae5 in JSC::JSStack::installTrapsAfterFrame (this=0x0, frame=0x0) at /home/reni/Data/REPOS/webkit_sec/Source/JavaScriptCore/interpreter/JSStackInlines.h:212 #34 0x00007ffff555d7b4 in JSC::JITCode::execute (this=0xa7dd70, stack=0x7b5e08, callFrame=0x7fffe409b058, vm=0x7f8300) at /home/reni/Data/REPOS/webkit_sec/Source/JavaScriptCore/jit/JITCode.cpp:46 #35 0x00007ffff554936b in JSC::Interpreter::execute (this=0x7b5df0, program=0x7fff8638fe70, callFrame=0x7fff9c03f4e0, thisObj=0x7fffe402ffd8) at /home/reni/Data/REPOS/webkit_sec/Source/JavaScriptCore/interpreter/Interpreter.cpp:851 #36 0x00007ffff5628362 in JSC::evaluate (exec=0x7fff9c03f4e0, source=..., thisValue=..., returnedException=0x7fffffffc540) at /home/reni/Data/REPOS/webkit_sec/Source/JavaScriptCore/runtime/Completion.cpp:83 #37 0x00007ffff3f6abe3 in WebCore::JSMainThreadExecState::evaluate (exec=0x7fff9c03f4e0, source=..., thisValue=..., exception=0x7fffffffc540) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/bindings/js/JSMainThreadExecState.h:74 #38 0x00007ffff3f89192 in WebCore::ScriptController::evaluateInWorld (this=0x774400, sourceCode=..., world=0x76e220) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/bindings/js/ScriptController.cpp:142 #39 0x00007ffff3f89298 in WebCore::ScriptController::evaluate (this=0x774400, sourceCode=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/bindings/js/ScriptController.cpp:158 #40 0x00007ffff427748d in WebCore::ScriptElement::executeScript (this=0xa7e5e8, sourceCode=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/ScriptElement.cpp:316 #41 0x00007ffff4276c68 in WebCore::ScriptElement::prepareScript (this=0xa7e5e8, scriptStartPosition=..., supportLegacyTypes=WebCore::ScriptElement::DisallowLegacyTypeInTypeAttribute) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/ScriptElement.cpp:245 #42 0x00007ffff4426e4d in WebCore::HTMLScriptRunner::runScript (this=0x773cf0, script=0xa7e580, scriptStartPosition=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLScriptRunner.cpp:312 #43 0x00007ffff442659e in WebCore::HTMLScriptRunner::execute (this=0x773cf0, scriptElement=..., scriptStartPosition=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLScriptRunner.cpp:181 #44 0x00007ffff44134a9 in WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder (this=0x73b3d0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:271 #45 0x00007ffff4413594 in WebCore::HTMLDocumentParser::canTakeNextToken (this=0x73b3d0, mode=WebCore::HTMLDocumentParser::AllowYield, session=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:290 #46 0x00007ffff4413bac in WebCore::HTMLDocumentParser::pumpTokenizer (this=0x73b3d0, mode=WebCore::HTMLDocumentParser::AllowYield) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:535 #47 0x00007ffff4413317 in WebCore::HTMLDocumentParser::pumpTokenizerIfPossible (this=0x73b3d0, mode=WebCore::HTMLDocumentParser::AllowYield) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:235 #48 0x00007ffff44144b6 in WebCore::HTMLDocumentParser::append (this=0x73b3d0, inputSource=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:747 #49 0x00007ffff41a5099 in WebCore::DecodedDataDocumentParser::flush (this=0x73b3d0, writer=0x8985b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/DecodedDataDocumentParser.cpp:60 #50 0x00007ffff45aad6b in WebCore::DocumentWriter::end (this=0x8985b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentWriter.cpp:245 #51 0x00007ffff459d8e4 in WebCore::DocumentLoader::finishedLoading (this=0x898510, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:402 ---Type to continue, or q to quit--- #52 0x00007ffff459d652 in WebCore::DocumentLoader::notifyFinished (this=0x898510, resource=0xa711c0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:344 #53 0x00007ffff4584948 in WebCore::CachedResource::checkNotify (this=0xa711c0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:369 #54 0x00007ffff4584a1e in WebCore::CachedResource::finishLoading (this=0xa711c0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:385 #55 0x00007ffff4581170 in WebCore::CachedRawResource::finishLoading (this=0xa711c0, data=0x88b630) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedRawResource.cpp:94 #56 0x00007ffff45e7765 in WebCore::SubresourceLoader::didFinishLoading (this=0x895160, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/SubresourceLoader.cpp:282 #57 0x00007ffff45de04f in WebCore::ResourceLoader::didFinishLoading (this=0x895160, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/ResourceLoader.cpp:488 #58 0x00007ffff4a878e3 in WebCore::QNetworkReplyHandler::finish (this=0xa72dd0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:516 #59 0x00007ffff4a86602 in WebCore::QNetworkReplyHandlerCallQueue::flush (this=0xa72e08) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:250 #60 0x00007ffff4a862ff in WebCore::QNetworkReplyHandlerCallQueue::push (this=0xa72e08, method=(void (WebCore::QNetworkReplyHandler::*)(WebCore::QNetworkReplyHandler * const)) 0x7ffff4a87728 ) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:216 #61 0x00007ffff4a8724c in WebCore::QNetworkReplyWrapper::didReceiveFinished (this=0x865d50) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:409 #62 0x00007ffff4a89bde in WebCore::QNetworkReplyWrapper::qt_static_metacall (_o=0x865d50, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffffffcf90) at .moc/release-shared/moc_QNetworkReplyHandler.cpp:176 #63 0x00007ffff22115cb in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #64 0x00007ffff221284e in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #65 0x00007ffff3058dbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #66 0x00007ffff305c075 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #67 0x00007ffff21ecdbe in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #68 0x00007ffff21eea76 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #69 0x00007ffff2234333 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #70 0x00007fffee3790a6 in g_main_dispatch (context=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3058 #71 g_main_context_dispatch (context=context at entry=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3634 #72 0x00007fffee3793f8 in g_main_context_iterate (context=context at entry=0x6632f0, block=block at entry=1, dispatch=dispatch at entry=1, self=) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3705 #73 0x00007fffee37949c in g_main_context_iteration (context=0x6632f0, may_block=1) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3766 #74 0x00007ffff22344bc in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #75 0x00007ffff21ebd3b in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #76 0x00007ffff21ef120 in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #77 0x0000000000421ba0 in launcherMain (app=...) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:49 #78 0x0000000000423680 in main (argc=2, argv=0x7fffffffdc68) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:318 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:06:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:06:08 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119630 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:06:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:06:22 -0700 Subject: [Webkit-unassigned] [Bug 119630] ASSERTION FAILED: !m_frame->page()->defersLoading() || InspectorInstrumentation::isDebuggerPaused(m_frame) in WebCore::DocumentLoader::finishedLoading In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119630 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |japhet at chromium.org, | |koivisto at iki.fi -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:07:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:07:18 -0700 Subject: [Webkit-unassigned] [Bug 119630] ASSERTION FAILED: !m_frame->page()->defersLoading() || InspectorInstrumentation::isDebuggerPaused(m_frame) in WebCore::DocumentLoader::finishedLoading In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119630 --- Comment #1 from Renata Hodovan 2013-08-09 08:06:57 PST --- Created an attachment (id=208434) --> (https://bugs.webkit.org/attachment.cgi?id=208434&action=review) Test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:11:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:11:41 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208435| |review? Flag| | --- Comment #1 from Antti Koivisto 2013-08-09 08:11:19 PST --- Created an attachment (id=208435) --> (https://bugs.webkit.org/attachment.cgi?id=208435&action=review) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:11:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:11:55 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:16:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:16:42 -0700 Subject: [Webkit-unassigned] [Bug 114550] [GTK] Unable to build with --disable-webgl. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114550 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID --- Comment #8 from Zan Dobersek 2013-08-09 08:16:20 PST --- I can't reproduce this problem using WebKitGTK+ 2.0.0 and passing the same configuration flags. Diffing my config.log with the config.log from attachment #198179 doesn't show any substantial differences either. I'm closing this bug, but feel free to reopen it if you get this problem again, especially when using the latest stable version (= 2.0.4) and during a clean build with these configuration flags. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:19:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:19:05 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208435|0 |1 is obsolete| | Attachment #208435|review? | Flag| | Attachment #208436| |review? Flag| | --- Comment #2 from Antti Koivisto 2013-08-09 08:18:44 PST --- Created an attachment (id=208436) --> (https://bugs.webkit.org/attachment.cgi?id=208436&action=review) rebased The patch is big because StyleResolver.cpp was svn cp'd to keep history. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:27:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:27:49 -0700 Subject: [Webkit-unassigned] [Bug 119632] New: [CSS Grid Layout] Resolve named grid lines Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119632 Summary: [CSS Grid Layout] Resolve named grid lines Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: svillar at igalia.com Depends on: 119540 Blocks: 103310 The patch for bug 119540 will add parsing support for named grid lines. That's the first step, after that we need to use that information to properly position the different elements in the grid. This was done in Blink in: r152659 Properly resolve named grid lines This change adds the code to convert from a raw named grid line (stored in RenderStyle) to its actual grid position. and r153794 [CSS Grid Layout] Support named grid lines with 'span' This change implements the resolution for named grid lines with 'span', which is the missing piece to fully support named grid lines. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:27:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:27:49 -0700 Subject: [Webkit-unassigned] [Bug 119540] [CSS Grid Layout] Add parsing for named grid lines In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119540 Sergio Villar Senin changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119632 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:27:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:27:51 -0700 Subject: [Webkit-unassigned] [Bug 103310] [CSS Grid Layout] Support naming grid tracks In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=103310 Sergio Villar Senin changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119632 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:28:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:28:54 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 --- Comment #13 from EFL EWS Bot 2013-08-09 08:28:31 PST --- (From update of attachment 208429) Attachment 208429 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1414369 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:32:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:32:51 -0700 Subject: [Webkit-unassigned] [Bug 119585] [EFL] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119585 Raphael Kubo da Costa (:rakuco) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakuco at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:42:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:42:06 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 --- Comment #14 from Qt Early Warning System Bot 2013-08-09 08:41:43 PST --- (From update of attachment 208429) Attachment 208429 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1399219 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:43:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:43:16 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 --- Comment #15 from Qt Early Warning System Bot 2013-08-09 08:42:53 PST --- (From update of attachment 208429) Attachment 208429 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1350447 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:57:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:57:58 -0700 Subject: [Webkit-unassigned] [Bug 101047] REGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=101047 --- Comment #13 from Zalan Bujtas 2013-08-09 08:57:34 PST --- Created an attachment (id=208438) --> (https://bugs.webkit.org/attachment.cgi?id=208438&action=review) test reduction It seems that -webkit-backface-visibility has some side effect here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 08:58:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 08:58:44 -0700 Subject: [Webkit-unassigned] [Bug 119059] [GTK] Media player slider position is not consistent In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119059 Danilo Cesar Lemes de Paula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WORKSFORME --- Comment #1 from Danilo Cesar Lemes de Paula 2013-08-09 08:58:22 PST --- Couldn't be replicated on MiniBrowser anymore. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 09:30:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 09:30:47 -0700 Subject: [Webkit-unassigned] [Bug 119626] ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) in WebCore::RenderGeometryMap::mapToContainer with very tall content In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119626 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SSERTION FAILED: |ASSERTION FAILED: |roundedIntPoint(rendererMap |roundedIntPoint(rendererMap |pedResult) == |pedResult) == |roundedIntPoint(result) in |roundedIntPoint(result) in |WebCore::RenderGeometryMap: |WebCore::RenderGeometryMap: |:mapToContainer |:mapToContainer with very | |tall content -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 09:35:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 09:35:34 -0700 Subject: [Webkit-unassigned] [Bug 101047] REGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=101047 --- Comment #14 from Simon Fraser (smfr) 2013-08-09 09:35:11 PST --- Feels a bit similar to bug 115991. Got a regression range? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 09:42:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 09:42:29 -0700 Subject: [Webkit-unassigned] [Bug 119623] ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119623 Rob Buis changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rwlbuis at gmail.com |kit.org | CC| |rwlbuis at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:03:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:03:17 -0700 Subject: [Webkit-unassigned] [Bug 119078] [GTK] [EFL] Enable tiled shadow blur for the inset shadows. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119078 Alejandro G. Castro changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Alejandro G. Castro 2013-08-09 10:02:55 PST --- (In reply to comment #5) > (From update of attachment 207927 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207927&action=review > > > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1056 > > + if (this->mustUseShadowBlur()) > > + platformContext()->shadowBlur().drawInsetShadow(this, rect, roundedHoleRect.rect(), roundedHoleRect.radii()); > > You could even move this above the path manipulation, I think. Yeah, I've modified the patch before landing, thanks. http://trac.webkit.org/changeset/142608 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:10:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:10:08 -0700 Subject: [Webkit-unassigned] [Bug 119628] Canvas blending tests should test both accelerated and non accelerated modes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119628 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208431|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #2 from Dirk Schulze 2013-08-09 10:09:47 PST --- (From update of attachment 208431) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:10:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:10:44 -0700 Subject: [Webkit-unassigned] [Bug 119628] Canvas blending tests should test both accelerated and non accelerated modes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119628 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:14:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:14:35 -0700 Subject: [Webkit-unassigned] [Bug 101047] REGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=101047 --- Comment #15 from Zalan Bujtas 2013-08-09 10:14:13 PST --- (In reply to comment #14) > Feels a bit similar to bug 115991. Got a regression range? It's not a regression afaict. Oddly, subpixel layout makes this issue hidden, so you can't repro it starting from http://trac.webkit.org/changeset/133351 up until http://trac.webkit.org/changeset/149208, when we disabled subpixel layout (at r149209) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:21:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:21:27 -0700 Subject: [Webkit-unassigned] [Bug 67079] Replace usages of Vector with existing StringBuilder In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=67079 --- Comment #19 from Adam Barth 2013-08-09 10:21:03 PST --- (From update of attachment 106540) View in context: https://bugs.webkit.org/attachment.cgi?id=106540&action=review > Source/WebCore/rendering/InlineTextBox.h:42 > -typedef Vector BufferForAppendingHyphen; > + > +class BufferForAppendingHyphen : public StringBuilder { > +public: > + BufferForAppendingHyphen() { reserveCapacity(256); } > +}; Pre-allocating 256 characters in a StringBuilder is not nearly as efficient as reserving 256 characters of inline capacity in a Vector. This change caused https://code.google.com/p/chromium/issues/detail?id=270678. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:21:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:21:33 -0700 Subject: [Webkit-unassigned] [Bug 67079] Replace usages of Vector with existing StringBuilder In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=67079 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abarth at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:31:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:31:14 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208436|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:34:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:34:26 -0700 Subject: [Webkit-unassigned] [Bug 119628] Canvas blending tests should test both accelerated and non accelerated modes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119628 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208431|review+, commit-queue+ | Flag| | --- Comment #3 from WebKit Commit Bot 2013-08-09 10:34:04 PST --- (From update of attachment 208431) Clearing flags on attachment: 208431 Committed r153902: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:34:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:34:28 -0700 Subject: [Webkit-unassigned] [Bug 119628] Canvas blending tests should test both accelerated and non accelerated modes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119628 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from WebKit Commit Bot 2013-08-09 10:34:06 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:46:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:46:10 -0700 Subject: [Webkit-unassigned] [Bug 119625] [Performance]making HTMLSelectElement::usesMenuList() inline In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119625 Santosh Mahto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208430|0 |1 is obsolete| | Attachment #208430|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:46:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:46:19 -0700 Subject: [Webkit-unassigned] [Bug 119625] [Performance]making HTMLSelectElement::usesMenuList() inline In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119625 Santosh Mahto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208441| |review? Flag| | --- Comment #2 from Santosh Mahto 2013-08-09 10:45:57 PST --- Created an attachment (id=208441) --> (https://bugs.webkit.org/attachment.cgi?id=208441&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:48:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:48:11 -0700 Subject: [Webkit-unassigned] [Bug 101047] REGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=101047 --- Comment #16 from Alexey Proskuryakov 2013-08-09 10:47:49 PST --- There is a regression number right in the title, and I just re-tested that this is when the site regressed. The issue is 100% reproducible for me. The reduction fails in r132514, so it has to be less than 100% precise. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:51:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:51:54 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208436|0 |1 is obsolete| | --- Comment #3 from Antti Koivisto 2013-08-09 10:51:32 PST --- Created an attachment (id=208442) --> (https://bugs.webkit.org/attachment.cgi?id=208442&action=review) lets try without move -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:54:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:54:15 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org --- Comment #4 from WebKit Commit Bot 2013-08-09 10:53:54 PST --- Attachment 208442 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/html/HTMLLinkElement.cpp', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Source/WebCore/rendering/style/RenderStyle.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/style/StyleFontSizeFunctions.cpp', u'Source/WebCore/style/StyleFontSizeFunctions.h', u'Source/WebCore/style/StyleResolveForDocument.cpp', u'Source/WebCore/style/StyleResolveForDocument.h']" exit_code: 1 Source/WebCore/style/StyleFontSizeFunctions.cpp:109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:110: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:115: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:116: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:127: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/style/StyleFontSizeFunctions.cpp:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 16 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:59:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:59:44 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Qt Early Warning System Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |webkit-ews at sed.inf.u-szeged | |.hu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:59:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:59:49 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Qt Early Warning System Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208442| |commit-queue- Flag| | --- Comment #5 from Qt Early Warning System Bot 2013-08-09 10:59:27 PST --- (From update of attachment 208442) Attachment 208442 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1385327 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 10:59:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 10:59:57 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 --- Comment #6 from Qt Early Warning System Bot 2013-08-09 10:59:35 PST --- (From update of attachment 208442) Attachment 208442 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1413246 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:01:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:01:33 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:01:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:01:36 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 --- Comment #7 from Build Bot 2013-08-09 11:01:14 PST --- (From update of attachment 208442) Attachment 208442 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1353529 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:08:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:08:15 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 EFL EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eflews.bot at gmail.com, | |gyuyoung.kim at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:08:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:08:19 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 --- Comment #8 from EFL EWS Bot 2013-08-09 11:07:56 PST --- (From update of attachment 208442) Attachment 208442 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1401263 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:08:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:08:53 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Igalia EWS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philn at igalia.com, | |xan.lopez at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:10:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:10:00 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 kov's GTK+ EWS bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gtk-ews at kov.eti.br -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:10:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:10:05 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 --- Comment #9 from kov's GTK+ EWS bot 2013-08-09 11:09:41 PST --- (From update of attachment 208442) Attachment 208442 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1413251 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:16:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:16:16 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 --- Comment #10 from EFL EWS Bot 2013-08-09 11:15:53 PST --- (From update of attachment 208442) Attachment 208442 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1412236 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:17:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:17:28 -0700 Subject: [Webkit-unassigned] [Bug 67079] Replace usages of Vector with existing StringBuilder In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=67079 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com, | |benjamin at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:19:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:19:45 -0700 Subject: [Webkit-unassigned] [Bug 67079] Replace usages of Vector with existing StringBuilder In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=67079 --- Comment #20 from Darin Adler 2013-08-09 11:19:21 PST --- (In reply to comment #19) > (From update of attachment 106540 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106540&action=review > > > Source/WebCore/rendering/InlineTextBox.h:42 > > -typedef Vector BufferForAppendingHyphen; > > + > > +class BufferForAppendingHyphen : public StringBuilder { > > +public: > > + BufferForAppendingHyphen() { reserveCapacity(256); } > > +}; > > Pre-allocating 256 characters in a StringBuilder is not nearly as efficient as reserving 256 characters of inline capacity in a Vector. This change caused https://code.google.com/p/chromium/issues/detail?id=270678. Thanks for pointing that out. We should figure out what to do about this in WebKit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:23:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:23:44 -0700 Subject: [Webkit-unassigned] [Bug 119630] ASSERTION FAILED: !m_frame->page()->defersLoading() || InspectorInstrumentation::isDebuggerPaused(m_frame) in WebCore::DocumentLoader::finishedLoading In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119630 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org, | |beidson at apple.com, | |psolanki at apple.com, | |timothy at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:24:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:24:46 -0700 Subject: [Webkit-unassigned] [Bug 119484] [WK2] REGRESSION(r138378): Keyboard scrolling does not work with delegated scrolling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119484 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:26:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:26:46 -0700 Subject: [Webkit-unassigned] [Bug 90708] fullscreen/exit-full-screen-iframe.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=90708 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jer.noble at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:28:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:28:06 -0700 Subject: [Webkit-unassigned] [Bug 119581] URL query string mistakenly decoded when used in tag In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119581 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org, | |beidson at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:32:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:32:29 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 --- Comment #11 from Build Bot 2013-08-09 11:32:06 PST --- (From update of attachment 208442) Attachment 208442 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1405256 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:36:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:36:01 -0700 Subject: [Webkit-unassigned] [Bug 119625] [Performance]making HTMLSelectElement::usesMenuList() inline In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119625 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam at webkit.org --- Comment #3 from Sam Weinig 2013-08-09 11:35:39 PST --- Does this actually speed anything up? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:42:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:42:08 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208442|0 |1 is obsolete| | --- Comment #12 from Antti Koivisto 2013-08-09 11:41:45 PST --- Created an attachment (id=208443) --> (https://bugs.webkit.org/attachment.cgi?id=208443&action=review) build files and fixes -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:44:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:44:26 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Andreas Kling changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208443| |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:57:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:57:30 -0700 Subject: [Webkit-unassigned] [Bug 119625] [Performance]making HTMLSelectElement::usesMenuList() inline In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119625 Santosh Mahto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208441|0 |1 is obsolete| | Attachment #208441|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 11:57:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 11:57:42 -0700 Subject: [Webkit-unassigned] [Bug 119625] [Performance]making HTMLSelectElement::usesMenuList() inline In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119625 Santosh Mahto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208444| |review? Flag| | --- Comment #4 from Santosh Mahto 2013-08-09 11:57:20 PST --- Created an attachment (id=208444) --> (https://bugs.webkit.org/attachment.cgi?id=208444&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:00:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:00:35 -0700 Subject: [Webkit-unassigned] [Bug 108187] Assertion faulire in RenderObject::drawLineForBoxSide In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108187 Rob Buis changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rwlbuis at gmail.com |kit.org | CC| |rwlbuis at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:01:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:01:56 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208443| |commit-queue- Flag| | --- Comment #13 from Build Bot 2013-08-09 12:01:33 PST --- (From update of attachment 208443) Attachment 208443 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1359542 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:07:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:07:29 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 --- Comment #14 from Build Bot 2013-08-09 12:07:06 PST --- (From update of attachment 208443) Attachment 208443 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1412250 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:07:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:07:31 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Javier Fernandez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208429|0 |1 is obsolete| | Attachment #208429|review?, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:07:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:07:43 -0700 Subject: [Webkit-unassigned] [Bug 119622] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Javier Fernandez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208447| |review?, commit-queue? Flag| | --- Comment #16 from Javier Fernandez 2013-08-09 12:07:19 PST --- Created an attachment (id=208447) --> (https://bugs.webkit.org/attachment.cgi?id=208447&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:21:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:21:42 -0700 Subject: [Webkit-unassigned] [Bug 119635] New: Selection gap doesn't get cleared in vertical writing mode Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119635 Summary: Selection gap doesn't get cleared in vertical writing mode Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: hyatt at apple.com, simon.fraser at apple.com, dino at apple.com, enrica at apple.com Created an attachment (id=208448) --> (https://bugs.webkit.org/attachment.cgi?id=208448&action=review) Demo It appears that our code to repaint selection gap is broken in vertical writing mode -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:29:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:29:22 -0700 Subject: [Webkit-unassigned] [Bug 119635] Selection gap doesn't get cleared in vertical writing mode In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119635 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |webkit-bug-importer at group.a | |pple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:29:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:29:30 -0700 Subject: [Webkit-unassigned] [Bug 119635] Selection gap doesn't get cleared in vertical writing mode In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119635 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Radar WebKit Bug Importer 2013-08-09 12:29:08 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:32:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:32:53 -0700 Subject: [Webkit-unassigned] [Bug 119582] Crash due to DFG in jslinux In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119582 --- Comment #1 from Oliver Hunt 2013-08-09 12:32:30 PST --- Created an attachment (id=208449) --> (https://bugs.webkit.org/attachment.cgi?id=208449&action=review) Log dump So here's the log for the failing compile. I wonder if it's the switch that isn't doing the right thing? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:34:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:34:53 -0700 Subject: [Webkit-unassigned] [Bug 119582] Crash due to DFG in jslinux In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119582 --- Comment #2 from Oliver Hunt 2013-08-09 12:34:31 PST --- Here's the command i use to launch: JSC_enableConcurrentJIT=0 JSC_maximumInliningDepth=1 JSC_bytecodeRangeToDFGCompile=437:437 JSC_dumpBytecodeAtDFGTime=1 JSC_dumpGraphAtEachPhase=1 run-minibrowser and then ran gcc hello.c -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:37:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:37:11 -0700 Subject: [Webkit-unassigned] [Bug 119582] Crash due to DFG in jslinux In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119582 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #3 from Oliver Hunt 2013-08-09 12:36:49 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:37:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:37:12 -0700 Subject: [Webkit-unassigned] [Bug 119582] Crash due to DFG in jslinux In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119582 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|NeedsRadar | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:38:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:38:03 -0700 Subject: [Webkit-unassigned] [Bug 119582] Crash due to DFG in jslinux In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119582 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |webkit-bug-importer at group.a | |pple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:38:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:38:15 -0700 Subject: [Webkit-unassigned] [Bug 119582] Crash due to DFG in jslinux In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119582 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ggaren at apple.com, | |mhahnenberg at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 12:43:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 12:43:42 -0700 Subject: [Webkit-unassigned] [Bug 119629] Move StyleResolver static functions to Style namespace In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119629 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #15 from Antti Koivisto 2013-08-09 12:43:19 PST --- http://trac.webkit.org/changeset/153906 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 13:43:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 13:43:07 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #24 from Darin Adler 2013-08-09 13:42:44 PST --- (From update of attachment 208423) View in context: https://bugs.webkit.org/attachment.cgi?id=208423&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:98 > +// Spec : http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#space-character > +static inline bool isHTMLSpace(UChar c) > +{ > + return (c == 0x0009 || c == 0x000A || c == 0x000B || c == 0x000C || c == 0x000D); > +} This function already exists in HTMLParserIdioms.h and you should use the version from there instead of adding a new one. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 14:03:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 14:03:17 -0700 Subject: [Webkit-unassigned] [Bug 36412] [GTK] Crashes reproducibly in www.formula1.com with Adobe's Flash plugin In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=36412 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID --- Comment #2 from Gustavo Noronha (kov) 2013-08-09 14:02:55 PST --- I can't reproduce this anymore, no. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 14:04:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 14:04:52 -0700 Subject: [Webkit-unassigned] [Bug 80063] [GTK] Build is too sensitive to change in configuration options In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=80063 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #1 from Gustavo Noronha (kov) 2013-08-09 14:04:29 PST --- I believe we have managed to make this less of a problem after a lot of changes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 14:09:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 14:09:54 -0700 Subject: [Webkit-unassigned] [Bug 119431] A script on specific page causes a whole-browser crash In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119431 --- Comment #4 from Nick Heer 2013-08-09 14:09:31 PST --- Still seeing this in 8536.30.1, 538+ (r153882). Also occurs on http://thecamerastore.com; not sure what the overlap is. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 14:26:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 14:26:34 -0700 Subject: [Webkit-unassigned] [Bug 19506] When hitting 302 pages the originating page is saved to history rather than the redirected page In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=19506 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Component|Page Loading |History Ever Confirmed|0 |1 --- Comment #4 from Alexey Proskuryakov 2013-08-09 14:26:12 PST --- This still seems broken, possibly even regressed. The history doesn't contain any intermediate pages now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 9 14:32:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 9 Aug 2013 14:32:36 -0700 Subject: [Webkit-unassigned] [Bug 77538] 302 redirect for resources with cached location caches the redirect In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=77538 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|302 redirect for Backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff56fe985 in WTFCrash () at /home/reni2/data/REPOS/webkit/Source/WTF/wtf/Assertions.cpp:342 342 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) bt #0 0x00007ffff56fe985 in WTFCrash () at /home/reni2/data/REPOS/webkit/Source/WTF/wtf/Assertions.cpp:342 #1 0x00007ffff42a9fb7 in WebCore::ApplyStyleCommand::removeInlineStyleFromElement (this=0x8a9450, style=0x8a8cd0, element=..., mode=WebCore::ApplyStyleCommand::RemoveAlways, extractedStyle=0x0) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/ApplyStyleCommand.cpp:889 #2 0x00007ffff42a9d00 in WebCore::ApplyStyleCommand::removeConflictingInlineStyleFromRun (this=0x8a9450, style=0x8a8cd0, runStart=..., runEnd=..., pastEndNode=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/ApplyStyleCommand.cpp:868 #3 0x00007ffff42a95d8 in WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange (this=0x8a9450, style=0x8a8cd0, startNode=..., pastEndNode=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/ApplyStyleCommand.cpp:812 #4 0x00007ffff42a8b47 in WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle (this=0x8a9450, style=0x8a8cd0, start=..., end=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/ApplyStyleCommand.cpp:711 #5 0x00007ffff42a8763 in WebCore::ApplyStyleCommand::applyInlineStyle (this=0x8a9450, style=0x8a8cd0) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/ApplyStyleCommand.cpp:674 #6 0x00007ffff42a58ff in WebCore::ApplyStyleCommand::doApply (this=0x8a9450) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/ApplyStyleCommand.cpp:225 #7 0x00007ffff42b4f8a in WebCore::CompositeEditCommand::applyCommandToComposite (this=0x8a8d50, prpCommand=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/CompositeEditCommand.cpp:266 #8 0x00007ffff42b5275 in WebCore::CompositeEditCommand::applyStyledElement (this=0x8a8d50, element=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/CompositeEditCommand.cpp:297 #9 0x00007ffff42c1774 in WebCore::CreateLinkCommand::doApply (this=0x8a8d50) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/CreateLinkCommand.cpp:50 #10 0x00007ffff42b4d52 in WebCore::CompositeEditCommand::apply (this=0x8a8d50) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/CompositeEditCommand.cpp:215 #11 0x00007ffff42b4ada in WebCore::applyCommand (command=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/CompositeEditCommand.cpp:171 #12 0x00007ffff42e5c89 in WebCore::executeCreateLink (frame=0x7a27a0, value=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/EditorCommand.cpp:293 #13 0x00007ffff42e9e1a in WebCore::Editor::Command::execute (this=0x7fffffffbc20, parameter=..., triggeringEvent=0x0) at /home/reni2/data/REPOS/webkit/Source/WebCore/editing/EditorCommand.cpp:1706 #14 0x00007ffff41b93b2 in WebCore::Document::execCommand (this=0x7f4470, commandName=..., userInterface=false, value=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/dom/Document.cpp:4148 #15 0x00007ffff4ecd0c8 in WebCore::jsDocumentPrototypeFunctionExecCommand (exec=0x7fff9b3fd0b0) at generated/JSDocument.cpp:2748 #16 0x00007fff9bfff0e5 in ?? () #17 0x00007fffffffbdc0 in ?? () ---Type to continue, or q to quit--- #18 0x00007ffff68071d4 in llint_op_call () from /home/reni2/data/REPOS/webkit/WebKitBuild/Debug/lib/libQt5WebKit.so.5 #19 0x00007fffffffbd70 in ?? () #20 0x00007ffff5556017 in JSC::JSStack::installTrapsAfterFrame (this=0x0, frame=0x0) at /home/reni2/data/REPOS/webkit/Source/JavaScriptCore/interpreter/JSStackInlines.h:212 #21 0x00007ffff5566cea in JSC::JITCode::execute (this=0x86ef40, stack=0x788658, callFrame=0x7fff9b3fd058, vm=0x7de090) at /home/reni2/data/REPOS/webkit/Source/JavaScriptCore/jit/JITCode.cpp:46 #22 0x00007ffff555289d in JSC::Interpreter::execute (this=0x788640, program=0x7fff9a2afef0, callFrame=0x7fff9a3af8e0, thisObj=0x7fffe004ffd8) at /home/reni2/data/REPOS/webkit/Source/JavaScriptCore/interpreter/Interpreter.cpp:851 #23 0x00007ffff56318a5 in JSC::evaluate (exec=0x7fff9a3af8e0, source=..., thisValue=..., returnedException=0x7fffffffcac0) at /home/reni2/data/REPOS/webkit/Source/JavaScriptCore/runtime/Completion.cpp:83 #24 0x00007ffff3f6c4cb in WebCore::JSMainThreadExecState::evaluate (exec=0x7fff9a3af8e0, source=..., thisValue=..., exception=0x7fffffffcac0) at /home/reni2/data/REPOS/webkit/Source/WebCore/bindings/js/JSMainThreadExecState.h:74 #25 0x00007ffff3f8aa7a in WebCore::ScriptController::evaluateInWorld (this=0x785620, sourceCode=..., world=0x78f210) at /home/reni2/data/REPOS/webkit/Source/WebCore/bindings/js/ScriptController.cpp:142 #26 0x00007ffff3f8ab80 in WebCore::ScriptController::evaluate (this=0x785620, sourceCode=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/bindings/js/ScriptController.cpp:158 #27 0x00007ffff4275a13 in WebCore::ScriptElement::executeScript (this=0x862db8, sourceCode=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/dom/ScriptElement.cpp:316 #28 0x00007ffff42751ee in WebCore::ScriptElement::prepareScript (this=0x862db8, scriptStartPosition=..., supportLegacyTypes=WebCore::ScriptElement::DisallowLegacyTypeInTypeAttribute) at /home/reni2/data/REPOS/webkit/Source/WebCore/dom/ScriptElement.cpp:245 #29 0x00007ffff4425397 in WebCore::HTMLScriptRunner::runScript (this=0x77e010, script=0x862d50, scriptStartPosition=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/html/parser/HTMLScriptRunner.cpp:312 #30 0x00007ffff4424ae8 in WebCore::HTMLScriptRunner::execute (this=0x77e010, scriptElement=..., scriptStartPosition=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/html/parser/HTMLScriptRunner.cpp:181 #31 0x00007ffff44119f3 in WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder (this=0x77fb30) at /home/reni2/data/REPOS/webkit/Source/WebCore/html/parser/HTMLDocumentParser.cpp:271 #32 0x00007ffff4411ade in WebCore::HTMLDocumentParser::canTakeNextToken (this=0x77fb30, mode=WebCore::HTMLDocumentParser::AllowYield, session=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/html/parser/HTMLDocumentParser.cpp:290 #33 0x00007ffff44120f6 in WebCore::HTMLDocumentParser::pumpTokenizer (this=0x77fb30, mode=WebCore::HTMLDocumentParser::AllowYield) ---Type to continue, or q to quit--- at /home/reni2/data/REPOS/webkit/Source/WebCore/html/parser/HTMLDocumentParser.cpp:535 #34 0x00007ffff4411861 in WebCore::HTMLDocumentParser::pumpTokenizerIfPossible (this=0x77fb30, mode=WebCore::HTMLDocumentParser::AllowYield) at /home/reni2/data/REPOS/webkit/Source/WebCore/html/parser/HTMLDocumentParser.cpp:235 #35 0x00007ffff4412a00 in WebCore::HTMLDocumentParser::append (this=0x77fb30, inputSource=...) at /home/reni2/data/REPOS/webkit/Source/WebCore/html/parser/HTMLDocumentParser.cpp:747 #36 0x00007ffff41a55c9 in WebCore::DecodedDataDocumentParser::flush (this=0x77fb30, writer=0x6a6f30) at /home/reni2/data/REPOS/webkit/Source/WebCore/dom/DecodedDataDocumentParser.cpp:60 #37 0x00007ffff45aab37 in WebCore::DocumentWriter::end (this=0x6a6f30) at /home/reni2/data/REPOS/webkit/Source/WebCore/loader/DocumentWriter.cpp:245 #38 0x00007ffff459d6b0 in WebCore::DocumentLoader::finishedLoading (this=0x6a6e90, finishTime=0) at /home/reni2/data/REPOS/webkit/Source/WebCore/loader/DocumentLoader.cpp:402 #39 0x00007ffff459d41e in WebCore::DocumentLoader::notifyFinished (this=0x6a6e90, resource=0x785f00) at /home/reni2/data/REPOS/webkit/Source/WebCore/loader/DocumentLoader.cpp:344 #40 0x00007ffff4584714 in WebCore::CachedResource::checkNotify (this=0x785f00) at /home/reni2/data/REPOS/webkit/Source/WebCore/loader/cache/CachedResource.cpp:369 #41 0x00007ffff45847ea in WebCore::CachedResource::finishLoading (this=0x785f00) at /home/reni2/data/REPOS/webkit/Source/WebCore/loader/cache/CachedResource.cpp:385 #42 0x00007ffff4580f3c in WebCore::CachedRawResource::finishLoading (this=0x785f00, data=0x72d050) at /home/reni2/data/REPOS/webkit/Source/WebCore/loader/cache/CachedRawResource.cpp:94 #43 0x00007ffff45e7569 in WebCore::SubresourceLoader::didFinishLoading (this=0x784c30, finishTime=0) at /home/reni2/data/REPOS/webkit/Source/WebCore/loader/SubresourceLoader.cpp:282 #44 0x00007ffff45dde53 in WebCore::ResourceLoader::didFinishLoading (this=0x784c30, finishTime=0) at /home/reni2/data/REPOS/webkit/Source/WebCore/loader/ResourceLoader.cpp:488 #45 0x00007ffff4a888fd in WebCore::QNetworkReplyHandler::finish (this=0x78e9b0) at /home/reni2/data/REPOS/webkit/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:516 #46 0x00007ffff4a8761c in WebCore::QNetworkReplyHandlerCallQueue::flush (this=0x78e9e8) at /home/reni2/data/REPOS/webkit/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:250 #47 0x00007ffff4a87319 in WebCore::QNetworkReplyHandlerCallQueue::push (this=0x78e9e8, method=(void (WebCore::QNetworkReplyHandler::*)(WebCore::QNetworkReplyHandler * const)) 0x7ffff4a88742 ) at /home/reni2/data/REPOS/webkit/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:216 ---Type to continue, or q to quit--- #48 0x00007ffff4a88266 in WebCore::QNetworkReplyWrapper::didReceiveFinished (this=0x78b6a0) at /home/reni2/data/REPOS/webkit/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:409 #49 0x00007ffff4a8abf8 in WebCore::QNetworkReplyWrapper::qt_static_metacall (_o=0x78b6a0, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffffffd560) at .moc/release-shared/moc_QNetworkReplyHandler.cpp:175 #50 0x00007ffff21c70e1 in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #51 0x00007ffff21c873e in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #52 0x00007ffff301e1f4 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Widgets.so.5 #53 0x00007ffff30215d1 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Widgets.so.5 #54 0x00007ffff21a1a24 in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #55 0x00007ffff21a3961 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #56 0x00007ffff21e91f3 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #57 0x00007fffeecd8f05 in g_main_dispatch (context=0x664790) at /build/buildd/glib2.0-2.36.0/./glib/gmain.c:3054 #58 g_main_context_dispatch (context=context at entry=0x664790) at /build/buildd/glib2.0-2.36.0/./glib/gmain.c:3630 #59 0x00007fffeecd9248 in g_main_context_iterate (context=context at entry=0x664790, block=block at entry=1, dispatch=dispatch at entry=1, self=) at /build/buildd/glib2.0-2.36.0/./glib/gmain.c:3701 #60 0x00007fffeecd9304 in g_main_context_iteration (context=0x664790, may_block=1) at /build/buildd/glib2.0-2.36.0/./glib/gmain.c:3762 #61 0x00007ffff21e9634 in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #62 0x00007ffff21a08fb in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #63 0x00007ffff21a3e9e in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.1/lib/libQt5Core.so.5 #64 0x00000000004219f2 in launcherMain (app=...) at /home/reni2/data/REPOS/webkit/Tools/QtTestBrowser/qttestbrowser.cpp:50 #65 0x00000000004234d2 in main (argc=2, argv=0x7fffffffe278) at /home/reni2/data/REPOS/webkit/Tools/QtTestBrowser/qttestbrowser.cpp:319 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 01:21:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 01:21:35 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119672 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 01:25:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 01:25:36 -0700 Subject: [Webkit-unassigned] [Bug 119672] ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119672 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 01:25:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 01:25:56 -0700 Subject: [Webkit-unassigned] [Bug 119672] ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119672 --- Comment #1 from Renata Hodovan 2013-08-12 01:25:32 PST --- Created an attachment (id=208516) --> (https://bugs.webkit.org/attachment.cgi?id=208516&action=review) Test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 01:26:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 01:26:46 -0700 Subject: [Webkit-unassigned] [Bug 119672] ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119672 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |reni at webkit.org |kit.org | Attachment #208517| |review? Flag| | --- Comment #2 from Renata Hodovan 2013-08-12 01:26:22 PST --- Created an attachment (id=208517) --> (https://bugs.webkit.org/attachment.cgi?id=208517&action=review) Proposed patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 01:51:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 01:51:30 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Rashmi Shyamasundar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208514|0 |1 is obsolete| | Attachment #208514|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 01:51:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 01:51:43 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Rashmi Shyamasundar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208518| |review? Flag| | --- Comment #29 from Rashmi Shyamasundar 2013-08-12 01:51:18 PST --- Created an attachment (id=208518) --> (https://bugs.webkit.org/attachment.cgi?id=208518&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:16:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:16:20 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 Przemyslaw Szymanski changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208178|0 |1 is obsolete| | Attachment #208178|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:21:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:21:07 -0700 Subject: [Webkit-unassigned] [Bug 119673] New: [GTK] Remove Gail dependency from build system for GTK3 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119673 Summary: [GTK] Remove Gail dependency from build system for GTK3 Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: Gtk Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mario at webkit.org Once bug 114867 is fixed, we won't longer need to compile and link against libgail anymore, so let's remove it from the build system. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:22:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:22:19 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 Przemyslaw Szymanski changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208519| |review? Flag| | --- Comment #6 from Przemyslaw Szymanski 2013-08-12 02:21:55 PST --- Created an attachment (id=208519) --> (https://bugs.webkit.org/attachment.cgi?id=208519&action=review) Vertex attribute binding validation method update after review -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:24:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:24:32 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 --- Comment #7 from Przemyslaw Szymanski 2013-08-12 02:24:08 PST --- (In reply to comment #5) > (From update of attachment 208178 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208178&action=review > > >> Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.h:62 > >> + inline bool validateBinding() const { return !enabled || (enabled && isBound()); } > > > > Second check should be enough here. > > Do you need the second enabled? (if enabled is false, the second part of the condition does not get evaluated, while if enabled is true, then it doesnt bring much value to the second part of the condition) Good point. Thank you. I updated this code. Review again please. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:27:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:27:30 -0700 Subject: [Webkit-unassigned] [Bug 119673] [GTK] Remove Gail dependency from build system for GTK3 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119673 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgarcia at igalia.com, | |gns at gnome.org, | |mrobinson at webkit.org, | |xan.lopez at gmail.com Depends on| |114867 --- Comment #1 from Mario Sanchez Prada 2013-08-12 02:27:06 PST --- Setting proper dependency path and adding people on CC who might be interested -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:27:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:27:31 -0700 Subject: [Webkit-unassigned] [Bug 114867] [GTK] Get rid of Pango/Gail dependencies in accessibility for ATK In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=114867 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119673 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:29:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:29:13 -0700 Subject: [Webkit-unassigned] [Bug 33928] Add support for touch manipulation events In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=33928 Vitaliy Kharin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kvserr at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:34:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:34:30 -0700 Subject: [Webkit-unassigned] [Bug 119674] New: Remove glu's libtest rule from checker.py Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119674 Summary: Remove glu's libtest rule from checker.py Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: seokju at webkit.org It is no longer used after r148032. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:36:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:36:54 -0700 Subject: [Webkit-unassigned] [Bug 119674] Remove glu's libtest rule from checker.py In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119674 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208521| |review? Flag| | --- Comment #1 from Seokju Kwon 2013-08-12 02:36:30 PST --- Created an attachment (id=208521) --> (https://bugs.webkit.org/attachment.cgi?id=208521&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:38:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:38:27 -0700 Subject: [Webkit-unassigned] [Bug 119674] Remove glu's libtest rule from checker.py In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119674 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |dpranke at chromium.org, | |glenn at skynav.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:43:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:43:17 -0700 Subject: [Webkit-unassigned] [Bug 33928] Add support for touch manipulation events In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=33928 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:46:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:46:07 -0700 Subject: [Webkit-unassigned] [Bug 119675] New: [GTK] Do not load the GAIL module for GTK+ 3 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119675 Summary: [GTK] Do not load the GAIL module for GTK+ 3 Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: a.obzhirov at samsung.com After talking to Mario we realized that GAIL module was still being loaded for API tests when using GTK 3 even if it is not needed after GTK 3.2 and now we require GTK 3.6. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:48:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:48:08 -0700 Subject: [Webkit-unassigned] [Bug 119675] [GTK] Do not load the GAIL module for GTK+ 3 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119675 Anton Obzhirov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 02:55:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 02:55:43 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #30 from Christophe Dumez 2013-08-12 02:55:18 PST --- (From update of attachment 208518) View in context: https://bugs.webkit.org/attachment.cgi?id=208518&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:95 > +// Spec : http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#space-character This link is not needed. > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:98 > + return (isHTMLSpace(c) || c == 0x000B); You need to add a comment to explain why we treat 0x000B as a space here (backward compatibility and consistency with Firefox). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:00:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:00:04 -0700 Subject: [Webkit-unassigned] [Bug 119673] [GTK] Remove Gail dependency from build system for GTK3 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119673 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208522| |review? Flag| | --- Comment #2 from Mario Sanchez Prada 2013-08-12 02:59:39 PST --- Created an attachment (id=208522) --> (https://bugs.webkit.org/attachment.cgi?id=208522&action=review) Patch proposal One dependency less! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:00:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:00:46 -0700 Subject: [Webkit-unassigned] [Bug 119585] [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119585 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[EFL] URL printing code in |[EFL][WK1] URL printing |DumpRenderTree doesn't |code in DumpRenderTree |match WTR or Mac DRT |doesn't match WTR or Mac | |DRT CC| |dchris at gmail.com, | |gyuyoung.kim at samsung.com, | |ryuan.choi at samsung.com --- Comment #1 from Christophe Dumez 2013-08-12 03:00:20 PST --- Adding Ryuan and Gyuyoung in CC since I believe they are maintaining EFL WK1. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:01:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:01:18 -0700 Subject: [Webkit-unassigned] [Bug 119673] [GTK] Remove Gail dependency from build system for GTK3 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119673 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |gyuyoung.kim at webkit.org, | |rakuco at webkit.org, | |zandobersek at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:05:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:05:50 -0700 Subject: [Webkit-unassigned] [Bug 119675] [GTK] Do not load the GAIL module for GTK+ 3 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119675 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE --- Comment #1 from Mario Sanchez Prada 2013-08-12 03:05:25 PST --- (In reply to comment #0) > After talking to Mario we realized that GAIL module was still being > loaded for API tests when using GTK 3 even if it is not needed > after GTK 3.2 and now we require GTK 3.6. ...and Mario seemed not to remember that he reported this very same bug already in the past, so resolving it as duplicate now :) Anton, please provide your patch as related to bug 72735 instead, sorry for not realizing before about this. *** This bug has been marked as a duplicate of bug 72735 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:05:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:05:51 -0700 Subject: [Webkit-unassigned] [Bug 72735] [GTK] Don't load GAIL when using GTK 3.2 or greater In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=72735 Mario Sanchez Prada changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.obzhirov at samsung.com --- Comment #1 from Mario Sanchez Prada 2013-08-12 03:05:25 PST --- *** Bug 119675 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:08:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:08:32 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Rashmi Shyamasundar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208518|0 |1 is obsolete| | Attachment #208518|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:08:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:08:50 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Rashmi Shyamasundar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208523| |review? Flag| | --- Comment #31 from Rashmi Shyamasundar 2013-08-12 03:08:24 PST --- Created an attachment (id=208523) --> (https://bugs.webkit.org/attachment.cgi?id=208523&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:10:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:10:56 -0700 Subject: [Webkit-unassigned] [Bug 119676] New: Move some Document recalcStyle code to StyleResolveTree Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119676 Summary: Move some Document recalcStyle code to StyleResolveTree Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: koivisto at iki.fi This is the usual starting point for tree resolve. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:15:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:15:04 -0700 Subject: [Webkit-unassigned] [Bug 119676] Move some Document recalcStyle code to StyleResolveTree In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119676 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208524| |review? Flag| | --- Comment #1 from Antti Koivisto 2013-08-12 03:14:40 PST --- Created an attachment (id=208524) --> (https://bugs.webkit.org/attachment.cgi?id=208524&action=review) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:15:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:15:10 -0700 Subject: [Webkit-unassigned] [Bug 119676] Move some Document recalcStyle code to StyleResolveTree In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119676 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:16:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:16:29 -0700 Subject: [Webkit-unassigned] [Bug 119654] [Qt] Avoid calling QWebPage's virtual functions during deletion of QWebPage In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119654 --- Comment #7 from Allan Sandfeld Jensen 2013-08-12 03:16:05 PST --- (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #3) > > > > (In reply to comment #2) > > > > > Since QWebPage is already a wrapper around QWebPageAdaptor why can't you call QWebPageAdaptor::preparetoDestroy() from the qwebpage destructor? > > > > > > > > When control reaches ~QWebPage derived class already been destroyed(~UnLoadTestPage). > > > > > > True, but that only matters if you need the overloaded alert like the test-case. Most common cases of what happens on unload would work, wouldn't it? > > > > Nevermind that was the entire case of the bug-report. > > > > If this depends on the user of qwebpage calling an extra method, could he call something to unload the page instead? > > > > Perhaps mainFram()->setHtml("") ? > > Thanks Allan, I tried this, it is not working. Might be because of its async. nature of mainFrame()->setHtml() I guess :( Another option might be to only introduce the close or unload method on qwebpage level and call QWebPageAdapter::deletePage(). I think it will do the same, but using the iterative detach/closeURL in FrameLoader. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:17:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:17:14 -0700 Subject: [Webkit-unassigned] [Bug 119676] Move some Document recalcStyle code to StyleResolveTree In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119676 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |esprehn+autocc at chromium.org | |, kangil.han at samsung.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:18:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:18:05 -0700 Subject: [Webkit-unassigned] [Bug 72735] [GTK] Don't load GAIL when using GTK 3.2 or greater In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=72735 Anton Obzhirov changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |a.obzhirov at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:19:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:19:54 -0700 Subject: [Webkit-unassigned] [Bug 119676] Move some Document recalcStyle code to StyleResolveTree In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119676 Andreas Kling changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208524|review? |review+ Flag| | --- Comment #2 from Andreas Kling 2013-08-12 03:19:30 PST --- (From update of attachment 208524) View in context: https://bugs.webkit.org/attachment.cgi?id=208524&action=review r=me > Source/WebCore/style/StyleResolveTree.cpp:299 > + for (Node* child = document->firstChild(); child; child = child->nextSibling()) { > + if (!child->isElementNode()) > + continue; > + Element* elementChild = toElement(child); We should make ElementTraversal support this case. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:21:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:21:27 -0700 Subject: [Webkit-unassigned] [Bug 117354] [GStreamer] Don't set state to NULL until element is destroyed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117354 Bug 117354 depends on bug 109350, which changed state. Bug 109350 Summary: Resource leak related to gstreamer and videos https://bugs.webkit.org/show_bug.cgi?id=109350 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|UNCONFIRMED |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:22:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:22:38 -0700 Subject: [Webkit-unassigned] [Bug 119673] [GTK] Remove Gail dependency from build system for GTK3 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119673 Rego GTK+ EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rego+ews at igalia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:25:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:25:02 -0700 Subject: [Webkit-unassigned] [Bug 119676] Move some Document recalcStyle code to StyleResolveTree In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119676 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Antti Koivisto 2013-08-12 03:24:38 PST --- http://trac.webkit.org/changeset/153938 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:43:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:43:17 -0700 Subject: [Webkit-unassigned] [Bug 119622] [CSSRegions] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Javier Fernandez changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Not possible to clear the |[CSSRegions] Not possible |selection when mixing |to clear the selection when |content from different |mixing content from |FlowThreads |different FlowThreads -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:47:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:47:45 -0700 Subject: [Webkit-unassigned] [Bug 119622] [CSSRegions] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Javier Fernandez changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |106817 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:47:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:47:46 -0700 Subject: [Webkit-unassigned] [Bug 106817] [CSS Regions] Selecting text inside + outside regions does not work properly In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=106817 Javier Fernandez changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119622 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 03:50:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 03:50:43 -0700 Subject: [Webkit-unassigned] [Bug 119678] New: Move ElementTraversal to ElementTraversal.h Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119678 Summary: Move ElementTraversal to ElementTraversal.h Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: koivisto at iki.fi from NodeTraversal.h -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 04:00:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 04:00:09 -0700 Subject: [Webkit-unassigned] [Bug 119678] Move ElementTraversal to ElementTraversal.h In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119678 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208528| |review? Flag| | --- Comment #1 from Antti Koivisto 2013-08-12 03:59:45 PST --- Created an attachment (id=208528) --> (https://bugs.webkit.org/attachment.cgi?id=208528&action=review) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 04:04:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 04:04:02 -0700 Subject: [Webkit-unassigned] [Bug 119678] Move ElementTraversal to ElementTraversal.h In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119678 Andreas Kling changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208528|review? |review+ Flag| | --- Comment #2 from Andreas Kling 2013-08-12 04:03:38 PST --- (From update of attachment 208528) rs=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 04:08:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 04:08:56 -0700 Subject: [Webkit-unassigned] [Bug 119679] New: Remove the cast-align warnings for ARM Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119679 Summary: Remove the cast-align warnings for ARM Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: vjaquez at igalia.com Compiling for armhf, gcc (4.7.3) reports ~830 cast-align warnings. These warnings might be silenced using reinterpret_cast_ptr<>. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 04:09:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 04:09:46 -0700 Subject: [Webkit-unassigned] [Bug 119679] Remove the cast-align warnings for ARM In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119679 --- Comment #1 from V?ctor M. J?quez L. 2013-08-12 04:09:22 PST --- Created an attachment (id=208529) --> (https://bugs.webkit.org/attachment.cgi?id=208529&action=review) list of cast align warnings -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 04:20:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 04:20:57 -0700 Subject: [Webkit-unassigned] [Bug 119678] Move ElementTraversal to ElementTraversal.h In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119678 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Antti Koivisto 2013-08-12 04:20:33 PST --- http://trac.webkit.org/changeset/153939 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 04:32:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 04:32:23 -0700 Subject: [Webkit-unassigned] [Bug 119569] REGRESSION(FTL merge): There are still crashes on ARM In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119569 --- Comment #2 from Csaba Osztrogonac OOO until 21st Aug 2013-08-12 04:31:58 PST --- (In reply to comment #1) > The test results show there was a crash, but there isn't a crash log. Could you run one or more of these tests and attach a backtrace? Unfortunately I can't do it on my summer holiday. Maybe rgabor could help you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 04:41:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 04:41:26 -0700 Subject: [Webkit-unassigned] [Bug 119678] Move ElementTraversal to ElementTraversal.h In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119678 Andrei Bucur changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abucur at adobe.com --- Comment #4 from Andrei Bucur 2013-08-12 04:41:02 PST --- Thank you! :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 04:49:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 04:49:03 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 Divakar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208335|0 |1 is obsolete| | Attachment #208335|review-, commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 04:49:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 04:49:13 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 Divakar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208534| |review? Flag| | --- Comment #15 from Divakar 2013-08-12 04:48:49 PST --- Created an attachment (id=208534) --> (https://bugs.webkit.org/attachment.cgi?id=208534&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 05:12:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 05:12:36 -0700 Subject: [Webkit-unassigned] [Bug 119673] [GTK] Remove Gail dependency from build system for GTK3 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119673 kov's GTK+ EWS bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gtk-ews at kov.eti.br -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 05:12:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 05:12:37 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking]Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 --- Comment #3 from Andrei Parvu 2013-08-12 05:12:12 PST --- (In reply to comment #2) > Attachment 208398 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/masking/parsing-mask-type-expected.txt', u'LayoutTests/fast/masking/parsing-mask-type.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSProperty.cpp', u'Source/WebCore/css/CSSPropertyNames.in', u'Source/WebCore/css/CSSToStyleMap.cpp', u'Source/WebCore/css/CSSToStyleMap.h', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/rendering/style/FillLayer.cpp', u'Source/WebCore/rendering/style/FillLayer.h', u'Source/WebCore/rendering/style/RenderStyleConstants.h', u'Source/WebCore/rendering/style/SVGRenderStyleDefs.h']" exit_code: 1 > Source/WebCore/rendering/style/RenderStyleConstants.h:167: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Total errors found: 1 in 15 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. EMaskType was already defined in SVGRenderStyleDefs, I only moved it to RenderStyleConstants -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 05:12:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 05:12:39 -0700 Subject: [Webkit-unassigned] [Bug 119673] [GTK] Remove Gail dependency from build system for GTK3 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119673 kov's GTK+ EWS bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208522| |commit-queue- Flag| | --- Comment #3 from kov's GTK+ EWS bot 2013-08-12 05:12:15 PST --- (From update of attachment 208522) Attachment 208522 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1449136 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 05:32:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 05:32:22 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 EFL EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208534| |commit-queue- Flag| | --- Comment #16 from EFL EWS Bot 2013-08-12 05:31:57 PST --- (From update of attachment 208534) Attachment 208534 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1441567 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 05:36:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 05:36:04 -0700 Subject: [Webkit-unassigned] [Bug 119681] New: Add ElementTraversal::nextSibling/previousSibling Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119681 Summary: Add ElementTraversal::nextSibling/previousSibling Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: koivisto at iki.fi Better internal traversal. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 05:37:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 05:37:18 -0700 Subject: [Webkit-unassigned] [Bug 119681] Add ElementTraversal::next/previousSibling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119681 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add |Add |ElementTraversal::nextSibli |ElementTraversal::next/prev |ng/previousSibling |iousSibling -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 05:41:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 05:41:29 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking]Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208398|review? |review- Flag| | --- Comment #4 from Dirk Schulze 2013-08-12 05:41:04 PST --- (From update of attachment 208398) View in context: https://bugs.webkit.org/attachment.cgi?id=208398&action=review Great patch! Still some snippets. > Source/WebCore/ChangeLog:4 > + [CSS Masking]Add -webkit-mask-type property, with alpha and luminance values > + Added the -webkit-mask-type property, which can have a value of alpha or First title, then in a new line the link to the bug report, a newline and then the description. > Source/WebCore/ChangeLog:13 > + * css/CSSComputedStyleDeclaration.cpp: Added case for CSSPropertyWebkitMaskType Sentences please. You miss the period. > Source/WebCore/ChangeLog:15 > + * css/CSSParser.cpp: Parsed the values for CSSPropertyWebkitMaskType Ditto, in the other sentences as well. Stop here. > Source/WebCore/ChangeLog:39 > + * rendering/style/RenderStyleConstants.h: Added EMaskType > + * rendering/style/SVGRenderStyleDefs.h: Removed EMaskType s/Added EMaskType/Moved EMaskType from SVGRenderStyleDefs.h./ > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1789 > + case CSSPropertyWebkitMaskType: { > + const FillLayer* layers = style->maskLayers(); > + > + if (!layers) > + return cssValuePool().createIdentifierValue(CSSValueNone); > + > + if (!layers->next()) { > + if (layers->maskType() == MT_ALPHA) > + return cssValuePool().createIdentifierValue(CSSValueAlpha); > + return cssValuePool().createIdentifierValue(CSSValueLuminance); > + } > + > + RefPtr list = CSSValueList::createCommaSeparated(); > + for (const FillLayer* currLayer = layers; currLayer; currLayer = currLayer->next()) { > + if (currLayer->maskType() == MT_ALPHA) > + list->append(cssValuePool().createIdentifierValue(CSSValueAlpha)); > + else > + list->append(cssValuePool().createIdentifierValue(CSSValueLuminance)); > + } > + return list.release(); > + } This needs testing. If you want to, you can add it to a new patch, since we do not compute the style for -webkit-mask yet. Or you need to add the code for testing as we do for the background property. > Source/WebCore/css/CSSParser.cpp:4438 > + case CSSPropertyWebkitMaskType: { > + if (val->id == CSSValueAlpha || val->id == CSSValueLuminance) { > + currValue = cssValuePool().createIdentifierValue(val->id); > + m_valueList->next(); > + } else > + currValue = 0; > + break; > + } Hm, so the -webkit-mask property does not support parsing of luminance and alpha yet. Can you open a separate bug report and state that in the ChangeLog explicitly please? > Source/WebCore/css/CSSToStyleMap.cpp:313 > + CSSPrimitiveValue* primitiveValue = static_cast(value); > + layer->setMaskType(*primitiveValue); I think you want to set the enumeration and not pass the CSSPrimtiveValue. > Source/WebCore/rendering/style/FillLayer.cpp:57 > + , m_maskType(MT_ALPHA) For consistency add a initialFillMaskType function that returns the enumeration. > Source/WebCore/rendering/style/FillLayer.h:191 > + static EMaskType initialMaskType(EFillLayerType) { return MT_ALPHA; } So you already have the initial function here. Why didn't you use it? > LayoutTests/ChangeLog:10 > + * fast/masking/parsing-mask-type-expected.txt: Added. > + * fast/masking/parsing-mask-type.html: Added. You can reuse the existing parsing-mask.html test. Just add your -webkit-mask-type tests there. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 05:42:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 05:42:47 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking] Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[CSS Masking]Add |[CSS Masking] Add |-webkit-mask-type property, |-webkit-mask-type property, |with alpha and luminance |with alpha and luminance |values |values Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 05:45:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 05:45:36 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking] Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 --- Comment #5 from Dirk Schulze 2013-08-12 05:45:11 PST --- (From update of attachment 208398) View in context: https://bugs.webkit.org/attachment.cgi?id=208398&action=review >> Source/WebCore/css/CSSParser.cpp:4438 >> + } > > Hm, so the -webkit-mask property does not support parsing of luminance and alpha yet. Can you open a separate bug report and state that in the ChangeLog explicitly please? Forget to say that it is the -webkit-mask-source-type property, not the -webkit-mask-type property. Also, -webkit-mask-source-type has an initial value of 'auto'. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 05:50:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 05:50:29 -0700 Subject: [Webkit-unassigned] [Bug 119585] [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119585 --- Comment #2 from Gyuyoung Kim 2013-08-12 05:50:03 PST --- ap, will you submit a patch for this bug ? Otherwise, do you want we make a patch for this bug ? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 05:59:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 05:59:43 -0700 Subject: [Webkit-unassigned] [Bug 119585] [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119585 --- Comment #3 from Christophe Dumez 2013-08-12 05:59:17 PST --- (In reply to comment #2) > ap, will you submit a patch for this bug ? Otherwise, do you want we make a patch for this bug ? I really think it is up to us to fix EFL bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 06:02:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 06:02:52 -0700 Subject: [Webkit-unassigned] [Bug 119585] [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119585 --- Comment #4 from Gyuyoung Kim 2013-08-12 06:02:26 PST --- (In reply to comment #3) > (In reply to comment #2) > > ap, will you submit a patch for this bug ? Otherwise, do you want we make a patch for this bug ? > > I really think it is up to us to fix EFL bugs. Looks like that as well. Ryuan or I will fix this soon. ;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 06:46:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 06:46:35 -0700 Subject: [Webkit-unassigned] [Bug 119681] Add ElementTraversal::next/previousSibling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119681 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208538| |review? Flag| | --- Comment #1 from Antti Koivisto 2013-08-12 06:46:11 PST --- Created an attachment (id=208538) --> (https://bugs.webkit.org/attachment.cgi?id=208538&action=review) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 06:46:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 06:46:44 -0700 Subject: [Webkit-unassigned] [Bug 119681] Add ElementTraversal::next/previousSibling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119681 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208538|application/octet-stream |text/plain mime type| | Attachment #208538|0 |1 is patch| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 07:00:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 07:00:08 -0700 Subject: [Webkit-unassigned] [Bug 119681] Add ElementTraversal::next/previousSibling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119681 Andreas Kling changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208538|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 07:32:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 07:32:14 -0700 Subject: [Webkit-unassigned] [Bug 119272] Broken build with build-webkit --no-webgl In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119272 Ragner Magalhaes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208298|0 |1 is obsolete| | Attachment #208298|review- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 07:32:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 07:32:26 -0700 Subject: [Webkit-unassigned] [Bug 119272] Broken build with build-webkit --no-webgl In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119272 Ragner Magalhaes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208539| |review? Flag| | --- Comment #4 from Ragner Magalhaes 2013-08-12 07:32:01 PST --- Created an attachment (id=208539) --> (https://bugs.webkit.org/attachment.cgi?id=208539&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:39:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:39:04 -0700 Subject: [Webkit-unassigned] [Bug 119684] New: [Qt][WK1] fast/events/setDragImage-in-document-element-crash.html test timed out. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119684 Summary: [Qt][WK1] fast/events/setDragImage-in-document-element-crash.htm l test timed out. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abrhm at inf.u-szeged.hu CC: ossy at webkit.org, thorton at apple.com, zarvai at inf.u-szeged.hu, kadam at inf.u-szeged.hu Blocks: 87008 This test timed out on x64 Qt WK1 Release bot. Could you take a look please? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:39:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:39:07 -0700 Subject: [Webkit-unassigned] [Bug 87008] [Qt] Meta bug to fix newly added but failing tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=87008 G?bor ?brah?m changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119684 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:41:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:41:50 -0700 Subject: [Webkit-unassigned] [Bug 119320] Do not normalize into NFC the values of form fields In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119320 --- Comment #5 from Alexey Proskuryakov 2013-08-12 08:41:26 PST --- This is already discussed in the original. In any case, please keep the discussion to the original bug, to keep it in one place. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:47:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:47:51 -0700 Subject: [Webkit-unassigned] [Bug 119585] [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119585 --- Comment #5 from Alexey Proskuryakov 2013-08-12 08:47:25 PST --- Thank you! It would be much better for someone with a EFL build to do this, as there is likely to be quite a bit of test expectation cleanup. WebKitTestRunner code can probably serve as a model here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:49:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:49:25 -0700 Subject: [Webkit-unassigned] [Bug 119686] New: Web Inspector: rich editing of CSS gradients Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119686 Summary: Web Inspector: rich editing of CSS gradients Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: graouts at apple.com CC: timothy at apple.com, joepeck at webkit.org, webkit-bug-importer at group.apple.com, graouts at apple.com In order to alleviate the complexity of the CSS gradients syntax and make it more visually efficient to edit them, we should offer rich editing of gradients within Web Inspector, for instance in the form of a popover allowing to edit the gradient type, direction and stops. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:50:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:50:07 -0700 Subject: [Webkit-unassigned] [Bug 119684] [Qt][WK1] New fast/events/setDragImage-in-document-element-crash.html test timed out after r153511. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119684 G?bor ?brah?m changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[Qt][WK1] |[Qt][WK1] New |fast/events/setDragImage-in |fast/events/setDragImage-in |-document-element-crash.htm |-document-element-crash.htm |l test timed out. |l test timed out after | |r153511. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:50:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:50:47 -0700 Subject: [Webkit-unassigned] [Bug 119686] Web Inspector: rich editing of CSS gradients In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119686 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Radar WebKit Bug Importer 2013-08-12 08:50:23 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:51:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:51:10 -0700 Subject: [Webkit-unassigned] [Bug 119686] Web Inspector: rich editing of CSS gradients In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119686 Antoine Quint changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |graouts at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:52:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:52:06 -0700 Subject: [Webkit-unassigned] [Bug 119681] Add ElementTraversal::next/previousSibling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119681 --- Comment #2 from Antti Koivisto 2013-08-12 08:51:42 PST --- http://trac.webkit.org/changeset/153942 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:52:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:52:37 -0700 Subject: [Webkit-unassigned] [Bug 119687] New: [GTK][Qt][WK1] New test fails: plugins/navigator-plugins-disabled.html after r153877. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119687 Summary: [GTK][Qt][WK1] New test fails: plugins/navigator-plugins-disabled.html after r153877. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abrhm at inf.u-szeged.hu CC: ossy at webkit.org, thorton at apple.com, zarvai at inf.u-szeged.hu, kadam at inf.u-szeged.hu Blocks: 87008 http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r153941%20(52935)/plugins/navigator-plugins-disabled-pretty-diff.html /ramdisk/qt-linux-64-release/build/layout-test-results/plugins/navigator-plugins-disabled-actual.txt 1 Passed! 1Found non-application plug-in: WebKit Test PlugIn 2Failed! Could you take a look please? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:52:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:52:38 -0700 Subject: [Webkit-unassigned] [Bug 87008] [Qt] Meta bug to fix newly added but failing tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=87008 G?bor ?brah?m changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119687 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 08:59:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 08:59:25 -0700 Subject: [Webkit-unassigned] [Bug 119684] [Qt][WK1] New fast/events/setDragImage-in-document-element-crash.html test timed out after r153511. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119684 --- Comment #1 from Zoltan Arvai 2013-08-12 08:59:01 PST --- (In reply to comment #0) > This test timed out on x64 Qt WK1 Release bot. > Could you take a look please? And also on Qt Linux Release and x86-32 Linux Qt Release NRWT. It is flaky timeout/pass on x86-32 Linux Qt Debug and x86-64 Linux Qt Debug. So it has timeouts on Qt WK1. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:01:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:01:35 -0700 Subject: [Webkit-unassigned] [Bug 119681] Add ElementTraversal::next/previousSibling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119681 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:08:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:08:16 -0700 Subject: [Webkit-unassigned] [Bug 119062] [GTK] Media Player's volume slider behavior is not consistent In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119062 Danilo Cesar Lemes de Paula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208545| |review? Flag| | --- Comment #1 from Danilo Cesar Lemes de Paula 2013-08-12 09:07:51 PST --- Created an attachment (id=208545) --> (https://bugs.webkit.org/attachment.cgi?id=208545&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:10:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:10:04 -0700 Subject: [Webkit-unassigned] [Bug 119062] [GTK] Media Player's volume slider behavior is not consistent In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119062 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |eric.carlson at apple.com, | |esprehn+autocc at chromium.org | |, glenn at skynav.com, | |jer.noble at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:14:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:14:03 -0700 Subject: [Webkit-unassigned] [Bug 119689] New: [Qt] New editing/selection/leak-document-with-selection-inside.html test fails on Qt bots after r153366. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119689 Summary: [Qt] New editing/selection/leak-document-with-selection-inside. html test fails on Qt bots after r153366. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abrhm at inf.u-szeged.hu CC: ossy at webkit.org, rniwa at webkit.org, zarvai at inf.u-szeged.hu, kadam at inf.u-szeged.hu Blocks: 87008 On Qt WK1: PASS internals.numberOfLiveDocuments() is originalNumberOfLiveDocuments FAIL internals.numberOfLiveDocuments() should be 4. Was 5. PASS successfullyParsed is true http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r153941%20(52935)/editing/selection/leak-document-with-selection-inside-pretty-diff.html On Qt WK2: PASS internals.numberOfLiveDocuments() is originalNumberOfLiveDocuments FAIL internals.numberOfLiveDocuments() should be 2. Was 3. PASS successfullyParsed is true http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r153941%20(37327)/editing/selection/leak-document-with-selection-inside-pretty-diff.html Could you check it please? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:14:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:14:04 -0700 Subject: [Webkit-unassigned] [Bug 87008] [Qt] Meta bug to fix newly added but failing tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=87008 G?bor ?brah?m changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119689 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:14:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:14:38 -0700 Subject: [Webkit-unassigned] [Bug 20018] Linking to style sheets with HTTP headers is not implemented in WebKit In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=20018 Pierre Rudloff changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rudloff at strasweb.fr -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:15:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:15:44 -0700 Subject: [Webkit-unassigned] [Bug 119062] [GTK] Media Player's volume slider behavior is not consistent In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119062 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208545|review? |review+ Flag| | --- Comment #2 from Gustavo Noronha (kov) 2013-08-12 09:15:20 PST --- (From update of attachment 208545) OK, makeTransparent sucks as a name for this IMO, but I guess it's what we're stuck with. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:21:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:21:06 -0700 Subject: [Webkit-unassigned] [Bug 119620] [Curl] Crash when starting second download. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119620 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208419|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #2 from Brent Fulgham 2013-08-12 09:20:42 PST --- (From update of attachment 208419) View in context: https://bugs.webkit.org/attachment.cgi?id=208419&action=review r=me > Source/WebCore/platform/network/curl/CurlDownload.cpp:133 > + if (addToCurl(m_pendingHandleList[0])) I know you only moved this code, but glancing at it I am concerned by this loop. It seems like we could get stuck here if the 'addToCurl' keeps failing for the 0th entry in the pending handle list. Could you look over addToCurl at some point and see if this might be an issue? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:23:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:23:30 -0700 Subject: [Webkit-unassigned] [Bug 119619] [Win] TestWebKitAPI fails to link. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119619 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208412|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #2 from Brent Fulgham 2013-08-12 09:23:06 PST --- (From update of attachment 208412) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:25:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:25:44 -0700 Subject: [Webkit-unassigned] [Bug 119545] [Curl] Cookie is not set when url string is unicode. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119545 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208267|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #2 from Brent Fulgham 2013-08-12 09:25:20 PST --- (From update of attachment 208267) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:26:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:26:25 -0700 Subject: [Webkit-unassigned] [Bug 119690] New: [CSS Shapes] Eliminate GraphicsContext3D::ImageExtractor dependency Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119690 Summary: [CSS Shapes] Eliminate GraphicsContext3D::ImageExtractor dependency Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: giles_joplin at yahoo.com Blocks: 116643 The reviewer for bug 116643 had asked for the GraphicsContext3D dependency in Shapes.cpp to be removed. The original plan was to refactor GraphicsContext3D::ImageExtractor et al, to remove its dependency on the rest of the WebGL code. See: The new plan is to render the shape's StyleImage instead: https://bugs.webkit.org/show_bug.cgi?id=119634 Use ImageBuffer::create() to create an ImageBuffer of the right size. Draw the Image* with the GraphicsContext returned by imageBuffer->context(). Use ImageBuffer::getUnmultipliedImageData() to extract the RGBA pixels data. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:27:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:27:48 -0700 Subject: [Webkit-unassigned] [Bug 116715] ASSERTION FAILED: type() == Percent in WebCore::Length::percent In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116715 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |zandobersek at gmail.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:29:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:29:14 -0700 Subject: [Webkit-unassigned] [Bug 119619] [Win] TestWebKitAPI fails to link. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119619 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:32:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:32:14 -0700 Subject: [Webkit-unassigned] [Bug 119619] [Win] TestWebKitAPI fails to link. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119619 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208412|review+, commit-queue+ | Flag| | --- Comment #3 from WebKit Commit Bot 2013-08-12 09:31:50 PST --- (From update of attachment 208412) Clearing flags on attachment: 208412 Committed r153943: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:32:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:32:15 -0700 Subject: [Webkit-unassigned] [Bug 119619] [Win] TestWebKitAPI fails to link. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119619 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from WebKit Commit Bot 2013-08-12 09:31:51 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:32:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:32:33 -0700 Subject: [Webkit-unassigned] [Bug 119690] [CSS Shapes] Eliminate GraphicsContext3D::ImageExtractor dependency In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119690 Hans Muller changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID --- Comment #1 from Hans Muller 2013-08-12 09:32:09 PST --- This doesn't need to be a separate bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:35:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:35:18 -0700 Subject: [Webkit-unassigned] [Bug 119620] [Curl] Crash when starting second download. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119620 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208419|review+, commit-queue+ | Flag| | --- Comment #3 from WebKit Commit Bot 2013-08-12 09:34:54 PST --- (From update of attachment 208419) Clearing flags on attachment: 208419 Committed r153944: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:35:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:35:19 -0700 Subject: [Webkit-unassigned] [Bug 119620] [Curl] Crash when starting second download. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119620 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from WebKit Commit Bot 2013-08-12 09:34:55 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:45:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:45:23 -0700 Subject: [Webkit-unassigned] [Bug 119674] Remove glu's libtest rule from checker.py In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119674 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208521|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:46:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:46:20 -0700 Subject: [Webkit-unassigned] [Bug 119687] [GTK][Qt][WK1] New test fails: plugins/navigator-plugins-disabled.html after r153877. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119687 --- Comment #1 from Tim Horton 2013-08-12 09:45:56 PST --- (In reply to comment #0) > http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r153941%20(52935)/plugins/navigator-plugins-disabled-pretty-diff.html > > /ramdisk/qt-linux-64-release/build/layout-test-results/plugins/navigator-plugins-disabled-actual.txt > 1 Passed! > 1Found non-application plug-in: WebKit Test PlugIn > 2Failed! > > Could you take a look please? I guess we need code similar to the WebPlatformStrategies implementations from http://trac.webkit.org/changeset/153877 for the other platforms too :| -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:52:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:52:05 -0700 Subject: [Webkit-unassigned] [Bug 119545] [Curl] Cookie is not set when url string is unicode. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119545 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208267|review+, commit-queue+ | Flag| | --- Comment #3 from WebKit Commit Bot 2013-08-12 09:51:41 PST --- (From update of attachment 208267) Clearing flags on attachment: 208267 Committed r153946: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:52:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:52:07 -0700 Subject: [Webkit-unassigned] [Bug 119545] [Curl] Cookie is not set when url string is unicode. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119545 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from WebKit Commit Bot 2013-08-12 09:51:43 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 09:56:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 09:56:55 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208523|review? |review- Flag| | --- Comment #32 from Darin Adler 2013-08-12 09:56:28 PST --- (From update of attachment 208523) View in context: https://bugs.webkit.org/attachment.cgi?id=208523&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:97 > + // 0x000B should be treated as space for backward compatibility and for matching the behavior of Firefox 23.0 For matching is bad grammar; it's not clear why matching Firefox 23.0 is a goal, so not sure why citing it here is helpful. > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2127 > + // According to spec all space characters should be replaced with +U0020 space character +U0020 is not the correct syntax. Missing period here. ?According to spec? is ambiguous. Please briefly name the spec you are talking bout. > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2129 > + replaceCharacterInString(normalizedText, isHTMLSpaceOrVerticalTab, " "); The algorithm used in this replaceCharacterInString function is highly inefficient and we should not use it. There are major problems: 1) No algorithm that loops through a string should modify the string with multiple calls to String member functions. Each of those String member functions allocates a new string for the result. So if the string has 100 spaces in it, this will reallocate the string 100 times, for a total of about 200 expensive calls to malloc. One good way to avoid this problem is to use a StringBuilder or Vector instead of using the string replace function. We would only do that work if there is at least one character that needs to be replaced. 2) This algorithm finds existing U+0020 spaces in the string and replaces each one. I'm sure it's common to have strings with spaces in them. We should not be finding those one at a time and then doing a costly replace-with-self operation that has no effect but causes multiple memory allocations. One way to avoid this problem is to have the character matching function return false for U+0020. 3) The replace function called here is an extremely expensive way to replace a single character without changing the string. Just calling the function requires creating and destroying a string, which means we are doing memory allocation even when measuring a string that has no spaces in it. And the function is a general purpose one that can change string length, which is far more expensive than it should be. > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2173 > - replaceCharacterInString(normalizedText, isSpaceOrNewline, " "); > + replaceCharacterInString(normalizedText, isHTMLSpaceOrVerticalTab, " "); This is just as a bad as the new call site. Not sure how this made it through patch review before! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:22:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:22:54 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 --- Comment #17 from Christophe Dumez 2013-08-12 10:22:28 PST --- (From update of attachment 208534) View in context: https://bugs.webkit.org/attachment.cgi?id=208534&action=review > Source/WebCore/page/Settings.cpp:131 > , m_textAutosizingWindowSizeOverride(320, 480) Why are we keeping this line if we are removing HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:28:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:28:30 -0700 Subject: [Webkit-unassigned] [Bug 119620] [Curl] Crash when starting second download. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119620 --- Comment #5 from peavo at outlook.com 2013-08-12 10:28:06 PST --- (In reply to comment #2) > (From update of attachment 208419 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208419&action=review > > r=me > Thanks for reviewing, now I can download several files without crashing ;) > > Source/WebCore/platform/network/curl/CurlDownload.cpp:133 > > + if (addToCurl(m_pendingHandleList[0])) > > I know you only moved this code, but glancing at it I am concerned by this loop. It seems like we could get stuck here if the 'addToCurl' keeps failing for the 0th entry in the pending handle list. Could you look over addToCurl at some point and see if this might be an issue? Good point, will have a look. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:31:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:31:08 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 --- Comment #8 from Christophe Dumez 2013-08-12 10:30:44 PST --- (From update of attachment 208519) View in context: https://bugs.webkit.org/attachment.cgi?id=208519&action=review > Source/WebCore/ChangeLog:6 > + This patch refactors WebGLRenderingContext code by move a vertex "by moving" > Source/WebCore/ChangeLog:7 > + attribute binding validation to the separate method. It is now "to a separate" > Source/WebCore/ChangeLog:9 > + code is more readable and more clear now. "more readable and more clear": pretty much means the same. Probably one is enough. > Source/WebCore/ChangeLog:13 > + No new tests. Covered by existing tests. There is no behavior change, right? If so, it is a good idea to say so in the Changelog. > Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.h:61 > + inline bool isBound() const { return bufferBinding && bufferBinding->object(); } inline is redundant here. > Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.h:62 > + inline bool validateBinding() const { return !enabled || isBound(); } Ditto. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:31:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:31:19 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dchris at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:31:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:31:51 -0700 Subject: [Webkit-unassigned] [Bug 119663] [Qt] [WebKit2] Remove duplicate RAM Size calculation and reuse WTF::ramSize() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119663 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208498|review+, commit-queue+ | Flag| | --- Comment #2 from WebKit Commit Bot 2013-08-12 10:31:27 PST --- (From update of attachment 208498) Clearing flags on attachment: 208498 Committed r153949: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:31:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:31:53 -0700 Subject: [Webkit-unassigned] [Bug 119663] [Qt] [WebKit2] Remove duplicate RAM Size calculation and reuse WTF::ramSize() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119663 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from WebKit Commit Bot 2013-08-12 10:31:29 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:31:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:31:59 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 --- Comment #9 from Christophe Dumez 2013-08-12 10:31:35 PST --- (From update of attachment 208519) View in context: https://bugs.webkit.org/attachment.cgi?id=208519&action=review >> Source/WebCore/ChangeLog:6 >> + This patch refactors WebGLRenderingContext code by move a vertex > > "by moving" "by moving the" actually -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:33:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:33:39 -0700 Subject: [Webkit-unassigned] [Bug 119691] New: Section's collapsed borders painted in wrong place in rtl tables Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119691 Summary: Section's collapsed borders painted in wrong place in rtl tables Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: robert at webkit.org .. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:47:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:47:06 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 --- Comment #3 from Christophe Dumez 2013-08-12 10:46:42 PST --- (From update of attachment 208515) View in context: https://bugs.webkit.org/attachment.cgi?id=208515&action=review > Source/WebCore/ChangeLog:7 > + Missing changelog. Please explain what you did and why it is better / faster. > Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp:-171 > - unsigned char c = pixelArray->item(pixelOffset + channel); Removing the char variable reduces the readability a bit IMHO. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:47:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:47:14 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dchris at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:47:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:47:27 -0700 Subject: [Webkit-unassigned] [Bug 119644] [iOS] isMainThread implementation with USE(WEB_THREAD) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119644 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED CC| |joepeck at webkit.org --- Comment #3 from Joseph Pecoraro 2013-08-12 10:47:02 PST --- Committed . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:51:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:51:45 -0700 Subject: [Webkit-unassigned] [Bug 119622] [CSSRegions] Not possible to clear the selection when mixing content from different FlowThreads In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119622 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |hyatt at apple.com Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 10:52:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 10:52:45 -0700 Subject: [Webkit-unassigned] [Bug 119272] Broken build with build-webkit --no-webgl In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119272 --- Comment #5 from Antonio Gomes 2013-08-12 10:52:21 PST --- (From update of attachment 208539) View in context: https://bugs.webkit.org/attachment.cgi?id=208539&action=review > Source/WTF/ChangeLog:8 > + CSS_SHADERS requires WEBGL enabled. Is not it more accurate to say that it requeres ANGLE, which is only available when WebGL is on? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:00:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:00:04 -0700 Subject: [Webkit-unassigned] [Bug 119654] [Qt] Avoid calling QWebPage's virtual functions during deletion of QWebPage In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119654 --- Comment #8 from Arunprasad Rajkumar 2013-08-12 10:59:39 PST --- Some review comments given by Allen(via IRC) - Implement the unload() method QWebFrame instead of QWebPage - Use detachFromParent()/cancelAndClear() of FrameLoader to send unload event instead of closeURL() - Finding appropriate place to call QWebFrame::unload implicitly without user intervention(may be side-effect of QWidget::close,..or similar) Allan, Please correct me if I'm wrong :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:10:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:10:03 -0700 Subject: [Webkit-unassigned] [Bug 119272] Broken build with build-webkit --no-webgl In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119272 Alexandru Chiculita changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208539|review? |review+ Flag| | --- Comment #6 from Alexandru Chiculita 2013-08-12 11:09:39 PST --- (From update of attachment 208539) View in context: https://bugs.webkit.org/attachment.cgi?id=208539&action=review >> Source/WTF/ChangeLog:8 >> + CSS_SHADERS requires WEBGL enabled. > > Is not it more accurate to say that it requeres ANGLE, which is only available when WebGL is on? Custom Filters are implemented on top of WebGL. We are only using ANGLE to validate the shaders, so we need both. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:17:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:17:45 -0700 Subject: [Webkit-unassigned] [Bug 119272] Broken build with build-webkit --no-webgl In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119272 Antonio Gomes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208539| |commit-queue+ Flag| | --- Comment #7 from Antonio Gomes 2013-08-12 11:17:21 PST --- (From update of attachment 208539) View in context: https://bugs.webkit.org/attachment.cgi?id=208539&action=review >>> Source/WTF/ChangeLog:8 >>> + CSS_SHADERS requires WEBGL enabled. >> >> Is not it more accurate to say that it requeres ANGLE, which is only available when WebGL is on? > > Custom Filters are implemented on top of WebGL. We are only using ANGLE to validate the shaders, so we need both. ok thanks -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:24:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:24:57 -0700 Subject: [Webkit-unassigned] [Bug 119684] [Qt][WK1] New fast/events/setDragImage-in-document-element-crash.html test timed out after r153511. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119684 --- Comment #2 from Tim Horton 2013-08-12 11:24:33 PST --- I have no idea why that would be the case. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:34:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:34:23 -0700 Subject: [Webkit-unassigned] [Bug 119691] Section's collapsed borders painted in wrong place in rtl tables In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119691 Robert Hogan changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |robert at webkit.org |kit.org | CC| |robert at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:40:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:40:36 -0700 Subject: [Webkit-unassigned] [Bug 119272] Broken build with build-webkit --no-webgl In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119272 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208539|review+, commit-queue+ | Flag| | --- Comment #8 from WebKit Commit Bot 2013-08-12 11:40:12 PST --- (From update of attachment 208539) Clearing flags on attachment: 208539 Committed r153951: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:40:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:40:39 -0700 Subject: [Webkit-unassigned] [Bug 119272] Broken build with build-webkit --no-webgl In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119272 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from WebKit Commit Bot 2013-08-12 11:40:14 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:43:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:43:04 -0700 Subject: [Webkit-unassigned] [Bug 119694] New: AX: main landmark takes very long to index Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119694 Summary: AX: main landmark takes very long to index Product: WebKit Version: 528+ (Nightly build) Platform: All URL: https://bugzilla.wikimedia.org/show_bug.cgi?id=42394 OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hartman at videolan.org CC: webkit-bug-importer at group.apple.com https://bugzilla.wikimedia.org/show_bug.cgi?id=42394 Wikipedia articles can be very large as you know. There have been some reports that after the introduction of landmark roles in mediawiki, navigation has become much slower for users of VO. It seems that this is caused by the fact that there is now one huge main landmark role around most of the content, that takes very long to finish indexing and in the mean time Safari is reporting 'busy'. Without landmarks, the page seems to go trough a different analysis path, causing way less resources usage. A good example is the complex page: http://de.wikipedia.org/wiki/Deutschland -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:43:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:43:27 -0700 Subject: [Webkit-unassigned] [Bug 119694] AX: main landmark takes very long to index In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119694 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Radar WebKit Bug Importer 2013-08-12 11:43:03 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:46:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:46:14 -0700 Subject: [Webkit-unassigned] [Bug 119694] AX: main landmark takes very long to index In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119694 Tim Horton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com, | |cfleizach at apple.com, | |thorton at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:58:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:58:14 -0700 Subject: [Webkit-unassigned] [Bug 99618] [MathML] Implement the mmultiscripts tag In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99618 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208490| |commit-queue- Flag| | --- Comment #17 from Build Bot 2013-08-12 11:57:48 PST --- (From update of attachment 208490) Attachment 208490 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1453182 New failing tests: mathml/presentation/scripts-base-alignment.html platform/mac/accessibility/mathml-elements.html platform/mac/accessibility/mathml-multiscript.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 11:58:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 11:58:18 -0700 Subject: [Webkit-unassigned] [Bug 99618] [MathML] Implement the mmultiscripts tag In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99618 --- Comment #18 from Build Bot 2013-08-12 11:57:52 PST --- Created an attachment (id=208552) --> (https://bugs.webkit.org/attachment.cgi?id=208552&action=review) Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 12:00:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 12:00:59 -0700 Subject: [Webkit-unassigned] [Bug 119694] AX: main landmark takes very long to index In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119694 --- Comment #2 from Derk-Jan Hartman 2013-08-12 12:00:35 PST --- Also, it seems that Firefox is considerably slower than Safari, and Chrome 28 is fast but ignores the landmarks altogether (but in performance is equal to Safari when the page had no landmarks) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 12:14:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 12:14:57 -0700 Subject: [Webkit-unassigned] [Bug 119695] New: AX: title attribute content not exposed as accessible name Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119695 Summary: AX: title attribute content not exposed as accessible name Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: faulkner.steve at gmail.com CC: webkit-bug-importer at group.apple.com In the absence of any other source for the accessible name/description for an element the title attribute content should be used: [1] "D. The last resort is to use text from a tooltip attribute (such as the title attribute in HTML). This is used only if nothing else, including subtree content, has provided results." for example: 1) 2) should be equivalent, but they are not: 1) AXHelp: "test" AXDescription: "" 2) AXHelp: "test" AXDescription: "aria test" 1) should be mapped thus: AXHelp: "" AXDescription: "test" This results in VoiceOver not announcing the label for a control when the title attribute is used as the source of the label. [1] http://www.w3.org/TR/wai-aria/roles#namecalculation -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 12:15:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 12:15:12 -0700 Subject: [Webkit-unassigned] [Bug 119695] AX: title attribute content not exposed as accessible name In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119695 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Radar WebKit Bug Importer 2013-08-12 12:14:48 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 12:15:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 12:15:33 -0700 Subject: [Webkit-unassigned] [Bug 119696] New: AX: Lang attributes are not used in Mac OS Voice over Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119696 Summary: AX: Lang attributes are not used in Mac OS Voice over Product: WebKit Version: 528+ (Nightly build) Platform: All URL: http://en.wikipedia.org/wiki/Chinese_language OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hartman.wiki at gmail.com CC: webkit-bug-importer at group.apple.com It seems that language based voice selection is an iOS only feature, which is truly a shame. It's time this got fixed on the Desktop, so that the inline foreign languages inside the Wikipedia articles are properly pronounced on the Desktop as well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 12:16:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 12:16:02 -0700 Subject: [Webkit-unassigned] [Bug 119696] AX: Lang attributes are not used in Mac OS Voice over In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119696 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Radar WebKit Bug Importer 2013-08-12 12:15:38 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 12:23:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 12:23:48 -0700 Subject: [Webkit-unassigned] [Bug 119674] Remove glu's libtest rule from checker.py In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119674 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208521| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 12:40:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 12:40:26 -0700 Subject: [Webkit-unassigned] [Bug 119674] Remove glu's libtest rule from checker.py In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119674 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208521|review+, commit-queue+ | Flag| | --- Comment #2 from WebKit Commit Bot 2013-08-12 12:40:02 PST --- (From update of attachment 208521) Clearing flags on attachment: 208521 Committed r153954: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 12:40:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 12:40:28 -0700 Subject: [Webkit-unassigned] [Bug 119674] Remove glu's libtest rule from checker.py In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119674 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from WebKit Commit Bot 2013-08-12 12:40:04 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 12:55:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 12:55:16 -0700 Subject: [Webkit-unassigned] [Bug 119696] AX: Lang attributes are not used in Mac OS Voice over In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119696 Beth Dakin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 12:57:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 12:57:44 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208515|review? |review- Flag| | --- Comment #4 from Dean Jackson 2013-08-12 12:57:19 PST --- (From update of attachment 208515) +1 to Christophe's review. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 13:00:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 13:00:13 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208519|review? |review- Flag| | --- Comment #10 from Dean Jackson 2013-08-12 12:59:49 PST --- (From update of attachment 208519) Another +1 to Christophe's review. Just minor changes needed before r+ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 13:10:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 13:10:42 -0700 Subject: [Webkit-unassigned] [Bug 119402] [cmake] Extra compiler flags should be passed for all target In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119402 Raphael Kubo da Costa (:rakuco) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakuco at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 13:13:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 13:13:05 -0700 Subject: [Webkit-unassigned] [Bug 119695] AX: title attribute content not exposed as accessible name In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119695 Steve Faulkner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |faulkner.steve at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 13:16:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 13:16:51 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 Alberto Garcia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205995|0 |1 is obsolete| | Attachment #205995|review?, commit-queue? | Flag| | Attachment #208556| |review? Flag| | --- Comment #5 from Alberto Garcia 2013-08-12 13:16:26 PST --- Created an attachment (id=208556) --> (https://bugs.webkit.org/attachment.cgi?id=208556&action=review) Patch (In reply to comment #4) > It could be easier, yes, adding a comment explaining why parent > dispose is called first. Here it is. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:03:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:03:39 -0700 Subject: [Webkit-unassigned] [Bug 119698] New: Remove Node::attach() and ContainerNode::attach() Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Summary: Remove Node::attach() and ContainerNode::attach() Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: koivisto at iki.fi Currently attach() is a virtual function on Node. However only Elements have style and so a corresponding independent render object. Attaching should be made Element level concept. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:10:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:10:43 -0700 Subject: [Webkit-unassigned] [Bug 119135] [CSS-Regions] Anonymous nested regions In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119135 Catalin badea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208319|0 |1 is obsolete| | Attachment #208319|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:10:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:10:51 -0700 Subject: [Webkit-unassigned] [Bug 119135] [CSS-Regions] Anonymous nested regions In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119135 Catalin badea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208559| |review? Flag| | --- Comment #5 from Catalin badea 2013-08-12 14:10:27 PST --- Created an attachment (id=208559) --> (https://bugs.webkit.org/attachment.cgi?id=208559&action=review) WIP -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:13:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:13:17 -0700 Subject: [Webkit-unassigned] [Bug 119135] [CSS-Regions] Anonymous nested regions In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119135 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmarcelo at webkit.org, | |commit-queue at webkit.org, | |esprehn+autocc at chromium.org | |, glenn at skynav.com, | |kangil.han at samsung.com, | |kondapallykalyan at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:17:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:17:21 -0700 Subject: [Webkit-unassigned] [Bug 119699] New: AX: Headings not longer have an AXTitle if they have a link as the only child Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119699 Summary: AX: Headings not longer have an AXTitle if they have a link as the only child Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Keywords: InRadar Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cfleizach at apple.com CC: webkit-bug-importer at group.apple.com Headings not longer have an AXTitle if they have a link as the only child rdar://14699680 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:21:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:21:06 -0700 Subject: [Webkit-unassigned] [Bug 119699] AX: Headings not longer have an AXTitle if they have a link as the only child In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119699 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |cfleizach at apple.com |kit.org | Attachment #208562| |review? Flag| | --- Comment #1 from chris fleizach 2013-08-12 14:20:42 PST --- Created an attachment (id=208562) --> (https://bugs.webkit.org/attachment.cgi?id=208562&action=review) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:23:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:23:03 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #1 from Antti Koivisto 2013-08-12 14:22:38 PST --- Created an attachment (id=208563) --> (https://bugs.webkit.org/attachment.cgi?id=208563&action=review) possibly patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:24:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:24:47 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmarcelo at webkit.org, | |commit-queue at webkit.org, | |esprehn+autocc at chromium.org | |, japhet at chromium.org, | |kangil.han at samsung.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:25:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:25:18 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:31:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:31:38 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Igalia EWS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philn at igalia.com, | |xan.lopez at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:44:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:44:23 -0700 Subject: [Webkit-unassigned] [Bug 119701] New: Encapsulate access to documentNamedItemMap and windowNamedItemMap Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119701 Summary: Encapsulate access to documentNamedItemMap and windowNamedItemMap Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: ggaren at apple.com, barraclough at apple.com, benjamin at webkit.org Depends on: 119700 We should encapsulate documentNamedItemMap and windowNamedItemMap so that random code in WebCore doesn't modify them. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:49:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:49:16 -0700 Subject: [Webkit-unassigned] [Bug 119701] Encapsulate access to documentNamedItemMap and windowNamedItemMap In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119701 Bug 119701 depends on bug 119700, which changed state. Bug 119700 Summary: Use const AtomicStringImpl* in DocumentOrderedMap https://bugs.webkit.org/show_bug.cgi?id=119700 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:52:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:52:02 -0700 Subject: [Webkit-unassigned] [Bug 104104] Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104104 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rniwa at webkit.org --- Comment #6 from Ryosuke Niwa 2013-08-12 14:51:38 PST --- It's still failing. e.g. http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r153956%20(11902)/results.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 14:54:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 14:54:14 -0700 Subject: [Webkit-unassigned] [Bug 104104] Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104104 --- Comment #7 from Ryosuke Niwa 2013-08-12 14:53:50 PST --- Committed r153960: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 15:03:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 15:03:04 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 15:03:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 15:03:07 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208563| |commit-queue- Flag| | --- Comment #2 from Build Bot 2013-08-12 15:02:42 PST --- (From update of attachment 208563) Attachment 208563 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1445487 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 15:04:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 15:04:00 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 EFL EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eflews.bot at gmail.com, | |gyuyoung.kim at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 15:04:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 15:04:06 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #3 from EFL EWS Bot 2013-08-12 15:03:40 PST --- (From update of attachment 208563) Attachment 208563 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1455188 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 15:05:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 15:05:20 -0700 Subject: [Webkit-unassigned] [Bug 119654] [Qt] Avoid calling QWebPage's virtual functions during deletion of QWebPage In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119654 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208476|0 |1 is obsolete| | Attachment #208476|review?, commit-queue? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 15:05:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 15:05:30 -0700 Subject: [Webkit-unassigned] [Bug 119654] [Qt] Avoid calling QWebPage's virtual functions during deletion of QWebPage In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119654 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208566| |review?, commit-queue? Flag| | --- Comment #9 from Arunprasad Rajkumar 2013-08-12 15:05:05 PST --- Created an attachment (id=208566) --> (https://bugs.webkit.org/attachment.cgi?id=208566&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 15:21:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 15:21:02 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #4 from Build Bot 2013-08-12 15:20:37 PST --- (From update of attachment 208563) Attachment 208563 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1449294 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 15:29:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 15:29:26 -0700 Subject: [Webkit-unassigned] [Bug 85522] http/tests/security/sandboxed-iframe-modify-self.html is flaky on Lion Debug Tests as of r115979 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=85522 --- Comment #7 from Alexey Proskuryakov 2013-08-12 15:29:01 PST --- http/tests/security/sandboxed-iframe-form-top.html got unskipped in r150558 accidentally, so it's causing badness again. I'll see if I can easily fix it, and will skip again if not. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 15:31:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 15:31:34 -0700 Subject: [Webkit-unassigned] [Bug 85522] http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=85522 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|http/tests/security/sandbox |http/tests/security/sandbox |ed-iframe-modify-self.html |ed-iframe-invalid.html is |is flaky on Lion Debug |flaky on Mac |Tests as of r115979 | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 15:34:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 15:34:09 -0700 Subject: [Webkit-unassigned] [Bug 119703] New: Comments within nested CSS media queries are getting parsed Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119703 Summary: Comments within nested CSS media queries are getting parsed Product: WebKit Version: 528+ (Nightly build) Platform: Android OS/Version: Android Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: seanrice at seanrice.net I have a piece of CSS that looks something like this @media screen and (something) { body{background:#f00;} @media screen and (something more specific){ /*body{background:#0f0;}*/ } } The commented out line is getting parsed as a normal line for some reason. This is appearing in Chrome on android, but also on safari on IOS, at least on retina screens. I am not sure about other screens. The media queries we were using had to do with pixel density. To work around, we have removed the commented code entirely, so there's no longer a live site that we can point you to with the issue, but if you have trouble replicating it, we can probably reproduce the relevant files. Thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 16:13:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 16:13:15 -0700 Subject: [Webkit-unassigned] [Bug 119701] Encapsulate access to documentNamedItemMap and windowNamedItemMap In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119701 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rniwa at webkit.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 16:16:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 16:16:46 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208563|0 |1 is obsolete| | --- Comment #5 from Antti Koivisto 2013-08-12 16:16:21 PST --- Created an attachment (id=208570) --> (https://bugs.webkit.org/attachment.cgi?id=208570&action=review) another -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 16:24:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 16:24:33 -0700 Subject: [Webkit-unassigned] [Bug 119135] [CSS-Regions] Anonymous nested regions In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119135 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buildbot at hotmail.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 16:24:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 16:24:36 -0700 Subject: [Webkit-unassigned] [Bug 119135] [CSS-Regions] Anonymous nested regions In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119135 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208559| |commit-queue- Flag| | --- Comment #6 from Build Bot 2013-08-12 16:24:11 PST --- (From update of attachment 208559) Attachment 208559 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1453242 New failing tests: fast/regions/flow-body-in-html.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html fast/regions/flows-dependency-same-flow.html http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html http/tests/inspector/inspect-element.html fast/regions/flow-content-basic-vertical.html fast/regions/shape-inside/shape-inside-with-region-borders.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html fast/regions/autoheight-regions-mark.html fast/regions/overflow-in-variable-width-regions.html fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html fast/regions/multiple-directionality-changes-in-variable-width-regions.html fast/regions/offsetLeft-offsetTop-in-multiple-regions.html fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html fast/regions/overflow-in-uniform-regions-dynamic.html fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html fast/regions/overflow-moving-below-floats-in-variable-width-regions.html fast/regions/flow-content-basic.html fast/regions/flows-dependency-dynamic-remove.html fast/repaint/line-flow-with-floats-in-regions.html fast/repaint/region-painting-invalidation.html fast/repaint/region-painting-via-layout.html fast/regions/overflow-rtl-in-variable-width-regions.html fast/regions/flow-content-basic-vertical-rl.html fast/repaint/japanese-rl-selection-repaint-in-regions.html fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html fast/loader/javascript-url-in-object.html fast/repaint/overflow-flipped-writing-mode-block-in-regions.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 16:24:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 16:24:40 -0700 Subject: [Webkit-unassigned] [Bug 119135] [CSS-Regions] Anonymous nested regions In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119135 --- Comment #7 from Build Bot 2013-08-12 16:24:14 PST --- Created an attachment (id=208572) --> (https://bugs.webkit.org/attachment.cgi?id=208572&action=review) Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:18:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:18:15 -0700 Subject: [Webkit-unassigned] [Bug 119706] New: Move id attribute to parent Element interface Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119706 Summary: Move id attribute to parent Element interface Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: dchris at gmail.com Merge https://chromium.googlesource.com/chromium/blink/+/048383b5f7c71faffb20202c64e389ac23d2e955 Move id attribute from SVGElement / HTMLElement to their Element parent interface to match the latest DOM specification and avoid duplication: http://dom.spec.whatwg.org/#dom-element-id This behavior is consistent with Firefox. There is no web-exposed behavior change because we haven't moved properties from instances to their prototype, as per the Web IDL specification (http://dev.w3.org/2006/webapi/WebIDL/#es-attributes). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:19:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:19:43 -0700 Subject: [Webkit-unassigned] [Bug 119706] Move id attribute to parent Element interface In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119706 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com, | |eoconnor at apple.com, | |koivisto at iki.fi -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:21:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:21:28 -0700 Subject: [Webkit-unassigned] [Bug 119707] New: Add another test for whitespace handling in flexbox Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119707 Summary: Add another test for whitespace handling in flexbox Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: hyatt at apple.com, bdakin at apple.com, simon.fraser at apple.com, dino at apple.com Consider merging https://chromium.googlesource.com/chromium/blink/+/80aeeadb35f360518224a8042326d0eb4f3ae0ad This test makes sure that we don't create renderers for whitespace flex items even when they're surrounded by inlines. We get it right, but I didn't consider this case when I wrote this test, and I felt it was worth testing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:35:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:35:09 -0700 Subject: [Webkit-unassigned] [Bug 85522] http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=85522 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208575| |review? Flag| | --- Comment #8 from Alexey Proskuryakov 2013-08-12 17:34:44 PST --- Created an attachment (id=208575) --> (https://bugs.webkit.org/attachment.cgi?id=208575&action=review) proposed fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:35:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:35:21 -0700 Subject: [Webkit-unassigned] [Bug 104498] [EFL][WK2] Enable TEXT_AUTOSIZING In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=104498 --- Comment #18 from Jaehun Lim 2013-08-12 17:34:56 PST --- (In reply to comment #17) > (From update of attachment 208534 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208534&action=review > > > Source/WebCore/page/Settings.cpp:131 > > , m_textAutosizingWindowSizeOverride(320, 480) > > Why are we keeping this line if we are removing HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP? "windows size" is used to adjust the font size. If it is not override, "visible contents size" is used instead of it. http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/TextAutosizer.cpp#L116 I think this line is necessary to activate TextAutosizing for the big screen. But I don't like it. Johe Mellor filed the related bug, https://bugs.webkit.org/show_bug.cgi?id=94371 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:35:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:35:51 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208570| |commit-queue- Flag| | --- Comment #6 from Build Bot 2013-08-12 17:35:26 PST --- (From update of attachment 208570) Attachment 208570 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1459173 New failing tests: editing/style/remove-underline-across-paragraph-in-bold.html editing/inserting/editing-empty-divs.html editing/selection/caret-rtl.html fullscreen/full-screen-render-inline.html editing/style/remove-underline-from-stylesheet.html editing/selection/caret-ltr-right.html fast/repaint/caret-jump-between-nodes.html http/tests/inspector/inspect-element.html editing/selection/caret-ltr-2.html fast/multicol/span/clone-summary.html fast/html/details-remove-child-2.html editing/pasteboard/paste-match-style-001.html editing/selection/caret-rtl-2-left.html fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html editing/style/remove-underline-across-paragraph.html editing/selection/caret-ltr-2-left.html fast/html/details-add-child-2.html editing/style/remove-underline.html fast/html/details-open2.html editing/selection/4983858.html editing/selection/caret-rtl-2.html editing/style/remove-underline-after-paragraph.html editing/selection/caret-rtl-right.html editing/inserting/editable-html-element.html editing/style/remove-underline-in-bold.html editing/style/remove-underline-after-paragraph-in-bold.html editing/style/typing-style-003.html editing/selection/caret-ltr.html fast/loader/javascript-url-in-object.html editing/style/underline.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:35:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:35:54 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #7 from Build Bot 2013-08-12 17:35:28 PST --- Created an attachment (id=208576) --> (https://bugs.webkit.org/attachment.cgi?id=208576&action=review) Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:36:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:36:33 -0700 Subject: [Webkit-unassigned] [Bug 97485] http/tests/security/sandboxed-iframe-form-top.html fails In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=97485 --- Comment #2 from Alexey Proskuryakov 2013-08-12 17:36:09 PST --- Probably can be fixed in the same way as the Mac bug, too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:37:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:37:04 -0700 Subject: [Webkit-unassigned] [Bug 85522] http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=85522 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |japhet at chromium.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:47:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:47:03 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #8 from EFL EWS Bot 2013-08-12 17:46:37 PST --- (From update of attachment 208570) Attachment 208570 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1459183 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:50:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:50:34 -0700 Subject: [Webkit-unassigned] [Bug 85522] http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=85522 Andy Estes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208575|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:53:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:53:25 -0700 Subject: [Webkit-unassigned] [Bug 113546] [CSS Grid Layout] Align our grid-line handling with the updated specification In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113546 Kangil Han changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kangil.han at samsung.com |webkit-unassigned at lists.web | |kit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:53:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:53:43 -0700 Subject: [Webkit-unassigned] [Bug 113546] [CSS Grid Layout] Align our grid-line handling with the updated specification In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113546 Kangil Han changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204757|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:54:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:54:04 -0700 Subject: [Webkit-unassigned] [Bug 119710] New: Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 Summary: Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: seokju at webkit.org Remove unused parameter warning. WebKit/Source/WebCore/rendering/RenderObject.cpp:127:13: warning: unused parameter ?frameView? [-Wunused-parameter] -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 17:54:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 17:54:17 -0700 Subject: [Webkit-unassigned] [Bug 113546] [CSS Grid Layout] Align our grid-line handling with the updated specification In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113546 Kangil Han changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204757|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:04:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:04:13 -0700 Subject: [Webkit-unassigned] [Bug 119711] New: Make CSS property user-select:none not to affect Document.caretRangeFromPoint() Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119711 Summary: Make CSS property user-select:none not to affect Document.caretRangeFromPoint() Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: HTML Editing AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: enrica at apple.com, eoconnor at apple.com Consider merging https://chromium.googlesource.com/chromium/blink/+/50bbb9f6ab3394327e8fa63312316e6ae217a7a2 This patch introduces PositionWithAffinity as return value of RenderObject::positionForPoint() for making CSS property user-select:none doesn't affect Document.caretRangeFromPoint() and changes caretRangeFromPoint() to use Position instead of VisiblePosition, which excludes user-select:none. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:06:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:06:03 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208579| |review? Flag| | --- Comment #1 from Seokju Kwon 2013-08-12 18:05:38 PST --- Created an attachment (id=208579) --> (https://bugs.webkit.org/attachment.cgi?id=208579&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:06:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:06:59 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |esprehn+autocc at chromium.org | |, glenn at skynav.com, | |kondapallykalyan at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:08:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:08:56 -0700 Subject: [Webkit-unassigned] [Bug 119703] Comments within nested CSS media queries are getting parsed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119703 Andy Estes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aestes at apple.com --- Comment #1 from Andy Estes 2013-08-12 18:08:32 PST --- Sean, can you provide an actual test case we can open in Safari to see this bug? I tried to use max-width and max-height in place of the 'something's in your example, but I didn't see the commented-out rule being applied. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:09:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:09:40 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 --- Comment #2 from Darin Adler 2013-08-12 18:09:16 PST --- (From update of attachment 208579) View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review > Source/WebCore/rendering/RenderObject.cpp:129 > -#if !ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT) > +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) That?s the same as just change && to ||, why make it so complicated? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:10:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:10:56 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 --- Comment #3 from Darin Adler 2013-08-12 18:10:32 PST --- (From update of attachment 208579) View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review >> Source/WebCore/rendering/RenderObject.cpp:129 >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) > > That?s the same as just change && to ||, why make it so complicated? In other words, this is: #if !A || (A && !B) Which is the same as: #if !A || !B -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:12:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:12:35 -0700 Subject: [Webkit-unassigned] [Bug 119712] New: Remove support for 'pixel' and 'pos' CSSOM prefixes Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119712 Summary: Remove support for 'pixel' and 'pos' CSSOM prefixes Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate, WebExposed Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: hyatt at apple.com, bdakin at apple.com, simon.fraser at apple.com, dino at apple.com, jonlee at apple.com Consider merging https://chromium.googlesource.com/chromium/blink/+/7cb1d002fd79604c9e8d0bd810ba6f8f21ca78af These prefixes are: 1. Non-standard: the CSSOM standard doesn't mention them. 2. Broken: 'pixelWidth' should automagically convert from whatever unit the stylesheet specified into CSS pixels[1]. We're currently not doing that at all: if an element has a 'width' of 100em, pixelWidth is '100', which is probably wildly inaccurate. 3. Not covered by any tests ('fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html' is the only test mentioning these properties, and it only checks case-sensitivity: it doesn't validate behavior). This patch drops support completely. [1]: http://msdn.microsoft.com/en-us/library/ie/ms531135(v=vs.85).aspx -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:16:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:16:53 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 --- Comment #4 from Seokju Kwon 2013-08-12 18:16:29 PST --- (In reply to comment #3) > (From update of attachment 208579 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review > > >> Source/WebCore/rendering/RenderObject.cpp:129 > >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) > > > > That?s the same as just change && to ||, why make it so complicated? > > In other words, this is: > > #if !A || (A && !B) > > Which is the same as: > > #if !A || !B Just check it explicitly. You're right. It could be so complicated. Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:16:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:16:58 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208579|0 |1 is obsolete| | Attachment #208579|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:17:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:17:05 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 Seokju Kwon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208580| |review? Flag| | --- Comment #5 from Seokju Kwon 2013-08-12 18:16:41 PST --- Created an attachment (id=208580) --> (https://bugs.webkit.org/attachment.cgi?id=208580&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:40:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:40:35 -0700 Subject: [Webkit-unassigned] [Bug 57393] Extensions3D class API needs to be improved In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=57393 Kenneth Russell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW AssignedTo|kbr at google.com |webkit-unassigned at lists.web | |kit.org --- Comment #2 from Kenneth Russell 2013-08-12 18:40:10 PST --- Please do. I'll unassign myself. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:49:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:49:50 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 --- Comment #6 from Seokju Kwon 2013-08-12 18:49:26 PST --- (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 208579 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review > > > > >> Source/WebCore/rendering/RenderObject.cpp:129 > > >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) > > > > > > That?s the same as just change && to ||, why make it so complicated? > > > > In other words, this is: > > > > #if !A || (A && !B) > > > > Which is the same as: > > > > #if !A || !B > > Just check it explicitly. You're right. > It could be so complicated. Thanks. Fixed it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:59:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:59:39 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 Jinwoo Jeong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208515|0 |1 is obsolete| | Attachment #208515|review- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 18:59:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 18:59:49 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 Jinwoo Jeong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208582| |review? Flag| | --- Comment #5 from Jinwoo Jeong 2013-08-12 18:59:24 PST --- Created an attachment (id=208582) --> (https://bugs.webkit.org/attachment.cgi?id=208582&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:04:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:04:02 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 --- Comment #6 from Jinwoo Jeong 2013-08-12 19:03:36 PST --- Ok, I inserted some comment in ChangeLog. But the code that you checked is the deletion part of my changes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:10:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:10:49 -0700 Subject: [Webkit-unassigned] [Bug 119585] [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119585 Ryuan Choi changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |ryuan.choi at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:12:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:12:49 -0700 Subject: [Webkit-unassigned] [Bug 119706] Move id attribute to parent Element interface In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119706 Syoichi Tsuyuhara changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |syoichi at outlook.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:13:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:13:06 -0700 Subject: [Webkit-unassigned] [Bug 119712] Remove support for 'pixel' and 'pos' CSSOM prefixes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119712 Syoichi Tsuyuhara changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |syoichi at outlook.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:13:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:13:19 -0700 Subject: [Webkit-unassigned] [Bug 119711] Make CSS property user-select:none not to affect Document.caretRangeFromPoint() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119711 Syoichi Tsuyuhara changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |syoichi at outlook.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:17:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:17:13 -0700 Subject: [Webkit-unassigned] [Bug 119712] Remove support for 'pixel' and 'pos' CSSOM prefixes In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119712 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rniwa at webkit.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:18:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:18:34 -0700 Subject: [Webkit-unassigned] [Bug 118043] Mouse press should focus on any types of form controls In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118043 --- Comment #1 from Ryosuke Niwa 2013-08-12 19:18:09 PST --- Also merge https://chromium.googlesource.com/chromium/blink/+/543428b511b8fa108a740d2f707b10490dae20db -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:19:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:19:49 -0700 Subject: [Webkit-unassigned] [Bug 119713] New: Remove focus if supportsFocus state is changed Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119713 Summary: Remove focus if supportsFocus state is changed Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: ap at webkit.org, tkent at chromium.org Consider merging https://chromium.googlesource.com/chromium/blink/+/bdf4e305bcf5a7ab899f06a2cc697acaa9ab8116 Changes of *[tabindex], a[href], button[disabled], etc. affect focusable state, but these changes don't always trigger layout. We need to ask focus check explicitly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:21:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:21:30 -0700 Subject: [Webkit-unassigned] [Bug 119714] New: On request error, always fire events on the XMLHttpRequestUpload before the XMLHttpRequest Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119714 Summary: On request error, always fire events on the XMLHttpRequestUpload before the XMLHttpRequest Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: Page Loading AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: ap at webkit.org, dchris at gmail.com Consider merging https://chromium.googlesource.com/chromium/blink/+/20f42ed7623cc7366293ca610e6f40609185a591 On request error, fire events on the XMLHttpRequestUpload object before the XMLHttpRequest object as per the latest specification: http://xhr.spec.whatwg.org/#request-error IE10 behaves according to specification but blink was firing the events on the XMLHttpRequest object BEFORE the XMLHttpRequestUpload object in case of 'network error' or 'abort error'. Blink was however behaving according to specification in case of 'timeout error', which was inconsistent. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:23:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:23:28 -0700 Subject: [Webkit-unassigned] =?utf-8?q?=5BBug_119472=5D_REGRESSION_=28r153?= =?utf-8?q?106-r153334=29=3A_Function=2Eprototype=2Ecall=28=29_and_=2Eappl?= =?utf-8?b?eSgpICBpbiB3ZWIgd29ya2VyIGNhbuKAmXQgc2V0IOKAmHRoaXPigJkgdG8g?= =?utf-8?q?global_object?= In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119472 teeb changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REGRESSION: |REGRESSION |Function.prototype.call() |(r153106-r153334): |and .apply() in web worker |Function.prototype.call() |can?t set ?this? to global |and .apply() in web worker |object |can?t set ?this? to global | |object -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:33:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:33:32 -0700 Subject: [Webkit-unassigned] [Bug 118056] REGRESSION: Assertion failure !collection->hasExactlyOneItem() in WebCore::namedItemGetter In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118056 Rob Buis changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rwlbuis at gmail.com |kit.org | CC| |rwlbuis at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 19:36:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 19:36:16 -0700 Subject: [Webkit-unassigned] [Bug 119715] New: Fix variable name |end| -> |size| in EventTarget::fireEventListeners Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119715 Summary: Fix variable name |end| -> |size| in EventTarget::fireEventListeners Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: Event Handling AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: darin at apple.com, sam at webkit.org, ggaren at apple.com, benjamin at webkit.org, akling at apple.com Merge https://chromium.googlesource.com/chromium/blink/+/f58b017539c48059bb2b88d18ee0ee3d14decb01 |end| variables are used for iterators, so fix the variable name to |size| because it refers to an index. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:01:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:01:21 -0700 Subject: [Webkit-unassigned] [Bug 119715] Fix variable name |end| -> |size| in EventTarget::fireEventListeners In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119715 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rniwa at webkit.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:09:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:09:41 -0700 Subject: [Webkit-unassigned] [Bug 119716] New: Fix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119716 Summary: Fix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: mjs at apple.com, darin at apple.com, ap at webkit.org, jonlee at apple.com, thorton at apple.com Merge https://chromium.googlesource.com/chromium/blink/+/d5783da353ab783e9994b8fbecd91880be5192a1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:11:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:11:15 -0700 Subject: [Webkit-unassigned] [Bug 119716] Fix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119716 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |rniwa at webkit.org |kit.org | Attachment #208588| |review?, commit-queue? Flag| | --- Comment #1 from Ryosuke Niwa 2013-08-12 20:10:49 PST --- Created an attachment (id=208588) --> (https://bugs.webkit.org/attachment.cgi?id=208588&action=review) Fixes the bug -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:19:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:19:37 -0700 Subject: [Webkit-unassigned] [Bug 119717] New: [CSS Grid Layout] 2 span positions are not resolved correctly Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119717 Summary: [CSS Grid Layout] 2 span positions are not resolved correctly Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: hyatt at apple.com, bdakin at apple.com, jchaffraix at webkit.org, simon.fraser at apple.com, dino at apple.com Consider merging https://chromium.googlesource.com/chromium/blink/+/2245e6b85adf3c96ef9b34dc6c92d736aaba2aac The resolution code in resolveGridPositionsFromStyle had a bug where we would check for 2 'auto' positions to determine if we needed to run the auto-placement algorithm. However the specification considers other positions as being treat as 'auto' depending on the context. Due to this glitch, we would try to explicitly resolve a 'span' position yielding to ASSERTs and the wrong result. While touching some grid parsing tests, added a real grid container so they now also test the resolution code path. Also removed some unneeded internal overrides. TEST=grid-item-bad-resolution-double-span.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:21:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:21:26 -0700 Subject: [Webkit-unassigned] [Bug 85522] http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=85522 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208575| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:22:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:22:55 -0700 Subject: [Webkit-unassigned] [Bug 119718] New: Fix Document leak from NodeFilter Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119718 Summary: Fix Document leak from NodeFilter Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: mjs at apple.com, sam at webkit.org, ggaren at apple.com, oliver at apple.com, barraclough at apple.com Fix the problem https://chromium.googlesource.com/chromium/blink/+/65db79784ecd4a7e744d10a26befe5159638a56c fixed in WebKit if applicable. * Problem Description When NodeIterator/TreeWalker with filter JS callback is created, the following reference chain was created: NodeIterator -(RefPtr)-> NodeFilter -(RefPtr)-> V8NodeFilterCondition -(ScopedPersistent)-> JS callback object -> window This caused the whole document to be leaked when NodeIterator was referenced from window. For example, the following script created a circular reference which could not be collected. * Proposal This patch modifies the reference chain to avoid leak. The basic idea is to move the callback's whole reference chain to the V8 side. We change the strong reference to the JS callback object held by V8NodeFilterCondition to a weak reference. The JS callback is instead kept alive by a wrapper of NodeFilter, referenced from NodeIterator wrapper. The new reference chain is illustrated as follows: Blink world: NodeIterator -(RefPtr)-> NodeFilter -(RefPtr)-> V8NodeFilterCondition ^^^ ^^^ vvv(weakref)vvv V8 world: NodeIterator wrap -(HiddenProperty)-> NodeFilter wrap -(HiddenProperty)-> JS callback obj. -> window The new reference chain can be collected correctly, as the whole circular reference chain is visible from V8 GC. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:27:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:27:37 -0700 Subject: [Webkit-unassigned] [Bug 119719] New: Suppress zero-length text SVG inline renderers Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119719 Summary: Suppress zero-length text SVG inline renderers Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: SVG AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: zimmermann at kde.org, krit at webkit.org, jonlee at apple.com, pdr at google.com, thorton at apple.com Consider merging https://chromium.googlesource.com/chromium/blink/+/e4c158a33d34264796abfa683d0413568dfdcde0 The SVG text layout functions assert non-zero metrics for SVG inline text (see SVGTextLayoutEngine::layoutTextOnLineOrPath, for example). Normally, we don't instantiate renderers for zero-length inline text (see Text::textRendererIsNeeded), but the RenderSVGInlineText constructor performs whitespace filtering to support xml:space semantics (http://www.w3.org/TR/SVG/struct.html#LangSpaceAttrs) and can end up with empty text while still passing the non-zero length test in Text::textRendererIsNeeded (for example a single newline gets deleted when xml:space="default"). Enter RenderText::positionLineBox() which attempts to fix things up by removing zero length inline boxes. But removing boxes at this point is bad for business because it invalidates (marks as dirty and clears computed metrics) parent boxes and sibling boxes during layout, and throws subsequent computations off. The patch adds isChildAllowed()-based validation for SVG inline text. This prevents zero-len-text renderers from being inserted into the tree in the first place. Most test result diffs are zero-lenght DRT RenderSVGInlineText variance, but some reveal prior issues: * svg/W3C-SVG-1.1/text-align-08-b-diffs.html has incorrect results checked in (one text group is missing due to this bug). * svg/dom/altGlyph-dom.xhtml(altGlyph-dom.js) also has incorrect results hardcoded in. * svg/animations/length-list-animation.svg is failing miserably without this patch, but the failure is only visible when testing manually because the reference SVG is failing in the same manner. Also removing a redundant test in SVGTextLayoutEngine::currentVisualCharacterMetrics(): the while loop condition handles that case in an equivalent manner. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:44:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:44:12 -0700 Subject: [Webkit-unassigned] [Bug 85522] http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=85522 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208575|review+, commit-queue+ | Flag| | --- Comment #9 from WebKit Commit Bot 2013-08-12 20:43:47 PST --- (From update of attachment 208575) Clearing flags on attachment: 208575 Committed r153973: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:44:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:44:16 -0700 Subject: [Webkit-unassigned] [Bug 85522] http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=85522 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #10 from WebKit Commit Bot 2013-08-12 20:43:50 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:46:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:46:33 -0700 Subject: [Webkit-unassigned] [Bug 118626] Introduce non-virtual Node::isFocusable and virtual rendererIsFocusable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118626 --- Comment #1 from Ryosuke Niwa 2013-08-12 20:46:08 PST --- There has been a number of patches dependent on this one including https://chromium.googlesource.com/chromium/blink/+/a85c013184cf9e663f8bb74abbecfefc924807c0%5E%21/#F0 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:48:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:48:07 -0700 Subject: [Webkit-unassigned] [Bug 119721] New: Node::lazyReattach should avoid doing lots of work if already set to lazyAttach Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119721 Summary: Node::lazyReattach should avoid doing lots of work if already set to lazyAttach Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: hyatt at apple.com, koivisto at iki.fi, simon.fraser at apple.com, dino at apple.com, akling at apple.com Consider merging https://chromium.googlesource.com/chromium/blink/+/56066be33d1372c11c3f2f97af0fa34a663f16fe In r155380 I originally observed a 25-30% improvement in speed for ShadowDOM/LargeDistributionWithLayout:Runs, but the final bug I fixed in that patch before uploading turned that into a 30% performance regression. The reason for this is that we now correctly lazyAttach all distributed nodes when doing lazyAttach on an InsertionPoint while before we were incorrectly skipping this work leading to bugs. It turns out the biggest issue with the fix is that we now end up calling lazyReattach repeatedly on the same nodes as we go through the distribution process in the ContentDistributor. To avoid this we can make Node::lazyReattach smart enough to skip doing the detach() and lazyAttach() if the node is already set to lazyAttach. This restores the 25-30% improvement on ShadowDOM/LargeDistributionWithLayout:Runs and adds a 3-6% improvement on all other ShadowDOM/* perf tests. It should also improve our performance when doing large multi level reprojections since we'll no longer do the detach/lazyAttach work for each node as we reproject them down through the tree. Unfortunately when researching this I also realized that the LargeDistributionWithLayout perf test doesn't actually perf test layout time at all. I'll deal with the perf test itself in a follow up patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:53:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:53:13 -0700 Subject: [Webkit-unassigned] [Bug 119722] New: NodeList.item() does not behave according to specification Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119722 Summary: NodeList.item() does not behave according to specification Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate, InChromiumBugs, WebExposed Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: ap at webkit.org, ggaren at apple.com, oliver at apple.com, koivisto at iki.fi, akling at apple.com, dchris at gmail.com NodeList.item() does not behave according to specification: http://dom.spec.whatwg.org/#nodelist Namely, we should not throw if the index is negative (meaning we should drop the [IsIndex] extended attribute) and the argument should be mandatory. This behavior is consistent with both IE10 and Firefox. http://crbug.com/237739 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:53:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:53:45 -0700 Subject: [Webkit-unassigned] [Bug 119722] NodeList.item() does not behave according to specification In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119722 --- Comment #1 from Ryosuke Niwa 2013-08-12 20:53:20 PST --- https://chromium.googlesource.com/chromium/blink/+/772a8f92ccdcf997ebfbbcf185132a050e8132aa Also see https://chromium.googlesource.com/chromium/blink/+/33a9622c83dd9d85a7bd91b936bb2a31bd34f74b HTMLSelectElement.item() does not behave according to specification HTMLSelectElement.item() does not behave according to specification: http://www.w3.org/TR/html51/forms.html#dom-select-item http://dom.spec.whatwg.org/#dom-htmlcollection-item Namely, we should not throw if the offset argument is negative. Also, the argument should be mandatory. IE10 and Firefox do not throw when HTMLSelectElement.item() is called with a negative value (as per the specification). The argument is mandatory in Firefox but optional in IE10 (it returns null when called without argument). This looks like a bug in IE because other item() getters' argument is usually mandatory in IE (e.g. NodeList.item()). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:55:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:55:42 -0700 Subject: [Webkit-unassigned] [Bug 119625] [Performance]making HTMLSelectElement::usesMenuList() inline In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119625 --- Comment #10 from Santosh Mahto 2013-08-12 20:55:16 PST --- As per benjamin comments this bug can be closed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:56:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:56:11 -0700 Subject: [Webkit-unassigned] [Bug 119723] New: XMLTreeViewer should be created only in the XML viewer mode Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119723 Summary: XMLTreeViewer should be created only in the XML viewer mode Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: XML AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: ap at webkit.org, rwlbuis at gmail.com, koivisto at iki.fi, akling at apple.com, dchris at gmail.com Consider merging https://chromium.googlesource.com/chromium/blink/+/456b438748b9d091b62b0c992bd2bb35fe65e0cc Moving XMLTreeViewer::hasNoStyleInformation to be static inline method in XMLDocumentParser.cpp as it should not be the responsibility of XMLTreeViewer. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:57:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:57:32 -0700 Subject: [Webkit-unassigned] [Bug 119724] New: Canvas focus outline should match style in html.css Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119724 Summary: Canvas focus outline should match style in html.css Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: Canvas AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: hyatt at apple.com, simon.fraser at apple.com, dino at apple.com, enrica at apple.com, thorton at apple.com Perhaps we want to merge https://chromium.googlesource.com/chromium/blink/+/c546f38701339139bb7f7e8480bb369543dce4ec The default style of an element isn't quite right. The style that most elements get by default when focused is defined in html.css. There's no easy way to access this, so this change hardcodes the values and adds a comment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:58:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:58:17 -0700 Subject: [Webkit-unassigned] [Bug 119725] New: Simplify RadioNodeList's anonymous indexed getter Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119725 Summary: Simplify RadioNodeList's anonymous indexed getter Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: dchris at gmail.com Consider merging https://chromium.googlesource.com/chromium/blink/+/c06e3ea129f0a16eb4275a2c6bb9e77094bda632 Make RadioNodeList's anonymous indexed getter argument mandatory and drop the [IsIndex] IDL extended attribute. 'optional' and [IsIndex] have no effect on the generated code of anonymous indexed getters: - There is no way for the caller to omit the index - The generated code uses ObjectTemplate::SetIndexedPropertyHandler() and the IndexedPropertyGetterCallback takes a uint32_t in argument. There is no web-exposed behavior change, the generated bindings code is identical. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 20:58:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 20:58:35 -0700 Subject: [Webkit-unassigned] [Bug 119725] Simplify RadioNodeList's anonymous indexed getter In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119725 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com, | |ggaren at apple.com, | |koivisto at iki.fi, | |oliver at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 21:11:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 21:11:17 -0700 Subject: [Webkit-unassigned] [Bug 119727] New: Do not dispatch 'focus' or 'blur' event twice when window active state is changed Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119727 Summary: Do not dispatch 'focus' or 'blur' event twice when window active state is changed Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: Event Handling AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rniwa at webkit.org CC: darin at apple.com, ap at webkit.org, tkent at chromium.org, benjamin at webkit.org * Bug On Windows, 'focus' event for the window object or a focused element is dispatched twice when the browser tab gets active, and 'blue' evnet is dispatched twice when the browser tab gets inactive. On OSX, 'blur' evnet is dispatched twice when the browser tab gets inactive. On Android, we don't have this bug. * Root cause Focus/blue event is dispatched in dispatchEventsOnWindowAndFocusedNode in these cases. FocusController::setFocused(bool) calls it, and FocusController::setActive(bool) also calls it if setFocused(true) was already called. On Windows, these functions are called in the following sequence: Activation: WebView::setFocus(true) FocusController::setFocused(true) FocusController::setActive(true) WebView::setIsActive(true) Inactivation: WebView::setIsActive(false) FocusController::setActive(false) WebView::setFocus(false) FocusController::setFocused(false) On OSX, these functions are called in the following sequence: Activation: WebView::setIsActive(true) FocusController::setActive(true) WebView::setFocus(true) FocusController::setFocused(true) FocusController::setActive(true) Inactivation: WebView::setIsActive(false) FocusController::setActive(false) WebView::setFocus(false) FocusController::setFocused(false); On Android, these functions are called in the following sequence: Activation: WebView::setFocus(true) FocusController::setFocused(true) FocusController::setActive(true) Inactivation: WebView::setFocus(false) FocusController::setFocused(false); * Fix We don't need to call dispatchEventsOnWindowAndFocusedNode in setActive() because we don't make a window focused state true when the window is inactive. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 21:31:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 21:31:02 -0700 Subject: [Webkit-unassigned] [Bug 119625] [Performance]making HTMLSelectElement::usesMenuList() inline In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119625 Benjamin Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WONTFIX -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 21:57:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 21:57:19 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 22:00:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 22:00:26 -0700 Subject: [Webkit-unassigned] [Bug 119654] [Qt] Avoid calling QWebPage's virtual functions during deletion of QWebPage In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119654 --- Comment #10 from Arunprasad Rajkumar 2013-08-12 22:00:01 PST --- (In reply to comment #9) > Created an attachment (id=208566) --> (https://bugs.webkit.org/attachment.cgi?id=208566&action=review) [details] > Patch Allan, I feel calling unload implicitly from ~QWebViewPrivate & ~QGraphicsWebViewPrivate is more reasonable than closeEvent. What do you think? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 22:22:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 22:22:50 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208580|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 22:23:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 22:23:25 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208580| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 22:46:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 22:46:44 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208580|review+, commit-queue+ | Flag| | --- Comment #7 from WebKit Commit Bot 2013-08-12 22:46:20 PST --- (From update of attachment 208580) Clearing flags on attachment: 208580 Committed r153974: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 22:46:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 22:46:46 -0700 Subject: [Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119710 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #8 from WebKit Commit Bot 2013-08-12 22:46:22 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 22:54:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 22:54:00 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 --- Comment #7 from Christophe Dumez 2013-08-12 22:53:35 PST --- (In reply to comment #6) > Ok, I inserted some comment in ChangeLog. > But the code that you checked is the deletion part of my changes. Does keeping the 'char c' local variable really affect performance when building in release with -O2 or -O3? This would be surprising. What makes your code really faster is avoiding the call to set() and therefore skipping data validation (since you already know the data is fine). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 22:57:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 22:57:35 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 --- Comment #8 from Christophe Dumez 2013-08-12 22:57:10 PST --- (From update of attachment 208582) View in context: https://bugs.webkit.org/attachment.cgi?id=208582&action=review The change looks good overall. > Source/WebCore/ChangeLog:8 > + Use direct writing to target data instead of calling SET function. SET -> Uint8ClampedArray::set() > Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp:-171 > - unsigned char c = pixelArray->item(pixelOffset + channel); could we maybe keep "unsigned char c = data[pixelOffset + channel];" just to improve readability a bit. It shouldn't affect performance but let me know if I'm wrong. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:13:13 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:13:13 -0700 Subject: [Webkit-unassigned] [Bug 119728] New: extract-localizable-strings output is not suited for parsing by Xcode Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119728 Summary: extract-localizable-strings output is not suited for parsing by Xcode Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mitz at webkit.org The Xcode build log editor can identify warnings, errors and file references in script output, but some of the messages extract-localizable-strings prints fail to be parsed correctly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:17:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:17:43 -0700 Subject: [Webkit-unassigned] [Bug 119728] extract-localizable-strings output is not suited for parsing by Xcode In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119728 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208595| |review? Flag| | --- Comment #1 from mitz at webkit.org 2013-08-12 23:17:19 PST --- Created an attachment (id=208595) --> (https://bugs.webkit.org/attachment.cgi?id=208595&action=review) Change the format of some error and warning messages -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:17:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:17:55 -0700 Subject: [Webkit-unassigned] [Bug 119728] extract-localizable-strings output is not suited for parsing by Xcode In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119728 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:19:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:19:31 -0700 Subject: [Webkit-unassigned] [Bug 119728] extract-localizable-strings output is not suited for parsing by Xcode In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119728 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208595|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:25:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:25:58 -0700 Subject: [Webkit-unassigned] [Bug 119728] extract-localizable-strings output is not suited for parsing by Xcode In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119728 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from mitz at webkit.org 2013-08-12 23:25:34 PST --- Fixed in . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:32:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:32:04 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking] Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208398|0 |1 is obsolete| | Attachment #208398|review- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:32:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:32:14 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking] Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208597| |review? Flag| | --- Comment #6 from Andrei Parvu 2013-08-12 23:31:49 PST --- Created an attachment (id=208597) --> (https://bugs.webkit.org/attachment.cgi?id=208597&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:34:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:34:41 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking] Add -webkit-mask-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 --- Comment #7 from Andrei Parvu 2013-08-12 23:34:16 PST --- > > LayoutTests/ChangeLog:10 > > + * fast/masking/parsing-mask-type-expected.txt: Added. > > + * fast/masking/parsing-mask-type.html: Added. > > You can reuse the existing parsing-mask.html test. Just add your -webkit-mask-type tests there. Added some tests to the parsing-mask.html file. Also, I didn't remove my test file, because I wanted to test mask-source-type with multiple fill layers. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:35:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:35:08 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking] Add -webkit-mask-source-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 Andrei Parvu changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[CSS Masking] Add |[CSS Masking] Add |-webkit-mask-type property, |-webkit-mask-source-type |with alpha and luminance |property, with alpha and |values |luminance values -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:35:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:35:21 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208556|review? |review+ Flag| | --- Comment #6 from Carlos Garcia Campos 2013-08-12 23:34:56 PST --- (From update of attachment 208556) Thanks -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:45:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:45:07 -0700 Subject: [Webkit-unassigned] [Bug 119723] XMLTreeViewer should be created only in the XML viewer mode In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119723 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vivekg at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:46:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:46:41 -0700 Subject: [Webkit-unassigned] [Bug 119723] XMLTreeViewer should be created only in the XML viewer mode In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119723 --- Comment #1 from Vivek Galatage 2013-08-12 23:46:16 PST --- Hi, its already fixed in https://bugs.webkit.org/show_bug.cgi?id=119483 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:47:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:47:23 -0700 Subject: [Webkit-unassigned] [Bug 119706] Move id attribute to parent Element interface In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119706 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |dchris at gmail.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:48:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:48:04 -0700 Subject: [Webkit-unassigned] [Bug 119723] XMLTreeViewer should be created only in the XML viewer mode In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119723 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE --- Comment #2 from Ryosuke Niwa 2013-08-12 23:47:39 PST --- (In reply to comment #1) > Hi, its already fixed in https://bugs.webkit.org/show_bug.cgi?id=119483 Excellent! Thanks. *** This bug has been marked as a duplicate of bug 119483 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:55:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:55:14 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 Jinwoo Jeong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208582|0 |1 is obsolete| | Attachment #208582|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:55:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:55:23 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 Jinwoo Jeong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208600| |review? Flag| | --- Comment #9 from Jinwoo Jeong 2013-08-12 23:54:58 PST --- Created an attachment (id=208600) --> (https://bugs.webkit.org/attachment.cgi?id=208600&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 12 23:59:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 12 Aug 2013 23:59:37 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 --- Comment #10 from Christophe Dumez 2013-08-12 23:59:12 PST --- (From update of attachment 208600) View in context: https://bugs.webkit.org/attachment.cgi?id=208600&action=review > Source/WebCore/ChangeLog:11 > + The SET function has index checking code, value checking code and value casting code. nit: Please update other uses of SET in the changelog as well > Source/WebCore/ChangeLog:14 > + Thus all works in SET function is duplicated. duplicated -> redundant > Source/WebCore/ChangeLog:15 > + So deletion of calling SET function do not reduce stability, but improve the performance. Removing the call to set() does not reduce stability but improves performance. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:06:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:06:26 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 Przemyslaw Szymanski changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208519|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:06:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:06:53 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 Jinwoo Jeong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208600|0 |1 is obsolete| | Attachment #208600|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:07:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:07:03 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 Jinwoo Jeong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208601| |review? Flag| | --- Comment #11 from Jinwoo Jeong 2013-08-13 00:06:37 PST --- Created an attachment (id=208601) --> (https://bugs.webkit.org/attachment.cgi?id=208601&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:18:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:18:41 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208601|review? |review+ Flag| | --- Comment #12 from Christophe Dumez 2013-08-13 00:18:15 PST --- (From update of attachment 208601) Looks good, thanks. r=me but please let Dean take a final look before landing as he was reviewing this as well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:22:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:22:39 -0700 Subject: [Webkit-unassigned] [Bug 119714] On request error, always fire events on the XMLHttpRequestUpload before the XMLHttpRequest In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119714 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |dchris at gmail.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:30:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:30:07 -0700 Subject: [Webkit-unassigned] [Bug 119729] New: [EFL][GTK][Qt][WK1] New fast/dom/Window/open-zero-size-as-default.html test fails after r153913. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119729 Summary: [EFL][GTK][Qt][WK1] New fast/dom/Window/open-zero-size-as-default.html test fails after r153913. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abrhm at inf.u-szeged.hu CC: ap at webkit.org, ossy at webkit.org, zarvai at inf.u-szeged.hu, kadam at inf.u-szeged.hu Blocks: 87008 This new test fails on WK1. Result on EFL, Qt WK1 bots: Test that passing "height=0,width=0" to window.open() results in default window size. PASS FAIL: [0,0] http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r153979%20(52957)/fast/dom/Window/open-zero-size-as-default-pretty-diff.html Result on GTK bots: Test that passing "height=0,width=0" to window.open() results in default window size. PASS FAIL: [1,1] http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug%20WK1/r153975%20(3540)/fast/dom/Window/open-zero-size-as-default-pretty-diff.html Could you take a look please? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:30:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:30:08 -0700 Subject: [Webkit-unassigned] [Bug 87008] [Qt] Meta bug to fix newly added but failing tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=87008 G?bor ?brah?m changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119729 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:43:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:43:57 -0700 Subject: [Webkit-unassigned] [Bug 116295] [CSS Regions] Implement correct overflow handling in regions In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116295 Bug 116295 depends on bug 116296, which changed state. Bug 116296 Summary: [CSS Regions] Compute correct region ranges for boxes https://bugs.webkit.org/show_bug.cgi?id=116296 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:49:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:49:30 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 --- Comment #13 from Jinwoo Jeong 2013-08-13 00:49:04 PST --- CC'ing Dean, could you take a final look ? I would land this patch :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:50:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:50:01 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 Przemyslaw Szymanski changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208605| |review? Flag| | --- Comment #11 from Przemyslaw Szymanski 2013-08-13 00:49:36 PST --- Created an attachment (id=208605) --> (https://bugs.webkit.org/attachment.cgi?id=208605&action=review) Vertex attribute binding validation method -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:52:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:52:24 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 --- Comment #12 from Przemyslaw Szymanski 2013-08-13 00:51:59 PST --- Christophe, thank you very much for review. Changes applied. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:53:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:53:33 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208605|review? |review+ Flag| | --- Comment #13 from Christophe Dumez 2013-08-13 00:53:08 PST --- (From update of attachment 208605) Looks like a nice refactoring. r=me but please let Dean take a final look before landing as he was reviewing this as well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 00:56:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 00:56:27 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 --- Comment #7 from Alberto Garcia 2013-08-13 00:56:03 PST --- Fixed in . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:01:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:01:11 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:09:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:09:55 -0700 Subject: [Webkit-unassigned] [Bug 113546] [CSS Grid Layout] Align our grid-line handling with the updated specification In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113546 --- Comment #19 from Sergio Villar Senin 2013-08-13 01:09:28 PST --- (In reply to comment #18) > @svillar: > FOA, thanks for having interest on this bug. > Unfortunately, I don't have plan to continue this work in nearest future. > Furthermore, seems you are working on grid layout these days. > Therefore, considering my personal reason and keep consistency on implementation, would you take this bug and continue work on patch? :) Sure, I can take over it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:30:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:30:58 -0700 Subject: [Webkit-unassigned] [Bug 119722] NodeList.item() does not behave according to specification In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119722 Syoichi Tsuyuhara changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |syoichi at outlook.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:39:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:39:10 -0700 Subject: [Webkit-unassigned] [Bug 119725] Simplify RadioNodeList's anonymous indexed getter In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119725 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |dchris at gmail.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:41:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:41:04 -0700 Subject: [Webkit-unassigned] [Bug 119730] New: [GTK] fast/dom/Window/open-zero-size-as-default.html is failing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119730 Summary: [GTK] fast/dom/Window/open-zero-size-as-default.html is failing Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: Gtk, LayoutTestFailure Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: zandobersek at gmail.com The fast/dom/Window/open-zero-size-as-default.html layout test is failing on GTK since being added in r153913. http://trac.webkit.org/changeset/153913 --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/dom/Window/open-zero-size-as-default-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/dom/Window/open-zero-size-as-default-actual.txt @@ -1,3 +1,3 @@ Test that passing "height=0,width=0" to window.open() results in default window size. -PASS +FAIL: [1,1] -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:43:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:43:39 -0700 Subject: [Webkit-unassigned] [Bug 119731] New: [GTK] fast/images/exif-orientation-composited.html is failing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119731 Summary: [GTK] fast/images/exif-orientation-composited.html is failing Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: Gtk, LayoutTestFailure Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: zandobersek at gmail.com The fast/images/exif-orientation-composited.html layout test is failing since added in r153797. http://trac.webkit.org/changeset/153797 http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fimages%2Fexif-orientation-composited.html --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/images/exif-orientation-composited-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/images/exif-orientation-composited-actual.txt @@ -12,7 +12,7 @@ img1 size = 100px by 50px img2 size = 100px by 50px img3 size = 100px by 50px -img4 size = 50px by 100px -img5 size = 50px by 100px -img6 size = 50px by 100px -img7 size = 50px by 100px +img4 size = 100px by 50px +img5 size = 100px by 50px +img6 size = 100px by 50px +img7 size = 100px by 50px -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:43:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:43:58 -0700 Subject: [Webkit-unassigned] [Bug 119730] [GTK] fast/dom/Window/open-zero-size-as-default.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119730 --- Comment #1 from Zan Dobersek 2013-08-13 01:43:34 PST --- http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fdom%2FWindow%2Fopen-zero-size-as-default.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:46:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:46:09 -0700 Subject: [Webkit-unassigned] [Bug 119732] New: REGRESSION (r153925): fast/media/media-query-list-07.html is failing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119732 Summary: REGRESSION (r153925): fast/media/media-query-list-07.html is failing Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: LayoutTestFailure, Regression Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: zandobersek at gmail.com CC: sam at webkit.org, akling at apple.com The fast/media/media-query-list-07.html layout test is failing after changes in r153925. http://trac.webkit.org/changeset/153925 http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fmedia%2Fmedia-query-list-07.html Diff: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/media/media-query-list-07-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/media/media-query-list-07-actual.txt @@ -1,7 +1,6 @@ +CONSOLE MESSAGE: line 33: TypeError: Type error Test the MediaQueryList interface: http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface. Invalid listeners. Two callbacks are expected. -[1] - query (-webkit-view-mode: windowed) changed to false -[2] - query (-webkit-view-mode: windowed) changed to false -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:47:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:47:27 -0700 Subject: [Webkit-unassigned] [Bug 119733] New: [GTK] fast/regions/overflow-scrollable-2.html is failing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119733 Summary: [GTK] fast/regions/overflow-scrollable-2.html is failing Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: Gtk, LayoutTestFailure Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: zandobersek at gmail.com The fast/regions/overflow-scrollable-2.html reftest is failing since it was introduced in r153814. http://trac.webkit.org/changeset/153814 http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fregions%2Foverflow-scrollable-2.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:50:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:50:09 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #9 from Build Bot 2013-08-13 01:49:44 PST --- (From update of attachment 208570) Attachment 208570 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1378424 New failing tests: editing/style/remove-underline-across-paragraph-in-bold.html editing/inserting/editing-empty-divs.html editing/selection/caret-rtl.html editing/style/typing-style-003.html editing/selection/caret-ltr-right.html http/tests/inspector/inspect-element.html editing/pasteboard/copy-image-with-alt-text.html editing/pasteboard/paste-match-style-001.html editing/selection/caret-rtl-2-left.html editing/style/remove-underline-across-paragraph.html editing/selection/caret-ltr-2-left.html fast/html/details-remove-child-2.html fast/html/details-add-child-2.html editing/style/remove-underline.html fast/html/details-open2.html editing/selection/4983858.html editing/selection/caret-rtl-2.html editing/style/remove-underline-after-paragraph.html editing/selection/caret-rtl-right.html editing/inserting/editable-html-element.html editing/style/remove-underline-in-bold.html editing/style/remove-underline-after-paragraph-in-bold.html editing/style/remove-underline-from-stylesheet.html editing/selection/caret-ltr.html editing/selection/caret-ltr-2.html editing/style/underline.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:50:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:50:12 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #10 from Build Bot 2013-08-13 01:49:47 PST --- Created an attachment (id=208609) --> (https://bugs.webkit.org/attachment.cgi?id=208609&action=review) Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:51:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:51:51 -0700 Subject: [Webkit-unassigned] [Bug 119734] New: [GTK] plugins/navigator-plugins-disabled.html is failing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119734 Summary: [GTK] plugins/navigator-plugins-disabled.html is failing Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: Gtk, LayoutTestFailure Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: zandobersek at gmail.com The plugins/navigator-plugins-disabled.html layout test is failing since introduced in r153877. http://trac.webkit.org/changeset/153877 http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=plugins%2Fnavigator-plugins-disabled.html Diff: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/plugins/navigator-plugins-disabled-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/plugins/navigator-plugins-disabled-actual.txt @@ -1 +1,2 @@ -Passed! +Found non-application plug-in: WebKit Test PlugIn +Failed! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 01:53:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 01:53:37 -0700 Subject: [Webkit-unassigned] [Bug 119735] New: [GTK] plugins/unavailable-plugin-indicator-obscurity.html is failing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119735 Summary: [GTK] plugins/unavailable-plugin-indicator-obscurity.html is failing Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: Gtk, LayoutTestFailure Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: zandobersek at gmail.com The plugins/unavailable-plugin-indicator-obscurity.html layout test is failing since introduced in r153054. http://trac.webkit.org/changeset/153054 http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=plugins%2Funavailable-plugin-indicator-obscurity.html Diff: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/plugins/unavailable-plugin-indicator-obscurity-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/plugins/unavailable-plugin-indicator-obscurity-actual.txt @@ -1,30 +1,76 @@ -Expected to be obscured: -'tooSmall' was obscured: true (expected true; PASS) -'emptyRect' was obscured: true (expected true; PASS) -'lowOpacity' was obscured: true (expected true; PASS) -'lowOpacityParent' was obscured: true (expected true; PASS) -'stackedLowOpacityParents' was obscured: true (expected true; PASS) -'clippedByParent' was obscured: true (expected true; PASS) -'visibilityHidden' was obscured: true (expected true; PASS) -'visibilityHiddenOnParent' was obscured: true (expected true; PASS) -'pointerEventsBlocked' was obscured: true (expected true; PASS) -'pointerEventsBlockedOnParent' was obscured: true (expected true; PASS) -'pointerEventsBlockedOnObscuringSibling' was obscured: false (expected true; FAIL) -'leftHalfObscured' was obscured: true (expected true; PASS) -'rightHalfObscured' was obscured: true (expected true; PASS) -'topHalfObscured' was obscured: true (expected true; PASS) -'bottomHalfObscured' was obscured: true (expected true; PASS) -'centerObscured' was obscured: true (expected true; PASS) -'offScreenTopLeft' was obscured: true (expected true; PASS) -'offScreenTop' was obscured: true (expected true; PASS) -'offScreenLeft' was obscured: true (expected true; PASS) - -Expected to not be obscured: -'large' was obscured: false (expected false; PASS) -'stackedHighOpacityParents' was obscured: false (expected false; PASS) -'notClippedByParent' was obscured: false (expected false; PASS) -'topQuarterObscured' was obscured: false (expected false; PASS) -'bottomQuarterObscured' was obscured: false (expected false; PASS) - -Passed all tests: false - +CONSOLE MESSAGE: line 6: TypeError: undefined is not a function (evaluating 'testRunner.setBlockAllPlugins(true)') +layer at (0,0) size 785x9526 + RenderView at (0,0) size 785x600 +layer at (0,0) size 785x9526 + RenderBlock {HTML} at (0,0) size 785x9526 + RenderBody {BODY} at (8,8) size 769x9510 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 + RenderEmbeddedObject {EMBED} at (0,500) size 10x10 + RenderEmbeddedObject {EMBED} at (0,510) size 0x0 + RenderBlock {DIV} at (0,3010) size 20x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 + RenderEmbeddedObject {EMBED} at (0,3510) size 500x500 + RenderBlock {DIV} at (0,4010) size 769x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 + RenderEmbeddedObject {EMBED} at (0,4510) size 500x500 + RenderBlock {DIV} at (0,5010) size 769x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 + RenderBlock {DIV} at (0,9510) size 769x0 +layer at (8,2518) size 20x500 scrollWidth 500 + RenderBlock {DIV} at (0,2510) size 20x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (8,518) size 500x500 + RenderEmbeddedObject {EMBED} at (0,510) size 500x500 +layer at (8,1018) size 769x500 + RenderBlock {DIV} at (0,1010) size 769x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (8,1518) size 769x500 + RenderBlock {DIV} at (0,1510) size 769x500 +layer at (8,1518) size 769x500 + RenderBlock {DIV} at (0,0) size 769x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (8,2018) size 769x500 + RenderBlock {DIV} at (0,2010) size 769x500 +layer at (8,2018) size 769x500 + RenderBlock {DIV} at (0,0) size 769x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (8,5518) size 500x500 + RenderBlock (relative positioned) {DIV} at (0,5510) size 500x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (8,5518) size 500x500 + RenderBlock (positioned) {DIV} at (0,0) size 500x500 [bgcolor=#008000] +layer at (8,6018) size 500x500 + RenderBlock (relative positioned) {DIV} at (0,6010) size 500x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (8,6018) size 250x500 + RenderBlock (positioned) {DIV} at (0,0) size 250x500 [bgcolor=#008000] +layer at (8,6518) size 500x500 + RenderBlock (relative positioned) {DIV} at (0,6510) size 500x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (258,6518) size 250x500 + RenderBlock (positioned) {DIV} at (250,0) size 250x500 [bgcolor=#008000] +layer at (8,7018) size 500x500 + RenderBlock (relative positioned) {DIV} at (0,7010) size 500x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (8,7018) size 500x250 + RenderBlock (positioned) {DIV} at (0,0) size 500x250 [bgcolor=#008000] +layer at (8,7518) size 500x500 + RenderBlock (relative positioned) {DIV} at (0,7510) size 500x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (8,7768) size 500x250 + RenderBlock (positioned) {DIV} at (0,250) size 500x250 [bgcolor=#008000] +layer at (8,8018) size 500x500 + RenderBlock (relative positioned) {DIV} at (0,8010) size 500x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (8,8018) size 500x125 + RenderBlock (positioned) {DIV} at (0,0) size 500x125 [bgcolor=#008000] +layer at (8,8518) size 500x500 + RenderBlock (relative positioned) {DIV} at (0,8510) size 500x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (8,8893) size 500x125 + RenderBlock (positioned) {DIV} at (0,375) size 500x125 [bgcolor=#008000] +layer at (8,9018) size 500x500 + RenderBlock (relative positioned) {DIV} at (0,9010) size 500x500 + RenderEmbeddedObject {EMBED} at (0,0) size 500x500 +layer at (208,9218) size 100x100 + RenderBlock (positioned) {DIV} at (200,200) size 100x100 [bgcolor=#008000] -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 02:20:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 02:20:52 -0700 Subject: [Webkit-unassigned] [Bug 119736] New: [Qt] Fix build with gcc 4.3 to 4.5 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119736 Summary: [Qt] Fix build with gcc 4.3 to 4.5 Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: allan.jensen at digia.com Since we removed the nullptr use in JavaScriptCore, WebKit minus WebKit2 should build using gcc 4.3 and up, but currently fails on Qt because we forced C++11 off due back when JavaScriptCore didn't build with it enabled. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 02:21:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 02:21:51 -0700 Subject: [Webkit-unassigned] [Bug 119736] [Qt] Fix build with gcc 4.3 to 4.5 In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119736 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |allan.jensen at digia.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 02:23:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 02:23:28 -0700 Subject: [Webkit-unassigned] [Bug 113546] [CSS Grid Layout] Align our grid-line handling with the updated specification In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=113546 Sergio Villar Senin changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |svillar at igalia.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:02:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:02:40 -0700 Subject: [Webkit-unassigned] [Bug 119584] [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119584 Simon Pena changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.pena at samsung.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:13:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:13:40 -0700 Subject: [Webkit-unassigned] [Bug 26590] Support for String.trim(), String.trimLeft() and String.trimRight() methods In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=26590 Mathias Bynens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathias at qiwi.be -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:17:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:17:44 -0700 Subject: [Webkit-unassigned] [Bug 119737] New: [sh4] DFG_JIT implementation for sh4 architecture Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 Summary: [sh4] DFG_JIT implementation for sh4 architecture Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jbrianceau at nds.com I'll submit a DFG_JIT implementation proposal for sh4 architecture soon. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:19:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:19:18 -0700 Subject: [Webkit-unassigned] [Bug 119722] NodeList.item() does not behave according to specification In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119722 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |dchris at gmail.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:24:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:24:04 -0700 Subject: [Webkit-unassigned] [Bug 119739] New: Precision updates in WebAudio Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119739 Summary: Precision updates in WebAudio Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Audio AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: praveen.j at samsung.com CC: crogers at google.com, dev_sachin at yahoo.com Attributes minDecibels, maxDecibels and smoothingTimeConstant in AnalyserNode and currentTime in AudioContext should be of type double. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:33:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:33:14 -0700 Subject: [Webkit-unassigned] [Bug 119739] Precision updates in WebAudio In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119739 Praveen Jadhav changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208614| |review?, commit-queue? Flag| | --- Comment #1 from Praveen Jadhav 2013-08-13 03:32:49 PST --- Created an attachment (id=208614) --> (https://bugs.webkit.org/attachment.cgi?id=208614&action=review) Patch Patch includes one minor optimization in GStreamer porting file WebKitWebAudioSourceGStreamer.cpp -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:34:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:34:14 -0700 Subject: [Webkit-unassigned] [Bug 119739] Precision updates in WebAudio In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119739 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |dchris at gmail.com, | |eric.carlson at apple.com, | |esprehn+autocc at chromium.org | |, glenn at skynav.com, | |jer.noble at apple.com, | |kondapallykalyan at gmail.com, | |pnormand at igalia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:35:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:35:25 -0700 Subject: [Webkit-unassigned] [Bug 119088] [Qt] Crash in SimpleFontData, related to @font-face with non-existing src url In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119088 --- Comment #11 from Allan Sandfeld Jensen 2013-08-13 03:35:00 PST --- If you are seeing the crash on a 32bit machine then it could be the same as https://bugreports.qt-project.org/browse/QTBUG-32879 and explain why we don't see it on out 64bit development machines. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:37:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:37:00 -0700 Subject: [Webkit-unassigned] [Bug 119271] REGRESSION (r153145): fast/workers/worker-call.html fails In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119271 G?bor ?brah?m changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abrhm at inf.u-szeged.hu --- Comment #4 from G?bor ?brah?m 2013-08-13 03:36:35 PST --- On EFL, GTK and Qt ports this test timed out too, after the FTL merge. x64 debug stdio: 01:38:54.079 1617 worker/0 fast/workers/worker-call.html output stderr lines: 01:38:54.079 1617 FAIL: Timed out waiting for notifyDone to be called 01:38:54.080 1617 [18296/29688] fast/workers/worker-call.html failed unexpectedly (test timed out) 01:38:54.080 1617 worker/0 killing driver 01:38:54.080 1617 worker/0 fast/workers/worker-call.html failed: 01:38:54.080 1617 worker/0 test timed out http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/30024/steps/layout-test/logs/stdio/text Do you think this is the same problem? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:43:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:43:38 -0700 Subject: [Webkit-unassigned] [Bug 119584] [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119584 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zandobersek at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:44:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:44:36 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Bug 116980 depends on bug 116715, which changed state. Bug 116715 Summary: ASSERTION FAILED: type() == Percent in WebCore::Length::percent https://bugs.webkit.org/show_bug.cgi?id=116715 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:46:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:46:22 -0700 Subject: [Webkit-unassigned] [Bug 119739] Precision updates in WebAudio In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119739 --- Comment #2 from Christophe Dumez 2013-08-13 03:45:57 PST --- (From update of attachment 208614) View in context: https://bugs.webkit.org/attachment.cgi?id=208614&action=review > Source/WebCore/ChangeLog:7 > + Missing changelog > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:-246 > - for (unsigned channelIndex = 0; channelIndex < priv->bus->numberOfChannels(); channelIndex++) { Looks unrelated? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:50:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:50:25 -0700 Subject: [Webkit-unassigned] [Bug 119739] Precision updates in WebAudio In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119739 --- Comment #3 from Philippe Normand 2013-08-13 03:50:00 PST --- (From update of attachment 208614) View in context: https://bugs.webkit.org/attachment.cgi?id=208614&action=review >> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:-246 >> - for (unsigned channelIndex = 0; channelIndex < priv->bus->numberOfChannels(); channelIndex++) { > > Looks unrelated? This is unrelated, and how is this an optimization? This is how the GLib docs advize on how to fill a GSList. It's not the first time people try to optimize this code :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:54:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:54:15 -0700 Subject: [Webkit-unassigned] [Bug 119739] Precision updates in WebAudio In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119739 --- Comment #4 from Christophe Dumez 2013-08-13 03:53:50 PST --- (From update of attachment 208614) View in context: https://bugs.webkit.org/attachment.cgi?id=208614&action=review >>> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:-246 >>> - for (unsigned channelIndex = 0; channelIndex < priv->bus->numberOfChannels(); channelIndex++) { >> >> Looks unrelated? > > This is unrelated, and how is this an optimization? This is how the GLib docs advize on how to fill a GSList. It's not the first time people try to optimize this code :) Well, it avoids a call to g_slist_reverse() so it can only be faster IMHO. That said, this is a micro-optimization considering the number of channels (and thus the size of the list). In any case, this should not be in this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 03:57:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 03:57:35 -0700 Subject: [Webkit-unassigned] [Bug 119739] Precision updates in WebAudio In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119739 --- Comment #5 from Praveen Jadhav 2013-08-13 03:57:10 PST --- (In reply to comment #2) > (From update of attachment 208614 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208614&action=review > > > Source/WebCore/ChangeLog:7 > > + > > Missing changelog oh, I missed. Will update this shortly. > > > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:-246 > > - for (unsigned channelIndex = 0; channelIndex < priv->bus->numberOfChannels(); channelIndex++) { > > Looks unrelated? Its a minor change to avoid calling g_slist_reverse() API. So, thought of including this in the same bug. Will raise a new bug for this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 04:06:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 04:06:21 -0700 Subject: [Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109422 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HTML5, Qt -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 04:10:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 04:10:01 -0700 Subject: [Webkit-unassigned] [Bug 119739] Precision updates in WebAudio In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119739 Praveen Jadhav changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208614|0 |1 is obsolete| | Attachment #208614|review?, commit-queue? | Flag| | Attachment #208616| |review?, commit-queue? Flag| | --- Comment #6 from Praveen Jadhav 2013-08-13 04:09:35 PST --- Created an attachment (id=208616) --> (https://bugs.webkit.org/attachment.cgi?id=208616&action=review) Patch Patch updated as per the comments. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 04:38:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 04:38:22 -0700 Subject: [Webkit-unassigned] [Bug 117735] [curl] Improve multipart response handling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117735 --- Comment #8 from Peter Gal 2013-08-13 04:37:57 PST --- (In reply to comment #6) > (From update of attachment 206765 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206765&action=review > > > Source/WebCore/platform/network/curl/MultipartHandle.h:73 > > + ResourceHandle *m_resourceHandle; > > * should be part of the type. > > Since ResourceHandle is not 'owned' by this object, and the MultipartHandle cannot exist without a resource handle, I wonder if this should be a reference? In case of the FormDataStream the ResourceHandle is also a simple pointer (http://trac.webkit.org/browser/trunk/Source/WebCore/platform/network/curl/FormDataStreamCurl.h#L54) that's why I did the same here. Also note that in the headerCallback method the ResourceHandle ('job' variable) is pointer and for the 'client()->didReceive*' calls a pointer is required. Still I could change this to be a reference if you think that'll be better. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 04:41:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 04:41:52 -0700 Subject: [Webkit-unassigned] [Bug 119088] [Qt] Crash in SimpleFontData, related to @font-face with non-existing src url In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119088 --- Comment #12 from Allan Sandfeld Jensen 2013-08-13 04:41:27 PST --- Most likely caused by the patch for bug #118532 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 04:44:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 04:44:51 -0700 Subject: [Webkit-unassigned] [Bug 118532] [Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118532 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119740 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 04:44:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 04:44:53 -0700 Subject: [Webkit-unassigned] [Bug 118532] [Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118532 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #6 from WebKit Commit Bot 2013-08-13 04:44:28 PST --- Re-opened since this is blocked by bug 119740 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 04:52:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 04:52:46 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 --- Comment #1 from Julien Brianceau 2013-08-13 04:52:21 PST --- Created an attachment (id=208618) --> (https://bugs.webkit.org/attachment.cgi?id=208618&action=review) DFG_JIT implementation for sh4 architecture I've tested this patch on my sh4 board using r153882 and I didn't see regressions when running - Tools/Scripts/run-javascriptcore-tests - Tools/Scripts/run-fast-jsc - SunSpider 1.0 SunSpider 1.0 results on r153882 without this patch: ============================================ RESULTS (means and 95% confidence intervals) -------------------------------------------- Total: 13166.3ms +/- 0.2% -------------------------------------------- 3d: 2706.3ms +/- 0.5% cube: 837.8ms +/- 0.6% morph: 539.2ms +/- 0.7% raytrace: 1329.3ms +/- 0.7% access: 1905.7ms +/- 0.1% binary-trees: 114.2ms +/- 2.7% fannkuch: 1148.7ms +/- 0.4% nbody: 455.2ms +/- 1.0% nsieve: 187.7ms +/- 0.3% bitops: 1031.2ms +/- 0.4% 3bit-bits-in-byte: 78.2ms +/- 0.5% bits-in-byte: 111.2ms +/- 0.4% bitwise-and: 196.0ms +/- 0.0% nsieve-bits: 645.8ms +/- 0.6% controlflow: 74.0ms +/- 0.0% recursive: 74.0ms +/- 0.0% crypto: 1165.7ms +/- 1.3% aes: 666.2ms +/- 1.9% md5: 317.5ms +/- 1.1% sha1: 182.0ms +/- 2.0% date: 2085.0ms +/- 1.1% format-tofte: 925.7ms +/- 1.2% format-xparb: 1159.3ms +/- 1.3% math: 850.2ms +/- 1.1% cordic: 248.8ms +/- 3.8% partial-sums: 343.8ms +/- 2.7% spectral-norm: 257.5ms +/- 1.2% regexp: 531.0ms +/- 0.8% dna: 531.0ms +/- 0.8% string: 2817.3ms +/- 0.5% base64: 218.2ms +/- 0.5% fasta: 446.3ms +/- 3.2% tagcloud: 560.0ms +/- 1.1% unpack-code: 1255.2ms +/- 1.0% validate-input: 337.7ms +/- 2.2% SunSpider 1.0 results on r153882 with this patch: ============================================ RESULTS (means and 95% confidence intervals) -------------------------------------------- Total: 10122.6ms +/- 0.2% -------------------------------------------- 3d: 2440.8ms +/- 0.2% cube: 899.0ms +/- 0.3% morph: 278.5ms +/- 0.6% raytrace: 1263.3ms +/- 0.2% access: 882.0ms +/- 0.3% binary-trees: 106.5ms +/- 1.6% fannkuch: 289.3ms +/- 0.5% nbody: 335.9ms +/- 0.7% nsieve: 150.3ms +/- 0.7% bitops: 335.5ms +/- 0.6% 3bit-bits-in-byte: 29.2ms +/- 1.0% bits-in-byte: 74.6ms +/- 1.8% bitwise-and: 79.2ms +/- 0.4% nsieve-bits: 152.5ms +/- 0.9% controlflow: 96.1ms +/- 0.2% recursive: 96.1ms +/- 0.2% crypto: 886.4ms +/- 0.3% aes: 464.9ms +/- 0.6% md5: 251.0ms +/- 0.7% sha1: 170.5ms +/- 0.7% date: 1512.6ms +/- 0.4% format-tofte: 780.6ms +/- 0.7% format-xparb: 732.0ms +/- 0.7% math: 589.3ms +/- 0.4% cordic: 148.5ms +/- 0.3% partial-sums: 314.9ms +/- 0.6% spectral-norm: 125.9ms +/- 0.2% regexp: 529.1ms +/- 0.4% dna: 529.1ms +/- 0.4% string: 2850.8ms +/- 0.7% base64: 189.2ms +/- 0.9% fasta: 402.9ms +/- 0.9% tagcloud: 541.1ms +/- 0.6% unpack-code: 1323.1ms +/- 1.0% validate-input: 394.5ms +/- 1.5% -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 04:55:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 04:55:16 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin at webkit.org, | |cmarcelo at webkit.org, | |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 04:57:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 04:57:46 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fpizlo at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 04:57:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 04:57:54 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 04:58:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 04:58:09 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208618| |review?, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:14:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:14:02 -0700 Subject: [Webkit-unassigned] [Bug 118532] [Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118532 Bug 118532 depends on bug 119740, which changed state. Bug 119740 Summary: REGRESSION(r152563): causes random crashes (Requested by carewolf on #webkit). https://bugs.webkit.org/show_bug.cgi?id=119740 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:22:24 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:22:24 -0700 Subject: [Webkit-unassigned] [Bug 118532] [Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118532 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206393|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:22:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:22:31 -0700 Subject: [Webkit-unassigned] [Bug 118532] [Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118532 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |allan.jensen at digia.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:23:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:23:30 -0700 Subject: [Webkit-unassigned] [Bug 119741] New: [Win] Compile fixes. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119741 Summary: [Win] Compile fixes. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: peavo at outlook.com There are a number of compile errors in WebCore/page/win/DragControllerWin.cpp. Need to include required headers. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:27:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:27:14 -0700 Subject: [Webkit-unassigned] [Bug 119742] New: REGRESSION(FTL): Fix register usage in mips implementation of ctiVMThrowTrampolineSlowpath Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119742 Summary: REGRESSION(FTL): Fix register usage in mips implementation of ctiVMThrowTrampolineSlowpath Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: kilvadyb at homejinni.com CC: ggaren at apple.com, oliver at apple.com, fu at mips.com, msaboff at apple.com, fpizlo at apple.com, gergely at homejinni.com, jbrianceau at nds.com +++ This bug was initially created as a clone of Bug #119447 +++ Crashes are observed during javascriptcore tests around exception catching (lint_op_catch). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:32:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:32:00 -0700 Subject: [Webkit-unassigned] [Bug 119741] [Win] Compile fixes. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119741 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208620| |review? Flag| | --- Comment #1 from peavo at outlook.com 2013-08-13 05:31:35 PST --- Created an attachment (id=208620) --> (https://bugs.webkit.org/attachment.cgi?id=208620&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:32:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:32:34 -0700 Subject: [Webkit-unassigned] [Bug 119741] [Win] Compile fixes. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119741 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208620| |commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:32:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:32:46 -0700 Subject: [Webkit-unassigned] [Bug 119741] [Win] Compile fixes. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119741 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bfulgham at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:40:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:40:12 -0700 Subject: [Webkit-unassigned] [Bug 119742] REGRESSION(FTL): Fix register usage in mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119742 Balazs Kilvady changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208621| |review?, commit-queue? Flag| | --- Comment #1 from Balazs Kilvady 2013-08-13 05:39:47 PST --- Created an attachment (id=208621) --> (https://bugs.webkit.org/attachment.cgi?id=208621&action=review) proposed patch. Applying this patch all mozilla test are passed and SunSpider can runs also on MIPS boards. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:48:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:48:20 -0700 Subject: [Webkit-unassigned] [Bug 119584] [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119584 --- Comment #1 from Simon Pena 2013-08-13 05:47:54 PST --- I can take a look at this -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:50:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:50:29 -0700 Subject: [Webkit-unassigned] [Bug 119062] [GTK] Media Player's volume slider behavior is not consistent In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119062 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208545| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 05:56:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 05:56:20 -0700 Subject: [Webkit-unassigned] [Bug 119088] [Qt] Crash in SimpleFontData, related to @font-face with non-existing src url In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119088 --- Comment #13 from Milian Wolff 2013-08-13 05:55:56 PST --- Nope, I'm on a 64bit machine: Linux milian-kdab2 3.10.5-1-ARCH #1 SMP PREEMPT Mon Aug 5 08:04:22 CEST 2013 x86_64 GNU/Linux -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:00:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:00:16 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #33 from Rashmi Shyamasundar 2013-08-13 05:59:50 PST --- Please comment on the below function "replaceHTMLSpace()", which can be used instead of the existing function "replaceCharacterInString()" static void replaceHTMLSpace(String& text) { unsigned int textLength = text.length(); std::vector charVector(textLength); unsigned int i=0; while (i != textLength) { ch = text.characterStartingAt(i); if (!isHTMLSpace(ch)) charVector[i] = ch; else charVector[i] = ' '; i++; } charVector[i] = '\0'; string tempText(charVector.begin(), charVector.end()); String finalText(tempText.c_str(),textLength); text = finalText; } As suggested by Mr. Darin Adler, the above approach avoids the expensive memory re-allocations unlike the function replaceCharacterInString(). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:13:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:13:53 -0700 Subject: [Webkit-unassigned] [Bug 119062] [GTK] Media Player's volume slider behavior is not consistent In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119062 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208545|review+, commit-queue+ | Flag| | --- Comment #3 from WebKit Commit Bot 2013-08-13 06:13:28 PST --- (From update of attachment 208545) Clearing flags on attachment: 208545 Committed r154000: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:13:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:13:55 -0700 Subject: [Webkit-unassigned] [Bug 119062] [GTK] Media Player's volume slider behavior is not consistent In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119062 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from WebKit Commit Bot 2013-08-13 06:13:30 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:16:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:16:28 -0700 Subject: [Webkit-unassigned] [Bug 119088] [Qt] Crash in SimpleFontData, related to @font-face with non-existing src url In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119088 --- Comment #14 from Allan Sandfeld Jensen 2013-08-13 06:16:03 PST --- (In reply to comment #13) > Nope, I'm on a 64bit machine: > > Linux milian-kdab2 3.10.5-1-ARCH #1 SMP PREEMPT Mon Aug 5 08:04:22 CEST 2013 x86_64 GNU/Linux Yes, the bug seem to hit more than 32bit, but is kind of random. Have you tried to revert the patch from bug 118532 ? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:18:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:18:50 -0700 Subject: [Webkit-unassigned] [Bug 108664] [meta] MIPS related bugs In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108664 Balazs Kilvady changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119742 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:18:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:18:51 -0700 Subject: [Webkit-unassigned] [Bug 119742] REGRESSION(FTL): Fix register usage in mips implementation of ctiVMThrowTrampolineSlowpath In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119742 Balazs Kilvady changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |108664 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:24:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:24:46 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 --- Comment #8 from Gustavo Noronha (kov) 2013-08-13 06:24:21 PST --- (From update of attachment 208556) This appears to have caused a few API tests to fail: (./Tools/gtk/../Scripts/../../WebKitBuild/Release/Programs/unittests/testloading:9117): GLib-CRITICAL **: g_hash_table_lookup_extended: assertion `hash_table != NULL' failed (./Tools/gtk/../Scripts/../../WebKitBuild/Release/Programs/unittests/testhttpbackend:9159): GLib-CRITICAL **: g_hash_table_lookup_extended: assertion `hash_table != NULL' failed -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:27:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:27:32 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #34 from Christophe Dumez 2013-08-13 06:27:05 PST --- (In reply to comment #33) > Please comment on the below function "replaceHTMLSpace()", which can be used instead of the existing function "replaceCharacterInString()" > > static void replaceHTMLSpace(String& text) > { > unsigned int textLength = text.length(); > std::vector charVector(textLength); > > unsigned int i=0; > while (i != textLength) > { > ch = text.characterStartingAt(i); > if (!isHTMLSpace(ch)) > charVector[i] = ch; > else > charVector[i] = ' '; > i++; > } > charVector[i] = '\0'; > string tempText(charVector.begin(), charVector.end()); > String finalText(tempText.c_str(),textLength); > text = finalText; > } A few comments comments: - Looks like you could use a for loop. - You can use String::adopt() to avoid copying the input Vector - You don't handle vertical spaces anymore - As Darin advised, you should not replace ' ' (U+0020) chars by ' '. The space matching function should return false for those - Use a WTF::Vector, not a std::vector - iirc Darin wanted to allocate memory only if there is at least 1 char that needs replacing - You can use operator[] instead of characterStartingAt() -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:28:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:28:30 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208618|commit-queue? |commit-queue- Flag| | --- Comment #2 from Julien Brianceau 2013-08-13 06:28:05 PST --- (From update of attachment 208618) I cq- because I just saw that this patch introduces a regression (crash) in v8-v4 test suite. However, I'd still be happy to get feedbacks on this patch, especially the "SH4_32BIT_DUMMY_ARG" part introduced in DFGSpeculativeJIT.h. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:30:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:30:56 -0700 Subject: [Webkit-unassigned] [Bug 119743] New: [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119743 Summary: [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit2 AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cgarcia at igalia.com CC: andersca at apple.com, sam at webkit.org, gns at gnome.org, mrobinson at webkit.org, svillar at igalia.com Blocks: 103377 This is required for the javascript injection and isolated worlds API. See https://lists.webkit.org/pipermail/webkit-gtk/2013-August/001535.html. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:30:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:30:57 -0700 Subject: [Webkit-unassigned] [Bug 103377] Add GTK+ WebKit2 API for isolated worlds In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=103377 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119743 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:32:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:32:06 -0700 Subject: [Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=108881 --- Comment #35 from Rashmi Shyamasundar 2013-08-13 06:31:40 PST --- (In reply to comment #33) > Please comment on the below function "replaceHTMLSpace()", which can be used instead of the existing function "replaceCharacterInString()" > > static void replaceHTMLSpace(String& text) > { > unsigned int textLength = text.length(); > std::vector charVector(textLength); > > unsigned int i=0; > while (i != textLength) > { > ch = text.characterStartingAt(i); > if (!isHTMLSpace(ch)) > charVector[i] = ch; > else > charVector[i] = ' '; > i++; > } > charVector[i] = '\0'; > string tempText(charVector.begin(), charVector.end()); > String finalText(tempText.c_str(),textLength); > text = finalText; > } > > > As suggested by Mr. Darin Adler, the above approach avoids the expensive memory re-allocations unlike the function replaceCharacterInString(). Re-wrote the function replaceHTMLSpace() as below :- static void replaceHTMLSpace(String& text) { unsigned int textLength = text.length(); const UChar *textArray = text.characters(); UChar *finalTextArray = new UChar[textLength]; UChar ch; unsigned int i=0; while (i != textLength) { ch = textArray[i]; if (!isHTMLSpace(ch)) finalTextArray[i] = ch; else finalTextArray[i] = ' '; i++; } String finalText(finalTextArray, textLength); text = finalText; } -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:44:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:44:52 -0700 Subject: [Webkit-unassigned] [Bug 119743] [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119743 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208624| |review? Flag| | --- Comment #1 from Carlos Garcia Campos 2013-08-13 06:44:27 PST --- Created an attachment (id=208624) --> (https://bugs.webkit.org/attachment.cgi?id=208624&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:46:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:46:45 -0700 Subject: [Webkit-unassigned] [Bug 119743] [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119743 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abecsi at webkit.org, | |alexis at webkit.org, | |cmarcelo at webkit.org, | |commit-queue at webkit.org, | |dchris at gmail.com, | |gyuyoung.kim at webkit.org, | |rakuco at webkit.org, | |zandobersek at gmail.com --- Comment #2 from WebKit Commit Bot 2013-08-13 06:46:20 PST --- Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:51:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:51:39 -0700 Subject: [Webkit-unassigned] [Bug 119744] New: [Curl] Possible infinite loop while downloading. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119744 Summary: [Curl] Possible infinite loop while downloading. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: peavo at outlook.com If the methods addToCurl() or removeFromCurl() in the curl download manager fails (WebCore/platform/network/curl/CurlDownload.cpp), the download thread might get stuck in an endless loop, while trying to update the curl handle list (in the method updateHandleList()). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:52:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:52:11 -0700 Subject: [Webkit-unassigned] [Bug 119743] [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119743 Rego GTK+ EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rego+ews at igalia.com, | |xan.lopez at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 06:55:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 06:55:32 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 --- Comment #9 from Alberto Garcia 2013-08-13 06:55:07 PST --- (In reply to comment #8) > (./Tools/gtk/../Scripts/../../WebKitBuild/Release/Programs/unittests/testloading:9117): GLib-CRITICAL **: g_hash_table_lookup_extended: assertion `hash_table != NULL' failed > (./Tools/gtk/../Scripts/../../WebKitBuild/Release/Programs/unittests/testhttpbackend:9159): GLib-CRITICAL **: g_hash_table_lookup_extended: assertion `hash_table != NULL' failed I think this is because of putting the code after the parent's dispose call. Going back to my original solution should fix this. I'll upload a new patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:00:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:00:03 -0700 Subject: [Webkit-unassigned] [Bug 119744] [Curl] Possible infinite loop while downloading. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119744 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208625| |review? Flag| | --- Comment #1 from peavo at outlook.com 2013-08-13 06:59:38 PST --- Created an attachment (id=208625) --> (https://bugs.webkit.org/attachment.cgi?id=208625&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:00:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:00:35 -0700 Subject: [Webkit-unassigned] [Bug 119744] [Curl] Possible infinite loop while downloading. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119744 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208625| |commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:00:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:00:51 -0700 Subject: [Webkit-unassigned] [Bug 119744] [Curl] Possible infinite loop while downloading. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119744 peavo at outlook.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bfulgham at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:01:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:01:45 -0700 Subject: [Webkit-unassigned] [Bug 19008] incorrect table border due to colSpan In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=19008 Suchit Agrawal changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suchit.agrawal at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:01:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:01:50 -0700 Subject: [Webkit-unassigned] [Bug 119744] [Curl] Possible infinite loop while downloading. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119744 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |galpeter at inf.u-szeged.hu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:42:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:42:43 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208570|0 |1 is obsolete| | --- Comment #11 from Antti Koivisto 2013-08-13 07:42:17 PST --- Created an attachment (id=208629) --> (https://bugs.webkit.org/attachment.cgi?id=208629&action=review) another -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:44:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:44:38 -0700 Subject: [Webkit-unassigned] [Bug 119743] [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119743 kov's GTK+ EWS bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gtk-ews at kov.eti.br -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:44:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:44:41 -0700 Subject: [Webkit-unassigned] [Bug 119743] [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119743 kov's GTK+ EWS bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208624| |commit-queue- Flag| | --- Comment #3 from kov's GTK+ EWS bot 2013-08-13 07:44:15 PST --- (From update of attachment 208624) Attachment 208624 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1452440 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:53:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:53:20 -0700 Subject: [Webkit-unassigned] [Bug 119747] New: svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html asserts flakily Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119747 Summary: svg/text/text-overflow-ellipsis-svgfont-kerning-ligatu res.html asserts flakily Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Text AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: koivisto at iki.fi Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r153990%20(11617)/results.html Exception Codes: KERN_INVALID_ADDRESS at 0x00000000bbadbeef VM Regions Near 0xbbadbeef: --> __TEXT 000000010fc9d000-000000010fc9e000 [ 4K] r-x/rwx SM=COW /Volumes/VOLUME/*/WebKit2.framework/WebProcess.app/Contents/MacOS/WebProcess Application Specific Information: CRASHING TEST: svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000011195c55a WTFCrash + 42 (Assertions.cpp:342) 1 com.apple.WebCore 0x000000011287d5ef WebCore::ComplexTextController::offsetForPosition(float, bool) + 2623 (ComplexTextController.cpp:258) 2 com.apple.WebCore 0x0000000112d5ee00 WebCore::Font::offsetForPositionForComplexText(WebCore::TextRun const&, float, bool) const + 144 (FontComplexTextMac.cpp:124) 3 com.apple.WebCore 0x0000000112d41dc6 WebCore::Font::offsetForPosition(WebCore::TextRun const&, float, bool) const + 150 (Font.cpp:380) 4 com.apple.WebCore 0x000000011307c768 WebCore::InlineTextBox::offsetForPosition(float, bool) const + 504 (InlineTextBox.cpp:1555) 5 com.apple.WebCore 0x000000011307452a WebCore::InlineTextBox::placeEllipsisBox(bool, float, float, float, float&, bool&) + 938 (InlineTextBox.cpp:294) 6 com.apple.WebCore 0x0000000113069179 WebCore::InlineFlowBox::placeEllipsisBox(bool, float, float, float, float&, bool&) + 233 (InlineFlowBox.cpp:1485) 7 com.apple.WebCore 0x0000000113c83d2e WebCore::RootInlineBox::placeEllipsisBox(bool, float, float, float, float&, bool&) + 94 (RootInlineBox.cpp:163) 8 com.apple.WebCore 0x0000000113c83c9c WebCore::RootInlineBox::placeEllipsis(WTF::AtomicString const&, bool, float, float, float, WebCore::InlineBox*) + 844 (RootInlineBox.cpp:156) 9 com.apple.WebCore 0x00000001139e0889 WebCore::RenderBlock::checkLinesForTextOverflow() + 1545 (RenderBlockLineLayout.cpp:3615) 10 com.apple.WebCore 0x00000001139dfe89 WebCore::RenderBlock::layoutInlineChildren(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&) + 2729 (RenderBlockLineLayout.cpp:2212) 11 com.apple.WebCore 0x000000011397d715 WebCore::RenderBlock::layoutBlock(bool, WebCore::LayoutUnit) + 1205 (RenderBlock.cpp:1645) 12 com.apple.WebCore 0x000000011397ca2d WebCore::RenderBlock::layout() + 125 (RenderBlock.cpp:1432) 13 com.apple.WebCore 0x000000011398a242 WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) + 1266 (RenderBlock.cpp:2664) 14 com.apple.WebCore 0x000000011397feb6 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::LayoutUnit&) + 614 (RenderBlock.cpp:2596) 15 com.apple.WebCore 0x000000011397d738 WebCore::RenderBlock::layoutBlock(bool, WebCore::LayoutUnit) + 1240 (RenderBlock.cpp:1650) 16 com.apple.WebCore 0x000000011397ca2d WebCore::RenderBlock::layout() + 125 (RenderBlock.cpp:1432) 17 com.apple.WebCore 0x000000011398a242 WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) + 1266 (RenderBlock.cpp:2664) 18 com.apple.WebCore 0x000000011397feb6 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::LayoutUnit&) + 614 (RenderBlock.cpp:2596) 19 com.apple.WebCore 0x000000011397d738 WebCore::RenderBlock::layoutBlock(bool, WebCore::LayoutUnit) + 1240 (RenderBlock.cpp:1650) 20 com.apple.WebCore 0x000000011397ca2d WebCore::RenderBlock::layout() + 125 (RenderBlock.cpp:1432) 21 com.apple.WebCore 0x000000011398a242 WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) + 1266 (RenderBlock.cpp:2664) 22 com.apple.WebCore 0x000000011397feb6 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::LayoutUnit&) + 614 (RenderBlock.cpp:2596) 23 com.apple.WebCore 0x000000011397d738 WebCore::RenderBlock::layoutBlock(bool, WebCore::LayoutUnit) + 1240 (RenderBlock.cpp:1650) 24 com.apple.WebCore 0x000000011397ca2d WebCore::RenderBlock::layout() + 125 (RenderBlock.cpp:1432) 25 com.apple.WebCore 0x0000000113c3c0ed WebCore::RenderView::layoutContent(WebCore::LayoutState const&) + 93 (RenderView.cpp:143) 26 com.apple.WebCore 0x0000000113c3cfd5 WebCore::RenderView::layout() + 1349 (RenderView.cpp:327) 27 com.apple.WebCore 0x0000000112dcdea2 WebCore::FrameView::layout(bool) + 3218 (FrameView.cpp:1333) 28 com.apple.WebCore 0x0000000112b2dd8f WebCore::Document::implicitClose() + 991 (Document.cpp:2419) 29 com.apple.WebCore 0x0000000112da461b WebCore::FrameLoader::checkCallImplicitClose() + 155 (FrameLoader.cpp:851) 30 com.apple.WebCore 0x0000000112da4296 WebCore::FrameLoader::checkCompleted() + 358 (FrameLoader.cpp:795) 31 com.apple.WebCore 0x0000000112da2e28 WebCore::FrameLoader::finishedParsing() + 184 (FrameLoader.cpp:728) 32 com.apple.WebCore 0x0000000112b38a0b WebCore::Document::finishedParsing() + 475 (Document.cpp:4393) 33 com.apple.WebCore 0x0000000112ef6378 WebCore::HTMLConstructionSite::finishedParsing() + 24 (HTMLConstructionSite.cpp:349) 34 com.apple.WebCore 0x0000000112fe9b24 WebCore::HTMLTreeBuilder::finished() + 116 (HTMLTreeBuilder.cpp:2927) 35 com.apple.WebCore 0x0000000112f160fe WebCore::HTMLDocumentParser::end() + 174 (HTMLDocumentParser.cpp:764) 36 com.apple.WebCore 0x0000000112f14b52 WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() + 242 (HTMLDocumentParser.cpp:775) 37 com.apple.WebCore 0x0000000112f1497f WebCore::HTMLDocumentParser::prepareToStopParsing() + 271 (HTMLDocumentParser.cpp:212) 38 com.apple.WebCore 0x0000000112f16153 WebCore::HTMLDocumentParser::attemptToEnd() + 67 (HTMLDocumentParser.cpp:787) 39 com.apple.WebCore 0x0000000112f161a8 WebCore::HTMLDocumentParser::finish() + 72 (HTMLDocumentParser.cpp:836) 40 com.apple.WebCore 0x0000000112ba17ba WebCore::DocumentWriter::end() + 346 (DocumentWriter.cpp:249) 41 com.apple.WebCore 0x0000000112b70693 WebCore::DocumentLoader::finishedLoading(double) + 595 (DocumentLoader.cpp:403) 42 com.apple.WebCore 0x0000000112b703ae WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource*) + 270 (DocumentLoader.cpp:345) 43 com.apple.WebCore 0x000000011281a11d WebCore::CachedResource::checkNotify() + 109 (CachedResource.cpp:369) 44 com.apple.WebCore 0x000000011281a234 WebCore::CachedResource::finishLoading(WebCore::ResourceBuffer*) + 52 (CachedResource.cpp:386) 45 com.apple.WebCore 0x000000011281447b WebCore::CachedRawResource::finishLoading(WebCore::ResourceBuffer*) + 187 (CachedRawResource.cpp:95) 46 com.apple.WebCore 0x0000000113e3d12b WebCore::SubresourceLoader::didFinishLoading(double) + 459 (SubresourceLoader.cpp:284) 47 com.apple.WebCore 0x0000000113c6b935 WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) + 53 (ResourceLoader.cpp:489) 48 com.apple.WebCore 0x000000011404d5fa -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] + 186 (WebCoreResourceHandleAsDelegate.mm:234) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:53:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:53:31 -0700 Subject: [Webkit-unassigned] [Bug 119747] svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html asserts flakily In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119747 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.carlson at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:54:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:54:16 -0700 Subject: [Webkit-unassigned] [Bug 119747] svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html asserts flakily In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119747 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |MakingBotsRed -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 07:57:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 07:57:22 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 Alberto Garcia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208556|0 |1 is obsolete| | Attachment #208630| |review? Flag| | --- Comment #10 from Alberto Garcia 2013-08-13 07:56:57 PST --- Created an attachment (id=208630) --> (https://bugs.webkit.org/attachment.cgi?id=208630&action=review) Patch Here's the patch with the original fix. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:04:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:04:52 -0700 Subject: [Webkit-unassigned] [Bug 119748] New: ASSERTION FAILED: resultAnimationElement->m_animatedType in WebCore::SVGAnimateElement::calculateAnimatedValue Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119748 Summary: ASSERTION FAILED: resultAnimationElement->m_animatedType in WebCore::SVGAnimateElement::calculateAnimatedValue Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: P2 Component: SVG AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: reni at webkit.org CC: zimmermann at kde.org Blocks: 116980 The failing test: Backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff56f5744 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 342 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) bt #0 0x00007ffff56f5744 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 #1 0x00007ffff4c56b5a in WebCore::SVGAnimateElement::calculateAnimatedValue (this=0x8d99d0, percentage=1, repeatCount=0, resultElement=0x8d99d0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/svg/SVGAnimateElement.cpp:120 #2 0x00007ffff4c5e678 in WebCore::SVGAnimationElement::updateAnimation (this=0x8d99d0, percent=0, repeatCount=0, resultElement=0x8d99d0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/svg/SVGAnimationElement.cpp:632 #3 0x00007ffff4c09c19 in WebCore::SVGSMILElement::progress (this=0x8d99d0, elapsed=..., resultElement=0x8d99d0, seekToTime=false) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/svg/animation/SVGSMILElement.cpp:1113 #4 0x00007ffff4bffdd1 in WebCore::SMILTimeContainer::updateAnimations (this=0x8b5050, elapsed=..., seekToTime=false) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/svg/animation/SMILTimeContainer.cpp:293 #5 0x00007ffff4bff2cb in WebCore::SMILTimeContainer::begin (this=0x8b5050) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/svg/animation/SMILTimeContainer.cpp:139 #6 0x00007ffff4c24c01 in WebCore::SVGDocumentExtensions::startAnimations (this=0x8b70f0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/svg/SVGDocumentExtensions.cpp:102 #7 0x00007ffff41b2ec6 in WebCore::Document::implicitClose (this=0x89e3a0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:2453 #8 0x00007ffff45b311d in WebCore::FrameLoader::checkCallImplicitClose (this=0x7d5998) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:844 #9 0x00007ffff45b2e8e in WebCore::FrameLoader::checkCompleted (this=0x7d5998) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:787 #10 0x00007ffff45b2bc3 in WebCore::FrameLoader::finishedParsing (this=0x7d5998) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:720 #11 0x00007ffff41b9e37 in WebCore::Document::finishedParsing (this=0x89e3a0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:4404 #12 0x00007ffff440b2a1 in WebCore::HTMLConstructionSite::finishedParsing (this=0x7d3068) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLConstructionSite.cpp:348 #13 0x00007ffff443f9c3 in WebCore::HTMLTreeBuilder::finished (this=0x7d3050) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2926 #14 0x00007ffff44129a0 in WebCore::HTMLDocumentParser::end (this=0x794b70) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:763 #15 0x00007ffff4412a8b in WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd (this=0x794b70) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:774 #16 0x00007ffff44115fa in WebCore::HTMLDocumentParser::prepareToStopParsing (this=0x794b70) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:211 #17 0x00007ffff4412ad0 in WebCore::HTMLDocumentParser::attemptToEnd (this=0x794b70) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:786 #18 0x00007ffff4412b89 in WebCore::HTMLDocumentParser::finish (this=0x794b70) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:835 #19 0x00007ffff45aaa23 in WebCore::DocumentWriter::end (this=0x6942f0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentWriter.cpp:248 #20 0x00007ffff459d562 in WebCore::DocumentLoader::finishedLoading (this=0x694250, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:402 #21 0x00007ffff459d2d0 in WebCore::DocumentLoader::notifyFinished (this=0x694250, resource=0x7b0020) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:344 #22 0x00007ffff45845c6 in WebCore::CachedResource::checkNotify (this=0x7b0020) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:369 #23 0x00007ffff458469c in WebCore::CachedResource::finishLoading (this=0x7b0020) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:385 #24 0x00007ffff4580dee in WebCore::CachedRawResource::finishLoading (this=0x7b0020, data=0x7cc480) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedRawResource.cpp:94 #25 0x00007ffff45e73e3 in WebCore::SubresourceLoader::didFinishLoading (this=0x775d20, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/SubresourceLoader.cpp:282 #26 0x00007ffff45ddccd in WebCore::ResourceLoader::didFinishLoading (this=0x775d20, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/ResourceLoader.cpp:488 #27 0x00007ffff4a87683 in WebCore::QNetworkReplyHandler::finish (this=0x7bcfd0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:516 #28 0x00007ffff4a863a2 in WebCore::QNetworkReplyHandlerCallQueue::flush (this=0x7bd008) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:250 #29 0x00007ffff4a8609f in WebCore::QNetworkReplyHandlerCallQueue::push (this=0x7bd008, ---Type to continue, or q to quit--- method=(void (WebCore::QNetworkReplyHandler::*)(WebCore::QNetworkReplyHandler * const)) 0x7ffff4a874c8 ) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:216 #30 0x00007ffff4a86fec in WebCore::QNetworkReplyWrapper::didReceiveFinished (this=0x7cbce0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:409 #31 0x00007ffff4a8997e in WebCore::QNetworkReplyWrapper::qt_static_metacall (_o=0x7cbce0, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffffffcf80) at .moc/release-shared/moc_QNetworkReplyHandler.cpp:176 #32 0x00007ffff22115cb in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #33 0x00007ffff221284e in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #34 0x00007ffff3058dbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #35 0x00007ffff305c075 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #36 0x00007ffff21ecdbe in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #37 0x00007ffff21eea76 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #38 0x00007ffff2234333 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #39 0x00007fffee3790a6 in g_main_dispatch (context=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3058 #40 g_main_context_dispatch (context=context at entry=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3634 #41 0x00007fffee3793f8 in g_main_context_iterate (context=context at entry=0x6632f0, block=block at entry=1, dispatch=dispatch at entry=1, self=) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3705 #42 0x00007fffee37949c in g_main_context_iteration (context=0x6632f0, may_block=1) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3766 #43 0x00007ffff22344bc in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #44 0x00007ffff21ebd3b in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #45 0x00007ffff21ef120 in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #46 0x0000000000421ba0 in launcherMain (app=...) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:49 #47 0x0000000000423680 in main (argc=2, argv=0x7fffffffdc58) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:318 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:04:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:04:56 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119748 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:06:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:06:12 -0700 Subject: [Webkit-unassigned] [Bug 119748] ASSERTION FAILED: resultAnimationElement->m_animatedType in WebCore::SVGAnimateElement::calculateAnimatedValue In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119748 --- Comment #1 from Renata Hodovan 2013-08-13 08:05:47 PST --- Created an attachment (id=208632) --> (https://bugs.webkit.org/attachment.cgi?id=208632&action=review) Test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:07:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:07:07 -0700 Subject: [Webkit-unassigned] [Bug 119743] [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119743 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208624|0 |1 is obsolete| | Attachment #208624|review? | Flag| | Attachment #208634| |review? Flag| | --- Comment #4 from Carlos Garcia Campos 2013-08-13 08:06:40 PST --- Created an attachment (id=208634) --> (https://bugs.webkit.org/attachment.cgi?id=208634&action=review) Updated patch I forgot to git add some new files -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:08:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:08:36 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 --- Comment #11 from Carlos Garcia Campos 2013-08-13 08:08:11 PST --- I guess we need to roll out the patch first -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:09:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:09:48 -0700 Subject: [Webkit-unassigned] [Bug 119749] New: Tests often incorrectly reported as passing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119749 Summary: Tests often incorrectly reported as passing Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric.carlson at apple.com CC: rniwa at webkit.org The build bots often incorrectly report tests as "expected to fail but passed". For example http/tests/navigation/back-twice-without-commit.html was marked as Timeout in Mac TestExpectations, and the MountainLion bot showed that it was passing unexpectedly: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r153825%20(11521)/results.html but the flakiness dashboard shows that it never passes: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fnavigation%2Fback-twice-without-commit.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:10:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:10:41 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 --- Comment #12 from Alberto Garcia 2013-08-13 08:10:16 PST --- (In reply to comment #11) > I guess we need to roll out the patch first This one goes on top of the other already. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:19:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:19:30 -0700 Subject: [Webkit-unassigned] [Bug 119750] New: Three inspector tests are crashing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119750 Summary: Three inspector tests are crashing Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: MakingBotsRed Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric.carlson at apple.com CC: timothy at apple.com, koivisto at iki.fi, graouts at apple.com http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r154000%20(9403)/results.html http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r154000%20(10103)/results.html Three inspector tests, inspector/debugger/watch-expressions-preserve-expansion.html, inspector/debugger/properties-special.html, and inspector/debugger/script-extract-outline.html are all crashing on Lion and MountainLion the same backtrace. Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010ea0c55a WTFCrash + 42 (Assertions.cpp:342) 1 com.apple.WebCore 0x0000000110ad50df WebCore::InspectorOverlay::paint(WebCore::GraphicsContext&) + 255 (InspectorOverlay.cpp:212) 2 com.apple.WebCore 0x0000000110a41abf WebCore::InspectorController::drawHighlight(WebCore::GraphicsContext&) const + 47 (InspectorController.cpp:323) 3 com.apple.WebKit 0x000000010fa358c5 -[WebNodeHighlightView drawRect:] + 293 (WebNodeHighlightView.mm:76) 4 com.apple.AppKit 0x00007fff8c0ee064 -[NSView _drawRect:clip:] + 4217 5 com.apple.AppKit 0x00007fff8c0ec6c1 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 1656 6 com.apple.AppKit 0x00007fff8c0ecad9 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 2704 7 com.apple.AppKit 0x00007fff8c0ea6f2 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 817 8 com.apple.AppKit 0x00007fff8c239fab -[NSNextStepFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 286 9 com.apple.AppKit 0x00007fff8c0e5d6d -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 4675 10 com.apple.AppKit 0x00007fff8c0afc93 -[NSView displayIfNeeded] + 1830 11 com.apple.AppKit 0x00007fff8c239e64 -[NSNextStepFrame displayIfNeeded] + 84 12 com.apple.AppKit 0x00007fff8c0db5f4 -[NSWindow _setFrameCommon:display:stashSize:] + 2664 13 com.apple.WebKit 0x000000010fa35179 -[WebNodeHighlight(FileInternal) _repositionHighlightWindow] + 361 (WebNodeHighlight.mm:202) 14 com.apple.CoreFoundation 0x00007fff8f2faeda _CFXNotificationPost + 2554 15 com.apple.Foundation 0x00007fff8a4207b6 -[NSNotificationCenter postNotificationName:object:userInfo:] + 64 16 com.apple.AppKit 0x00007fff8c09513e -[NSView _postFrameChangeNotification] + 259 17 com.apple.AppKit 0x00007fff8c07f813 -[NSView setFrameSize:] + 1352 18 com.apple.AppKit 0x00007fff8c0d4c81 -[NSClipView setFrameSize:] + 394 19 com.apple.AppKit 0x00007fff8c07ef5e -[NSView setFrame:] + 299 20 com.apple.AppKit 0x00007fff8c1429ff -[NSScrollView _setContentViewFrame:] + 596 21 com.apple.AppKit 0x00007fff8c142437 -[NSScrollView _applyContentAreaLayout:] + 129 22 com.apple.AppKit 0x00007fff8c1414ee -[NSScrollView tile] + 2091 23 com.apple.WebKit 0x000000010f988f69 -[WebDynamicScrollBarsView(WebInternal) tile] + 57 (WebDynamicScrollBarsView.mm:241) 24 com.apple.AppKit 0x00007fff8c140c26 -[NSScrollView _tileWithoutRecursing] + 49 25 com.apple.AppKit 0x00007fff8c140baa -[NSScrollView _update] + 30 26 com.apple.WebKit 0x000000010f989641 -[WebDynamicScrollBarsView(WebInternal) updateScrollers] + 913 (WebDynamicScrollBarsView.mm:329) 27 com.apple.WebKit 0x000000010f98a3b9 -[WebDynamicScrollBarsView(WebInternal) setScrollingModes:vertical:andLock:] + 249 (WebDynamicScrollBarsView.mm:506) 28 com.apple.WebCore 0x000000011169132e WebCore::ScrollView::platformSetScrollbarModes() + 78 (ScrollViewMac.mm:86) 29 com.apple.WebCore 0x0000000111687ff9 WebCore::ScrollView::setScrollbarModes(WebCore::ScrollbarMode, WebCore::ScrollbarMode, bool, bool) + 249 (ScrollView.cpp:148) 30 com.apple.WebCore 0x000000011074a558 WebCore::ScrollView::setVerticalScrollbarMode(WebCore::ScrollbarMode, bool) + 104 (ScrollView.h:90) 31 com.apple.WebCore 0x000000011073cb19 WebCore::FrameView::layout(bool) + 2313 (FrameView.cpp:1285) 32 com.apple.WebCore 0x000000011049cd8f WebCore::Document::implicitClose() + 991 (Document.cpp:2419) 33 com.apple.WebCore 0x000000011071361b WebCore::FrameLoader::checkCallImplicitClose() + 155 (FrameLoader.cpp:851) 34 com.apple.WebCore 0x0000000110713296 WebCore::FrameLoader::checkCompleted() + 358 (FrameLoader.cpp:795) 35 com.apple.WebCore 0x0000000110711e28 WebCore::FrameLoader::finishedParsing() + 184 (FrameLoader.cpp:728) 36 com.apple.WebCore 0x00000001104a7a0b WebCore::Document::finishedParsing() + 475 (Document.cpp:4393) 37 com.apple.WebCore 0x0000000110865378 WebCore::HTMLConstructionSite::finishedParsing() + 24 (HTMLConstructionSite.cpp:349) 38 com.apple.WebCore 0x0000000110958b24 WebCore::HTMLTreeBuilder::finished() + 116 (HTMLTreeBuilder.cpp:2927) 39 com.apple.WebCore 0x00000001108850fe WebCore::HTMLDocumentParser::end() + 174 (HTMLDocumentParser.cpp:764) 40 com.apple.WebCore 0x0000000110883b52 WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() + 242 (HTMLDocumentParser.cpp:775) 41 com.apple.WebCore 0x000000011088397f WebCore::HTMLDocumentParser::prepareToStopParsing() + 271 (HTMLDocumentParser.cpp:212) 42 com.apple.WebCore 0x0000000110885153 WebCore::HTMLDocumentParser::attemptToEnd() + 67 (HTMLDocumentParser.cpp:787) 43 com.apple.WebCore 0x00000001108851a8 WebCore::HTMLDocumentParser::finish() + 72 (HTMLDocumentParser.cpp:836) 44 com.apple.WebCore 0x00000001105107ba WebCore::DocumentWriter::end() + 346 (DocumentWriter.cpp:249) 45 com.apple.WebCore 0x00000001104df693 WebCore::DocumentLoader::finishedLoading(double) + 595 (DocumentLoader.cpp:403) 46 com.apple.WebCore 0x00000001104e3db5 WebCore::DocumentLoader::maybeLoadEmpty() + 901 (DocumentLoader.cpp:1344) 47 com.apple.WebCore 0x00000001104e3ef2 WebCore::DocumentLoader::startLoadingMainResource() + 274 (DocumentLoader.cpp:1356) 48 com.apple.WebCore 0x000000011071b4e9 WebCore::FrameLoader::continueLoadAfterWillSubmitForm() + 185 (FrameLoader.cpp:2234) 49 com.apple.WebCore 0x0000000110717da6 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WTF::PassRefPtr, bool) + 982 (FrameLoader.cpp:2890) 50 com.apple.WebCore 0x0000000110717e07 WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr, bool) + 87 (FrameLoader.cpp:2718) 51 com.apple.WebCore 0x00000001112a66e2 WebCore::PolicyChecker::checkNavigationPolicy(WebCore::ResourceRequest const&, WebCore::DocumentLoader*, WTF::PassRefPtr, void (*)(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr, bool), void*) + 370 (PolicyChecker.cpp:72) 52 com.apple.WebCore 0x00000001107177dc WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::PassRefPtr) + 1436 (FrameLoader.cpp:1421) 53 com.apple.WebCore 0x0000000110714ead WebCore::FrameLoader::load(WebCore::DocumentLoader*) + 429 (FrameLoader.cpp:1363) 54 com.apple.WebCore 0x00000001107171f3 WebCore::FrameLoader::load(WebCore::FrameLoadRequest const&) + 1219 (FrameLoader.cpp:1313) 55 com.apple.WebKit 0x000000010f99ca8b -[WebFrame loadRequest:] + 635 (WebFrame.mm:1368) 56 DumpRenderTree 0x000000010e3b231f runTest(std::__1::basic_string, std::__1::allocator > const&) + 6207 (DumpRenderTree.mm:1447) 57 DumpRenderTree 0x000000010e3b0a6a runTestingServerLoop() + 282 (DumpRenderTree.mm:860) 58 DumpRenderTree 0x000000010e3b0455 dumpRenderTree(int, char const**) + 405 (DumpRenderTree.mm:915) 59 DumpRenderTree 0x000000010e3b2609 main + 105 (DumpRenderTree.mm:953) 60 libdyld.dylib 0x00007fff895ca7e1 start + 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:23:58 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:23:58 -0700 Subject: [Webkit-unassigned] [Bug 18293] td width=100% causes border of table to appear incorrectly In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=18293 Pravin D changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pravind at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:25:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:25:04 -0700 Subject: [Webkit-unassigned] [Bug 19955] width="100%" table cell doesn't eat all available space In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=19955 Pravin D changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pravind at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:27:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:27:18 -0700 Subject: [Webkit-unassigned] [Bug 52100] Table
    with 100% height not taking it's sibling 's img content into consideration In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=52100 Pravin D changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pravind at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:27:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:27:41 -0700 Subject: [Webkit-unassigned] [Bug 48010] nested table with td width=100% does not work (wunderground radar displays incorrectly) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=48010 Pravin D changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pravind at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:30:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:30:12 -0700 Subject: [Webkit-unassigned] [Bug 32744] Table nested child table's column widths with nowrap In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=32744 Pravin D changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pravind at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:32:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:32:01 -0700 Subject: [Webkit-unassigned] [Bug 99618] [MathML] Implement the mmultiscripts tag In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=99618 Fr?d?ric Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208490|0 |1 is obsolete| | --- Comment #19 from Fr?d?ric Wang 2013-08-13 08:31:34 PST --- Created an attachment (id=208636) --> (https://bugs.webkit.org/attachment.cgi?id=208636&action=review) Patch V6 Quick update to fix the test failures on Mac. I forgot to say that I disabled two MathML pixel tests. They should probably be converted to reftests. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:37:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:37:32 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 EFL EWS Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208629| |commit-queue- Flag| | --- Comment #12 from EFL EWS Bot 2013-08-13 08:37:06 PST --- (From update of attachment 208629) Attachment 208629 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1451473 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:37:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:37:51 -0700 Subject: [Webkit-unassigned] [Bug 119729] [EFL][GTK][Qt][WK1] New fast/dom/Window/open-zero-size-as-default.html test fails after r153913. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119729 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |allan.jensen at digia.com --- Comment #1 from Alexey Proskuryakov 2013-08-13 08:37:26 PST --- Perhaps this is the default size in DumpRenderTree for these platforms? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:39:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:39:26 -0700 Subject: [Webkit-unassigned] [Bug 119088] [Qt] Crash in SimpleFontData, related to @font-face with non-existing src url In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119088 --- Comment #15 from Milian Wolff 2013-08-13 08:39:01 PST --- https://codereview.qt-project.org/#change,62910 fixes the issue for me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:41:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:41:01 -0700 Subject: [Webkit-unassigned] [Bug 119751] New: ASSERTION FAILED: url.isEmpty() || isSchemeFirstChar(url[0]) in WebCore::checkEncodedString Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119751 Summary: ASSERTION FAILED: url.isEmpty() || isSchemeFirstChar(url[0]) in WebCore::checkEncodedString Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: P2 Component: Page Loading AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: reni at webkit.org Blocks: 116980 The following test fails if it's loaded from the network (at least from localhost): The backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff56f5744 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 342 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) bt #0 0x00007ffff56f5744 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 #1 0x00007ffff4758489 in WebCore::checkEncodedString (url=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/KURL.cpp:307 #2 0x00007ffff475b306 in WebCore::KURL::parse (this=0x7fffffffc3b0, string=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/KURL.cpp:982 #3 0x00007ffff4758578 in WebCore::KURL::KURL (this=0x7fffffffc3b0, url=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/KURL.cpp:333 #4 0x00007ffff45da5f0 in WebCore::NavigationScheduler::scheduleLocationChange (this=0x8ecb98, securityOrigin=0x781e90, url=..., referrer=..., lockHistory=true, lockBackForwardList=true) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/NavigationScheduler.cpp:352 #5 0x00007ffff45e55df in WebCore::SubframeLoader::loadOrRedirectSubframe (this=0x7e6080, ownerElement=0x829520, url=..., frameName=..., lockHistory=true, lockBackForwardList=true) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/SubframeLoader.cpp:340 #6 0x00007ffff45e4eff in WebCore::SubframeLoader::requestObject (this=0x7e6080, ownerElement=0x829520, url=..., frameName=..., mimeType=..., paramNames=..., paramValues=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/SubframeLoader.cpp:243 #7 0x00007ffff43b94b7 in WebCore::HTMLObjectElement::updateWidget (this=0x829520, pluginCreationOption=WebCore::CreateOnlyNonNetscapePlugins) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/HTMLObjectElement.cpp:322 #8 0x00007ffff43c062d in WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary (this=0x829520) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/HTMLPlugInImageElement.cpp:274 #9 0x00007ffff43c08ef in WebCore::HTMLPlugInImageElement::updateWidgetCallback (n=0x829520) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/HTMLPlugInImageElement.cpp:331 #10 0x00007ffff419f064 in WebCore::ContainerNode::dispatchPostAttachCallbacks () at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/ContainerNode.cpp:772 #11 0x00007ffff419ed5b in WebCore::ContainerNode::resumePostAttachCallbacks (this=0x829520) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/ContainerNode.cpp:739 #12 0x00007ffff41a7379 in WebCore::PostAttachCallbackDisabler::~PostAttachCallbackDisabler (this=0x7fffffffc750, __in_chrg=) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/ContainerNode.h:345 #13 0x00007ffff43c04d7 in WebCore::HTMLPlugInImageElement::attach (this=0x829520, context=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/HTMLPlugInImageElement.cpp:250 #14 0x00007ffff429162f in WebCore::Node::reattach (this=0x829520, context=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Node.h:811 #15 0x00007ffff43b98e7 in WebCore::HTMLObjectElement::renderFallbackContent (this=0x829520) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/HTMLObjectElement.cpp:384 #16 0x00007ffff43a73d2 in WebCore::HTMLImageLoader::notifyFinished (this=0x7779e0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/HTMLImageLoader.cpp:89 #17 0x00007ffff45845c6 in WebCore::CachedResource::checkNotify (this=0x915ef0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:369 #18 0x00007ffff4584731 in WebCore::CachedResource::error (this=0x915ef0, status=WebCore::CachedResource::DecodeError) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:395 #19 0x00007ffff457db36 in WebCore::CachedImage::error (this=0x915ef0, status=WebCore::CachedResource::DecodeError) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedImage.cpp:435 #20 0x00007ffff457da2f in WebCore::CachedImage::finishLoading (this=0x915ef0, data=0x87e260) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedImage.cpp:419 #21 0x00007ffff45e73e3 in WebCore::SubresourceLoader::didFinishLoading (this=0x913690, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/SubresourceLoader.cpp:282 #22 0x00007ffff45ddccd in WebCore::ResourceLoader::didFinishLoading (this=0x913690, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/ResourceLoader.cpp:488 #23 0x00007ffff4a87683 in WebCore::QNetworkReplyHandler::finish (this=0x9105d0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:516 #24 0x00007ffff4a863a2 in WebCore::QNetworkReplyHandlerCallQueue::flush (this=0x910608) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:250 #25 0x00007ffff4a860f2 in WebCore::QNetworkReplyHandlerCallQueue::unlock (this=0x910608) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:230 #26 0x00007ffff4a8643b in WebCore::QueueLocker::~QueueLocker (this=0x7fffffffcac0, __in_chrg=) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:258 #27 0x00007ffff4a86f2a in WebCore::QNetworkReplyWrapper::emitMetaDataChanged (this=0x8f5410) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:395 #28 0x00007ffff4a86cd9 in WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType (this=0x8f5410) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:359 #29 0x00007ffff4a8999a in WebCore::QNetworkReplyWrapper::qt_static_metacall (_o=0x8f5410, _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fffffffcc20) ---Type to continue, or q to quit--- at .moc/release-shared/moc_QNetworkReplyHandler.cpp:178 #30 0x00007ffff22115cb in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #31 0x00007ffff528731f in QtMIMETypeSniffer::finished (this=0x86e720) at .moc/release-shared/moc_QtMIMETypeSniffer.cpp:131 #32 0x00007ffff4a853dc in QtMIMETypeSniffer::trySniffing (this=0x86e720) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QtMIMETypeSniffer.cpp:65 #33 0x00007ffff5287182 in QtMIMETypeSniffer::qt_static_metacall (_o=0x86e720, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffffffce20) at .moc/release-shared/moc_QtMIMETypeSniffer.cpp:76 #34 0x00007ffff22115cb in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #35 0x00007ffff2c5df81 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Network.so.5 #36 0x00007ffff2cd7a4d in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Network.so.5 #37 0x00007ffff221284e in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #38 0x00007ffff3058dbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #39 0x00007ffff305c075 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #40 0x00007ffff21ecdbe in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #41 0x00007ffff21eea76 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #42 0x00007ffff2234333 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #43 0x00007fffee3790a6 in g_main_dispatch (context=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3058 #44 g_main_context_dispatch (context=context at entry=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3634 #45 0x00007fffee3793f8 in g_main_context_iterate (context=context at entry=0x6632f0, block=block at entry=1, dispatch=dispatch at entry=1, self=) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3705 #46 0x00007fffee37949c in g_main_context_iteration (context=0x6632f0, may_block=1) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3766 #47 0x00007ffff22344bc in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #48 0x00007ffff21ebd3b in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #49 0x00007ffff21ef120 in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #50 0x0000000000421ba0 in launcherMain (app=...) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:49 #51 0x0000000000423680 in main (argc=2, argv=0x7fffffffdc58) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:318 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:41:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:41:03 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119751 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:41:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:41:28 -0700 Subject: [Webkit-unassigned] [Bug 119751] ASSERTION FAILED: url.isEmpty() || isSchemeFirstChar(url[0]) in WebCore::checkEncodedString In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119751 --- Comment #1 from Renata Hodovan 2013-08-13 08:41:03 PST --- Created an attachment (id=208637) --> (https://bugs.webkit.org/attachment.cgi?id=208637&action=review) Test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:41:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:41:57 -0700 Subject: [Webkit-unassigned] [Bug 119751] ASSERTION FAILED: url.isEmpty() || isSchemeFirstChar(url[0]) in WebCore::checkEncodedString In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119751 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com, | |andersca at apple.com, | |benjamin at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:45:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:45:03 -0700 Subject: [Webkit-unassigned] [Bug 32744] Table nested child table's column widths with nowrap In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=32744 --- Comment #4 from Brad Beattie 2013-08-13 08:44:38 PST --- Confirmed that this bug still exists. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:45:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:45:17 -0700 Subject: [Webkit-unassigned] [Bug 119741] [Win] Compile fixes. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119741 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #2 from Brent Fulgham 2013-08-13 08:44:53 PST --- Sorry you had to deal with this. Ryosuke fixed this independently: http://trac.webkit.org/changeset/153983 http://trac.webkit.org/changeset/153984 http://trac.webkit.org/changeset/153985 http://trac.webkit.org/changeset/153988 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:45:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:45:34 -0700 Subject: [Webkit-unassigned] [Bug 119741] [Win] Compile fixes. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119741 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208620|review?, commit-queue? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:48:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:48:01 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 --- Comment #13 from Carlos Garcia Campos 2013-08-13 08:47:36 PST --- It doesn't seem to apply in EWS bots -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 08:50:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 08:50:04 -0700 Subject: [Webkit-unassigned] [Bug 119744] [Curl] Possible infinite loop while downloading. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119744 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208625|review?, commit-queue? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:05:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:05:52 -0700 Subject: [Webkit-unassigned] [Bug 119753] New: ASSERT_NOT_REACHED() touched in WebCore::BidiResolver::createBidiRunsForLine Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119753 Summary: ASSERT_NOT_REACHED() touched in WebCore::BidiResolver::createBidiRunsForLine Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: reni at webkit.org Blocks: 116980 Failing test case: This bug is probably related to https://bugs.webkit.org/show_bug.cgi?id=116964, since if we remove the tag then we fail on the other assertion check. The backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff56f5744 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 342 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) bt #0 0x00007ffff56f5744 in WTFCrash () at /home/reni/Data/REPOS/webkit_sec/Source/WTF/wtf/Assertions.cpp:342 #1 0x00007ffff486fa0c in WebCore::BidiResolver::createBidiRunsForLine (this=0x7fffffffa350, end=..., override=WebCore::NoVisualOverride, hardLineBreak=false) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/text/BidiResolver.h:864 #2 0x00007ffff4860f95 in WebCore::constructBidiRunsForSegment (topResolver=..., bidiRuns=..., endOfRuns=..., override=WebCore::NoVisualOverride, previousLineBrokeCleanly=false) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1347 #3 0x00007ffff4861125 in WebCore::constructBidiRunsForLine (block=0x767388, topResolver=..., bidiRuns=..., endOfLine=..., override=WebCore::NoVisualOverride, previousLineBrokeCleanly=false) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1372 #4 0x00007ffff48636e2 in WebCore::RenderBlock::layoutRunsAndFloatsInRange (this=0x767388, layoutState=..., resolver=..., cleanLineStart=..., cleanLineBidiStatus=..., consecutiveHyphenatedLines=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1877 #5 0x00007ffff4861e33 in WebCore::RenderBlock::layoutRunsAndFloats (this=0x767388, layoutState=..., hasInlineChild=true) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1614 #6 0x00007ffff486558c in WebCore::RenderBlock::layoutInlineChildren (this=0x767388, relayoutChildren=true, repaintLogicalTop=..., repaintLogicalBottom=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlockLineLayout.cpp:2189 #7 0x00007ffff4819872 in WebCore::RenderBlock::layoutBlock (this=0x767388, relayoutChildren=true, pageLogicalHeight=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1656 #8 0x00007ffff4818ca5 in WebCore::RenderBlock::layout (this=0x767388) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1428 #9 0x00007ffff481e0d4 in WebCore::RenderBlock::layoutBlockChild (this=0x7d19c8, child=0x767388, marginInfo=..., previousFloatLogicalBottom=..., maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:2669 #10 0x00007ffff481dccd in WebCore::RenderBlock::layoutBlockChildren (this=0x7d19c8, relayoutChildren=true, maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:2604 #11 0x00007ffff4819893 in WebCore::RenderBlock::layoutBlock (this=0x7d19c8, relayoutChildren=true, pageLogicalHeight=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1658 #12 0x00007ffff4818ca5 in WebCore::RenderBlock::layout (this=0x7d19c8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1428 #13 0x00007ffff481e0d4 in WebCore::RenderBlock::layoutBlockChild (this=0x7d3f48, child=0x7d19c8, marginInfo=..., previousFloatLogicalBottom=..., maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:2669 #14 0x00007ffff481dccd in WebCore::RenderBlock::layoutBlockChildren (this=0x7d3f48, relayoutChildren=true, maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:2604 #15 0x00007ffff4819893 in WebCore::RenderBlock::layoutBlock (this=0x7d3f48, relayoutChildren=true, pageLogicalHeight=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1658 #16 0x00007ffff4818ca5 in WebCore::RenderBlock::layout (this=0x7d3f48) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderBlock.cpp:1428 #17 0x00007ffff49cdcb5 in WebCore::RenderView::layoutContent (this=0x7d3f48, state=...) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderView.cpp:142 #18 0x00007ffff49cea72 in WebCore::RenderView::layout (this=0x7d3f48) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/rendering/RenderView.cpp:327 #19 0x00007ffff467a2b8 in WebCore::FrameView::layout (this=0x78d5f0, allowSubtree=true) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/page/FrameView.cpp:1327 #20 0x00007ffff41b2e91 in WebCore::Document::implicitClose (this=0x89d8f0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:2429 #21 0x00007ffff45b311d in WebCore::FrameLoader::checkCallImplicitClose (this=0x7d56d8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:844 #22 0x00007ffff45b2e8e in WebCore::FrameLoader::checkCompleted (this=0x7d56d8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:787 #23 0x00007ffff45b2bc3 in WebCore::FrameLoader::finishedParsing (this=0x7d56d8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/FrameLoader.cpp:720 #24 0x00007ffff41b9e37 in WebCore::Document::finishedParsing (this=0x89d8f0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/dom/Document.cpp:4404 #25 0x00007ffff440b2a1 in WebCore::HTMLConstructionSite::finishedParsing (this=0x8158c8) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLConstructionSite.cpp:348 #26 0x00007ffff443f9c3 in WebCore::HTMLTreeBuilder::finished (this=0x8158b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2926 #27 0x00007ffff44129a0 in WebCore::HTMLDocumentParser::end (this=0x7d20b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:763 #28 0x00007ffff4412a8b in WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd (this=0x7d20b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:774 #29 0x00007ffff44115fa in WebCore::HTMLDocumentParser::prepareToStopParsing (this=0x7d20b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:211 #30 0x00007ffff4412ad0 in WebCore::HTMLDocumentParser::attemptToEnd (this=0x7d20b0) ---Type to continue, or q to quit--- at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:786 #31 0x00007ffff4412b89 in WebCore::HTMLDocumentParser::finish (this=0x7d20b0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/html/parser/HTMLDocumentParser.cpp:835 #32 0x00007ffff45aaa23 in WebCore::DocumentWriter::end (this=0x6942e0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentWriter.cpp:248 #33 0x00007ffff459d562 in WebCore::DocumentLoader::finishedLoading (this=0x694240, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:402 #34 0x00007ffff459d2d0 in WebCore::DocumentLoader::notifyFinished (this=0x694240, resource=0x7cc6d0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/DocumentLoader.cpp:344 #35 0x00007ffff45845c6 in WebCore::CachedResource::checkNotify (this=0x7cc6d0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:369 #36 0x00007ffff458469c in WebCore::CachedResource::finishLoading (this=0x7cc6d0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedResource.cpp:385 #37 0x00007ffff4580dee in WebCore::CachedRawResource::finishLoading (this=0x7cc6d0, data=0x7e2480) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/cache/CachedRawResource.cpp:94 #38 0x00007ffff45e73e3 in WebCore::SubresourceLoader::didFinishLoading (this=0x7cbd30, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/SubresourceLoader.cpp:282 #39 0x00007ffff45ddccd in WebCore::ResourceLoader::didFinishLoading (this=0x7cbd30, finishTime=0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/loader/ResourceLoader.cpp:488 #40 0x00007ffff4a87683 in WebCore::QNetworkReplyHandler::finish (this=0x7b7ae0) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:516 #41 0x00007ffff4a863a2 in WebCore::QNetworkReplyHandlerCallQueue::flush (this=0x7b7b18) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:250 #42 0x00007ffff4a8609f in WebCore::QNetworkReplyHandlerCallQueue::push (this=0x7b7b18, method=(void (WebCore::QNetworkReplyHandler::*)(WebCore::QNetworkReplyHandler * const)) 0x7ffff4a874c8 ) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:216 #43 0x00007ffff4a86fec in WebCore::QNetworkReplyWrapper::didReceiveFinished (this=0x7b9890) at /home/reni/Data/REPOS/webkit_sec/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:409 #44 0x00007ffff4a8997e in WebCore::QNetworkReplyWrapper::qt_static_metacall (_o=0x7b9890, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffffffcf90) at .moc/release-shared/moc_QNetworkReplyHandler.cpp:176 #45 0x00007ffff22115cb in QMetaObject::activate(QObject*, int, int, void**) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #46 0x00007ffff221284e in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #47 0x00007ffff3058dbc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #48 0x00007ffff305c075 in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Widgets.so.5 #49 0x00007ffff21ecdbe in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #50 0x00007ffff21eea76 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #51 0x00007ffff2234333 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #52 0x00007fffee3790a6 in g_main_dispatch (context=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3058 #53 g_main_context_dispatch (context=context at entry=0x6632f0) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3634 #54 0x00007fffee3793f8 in g_main_context_iterate (context=context at entry=0x6632f0, block=block at entry=1, dispatch=dispatch at entry=1, self=) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3705 #55 0x00007fffee37949c in g_main_context_iteration (context=0x6632f0, may_block=1) at /build/buildd/glib2.0-2.37.3/./glib/gmain.c:3766 #56 0x00007ffff22344bc in QEventDispatcherGlib::processEvents(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #57 0x00007ffff21ebd3b in QEventLoop::exec(QFlags) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #58 0x00007ffff21ef120 in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r40/lib/libQt5Core.so.5 #59 0x0000000000421ba0 in launcherMain (app=...) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:49 #60 0x0000000000423680 in main (argc=2, argv=0x7fffffffdc68) at /home/reni/Data/REPOS/webkit_sec/Tools/QtTestBrowser/qttestbrowser.cpp:318 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:05:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:05:55 -0700 Subject: [Webkit-unassigned] [Bug 116980] [meta] Bugs found with Fuzzinator (mutation based web fuzzer) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116980 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119753 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:06:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:06:05 -0700 Subject: [Webkit-unassigned] [Bug 119743] [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119743 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208634|0 |1 is obsolete| | Attachment #208634|review? | Flag| | Attachment #208638| |review? Flag| | --- Comment #5 from Carlos Garcia Campos 2013-08-13 09:05:39 PST --- Created an attachment (id=208638) --> (https://bugs.webkit.org/attachment.cgi?id=208638&action=review) Another update Sorry, I forgot to git add two more files. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:06:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:06:12 -0700 Subject: [Webkit-unassigned] [Bug 119753] ASSERT_NOT_REACHED() touched in WebCore::BidiResolver::createBidiRunsForLine In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119753 --- Comment #1 from Renata Hodovan 2013-08-13 09:05:47 PST --- Created an attachment (id=208639) --> (https://bugs.webkit.org/attachment.cgi?id=208639&action=review) Test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:07:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:07:02 -0700 Subject: [Webkit-unassigned] [Bug 119753] ASSERT_NOT_REACHED() touched in WebCore::BidiResolver::createBidiRunsForLine In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119753 Renata Hodovan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |achicu at adobe.com, | |betravis at adobe.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:07:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:07:32 -0700 Subject: [Webkit-unassigned] [Bug 116964] ASSERTION FAILED: !m_nestedIsolateCount in WebCore::BidiResolver::~BidiResolver() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=116964 --- Comment #3 from Renata Hodovan 2013-08-13 09:07:06 PST --- This bug is probably related to: https://bugs.webkit.org/show_bug.cgi?id=119753 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:15:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:15:17 -0700 Subject: [Webkit-unassigned] [Bug 119743] [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119743 --- Comment #6 from Sergio Villar Senin 2013-08-13 09:14:51 PST --- (From update of attachment 208638) View in context: https://bugs.webkit.org/attachment.cgi?id=208638&action=review Changes (informally) look awesome to me > Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt:1064 > +webkit_frame_get_javascript_global_context nit: should we have these properly sorted? > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:305 > + kWKBundlePageLoaderClientCurrentVersion, wow this probably deserved a separate fix :), good catch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:18:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:18:45 -0700 Subject: [Webkit-unassigned] [Bug 119744] [Curl] Possible infinite loop while downloading. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119744 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208625|review+, commit-queue+ | Flag| | --- Comment #2 from WebKit Commit Bot 2013-08-13 09:18:21 PST --- (From update of attachment 208625) Clearing flags on attachment: 208625 Committed r154006: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:18:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:18:47 -0700 Subject: [Webkit-unassigned] [Bug 119744] [Curl] Possible infinite loop while downloading. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119744 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from WebKit Commit Bot 2013-08-13 09:18:22 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:26:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:26:39 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208618|0 |1 is obsolete| | Attachment #208618|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:37:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:37:54 -0700 Subject: [Webkit-unassigned] [Bug 119751] ASSERTION FAILED: url.isEmpty() || isSchemeFirstChar(url[0]) in WebCore::checkEncodedString In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119751 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Platform|PC |All OS/Version|Linux |All Component|Page Loading |HTML DOM CC| |ap at webkit.org --- Comment #2 from Alexey Proskuryakov 2013-08-13 09:37:29 PST --- Ugh, resolving a URL against a mailto: base! We should probably outlaw overly tricky base URLs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:39:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:39:32 -0700 Subject: [Webkit-unassigned] [Bug 119750] Three inspector tests are crashing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119750 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:40:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:40:23 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 --- Comment #3 from Julien Brianceau 2013-08-13 09:39:58 PST --- Created an attachment (id=208642) --> (https://bugs.webkit.org/attachment.cgi?id=208642&action=review) DFG_JIT implementation for sh4 architecture I've tested this patch on my sh4 board using r153999 and I didn't see regressions when running - Tools/Scripts/run-javascriptcore-tests - Tools/Scripts/run-fast-jsc - SunSpider 1.0 - v8-v4 test suite v8-v4 test suite results on r153999 without this patch: ============================================ RESULTS (means and 95% confidence intervals) -------------------------------------------- Total: 74696.0ms +/- 11.7% -------------------------------------------- v8: 74696.0ms +/- 11.7% crypto: 13296.7ms +/- 1.4% deltablue: 21649.7ms +/- 17.6% earley-boyer: 6108.0ms +/- 7.4% raytrace: 7092.7ms +/- 7.3% regexp: 6166.3ms +/- 1.2% richards: 15396.0ms +/- 43.9% splay: 4986.7ms +/- 6.6% v8-v4 test suite results on r153999 with this patch: ============================================ RESULTS (means and 95% confidence intervals) -------------------------------------------- Total: 36705.7ms +/- 0.7% -------------------------------------------- v8: 36705.7ms +/- 0.7% crypto: 4592.0ms +/- 0.5% deltablue: 7425.7ms +/- 1.6% earley-boyer: 4113.3ms +/- 0.2% raytrace: 5562.7ms +/- 1.1% regexp: 7486.7ms +/- 0.1% richards: 4316.7ms +/- 1.4% splay: 3208.7ms +/- 9.5% -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:40:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:40:34 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 --- Comment #4 from Oliver Hunt 2013-08-13 09:40:09 PST --- (From update of attachment 208618) Separate out the llint changes into a separate patch (it will jus take it easier to be sure a regression was not introduced by those vs. the dfg. Similarly there's a lot of assembler changes that look like they should be safe on there own (separate tom this patch) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:41:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:41:03 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208642| |review?, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:44:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:44:51 -0700 Subject: [Webkit-unassigned] [Bug 119584] [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119584 Simon Pena changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org, | |bfulgham at webkit.org, | |gns at gnome.org, | |pnormand at igalia.com, | |thorton at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:44:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:44:56 -0700 Subject: [Webkit-unassigned] [Bug 119584] [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119584 Simon Pena changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |simon.pena at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:46:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:46:40 -0700 Subject: [Webkit-unassigned] [Bug 119749] Tests often incorrectly reported as passing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119749 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org --- Comment #1 from Alexey Proskuryakov 2013-08-13 09:46:15 PST --- I?m not sure if there is anything wrong with the tools - the bot where the test passes is a WK2 one, and the flakiness dashboard only complains about WK1 bots. Dashboard output is quite confusing though - as recently as yesterday afternoon, I misunderstood which bots it followed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:50:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:50:14 -0700 Subject: [Webkit-unassigned] [Bug 119732] REGRESSION (r153925): fast/media/media-query-list-07.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119732 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |MakingBotsRed CC| |ap at webkit.org --- Comment #1 from Alexey Proskuryakov 2013-08-13 09:49:49 PST --- Appears to fail everywhere. Andreas, should the patch be rolled out for now? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:56:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:56:48 -0700 Subject: [Webkit-unassigned] [Bug 118043] Mouse press should focus on any types of form controls In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118043 --- Comment #2 from Alexey Proskuryakov 2013-08-13 09:56:23 PST --- I?m pretty sure we have something to dupe this to. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:58:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:58:49 -0700 Subject: [Webkit-unassigned] [Bug 119711] Make CSS property user-select:none not to affect Document.caretRangeFromPoint() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119711 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org --- Comment #1 from Alexey Proskuryakov 2013-08-13 09:58:24 PST --- I wonder if user-select:none breaks OS X Dictionary. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:59:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:59:36 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208642|0 |1 is obsolete| | Attachment #208642|review?, commit-queue? | Flag| | --- Comment #5 from Julien Brianceau 2013-08-13 09:59:11 PST --- (From update of attachment 208642) (In reply to comment #4) > Separate out the llint changes into a separate patch (it will jus take it easier to be sure a regression was not introduced by those vs. the dfg. Similarly there's a lot of assembler changes that look like they should be safe on there own (separate tom this patch) Thanks. So I'm going to separate this patch in 3 parts: LLINT, MacroAssembler not related to the DFG then the DFG. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 09:59:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 09:59:57 -0700 Subject: [Webkit-unassigned] [Bug 119755] New: [sh4] Prepare LLINT for DFG_JIT implementation for sh4 architecture. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119755 Summary: [sh4] Prepare LLINT for DFG_JIT implementation for sh4 architecture. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jbrianceau at nds.com Prepare LLINT for DFG_JIT implementation for sh4 architecture. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:15:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:15:12 -0700 Subject: [Webkit-unassigned] [Bug 119755] [sh4] Prepare LLINT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119755 --- Comment #1 from Julien Brianceau 2013-08-13 10:14:47 PST --- Created an attachment (id=208647) --> (https://bugs.webkit.org/attachment.cgi?id=208647&action=review) Prepare LLINT for DFG_JIT implementation for sh4 architecture. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:16:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:16:02 -0700 Subject: [Webkit-unassigned] [Bug 119755] [sh4] Prepare LLINT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119755 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:16:14 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:16:14 -0700 Subject: [Webkit-unassigned] [Bug 119755] [sh4] Prepare LLINT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119755 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208647| |review?, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:16:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:16:51 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 --- Comment #6 from Julien Brianceau 2013-08-13 10:16:26 PST --- LLINT part: https://bugs.webkit.org/show_bug.cgi?id=119755 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:17:17 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:17:17 -0700 Subject: [Webkit-unassigned] [Bug 119755] [sh4] Prepare LLINT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119755 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208647|review?, commit-queue? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:18:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:18:44 -0700 Subject: [Webkit-unassigned] [Bug 119755] [sh4] Prepare LLINT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119755 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:20:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:20:53 -0700 Subject: [Webkit-unassigned] [Bug 119654] [Qt] Avoid calling QWebPage's virtual functions during deletion of QWebPage In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119654 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208566|0 |1 is obsolete| | Attachment #208566|review?, commit-queue? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:21:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:21:12 -0700 Subject: [Webkit-unassigned] [Bug 119654] [Qt] Avoid calling QWebPage's virtual functions during deletion of QWebPage In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119654 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208648| |review?, commit-queue? Flag| | --- Comment #11 from Arunprasad Rajkumar 2013-08-13 10:20:46 PST --- Created an attachment (id=208648) --> (https://bugs.webkit.org/attachment.cgi?id=208648&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:25:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:25:55 -0700 Subject: [Webkit-unassigned] [Bug 119756] New: [CSS Grid Layout] Handle 'span' positions during layout Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119756 Summary: [CSS Grid Layout] Handle 'span' positions during layout Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: svillar at igalia.com In bug 118051 we added support for the 'span' keyword at parser level. This change effectively uses it to perform the final layout of the grid items. This has been already implemented in Blink. We should probably merge: r149133 Properly handle 'span' position during layout This change plumbs the final bits so that we now recognize 'span' positions and resolve them accordingly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:28:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:28:54 -0700 Subject: [Webkit-unassigned] [Bug 119756] [CSS Grid Layout] Handle 'span' positions during layout In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119756 Sergio Villar Senin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |svillar at igalia.com Depends on| |118051 Blocks| |103314 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:28:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:28:55 -0700 Subject: [Webkit-unassigned] [Bug 103314] [CSS Grid Layout] Implement support for row / column spanning In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=103314 Sergio Villar Senin changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119756 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:32:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:32:53 -0700 Subject: [Webkit-unassigned] [Bug 119756] [CSS Grid Layout] Handle 'span' positions during layout In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119756 Sergio Villar Senin changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |113546 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:35:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:35:50 -0700 Subject: [Webkit-unassigned] [Bug 119756] [CSS Grid Layout] Handle 'span' positions during layout In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119756 Sergio Villar Senin changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|113546 | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:36:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:36:51 -0700 Subject: [Webkit-unassigned] [Bug 119758] New: [sh4] Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119758 Summary: [sh4] Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jbrianceau at nds.com Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:46:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:46:00 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208629|0 |1 is obsolete| | --- Comment #13 from Antti Koivisto 2013-08-13 10:45:34 PST --- Created an attachment (id=208651) --> (https://bugs.webkit.org/attachment.cgi?id=208651&action=review) yet another -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:50:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:50:20 -0700 Subject: [Webkit-unassigned] [Bug 119759] New: Collapsed borders between adjoining sections shouldn't overpaint each other Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119759 Summary: Collapsed borders between adjoining sections shouldn't overpaint each other Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: robert at webkit.org .. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:51:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:51:48 -0700 Subject: [Webkit-unassigned] [Bug 119758] [sh4] Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119758 --- Comment #1 from Julien Brianceau 2013-08-13 10:51:23 PST --- Created an attachment (id=208653) --> (https://bugs.webkit.org/attachment.cgi?id=208653&action=review) Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:54:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:54:31 -0700 Subject: [Webkit-unassigned] [Bug 119758] [sh4] Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119758 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:54:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:54:41 -0700 Subject: [Webkit-unassigned] [Bug 119758] [sh4] Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119758 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208653| |review?, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:55:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:55:21 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 --- Comment #7 from Julien Brianceau 2013-08-13 10:54:55 PST --- Baseline JIT part: https://bugs.webkit.org/show_bug.cgi?id=119758 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:56:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:56:05 -0700 Subject: [Webkit-unassigned] [Bug 119758] [sh4] Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119758 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208653|review?, commit-queue? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:56:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:56:30 -0700 Subject: [Webkit-unassigned] [Bug 115352] [gstreamer] Make sure gstreamer source element is thread-safe In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115352 Andre Moreira Magalhaes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202292|0 |1 is obsolete| | --- Comment #20 from Andre Moreira Magalhaes 2013-08-13 10:56:03 PST --- Created an attachment (id=208654) --> (https://bugs.webkit.org/attachment.cgi?id=208654&action=review) Updated patch against upstream master So, first of all, this is the updated patch against upstream master with conflicts fixed, etc. I investigated the regressions on #117141 and #117688 and here goes my findings: 1 - Bug #117688 (http/tests/security/video-poster-cross-origin-crash.html crash on GTK bots): Running this test with both upstream/master and upstream/master with the updated patch applied I get the exactly same results: $ TEST_RUNNER_TEST_PLUGIN_PATH=./WebKitBuild/Debug/TestNetscapePlugin/.libs/libtestnetscapeplugin.so TEST_RUNNER_INJECTED_BUNDLE_FILENAME=WebKitBuild/Debug/Libraries/.libs/libTestRunnerInjectedBundle.so Tools/jhbuild/jhbuild-wrapper --gtk run ./WebKitBuild/Debug/Programs/WebKitTestRunner LayoutTests/http/tests/security/video-poster-cross-origin-crash.html Gtk-Message: Failed to load module "overlay-scrollbar" Gtk-Message: Failed to load module "canberra-gtk-module" Gtk-Message: Failed to load module "overlay-scrollbar" Gtk-Message: Failed to load module "canberra-gtk-module" Content-Type: text/plain >>> #EOF #EOF #EOF ** (WebKitTestRunner:24868): CRITICAL **: socket_embed_hook: assertion `spi_global_register != NULL' failed LEAK: 1 WebContext LEAK: 8 WebCoreNode 2 - Bug #117141 (fast/js/cyclic-proto.html crash on Qt bots): This bug seems to be crashing on LocalStorage and I can't see how this patch is related. That said I believe this bug is not related to the crashes, but if someone can enlighten me here or get me some better backtrace with the crashes I may be able to fix any possible regression. It is good to note that this patch fixes a bunch of thread related issues with the webkit gstreamer source element. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:56:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:56:54 -0700 Subject: [Webkit-unassigned] [Bug 115352] [gstreamer] Make sure gstreamer source element is thread-safe In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115352 Andre Moreira Magalhaes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208654| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 10:58:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 10:58:20 -0700 Subject: [Webkit-unassigned] [Bug 119758] [sh4] Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119758 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:04:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:04:28 -0700 Subject: [Webkit-unassigned] [Bug 119490] Various media tests spew "CGContextScaleCTM: invalid context 0x0" errors In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119490 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.carlson at apple.com, | |simon.fraser at apple.com, | |webkit-bug-importer at group.a | |pple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:06:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:06:39 -0700 Subject: [Webkit-unassigned] [Bug 119490] Various media tests spew "CGContextScaleCTM: invalid context 0x0" errors In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119490 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Radar WebKit Bug Importer 2013-08-13 11:06:13 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:10:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:10:41 -0700 Subject: [Webkit-unassigned] [Bug 115352] [gstreamer] Make sure gstreamer source element is thread-safe In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115352 --- Comment #21 from Andre Moreira Magalhaes 2013-08-13 11:10:16 PST --- (In reply to comment #20 > 2 - Bug #117141 (fast/js/cyclic-proto.html crash on Qt bots): > This bug seems to be crashing on LocalStorage and I can't see how this patch is related. Sorry, now I saw the full backtrace there, both bugs are crashing in the same place, when calling "request.setHTTPReferrer(priv->player->referrer());" from webKitWebSrcStart. I will try to reproduce this crash here again. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:12:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:12:54 -0700 Subject: [Webkit-unassigned] [Bug 119761] New: Replace currentTime() with monotonicallyIncreasingTime() in all possible places Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119761 Summary: Replace currentTime() with monotonicallyIncreasingTime() in all possible places Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P3 Component: Web Template Framework AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: arurajku at cisco.com CC: darin at apple.com, allan.jensen at digia.com, andersca at apple.com, hausmann at webkit.org, rniwa at webkit.org, jocelyn.turcotte at digia.com, benjamin at webkit.org, ararunprasad at gmail.com It is a meta-bug to track. Changes will be done in incremental phases, - Initially WTF & JavaScriptCore - WebCore -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:16:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:16:39 -0700 Subject: [Webkit-unassigned] [Bug 119762] New: [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 Summary: [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Template Framework AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: arurajku at cisco.com CC: ararunprasad at gmail.com Replace currentTime() with monotonicallyIncreasingTime() in WTF and JavaScriptCore [at appropriate places] -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:17:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:17:26 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119761 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:17:28 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:17:28 -0700 Subject: [Webkit-unassigned] [Bug 119761] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119761 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119762 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:19:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:19:18 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #14 from Carlos Garcia Campos 2013-08-13 11:18:53 PST --- reopening -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:20:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:20:03 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208657| |review?, commit-queue? Flag| | --- Comment #1 from Arunprasad Rajkumar 2013-08-13 11:19:38 PST --- Created an attachment (id=208657) --> (https://bugs.webkit.org/attachment.cgi?id=208657&action=review) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:21:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:21:07 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akling at apple.com, | |benjamin at webkit.org, | |darin at apple.com, | |rniwa at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:21:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:21:25 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 Alberto Garcia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208630|0 |1 is obsolete| | Attachment #208630|review? | Flag| | Attachment #208658| |review? Flag| | --- Comment #15 from Alberto Garcia 2013-08-13 11:21:00 PST --- Created an attachment (id=208658) --> (https://bugs.webkit.org/attachment.cgi?id=208658&action=review) Patch Resubmitting patch for EWS processing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:21:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:21:42 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmarcelo at webkit.org, | |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:26:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:26:59 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ggaren at apple.com --- Comment #2 from Geoffrey Garen 2013-08-13 11:26:33 PST --- Why? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:27:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:27:16 -0700 Subject: [Webkit-unassigned] [Bug 119764] New: srcset: Respect updates to display density Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119764 Summary: srcset: Respect updates to display density Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified URL: http://www.webkit.org/demos/srcset/ OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: webkitorg.rickyromero at spamgourmet.com There are situations in which a browser window may encounter a display density change: 1.) Opening a webpage on a @2x laptop, closing the laptop, then later connecting a @1x display. 2.) Dragging the browser window from a @1x display to a @2x display. 3.) Enabling the developer-only HiDPI mode in OS X. Webkit does not appear to detect these changes and load in the correct images from srcset when they are available. This is a bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:31:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:31:19 -0700 Subject: [Webkit-unassigned] [Bug 119490] Various media tests spew "CGContextScaleCTM: invalid context 0x0" errors In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119490 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |simon.fraser at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:43:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:43:38 -0700 Subject: [Webkit-unassigned] [Bug 71819] getBoundingClientRect() yields global coordinates for XHTML elements embedded in SVG In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=71819 willy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |willy at entropi.info -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:44:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:44:07 -0700 Subject: [Webkit-unassigned] [Bug 119761] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119761 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjs at apple.com, | |sam at webkit.org --- Comment #1 from Ryosuke Niwa 2013-08-13 11:43:42 PST --- What is the goal of this change? Why do we want to do this? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:46:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:46:42 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208658|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:50:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:50:32 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 --- Comment #16 from Alberto Garcia 2013-08-13 11:50:07 PST --- Fixed in . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:51:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:51:02 -0700 Subject: [Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=110865 Carlos Garcia Campos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:51:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:51:23 -0700 Subject: [Webkit-unassigned] [Bug 119759] Collapsed borders between adjoining sections shouldn't overpaint each other In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119759 Robert Hogan changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |robert at webkit.org |kit.org | CC| |robert at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:58:32 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:58:32 -0700 Subject: [Webkit-unassigned] [Bug 119758] [sh4] Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119758 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208653|review+, commit-queue+ | Flag| | --- Comment #2 from WebKit Commit Bot 2013-08-13 11:58:07 PST --- (From update of attachment 208653) Clearing flags on attachment: 208653 Committed r154016: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 11:58:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 11:58:33 -0700 Subject: [Webkit-unassigned] [Bug 119758] [sh4] Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119758 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from WebKit Commit Bot 2013-08-13 11:58:08 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 12:11:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 12:11:50 -0700 Subject: [Webkit-unassigned] [Bug 119761] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119761 --- Comment #2 from Arunprasad Rajkumar 2013-08-13 12:11:24 PST --- (In reply to comment #1) > What is the goal of this change? Why do we want to do this? Actually some platforms(mostly embedded systems like TV/STB) doesn't have battery powered reliable clock source. Wall Clock time is obtained via time sources like NTP(it may have some latency). So I feel use currentTime() only on the places which really needs wall clock time(like jsDateTime()), remaining places monotonicallyIncreasingTime() is good. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 12:12:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 12:12:42 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 --- Comment #3 from Arunprasad Rajkumar 2013-08-13 12:12:16 PST --- (In reply to comment #2) > Why? Actually some platforms(mostly embedded systems like TV/STB) doesn't have battery powered reliable clock source. Wall Clock time is obtained via time sources like NTP(it may have some latency). So I feel use currentTime() only on the places which really needs wall clock time(like jsDateTime()), remaining places monotonicallyIncreasingTime() is good. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 12:13:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 12:13:54 -0700 Subject: [Webkit-unassigned] [Bug 119761] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119761 --- Comment #3 from Darin Adler 2013-08-13 12:13:27 PST --- We should think this through. I think we should use a shorter name for the time we use ?almost everywhere?. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 12:16:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 12:16:56 -0700 Subject: [Webkit-unassigned] [Bug 119761] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119761 --- Comment #4 from Ryosuke Niwa 2013-08-13 12:16:30 PST --- (In reply to comment #2) > (In reply to comment #1) > > What is the goal of this change? Why do we want to do this? > > Actually some platforms(mostly embedded systems like TV/STB) doesn't have battery powered reliable clock source. Wall Clock time is obtained via time sources like NTP(it may have some latency). So I feel use currentTime() only on the places which really needs wall clock time(like jsDateTime()), remaining places monotonicallyIncreasingTime() is good. I'm still not sure replacing calls to currentTime() by monotonicallyIncreasingTime() everywhere is such a great idea. Can't those platforms emulate currentTime? Presumably, this is just an optimization, right? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 12:24:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 12:24:36 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 kov's GTK+ EWS bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gtk-ews at kov.eti.br -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 12:24:39 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 12:24:39 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 kov's GTK+ EWS bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208651| |commit-queue- Flag| | --- Comment #14 from kov's GTK+ EWS bot 2013-08-13 12:24:14 PST --- (From update of attachment 208651) Attachment 208651 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1446748 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 12:30:00 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 12:30:00 -0700 Subject: [Webkit-unassigned] [Bug 119761] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119761 --- Comment #5 from Anders Carlsson 2013-08-13 12:29:35 PST --- (In reply to comment #3) > We should think this through. I think we should use a shorter name for the time we use ?almost everywhere?. C++11 calls this the ?steady clock? - http://en.cppreference.com/w/cpp/chrono/steady_clock -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 12:33:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 12:33:07 -0700 Subject: [Webkit-unassigned] [Bug 119761] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119761 --- Comment #6 from Arunprasad Rajkumar 2013-08-13 12:32:41 PST --- (In reply to comment #4) > (In reply to comment #2) > > (In reply to comment #1) > > > What is the goal of this change? Why do we want to do this? > > > > I'm still not sure replacing calls to currentTime() by monotonicallyIncreasingTime() everywhere is such a great idea. Can't those platforms emulate currentTime? Not just blindly everywhere. I think wall clock time is needed only in some places like jsDateTime, HTTP Resource Caching,.. >Presumably, this is just an optimization, right? Yes, it is a kind of optimization. The issue is some of the platform wall clock timer's accuracy is about 10ms(what we using), but monotonicallyIncreasingTime's accuracy is < 1ms. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 12:40:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 12:40:57 -0700 Subject: [Webkit-unassigned] [Bug 119654] [Qt] Avoid calling QWebPage's virtual functions during deletion of QWebPage In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119654 --- Comment #12 from Arunprasad Rajkumar 2013-08-13 12:40:32 PST --- (In reply to comment #11) > Created an attachment (id=208648) --> (https://bugs.webkit.org/attachment.cgi?id=208648&action=review) [details] > Patch Called unload() method implicitly from QWebViewPrivate::detachCurrentPage() & QGraphicsWebViewPrivate::detachCurrentPage(). So QtWebKit embedder uses QWebView/QGraphicsWebView, deletion of those will trigger unload() without any extra call. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 13:06:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 13:06:45 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #15 from Build Bot 2013-08-13 13:06:18 PST --- (From update of attachment 208651) Attachment 208651 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1458429 New failing tests: fullscreen/video-controls-override.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 13:06:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 13:06:50 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #16 from Build Bot 2013-08-13 13:06:23 PST --- Created an attachment (id=208666) --> (https://bugs.webkit.org/attachment.cgi?id=208666&action=review) Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 13:07:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 13:07:45 -0700 Subject: [Webkit-unassigned] [Bug 119551] Every scroll causes additional layer tree work because of flatteningLayer->removeFromParent(); In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119551 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |simon.fraser at apple.com |kit.org | CC| |simon.fraser at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 13:11:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 13:11:11 -0700 Subject: [Webkit-unassigned] [Bug 119732] REGRESSION (r153925): fast/media/media-query-list-07.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119732 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barraclough at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 13:50:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 13:50:09 -0700 Subject: [Webkit-unassigned] [Bug 119767] New: [WK2] Sync messages from secondary threads always time out Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119767 Summary: [WK2] Sync messages from secondary threads always time out Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh OS/Version: Mac OS X 10.8 Status: UNCONFIRMED Severity: Major Priority: P2 Component: WebKit2 AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: justin at cam.org Created an attachment (id=208670) --> (https://bugs.webkit.org/attachment.cgi?id=208670&action=review) proposed patch Any request from the UI process to the Web Content process that is made from a secondary thread will probably fail, because of a bug introduced with Connection::sendSyncMessageFromSecondaryThread() in r139514 (https://bugs.webkit.org/show_bug.cgi?id=106708). It is quite simple: the timeout argument to semaphore.wait() is supposed to be an absolute time, but the length of the timeout is being sent instead. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 13:58:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 13:58:25 -0700 Subject: [Webkit-unassigned] [Bug 119732] REGRESSION (r153925): fast/media/media-query-list-07.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119732 Andreas Kling changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Andreas Kling 2013-08-13 13:58:00 PST --- Rolled out Sam's patch here: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 14:03:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 14:03:09 -0700 Subject: [Webkit-unassigned] [Bug 109274] [CSSRegions] Text highlight in regions is wrong In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109274 Javier Fernandez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jfernandez at igalia.com --- Comment #3 from Javier Fernandez 2013-08-13 14:02:44 PST --- Well, I had to apply the patch posted at bug 117631 but I can confirm this bug is not reproducible in the Gtk+ port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 14:18:07 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 14:18:07 -0700 Subject: [Webkit-unassigned] [Bug 119767] [WK2] Sync messages with with non-default timeout sent from secondary threads always time out In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119767 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[WK2] Sync messages from |[WK2] Sync messages with |secondary threads always |with non-default timeout |time out |sent from secondary threads | |always time out Keywords| |InRadar --- Comment #1 from Alexey Proskuryakov 2013-08-13 14:17:42 PST --- Thank you, this is a good catch. Note however that we never send sync messages with timeouts from secondary threads. Can you please tell us more about the failing scenario? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 14:18:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 14:18:53 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #17 from Build Bot 2013-08-13 14:18:26 PST --- (From update of attachment 208651) Attachment 208651 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1456540 New failing tests: fullscreen/video-controls-override.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 14:18:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 14:18:56 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #18 from Build Bot 2013-08-13 14:18:30 PST --- Created an attachment (id=208675) --> (https://bugs.webkit.org/attachment.cgi?id=208675&action=review) Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 14:24:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 14:24:48 -0700 Subject: [Webkit-unassigned] [Bug 119767] [WK2] Sync messages with with non-default timeout sent from secondary threads always time out In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119767 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208670|0 |1 is obsolete| | Attachment #208676| |review? Flag| | --- Comment #2 from Alexey Proskuryakov 2013-08-13 14:24:23 PST --- Created an attachment (id=208676) --> (https://bugs.webkit.org/attachment.cgi?id=208676&action=review) patch with ChangeLog -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 14:24:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 14:24:56 -0700 Subject: [Webkit-unassigned] [Bug 119767] [WK2] Sync messages with non-default timeout sent from secondary threads always time out In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119767 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[WK2] Sync messages with |[WK2] Sync messages with |with non-default timeout |non-default timeout sent |sent from secondary threads |from secondary threads |always time out |always time out -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 14:25:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 14:25:25 -0700 Subject: [Webkit-unassigned] [Bug 109283] [CSS Regions] Layout Test fast/regions/selecting-text-through-different-region-flows.html is failing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=109283 Javier Fernandez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jfernandez at igalia.com --- Comment #3 from Javier Fernandez 2013-08-13 14:24:59 PST --- This test was added by the fix for the bug 105641, which just avoided the clearing issues limiting the selection to the region boundaries. I've proposed a new solution in the bug 119622, so perhaps adding a dependency on that bug would be a good idea. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 14:53:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 14:53:51 -0700 Subject: [Webkit-unassigned] [Bug 112263] Crash in JSC::CodeCacheMap::pruneSlowCase() running svg/css/scientific-numbers.html In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=112263 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE --- Comment #4 from Alexey Proskuryakov 2013-08-13 14:53:26 PST --- *** This bug has been marked as a duplicate of bug 113453 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 14:59:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 14:59:01 -0700 Subject: [Webkit-unassigned] [Bug 119750] Three inspector tests are crashing In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119750 --- Comment #1 from Alexey Proskuryakov 2013-08-13 14:58:35 PST --- This used to happen before, fairly rarely (bug 105988). But now it's all the time, which is a recent regression. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 15:06:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 15:06:45 -0700 Subject: [Webkit-unassigned] [Bug 119417] Use op_get_by_id_custom_stub to fast access to JSCallbackObject's static value In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119417 Yi Shen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208682| |review? Flag| | --- Comment #5 from Yi Shen 2013-08-13 15:06:19 PST --- Created an attachment (id=208682) --> (https://bugs.webkit.org/attachment.cgi?id=208682&action=review) updated with test -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 15:09:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 15:09:56 -0700 Subject: [Webkit-unassigned] [Bug 119417] Use op_get_by_id_custom_stub to fast access to JSCallbackObject's static value In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119417 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org --- Comment #6 from WebKit Commit Bot 2013-08-13 15:09:32 PST --- Attachment 208682 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject.h', u'Source/JavaScriptCore/API/JSCallbackObjectFunctions.h', u'Source/JavaScriptCore/API/JSClassRef.cpp', u'Source/JavaScriptCore/API/JSClassRef.h', u'Source/JavaScriptCore/API/tests/testapi.c', u'Source/JavaScriptCore/API/tests/testapi.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/runtime/PropertySlot.h', u'Source/JavaScriptCore/runtime/PutPropertySlot.h']" exit_code: 1 Source/JavaScriptCore/API/tests/testapi.c:678: MyCacheableObject_get_cacheableStaticValue is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/API/tests/testapi.c:694: CacheableObject_definition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/API/tests/testapi.c:717: MyCacheableObject_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/API/tests/testapi.c:728: MyUncacheableObject_getProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/API/tests/testapi.c:744: MyUncacheableObject_get_uncacheableStaticValue is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/API/tests/testapi.c:758: UncacheableObject_definition is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/API/tests/testapi.c:781: MyUncacheableObject_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 7 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 15:14:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 15:14:23 -0700 Subject: [Webkit-unassigned] [Bug 119755] [sh4] Prepare LLINT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119755 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208647|review+, commit-queue+ | Flag| | --- Comment #2 from Oliver Hunt 2013-08-13 15:13:58 PST --- (From update of attachment 208647) Clearing flags on attachment: 208647 Committed r154025: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 15:14:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 15:14:25 -0700 Subject: [Webkit-unassigned] [Bug 119755] [sh4] Prepare LLINT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119755 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Oliver Hunt 2013-08-13 15:14:00 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 15:18:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 15:18:57 -0700 Subject: [Webkit-unassigned] [Bug 119748] ASSERTION FAILED: resultAnimationElement->m_animatedType in WebCore::SVGAnimateElement::calculateAnimatedValue In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119748 Rob Buis changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |rwlbuis at gmail.com |kit.org | CC| |rwlbuis at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 15:45:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 15:45:22 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 --- Comment #4 from Geoffrey Garen 2013-08-13 15:44:56 PST --- Are you saying that monotonicallyIncreasingTime() is faster than currentTime()? If so, how did you measure that? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 15:53:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 15:53:26 -0700 Subject: [Webkit-unassigned] [Bug 115352] [gstreamer] Make sure gstreamer source element is thread-safe In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115352 Andre Moreira Magalhaes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208654|0 |1 is obsolete| | Attachment #208654|review? | Flag| | --- Comment #22 from Andre Moreira Magalhaes 2013-08-13 15:53:00 PST --- (From update of attachment 208654) Ignore this patch, I am working on an updated patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 15:54:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 15:54:31 -0700 Subject: [Webkit-unassigned] [Bug 119767] [WK2] Sync messages with non-default timeout sent from secondary threads always time out In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119767 --- Comment #3 from Justin Bur 2013-08-13 15:54:06 PST --- The timeout comes from ChildProcessProxy.h (default argument in ChildProcessProxy::sendSync(), called from UIProcess/mac/WebPageProxyMac.mm). The use case is calling methods of the NSTextInputClient protocol, such as - attributedSubstringForProposedRange:actualRange: on WKView. The secondary thread is running my scripting addition. More details on my scenario (a grammar and spell check application) in bug 61889. It would probably be possible to do the same work using the AppleScript command "do JavaScript" to access the DOM directly. The nice thing about NSTextInputClient is that it conveniently converts back and forth between the DOM and flat attributed strings. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 15:54:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 15:54:54 -0700 Subject: [Webkit-unassigned] [Bug 73743] [GStreamer] webkitwebsrc: use SubResourceLoader In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=73743 Andre Moreira Magalhaes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrunko at gmail.com --- Comment #29 from Andre Moreira Magalhaes 2013-08-13 15:54:27 PST --- I am working on an updated patch for bug #115352 and stumbled upon an issue related to this bug. The issue is that the webkit source element can be created by any code using gst_element_make_from_uri with the uris supported by the webkit source element (currently http/https uris). This means that the source element may exist without a player involved (e.g. dash gstreamer plugin loading fragments in different threads), in which case we cannot get the CachedResourceLoader from priv->player which would not be set. I will try to create a CachedResourceLoader/CachedResource manually (when priv->player is not set) and see how it goes, otherwise I believe we will have to have 2 code branches (one using CachedResourceLoader as is now and another one using ResourceHandle as it was before). Please let me know what you think. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 16:41:10 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 16:41:10 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 --- Comment #5 from Darin Adler 2013-08-13 16:40:44 PST --- (In reply to comment #4) > Are you saying that monotonicallyIncreasingTime() is faster than currentTime()? If so, how did you measure that? No he?s not saying that. He?s saying that on his platform, monotonicallyIncreasingTime has higher resolution than currentTime. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 16:48:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 16:48:18 -0700 Subject: [Webkit-unassigned] [Bug 73743] [GStreamer] webkitwebsrc: use SubResourceLoader In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=73743 --- Comment #30 from Andre Moreira Magalhaes 2013-08-13 16:47:51 PST --- Ok, I tried creating a CachedResourceLoader manually (inside the webkit source element when there is no player involved) with CachedResourceLoader::create(0) but when calling requestRawResource() it always returns null. I nailed it down to ResourceLoader::init() failing when called from SubresourceLoader::init() called from CachedResourceLoader::requestResource(). Is there a way to create a CachedResourceLoader without a Document/frame involved? If not we should either have 2 code branches in the webkit source as I stated on comment #29 or revert this patch and always use ResourceHandle as it was before. Please let me know what you think. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 17:00:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 17:00:49 -0700 Subject: [Webkit-unassigned] [Bug 115352] [gstreamer] Make sure gstreamer source element is thread-safe In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=115352 --- Comment #23 from Andre Moreira Magalhaes 2013-08-13 17:00:23 PST --- (In reply to comment #22) > (From update of attachment 208654 [details]) > Ignore this patch, I am working on an updated patch. I have a semi updated patch that should fix this bug, but the final changes here depend on input on bug #73743 (added some comments there). Once we solve the issue with my comments on bug #73743 I will push a new patch here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 17:05:56 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 17:05:56 -0700 Subject: [Webkit-unassigned] [Bug 119767] [WK2] Sync messages with non-default timeout sent from secondary threads always time out In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119767 --- Comment #4 from Alexey Proskuryakov 2013-08-13 17:05:31 PST --- Thank you for the additional information! It's not valid to use NSTextInputClient methods form a secondary thread. We make no attempt to make this work, and in fact do access a lot of shared state from these methods. We should still fix this mistake of course, however I strongly suggest looking into a way to not call -attributedSubstringForProposedRange:actualRange: from secondary threads. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 17:27:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 17:27:29 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208657|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #6 from Geoffrey Garen 2013-08-13 17:27:03 PST --- (From update of attachment 208657) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 17:27:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 17:27:41 -0700 Subject: [Webkit-unassigned] [Bug 119767] [WK2] Sync messages with non-default timeout sent from secondary threads always time out In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119767 --- Comment #5 from Justin Bur 2013-08-13 17:27:16 PST --- (In reply to comment #4) Ah, that is good to know. I will make my code comply with that restriction. Thank you! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 17:27:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 17:27:45 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 --- Comment #7 from Geoffrey Garen 2013-08-13 17:27:18 PST --- Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 17:42:41 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 17:42:41 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 --- Comment #14 from Jinwoo Jeong 2013-08-13 17:42:15 PST --- Dean, if you don't have time to review this patch until tonight, I will ask another committer for landing this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 17:50:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 17:50:20 -0700 Subject: [Webkit-unassigned] [Bug 73936] Web Inspector: [JSC] implement ScriptProfiler::domNodeCount In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=73936 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WONTFIX CC| |dino at apple.com --- Comment #2 from Dean Jackson 2013-08-13 17:49:54 PST --- Removed method in Bug 119776 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 17:50:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 17:50:45 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208657|review+, commit-queue+ | Flag| | --- Comment #8 from WebKit Commit Bot 2013-08-13 17:50:19 PST --- (From update of attachment 208657) Clearing flags on attachment: 208657 Committed r154032: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 17:50:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 17:50:47 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #9 from WebKit Commit Bot 2013-08-13 17:50:21 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 17:50:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 17:50:48 -0700 Subject: [Webkit-unassigned] [Bug 119761] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119761 Bug 119761 depends on bug 119762, which changed state. Bug 119762 Summary: [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places https://bugs.webkit.org/show_bug.cgi?id=119762 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |FIXED Status|UNCONFIRMED |RESOLVED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 18:19:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 18:19:30 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.fraser at apple.com --- Comment #10 from Simon Fraser (smfr) 2013-08-13 18:19:03 PST --- The changelog and commit message should have explained the "why". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 18:29:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 18:29:35 -0700 Subject: [Webkit-unassigned] [Bug 119779] New: The length of scheme is at least five characters even when the scheme has 'web+' prefix Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119779 Summary: The length of scheme is at least five characters even when the scheme has 'web+' prefix Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gyuyoung.kim at samsung.com The content-scheme handler specification requires that it is SecurityError if the length of scheme isn't five characters at least, including 'web+' prefix. Thus, we need to check the length of scheme on the 'web+' scheme. Spec: http://www.whatwg.org/specs/web-apps/current-work/#custom-handlers Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=156049 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 18:30:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 18:30:47 -0700 Subject: [Webkit-unassigned] [Bug 119779] The length of scheme is at least five characters even when the scheme has 'web+' prefix In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119779 Gyuyoung Kim changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |gyuyoung.kim at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 18:41:08 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 18:41:08 -0700 Subject: [Webkit-unassigned] [Bug 119727] Do not dispatch 'focus' or 'blur' event twice when window active state is changed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119727 --- Comment #1 from Kent Tamura 2013-08-13 18:40:42 PST --- AFAIK, Apple Mac port doesn't have this issue. Test page: http://jsfiddle.net/FbzNA/ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 18:43:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 18:43:35 -0700 Subject: [Webkit-unassigned] [Bug 119713] Remove focus if supportsFocus state is changed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119713 Kent Tamura changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |112992, 118626 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 18:43:37 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 18:43:37 -0700 Subject: [Webkit-unassigned] [Bug 112992] document.activeElement should not point elements with display:none In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=112992 Kent Tamura changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119713 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 18:43:38 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 18:43:38 -0700 Subject: [Webkit-unassigned] [Bug 118626] Introduce non-virtual Node::isFocusable and virtual rendererIsFocusable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118626 Kent Tamura changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119713 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 18:44:25 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 18:44:25 -0700 Subject: [Webkit-unassigned] [Bug 119713] Remove focus if supportsFocus state is changed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119713 Kent Tamura changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|118626 | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 18:44:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 18:44:26 -0700 Subject: [Webkit-unassigned] [Bug 118626] Introduce non-virtual Node::isFocusable and virtual rendererIsFocusable In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118626 Kent Tamura changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|119713 | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 19:13:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 19:13:47 -0700 Subject: [Webkit-unassigned] [Bug 119764] srcset: Respect updates to display density In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119764 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dino at apple.com, | |sam at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 19:40:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 19:40:59 -0700 Subject: [Webkit-unassigned] [Bug 119781] New: [WK2] Assertion failure in WebCore::Page::checkSubframeCountConsistency when going back Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119781 Summary: [WK2] Assertion failure in WebCore::Page::checkSubframeCountConsistency when going back Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: History AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: changseok.oh at collabora.com I faced this assertion failure when going back to a page which has multiple frames. The backtrace is ... Program received signal SIGSEGV, Segmentation fault. 0x00007ff42b9e9ee5 in WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:342 342 *(int *)(uintptr_t)0xbbadbeef = 0; (gdb) bt #0 0x00007ff42b9e9ee5 in WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:342 #1 0x00007ff42d7757f2 in WebCore::Page::checkSubframeCountConsistency ( this=0x1afc210) at ../../Source/WebCore/page/Page.cpp:1255 #2 0x00007ff42d3c9d02 in WebCore::Page::subframeCount (this=0x1afc210) at ../../Source/WebCore/page/Page.h:185 #3 0x00007ff42d74e152 in WebCore::Frame::isURLAllowed (this=0x3445710, url=...) at ../../Source/WebCore/page/Frame.cpp:1022 #4 0x00007ff42d489639 in WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL ( this=0x374a410, url=...) at ../../Source/WebCore/html/HTMLPlugInImageElement.cpp:177 #5 0x00007ff42d44e09e in WebCore::HTMLEmbedElement::updateWidget (this=0x374a410, pluginCreationOption=WebCore::CreateOnlyNonNetscapePlugins) at ../../Source/WebCore/html/HTMLEmbedElement.cpp:137 #6 0x00007ff42d489d03 in WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary ( this=0x374a410) at ../../Source/WebCore/html/HTMLPlugInImageElement.cpp:274 #7 0x00007ff42d489fc5 in WebCore::HTMLPlugInImageElement::updateWidgetCallback (n= 0x374a410) at ../../Source/WebCore/html/HTMLPlugInImageElement.cpp:331 #8 0x00007ff42d207b2a in WebCore::ContainerNode::dispatchPostAttachCallbacks () at ../../Source/WebCore/dom/ContainerNode.cpp:772 #9 0x00007ff42d207981 in WebCore::ContainerNode::resumePostAttachCallbacks ( this=0x3748570) at ../../Source/WebCore/dom/ContainerNode.cpp:739 #10 0x00007ff42d229d79 in WebCore::PostAttachCallbackDisabler::~PostAttachCallbackDisabler (this=0x7fffaa656620, __in_chrg=) at ../../Source/WebCore/dom/ContainerNode.h:345 #11 0x00007ff42d489bac in WebCore::HTMLPlugInImageElement::attach (this=0x3748570, context=...) at ../../Source/WebCore/html/HTMLPlugInImageElement.cpp:250 #12 0x00007ff42d2ff799 in WebCore::Node::reattach (this=0x3748570, context=...) at ../../Source/WebCore/dom/Node.h:811 #13 0x00007ff42da295d7 in WebCore::Style::resolveLocal (current=0x3748570, inheritedChange=WebCore::Style::Force) at ../../Source/WebCore/style/StyleResolveTree.cpp:152 #14 0x00007ff42da29b4b in WebCore::Style::resolveTree (current=0x3748570, change=WebCore::Style::Force) at ../../Source/WebCore/style/StyleResolveTree.cpp:236 #15 0x00007ff42d489f09 in WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache (this=0x3748570) at ../../Source/WebCore/html/HTMLPlugInImageElement.cpp:316 #16 0x00007ff42d2222b0 in WebCore::Document::documentDidResumeFromPageCache ( this=0x2be2f90) at ../../Source/WebCore/dom/Document.cpp:4023 #17 0x00007ff42d3c7d18 in WebCore::CachedFrameBase::restore (this=0x32ea688) at ../../Source/WebCore/history/CachedFrame.cpp:149 #18 0x00007ff42d6888b3 in WebCore::FrameLoader::open (this=0x3445790, cachedFrame=...) at ../../Source/WebCore/loader/FrameLoader.cpp:2023 ---Type to continue, or q to quit--- #19 0x00007ff42d3c82b8 in WebCore::CachedFrame::open (this=0x32ea680) at ../../Source/WebCore/history/CachedFrame.cpp:220 #20 0x00007ff42d3c7c1c in WebCore::CachedFrameBase::restore (this=0x21da638) at ../../Source/WebCore/history/CachedFrame.cpp:134 #21 0x00007ff42d6888b3 in WebCore::FrameLoader::open (this=0x1a39d20, cachedFrame=...) at ../../Source/WebCore/loader/FrameLoader.cpp:2023 #22 0x00007ff42d3c82b8 in WebCore::CachedFrame::open (this=0x21da630) at ../../Source/WebCore/history/CachedFrame.cpp:220 #23 0x00007ff42d3c9a75 in WebCore::CachedPage::restore (this=0x2ea4d40, page=0x1afc210) at ../../Source/WebCore/history/CachedPage.cpp:83 #24 0x00007ff42d687623 in WebCore::FrameLoader::commitProvisionalLoad (this=0x1a39d20) at ../../Source/WebCore/loader/FrameLoader.cpp:1742 #25 0x00007ff42d68d0ba in WebCore::FrameLoader::loadProvisionalItemFromCachedPage ( this=0x1a39d20) at ../../Source/WebCore/loader/FrameLoader.cpp:3040 #26 0x00007ff42d68bfdf in WebCore::FrameLoader::continueLoadAfterNavigationPolicy ( this=0x1a39d20, formState=..., shouldContinue=true) at ../../Source/WebCore/loader/FrameLoader.cpp:2882 #27 0x00007ff42d68b575 in WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy (argument=0x1a39d20, request=..., formState=..., shouldContinue=true) at ../../Source/WebCore/loader/FrameLoader.cpp:2718 #28 0x00007ff42d6b8029 in WebCore::PolicyCallback::call (this=0x7fffaa657010, shouldContinue=true) at ../../Source/WebCore/loader/PolicyCallback.cpp:103 #29 0x00007ff42d6b8f98 in WebCore::PolicyChecker::continueAfterNavigationPolicy ( this=0x1a39fa0, policy=WebCore::PolicyUse) at ../../Source/WebCore/loader/PolicyChecker.cpp:180 #30 0x00007ff42cecbc6a in WebKit::WebFrame::didReceivePolicyDecision (this=0x19f7230, listenerID=48, action=WebCore::PolicyUse, downloadID=0) at ../../Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:234 #31 0x00007ff42cea321d in WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction (this=0x19f7268, function= (void (WebCore::PolicyChecker::*)(WebCore::PolicyChecker * const, WebCore::PolicyAction)) 0x7ff42d6b8d2e , navigationAction=..., request=..., formState=...) at ../../Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:708 #32 0x00007ff42d6b8951 in WebCore::PolicyChecker::checkNavigationPolicy ( this=0x1a39fa0, request=..., loader=0x3111780, formState=..., function=0x7ff42d68b526 , bool)>, argument=0x1a39d20) at ../../Source/WebCore/loader/PolicyChecker.cpp:99 #33 0x00007ff42d685d40 in WebCore::FrameLoader::loadWithDocumentLoader ( this=0x1a39d20, loader=0x3111780, type=WebCore::FrameLoadTypeBack, prpFormState=...) at ../../Source/WebCore/loader/FrameLoader.cpp:1422 ---Type to continue, or q to quit--- #34 0x00007ff42d68d699 in WebCore::FrameLoader::loadDifferentDocumentItem ( this=0x1a39d20, item=0x1c58a50, loadType=WebCore::FrameLoadTypeBack, cacheLoadPolicy=WebCore::FrameLoader::MayAttemptCacheOnlyLoadForFormSubmissionItem) at ../../Source/WebCore/loader/FrameLoader.cpp:3135 #35 0x00007ff42d68dd17 in WebCore::FrameLoader::loadItem (this=0x1a39d20, item=0x1c58a50, loadType=WebCore::FrameLoadTypeBack) at ../../Source/WebCore/loader/FrameLoader.cpp:3223 #36 0x00007ff42d696f10 in WebCore::HistoryController::recursiveGoToItem ( this=0x1a3a240, item=0x1c58a50, fromItem=0x36dc950, type=WebCore::FrameLoadTypeBack) at ../../Source/WebCore/loader/HistoryController.cpp:765 #37 0x00007ff42d694fb2 in WebCore::HistoryController::goToItem (this=0x1a3a240, targetItem=0x1c58a50, type=WebCore::FrameLoadTypeBack) at ../../Source/WebCore/loader/HistoryController.cpp:306 #38 0x00007ff42d77245a in WebCore::Page::goToItem (this=0x1afc210, item=0x1c58a50, type=WebCore::FrameLoadTypeBack) at ../../Source/WebCore/page/Page.cpp:432 #39 0x00007ff42ced5db9 in WebKit::WebPage::goBack (this=0x1afbb60, backForwardItemID=3) at ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1036 #40 0x00007ff42cf3b903 in CoreIPC::callMemberFunction (args=..., object=0x1afbb60, function= (void (WebKit::WebPage::*)(WebKit::WebPage * const, unsigned long)) 0x7ff42ced5d28 ) at ../../Source/WebKit2/Platform/CoreIPC/HandleMessage.h:21 #41 0x00007ff42cf38905 in CoreIPC::handleMessage (decoder=..., object=0x1afbb60, function= (void (WebKit::WebPage::*)(WebKit::WebPage * const, unsigned long)) 0x7ff42ced5d28 ) at ../../Source/WebKit2/Platform/CoreIPC/HandleMessage.h:376 #42 0x00007ff42cf335be in WebKit::WebPage::didReceiveWebPageMessage (this=0x1afbb60, decoder=...) at DerivedSources/WebKit2/WebPageMessageReceiver.cpp:172 #43 0x00007ff42cedcaca in WebKit::WebPage::didReceiveMessage (this=0x1afbb60, connection=0x19934c0, decoder=...) at ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3179 #44 0x00007ff42e43450e in CoreIPC::MessageReceiverMap::dispatchMessage ( this=0x19c3df0, connection=0x19934c0, decoder=...) at ../../Source/WebKit2/Platform/CoreIPC/MessageReceiverMap.cpp:86 #45 0x00007ff42cef376d in WebKit::WebProcess::didReceiveMessage (this=0x19c3d90, connection=0x19934c0, decoder=...) at ../../Source/WebKit2/WebProcess/WebProcess.cpp:638 #46 0x00007ff42e423ea4 in CoreIPC::Connection::dispatchMessage (this=0x19934c0, decoder=...) at ../../Source/WebKit2/Platform/CoreIPC/Connection.cpp:793 ---Type to continue, or q to quit--- #47 0x00007ff42e423f84 in CoreIPC::Connection::dispatchMessage (this=0x19934c0, incomingMessage=...) at ../../Source/WebKit2/Platform/CoreIPC/Connection.cpp:816 #48 0x00007ff42e424195 in CoreIPC::Connection::dispatchOneMessage (this=0x19934c0) at ../../Source/WebKit2/Platform/CoreIPC/Connection.cpp:842 #49 0x00007ff42e43391f in WTF::FunctionWrapper::operator() (this=0x7ff3d0001f90, c=0x19934c0) at ../../Source/WTF/wtf/Functional.h:218 #50 0x00007ff42e4334a4 in WTF::BoundFunctionImpl, void (CoreIPC::Connection*)>::operator()() (this=0x7ff3d0001f80) at ../../Source/WTF/wtf/Functional.h:496 #51 0x00007ff42ceb4aed in WTF::Function::operator()() const ( this=0x7fffaa658830) at ../../Source/WTF/wtf/Functional.h:704 #52 0x00007ff42e2f924f in WebCore::RunLoop::performWork (this=0x19c3c10) at ../../Source/WebCore/platform/RunLoop.cpp:104 #53 0x00007ff42e3198cc in WebCore::RunLoop::queueWork (runLoop=0x19c3c10) at ../../Source/WebCore/platform/gtk/RunLoopGtk.cpp:104 #54 0x00007ff426483fd5 in g_main_dispatch (context=0x19538c0) at gmain.c:3058 #55 g_main_context_dispatch (context=context at entry=0x19538c0) at gmain.c:3634 #56 0x00007ff426484318 in g_main_context_iterate (context=0x19538c0, block=block at entry=1, dispatch=dispatch at entry=1, self=) at gmain.c:3705 #57 0x00007ff42648478a in g_main_loop_run (loop=0x19c3c90) at gmain.c:3899 #58 0x00007ff42e319692 in WebCore::RunLoop::run () at ../../Source/WebCore/platform/gtk/RunLoopGtk.cpp:61 #59 0x00007ff42ce11d64 in WebKit::WebProcessMainGtk (argc=2, argv=0x7fffaa658b58) at ../../Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:78 #60 0x000000000040080c in main (argc=2, argv=0x7fffaa658b58) at ../../Source/WebKit2/gtk/MainGtk.cpp:31 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 19:41:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 19:41:27 -0700 Subject: [Webkit-unassigned] [Bug 119727] Do not dispatch 'focus' or 'blur' event twice when window active state is changed In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119727 --- Comment #2 from Ryosuke Niwa 2013-08-13 19:41:01 PST --- (In reply to comment #1) > AFAIK, Apple Mac port doesn't have this issue. > > Test page: http://jsfiddle.net/FbzNA/ Thanks for the info! We should probably add a test though. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 20:07:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 20:07:18 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #19 from Build Bot 2013-08-13 20:06:51 PST --- (From update of attachment 208651) Attachment 208651 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1453665 New failing tests: fullscreen/video-controls-override.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 20:07:23 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 20:07:23 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 --- Comment #20 from Build Bot 2013-08-13 20:06:56 PST --- Created an attachment (id=208697) --> (https://bugs.webkit.org/attachment.cgi?id=208697&action=review) Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 21:19:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 21:19:44 -0700 Subject: [Webkit-unassigned] [Bug 119782] New: [EFL] fast/forms/search-styled.html is failing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119782 Summary: [EFL] fast/forms/search-styled.html is failing Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit EFL AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ryuan.choi at samsung.com CC: demarchi at webkit.org fast/forms/search-styled.html requires apple image but Efl port does draw it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 21:40:22 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 21:40:22 -0700 Subject: [Webkit-unassigned] [Bug 119783] New: Add toSVGTextPathElement(), and use it Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119783 Summary: Add toSVGTextPathElement(), and use it Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Keywords: BlinkMergeCandidate Severity: Normal Priority: P2 Component: SVG AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gyuyoung.kim at samsung.com CC: zimmermann at kde.org As a step to clean-up static_cast, static_cast can be changed with toSVGTextPathElement(). Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=156060 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 21:42:21 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 21:42:21 -0700 Subject: [Webkit-unassigned] [Bug 119783] Add toSVGTextPathElement(), and use it In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119783 Gyuyoung Kim changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |gyuyoung.kim at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 21:45:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 21:45:51 -0700 Subject: [Webkit-unassigned] [Bug 119619] [Win] TestWebKitAPI fails to link. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119619 Alex Christensen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |achristensen at apple.com --- Comment #5 from Alex Christensen 2013-08-13 21:45:26 PST --- The parameter of this function is a size_t, which is the size of a pointer, which changes with the 64-bit build. This should have been the following: symbolWithPointer(?frameOrientationAtIndex at BitmapImage@WebCore@@IAE?AVImageOrientation at 2@I at Z, ?frameOrientationAtIndex at BitmapImage@WebCore@@IEAA?AVImageOrientation at 2@_K at Z) I'll commit this manually. It doesn't break anything any bots are doing right now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 21:59:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 21:59:43 -0700 Subject: [Webkit-unassigned] [Bug 119654] [Qt] Avoid calling QWebPage's virtual functions during deletion of QWebPage In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119654 Jose Lejin PJ changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose.lejin at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 22:48:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 22:48:06 -0700 Subject: [Webkit-unassigned] [Bug 73743] [GStreamer] webkitwebsrc: use SubResourceLoader In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=73743 --- Comment #31 from Carlos Garcia Campos 2013-08-13 22:47:38 PST --- I think the WebKit source element is to load URIs inside WebKit, to load HTTP/HTTPS URIs from any other application not using WebKit I think there's another implementation based only on libsoup. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 22:59:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 22:59:52 -0700 Subject: [Webkit-unassigned] [Bug 119762] [WTF] [JSC] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119762 --- Comment #11 from Arunprasad Rajkumar 2013-08-13 22:59:25 PST --- (In reply to comment #10) > The changelog and commit message should have explained the "why". Simon, sorry for not including details. I will add more details while doing the change for WebCore.(Or is it possible to change the commit message?) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 13 23:07:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 13 Aug 2013 23:07:52 -0700 Subject: [Webkit-unassigned] [Bug 119784] New: [EFL] fast/forms/datalist/input-list.html is failing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119784 Summary: [EFL] fast/forms/datalist/input-list.html is failing Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit EFL AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ryuan.choi at samsung.com CC: demarchi at webkit.org fast/forms/datalist/input-list.html is failing on all EFL platforms. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:11:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:11:30 -0700 Subject: [Webkit-unassigned] [Bug 73743] [GStreamer] webkitwebsrc: use SubResourceLoader In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=73743 --- Comment #32 from Philippe Normand 2013-08-14 00:11:02 PST --- Yes there is a souphttpsrc element in gst-plugins-good but the issue is that in WebKit we kinda neutralize it by configuring our http element to a higher rank. So code in gst plugins calling gst_element_make_from_uri("http") will indeed get a webkitwebsrc element :) We intend to fix that in bug 108088 . Andre, perhaps you can try the patch from that bug? It's not ready to land yet but it should help you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:20:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:20:57 -0700 Subject: [Webkit-unassigned] [Bug 119785] New: [WebCore] Replace currentTime() with monotonicallyIncreasingTime() in all possible places Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119785 Summary: [WebCore] Replace currentTime() with monotonicallyIncreasingTime() in all possible places Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: arurajku at cisco.com CC: darin at apple.com, andersca at apple.com, ggaren at apple.com, rniwa at webkit.org, ararunprasad at gmail.com Replace currentTime() with monotonicallyIncreasingTime() in WebCore [at appropriate places] -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:22:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:22:18 -0700 Subject: [Webkit-unassigned] [Bug 119785] [WebCore] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119785 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119761 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:22:20 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:22:20 -0700 Subject: [Webkit-unassigned] [Bug 119761] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119761 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119785 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:25:02 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:25:02 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208601| |commit-queue+ Flag| | --- Comment #15 from Dirk Schulze 2013-08-14 00:24:36 PST --- (From update of attachment 208601) (In reply to comment #14) > Dean, if you don't have time to review this patch until tonight, I will ask another committer for landing this patch. Looks good. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:25:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:25:49 -0700 Subject: [Webkit-unassigned] [Bug 119786] New: [EFL] decoration of search type is different from other platforms Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119786 Summary: [EFL] decoration of search type is different from other platforms Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit EFL AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ryuan.choi at samsung.com CC: demarchi at webkit.org Search field has three types of decoration style, -webkit-search-results-button, -webkit-search-results-decoration and -webkit-search-decoration Other platforms except Efl port draw glass icon for search type in first two cases, but only Efl ports draw icon in last case. It looks better for Efl port to draw icon in first two cases like other ports. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:29:16 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:29:16 -0700 Subject: [Webkit-unassigned] [Bug 119719] Suppress zero-length text SVG inline renderers In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119719 --- Comment #1 from Dirk Schulze 2013-08-14 00:28:50 PST --- IIRC xml:space won't make it into SVG2 in favor of space handling in HTML. Just as a note to this bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:34:42 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:34:42 -0700 Subject: [Webkit-unassigned] [Bug 119785] [WebCore] Replace currentTime() with monotonicallyIncreasingTime() in all possible places In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119785 Jose Lejin PJ changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose.lejin at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:48:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:48:44 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208601|review+, commit-queue+ | Flag| | --- Comment #16 from WebKit Commit Bot 2013-08-14 00:48:18 PST --- (From update of attachment 208601) Clearing flags on attachment: 208601 Committed r154042: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:48:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:48:47 -0700 Subject: [Webkit-unassigned] [Bug 119671] FEComponentTransfer could be faster In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119671 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #17 from WebKit Commit Bot 2013-08-14 00:48:21 PST --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:54:45 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:54:45 -0700 Subject: [Webkit-unassigned] [Bug 119787] New: Add toSVGClipPathElement(), and use it Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119787 Summary: Add toSVGClipPathElement(), and use it Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: SVG AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gyuyoung.kim at samsung.com CC: zimmermann at kde.org As a step to clean-up static_cast, static_cast also can be changed with toSVGClipPathElement(). As minor clean-up, this cl changes to use toSVGSVGElement() instead of static_cast. Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=156069 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 00:56:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 00:56:12 -0700 Subject: [Webkit-unassigned] [Bug 119787] Add toSVGClipPathElement(), and use it In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119787 Gyuyoung Kim changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |gyuyoung.kim at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 01:12:48 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 01:12:48 -0700 Subject: [Webkit-unassigned] [Bug 119786] [EFL] decoration of search type is different from other platforms In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119786 Ryuan Choi changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |ryuan.choi at samsung.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:07:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:07:50 -0700 Subject: [Webkit-unassigned] [Bug 119477] [GStreamer] Store preloaded media in webkit's cache In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119477 --- Comment #1 from Sebastian Dr?ge 2013-08-14 02:07:23 PST --- It currently is impossible to do that properly, best solution would probably be to expose that queue2 property on uridecodebin and playbin. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:10:29 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:10:29 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119755 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:10:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:10:30 -0700 Subject: [Webkit-unassigned] [Bug 119755] [sh4] Prepare LLINT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119755 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119737 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:10:50 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:10:50 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119758 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:10:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:10:51 -0700 Subject: [Webkit-unassigned] [Bug 119758] [sh4] Prepare baseline JIT for DFG_JIT implementation for sh4 architecture. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119758 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119737 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:14:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:14:27 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 --- Comment #8 from Julien Brianceau 2013-08-14 02:14:01 PST --- Created an attachment (id=208707) --> (https://bugs.webkit.org/attachment.cgi?id=208707&action=review) DFG_JIT implementation for sh4 architecture (after split) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:14:59 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:14:59 -0700 Subject: [Webkit-unassigned] [Bug 119788] New: [CMake] Fix building with bison-3.0 after r153749. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119788 Summary: [CMake] Fix building with bison-3.0 after r153749. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit EFL AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abrhm at inf.u-szeged.hu CC: galpeter at inf.u-szeged.hu, demarchi at webkit.org Fix the build where the generated glslang isn't compile with Bison 3.0 or greater. Use already generated glslang instead. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:16:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:16:46 -0700 Subject: [Webkit-unassigned] [Bug 119788] [CMake] Fix building with bison-3.0. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119788 G?bor ?brah?m changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[CMake] Fix building with |[CMake] Fix building with |bison-3.0 after r153749. |bison-3.0. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:22:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:22:47 -0700 Subject: [Webkit-unassigned] [Bug 119737] [sh4] DFG_JIT implementation for sh4 architecture In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119737 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208707| |review?, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:23:18 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:23:18 -0700 Subject: [Webkit-unassigned] [Bug 118306] [WTR] Should dump as text when the mimetype is text/plain In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118306 --- Comment #34 from Peter Gal 2013-08-14 02:22:51 PST --- (In reply to comment #32) > (From update of attachment 207323 [details]) > Attachment 207323 [details] did not pass win-ews (win): > Output: http://webkit-queues.appspot.com/results/1249652 > > New failing tests: > dom/xhtml/level1/core/documentinvalidcharacterexceptioncreateentref1.xhtml > dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.svg > dom/html/level2/events/dispatchEvent04.html > dom/html/level2/html/HTMLSelectElement20.html > dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.svg > dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02.svg > dom/html/level1/core/documentinvalidcharacterexceptioncreateentref.html > dom/html/level2/core/hc_namednodemapinvalidtype1.html > dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR.svg > dom/html/level2/events/dispatchEvent01.html > dom/xhtml/level1/core/hc_attrappendchild4.xhtml > dom/html/level2/events/dispatchEvent03.html > dom/html/level2/events/dispatchEvent02.html > dom/html/level2/core/createDocumentType04.html > dom/html/level1/core/documentinvalidcharacterexceptioncreateentref1.html > dom/html/level1/core/documentinvalidcharacterexceptioncreatepi1.html > dom/html/level2/events/dispatchEvent06.html > css1/basic/comments.html > dom/xhtml/level1/core/documentinvalidcharacterexceptioncreatepi1.xhtml > dom/html/level2/events/dispatchEvent07.html > dom/html/level2/core/setAttributeNS10.html > dom/html/level2/events/dispatchEvent05.html > dom/html/level1/core/hc_attrappendchild2.html > dom/html/level2/core/createAttributeNS06.html > dom/html/level1/core/hc_attrappendchild4.html > dom/xhtml/level1/core/documentinvalidcharacterexceptioncreatepi.xhtml > dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01.svg > dom/xhtml/level1/core/documentinvalidcharacterexceptioncreateentref.xhtml > dom/xhtml/level1/core/hc_attrappendchild2.xhtml > dom/html/level1/core/documentinvalidcharacterexceptioncreatepi.html These are DRT related crashes. This patch couldn't have caused that. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:25:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:25:40 -0700 Subject: [Webkit-unassigned] [Bug 119788] [CMake] Fix building with bison-3.0. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119788 G?bor ?brah?m changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208708| |review? Flag| | --- Comment #1 from G?bor ?brah?m 2013-08-14 02:25:14 PST --- Created an attachment (id=208708) --> (https://bugs.webkit.org/attachment.cgi?id=208708&action=review) Fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:27:06 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:27:06 -0700 Subject: [Webkit-unassigned] [Bug 119788] [CMake] Fix building with bison-3.0. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119788 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org, | |gyuyoung.kim at webkit.org, | |rakuco at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:27:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:27:12 -0700 Subject: [Webkit-unassigned] [Bug 119788] [CMake] Fix building with bison-3.0. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119788 G?bor ?brah?m changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208708| |commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 02:27:19 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 02:27:19 -0700 Subject: [Webkit-unassigned] [Bug 118306] [WTR] Should dump as text when the mimetype is text/plain In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118306 Peter Gal changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207323|0 |1 is obsolete| | Attachment #207323|review? | Flag| | Attachment #208709| |review?, commit-queue? Flag| | --- Comment #35 from Peter Gal 2013-08-14 02:26:53 PST --- Created an attachment (id=208709) --> (https://bugs.webkit.org/attachment.cgi?id=208709&action=review) patch v5 Updated patch: - removed WTF:: - using WKStringIsEqualToUTF8CString method as per reviewer request. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:01:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:01:44 -0700 Subject: [Webkit-unassigned] [Bug 117735] [curl] Improve multipart response handling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117735 Peter Gal changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206765|0 |1 is obsolete| | Attachment #206765|commit-queue? | Flag| | Attachment #208710| |review?, commit-queue? Flag| | --- Comment #9 from Peter Gal 2013-08-14 03:01:18 PST --- Created an attachment (id=208710) --> (https://bugs.webkit.org/attachment.cgi?id=208710&action=review) patch v2 updated patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:18:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:18:05 -0700 Subject: [Webkit-unassigned] [Bug 119789] New: [EFL] Several tests in fast/events/touch are crashed Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119789 Summary: [EFL] Several tests in fast/events/touch are crashed Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: WebKit EFL AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ryuan.choi at samsung.com CC: demarchi at webkit.org Maybe after r153770, several tests in fast/events/touch are crashed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:19:33 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:19:33 -0700 Subject: [Webkit-unassigned] [Bug 119789] Regression(r153770?): Several tests in fast/events/touch are crashing on EFL In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119789 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[EFL] Several tests in |Regression(r153770?): |fast/events/touch are |Several tests in |crashed |fast/events/touch are | |crashing on EFL CC| |dchris at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:19:51 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:19:51 -0700 Subject: [Webkit-unassigned] [Bug 119790] New: [Qt] Activate visibility API layout tests Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 Summary: [Qt] Activate visibility API layout tests Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: bdupont at nds.com CC: allan.jensen at digia.com, hausmann at webkit.org, jocelyn.turcotte at digia.com, jbrianceau at nds.com With https://bugs.webkit.org/show_bug.cgi?id=109422 we can activate visibility API layout tests. Furthermore, void TestRunner::setPageVisibility(const char* visibility) method must be implemented. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:20:34 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:20:34 -0700 Subject: [Webkit-unassigned] [Bug 119789] Regression(r153770?): Several tests in fast/events/touch are crashing on EFL In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119789 Ryuan Choi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eunmi15.lee at samsung.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:26:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:26:26 -0700 Subject: [Webkit-unassigned] [Bug 119791] New: [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433) Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119791 Summary: [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433) Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P3 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: arurajku at cisco.com CC: allan.jensen at digia.com, ararunprasad at gmail.com There is fix introduced by http://trac.webkit.org/r61433 in QWebPage::javaScriptConsoleMessage to handle the derived class destruction situation(only for DRT run). Once https://bugs.webkit.org/show_bug.cgi?id=119654 is landed we are free from that issue & we can remove the fix. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:26:35 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:26:35 -0700 Subject: [Webkit-unassigned] [Bug 119791] [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433) In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119791 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |119654 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:26:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:26:36 -0700 Subject: [Webkit-unassigned] [Bug 119654] [Qt] Avoid calling QWebPage's virtual functions during deletion of QWebPage In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119654 Arunprasad Rajkumar changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |119791 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:26:53 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:26:53 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208711| |review?, commit-queue? Flag| | --- Comment #1 from Benjamin Dupont 2013-08-14 03:26:27 PST --- Created an attachment (id=208711) --> (https://bugs.webkit.org/attachment.cgi?id=208711&action=review) Implement the needed API and remove Page Visibility API test from Qt TestExpectations file. Tests results: fast/events/page-visibility-iframe-delete-test.html: This test checks that the page visibility event propagation does not crash the browser when frames are added / deleted. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". Loaded all frames. Visibility of main document changed. Visibility of sub frame 2 changed. PASS successfullyParsed is true TEST COMPLETE fast/events/page-visibility-iframe-move-test.html: Content-Type: text/plain This test checks that an iframe that moves between pages with different visibility will have the correct visibility value. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". Window 1 Loaded Window 2 Loaded PASS window.document.hidden is false PASS window2.document.hidden is false PASS iframe.contentDocument.hidden is false PASS window.document.hidden is true PASS window2.document.hidden is false PASS iframe.contentDocument.hidden is false Adopted iframe to Window 1 PASS window.document.hidden is true PASS window2.document.hidden is false PASS iframe.contentDocument.hidden is true PASS successfullyParsed is true TEST COMPLETE fast/events/page-visibility-iframe-propagation-test.html: This test checks that Page Visibility state events are propagated to child frames. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". Main Page: PASS document.visibilityState is "visible" PASS document.hidden is false Child Frame: PASS childFrame.contentDocument.visibilityState is "visible" PASS childFrame.contentDocument.hidden is false Main Page: PASS document.visibilityState is "hidden" PASS document.hidden is true Child Frame: PASS childFrame.contentDocument.visibilityState is "hidden" PASS childFrame.contentDocument.hidden is true Main Page: PASS document.visibilityState is "visible" PASS document.hidden is false Child Frame: PASS childFrame.contentDocument.visibilityState is "visible" PASS childFrame.contentDocument.hidden is false PASS successfullyParsed is true TEST COMPLETE fast/events/page-visibility-null-view.html: This test checks that Page Visibility state values are correct when a document has no defaultView. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS subdocument.defaultView == null is true PASS subdocument.visibilityState is "hidden" PASS subdocument.hidden is true PASS successfullyParsed is true TEST COMPLETE fast/events/page-visibility-transition-test.html: This test checks that Page Visibility state values are correct and the event changes are fired correctly. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS document.visibilityState is "visible" PASS document.hidden is false PASS document.visibilityState is "hidden" PASS document.hidden is true PASS document.visibilityState is "hidden" PASS document.hidden is true PASS document.visibilityState is "prerender" PASS document.hidden is true PASS document.visibilityState is "visible" PASS document.hidden is false PASS document.visibilityState is "unloaded" PASS document.hidden is true PASS document.visibilityState is "visible" PASS document.hidden is false PASS successfullyParsed is true TEST COMPLETE fast/frames/page-visibility-crash.html: PASS. WebKit didn't crash -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:27:31 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:27:31 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[Qt] Activate visibility |[Qt] Activate Page |API layout tests |Visibility API layout tests -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:27:54 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:27:54 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdupont at nds.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:34:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:34:57 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208711|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #2 from Allan Sandfeld Jensen 2013-08-14 03:34:31 PST --- (From update of attachment 208711) LGTM -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:36:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:36:57 -0700 Subject: [Webkit-unassigned] [Bug 119792] New: [Qt] fast/canvas/canvas-blending-transforms.html test fails on x32 after r153941. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119792 Summary: [Qt] fast/canvas/canvas-blending-transforms.html test fails on x32 after r153941. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abrhm at inf.u-szeged.hu CC: allan.jensen at digia.com, ossy at webkit.org, zarvai at inf.u-szeged.hu, kadam at inf.u-szeged.hu Created an attachment (id=208712) --> (https://bugs.webkit.org/attachment.cgi?id=208712&action=review) diff After r153941 this test fails on all Qt x32 bots. Probably it isn't because of the implemention of basic support for the blend-modes. Maybe this can be because of the FTL merge or can be related to https://bugs.webkit.org/show_bug.cgi?id=114913. I will skip this test to paint the bots green. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:37:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:37:01 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 WebKit Commit Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |commit-queue at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:39:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:39:09 -0700 Subject: [Webkit-unassigned] [Bug 118306] [WTR] Should dump as text when the mimetype is text/plain In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=118306 Christophe Dumez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208709|review?, commit-queue? |review+, commit-queue- Flag| | --- Comment #36 from Christophe Dumez 2013-08-14 03:38:43 PST --- (From update of attachment 208709) View in context: https://bugs.webkit.org/attachment.cgi?id=208709&action=review Looks fine. r=me with nits. > LayoutTests/ChangeLog:9 > + Now the result should match the expected. expected -> "expectation" > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:853 > + WKRetainPtr mimeType= adoptWK(WKBundleFrameCopyMIMETypeForResourceWithURL(frame, urlRef.get())); nit: missing space before equal -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:48:03 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:48:03 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208711|commit-queue+ |commit-queue- Flag| | --- Comment #3 from Benjamin Dupont 2013-08-14 03:47:37 PST --- (From update of attachment 208711) Must change QString... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:52:46 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:52:46 -0700 Subject: [Webkit-unassigned] [Bug 119793] New: lists break navbar in twitter bootstrap Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119793 Summary: lists break navbar in twitter bootstrap Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: d.ruf at cortona.de 1. go to http://fiddle.jshell.net/43hLC/1/show/ 2. klick in the navbar at the top around (download, about, bands, features) 3. when you click features sometimes it looks like this: https://f.cloud.github.com/assets/827205/930607/777e7860-0010-11e3-926d-fc5da103c71f.png 4. delete the 2 lists in features and it seems the problem is fixed the 2 lists in features break the navbar at the top -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:53:26 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:53:26 -0700 Subject: [Webkit-unassigned] [Bug 119793] lists break navbar in twitter bootstrap In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119793 d.ruf at cortona.de changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://fiddle.jshell.net/43 | |hLC/1/show/ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:53:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:53:36 -0700 Subject: [Webkit-unassigned] [Bug 119793] lists break navbar in twitter bootstrap In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119793 d.ruf at cortona.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |d.ruf at cortona.de -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:56:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:56:43 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208711|0 |1 is obsolete| | Attachment #208713| |review?, commit-queue? Flag| | --- Comment #4 from Benjamin Dupont 2013-08-14 03:56:17 PST --- Created an attachment (id=208713) --> (https://bugs.webkit.org/attachment.cgi?id=208713&action=review) Implement the needed API and remove Page Visibility API test from Qt TestExpectations file. (2) Use QLatin1String instead of QString. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 03:58:11 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 03:58:11 -0700 Subject: [Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119515 --- Comment #14 from Przemyslaw Szymanski 2013-08-14 03:57:45 PST --- Dean Jackson, could you do a final review for this patch? Thank you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 04:24:04 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 04:24:04 -0700 Subject: [Webkit-unassigned] [Bug 119764] srcset: Respect updates to display density In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119764 Dean Jackson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com, | |webkit-bug-importer at group.a | |pple.com --- Comment #1 from Dean Jackson 2013-08-14 04:23:38 PST --- Yeah, -image-set suffers equally. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 04:24:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 04:24:40 -0700 Subject: [Webkit-unassigned] [Bug 119764] srcset: Respect updates to display density In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119764 Radar WebKit Bug Importer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #2 from Radar WebKit Bug Importer 2013-08-14 04:24:14 PST --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 04:28:36 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 04:28:36 -0700 Subject: [Webkit-unassigned] [Bug 117735] [curl] Improve multipart response handling In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117735 --- Comment #10 from Christophe Dumez 2013-08-14 04:28:11 PST --- (From update of attachment 208710) View in context: https://bugs.webkit.org/attachment.cgi?id=208710&action=review > Source/WebCore/platform/network/curl/MultipartHandle.cpp:63 > + boundaryEnd = contentType.find(";", boundaryStart); ';' > Source/WebCore/platform/network/curl/MultipartHandle.cpp:77 > +bool MultipartHandle::matchForBoundary(const char* data, size_t pos, size_t& matchedLength) We don't use abbreviations in WebKit: pos -> position > Source/WebCore/platform/network/curl/MultipartHandle.cpp:82 > + if (data[pos + i] != m_boundary[i]) { how do we know data[pos + i] does not go out of bounds? > Source/WebCore/platform/network/curl/MultipartHandle.cpp:92 > +bool MultipartHandle::checkForBoundary(size_t& boundaryStartPos, size_t& lastPartialMatchPos) "Pos" -> "Position' > Source/WebCore/platform/network/curl/MultipartHandle.cpp:99 > + lastPartialMatchPos = contentLength; Ditto. > Source/WebCore/platform/network/curl/MultipartHandle.cpp:117 > + const char* content = m_buffer.data(); This can be moved after the if check for contentLength. > Source/WebCore/platform/network/curl/MultipartHandle.cpp:135 > + char* end = const_cast(content) + contentLength; Cannot this one be const? > Source/WebCore/platform/network/curl/MultipartHandle.cpp:249 > + if (!m_buffer.size()) m_buffer.isEmpty() > Source/WebCore/platform/network/curl/MultipartHandle.h:77 > + Vector m_buffer; Considering the operations you are doing (append and remove from beginning), a Vector may not be the best data structure. You might want to take a look at StreamBuffer (or Deque) > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:406 > + d->m_multipartHandle = adoptPtr(new MultipartHandle(job, boundary)); We usually use static factory functions such as PassOwnPtr MultipartHandle::create() for such cases so that we never deal with raw pointers externally. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 04:30:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 04:30:01 -0700 Subject: [Webkit-unassigned] [Bug 119088] [Qt] Crash in SimpleFontData, related to @font-face with non-existing src url In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119088 Allan Sandfeld Jensen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE --- Comment #16 from Allan Sandfeld Jensen 2013-08-14 04:29:36 PST --- *** This bug has been marked as a duplicate of bug 119740 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 04:30:40 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 04:30:40 -0700 Subject: [Webkit-unassigned] [Bug 119088] [Qt] Crash in SimpleFontData, related to @font-face with non-existing src url In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119088 --- Comment #17 from Allan Sandfeld Jensen 2013-08-14 04:30:15 PST --- (In reply to comment #15) > https://codereview.qt-project.org/#change,62910 fixes the issue for me. Can you test if the new patch in bug 118532 also works without crashing? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 04:55:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 04:55:44 -0700 Subject: [Webkit-unassigned] [Bug 119794] New: [DFG] isDouble(edge.useKind()) assertion fail Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119794 Summary: [DFG] isDouble(edge.useKind()) assertion fail Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jbrianceau at nds.com On 32-bit sh4 and mips debug build, many SunSpider 1.0 JSC tests fail: ASSERTION FAILED: mode == ManualOperandSpeculation || isDouble(edge.useKind()) /local/jbriance/webkit-mips/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h(2694) : JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand(JSC::DFG::SpeculativeJIT*, JSC::DFG::Edge, JSC::DFG::OperandSpeculationMode) FATAL ERROR: CRASH() called. Backtrace looks always the same. For instance, on my sh4 board: (gdb) bt #0 0x00000000 in ?? () #1 0x00a77d8a in WTFCrash () at /local/jbriance/webkit-dfg-sh4Source/WTF/wtf/Assertions.cpp:347 #2 0x00761eba in SpeculateDoubleOperand (this=0x7bec23d8, jit=0xedcb18, edge=..., mode=JSC::DFG::AutomaticOperandSpeculation) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:2703 #3 0x0073f08a in JSC::DFG::SpeculativeJIT::compileDoubleAsInt32 (this=0xedcb18, node=0x2bc31814) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2456 #4 0x0078d9e2 in JSC::DFG::SpeculativeJIT::compile (this=0xedcb18, node=0x2bc31814) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:2214 #5 0x0073ac68 in JSC::DFG::SpeculativeJIT::compileCurrentBlock (this=0xedcb18) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1804 #6 0x0073b538 in JSC::DFG::SpeculativeJIT::compile (this=0xedcb18) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1918 #7 0x006c7944 in JSC::DFG::JITCompiler::compileBody (this=0x7bec4778) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:117 #8 0x006c9ea0 in JSC::DFG::JITCompiler::compileFunction (this=0x7bec4778) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:382 #9 0x00716950 in JSC::DFG::Plan::compileInThreadImpl (this=0xee3e28, longLivedState=...) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/dfg/DFGPlan.cpp:256 #10 0x007161ee in JSC::DFG::Plan::compileInThread (this=0xee3e28, longLivedState=...) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/dfg/DFGPlan.cpp:113 #11 0x0069ba26 in compile (compileMode=JSC::DFG::CompileFunction, exec=0x2b62b130, codeBlock=0xee3670, jitCode=..., jitCodeWithArityCheck=0x2bbffacc, osrEntryBytecodeIndex=89) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/dfg/DFGDriver.cpp:127 #12 0x0069bba4 in JSC::DFG::tryCompileFunction (exec=0x2b62b130, codeBlock=0xee3670, jitCode=..., jitCodeWithArityCheck=..., bytecodeIndex=89) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/dfg/DFGDriver.cpp:138 #13 0x0095b1c4 in JSC::jitCompileFunctionIfAppropriateImpl (exec=0x2b62b130, codeBlock=0xee3670, jitCode=..., jitCodeWithArityCheck=..., jitType=JSC::JITCode::DFGJIT, bytecodeIndex=89, effort=JSC::JITCompilationCanFail) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/jit/JITDriver.h:98 #14 0x0095b620 in JSC::prepareFunctionForExecutionImpl (exec=0x2b62b130, codeBlock=0xee3670, jitCode=..., jitCodeWithArityCheck=..., jitType=JSC::JITCode::DFGJIT, bytecodeIndex=89, kind=JSC::CodeForCall) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/runtime/ExecutionHarness.h:84 #15 0x0095b6c2 in JSC::prepareFunctionForExecution (exec=0x2b62b130, sink=..., codeBlock=0xee3670, jitCode=..., jitCodeWithArityCheck=..., numParameters=@0x2bbffab4, jitType=JSC::JITCode::DFGJIT, bytecodeIndex=89, kind=JSC::CodeForCall) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/runtime/ExecutionHarness.h:138 #16 0x00958c0c in JSC::FunctionExecutable::compileForCallInternal (this=0x2bbffab0, exec=0x2b62b130, scope=0x2ba7fc38, jitType=JSC::JITCode::DFGJIT, result=0x7bec5004, bytecodeIndex=89) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/runtime/Executable.cpp:561 #17 0x009581ec in JSC::FunctionExecutable::compileOptimizedForCall (this=0x2bbffab0, exec=0x2b62b130, scope=0x2ba7fc38, result=@0x7bec5004, bytecodeIndex=89) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/runtime/Executable.cpp:480 #18 0x004c7716 in JSC::FunctionExecutable::compileOptimizedFor (this=0x2bbffab0, exec=0x2b62b130, scope=0x2ba7fc38, result=@0x7bec5004, bytecodeIndex=89, kind=JSC::CodeForCall) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/runtime/Executable.h:691 #19 0x004be7ee in JSC::FunctionCodeBlock::compileOptimized (this=0xedeb30, exec=0x2b62b130, scope=0x2ba7fc38, result=@0x7bec5004, bytecodeIndex=89) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/bytecode/CodeBlock.cpp:2744 #20 0x00840b64 in JITStubThunked_optimize (args=0x7bec5060) at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/jit/JITStubs.cpp:1046 #21 0x008404bc in cti_optimize () at /local/jbriance/webkit-dfg-sh4Source/JavaScriptCore/jit/JITStubs.cpp:888 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 04:58:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 04:58:47 -0700 Subject: [Webkit-unassigned] [Bug 119794] [DFG] isDouble(edge.useKind()) assertion fail In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119794 --- Comment #1 from Julien Brianceau 2013-08-14 04:58:22 PST --- I think the problem is not seen on X86 32-bit, X86 64-bit and Apple ARMv7S because of the following code in DFGFixupPhase.cpp: case ArithMod: { if (Node::shouldSpeculateIntegerForArithmetic(node->child1().node(), node->child2().node()) && node->canSpeculateInteger()) { if (isX86() || isARMv7s()) { setUseKindAndUnboxIfProfitable(node->child1()); setUseKindAndUnboxIfProfitable(node->child2()); break; } -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:16:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:16:09 -0700 Subject: [Webkit-unassigned] [Bug 119794] [DFG] isDouble(edge.useKind()) assertion fail In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119794 --- Comment #2 from Julien Brianceau 2013-08-14 05:15:44 PST --- Created an attachment (id=208715) --> (https://bugs.webkit.org/attachment.cgi?id=208715&action=review) isDouble() and isNumerical() should return true with KnownNumberUse UseKind. This patch solves the issue for sh4 & mips, but as I'm clearly not an expert of this area in DFG, I'd like someone confirms this is the right way to fix this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:17:44 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:17:44 -0700 Subject: [Webkit-unassigned] [Bug 119794] [DFG] isDouble(edge.useKind()) assertion fail In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119794 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208715| |review?, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:17:49 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:17:49 -0700 Subject: [Webkit-unassigned] [Bug 119794] [DFG] isDouble(edge.useKind()) assertion fail In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119794 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kilvadyb at homejinni.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:17:55 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:17:55 -0700 Subject: [Webkit-unassigned] [Bug 119794] [DFG] isDouble(edge.useKind()) assertion fail In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119794 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msaboff at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:18:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:18:01 -0700 Subject: [Webkit-unassigned] [Bug 119794] [DFG] isDouble(edge.useKind()) assertion fail In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119794 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ggaren at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:18:09 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:18:09 -0700 Subject: [Webkit-unassigned] [Bug 119794] [DFG] isDouble(edge.useKind()) assertion fail In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119794 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:18:15 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:18:15 -0700 Subject: [Webkit-unassigned] [Bug 119794] [DFG] isDouble(edge.useKind()) assertion fail In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119794 Julien Brianceau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fpizlo at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:25:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:25:27 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208713|0 |1 is obsolete| | Attachment #208713|review?, commit-queue? | Flag| | Attachment #208717| |review?, commit-queue? Flag| | --- Comment #5 from Benjamin Dupont 2013-08-14 05:25:01 PST --- Created an attachment (id=208717) --> (https://bugs.webkit.org/attachment.cgi?id=208717&action=review) Implement the needed API and remove Page Visibility API test from Qt TestExpectations file. (3) QStringLiteral is the fastest with C++11. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:31:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:31:01 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 Qt Early Warning System Bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |webkit-ews at sed.inf.u-szeged | |.hu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:31:05 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:31:05 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 Qt Early Warning System Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208717|commit-queue? |commit-queue- Flag| | --- Comment #6 from Qt Early Warning System Bot 2013-08-14 05:30:39 PST --- (From update of attachment 208717) Attachment 208717 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1451815 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:31:52 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:31:52 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 --- Comment #7 from Qt Early Warning System Bot 2013-08-14 05:31:26 PST --- (From update of attachment 208717) Attachment 208717 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1458707 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:37:01 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:37:01 -0700 Subject: [Webkit-unassigned] [Bug 119614] [CSS Masking] Add -webkit-mask-source-type property, with alpha and luminance values In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119614 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208597|review? |review- Flag| | --- Comment #8 from Dirk Schulze 2013-08-14 05:36:35 PST --- (From update of attachment 208597) View in context: https://bugs.webkit.org/attachment.cgi?id=208597&action=review Great progress. Some more snippets. > Source/WebCore/ChangeLog:6 > + Added the -webkit-mask-type property, which can have a value of auto, alpha or mask-source-type. > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1436 > + default: > + return cssValuePool().createValue(CSSValueAuto); > + } Usually we have ASSERT_NOT_REACHED in the default. To make sure we do not support more than expected. > Source/WebCore/css/CSSToStyleMap.cpp:323 > + default: > + type = EMaskSourceType::MaskAuto; > + } Ditto. And still set type of course (to initial value: auto). > Source/WebCore/rendering/style/FillLayer.h:191 > + static EMaskSourceType initialMaskSourceType(EFillLayerType) { return MaskAuto; } The spec says that mask-image has alpha as default. So even if we need to support auto for SVG Masks, we already know that it will be alpha for FillLayers. No need to store auto or return auto. Will affect computed value as well. > LayoutTests/fast/masking/parsing-mask-expected.txt:118 > +PASS innerStyle("-webkit-mask-source-type", "") is null Test for existing but not supported keywords would be great as well. > LayoutTests/fast/masking/parsing-mask.html:177 > +negativeTest("-webkit-mask-source-type", ""); Ditto. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:49:57 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:49:57 -0700 Subject: [Webkit-unassigned] [Bug 119796] New: [Qt] REGRESSION(FTL) 2 sputnik/Conformance/08_Types/8.5_The_Number_Type/ test failing on x86. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119796 Summary: [Qt] REGRESSION(FTL) 2 sputnik/Conformance/08_Types/8.5_The_Number_Type/ test failing on x86. Product: WebKit Version: 528+ (Nightly build) Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abrhm at inf.u-szeged.hu CC: oliver at apple.com, ossy at webkit.org, zarvai at inf.u-szeged.hu, kadam at inf.u-szeged.hu After the FTL merge 2 sputnik test failing on Qt x86 bots. sputnik/Conformance/08_Types/8.5_The_Number_Type/S8.5_A2.1.html sputnik/Conformance/08_Types/8.5_The_Number_Type/S8.5_A2.2.html Link: http://build.webkit.org/results/Qt%20Linux%20Release/r154045%20(62089)/results.html diff2.1: S8.5_A2.1 PASS FAIL SputnikError: #1: var x = 9007199254740994.0; var y = 1.0 - 1/65536.0; var z = x + y; var d = z - x; d === 0. Actual: 2 TEST COMPLETE diff2.2: S8.5_A2.2 PASS FAIL SputnikError: #1: var x = 9007199254740994.0; var y = 1.0 - 1/65536.0; var z = x + y; var d = z - x; d !== 2 TEST COMPLETE I think this fails caused by the FTL merge, but maybe other patch cause it. Could you take a look please? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 05:54:27 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 05:54:27 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208651|0 |1 is obsolete| | Attachment #208720| |review? Flag| | --- Comment #21 from Antti Koivisto 2013-08-14 05:54:00 PST --- Created an attachment (id=208720) --> (https://bugs.webkit.org/attachment.cgi?id=208720&action=review) more -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 06:14:47 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 06:14:47 -0700 Subject: [Webkit-unassigned] [Bug 119788] [CMake] Fix building with bison-3.0. In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119788 Zoltan Herczeg changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208708|review?, commit-queue? |review+, commit-queue+ Flag| | --- Comment #2 from Zoltan Herczeg 2013-08-14 06:14:21 PST --- (From update of attachment 208708) rs=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 06:15:12 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 06:15:12 -0700 Subject: [Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119790 Benjamin Dupont changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208717|0 |1 is obsolete| | Attachment #208717|review? | Flag| | Attachment #208721| |review?, commit-queue? Flag| | --- Comment #8 from Benjamin Dupont 2013-08-14 06:14:45 PST --- Created an attachment (id=208721) --> (https://bugs.webkit.org/attachment.cgi?id=208721&action=review) Implement the needed API and remove Page Visibility API test from Qt TestExpectations file. (4) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 06:49:43 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 06:49:43 -0700 Subject: [Webkit-unassigned] [Bug 119698] Remove Node::attach() and ContainerNode::attach() In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=119698 Andreas Kling changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208720|review? |review+ Flag| | --- Comment #22 from Andreas Kling 2013-08-14 06:49:17 PST --- (From update of attachment 208720) r=me, this is very cool. Like I mentioned on IRC, I think we can micro-optimize some things here but now is hardly the time. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 14 06:59:30 2013 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 14 Aug 2013 06:59:30 -0700 Subject: [Webkit-unassigned] [Bug 117008] [WK2][GTK] add new methods on WebKitSettings to enable/disable subtitles In-Reply-To: References: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=117008 --- Comment #6 from Danilo Cesar Lemes de Paula 2013-08-14 06:59:03 PST --- The goal of this patch changed to "Adding support to