[Webkit-unassigned] [Bug 115448] ipc-posix-shm backwards compatibility
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 30 22:28:23 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=115448
Alexey Proskuryakov <ap at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #200194|review?, commit-queue? |review+, commit-queue+
Flag| |
--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> 2013-04-30 22:26:46 PST ---
(From update of attachment 200194)
View in context: https://bugs.webkit.org/attachment.cgi?id=200194&action=review
r=me
> Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:250
> +(if (not (defined? 'ipc-posix-shm*))
> + (define ipc-posix-shm* ipc-posix-shm))
I wish we pre-processed plug-in sandbox profile files, so that we could do conditional compilation. With an #if check, removing obsolete code is much more straightforward.
Also, we wouldn't have to merge parts at runtime, as we could simply #include "com.apple.WebKit.plugin-common.sb", and let preprocessor build a complete profile.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list