[Webkit-unassigned] [Bug 115397] [ARM] REGRESSION(r149349): It broke Octane/Crypto

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115397


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #200089|review+, commit-queue+      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Filip Pizlo <fpizlo at apple.com>  2013-04-30 12:52:15 PST ---
(From update of attachment 200089)
Yeah, I think this is still wrong.  GPRResult is for forcing the return register to be live across a call to flushRegisters(), when you're making an unconditional call that clobbers all registers.  It looks like you're doing an unconditional register-clobbering call if !supportsIntegerDiv().  So, this will still break things.  I think you need to use GPRResult if !supportsIntegerDiv() and GPRTemporary otherwise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.