[Webkit-unassigned] [Bug 113276] [CSSRegions] Implement offsetParent for elements inside named flow

Tue Apr 30 09:02:46 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=113276

--- Comment #7 from Mihnea Ovidenie <mihnea at adobe.com>  2013-04-30 09:01:08 PST ---
(From update of attachment 200117)
View in context: https://bugs.webkit.org/attachment.cgi?id=200117&action=review

> LayoutTests/fast/regions/offsetParent-in-flow-thread.html:6
>      <body>

I would like to see more tests for this, not only for the elements that are at the flow thread boundary, but also for other elements inside the flow thread that do not reach the flow thread boundary.
Also, what happens if you collect the body element of a document in a flow thread and then you call offsetParent on that element, and offsetParent for other elements for such case.

> Source/WebCore/ChangeLog:12
> +        end up calling curr->parent()->offsetForColumns(referencePoint) while curr->parent() was returning NULL.

It is not very clear to me - from your description - why you reached that. I suspect you were climbing up the RenderObject tree until you reached 0 for a curr object but you should not get there in the algorithm, you should probably stop the traversal sooner.

> Source/WebCore/rendering/RenderObject.cpp:3001
> +            return (document ? document->body() : 0);

When is document null? Also, as a preference, instead of returning from this loop, i would set node = document->body() and the loop will exit when will hit node->hasTagName(HTMLNames::bodyTag) condition.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.