[Webkit-unassigned] [Bug 108347] CSS3 'word-break: break-all' spoils CJK line-break restrictions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108347





--- Comment #29 from Lu jing <dujid0 at gmail.com>  2013-04-30 08:30:00 PST ---
(In reply to comment #28)
> (From update of attachment 199990 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=199990&action=review
> 
> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2750
> > +}
> 
> this is not consistent with the definition of break-all found in http://dev.w3.org/csswg/css-text/#word-break; in particular, the spec says that break all applies between any two 'letters', except where forbidden by line-break settings; since the spec defines 'letter' as "a character belonging to one of the Letter or Number general categories in Unicode", it is more than simply ASCII letters/digits;
> 
> accordingly, this patch should be r- (i'm not a reviewer, otherwise I would mark r-)

Thank you for review patch. CJK and other Unicode letters will be broken properly by this patch, Unicode letters checked by original line-break code and ICU. (I just fixed break-all, for the CJK letters there is same logic in break-normal mode.) 

> 
> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:3040
> > +            UChar previousCharacterInIteration = 0;
> 
> use lastCharacter instead of previousCharacterInIteration.
> 
> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:3068
> > +                    //             can be broken by isBreakableAllLetter function
> 
> remove comment, since it is already described in change long; also this comment doesn't follow comment conventions anyway

Ok. I will remove this.

> 
> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:3072
> > +                               && isBreakableAllLetter(previousCharacterInIteration)));
> 
> use lastCharacter instead of previousCharacterInIteration
Ok

> 
> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:3074
> > +                previousCharacterInIteration = c;
> 
> ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.