[Webkit-unassigned] [Bug 115364] [SOUP] Move default buffer handling from ResourceHandleClient to ResourceHandleSoup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115364





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-04-29 12:54:51 PST ---
(From update of attachment 200029)
View in context: https://bugs.webkit.org/attachment.cgi?id=200029&action=review

This is a really good change! I have just a couple small questions.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:56
> -        virtual char* getBuffer(int, int*);
> +        virtual char* getOrCreateReadBuffer(size_t requestedSize, size_t& actualSize);

I wonder if this should return a PassRefPtr<SharedBuffer> which would make it more similar to the rest of the networking code and allow for removing the actualSize argument.

Another small comment is that you probably want this to be called createBuffer. It seems that the ResourceHandle is always responsible for freeing the buffer (unless I have misread this patch), so this method is essentially a constructor since it passes ownership. That's another reason why I suggested a return value wrapped in PassRefPtr above. If we had a PassGOwnPtr it would make sense here. In fact, this reminds me to investigate removing GOwnPtr completely again. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.