[Webkit-unassigned] [Bug 52185] Cell heights are disproportional when a row-spanning cell contains a block element that determines the height of the rows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52185





--- Comment #6 from Suchit Agrawal <a.suchit at samsung.com>  2013-04-29 09:39:09 PST ---
(In reply to comment #3)
> Created an attachment (id=200020)
 --> (https://bugs.webkit.org/attachment.cgi?id=200020&action=review) [details]
> Patch

Cells heights are not proper when rowspan cell have its own height which is more then the height of the rows under rowspan. After calculating the logical height, we need to recalculate height of rows under rowspan.

After calculating logical height of the rows in the table, we are recalculating the height of the rows those are under rowspan. Based on the ratio of row's logical height, we are distributing rowspan cell height in the rows under rowspan.

We are storing all cell which have rowspan and then we are rearraging them in the order in which we need to calculate the height.
First rowspan cell in the table processed first but if any nested rowspan cell present then it will be calculated first. If 2 or more rowspan cell have same start index and end index then only one rowspan cell will be processed which would have highest height.
After sorting them in the order, we are processing one by one rowspan cell :
1. We takes the heights of rows in rowspan.
2. if any row contains only rowspan cells then height of that row will be zero then in this case, we are taking one part of the rowspan cell height.
3. Based on the ratio, we calculate new height of the rows if rowspan height is more then total rows height in the rowspan.

Beth,
some time back, we had submiited the patch for bug 18092, that code is removed because that code logic is moved down for fixing this bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.