[Webkit-unassigned] [Bug 80712] [CSS Regions] Convert some fast/regions pixel tests to reftests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80712


Alexandru Chiculita <achicu at adobe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #200005|review?                     |review-
               Flag|                            |




--- Comment #3 from Alexandru Chiculita <achicu at adobe.com>  2013-04-29 09:24:08 PST ---
(From update of attachment 200005)
View in context: https://bugs.webkit.org/attachment.cgi?id=200005&action=review

Thanks, looks good! I have a couple of hints below. The comments apply for both html files.

> LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html:5
> +    	text-align: justify;

nit: you have different indentation styles in the style elements.

> LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html:87
> +        margin-top: -22px;

<p> tags have margin-top/bottom set using "em" units.  I think you could avoid using <p> tags or set the margins to 0 to avoid having to compensate for it in the parent box. Setting the margin this way makes the ref-test fragile when changing the default font-size.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.