[Webkit-unassigned] [Bug 115256] Use the complete block as the context for Dictionary lookups

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115256





--- Comment #5 from Thomas Deniau <deniau at apple.com>  2013-04-26 12:35:54 PST ---
(From update of attachment 199826)
View in context: https://bugs.webkit.org/attachment.cgi?id=199826&action=review

>> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:510
>> +    // A "paragraph" is not enough as it may stop at a <br> and Lookup sometimes needs several lines of context.
> 
> If paragraph isn’t good enough, then block is probably not good enough either.
> You realize that we can have each paragraph being isolated by a div, right?

I do. This is of course best-effort and there's no solution that can work with all the web pages out there. My take is that a good Web author will put any related information (that Lookup cares about) in the same block. If that doesn't work, Lookup will do its best given the partial context. The user can select text manually if that's not enough...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.