[Webkit-unassigned] [Bug 114897] [EFL] Add unit test cases for ewk_settings APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114897





--- Comment #15 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-04-25 22:50:23 PST ---
(From update of attachment 199778)
View in context: https://bugs.webkit.org/attachment.cgi?id=199778&action=review

> Source/WebKit/efl/tests/test_ewk_setting.cpp:55
> +    strncpy(defaultPath, getenv("HOME"), sizeof(defaultPath));   

How about below case ?

 char* homePath = getenv("HOME");
 char* defaultPath = reinterpret_cast<char*>(malloc(strlen(homePath) + strlen("/.cache/WebKitEfl/Databases") + 1));
 strncpy(defaultPath, homePath, strlen(homePath) + 1);

> Source/WebKit/efl/tests/test_ewk_setting.cpp:82
> +    strncpy(defaultPath, getenv("HOME"), sizeof(defaultPath));   

ditto ?

> Source/WebKit/efl/tests/test_ewk_setting.cpp:112
> +    strncpy(defaultPath, getenv("HOME"), sizeof(defaultPath));   

ditto ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.