[Webkit-unassigned] [Bug 108425] [Qt] Adjust the way of determining whether build-webkit needs full incremental build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108425





--- Comment #7 from Tor Arne Vestbø <vestbo at webkit.org>  2013-04-25 07:32:45 PST ---
The terminology in the script is a bit off, but we have three levels:

 - clean
 - 'safe' incremental (make qmake_all && make)
 - 'regular' incremental (rely on make's dependency tracking)

You're right that we shouldn't do repeated clean builds. This patch was trying to skip the 'safe' incremental step before actually producing a working build, which is going to break builds.

I think one way to fix the repeated clean builds is to check for buildbot in the "elsif ($maybeNeedsCleanBuild)" block, and only wipe and re-make if we're on a build bot. Otherwise we can instruct the user to run make wipeclean manually.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.