[Webkit-unassigned] [Bug 108425] [Qt] Adjust the way of determining whether build-webkit needs full incremental build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108425





--- Comment #5 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2013-04-25 02:08:48 PST ---
(In reply to comment #4)
> (From update of attachment 199569 [details])
> The whole point is to ensure that we have a successful build before adding to BUILTREVISIONS. Why do you think the "second full incremental build is unnecessary"? What if 'make qmake_all' fails to generate a project file, or generating sources fails? Will we still end up running qmake for the whole project, even with -j1?

The bug is real and annoying:
- Build successfully svn rev 12345
- git pull --rebase (to svn rev 12346)
- Merge conflicts, make some mistakes that would make the build fail
- build-webkit -> some .pro file change detected -> full build -> fails
- Fix mistakes
- build-webkit -> same .pro file change detected again -> full build again!!
And this goes on until you're able to fix the build with full builds between all tries.

This is actually caused by the side effect where maybeNeedsCleanBuild is set to 1. Since the build fails, we do a clean build every time.
So it's not the "second incremental build" that is unnecessary, it's the second full rebuild because the first one failed and maybeNeedsCleanBuild was set.

I wasn't following the difference quite well the first time, so I think you're right and the fix is wrong. But we still have to make sure that maybeNeedsCleanBuild isn't set the second time, or maybe just set it if on the buildbot.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.