[Webkit-unassigned] [Bug 95178] Support CSS3 Keyboard control

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95178





--- Comment #14 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-04-24 22:29:46 PST ---
(From update of attachment 199152)
View in context: https://bugs.webkit.org/attachment.cgi?id=199152&action=review

> ChangeLog:8
> +        Add support for CSS3 Keyboard control http://dev.w3.org/csswg/css3-ui/#keyboard.

I'm wondering if you notify webkit-dev of this feature. According to webkit policy, new feature should be notified to webkit-dev first.

> Source/WebCore/GNUmakefile.list.am:4722
> +	Source/WebCore/rendering/style/StyleNavData.cpp \

I think this file needs to be added to CMake files as well in order to support EFL, blackberry and wince ports. Besides it looks you need to add this file to xcode for Mac.

> Source/WebCore/rendering/style/StyleNavData.cpp:2
> + * Copyright (C) 2013 Sangho Kim (thomas.kim at lge.com)

If contributor belongs to company, contributor has added a company copyright generally.

> Source/WebKit2/Shared/WebPreferencesStore.h:39
> +#if PLATFORM(GTK) || PLATFORM(QT)

There is no WK2 ChangeLog update for this file. As Ryosuke said, please use Tools/Script/prepare-ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.