[Webkit-unassigned] [Bug 115118] [GTK] Use stamp files for generate-forwarding-headers makefile rules

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115118





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-04-24 11:18:52 PST ---
(In reply to comment #2)
> (From update of attachment 199499 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=199499&action=review
> 
> Looks good. I just have one question...
> 
> > Source/WebKit2/GNUmakefile.am:326
> >  BUILT_SOURCES += generate-webkit2-forwarding-headers
> 
> Would it make more sense to add the stamp files to BUILT_SOURCES now?

hmm, I think you are right, and we don't need to add them to cleanfiles either since all built source are already in cleanfiles. Let me try.

> > Tools/TestWebKitAPI/GNUmakefile.am:229
> > +wk2_tests_sources = $(Programs_TestWebKitAPI_TestWebKit2_SOURCES) $(Libraries_libTestWebKitAPIInjectedBundle_la_SOURCES)
> 
> I don't think there's any need for this intermediate variable, unless it's used somewhere else.

It makes the rule easier to read, that's all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.