[Webkit-unassigned] [Bug 112913] [ATK] [WebKit2] AccessibilityUIElement often leaks it's AtkObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112913





--- Comment #2 from Mario Sanchez Prada <mario at webkit.org>  2013-04-24 03:55:03 PST ---
(From update of attachment 199409)
View in context: https://bugs.webkit.org/attachment.cgi?id=199409&action=review

Looks good to me, I just made a couple of minor suggestions.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:423
> +    if (target)
> +        g_object_ref(target);
>      return target ? AccessibilityUIElement::create(target) : 0;

You can merge that g_object_ref call into the return line:

return target ? AccessibilityUIElement::create(g_object_ref(target)) : 0;

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:434
> +    if (parent)
> +        g_object_ref(parent);
>      return parent ? AccessibilityUIElement::create(parent) : 0;

Same here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.