[Webkit-unassigned] [Bug 115022] [SH4] Misc bugfix and cleaning in sh4 base JIT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115022





--- Comment #5 from Mark Lam <mark.lam at apple.com>  2013-04-23 09:44:59 PST ---
(From update of attachment 199219)
View in context: https://bugs.webkit.org/attachment.cgi?id=199219&action=review

Overall, it looks good to me, but I don’t know how SH4 works.  Have you run any tests after these changes?  For example, "Tools/Scripts/run-javascriptcode-tests" and “Tools/Scripts/run-webkit-tests fast/js/ fast/regex/ ietestcenter/Javascript/ sputnik/“.

> Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:1920
> +                result = (cond == NonZero) ? false : true;

I’d suggest simplifying this to "result = (cond != NonZero);”.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.