[Webkit-unassigned] [Bug 112327] Reorganize image animation starting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112327





--- Comment #20 from Nandor Huszka <hnandor at inf.u-szeged.hu>  2013-04-22 10:30:20 PST ---
(In reply to comment #17)
> (In reply to comment #13)
> > I'm not sure I agree with this approach in general. It doesn't play nicely with threaded scrolling on Mac, for example; unless we test for restarting image animations while scrolling, we'll not see animated images when the threaded scrolling is happening.
> 
> I'm not familiar with threaded scrolling. Do you mean we should take care of image animations in layout tests after scrolling? Please describe this problem with more details.
> 
> If this approach is completely no-go, what do you think about the one that Antti mentioned, would that cooperates well with threaded scrolling?

A new idea: I have relocated methods that deal with image animation restarting to ImageAnimationController as Antti suggested. What if we combine this new class with the mentioned - tiled backing store knows image animations - approach.

This way BitmapImages won't animate themselves anymore, it will be TiledBackingStore's role. Besides TBS would cause the repaint of animated image if it is required (by invalidating their rect). Does it sound good (in terms of threaded scrolling)?

If you have an other concrete notion about the implementation, please specify it. Unfortunately I don't have too much time for doing this, so I would accept any kind of solution that can be implemented at full blast, then r+-ed. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.