[Webkit-unassigned] [Bug 114654] [GStreamer] Eclipse warnings in MediaPlayerPrivateGStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114654





--- Comment #18 from Zan Dobersek <zandobersek at gmail.com>  2013-04-22 03:32:31 PST ---
Reviving the discussion here in hope of resolving this problem.

(In reply to comment #8)
> (In reply to comment #7)
> > If including the <math.h> header isn't putting the isinf method inside std::, the <wtf/MathExtras.h> header (in Source/WTF/wtf/) should handle the OS-specific setup to do so and should then be included where necessary.
> 
> I could make it define these when --std=c++11 isn't set if that would be useful.
> 

Let's keep this as a backup plan. It makes sense though I'm not at the moment 100% sure it's the right approach.

Also, FWIW, the MediaPlayerPrivateGStreamer source code is at the moment not compiled with std=c++11.

> > To clarify, are we talking about the Eclipse IDE? What compiler is used? What version of it?
> 
> This is in the Eclipse IDE. Builds work fine (presumably --std=c++11 is set?), it's just annoying that Eclipse highlights every usage of std::isinf() as an error.
> 

Again, -std=c++11 is not used when compiling WebCore.

If I'm understanding right, the build _does_ work but it's the Eclipse static code analysis that's marking the std::isinf as an error?

Could you try including various headers in the MediaPlayerPrivateGStreamer.cpp file and reporting the outcome regarding the std::isinf being marked as an error? The three headers I'd like you to try are
- <math.h> (what's normally included in WebCore nowadays when stdlib's math functions are required),
- <cmath> (what I hope someday will replace the inclusions from the previous line),
- <wtf/MathExtras.h> (the helper header that also sets up missing math functions for various compiler configurations, also includes <cmath>).

> It sounds like it's probably better to just document how to get Eclipse working with QtWebKit and WebKitGtk instead of changing this?

Hrm, I'd prioritize getting to the source of the problem, though I'm admittedly not affected by it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.