[Webkit-unassigned] [Bug 113965] Add interfaces and stubs for audio and video tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113965


Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198913|review?                     |review+
               Flag|                            |




--- Comment #106 from Jer Noble <jer.noble at apple.com>  2013-04-19 16:08:24 PST ---
(From update of attachment 198913)
View in context: https://bugs.webkit.org/attachment.cgi?id=198913&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:2889
> +void HTMLMediaElement::mediaPlayerDidRemoveAudioTrack(PassRefPtr<AudioTrackPrivate> prpTrack)
> +{
> +    prpTrack->willBeRemoved();
> +}
> +
> +void HTMLMediaElement::mediaPlayerDidRemoveTextTrack(PassRefPtr<InbandTextTrackPrivate> prpTrack)
> +{
> +    prpTrack->willBeRemoved();
> +}
> +
> +void HTMLMediaElement::mediaPlayerDidRemoveVideoTrack(PassRefPtr<VideoTrackPrivate> prpTrack)
> +{
> +    prpTrack->willBeRemoved();
>  }

This looks much better.  It seems like, in theory, MediaPlayerPrivates could remove the middle-man and just call VideoTrackPrivate::willBeRemoved() directly, but there's nothing keeping both approaches from working with this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.