[Webkit-unassigned] [Bug 113284] [EFL] Add method in ewk_settings for setting the CSS media type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113284





--- Comment #23 from Jose Lejin PJ <jose.lejin at gmail.com>  2013-04-19 03:22:41 PST ---
(In reply to comment #22)
> null -> @c NULL
Corrected.

> Are you working for Samsung?
I work for Cisco. Earlier was with Samsung :) I will update this.

> > Source/WebKit/efl/tests/test_ewk_setting.cpp:38
> > +{
> 
> Please check the default value ("screen") of ewk_settings_css_media_type_get().

Please see doc of ewk_settings_css_media_type_get(). (It will only return the value set through ewk_settings_css_media_type_set and not the one used internally. So if nothing is set, it will return null. I have updated documentation of ewk_settings_css_media_type_set now to avoid confusion.)

> > Source/WebKit/efl/tests/test_ewk_setting.cpp:39
> > +    ewk_settings_css_media_type_set("screen");
> 
> Since this is the default value, you should probably set something else than "screen" first, to make sure it works.
ok
> 
> > Source/WebKit/efl/tests/test_ewk_setting.cpp:40
> > +    ASSERT_EQ(strcmp(ewk_settings_css_media_type_get(), "screen"), 0);
> 
> We usually use ASSERT_STREQ() for string comparisons.
> 
> > Source/WebKit/efl/tests/test_ewk_setting.cpp:47
> > +}
> 
> Please check resetting the default value by passing NULL.
ok

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.