[Webkit-unassigned] [Bug 113284] [EFL] Add method in ewk_settings for setting the CSS media type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113284





--- Comment #19 from Jose Lejin PJ <jose.lejin at gmail.com>  2013-04-18 20:55:20 PST ---
(In reply to comment #18)
> (From update of attachment 198699 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198699&action=review
> 
> > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:429
> > +    const char* overrideType = ewk_settings_css_media_type_get();
> 
> or simply return String::fromUTF8(ewk_settings_css_media_type_get());
> 
> Passing 0 to String::fromUTF8() will return String().

Thanks for review. I will use this single return.

> > Source/WebKit/efl/ewk/ewk_settings.h:407
> > + * @return css media type set by user or @c NULL if none is set
> 
> We usually document that the returned string is an eina stringshare. Please use other APIs as reference.

Yes. I saw this now in other APIs. I update documentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.