[Webkit-unassigned] [Bug 114842] [WK2] The nonCompositedContentLayer does not show even if WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to 1.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114842


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198788|review?                     |review-
               Flag|                            |




--- Comment #6 from Benjamin Poulain <benjamin at webkit.org>  2013-04-18 19:42:54 PST ---
(From update of attachment 198788)
View in context: https://bugs.webkit.org/attachment.cgi?id=198788&action=review

> Source/WebKit2/ChangeLog:12
> +        The showDebugBorders() and showRepaintCounter() functions of settings
> +        return false even if WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to 1
> +        when CoordinatedLayerTreeHost is created.
> +        This patch moves the position of functions call after settings is made.

This is a good start. But the first paragraph does not tell why showDebugBorders() and showRepaintCounter() return false at that point.

The second paragraph does not say why setNonCompositedContentsNeedDisplay() is the right place for the settings.
Of all places, setNonCompositedContentsNeedDisplay() is an odd call site for changing a layer configuration.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.