[Webkit-unassigned] [Bug 114826] ThreadCondition::timedWait should use monotonicallyIncreasingTime

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 18 15:07:22 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=114826





--- Comment #1 from Joe Mason <jmason at blackberry.com>  2013-04-18 15:05:40 PST ---
Created an attachment (id=198769)
 --> (https://bugs.webkit.org/attachment.cgi?id=198769&action=review)
wip patch

The attached patch shows the scale of the changes needed. It changes the name of all functions and variables which are still type "double" but now take a monotonic time instead of currenTime, so that the compiler can catch every reference to them and the patch shows every function affected. (Obviously this rename isn't intended to be committed, but we might consider changing monotonicallyIncreasingTime to return a different type than currentTime so that the type of time measurement in each "double" isn't ambiguous.)

The main thing missing from this patch is dealing with errors in the pthread_condattr_t setup (including handling platforms where CLOCK_MONOTONIC isn't available, if there are any.) And I haven't tested this at all, just checked that it compiles. But it can be a starting point for someone else to continue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list