[Webkit-unassigned] [Bug 112327] Reorganize image animation starting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 18 09:50:45 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=112327


Arunprasad <ArunPrasadR at nds.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ArunPrasadR at nds.com




--- Comment #18 from Arunprasad <ArunPrasadR at nds.com>  2013-04-18 09:49:01 PST ---

> Source/WebCore/page/FrameView.cpp:3560
> +    // resume animations after painting

Start comments with caps & end with "."

Follow this for all comments :)

> Source/WebCore/page/FrameView.cpp:4086
> +    RenderObject* stoppedAnimation;

Scope of the stoppedAnimation can be reduced into loop

> Source/WebCore/page/FrameView.cpp:4088
> +    bool intersectsArea;

Hope this variable can be removed, because after assignment it is only used for next conditional statement alone.

> Source/WebCore/page/FrameView.cpp:4105
> +    RenderObject* animationToResume;

Ditto,(Scope can be reduced inside loop)

> Source/WebCore/page/FrameView.cpp:4106
> +    IntRect animationToResumeBoundingBox;

Ditto,(Scope can be reduced inside loop)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list