[Webkit-unassigned] [Bug 106342] [GTK][WK2] accessibility/language-attribute.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106342





--- Comment #5 from Mario Sanchez Prada <mario at webkit.org>  2013-04-18 09:24:42 PST ---
(In reply to comment #4)
> > You are leaking both the returned GSList* and the data in each of its elements here, since atk_text_get_default_attributes() is transfer-full.
> > 
> > So, you should use a GOwnPtr<GSList> for that least, although you would still need to make sure that both the AtkAttribute structs and the gchar* pointers inside them (name, value) are freed before returning from this function.
> 
> Good point. Applied suggestions.

Thanks for considering those. The patch looks good to me now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.