[Webkit-unassigned] [Bug 113965] Add interfaces and stubs for audio and video tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113965





--- Comment #92 from Jer Noble <jer.noble at apple.com>  2013-04-17 21:52:43 PST ---
(In reply to comment #91)
> If I switch to GenerateIsReachable, I get these errors:
> 
> generated/JSAudioTrack.cpp: In member function 'virtual bool WebCore::JSAudioTrackOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown>, void*, JSC::SlotVisitor&)':
> generated/JSAudioTrack.cpp:233:18: error: 'root' is not a member of 'WebCore'
> generated/JSVideoTrack.cpp: In member function 'virtual bool WebCore::JSVideoTrackOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown>, void*, JSC::SlotVisitor&)':
> generated/JSVideoTrack.cpp:233:18: error: 'root' is not a member of 'WebCore'
> 
> Even though root(AudioTrack*) and root(VideoTrack*) are unchanged and still in JS*TrackCustom.h

Ah, yes, the generator won't add a #include "JSAudioTrackCustom.h" directive.  It will add a #include "AudioTrack.h", so you could add the WebCore::root() declaration there, instead.

The relevant code in the generator is in Source/WebCore/bindings/js/CodeGeneratorJS.pm, line ~2648. It shows what the various directive parameters will generate.  One option that might make sense would be to have an element() accessor (in addition to mediaElement()) in TrackBase, and use "GenerateIsReachable(ImplElementRoot)". 

The reason I'm pushing for getting rid of the JS*TrackCustom files is that when improvements are made to the generator, classes with custom directives don't automatically benefit; they need to be improved manually, and they may just get forgotten about.  So it's best not to have custom directives unless strictly necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.