[Webkit-unassigned] [Bug 113284] Add method in ewk_settings for setting the CSS media type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113284





--- Comment #5 from Jose Lejin PJ <jose.lejin at gmail.com>  2013-04-17 20:40:00 PST ---
(In reply to comment #4)
> (From update of attachment 198505 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198505&action=review
> 
> Please read WebKit EFL coding style : http://trac.webkit.org/wiki/EFLWebKitCodingStyle
> 
> > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:429
> > +    if (ewk_settings_css_media_type_get())
> 
> Why should we call this function twice ? Look at the implementation on mac port.
> 
> http://trac.webkit.org/browser/trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm#L1948
> 
> > Source/WebKit/efl/ewk/ewk_settings.cpp:393
> > +void ewk_settings_css_media_type_set(const char *type)
> 
> Wrong * place.
> 
> > Source/WebKit/efl/ewk/ewk_settings.cpp:398
> > +const char* ewk_settings_css_media_type_get(void)
> 
> Do not use *void* in implementation file. We use WebKit coding style except for public header.
> 
> > Source/WebKit/efl/ewk/ewk_settings.h:396
> > + * @param type css media type to be set, must be write-able.
> 
> We have not used . at @param, @return.
> 
> > Source/WebKit/efl/ewk/ewk_settings.h:407
> > + * @return css media type set by user.
> 
> ditto.

Thanks for review Gyuyoung Kim. I will provide updated patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.