[Webkit-unassigned] [Bug 98379] [GTK] accessibility/textarea-selected-text-range.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98379





--- Comment #8 from chris fleizach <cfleizach at apple.com>  2013-04-17 11:19:30 PST ---
(In reply to comment #7)
> (From update of attachment 179091 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179091&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        * platform/gtk/TestExpectations: Removed textare-selected-text-range.html failure expectation.
> 
> missing "a" at the end of text area in
> "textare-selected"
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:510
> > +    // siblings (e.g. multiline text) or text markers (e.g. list item's bullet)
> 
> I would rewrite this as
> 
> "The text content for TextAreas is already flattened so the startOffset is the same as the selectionStart.
> Other elements must handle other sibling nodes and text markers."
> 
> > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:806
> > +    // WebKit atk implementation only supports one selection
> 
> use a period at the end of comments.
> ATK should probably be capitalized
> 
> does anything support more than one selection? maybe the comment is not necessary
> 
> > Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:821
> > +    atk_text_set_selection(ATK_TEXT(m_element), 0, location, location+length);
> 
> space before and after +
otherwise things seem ok

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.