[Webkit-unassigned] [Bug 114742] [texmap] call setContentsNeedsDisplay() if graphics layer has a content layer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114742


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198528|review?                     |review-
               Flag|                            |




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-04-17 09:08:00 PST ---
(From update of attachment 198528)
View in context: https://bugs.webkit.org/attachment.cgi?id=198528&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:1883
> +    if (m_graphicsLayer) {
> +        if (m_graphicsLayer->hasContentsLayer())
> +            m_graphicsLayer->setContentsNeedsDisplay();
> +        else if (m_graphicsLayer->drawsContent())
> +            m_graphicsLayer->setNeedsDisplay();
> +    }

Calling setContentsNeedsDisplay is undesirable on platforms that don't need it. It will cauase the contents layer to get backing store in cases where it shouldn't have it (e.g. background color).

You also need to do a setNeedsDisplay() on the main graphics layer even if you have a contents layer, since the main graphics layer may be painting backgrounds and borders.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.