[Webkit-unassigned] [Bug 114743] BasicShapeFunctions should use RenderStyle instead of StyleResolver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114743


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198510|review?                     |review+
               Flag|                            |




--- Comment #3 from Antti Koivisto <koivisto at iki.fi>  2013-04-17 08:15:20 PST ---
(From update of attachment 198510)
View in context: https://bugs.webkit.org/attachment.cgi?id=198510&action=review

>> Source/WebCore/css/BasicShapeFunctions.h:43
>> +PassRefPtr<BasicShape> basicShapeForValue(RenderStyle* style, RenderStyle* rootElementStyle, const CSSBasicShape*);
> 
> The parameter name "style" adds no information, so it should be removed.  [readability/parameter_name] [5]

These should be const. I would put the main input (the shape) first.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.