[Webkit-unassigned] [Bug 86410] [texmap][GStreamer] Composited Video support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86410





--- Comment #80 from Philippe Normand <pnormand at igalia.com>  2013-04-17 04:20:56 PST ---
(From update of attachment 198493)
View in context: https://bugs.webkit.org/attachment.cgi?id=198493&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:311
> +    const void *srcData;

* misplaced

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:323
> +    // @TODO: support cropping

What's the plan for this? Get the GstCropMeta (or whatever the name is :)) and apply in ::updateContents below?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:381
> +        m_textureMapper = textureMapper; // @TODO Is this a sane enough?

Seems sane to me!

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:385
> +    if (m_texture) {
> +        textureMapper->drawTexture(*m_texture.get(), targetRect, matrix, opacity);
> +    }

No need for curly braces.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:107
> +    virtual void paintToTextureMapper(TextureMapper*, const FloatRect& targetRect, const TransformationMatrix&, float opacity);

targetRect doesn't need to be named.

> Source/WebCore/rendering/RenderLayerBacking.cpp:1785
> +        if (m_graphicsLayer->hasContentsLayer()) {
> +            m_graphicsLayer->setContentsNeedsDisplay();
> +        } else if (m_graphicsLayer->drawsContent()) {
> +            m_graphicsLayer->setNeedsDisplay();
> +        }

Curly braces can be avoided here too, I suppose

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.