[Webkit-unassigned] [Bug 114689] Print file-name, line and function name while calling CRASH()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114689





--- Comment #8 from Benjamin Poulain <benjamin at webkit.org>  2013-04-16 23:20:59 PST ---
(In reply to comment #7)
> Are you worrying about the binary size after? Hope it will be fewer KB(may be 10 to 20K).
> 
> Atleast if we pass __FILE__,__LINE__ to WTFInvokeCrashHook we can install our own WTFCrashHookFunction using WTFSetCrashHook to print the stuffs.

The part I am afraid is leaking private information unintentionally.
Let say I add a file optimizing our pipeline for SGX680MP12 (fictitious SGX). I would have a file GraphicsContextSGX680MP12.cpp. Just by using CRASH() in that file, I would leak the name of unreleased hardware.

I see little value in having the filename in release, because when developing, CRASH() is no different than a programming mistake causing a crash.
On the other side, I see a risk for leaking information and increasing the binary size.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.