[Webkit-unassigned] [Bug 112240] execCommand("RemoveFormat") might remove format after the selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112240


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198354|review?                     |review+
               Flag|                            |




--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org>  2013-04-16 11:55:20 PST ---
(From update of attachment 198354)
View in context: https://bugs.webkit.org/attachment.cgi?id=198354&action=review

> Source/WebCore/editing/ApplyStyleCommand.cpp:1094
>  

We should probably assert that start & end are not in a middle of text node either.
If they were, then we failed to split the text nodes properly.

> Source/WebCore/editing/ApplyStyleCommand.cpp:1109
> +    // The tree may have changed and Position::upstream(), which is used in nodeFullySelected(), relies
> +    // on an up-to-date layout.
> +    node->document()->updateLayoutIgnorePendingStylesheets();

On my second thought, we probably need to call this inside nodeFullySelected.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.